]> git.ipfire.org Git - thirdparty/dovecot/core.git/log
thirdparty/dovecot/core.git
9 years agomaster: Do not close stdout if going foreground
Aki Tuomi [Mon, 18 Jan 2016 13:50:23 +0000 (15:50 +0200)] 
master: Do not close stdout if going foreground

This lets one to use /dev/stdout for logging. Mainly
useful for testing purposes where we can generate
log output to stdout and use tee to write it to a
file for later examination.

9 years agolib-auth: Error message typofix
Timo Sirainen [Thu, 21 Jan 2016 11:59:31 +0000 (13:59 +0200)] 
lib-auth: Error message typofix

9 years agoMakefile: Fixed ChangeLog generation with older git versions that don't support ...
Timo Sirainen [Wed, 20 Jan 2016 17:35:06 +0000 (19:35 +0200)] 
Makefile: Fixed ChangeLog generation with older git versions that don't support --since

Changed the oldest changeset to be the v2.0.0 release commit.

9 years agoimap, pop3, lmtp: Enable MAIL_STORAGE_SERVICE_FLAG_AUTOEXPUNGE
Timo Sirainen [Wed, 20 Jan 2016 11:30:43 +0000 (13:30 +0200)] 
imap, pop3, lmtp: Enable MAIL_STORAGE_SERVICE_FLAG_AUTOEXPUNGE

9 years agolib-storage: Enable autoexpunge only when MAIL_STORAGE_SERVICE_FLAG_AUTOEXPUNGE is...
Timo Sirainen [Wed, 20 Jan 2016 11:30:34 +0000 (13:30 +0200)] 
lib-storage: Enable autoexpunge only when MAIL_STORAGE_SERVICE_FLAG_AUTOEXPUNGE is set.

9 years agolib-storage: Fixed looking up MAILBOX_METADATA_FIRST_SAVE_DATE from mailbox list...
Timo Sirainen [Wed, 20 Jan 2016 11:22:15 +0000 (13:22 +0200)] 
lib-storage: Fixed looking up MAILBOX_METADATA_FIRST_SAVE_DATE from mailbox list index.

If the mailbox was cached as empty, we didn't check if it had since received
new messages. This caused the first-save-date to be returned as nonexistent,
which caused autoexpunging to not always work.

9 years agolib-storage: Fixed updating first-saved-uid to mailbox list index when first mails...
Timo Sirainen [Wed, 20 Jan 2016 11:13:47 +0000 (13:13 +0200)] 
lib-storage: Fixed updating first-saved-uid to mailbox list index when first mails were just expunged.

9 years agolib-storage: Don't set internal error to storage when there's nothing to sync.
Timo Sirainen [Wed, 20 Jan 2016 10:55:57 +0000 (12:55 +0200)] 
lib-storage: Don't set internal error to storage when there's nothing to sync.

This may also wrongly overwrite an existing error.

9 years agoimap-login: If LOGINDISABLED capability is advertised in banner, don't try to LOGIN...
Timo Sirainen [Tue, 19 Jan 2016 21:47:08 +0000 (23:47 +0200)] 
imap-login: If LOGINDISABLED capability is advertised in banner, don't try to LOGIN without SSL/TLS.

This avoids accidentally sending the password in plaintext. Also the server
should fail the LOGIN in any case.

9 years agolib: Don't crash if getenv() is called after process_title_deinit() with Linux/OSX...
Timo Sirainen [Tue, 19 Jan 2016 18:45:27 +0000 (20:45 +0200)] 
lib: Don't crash if getenv() is called after process_title_deinit() with Linux/OSX PROCTITLE_HACK

Right now the only known issue is GNUTLS's lib_deinit():

e = getenv("GNUTLS_NO_EXPLICIT_INIT");

But we likely never want that to be set. Alternative ways to solve this are
more annoying than our clearing the environment. Libraries probably shouldn't
rely on it much anyway, because some parts of Dovecot clear the whole
environment while running.

9 years agoconfig: Improved error messages for wrong order of nested local/remote/protocol ...
Timo Sirainen [Tue, 19 Jan 2016 13:39:13 +0000 (15:39 +0200)] 
config: Improved error messages for wrong order of nested local/remote/protocol { .. } blocks

9 years agoquota-clone: Avoid leaving a dict transaction open for unnecessarily long.
Timo Sirainen [Tue, 19 Jan 2016 13:15:19 +0000 (15:15 +0200)] 
quota-clone: Avoid leaving a dict transaction open for unnecessarily long.

Even though the earlier change should fix the dict assert crash due to
opening multiple transactions when recursing back, this makes sure of it.
It could also be helpful for some dict backends to not keep the transaction
open for unnecessarily long.

9 years agoquota-clone: Fixed update-recursion crash when closing mailbox.
Timo Sirainen [Tue, 19 Jan 2016 13:11:44 +0000 (15:11 +0200)] 
quota-clone: Fixed update-recursion crash when closing mailbox.

We need to avoid recursing for all mailboxes that quota recalculation
might open and close, not just the one that triggered the recalculation.

9 years agopop3c: If authentication fails, log if it was done with USER+PASS or AUTH PLAIN
Timo Sirainen [Tue, 19 Jan 2016 00:30:53 +0000 (02:30 +0200)] 
pop3c: If authentication fails, log if it was done with USER+PASS or AUTH PLAIN

9 years agopop3c: Improve authentication debug log messages a bit.
Timo Sirainen [Tue, 19 Jan 2016 00:26:24 +0000 (02:26 +0200)] 
pop3c: Improve authentication debug log messages a bit.

9 years agoauth: If passdbs are required, don't allow only master=yes passdbs.
Timo Sirainen [Mon, 18 Jan 2016 15:38:22 +0000 (17:38 +0200)] 
auth: If passdbs are required, don't allow only master=yes passdbs.

This fixes a crash:

Panic: file auth-request.c: line 743 (auth_request_is_disabled_master_user):
assertion failed: (request->requested_login_user != NULL)

Which would happen because request->passdb=NULL because there are only
master passdbs. Even if only master passdb is actually needed, there should
still be a non-master passdb for non-master logins to specify what happens
to them.

9 years ago*-login: Typofix for login_plugins error messages.
Timo Sirainen [Mon, 18 Jan 2016 15:08:04 +0000 (17:08 +0200)] 
*-login: Typofix for login_plugins error messages.

9 years agolib-fs: Added default implementations for fs_iter_*(), fs_copy() and fs_stat()
Timo Sirainen [Mon, 18 Jan 2016 12:59:50 +0000 (14:59 +0200)] 
lib-fs: Added default implementations for fs_iter_*(), fs_copy() and fs_stat()

The backends can now leave them as NULL, and the callers will get an error
that they're not supported.

9 years agolib-mail: istream-binary-converter lost last few chars from root-level binary content.
Timo Sirainen [Mon, 18 Jan 2016 12:57:45 +0000 (14:57 +0200)] 
lib-mail: istream-binary-converter lost last few chars from root-level binary content.

9 years agolib-mail: message-parser unit test now verifies that parsed block parts match input.
Timo Sirainen [Mon, 18 Jan 2016 12:56:47 +0000 (14:56 +0200)] 
lib-mail: message-parser unit test now verifies that parsed block parts match input.

9 years agolib-mail: Added message_header_line_write()
Timo Sirainen [Mon, 18 Jan 2016 12:56:24 +0000 (14:56 +0200)] 
lib-mail: Added message_header_line_write()

9 years agoChangeLog: Generate mercurial style changelogs
Aki Tuomi [Fri, 15 Jan 2016 12:11:34 +0000 (14:11 +0200)] 
ChangeLog: Generate mercurial style changelogs

9 years agolib-storage: Ignore ACLs when autoexpunging.
Timo Sirainen [Mon, 18 Jan 2016 11:28:23 +0000 (13:28 +0200)] 
lib-storage: Ignore ACLs when autoexpunging.

9 years agoquota: Fixed namespace filtering for dict and count backends.
Timo Sirainen [Mon, 18 Jan 2016 10:31:26 +0000 (12:31 +0200)] 
quota: Fixed namespace filtering for dict and count backends.

9 years agolib-http: Assign an ID for each HTTP request and log it in debug lines.
Timo Sirainen [Sat, 16 Jan 2016 19:47:53 +0000 (21:47 +0200)] 
lib-http: Assign an ID for each HTTP request and log it in debug lines.

The ID stays the same when request is retried. Added a "Req" prefix so it's
easier to search for the IDs. Based on patch by Stephan Bosch.

9 years agoimapc: Added support for PROXYAUTH command by setting imapc_features = proxyauth
Timo Sirainen [Sat, 16 Jan 2016 19:31:55 +0000 (21:31 +0200)] 
imapc: Added support for PROXYAUTH command by setting imapc_features = proxyauth

This can be useful when talking to Sun/Oracle IMAP server, which wants you
to use LOGIN+PROXYAUTH to perform master user logins, instead of supporting
the standard SASL PLAIN authentication.

9 years agostats: Added missing #include forgotten in 63393b70
Timo Sirainen [Fri, 15 Jan 2016 17:36:46 +0000 (19:36 +0200)] 
stats: Added missing #include forgotten in 63393b70

9 years agodoveadm-stats: Add documentation about stats subcommand
Aki Tuomi [Tue, 12 Jan 2016 07:47:43 +0000 (09:47 +0200)] 
doveadm-stats: Add documentation about stats subcommand

9 years agodoveadm-stats: Add stats reset command line
Aki Tuomi [Mon, 11 Jan 2016 13:46:35 +0000 (15:46 +0200)] 
doveadm-stats: Add stats reset command line

9 years agostats: Add RESET call to stats client
Aki Tuomi [Mon, 11 Jan 2016 13:46:28 +0000 (15:46 +0200)] 
stats: Add RESET call to stats client

9 years agolib-stats: Add stats_reset function
Aki Tuomi [Mon, 11 Jan 2016 13:46:05 +0000 (15:46 +0200)] 
lib-stats: Add stats_reset function

9 years agolib-fts: Add lib-fts to CPPFLAGS as include dir
Aki Tuomi [Thu, 7 Jan 2016 09:09:50 +0000 (11:09 +0200)] 
lib-fts: Add lib-fts to CPPFLAGS as include dir

Without this, VPATH builds fail because the includes cannot be
found as they are not on same directory.

9 years ago*-login: Allow plugins to hook into client allocation and add module-specific context...
Timo Sirainen [Fri, 15 Jan 2016 16:03:11 +0000 (18:03 +0200)] 
*-login: Allow plugins to hook into client allocation and add module-specific contexts to client.

9 years agodovecot-config: Added LIBDOVECOT_{AUTH/POP3/IMAP_LOGIN}_INCLUDE
Timo Sirainen [Fri, 15 Jan 2016 15:17:05 +0000 (17:17 +0200)] 
dovecot-config: Added LIBDOVECOT_{AUTH/POP3/IMAP_LOGIN}_INCLUDE

9 years agoimap-login: Install imap-login-*.h headers so plugins can use them.
Timo Sirainen [Fri, 15 Jan 2016 14:51:15 +0000 (16:51 +0200)] 
imap-login: Install imap-login-*.h headers so plugins can use them.

9 years agoimap-login: Renamed client.[ch] to imap-login-client.[ch]
Timo Sirainen [Fri, 15 Jan 2016 14:49:05 +0000 (16:49 +0200)] 
imap-login: Renamed client.[ch] to imap-login-client.[ch]

This allows installing the imap-login-client.h without conflicting.

9 years agoimap-login: Added API for registering/unregistering commands (for plugins).
Timo Sirainen [Fri, 15 Jan 2016 14:46:34 +0000 (16:46 +0200)] 
imap-login: Added API for registering/unregistering commands (for plugins).

9 years ago*-login: Added login_plugins and login_plugin_dir settings.
Timo Sirainen [Fri, 15 Jan 2016 14:07:32 +0000 (16:07 +0200)] 
*-login: Added login_plugins and login_plugin_dir settings.

9 years agoAdded v2.2.21 to NEWS.
Timo Sirainen [Fri, 15 Jan 2016 14:20:45 +0000 (16:20 +0200)] 
Added v2.2.21 to NEWS.

9 years ago*-login: Changed -D parameter to mean a more generic login_debug option.
Timo Sirainen [Fri, 15 Jan 2016 13:55:26 +0000 (15:55 +0200)] 
*-login: Changed -D parameter to mean a more generic login_debug option.

9 years agoimapc: Added imapc_features = no-examine
Timo Sirainen [Fri, 15 Jan 2016 13:40:56 +0000 (15:40 +0200)] 
imapc: Added imapc_features = no-examine

9 years agodsync: Fixed syncing subscription state with doveadm backup.
Timo Sirainen [Fri, 15 Jan 2016 13:12:30 +0000 (15:12 +0200)] 
dsync: Fixed syncing subscription state with doveadm backup.

If DSYNC_MAILBOX_TREES_SYNC_TYPE_PRESERVE_REMOTE was set, we could still have
preserved the local subscription state. Also cleaned up the code a bit to
make it clearer.

9 years agoimapc: Fixed mailbox name escaping for STATUS
Timo Sirainen [Fri, 15 Jan 2016 13:04:21 +0000 (15:04 +0200)] 
imapc: Fixed mailbox name escaping for STATUS

9 years agoimapc: Fixed mailbox name escaping for CREATE, DELETE, RENAME, SUBSCRIBE, UNSUBSCRIBE
Timo Sirainen [Thu, 14 Jan 2016 16:52:01 +0000 (18:52 +0200)] 
imapc: Fixed mailbox name escaping for CREATE, DELETE, RENAME, SUBSCRIBE, UNSUBSCRIBE

9 years agoimapc: Fixed escaping/unescaping mailbox names.
Timo Sirainen [Thu, 14 Jan 2016 16:50:23 +0000 (18:50 +0200)] 
imapc: Fixed escaping/unescaping mailbox names.

This fixes accessing mailbox names with '%' (the escape_char). It also fixes
local namespace separator being different from the remote separator.

9 years agolib-storage: Added mailbox_list_[un]escape_name_params()
Timo Sirainen [Thu, 14 Jan 2016 16:47:40 +0000 (18:47 +0200)] 
lib-storage: Added mailbox_list_[un]escape_name_params()

This allows calling the mailbox_list_[un]escape_name() with wanted parameters
instead of taking them from mailbox_list.

9 years agoimapc: Don't duplicate standard mailbox flags in LIST replies.
Timo Sirainen [Thu, 14 Jan 2016 14:28:06 +0000 (16:28 +0200)] 
imapc: Don't duplicate standard mailbox flags in LIST replies.

We added the standard \NoSelect, \NonExistent, \NoInferiors and \Subscribed
to special_use string, which caused them to be sent duplicated.

9 years agovirtual plugin: Added support for filtering mailboxes by METADATA entries.
Timo Sirainen [Wed, 13 Jan 2016 12:30:03 +0000 (14:30 +0200)] 
virtual plugin: Added support for filtering mailboxes by METADATA entries.

Usage:

<mailbox patterns as usual>
[-]/<metadata-entry-name>:<value-wildcard>

There can be multiple metadata entries. All the entries must match.

For example:

*
/private/vendor/vendor.dovecot/virtual:*
-/private/vendor/vendor.dovecot/virtual:ignore

This matches all mailboxes, which contain a virtual METADATA entry that has
any value except "ignore".

Note that the current implementation requires still opening all the mailboxes
before matching the METADATA entries. This could be avoided in v2.3 with some
lib-storage API changes.

9 years agolib-imap-storage: imap_metadata_get*() returned 1 also when value wasn't found.
Timo Sirainen [Wed, 13 Jan 2016 12:22:22 +0000 (14:22 +0200)] 
lib-imap-storage: imap_metadata_get*() returned 1 also when value wasn't found.

9 years agovirtual plugin: Cleaned up behavior of '!' prefix with '+' and '-'
Timo Sirainen [Wed, 13 Jan 2016 11:46:33 +0000 (13:46 +0200)] 
virtual plugin: Cleaned up behavior of '!' prefix with '+' and '-'

It makes a bit more sense now. Mainly the difference is that "!foo*" means
to save mails to a mailbox called "foo*", instead of including mailboxes
matching "!foo*" pattern to the virtual mailbox. It's unlikely anyone was
relying on this behavior.

9 years agovirtual plugin: Don't treat "+-box" as a negative entry.
Timo Sirainen [Wed, 13 Jan 2016 11:41:05 +0000 (13:41 +0200)] 
virtual plugin: Don't treat "+-box" as a negative entry.

This was already documented by wiki to work as a mailbox named "-box",
although it didn't actually work that way. There wasn't any practical
difference between "+-box" and "-box", so this change is unlikely to break
anyone's config. It was mainly done as code cleanup.

9 years agovirtual plugin: Minor cleanup/fix - find the namespace after we have processed specia...
Timo Sirainen [Wed, 13 Jan 2016 11:31:54 +0000 (13:31 +0200)] 
virtual plugin: Minor cleanup/fix - find the namespace after we have processed special prefixes.

We already skipped over them earlier, but the logic wasn't exactly the same
as when they were actually being processed, so there could have been some
unexpected mismatches.

9 years agoglobal: freshen copyright
Timo Sirainen [Wed, 13 Jan 2016 10:24:03 +0000 (12:24 +0200)] 
global: freshen copyright

git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

9 years agolib-storage: Fixed autoexpunge=yes to work with namespace's root mailbox.
Timo Sirainen [Wed, 13 Jan 2016 09:22:20 +0000 (11:22 +0200)] 
lib-storage: Fixed autoexpunge=yes to work with namespace's root mailbox.

namespace { mailbox "" { autoexpunge = .. } }

9 years agolib-fts: Create library for development packages.
Teemu Huovila [Wed, 23 Dec 2015 12:45:08 +0000 (14:45 +0200)] 
lib-fts: Create library for development packages.

9 years agolib: i_stream_get_error() now returns "EOF" if stream_errno==0 and eof==TRUE.
Timo Sirainen [Mon, 11 Jan 2016 17:00:07 +0000 (19:00 +0200)] 
lib: i_stream_get_error() now returns "EOF" if stream_errno==0 and eof==TRUE.

This can be used to replace a lot of code like:

input->stream_errno == 0 ? "EOF" : i_stream_get_error(input)

with simply:

i_stream_get_error(input)

9 years agoRemoved now-unused is-tagged.py
Timo Sirainen [Sat, 9 Jan 2016 20:55:15 +0000 (22:55 +0200)] 
Removed now-unused is-tagged.py

9 years agoauth: Don't crash if passwd-file can't be opened
Timo Sirainen [Fri, 8 Jan 2016 16:12:21 +0000 (18:12 +0200)] 
auth: Don't crash if passwd-file can't be opened

9 years agolib-settings: If SET_UINT_OCT has invalid value, we ignored the error and returned...
Timo Sirainen [Fri, 8 Jan 2016 15:04:27 +0000 (17:04 +0200)] 
lib-settings: If SET_UINT_OCT has invalid value, we ignored the error and returned garbage value.

9 years agolib-settings: Fixed parsing '0' value for SET_UINT_OCT.
Timo Sirainen [Fri, 8 Jan 2016 15:02:56 +0000 (17:02 +0200)] 
lib-settings: Fixed parsing '0' value for SET_UINT_OCT.

This was used only by service { *_listener { mode } }

9 years agolib-mail: message-parser was counting body_size wrong for truncated MIME headers...
Timo Sirainen [Fri, 8 Jan 2016 11:24:32 +0000 (13:24 +0200)] 
lib-mail: message-parser was counting body_size wrong for truncated MIME headers after 7d800c55

9 years agolib-storage: mailbox_exists() shouldn't return INBOX as nonexistent if it's not creat...
Timo Sirainen [Thu, 7 Jan 2016 20:14:59 +0000 (22:14 +0200)] 
lib-storage: mailbox_exists() shouldn't return INBOX as nonexistent if it's not created yet.

9 years agoupdate-version.sh: Explicitly specify git directory.
Timo Sirainen [Thu, 7 Jan 2016 20:02:18 +0000 (22:02 +0200)] 
update-version.sh: Explicitly specify git directory.

9 years agopop3: Make sure pop3_lock_session=yes creates the lock's directory if it's missing.
Timo Sirainen [Tue, 5 Jan 2016 16:17:26 +0000 (11:17 -0500)] 
pop3: Make sure pop3_lock_session=yes creates the lock's directory if it's missing.

This happened at least with mbox if the root .imap/ didn't exist yet.

9 years agoauth: Fixed allow_nets=local to work correctly with non-local remote IP
Timo Sirainen [Tue, 5 Jan 2016 16:08:01 +0000 (11:08 -0500)] 
auth: Fixed allow_nets=local to work correctly with non-local remote IP

9 years agoimap: Don't hang at ambiguous commands when they were pipelined already before login
Timo Sirainen [Tue, 5 Jan 2016 16:01:26 +0000 (11:01 -0500)] 
imap: Don't hang at ambiguous commands when they were pipelined already before login

For example if all of these are sent in a single IP packet:

a login user pass
b select inbox
c noop
d unselect

9 years agoimap: Avoid crashing at deinit if mail_user_unref() triggers mail_storage_callbacks
Timo Sirainen [Mon, 4 Jan 2016 19:34:01 +0000 (14:34 -0500)] 
imap: Avoid crashing at deinit if mail_user_unref() triggers mail_storage_callbacks

This could have happened with Maildir/mbox and autoexpunging.

9 years agolib-storage: Fixed autoexpunge for namespaces with non-empty prefix
Timo Sirainen [Mon, 4 Jan 2016 19:23:46 +0000 (14:23 -0500)] 
lib-storage: Fixed autoexpunge for namespaces with non-empty prefix

9 years agoauth: If allow_nets has an invalid value, don't attempt to compare it anymore.
Timo Sirainen [Mon, 4 Jan 2016 19:15:50 +0000 (14:15 -0500)] 
auth: If allow_nets has an invalid value, don't attempt to compare it anymore.

This fixes a potential crash because net_is_in_network() was called with
garbage net_ip.

9 years agolib: Added unit tests for net_is_in_network() about IPv4-mapped IPv6 addresses
Timo Sirainen [Mon, 4 Jan 2016 19:10:44 +0000 (14:10 -0500)] 
lib: Added unit tests for net_is_in_network() about IPv4-mapped IPv6 addresses

9 years agolib: Fixed assert-crash with net_is_in_network(family=ipv6, family=0, ..)
Timo Sirainen [Mon, 4 Jan 2016 19:00:19 +0000 (14:00 -0500)] 
lib: Fixed assert-crash with net_is_in_network(family=ipv6, family=0, ..)

9 years agodict: Avoid a crash when dict connection is already closed when async lookup finishes.
Timo Sirainen [Mon, 4 Jan 2016 18:51:34 +0000 (20:51 +0200)] 
dict: Avoid a crash when dict connection is already closed when async lookup finishes.

9 years agoimap: Make sure pending input is handled when a pending command has input locked.
Timo Sirainen [Mon, 4 Jan 2016 18:12:18 +0000 (13:12 -0500)] 
imap: Make sure pending input is handled when a pending command has input locked.

This hopefully fixes the last assert-crash in client_check_command_hangs()

9 years agoimap: Fixed crash in IDLE if DONE is received while sending large output to client.
Timo Sirainen [Mon, 4 Jan 2016 17:40:39 +0000 (12:40 -0500)] 
imap: Fixed crash in IDLE if DONE is received while sending large output to client.

Fixes assert-crash with backtrace:

9 years agolib-storage: mail_add_temp_wanted_fields() was reading already-freed memory.
Timo Sirainen [Mon, 4 Jan 2016 17:02:12 +0000 (12:02 -0500)] 
lib-storage: mail_add_temp_wanted_fields() was reading already-freed memory.

This mainly happened with mail_log plugin enabled.

9 years agoimap: Don't assert-crash if hibernation resumes IDLE, which sends a lot of data to...
Timo Sirainen [Mon, 4 Jan 2016 16:47:24 +0000 (11:47 -0500)] 
imap: Don't assert-crash if hibernation resumes IDLE, which sends a lot of data to client.

9 years agomysql: Don't require connect setting to have host-parameter if option_file is set.
Timo Sirainen [Thu, 31 Dec 2015 02:26:01 +0000 (04:26 +0200)] 
mysql: Don't require connect setting to have host-parameter if option_file is set.

The option_file could also specify the host.

9 years agolib-mail: message-parser wasn't returning hdr=NULL blocks after 078c2c8c
Timo Sirainen [Wed, 30 Dec 2015 13:21:46 +0000 (08:21 -0500)] 
lib-mail: message-parser wasn't returning hdr=NULL blocks after 078c2c8c

9 years agolib-mail: Small test-message-header-parser unit test update
Timo Sirainen [Wed, 30 Dec 2015 13:21:24 +0000 (08:21 -0500)] 
lib-mail: Small test-message-header-parser unit test update

9 years agodsync: Don't restrict what mailbox names can be created (except basic sanity checks)
Timo Sirainen [Mon, 28 Dec 2015 11:49:29 +0000 (06:49 -0500)] 
dsync: Don't restrict what mailbox names can be created (except basic sanity checks)

The mailbox names already exist on the other side, so we don't want to add
arbitrary limits to them.

9 years agolib-http: Add more timing information to debug logs when HTTP connections get closed.
Timo Sirainen [Wed, 23 Dec 2015 09:48:12 +0000 (11:48 +0200)] 
lib-http: Add more timing information to debug logs when HTTP connections get closed.

9 years agoimap: Make static analyzer happier.
Timo Sirainen [Thu, 17 Dec 2015 03:52:03 +0000 (05:52 +0200)] 
imap: Make static analyzer happier.

9 years agoimap: Fixed potential assert-crash with command pipelining.
Timo Sirainen [Wed, 16 Dec 2015 13:37:26 +0000 (15:37 +0200)] 
imap: Fixed potential assert-crash with command pipelining.

Should fix assert-crash:
Panic: file imap-fetch.c: line 554: assertion failed: (ctx->client->output_cmd_lock == NULL || ctx->client->output_cmd_lock == cmd)

9 years agodoveadm-server: Added -D parameter to enable debugging at startup.
Timo Sirainen [Wed, 16 Dec 2015 13:26:02 +0000 (15:26 +0200)] 
doveadm-server: Added -D parameter to enable debugging at startup.

This mainly makes it show why plugin loads fail.

9 years agodoveadm-server: Fixed loading doveadm plugins that use doveadm_dump_register()
Timo Sirainen [Wed, 16 Dec 2015 13:25:22 +0000 (15:25 +0200)] 
doveadm-server: Fixed loading doveadm plugins that use doveadm_dump_register()

9 years agolib-compress: lz4 istream wasn't detected reliably in some situations.
Timo Sirainen [Wed, 16 Dec 2015 13:06:52 +0000 (15:06 +0200)] 
lib-compress: lz4 istream wasn't detected reliably in some situations.

We requested too few bytes from istream, so there wasn't any guarantee that
the istream actually had all the bytes. This caused a problem for example
with mdbox when the previous mail was already fetched and the stream happened
to end in the middle of the lz4 header.

9 years agoconfigure: Changed version number to v2.2.devel.
Timo Sirainen [Wed, 16 Dec 2015 12:11:04 +0000 (14:11 +0200)] 
configure: Changed version number to v2.2.devel.

The actual version numbers live only on the release-branches from now on.

9 years agoimap: Fixed potential crash when logging about pending commands at logout.
Timo Sirainen [Wed, 16 Dec 2015 09:59:41 +0000 (11:59 +0200)] 
imap: Fixed potential crash when logging about pending commands at logout.

9 years agolib-dict: Improve EACCES error logging for dict-file.
Timo Sirainen [Wed, 16 Dec 2015 09:29:36 +0000 (11:29 +0200)] 
lib-dict: Improve EACCES error logging for dict-file.

9 years agolib-mail: message-parser didn't detect MIME part boundaries in the middle of MIME...
Timo Sirainen [Tue, 15 Dec 2015 15:32:09 +0000 (17:32 +0200)] 
lib-mail: message-parser didn't detect MIME part boundaries in the middle of MIME part headers.

Instead the --boundary line was thought to be part of the header itself.

9 years agolib-mail: message_header_parser_next() updates istream position immediately now.
Timo Sirainen [Tue, 15 Dec 2015 15:29:11 +0000 (17:29 +0200)] 
lib-mail: message_header_parser_next() updates istream position immediately now.

Earlier it updated the position only on the next call or at deinit. This was
because some earlier code kept pointers to the stream data and stored them
to the returned struct message_header_line, but we don't do this anymore.

This allows more easily accessing the same istream for other purposes during
the header parsing.

9 years agolib: Avoid passing NULL to qsort() or bsearch() on empty array.
Timo Sirainen [Mon, 14 Dec 2015 15:42:34 +0000 (17:42 +0200)] 
lib: Avoid passing NULL to qsort() or bsearch() on empty array.

This wouldn't normally matter because count=0 so it wouldn't be dereferenced
anyway. But it triggered a run-time warning from clang, so lets fix it.

9 years agoimapc: Removed commented out code.
Timo Sirainen [Mon, 14 Dec 2015 10:36:23 +0000 (12:36 +0200)] 
imapc: Removed commented out code.

It was probably accidentally committed debug code.

9 years agodoveadm expunge: Using "all" parameter didn't work.
Timo Sirainen [Sun, 13 Dec 2015 19:25:32 +0000 (21:25 +0200)] 
doveadm expunge: Using "all" parameter didn't work.

9 years agostats: Avoid assert-crash with dsync.
Timo Sirainen [Sun, 13 Dec 2015 10:33:20 +0000 (12:33 +0200)] 
stats: Avoid assert-crash with dsync.

dsync creates two mail_users and they're deinited at the same time.
stats_global_user isn't set after the first one is deinited, so the next
deinit crashed because it wasn't set.

Fixes:
Panic: file stats-plugin.c: line 324 (stats_user_deinit): assertion failed:
(stats_global_user == user)

9 years agoconfigure: Minor cleanup - avoid code duplication.
Timo Sirainen [Fri, 11 Dec 2015 15:40:36 +0000 (17:40 +0200)] 
configure: Minor cleanup - avoid code duplication.

9 years agodovecot-config: Fixed setting LIBDOVECOT_LIBFTS[_DEPS]
Timo Sirainen [Fri, 11 Dec 2015 15:39:05 +0000 (17:39 +0200)] 
dovecot-config: Fixed setting LIBDOVECOT_LIBFTS[_DEPS]

9 years agodirector: Don't mark the host desynced if director is alone in ring.
Timo Sirainen [Fri, 11 Dec 2015 14:33:43 +0000 (16:33 +0200)] 
director: Don't mark the host desynced if director is alone in ring.

9 years agodirector: Don't trigger a ring resync if only last_updown_change has changed.
Timo Sirainen [Thu, 10 Dec 2015 12:40:01 +0000 (14:40 +0200)] 
director: Don't trigger a ring resync if only last_updown_change has changed.

9 years agoMakefile: Make ChangeLog depend on .git/index instead of .git/ORIG_HEAD
Timo Sirainen [Thu, 10 Dec 2015 09:14:26 +0000 (11:14 +0200)] 
Makefile: Make ChangeLog depend on .git/index instead of .git/ORIG_HEAD
ORIG_HEAD doesn't necessarily exist, so maybe index is good for this.