]>
git.ipfire.org Git - thirdparty/dovecot/core.git/log
Timo Sirainen [Tue, 21 Jun 2016 09:04:24 +0000 (12:04 +0300)]
lib-dict: Explicitly specify used dict_vfuncs methods for drivers.
This allows adding more methods without modifying all the existing drivers.
Baofeng Wang [Wed, 8 Jun 2016 13:41:04 +0000 (16:41 +0300)]
lib-fts: add unit test to fts_tokenizer_delete_trailing_partial_char()
Baofeng Wang [Tue, 7 Jun 2016 13:37:27 +0000 (16:37 +0300)]
lib-fts: allow hyphen character in domain part
Allow hyphen character and remove possible trailing hyhpen character
when email tokenization is done.
Baofeng Wang [Tue, 7 Jun 2016 12:58:38 +0000 (15:58 +0300)]
lib-fts: remove trailing period character from email-address
any trailing period character '.' should be removed when email
tokenization is done.
Baofeng Wang [Tue, 7 Jun 2016 13:01:03 +0000 (16:01 +0300)]
lib-test: add test_assert_failed_strcmp to expose strings.
the macro is used to facilitate any test to show string comparision
contents when they doesn't match.
Timo Sirainen [Mon, 20 Jun 2016 18:38:56 +0000 (21:38 +0300)]
Makefile: Added run-test-valgrind.supp to EXTRA_DIST
Timo Sirainen [Mon, 20 Jun 2016 15:46:04 +0000 (18:46 +0300)]
Updated run-test-valgrind.supp
Timo Sirainen [Mon, 20 Jun 2016 14:52:28 +0000 (17:52 +0300)]
lib: file_create_locked() - Unexpectedly deleted temp file is error.
This shouldn't happen and we shouldn't be silently retrying if it does.
Timo Sirainen [Mon, 20 Jun 2016 11:29:57 +0000 (14:29 +0300)]
Added valgrind suppression for OpenSSL <v1.0.2
This one works at least for CentOS 6. Because the OpenSSL library is
loaded as a plugin and unloaded before exit, valgrind sees only "???"
as the addresses. That's why we're using "obj:*". But the number of
obj:* lines is also important, so this may not work everywhere.
Timo Sirainen [Mon, 20 Jun 2016 10:37:13 +0000 (13:37 +0300)]
openssl: Use our own malloc()/realloc() that will die on out-of-memory.
This is likely safer rather than caller thinking for example that some input
is invalid when it's only a temporary memory allocation problem.
Timo Sirainen [Mon, 20 Jun 2016 10:33:34 +0000 (13:33 +0300)]
lib-dcrypt: Allow specifying crypto_device (OpenSSL engine).
Timo Sirainen [Mon, 20 Jun 2016 10:33:05 +0000 (13:33 +0300)]
lib-dcrypt: Added library dependencies to unit tests
Timo Sirainen [Mon, 20 Jun 2016 09:58:08 +0000 (12:58 +0300)]
lib-dcrypt, lib-ssl-iostream: Share OpenSSL init/deinit code.
Timo Sirainen [Mon, 20 Jun 2016 10:05:37 +0000 (13:05 +0300)]
lib-dcrypt: Fix to backend module loading.
Especially don't die if we fail to load the module.
Stephan Bosch [Sun, 19 Jun 2016 19:31:10 +0000 (21:31 +0200)]
lib-http: server: Created test program that tests error conditions.
Currently it is very limited, but it is due to be extended soon towards testing most common error conditions.
Stephan Bosch [Mon, 20 Jun 2016 00:41:37 +0000 (02:41 +0200)]
lib-http: Restructured Makefile.am to have less duplicated lines for the test suite.
Stephan Bosch [Sun, 19 Jun 2016 23:25:02 +0000 (01:25 +0200)]
lib-http: server: Added settings to configure the connection's socket kernel buffer sizes.
This is mainly useful for use in the lib-http test suite.
Stephan Bosch [Sun, 19 Jun 2016 23:20:33 +0000 (01:20 +0200)]
lib-http: server: Make sure provided connection FDs are non-blocking.
Stephan Bosch [Sun, 19 Jun 2016 23:15:18 +0000 (01:15 +0200)]
lib-http: server: Wrap request payload in a timeout input stream.
The server cannot reset the timeout properly while the payload is being read by the application.
The HTTP client solved this same problem by identical means.
Stephan Bosch [Sun, 19 Jun 2016 20:31:18 +0000 (22:31 +0200)]
lib-http: server: Fixed handling of idle timeout when request just starts processing on the server.
Stephan Bosch [Sun, 19 Jun 2016 20:35:43 +0000 (22:35 +0200)]
lib-http: server: Added more detailed debugging about when idle timeouts are started/stopped.
Stephan Bosch [Fri, 17 Jun 2016 14:59:37 +0000 (16:59 +0200)]
lib-http: client: Added tests for manual handling of connection loss retries to test-http-client-errors.
Stephan Bosch [Fri, 17 Jun 2016 14:59:15 +0000 (16:59 +0200)]
lib-http: client: Implemented no_auto_retry setting that disables all automatic request retries.
This currently only applies to requests sent over a connection that is subsequently lost before a response is received.
Before, such requests were always implicitly resumbitted for a new connection, without the application knowing about it.
By enabling the no_auto_retry client setting, the application is always notified of connection loss through the request's response callback.
As a consequence, requests need to be retried explicitly using the http_client_request_try_retry().
Stephan Bosch [Fri, 17 Jun 2016 13:39:36 +0000 (15:39 +0200)]
lib-http: client: Allow retrying requests that failed internally.
Stephan Bosch [Tue, 14 Jun 2016 20:47:31 +0000 (22:47 +0200)]
lib-http: client: Added test for http_client_request_delay_msecs() in test_http_client_errors.
Timo Sirainen [Thu, 26 May 2016 15:27:27 +0000 (18:27 +0300)]
lib-http: Improved error logging for net_set_*_buffer_size() failures.
Stephan Bosch [Sun, 22 May 2016 08:38:18 +0000 (10:38 +0200)]
lib-http: client: Created test program that triggers most possible error conditions.
Stephan Bosch [Tue, 24 May 2016 01:11:07 +0000 (03:11 +0200)]
lib-http: test-http-payload: Added tests for the use of nested ioloops.
Stephan Bosch [Mon, 23 May 2016 19:57:18 +0000 (21:57 +0200)]
lib-http: test-http-payload: Added cleanup code to make sure no child processes get orphaned at failures.
Also handles SIGSEGV and SIGABRT.
Stephan Bosch [Sun, 22 May 2016 17:16:42 +0000 (19:16 +0200)]
lib-http: test-http-payload: Added -D option to easily enable debug mode.
Stephan Bosch [Mon, 23 May 2016 01:16:07 +0000 (03:16 +0200)]
lib-http: test-http-client: Callback is not called for explicitly aborted requests.
Test request context was not freed in that case.
Stephan Bosch [Wed, 25 May 2016 21:41:47 +0000 (23:41 +0200)]
lib-http: client: Fixed bug in handling of lost connections while returning from another ioloop.
At one instance the http_client_connection_is_ready() function could have destroyed the connection while the caller still depended on it.
Renamed the http_client_connection_is_ready() function to http_client_connection_check_ready().
This now returns -1 when the connection got destroyed. Before it returned a bool that just indicated whether the connection was ready or not.
So, there is no need anymore to preserve a connection reference while calling this function.
Stephan Bosch [Mon, 23 May 2016 00:38:49 +0000 (02:38 +0200)]
lib-http: client: Reworked connection close handling.
Now, the peer is immediately notified of the lost connection.
Before, this step was only taken when the connection was fully dereferenced.
To prevent recursive notifications between peer and connection, handling the loss of a connection is deferred to the request handler.
When a peer is freed, any associated lingering connections have conn->peer set to NULL.
Stephan Bosch [Sun, 22 May 2016 10:48:37 +0000 (12:48 +0200)]
lib-http: client: Prevent useless and unexpected request callbacks during http_client_deinit().
Requests are now destroyed before queues, hosts, peers and connections.
As a side-effect, requests are now removed from the client request list at http_client_request_destroy(), so that requests with lingering references will no longer make http_client_wait() hang.
Stephan Bosch [Thu, 19 May 2016 22:04:12 +0000 (00:04 +0200)]
lib-http: client: Added settings to configure the connection's socket kernel buffer sizes.
This is mainly useful for use in the lib-http test suite.
Stephan Bosch [Thu, 19 May 2016 22:02:49 +0000 (00:02 +0200)]
lib: Implemented net_set_send_buffer_size() and net_set_recv_buffer_size().
These functions allow manipulating the kernel socket buffer sizes for a socket file descriptor.
Stephan Bosch [Thu, 19 May 2016 21:42:14 +0000 (23:42 +0200)]
lib-http: client: Removed curiously duplicated code.
Probably a patch got applied with sufficient fuzz that it duplicated this code fragment, while it actually already existed.
Stephan Bosch [Sat, 21 May 2016 11:17:58 +0000 (13:17 +0200)]
lib-http: client: peer: Improved debug message that shows the loss of a connection.
Stephan Bosch [Fri, 20 May 2016 22:16:21 +0000 (00:16 +0200)]
lib-http: client: Made peer object reference-counted to prevent invalid memory access in request handling routine.
Resetting the peer->handling_requests flag risked triggering a segfault, since the peer object could be deleted from within the request handler loop.
Stephan Bosch [Sat, 21 May 2016 11:16:08 +0000 (13:16 +0200)]
lib-http: client: Improved request reference counting in connection code.
It should now always be clear when the connection object holds a reference to a request and when it is released.
Only while the reference is held, req->conn points to a connection.
This also makes the assertion in http_client_request_unref() more robust and clear.
Stephan Bosch [Sun, 22 May 2016 08:42:01 +0000 (10:42 +0200)]
lib-http: client: Fixed reference counting for requests that are aborted due to an early server response.
An additional http_client_request_unref() is (now) unneccessary.
Stephan Bosch [Thu, 19 May 2016 21:40:26 +0000 (23:40 +0200)]
lib-http: client: Fixed reference counting for requests that are aborted due to having a broken outgoing payload stream.
Timo Sirainen [Wed, 18 May 2016 16:40:32 +0000 (19:40 +0300)]
lib-http: Changed http_client_request_error to set request to NULL
It's going to internally unreference it, so the caller should be aware of it
also.
I also changed request state check to be an assert, since I don't think
there's any safe way this could work otherwise.
Stephan Bosch [Fri, 20 May 2016 22:16:38 +0000 (00:16 +0200)]
lib-http: response parser: Added check for the range of the response status value.
A value of 666 was accepted inappropriately.
Timo Sirainen [Mon, 20 Jun 2016 00:07:58 +0000 (03:07 +0300)]
lib-dict-extra: Compiler warning fix
Timo Sirainen [Mon, 13 Jun 2016 14:10:22 +0000 (17:10 +0300)]
lib-dict: Added dict_switch_ioloop()
Timo Sirainen [Wed, 1 Jun 2016 21:57:17 +0000 (00:57 +0300)]
lib-dict: dict-client rewrite to support async operations
Timo Sirainen [Fri, 6 May 2016 14:24:42 +0000 (17:24 +0300)]
lib: Added t_str_tabunescape()
Timo Sirainen [Sun, 19 Jun 2016 23:25:47 +0000 (02:25 +0300)]
lib-dcrypt: Use a more supported EC curve in unit test
Fixes running the test on CentOS 6.
Timo Sirainen [Sun, 19 Jun 2016 22:47:59 +0000 (01:47 +0300)]
lib-index: Don't break indexes on syscall failures during index refreshing.
Especially mmap() failures due to out of memory could have triggered this.
We treated the open as successful, which meant that an empty index was
opened.
Timo Sirainen [Sun, 19 Jun 2016 20:18:43 +0000 (23:18 +0300)]
lib-dcrypt: Fixed running unit tests in build directory.
Timo Sirainen [Sun, 19 Jun 2016 17:23:27 +0000 (20:23 +0300)]
mailbox-alias: Fixed renaming mailboxes when the plugin is loaded.
Timo Sirainen [Sun, 19 Jun 2016 15:44:55 +0000 (18:44 +0300)]
lib-dcrypt: Fixed memory leak in test-crypto unit test
Timo Sirainen [Sun, 19 Jun 2016 15:38:39 +0000 (18:38 +0300)]
doveadm dump: Updated obox's oid output.
Stephan Bosch [Tue, 14 Jun 2016 23:54:25 +0000 (01:54 +0200)]
lib-http: client: Added more debug logging about the submission of delayed requests.
Stephan Bosch [Tue, 14 Jun 2016 23:53:44 +0000 (01:53 +0200)]
time-util: Fixed usec comparison in timeval_cmp_margin().
Teemu Huovila [Tue, 14 Jun 2016 19:42:09 +0000 (22:42 +0300)]
lib-dcrypt: Fix error_r pointer verification.
Timo Sirainen [Tue, 14 Jun 2016 19:32:36 +0000 (22:32 +0300)]
lib-fs: Added write_bytes to statistics
Martti Rannanjärvi [Tue, 10 May 2016 07:19:57 +0000 (10:19 +0300)]
[LEN] to [static LEN] on some function parameters
Also add STATIC_ARRAY macro to hide it in c++ compilation.
Aki Tuomi [Tue, 14 Jun 2016 09:30:27 +0000 (12:30 +0300)]
dcrypt: Arm deinitialization code
Aki Tuomi [Tue, 14 Jun 2016 09:08:49 +0000 (12:08 +0300)]
dcrypt: Add test for public key loading
Aki Tuomi [Tue, 14 Jun 2016 09:08:34 +0000 (12:08 +0300)]
dcrypt-openssl: Pass pointer safely
Timo Sirainen [Tue, 14 Jun 2016 07:49:24 +0000 (10:49 +0300)]
lib-index: Fixed test-mail-index-sync-ext
Timo Sirainen [Mon, 13 Jun 2016 22:14:13 +0000 (01:14 +0300)]
lib-index: Fixes to handling resized records.
Timo Sirainen [Mon, 13 Jun 2016 17:16:14 +0000 (20:16 +0300)]
dict: Increased max number of pipelined requests from 5 to 1000.
The client is supposed to be the one throttling the requests. We mainly
want to avoid accidental abuses. Using 1000 is hopefully "large enough"
without being "too large".
Timo Sirainen [Mon, 13 Jun 2016 14:59:01 +0000 (17:59 +0300)]
dict: Avoid potentially using 100% CPU
Continuing
65c570f18 fix.
Timo Sirainen [Mon, 13 Jun 2016 14:11:28 +0000 (17:11 +0300)]
lib-fs: Added fs_switch_ioloop()
Timo Sirainen [Mon, 13 Jun 2016 14:31:34 +0000 (17:31 +0300)]
lib-fs: Code cleanup for fs-sis: Use struct fs.parent
Aki Tuomi [Mon, 13 Jun 2016 09:49:19 +0000 (12:49 +0300)]
lib-dcrypt: Use hex encoded public key ID in callback
Timo Sirainen [Tue, 7 Jun 2016 00:47:44 +0000 (03:47 +0300)]
Fixed linking with OSX.
Aki Tuomi [Mon, 13 Jun 2016 09:44:09 +0000 (12:44 +0300)]
lib-dcrypt: Use dcrypt_key_id_private when applicable
Aki Tuomi [Wed, 11 May 2016 05:02:29 +0000 (08:02 +0300)]
ldap: Fix cyclic dependency
Timo Sirainen [Mon, 13 Jun 2016 09:18:07 +0000 (12:18 +0300)]
dovecot-config: Add lib-dcrypt to LIBDOVECOT_INCLUDE
Since lib-dcrypt is part of libdovecot.
Martti Rannanjärvi [Thu, 19 May 2016 08:14:46 +0000 (11:14 +0300)]
master: make setting listen empty an error
Timo Sirainen [Sun, 12 Jun 2016 17:11:49 +0000 (20:11 +0300)]
lib-index: mail_index_ext_resize() was broken when record_size wasn't changed.
Aki Tuomi [Sun, 12 Jun 2016 15:57:10 +0000 (18:57 +0300)]
lib-dcrypt: Fix various problems
Timo Sirainen [Sat, 11 Jun 2016 18:23:57 +0000 (21:23 +0300)]
lib-mail: Improved message-parser unit tests.
Timo Sirainen [Sat, 11 Jun 2016 18:23:07 +0000 (21:23 +0300)]
lib-mail: Fixed message_parser_init_from_parts() with truncated MIME headers
Timo Sirainen [Sat, 11 Jun 2016 18:20:37 +0000 (21:20 +0300)]
lib-mail: message-header-parser now keeps istream referenced.
Timo Sirainen [Sat, 11 Jun 2016 17:50:39 +0000 (20:50 +0300)]
lib-storage: mail_set_cache_corrupted*() now sets internal error to storage.
At least index_mail_set_message_parts_corrupted() assumed that this was
being done.
Timo Sirainen [Sat, 11 Jun 2016 14:13:12 +0000 (17:13 +0300)]
cassandra: Try fallback_consistency also for write timeout failures.
Aki Tuomi [Tue, 7 Jun 2016 05:50:12 +0000 (08:50 +0300)]
doveadm-server: Disable idle timeout for now
Timo Sirainen [Tue, 7 Jun 2016 00:25:16 +0000 (03:25 +0300)]
lib-dcrypt: Fixed library dependencies
_DEPENDENCIES needs an explicit paths, not "-lssl" and such. Fixes building
with e.g. OSX.
Timo Sirainen [Tue, 7 Jun 2016 00:04:32 +0000 (03:04 +0300)]
lib-lda: Don't assert-crash if home directory isn't set.
Timo Sirainen [Sun, 5 Jun 2016 13:01:05 +0000 (16:01 +0300)]
mbox: Code cleanup - use bool instead of int for tracking locked-status
Timo Sirainen [Mon, 2 May 2016 15:27:02 +0000 (18:27 +0300)]
quota: Differentiate between forced and non-forced quota recalc
The "count" backend doesn't need to recalc quota unless an explicit "doveadm
quota recalc" command is called.
Timo Sirainen [Mon, 2 May 2016 15:16:00 +0000 (18:16 +0300)]
quota: Skip reading mail sizes when quota backend doesn't need it.
If quota backend is updating the quota internally, it's just going to ignore
the looked up size. The only reason for looking up the sizes is to check
with quota_try_alloc() whether user is going over quota.
Timo Sirainen [Sun, 5 Jun 2016 23:27:35 +0000 (02:27 +0300)]
fs-randomfail: Support failures after asynchronous commands have already finished.
Timo Sirainen [Sun, 5 Jun 2016 23:26:09 +0000 (02:26 +0300)]
dict: Fixed hang when pipelining multiple commands.
Timo Sirainen [Sun, 5 Jun 2016 21:07:53 +0000 (00:07 +0300)]
lib-index: Extension record size resizing was still broken.
Fixes assert-crash:
Panic: file mail-index-util.c: line 143 (mail_index_seq_array_add): assertion failed: (array->arr.element_size == sizeof(seq) + aligned_record_size)
Timo Sirainen [Sun, 5 Jun 2016 13:51:12 +0000 (16:51 +0300)]
lib-mail: Added comment about invalid timezones in message_date_parse()
Timo Sirainen [Sun, 5 Jun 2016 13:40:27 +0000 (16:40 +0300)]
director: Fixed error handling when directors support incompatible tags
Connection should have been disconnected immediately, not after the next
command that would have produced "Incompatible protocol".
Timo Sirainen [Sun, 5 Jun 2016 12:57:48 +0000 (15:57 +0300)]
lib-dcrypt: Fixed error handling in dcrypt_key_id_public()
Timo Sirainen [Sun, 5 Jun 2016 12:35:13 +0000 (15:35 +0300)]
lib-storage: Fixed error handling in list=children checking
Timo Sirainen [Sun, 5 Jun 2016 12:32:09 +0000 (15:32 +0300)]
fts-lucene: Fixed error handling when checking if settings had changed.
Timo Sirainen [Sun, 5 Jun 2016 12:31:20 +0000 (15:31 +0300)]
mailbox-alias plugin: Fixed error handling
Timo Sirainen [Sun, 5 Jun 2016 12:26:11 +0000 (15:26 +0300)]
lib-storage: Search args equalness checks didn't compare keywords correctly.
This may have broken the search in some situations.
Timo Sirainen [Sun, 5 Jun 2016 12:23:45 +0000 (15:23 +0300)]
mbox: Fixed expunging first mail with CRLF linefeeds.
Timo Sirainen [Sun, 5 Jun 2016 12:18:04 +0000 (15:18 +0300)]
mdbox: Fix want_altpath flags/boolean mixup
There was only a single flag, so this wasn't actually currently broken.
Timo Sirainen [Sun, 5 Jun 2016 12:11:56 +0000 (15:11 +0300)]
auth: Fixed error handling in passdb/userdb dict config parsing