Andrew Tridgell [Fri, 7 Sep 2001 14:14:57 +0000 (14:14 +0000)]
added "display charset" option in smb.conf, along with d_printf()
which should now be used instead of DEBUG(0) or printf() for
interactive messages
I have only converted client.c to use d_printf(), and the code hasn't
had much testing yet. Eventually we want all interactive code to use
d_printf(), plus SWAT
(This used to be commit 266d8e67669adb329f25676c4bc4d4c50f223428)
Jeremy Allison [Thu, 6 Sep 2001 22:43:21 +0000 (22:43 +0000)]
Fix the 62bit locking onto 32 bit NFS mounts problem generically for HPUX.
Don. please check this out.
Jeremy.
(This used to be commit ce9f95996498f7795aaef069e1443ea1c7d524b3)
Jeremy Allison [Thu, 6 Sep 2001 15:48:29 +0000 (15:48 +0000)]
Fixed O(N^2) talloc loop when allocating printer name memory - fix from
Richard Bollinger <rabollinger@home.com>.
Jeremy.
(This used to be commit 408c0595bbeafca87795e5278656471fbe0540e8)
Tim Potter [Thu, 6 Sep 2001 09:10:26 +0000 (09:10 +0000)]
Started a cleanup of smbpasswd related stuff. I've created a new file
lib/smbpasswd.c which will contain routines related to manipulating
smbpasswd entries.
- renamed and moved pdb_{get,set}hexpwd() functions
- renamed and moved pdb_{decode,encode}acct_ctrl() functions
- started hiding references to the cruftalicious
NEW_PW_FORMAT_SPACE_PADDED_LEN constant
- started gradual rename of references to acct_ctrl to acb_info which is
the nomenclature used in MSDN and header files
There's still more work to be done. Currently there are several places
where smbpasswd entries are iterated etc. Ideally this should all happen
through the passdb system.
(This used to be commit 4a01e240305fb6fead973beef4937a016b15d744)
Andrew Tridgell [Thu, 6 Sep 2001 01:22:17 +0000 (01:22 +0000)]
enable strict locking by default. This will be slow, so now we just
need to fiind a way to make it fast
(This used to be commit 42b147d1f26093c45110077a309c5e0d3010a28d)
Andrew Tridgell [Thu, 6 Sep 2001 01:21:09 +0000 (01:21 +0000)]
it turns out that XP agrees with the samba head branch over the right
error codes for locking, so fix the test rather than fixing samba
(This used to be commit a583af3c2f5d1962495a0f18b671e34d6ff43511)
Jeremy Allison [Wed, 5 Sep 2001 22:45:48 +0000 (22:45 +0000)]
Fix I think for the fcntl spinning problem. Re-prioritize so
that oplock break messages get priority over incoming client messages.
Jeremy.
(This used to be commit 1779f6a223dad87c3b8451d09b9808b46495a8b6)
Andrew Tridgell [Wed, 5 Sep 2001 21:39:43 +0000 (21:39 +0000)]
2nd DELETE_ON_CLOSE_FLAG fix ...
we set the DELETE_ON_CLOSE_FLAG on all share modes on the file, which
means the share mode in the fsp will not match the one in the tdb when
we come to close for other file handles, which means we end up with
share modes on files after all handles are closed
fixed by making the comparison function that says if two shares modes
are equal ignore the DELETE_ON_CLOSE_FLAG
(This used to be commit 7b39c4c59897669106d7129bad8af3d592d25838)
Andrew Tridgell [Wed, 5 Sep 2001 21:13:58 +0000 (21:13 +0000)]
when you update the share mode in the db you must also update
fsp->share_mode otherwise the check to see if the fsp share mode
matches the one in the db will fail when you come to delete it,
thus leaving us with a share mode on a file that isn't even open!
(This used to be commit 2020738b889d8d508cf787e5c5d380af817b92f9)
Andrew Tridgell [Wed, 5 Sep 2001 21:11:52 +0000 (21:11 +0000)]
fixed formatting to make the code vaguely readable. It's still a dogs
breakfast, but at least you can follow the indents
(This used to be commit 9955ea0aaa299c6c946b4e7b7e98017c39b60bc8)
Herb Lewis [Wed, 5 Sep 2001 18:01:48 +0000 (18:01 +0000)]
always include profile support so you do not need a different binary of
smbstatus to dump profile stats.
(This used to be commit fc048955b8af05779992bc111f9bd690b8a8faf2)
Andrew Tridgell [Wed, 5 Sep 2001 11:32:59 +0000 (11:32 +0000)]
use cli_is_error() instead of looking in smb_rcls, otherwise NT status
codes don't work correctly
(This used to be commit 55d5828e608671f070a9e96938be0d16d50aeb26)
Andrew Tridgell [Wed, 5 Sep 2001 08:54:04 +0000 (08:54 +0000)]
fixed some compilation errors in cli_netlogon.c - tim, you need to rerun configure to get the new NTSTATUS stuff right
(This used to be commit 9bae57cfe30825174536d11983bb3434498e3f03)
Andrew Tridgell [Wed, 5 Sep 2001 07:55:54 +0000 (07:55 +0000)]
fixed a bunch of compilation errors on Solaris, mostly people getting NSS_STATUS and WINBINDD error codes mixed up
(This used to be commit 66698d6b841df809a8654012a8385bffacb9dc4a)
Tim Potter [Wed, 5 Sep 2001 04:46:21 +0000 (04:46 +0000)]
Merged cli_net_req_chal() and cli_net_auth2() from rpc_client/cli_login.c
except they are called new_cli_net_req_chal() and new_cli_net_auth2()
until they are working properly.
(This used to be commit 4ca085f253fc39de60115edc049e91d5c95735ef)
Jeremy Allison [Wed, 5 Sep 2001 00:05:07 +0000 (00:05 +0000)]
NFS v2 can return ENOLCK when greater than 31 bit offsets are used.
Treat this the same as an EFBIG error.
Jeremy
(This used to be commit 8fad5177701c1738a7f5bdd7c0082ef23a00b876)
Jeremy Allison [Tue, 4 Sep 2001 19:58:01 +0000 (19:58 +0000)]
Fixes to ensure invalid vuids cannot stop oplock breaks.
This may have bearing on the Solaris fcntl spin bug.
Jeremy.
(This used to be commit 0f676202529cbfead629d2c228b7d5abc2dff7d6)
Andrew Tridgell [Tue, 4 Sep 2001 07:13:01 +0000 (07:13 +0000)]
the next stage in the NTSTATUS/WERROR change. smbd and nmbd now compile, but the client code still needs some work
(This used to be commit dcd6e735f709a9231860ceb9682db40ff26c9a66)
Tim Potter [Fri, 31 Aug 2001 05:48:37 +0000 (05:48 +0000)]
Set acb_info to ACB_SVRTRUST if we are joining the domain as a BDC without
going through the server manager.
(This used to be commit 52f5abae4667d841be7ca8f5ff0f25ba6d027067)
Simo Sorce [Fri, 31 Aug 2001 01:29:53 +0000 (01:29 +0000)]
changed the data format in the tdb, as the time fields were not
managed correctly.
this mean you need to rebuild your passdb.tdb file.
(This used to be commit 57b8d3bb84e261e55febdde88e45684455f0a294)
Herb Lewis [Thu, 30 Aug 2001 18:56:35 +0000 (18:56 +0000)]
if no ACL elements then use chmod - fixes ability to set read-only bit
on files that do not have an ACL
(This used to be commit 65ea13420c78cf0a8c01f14c08815e4b44ca4abc)
This isn't the final version, of course, I still need to get WINS failover
working. This is just patched so it won't need lp_wins_server() (which I
renamed to lp_wins_server_list()).
I can't compile just now as something else is broken in HEAD. Let me know
if this version of namequery.c causes trouble down the line. Shouldn't,
as the changes are very small, but I've been known to rock the boat
before.
This should make it clear that the meaning of the parameter value has
changed. It no longer represents *the* WINS server, but a list of WINS
servers.
I have made other changes in the code such that the lp_wins_server()
function is no longer necessary. Whenever smb.conf is reloaded the list
managed by lib/wins_srv.c is refreshed. The wins_srv_count() function
returns the number of entries in the list so, if the list is empty, it
will return 0 (which can be interpreted as "false" in an if() statement).
Tim Potter [Tue, 28 Aug 2001 06:44:54 +0000 (06:44 +0000)]
Start of samsync program invoked by smbd to perform sam synchronisation and
sam replication. It doesn't work yet. (-:
(This used to be commit c96aae613dfe97808dedffc836c5d4cc9ae52185)
Tim Potter [Tue, 28 Aug 2001 06:43:43 +0000 (06:43 +0000)]
Merge of sam sync code from TNG.
Reverse-engineered the sam replication protocol from staring at hex dumps
for a while. It's pretty similar to the sam sync protocol with a couple of
different delta header types.
I wasn't able to figure out the format of the privilege stuff - needs more
time and a whiteboard. (-:
The impressive bit is that the sam sync stuff from tng basically just
worked thanks mainly to Luke Leighton's efforts in this area.
(This used to be commit 3a60cb44f22d5f3f8c78a56ed8f5ea4794cd7ab3)
Andrew Tridgell [Mon, 27 Aug 2001 17:52:23 +0000 (17:52 +0000)]
started converting NTSTATUS to be a structure on systems with gcc in order to make it type incompatible with BOOL so we catch errors sooner. This has already found a number of bugs
(This used to be commit 1b778bc7d22efff3f90dc450eb12baa1241cf68f)
Andrew Tridgell [Mon, 27 Aug 2001 08:19:43 +0000 (08:19 +0000)]
converted smbd to use NTSTATUS by default
major changes include:
- added NSTATUS type
- added automatic mapping between dos and nt error codes
- changed all ERROR() calls to ERROR_DOS() and many to ERROR_NT()
these calls auto-translate to the client error code system
- got rid of the cached error code and the writebmpx code
We eventually will need to also:
- get rid of BOOL, so we don't lose error info
- replace all ERROR_DOS() calls with ERROR_NT() calls
Andrew Bartlett [Mon, 27 Aug 2001 03:56:09 +0000 (03:56 +0000)]
As per plug-fest discussions this paramater no longer defaults to the value
of add user script.
(This used to be commit 9e0c9a99f6ca01cd6a0ee3084f85e1c36b11d7c3)