]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
17 months agoCoverity 1598300 is a false positive. The array IS terminated correctly
Arran Cudbard-Bell [Mon, 20 May 2024 15:59:32 +0000 (11:59 -0400)] 
Coverity 1598300 is a false positive.  The array IS terminated correctly

We should likely just default to not allowing any arguments unless they're explicitly set.

This commit doesn't fix anything, it just removes the call to "xlat_func_mono_set" which we should be moving away from.

17 months agoStupid const
Arran Cudbard-Bell [Sun, 19 May 2024 17:22:57 +0000 (11:22 -0600)] 
Stupid const

17 months agoWords hard
Arran Cudbard-Bell [Sun, 19 May 2024 17:14:48 +0000 (11:14 -0600)] 
Words hard

17 months agoImprove the performance of `if ('rcode')` by doing the string to integer conversion...
Arran Cudbard-Bell [Sun, 19 May 2024 17:10:07 +0000 (11:10 -0600)] 
Improve the performance of `if ('rcode')` by doing the string to integer conversion, once, on startup

This also involves splitting the function into two, one that does the comparison, and one that can return the current rcode.

17 months agoOnly update request->rcode for a few unlang_ops
Arran Cudbard-Bell [Sun, 19 May 2024 01:10:52 +0000 (19:10 -0600)] 
Only update request->rcode for a few unlang_ops

17 months agos/set_rcode/rcode_set/
Arran Cudbard-Bell [Sun, 19 May 2024 01:09:32 +0000 (19:09 -0600)] 
s/set_rcode/rcode_set/

17 months agoRename resume function in call...
Arran Cudbard-Bell [Sun, 19 May 2024 01:08:49 +0000 (19:08 -0600)] 
Rename resume function in call...

17 months agoAdd unpredictable macro
Arran Cudbard-Bell [Sun, 19 May 2024 00:53:47 +0000 (18:53 -0600)] 
Add unpredictable macro

17 months agoQuiet coverity
Arran Cudbard-Bell [Fri, 17 May 2024 20:53:30 +0000 (14:53 -0600)] 
Quiet coverity

17 months agoMake DEBUG3 output less noisy
Nick Porter [Fri, 17 May 2024 17:21:21 +0000 (18:21 +0100)] 
Make DEBUG3 output less noisy

17 months agoDon't crash when we fail thread instantiation
Arran Cudbard-Bell [Fri, 17 May 2024 16:15:44 +0000 (10:15 -0600)] 
Don't crash when we fail thread instantiation

17 months agodefine enough things to shut up compiler
Alan T. DeKok [Fri, 17 May 2024 14:46:18 +0000 (10:46 -0400)] 
define enough things to shut up compiler

17 months agoadd read / write pause / resume debounce functions
Alan T. DeKok [Fri, 17 May 2024 14:27:29 +0000 (10:27 -0400)] 
add read / write pause / resume debounce functions

17 months agoundef const
Alan T. DeKok [Fri, 17 May 2024 14:26:51 +0000 (10:26 -0400)] 
undef const

17 months agoTypo
Arran Cudbard-Bell [Fri, 17 May 2024 14:30:28 +0000 (08:30 -0600)] 
Typo

17 months ago...and actually use the new enum
Arran Cudbard-Bell [Fri, 17 May 2024 14:29:36 +0000 (08:29 -0600)] 
...and actually use the new enum

17 months agoshhh compiler
Arran Cudbard-Bell [Fri, 17 May 2024 14:28:53 +0000 (08:28 -0600)] 
shhh compiler

17 months agoRemove components (MOD_AUTHORIZE, MOD_AUTHENTICATE, etc..) from the server
Arran Cudbard-Bell [Fri, 17 May 2024 00:21:32 +0000 (18:21 -0600)] 
Remove components (MOD_AUTHORIZE, MOD_AUTHENTICATE, etc..) from the server

We rely entirely on named methods now.

This breaks policy lookups, where the policy name is <policy>.<component>.  This needs to be fixed, by looking up <policy>[.<name1>][.<name2>].

17 months agos/name/name1/g
Arran Cudbard-Bell [Thu, 16 May 2024 22:48:01 +0000 (16:48 -0600)] 
s/name/name1/g

17 months agoSome minor tweaks to expose problems in rlm_rest
Arran Cudbard-Bell [Thu, 16 May 2024 22:00:28 +0000 (16:00 -0600)] 
Some minor tweaks to expose problems in rlm_rest

17 months agoPull in the dictionary header in module_method.h
Arran Cudbard-Bell [Thu, 16 May 2024 16:39:57 +0000 (10:39 -0600)] 
Pull in the dictionary header in module_method.h

17 months agoIt's fine to allocate pool data from the module_instance_t
Arran Cudbard-Bell [Thu, 16 May 2024 14:39:31 +0000 (08:39 -0600)] 
It's fine to allocate pool data from the module_instance_t

17 months agotypo
Alan T. DeKok [Thu, 16 May 2024 13:38:31 +0000 (09:38 -0400)] 
typo

17 months agomake cast const-qualified
Alan T. DeKok [Thu, 16 May 2024 13:29:18 +0000 (09:29 -0400)] 
make cast const-qualified

17 months agomove pasue / resume callbacks to client config structure
Alan T. DeKok [Thu, 16 May 2024 13:13:26 +0000 (09:13 -0400)] 
move pasue / resume callbacks to client config structure

17 months agoAllow '.' back in, for now
Arran Cudbard-Bell [Thu, 16 May 2024 05:54:24 +0000 (23:54 -0600)] 
Allow '.' back in, for now

17 months agoTypo
Arran Cudbard-Bell [Thu, 16 May 2024 05:40:59 +0000 (23:40 -0600)] 
Typo

17 months agoAdd allowed chars merge function
Arran Cudbard-Bell [Thu, 16 May 2024 05:18:38 +0000 (23:18 -0600)] 
Add allowed chars merge function

17 months agoMake module instance allowed chars available
Arran Cudbard-Bell [Thu, 16 May 2024 05:18:28 +0000 (23:18 -0600)] 
Make module instance allowed chars available

17 months agoUnconst the module instance
Arran Cudbard-Bell [Thu, 16 May 2024 05:17:56 +0000 (23:17 -0600)] 
Unconst the module instance

17 months agoPass in the module instance to the rlm_mschap connection function
Arran Cudbard-Bell [Wed, 15 May 2024 23:32:20 +0000 (17:32 -0600)] 
Pass in the module instance to the rlm_mschap connection function

17 months agoRestrict the acceptable char set for module names
Arran Cudbard-Bell [Wed, 15 May 2024 23:22:58 +0000 (17:22 -0600)] 
Restrict the acceptable char set for module names

17 months agoRemove more module-list specific lookup functions
Arran Cudbard-Bell [Wed, 15 May 2024 21:50:10 +0000 (15:50 -0600)] 
Remove more module-list specific lookup functions

rlm_sql_ippool and rlm_sql_counter won't work with dynamic modules... but that's OK, because the way they depend on other modules is stupid, and needs to be fixed anyway.

17 months agoRemove a call to module_rlm_by_name
Arran Cudbard-Bell [Wed, 15 May 2024 21:31:26 +0000 (15:31 -0600)] 
Remove a call to module_rlm_by_name

17 months agoRemove all the module_rlm_by_data lookup functions
Arran Cudbard-Bell [Wed, 15 May 2024 21:24:20 +0000 (15:24 -0600)] 
Remove all the module_rlm_by_data lookup functions

17 months agoUpdate links in the howto for EAP
Arran Cudbard-Bell [Wed, 15 May 2024 19:33:55 +0000 (13:33 -0600)] 
Update links in the howto for EAP

17 months agostats is now in inst->mutable
Nick Porter [Wed, 15 May 2024 19:38:22 +0000 (20:38 +0100)] 
stats is now in inst->mutable

17 months agoMore mutable data in stats
Arran Cudbard-Bell [Wed, 15 May 2024 16:57:17 +0000 (10:57 -0600)] 
More mutable data in stats

17 months agoDon't write to instance data in rlm_stats
Arran Cudbard-Bell [Wed, 15 May 2024 16:27:27 +0000 (10:27 -0600)] 
Don't write to instance data in rlm_stats

17 months agoadd and set write pause / resume callbacks
Alan T. DeKok [Wed, 15 May 2024 13:21:30 +0000 (09:21 -0400)] 
add and set write pause / resume callbacks

17 months agotypo
Alan T. DeKok [Wed, 15 May 2024 13:21:18 +0000 (09:21 -0400)] 
typo

17 months agomove fd_info to client_info structure
Alan T. DeKok [Wed, 15 May 2024 12:56:47 +0000 (08:56 -0400)] 
move fd_info to client_info structure

17 months agoadd framework for RADIUS client bio write blocked / resume callbacks
Alan T. DeKok [Tue, 14 May 2024 23:59:04 +0000 (19:59 -0400)] 
add framework for RADIUS client bio write blocked / resume callbacks

17 months agoWe need to resume iterating from the previous configuration item
Arran Cudbard-Bell [Wed, 15 May 2024 04:58:11 +0000 (22:58 -0600)] 
We need to resume iterating from the previous configuration item

17 months agoAdd dynamic module list
Arran Cudbard-Bell [Wed, 15 May 2024 04:27:32 +0000 (22:27 -0600)] 
Add dynamic module list

17 months agoAdd more cf boilerplate, and have cf_item_remove return the previous item to make...
Arran Cudbard-Bell [Wed, 15 May 2024 03:55:35 +0000 (21:55 -0600)] 
Add more cf boilerplate, and have cf_item_remove return the previous item to make iterating easier

17 months agoMove packet global free to the atexit handlers
Arran Cudbard-Bell [Wed, 15 May 2024 01:59:50 +0000 (19:59 -0600)] 
Move packet global free to the atexit handlers

17 months agoMove trigger free to the atexit handlers
Arran Cudbard-Bell [Wed, 15 May 2024 01:52:11 +0000 (19:52 -0600)] 
Move trigger free to the atexit handlers

17 months agoMove password free to the atexit handlers
Arran Cudbard-Bell [Wed, 15 May 2024 01:46:13 +0000 (19:46 -0600)] 
Move password free to the atexit handlers

17 months agoMove tmpl free to the atexit handlers
Arran Cudbard-Bell [Wed, 15 May 2024 01:45:58 +0000 (19:45 -0600)] 
Move tmpl free to the atexit handlers

17 months agoAuto unload SNMP attributes
Arran Cudbard-Bell [Wed, 15 May 2024 01:25:52 +0000 (19:25 -0600)] 
Auto unload SNMP attributes

17 months agoPrint the addresses mprotect actually protects
Arran Cudbard-Bell [Wed, 15 May 2024 00:37:32 +0000 (18:37 -0600)] 
Print the addresses mprotect actually protects

17 months agoThis could equal to the length of the pool
Arran Cudbard-Bell [Wed, 15 May 2024 00:36:15 +0000 (18:36 -0600)] 
This could equal to the length of the pool

17 months agoFix mprotect to it hands back the correct end address
Arran Cudbard-Bell [Wed, 15 May 2024 00:10:24 +0000 (18:10 -0600)] 
Fix mprotect to it hands back the correct end address

17 months agohandle the case of write blocked due to all IDs being used.
Alan T. DeKok [Tue, 14 May 2024 23:41:59 +0000 (19:41 -0400)] 
handle the case of write blocked due to all IDs being used.

The next few commits should add and use the various callback
functions to actually handle write blocked / resume

17 months agochange function prototype to make more sense
Alan T. DeKok [Tue, 14 May 2024 23:41:15 +0000 (19:41 -0400)] 
change function prototype to make more sense

17 months agomissed in previous commit
Alan T. DeKok [Tue, 14 May 2024 23:41:02 +0000 (19:41 -0400)] 
missed in previous commit

17 months agocleanups for coverity complaints about unused code
Alan T. DeKok [Tue, 14 May 2024 21:15:06 +0000 (17:15 -0400)] 
cleanups for coverity complaints about unused code

17 months agouse better function signatures for read / write pause / resume
Alan T. DeKok [Tue, 14 May 2024 21:06:44 +0000 (17:06 -0400)] 
use better function signatures for read / write pause / resume

17 months agoremove callbacks from fd_alloc()
Alan T. DeKok [Tue, 14 May 2024 20:46:33 +0000 (16:46 -0400)] 
remove callbacks from fd_alloc()

the caller can set it themselves, and it looks like every bio
may need to set the callbacks

and move the "set callback" code to a common bio function.

It's a bit more work for the caller when it's needed, but it's
much less work when it's not needed.

17 months agoadd read blocked / resume callbacks
Alan T. DeKok [Tue, 14 May 2024 18:58:47 +0000 (14:58 -0400)] 
add read blocked / resume callbacks

17 months agoadd callbacks for read/write blocked, and read/write resume
Alan T. DeKok [Tue, 14 May 2024 18:36:07 +0000 (14:36 -0400)] 
add callbacks for read/write blocked, and read/write resume

for now, only write blocked/resume is plumbed in.

17 months agoEnable write protection on a per-module list basis
Arran Cudbard-Bell [Tue, 14 May 2024 14:57:47 +0000 (08:57 -0600)] 
Enable write protection on a per-module list basis

17 months agoTemporary fix
Arran Cudbard-Bell [Tue, 14 May 2024 04:13:34 +0000 (22:13 -0600)] 
Temporary fix

17 months agoExplicitly free the listener in the socket destructor
Arran Cudbard-Bell [Tue, 14 May 2024 03:48:53 +0000 (21:48 -0600)] 
Explicitly free the listener in the socket destructor

17 months agoUse talloc get type abort for safety...
Arran Cudbard-Bell [Tue, 14 May 2024 02:40:24 +0000 (20:40 -0600)] 
Use talloc get type abort for safety...

17 months agoDon't use cf_parent(inst->cs)
Arran Cudbard-Bell [Tue, 14 May 2024 02:24:45 +0000 (20:24 -0600)] 
Don't use cf_parent(inst->cs)

17 months agoRevert "Tests pass with mprotect enabled locally... let's see if it works with CI...
Arran Cudbard-Bell [Tue, 14 May 2024 01:01:31 +0000 (19:01 -0600)] 
Revert "Tests pass with mprotect enabled locally... let's see if it works with CI now"

This reverts commit 050120df5ff9e22378ee4b760a7a3a6da8d0b9f3.

17 months agoNetwork should own the drectory listener too
Arran Cudbard-Bell [Tue, 14 May 2024 01:00:37 +0000 (19:00 -0600)] 
Network should own the drectory listener too

17 months agoTests pass with mprotect enabled locally... let's see if it works with CI now
Arran Cudbard-Bell [Tue, 14 May 2024 00:48:46 +0000 (18:48 -0600)] 
Tests pass with mprotect enabled locally... let's see if it works with CI now

17 months agoadd write_blocked flag to packet bio
Alan T. DeKok [Mon, 13 May 2024 15:27:03 +0000 (11:27 -0400)] 
add write_blocked flag to packet bio

along with a flush API.  So that the individual protocols don't
have to do that.

and have the memory bio return IO_WOULD_BLOCK if it can't flush
the pending data.

17 months agostart of re-implementing CoA server functionality
Alan T. DeKok [Mon, 13 May 2024 15:28:43 +0000 (11:28 -0400)] 
start of re-implementing CoA server functionality

17 months agoupdate comments and documentation
Alan T. DeKok [Mon, 13 May 2024 14:59:50 +0000 (10:59 -0400)] 
update comments and documentation

17 months agoupdate doxygen
Alan T. DeKok [Mon, 13 May 2024 14:59:29 +0000 (10:59 -0400)] 
update doxygen

17 months agonotes on AD allowing "bind as user" without passwords
Alan T. DeKok [Mon, 13 May 2024 14:58:18 +0000 (10:58 -0400)] 
notes on AD allowing "bind as user" without passwords

17 months agoGet the listen section from the parent module
Arran Cudbard-Bell [Tue, 14 May 2024 00:29:23 +0000 (18:29 -0600)] 
Get the listen section from the parent module

17 months agoDup the parent config section before calling conf_parse for child transport modules
Arran Cudbard-Bell [Tue, 14 May 2024 00:25:26 +0000 (18:25 -0600)] 
Dup the parent config section before calling conf_parse for child transport modules

17 months agoDon't always copy the parsed flag when duping pairs
Arran Cudbard-Bell [Tue, 14 May 2024 00:24:51 +0000 (18:24 -0600)] 
Don't always copy the parsed flag when duping pairs

17 months agoAdd logging functions for sections and pairs
Arran Cudbard-Bell [Tue, 14 May 2024 00:24:01 +0000 (18:24 -0600)] 
Add logging functions for sections and pairs

17 months agoDon't try and free local thread instance data if it's not been allocated
Arran Cudbard-Bell [Mon, 13 May 2024 23:17:31 +0000 (17:17 -0600)] 
Don't try and free local thread instance data if it's not been allocated

17 months agoShouldn't use perr here...
Arran Cudbard-Bell [Mon, 13 May 2024 23:14:35 +0000 (17:14 -0600)] 
Shouldn't use perr here...

17 months agoCall submoule instantiate for proto modules before calling master.instantiate
Arran Cudbard-Bell [Mon, 13 May 2024 20:59:54 +0000 (14:59 -0600)] 
Call submoule instantiate for proto modules before calling master.instantiate

17 months agoReorder args in mod_network_get
Arran Cudbard-Bell [Mon, 13 May 2024 20:59:22 +0000 (14:59 -0600)] 
Reorder args in mod_network_get

17 months agoMake the default radclient tests run with dynamic clients
Arran Cudbard-Bell [Mon, 13 May 2024 20:29:37 +0000 (14:29 -0600)] 
Make the default radclient tests run with dynamic clients

17 months agoMake cntrl-c work again on macOS, after we do a TLS handhshake
Arran Cudbard-Bell [Mon, 13 May 2024 19:44:51 +0000 (13:44 -0600)] 
Make cntrl-c work again on macOS, after we do a TLS handhshake

17 months agoFix time tracking assert when the server is blocked processing children
Arran Cudbard-Bell [Mon, 13 May 2024 18:53:59 +0000 (12:53 -0600)] 
Fix time tracking assert when the server is blocked processing children

17 months agoTypo
Arran Cudbard-Bell [Mon, 13 May 2024 18:52:38 +0000 (12:52 -0600)] 
Typo

17 months agoSplit the backtrace function
Arran Cudbard-Bell [Mon, 13 May 2024 18:52:27 +0000 (12:52 -0600)] 
Split the backtrace function

17 months agoAdd the same shim for all modules
Arran Cudbard-Bell [Mon, 13 May 2024 15:58:13 +0000 (09:58 -0600)] 
Add the same shim for all modules

17 months agoMore predictable signal handling
Arran Cudbard-Bell [Mon, 13 May 2024 15:45:07 +0000 (09:45 -0600)] 
More predictable signal handling

17 months agoPre-populate some additional fields in app_io
Arran Cudbard-Bell [Mon, 13 May 2024 14:49:57 +0000 (08:49 -0600)] 
Pre-populate some additional fields in app_io

17 months agoSame shim for tacacs
Arran Cudbard-Bell [Mon, 13 May 2024 14:34:58 +0000 (08:34 -0600)] 
Same shim for tacacs

17 months agoDisable protection temporarily
Arran Cudbard-Bell [Mon, 13 May 2024 14:27:39 +0000 (08:27 -0600)] 
Disable protection temporarily

17 months agoHack in shim for proto_radius to populate io.app_io
Arran Cudbard-Bell [Mon, 13 May 2024 14:16:30 +0000 (08:16 -0600)] 
Hack in shim for proto_radius to populate io.app_io

17 months agoVestigal code that was never actually implemented, and likely doesn't need to be
Arran Cudbard-Bell [Mon, 13 May 2024 13:39:39 +0000 (07:39 -0600)] 
Vestigal code that was never actually implemented, and likely doesn't need to be

17 months agoBetter self signalling
Arran Cudbard-Bell [Mon, 13 May 2024 13:39:18 +0000 (07:39 -0600)] 
Better self signalling

17 months agouseful, but not _that_ useful
Arran Cudbard-Bell [Mon, 13 May 2024 04:18:09 +0000 (22:18 -0600)] 
useful, but not _that_ useful

17 months agoFix random ungraceful exits
Arran Cudbard-Bell [Mon, 13 May 2024 04:07:57 +0000 (22:07 -0600)] 
Fix random ungraceful exits

17 months agoNot just workers...
Arran Cudbard-Bell [Mon, 13 May 2024 04:06:23 +0000 (22:06 -0600)] 
Not just workers...

17 months agoWrite a message saying we tried to signal ourselves but failed
Arran Cudbard-Bell [Mon, 13 May 2024 04:06:17 +0000 (22:06 -0600)] 
Write a message saying we tried to signal ourselves but failed