Timo Sirainen [Fri, 4 Dec 2015 10:15:49 +0000 (12:15 +0200)]
imap: Fixed assert-crash if client disconnected at a specific command state.
If there was a command with state=CLIENT_COMMAND_STATE_WAIT_SYNC and output
stream was already detected to be closed, we crashed with:
Timo Sirainen [Fri, 4 Dec 2015 09:38:00 +0000 (11:38 +0200)]
lib-index: mail_transaction_log_file_map() didn't properly check start_offset
If it was too high, it still returned successful mapping. This could have
caused an assert-crash later on when the start_offset was actually attempted
to be used.
Timo Sirainen [Thu, 3 Dec 2015 12:24:06 +0000 (14:24 +0200)]
fts: Added support for per-language tokenizer settings.
fts_tokenizer_<lang> now overrides fts_tokenizers setting.
fts_tokenizer_<name>_<lang> now overrides fts_tokenizer_<name> setting.
Timo Sirainen [Thu, 3 Dec 2015 10:22:24 +0000 (12:22 +0200)]
lib-ssl-iostream: Moved openssl_iostream_*error() to -common.c
login-common code only links with this file, so that's required for the
previous changes to actually work.
Timo Sirainen [Thu, 3 Dec 2015 10:19:12 +0000 (12:19 +0200)]
login, lib-ssl-iostream: Clear errors caused by manual EC key selection when there was no EC key.
EVP_PKEY_get1_EC_KEY() would return an error, which should be ignored
instead of being logged later on.
Timo Sirainen [Thu, 3 Dec 2015 09:55:33 +0000 (11:55 +0200)]
lib-ssl-iostream: Fixes to error handling.
Copy behavior from login-common/ssl-proxy-openssl.c:
- Handle stacked errors.
- Improve errors with ERR_TXT_STRING flag.
Timo Sirainen [Tue, 1 Dec 2015 15:31:08 +0000 (17:31 +0200)]
mail-log: If uid field is used, make sure newly saved mails actually get an UID.
With Maildir the UID is otherwise assigned on mail deliveries only if
dovecot-uidlist happens to get locked.
Timo Sirainen [Mon, 30 Nov 2015 19:36:51 +0000 (21:36 +0200)]
director: Don't treat empty hostname the same as having it.
This could have caused "host not given" errors if an empty "host=" was sent
to login process, even though hostip was also sent.
Fixed this in two places, although either one should have been enough.
Timo Sirainen [Mon, 30 Nov 2015 11:14:29 +0000 (13:14 +0200)]
lib-mail: rfc822_parse_content_param() was unescaping already unescaped parameters
This caused all Content-* parameter parsing to be unescaped once too many
times, resulting in somewhat broken BODY and BODYSTRUCTURE replies if any
<\> characters were used. Also MIME boundaries were parsed in case <\> was
used in them, but this probably didn't practically happen.
Timo Sirainen [Fri, 27 Nov 2015 13:24:41 +0000 (15:24 +0200)]
fts-solr: Fixed escaping query parameters.
Solr documentation says that "quoted string" would already work without
escaping, but that doesn't seem to be true (we were also missing the \"
escaping there). So we'll now escape all the special characters without
quotes around it, which seems to work. Also added '/' to list of special
characters, which is used by Solr 4.0.
Timo Sirainen [Fri, 27 Nov 2015 12:57:03 +0000 (14:57 +0200)]
zlib: Fixed copying causing cache corruption when zlib_save wasn't set.
dovecot.index.cache entries were broken/missing if:
- The zlib plugin is enabled;
- The zlib_save/zlib_save_level options are NOT enabled;
- The source message being copied is compressed;
- The mail_log plugin is logging "copy" events;
- The mail_log_fields setting includes at least one message header;
- The destination mailbox folder has an index file that is recording the
logged headers;
- The source mailbox folder does NOT have an index file recording the
logged headers.
Timo Sirainen [Fri, 27 Nov 2015 11:59:22 +0000 (13:59 +0200)]
Added mailbox { autoexpunge } setting.
This can be used to automatically expunge mails from specified mailboxes
after they're old enough. The expunges are done when the user is being
deinitialized. mailbox_list_index=yes should be enabled to have the best
performance with this setting.
Timo Sirainen [Thu, 26 Nov 2015 13:42:35 +0000 (15:42 +0200)]
quota-clone: Avoid assert-crash when quota recalculation is triggered.
Quota recalculation opened all mailboxes and got us back to
quota_clone_flush(), which caused another dict transaction to be opened,
which caused a crash with some dict backends.
Teemu Huovila [Wed, 25 Nov 2015 13:09:52 +0000 (15:09 +0200)]
lib-fts: Move ICU transliterator creation to fts-icu.h
This allows others to use transliterators without so much code duplication.
The transliterator still has to be destroyed by the user, with utrans_close().
Timo Sirainen [Tue, 24 Nov 2015 09:50:15 +0000 (11:50 +0200)]
imap: Fixed hanging if a pipelined IMAP command was waiting for previous command to sync.
..And the previous command was waiting for the next command to finish before
it would start syncing. For example FETCH+LOGOUT pipelined.
Timo Sirainen [Tue, 24 Nov 2015 09:15:47 +0000 (11:15 +0200)]
director: Fixed backend selection when multiple tags were used.
The previous algorithm was causing an uneven load for backends.
This change breaks compatibility with older director servers that were using
tags because of the different selection algorithm. The new director code
refuses to run within a cluster with old directors if tags are used.
Timo Sirainen [Mon, 23 Nov 2015 17:35:03 +0000 (19:35 +0200)]
director: With director_consistent_hashing=yes hosts_hash wasn't always calculated right.
If different servers had added hosts in different order, the hosts_hash
would have become different, which caused errors and resyncs.
Teemu Huovila [Wed, 18 Nov 2015 14:33:26 +0000 (16:33 +0200)]
fts: Remove default filters and tokenizers.
There aren't any specially good defaults that work for all the languages,
so it's better to just enforce explicit settings.
Timo Sirainen [Wed, 18 Nov 2015 19:06:17 +0000 (21:06 +0200)]
indexer-worker: Use provided session-id only as a prefix for a unique session ID.
Fixes stats process's "Duplicate session ID" errors when LMTP delivers to
multiple recipients.
Timo Sirainen [Wed, 18 Nov 2015 19:03:41 +0000 (21:03 +0200)]
lib-storage: Added mail_storage_service_input.session_id_prefix
This should make it easier to pass through the original session_id to worker
process sessions. Especially if these sessions are somewhat short-lived it
can be useful to assign them a unique session ID while still being able to
match it to the parent's session ID.
Timo Sirainen [Wed, 18 Nov 2015 17:15:36 +0000 (19:15 +0200)]
stats: Forced sending of UPDATE-SESSION every 5 minutes wasn't working.
This caused stats process to forget about idling (imap) sessions if they
didn't do anything for over 15 minutes.
Timo Sirainen [Wed, 18 Nov 2015 16:10:46 +0000 (18:10 +0200)]
lib-storage: Create ioloop context for users even if log prefix changing is disabled.
This fixes stats plugin to work with lmtp, imap-urlauth and doveadm-server.
Timo Sirainen [Wed, 18 Nov 2015 15:45:35 +0000 (17:45 +0200)]
lib-master: master_service_is_master_stopped() now returns FALSE if running standalone.
The only caller of this function was stats plugin to see if it should send
stats updates. So this fixes dovecot-lda, doveadm and other standalone tools
to send stats updates.
Timo Sirainen [Wed, 18 Nov 2015 11:12:23 +0000 (13:12 +0200)]
pop3: When creating session lock file, prefer to write it to the index root dir.
This is especially important for mail storage backends that don't have a mail
root directory.
Timo Sirainen [Wed, 18 Nov 2015 11:08:57 +0000 (13:08 +0200)]
pop3: Send "OK Logged in" before reading mailbox.
This way if the reading takes a long time, the client still sees that the
login itself was successful. This is especially useful to avoid unnecessary
errors logged by proxies.
Timo Sirainen [Tue, 17 Nov 2015 15:26:56 +0000 (17:26 +0200)]
*-login: Added postlogin_socket=path passdb extra field.
By default e.g. "imap" or "pop3" is the post-login socket, but this can
override it. This could be used for example for per-user debugging (e.g.
setting executable to be run via strace or valgrind).
Timo Sirainen [Tue, 17 Nov 2015 14:30:16 +0000 (16:30 +0200)]
lib-fs: Added asserts to fs_set_metadata() to make sure key and value are non-NULL
Otherwise the bug would be noticed only much later when trying to
dereference NULL pointer.
Teemu Huovila [Tue, 17 Nov 2015 09:44:19 +0000 (11:44 +0200)]
lib-fts: Add Norwegian.
Norwegian has two main dialects, Bokmal(nb) and Nynorsk(nn). They
are detected separately by libexttextcat, but the stemmer only
knows Norwegian. Thus they are treated as a single language,
Norwegian (no). This might also make more sense in everyday
use of mixed writing style Norwegian.
Caveat: The default normalizer filter does not modify U+00F8
(Latin Small Letter O with Stroke). In some configurations it
might be desirable to rewrite it to e.g. o. Same goes for the
upper case version. This can be done by passing a modified "id"
setting to the normalizer filter.
Teemu Huovila [Tue, 17 Nov 2015 09:43:58 +0000 (11:43 +0200)]
lib-fts: Add comment to language names.
Languages are defined by their ISO 639-1 code, which is a two letters.
It is possible, that some languages with only a three letter code, ie.
a ISO 639-2 code, could be added in the future.
Timo Sirainen [Mon, 16 Nov 2015 12:16:00 +0000 (14:16 +0200)]
dovecot.m4: Run valgrind with --trace-children=yes
Some of the unit tests are run via shell and we want to check the unit tests
instead of just the shell.
Phil Carmody [Mon, 16 Nov 2015 10:29:51 +0000 (12:29 +0200)]
various - remove 8-bit characters from literal strings in test cases
C has a portable way of expressing characters not in the basic character
set, namely \xNN escaping. Otherwise, the interpretation of the raw utf-8
is implentation dependent. This has the benefit of making some tests'
expected output more obvious, such as "=c3=a4" matching "\xC3\xA4", even
if it hinders the readability of some natural-language-based tests.
Phil Carmody [Mon, 16 Nov 2015 10:26:06 +0000 (12:26 +0200)]
lib-http: ref/unref input stream in http message parser
To prevent assidental disappearance of the stream while it's in use.
Also, the caller can create and forget - we'll do the cleanup later.