]> git.ipfire.org Git - thirdparty/fastapi/fastapi.git/log
thirdparty/fastapi/fastapi.git
5 years ago:memo: Update release notes
Sebastián Ramírez [Sun, 29 Mar 2020 15:53:49 +0000 (17:53 +0200)] 
:memo: Update release notes

5 years ago:pencil2: Fix typo (#1148)
Paul-Louis NECH [Sun, 29 Mar 2020 15:51:58 +0000 (17:51 +0200)] 
:pencil2: Fix typo (#1148)

5 years ago:memo: Update release notes
Sebastián Ramírez [Sun, 29 Mar 2020 15:05:03 +0000 (17:05 +0200)] 
:memo: Update release notes

5 years ago:checkered_flag: Update Windows development environment and tests (#1179)
Sebastián Ramírez [Sun, 29 Mar 2020 15:04:04 +0000 (17:04 +0200)] 
:checkered_flag: Update Windows development environment and tests (#1179)

* :checkered_flag: Fix ./scripts/docs.py encoding for Windows

* :fire: Remove ujson from tests as it prevents Windows development

It's still tested by Starlette anyway

* :memo: Update development instructions for Windows

* :art: Update format for WSGIMiddleware example

* :white_check_mark: Update tests to run on Windows

5 years ago:bookmark: Release version 0.53.0 0.53.0
Sebastián Ramírez [Fri, 27 Mar 2020 16:56:41 +0000 (17:56 +0100)] 
:bookmark: Release version 0.53.0

5 years ago:memo: Update release notes
Sebastián Ramírez [Fri, 27 Mar 2020 16:52:33 +0000 (17:52 +0100)] 
:memo: Update release notes

5 years ago:art: Update badge for coverage (#1175)
Sebastián Ramírez [Fri, 27 Mar 2020 16:51:58 +0000 (17:51 +0100)] 
:art: Update badge for coverage (#1175)

from shields.io, as Codecov's one shows coverage for the last PR from a fork at master

5 years ago:memo: Update release notes
Sebastián Ramírez [Fri, 27 Mar 2020 16:33:51 +0000 (17:33 +0100)] 
:memo: Update release notes

5 years ago:heavy_plus_sign: Add orjson to pip install fastapi[all] (#1161)
Michael Oliver [Fri, 27 Mar 2020 16:32:35 +0000 (16:32 +0000)] 
:heavy_plus_sign: Add orjson to pip install fastapi[all] (#1161)

5 years ago:memo: Update release notes
Sebastián Ramírez [Fri, 27 Mar 2020 16:29:11 +0000 (17:29 +0100)] 
:memo: Update release notes

5 years ago:bug: Fix GZipMiddleware code block linking to TrustedHostMiddleware in docs (#1138)
Ari Bajo [Fri, 27 Mar 2020 16:27:57 +0000 (17:27 +0100)] 
:bug: Fix GZipMiddleware code block linking to TrustedHostMiddleware in docs (#1138)

5 years ago:memo: Update release notes
Sebastián Ramírez [Fri, 27 Mar 2020 16:20:01 +0000 (17:20 +0100)] 
:memo: Update release notes

5 years ago:pencil2: Update doc string with correct class name (#1126)
adg-mh [Fri, 27 Mar 2020 16:18:23 +0000 (11:18 -0500)] 
:pencil2: Update doc string with correct class name (#1126)

5 years ago:memo: Update release notes
Sebastián Ramírez [Fri, 27 Mar 2020 16:16:45 +0000 (17:16 +0100)] 
:memo: Update release notes

5 years ago:memo: Clarify function name in example (#1121)
Tomoya Yoshioka [Fri, 27 Mar 2020 16:15:26 +0000 (01:15 +0900)] 
:memo: Clarify function name in example (#1121)

5 years ago:memo: Update release notes
Sebastián Ramírez [Fri, 27 Mar 2020 16:04:25 +0000 (17:04 +0100)] 
:memo: Update release notes

5 years ago:memo: Add new external link (#1112)
Ben [Fri, 27 Mar 2020 16:02:18 +0000 (17:02 +0100)] 
:memo: Add new external link (#1112)

* Added new external link

I added an article in which I briefly explain how to build an Apache Kafka producer / consumer with FastAPI and aiokafka.

* :memo: Update format

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
5 years ago:memo: Update release notes
Sebastián Ramírez [Fri, 27 Mar 2020 15:21:28 +0000 (16:21 +0100)] 
:memo: Update release notes

5 years ago:bug: Fix exclude_unset and aliases in response model validation (#1074)
juhovh-aiven [Fri, 27 Mar 2020 15:19:17 +0000 (02:19 +1100)] 
:bug: Fix exclude_unset and aliases in response model validation (#1074)

* Fix exclude_unset and aliases in response model validation.

* :sparkles: Use by_alias from param :shrug:

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
5 years ago:memo: Update release notes
Sebastián Ramírez [Fri, 27 Mar 2020 14:34:16 +0000 (15:34 +0100)] 
:memo: Update release notes

5 years ago:sparkles: Add Gitter chat to docs (#1061)
Aakash Nand [Fri, 27 Mar 2020 14:32:15 +0000 (23:32 +0900)] 
:sparkles: Add Gitter chat to docs (#1061)

* implemented chat feature using sidecar from starlette docs

* :fire: Use external Gitter sidecar JS

* :sparkles: Re-implement Gitter chat after multi-lang

* :fire: Remove moved file

Co-authored-by: Aakash Nand <aakashnand@nttv6.jp>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
5 years ago:memo: Update release notes
Sebastián Ramírez [Fri, 27 Mar 2020 09:21:40 +0000 (10:21 +0100)] 
:memo: Update release notes

5 years ago:memo: Update and simplify translations docs (#1171)
Sebastián Ramírez [Fri, 27 Mar 2020 09:20:39 +0000 (10:20 +0100)] 
:memo: Update and simplify translations docs (#1171)

5 years ago:memo: Update release notes
Sebastián Ramírez [Thu, 26 Mar 2020 21:24:36 +0000 (22:24 +0100)] 
:memo: Update release notes

5 years ago:checkered_flag: Change docs address to localhost for Windows (#1169)
Camila Gutierrez [Thu, 26 Mar 2020 21:22:34 +0000 (22:22 +0100)] 
:checkered_flag: Change docs address to localhost for Windows (#1169)

5 years ago:memo: Update release notes
Sebastián Ramírez [Thu, 26 Mar 2020 19:13:03 +0000 (20:13 +0100)] 
:memo: Update release notes

5 years ago:sparkles: Add support for docs translations (#1168)
Sebastián Ramírez [Thu, 26 Mar 2020 19:09:53 +0000 (20:09 +0100)] 
:sparkles: Add support for docs translations (#1168)

* :globe_with_meridians: Refactor file structure to support internationalization

* :white_check_mark: Update tests changed after i18n

* :twisted_rightwards_arrows: Merge Typer style from master

* :wrench: Update MkConfig with Typer-styles

* :art: Format mkdocs.yml with cannonical form

* :art: Format mkdocs.yml

* :wrench: Update MkDocs config

* :heavy_plus_sign: Add docs translation scripts dependencies

* :sparkles: Add Typer scripts to handle translations

* :sparkles: Add missing translation snippet to include

* :sparkles: Update contributing docs, add docs for translations

* :see_no_evil: Add docs_build to gitignore

* :wrench: Update scripts with new locations and docs scripts

* :construction_worker: Update docs deploy action with translations

* :memo: Add note about languages not supported in the theme

* :sparkles: Add first translation, for Spanish

5 years ago:memo: Update release notes
Sebastián Ramírez [Thu, 19 Mar 2020 13:40:58 +0000 (14:40 +0100)] 
:memo: Update release notes

5 years ago:art: Update terminal examples and Typer note (#1139)
Sebastián Ramírez [Thu, 19 Mar 2020 13:39:29 +0000 (14:39 +0100)] 
:art: Update terminal examples and Typer note (#1139)

* :art: Update terminal examples with Termynal

* :bento: Add Termynal scripts and styles from Typer for terminal examples

5 years ago:bookmark: Release version 0.52.0 0.52.0
Sebastián Ramírez [Sun, 1 Mar 2020 21:34:38 +0000 (22:34 +0100)] 
:bookmark: Release version 0.52.0

5 years ago:memo: Update release notes
Sebastián Ramírez [Sun, 1 Mar 2020 21:33:11 +0000 (22:33 +0100)] 
:memo: Update release notes

5 years ago:sparkles: Add ORJSONResponse (#1065)
Sebastián Ramírez [Sun, 1 Mar 2020 21:30:58 +0000 (22:30 +0100)] 
:sparkles: Add ORJSONResponse (#1065)

* :sparkles: Add ORJSONResponse

* :memo: Add tutorial using ORJSONResponse

* :white_check_mark: Add test for ORJSONResponse

* :memo: Update index.md

5 years ago:bookmark: Release version 0.51.0 0.51.0
Sebastián Ramírez [Sun, 1 Mar 2020 21:02:51 +0000 (22:02 +0100)] 
:bookmark: Release version 0.51.0

5 years ago:memo: Update release notes
Sebastián Ramírez [Sun, 1 Mar 2020 20:58:36 +0000 (21:58 +0100)] 
:memo: Update release notes

5 years ago:sparkles: Re-export utils from Starlette (#1064)
Sebastián Ramírez [Sun, 1 Mar 2020 20:49:20 +0000 (21:49 +0100)] 
:sparkles: Re-export utils from Starlette (#1064)

* :sparkles: Re-export main features used from Starlette to simplify developer's code

* :recycle: Refactor Starlette exports

* :recycle: Refactor tutorial examples to use re-exported utils from Starlette

* :memo: Add examples for all middlewares

* :memo: Add new docs for middlewares

* :memo: Add examples for custom responses

* :memo: Extend docs for custom responses

* :memo: Update docs and add notes explaining re-exports from Starlette everywhere

* :bento: Update screenshot for HTTP status

* :wrench: Update MkDocs config with new content

* :recycle: Refactor tests to use re-exported utils from Starlette

* :sparkles: Re-export WebSocketDisconnect from Starlette for tests

* :white_check_mark: Add extra tests for extra re-exported middleware

* :white_check_mark: Add tests for re-exported responses from Starlette

* :sparkles: Add docs about mounting WSGI apps

* :heavy_plus_sign: Add Flask as a dependency to test WSGIMiddleware

* :white_check_mark: Test WSGIMiddleware example

5 years ago:bookmark: Release version 0.50.0 0.50.0
Sebastián Ramírez [Sat, 29 Feb 2020 20:49:09 +0000 (21:49 +0100)] 
:bookmark: Release version 0.50.0

5 years ago:memo: Update release notes
Sebastián Ramírez [Sat, 29 Feb 2020 20:48:11 +0000 (21:48 +0100)] 
:memo: Update release notes

5 years ago:memo: Add link to the Release Notes from the section about pinning versions for...
Sebastián Ramírez [Sat, 29 Feb 2020 20:47:46 +0000 (21:47 +0100)] 
:memo: Add link to the Release Notes from the section about pinning versions for deployment (#1058)

5 years ago:pushpin: Upgrade Starlette version (#1057)
Sebastián Ramírez [Sat, 29 Feb 2020 20:28:23 +0000 (21:28 +0100)] 
:pushpin: Upgrade Starlette version (#1057)

5 years ago:memo: Update release notes
Sebastián Ramírez [Sat, 29 Feb 2020 18:22:08 +0000 (19:22 +0100)] 
:memo: Update release notes

5 years ago:memo: Add docs about pinning versions for deployment (#1056)
Sebastián Ramírez [Sat, 29 Feb 2020 18:20:18 +0000 (19:20 +0100)] 
:memo: Add docs about pinning versions for deployment (#1056)

5 years ago:bookmark: Release 0.49.2 0.49.2
Sebastián Ramírez [Sat, 29 Feb 2020 17:19:52 +0000 (18:19 +0100)] 
:bookmark: Release 0.49.2

5 years ago:memo: Update release notes
Sebastián Ramírez [Sat, 29 Feb 2020 17:01:40 +0000 (18:01 +0100)] 
:memo: Update release notes

5 years ago:memo: Update release notes
Sebastián Ramírez [Sat, 29 Feb 2020 16:58:02 +0000 (17:58 +0100)] 
:memo: Update release notes

5 years ago:pencil2: Fix broken links in release notes (#1052)
sattosan [Sat, 29 Feb 2020 17:00:40 +0000 (02:00 +0900)] 
:pencil2: Fix broken links in release notes (#1052)

5 years ago:pencil2: Fix typo in release notes (#1051)
sattosan [Sat, 29 Feb 2020 16:56:41 +0000 (01:56 +0900)] 
:pencil2: Fix typo in release notes (#1051)

5 years ago:recycle: Refactor serialize_response parameter name (#1031)
Patrick McKenna [Sat, 29 Feb 2020 16:33:02 +0000 (08:33 -0800)] 
:recycle: Refactor serialize_response parameter name (#1031)

5 years ago:recycle: Refactor function calling a path operation function to simplify profiling...
sm-Fifteen [Sat, 29 Feb 2020 16:28:30 +0000 (11:28 -0500)] 
:recycle: Refactor function calling a path operation function to simplify profiling (#1027)

5 years ago:memo: Update release notes
Sebastián Ramírez [Sat, 29 Feb 2020 16:16:00 +0000 (17:16 +0100)] 
:memo: Update release notes

5 years ago:heavy_plus_sign: Add testing dependencies #1026
sm-Fifteen [Sat, 29 Feb 2020 13:23:41 +0000 (08:23 -0500)] 
:heavy_plus_sign: Add testing dependencies #1026

5 years ago:memo: Update release notes
Sebastián Ramírez [Sat, 29 Feb 2020 13:06:45 +0000 (14:06 +0100)] 
:memo: Update release notes

5 years ago:bug: Admit valid types for Pydantic fields as responses models (#1017)
Patrick McKenna [Sat, 29 Feb 2020 13:04:35 +0000 (05:04 -0800)] 
:bug: Admit valid types for Pydantic fields as responses models (#1017)

5 years ago:memo: Update release notes
Sebastián Ramírez [Sat, 29 Feb 2020 12:16:20 +0000 (13:16 +0100)] 
:memo: Update release notes

5 years ago:art: Fix markdown code section rendering error in SQL tutorial (#1015)
Vegard Stikbakke [Sat, 29 Feb 2020 11:40:09 +0000 (12:40 +0100)] 
:art: Fix markdown code section rendering error in SQL tutorial (#1015)

5 years ago:bookmark: Release 0.49.1 0.49.1
Sebastián Ramírez [Fri, 28 Feb 2020 21:48:03 +0000 (22:48 +0100)] 
:bookmark: Release 0.49.1

5 years ago:memo: Update release notes
Sebastián Ramírez [Fri, 28 Feb 2020 21:46:55 +0000 (22:46 +0100)] 
:memo: Update release notes

5 years ago:bug: Fix declaring a single parameter per name (#994)
merowinger92 [Fri, 28 Feb 2020 21:36:30 +0000 (22:36 +0100)] 
:bug: Fix declaring a single parameter per name (#994)

5 years ago:rocket: Update Netlify deploy action (#1047)
Sebastián Ramírez [Fri, 28 Feb 2020 16:27:43 +0000 (17:27 +0100)] 
:rocket: Update Netlify deploy action (#1047)

5 years ago:wrench: Move all mypy configurations to configuration file (#987)
Taneli Hukkinen [Thu, 27 Feb 2020 20:03:03 +0000 (21:03 +0100)] 
:wrench: Move all mypy configurations to configuration file (#987)

5 years ago:green_heart: Do not deploy preview to Netlify on external PRs while GitHub actions...
Camila Gutierrez [Thu, 27 Feb 2020 19:59:26 +0000 (20:59 +0100)] 
:green_heart: Do not deploy preview to Netlify on external PRs while GitHub actions are solved (#1046)

5 years ago:bookmark: Release version 0.49.0 0.49.0
Sebastián Ramírez [Sun, 16 Feb 2020 20:11:28 +0000 (21:11 +0100)] 
:bookmark: Release version 0.49.0

5 years ago:memo: Update release notes
Sebastián Ramírez [Sun, 16 Feb 2020 20:08:58 +0000 (21:08 +0100)] 
:memo: Update release notes

5 years ago:bug: Fix path encoding (#978)
Patrick McKenna [Sun, 16 Feb 2020 20:06:41 +0000 (12:06 -0800)] 
:bug: Fix path encoding (#978)

5 years ago:memo: Add link: JP articles related to fastapi (#974)
T. Tokusumi [Sun, 16 Feb 2020 20:00:42 +0000 (05:00 +0900)] 
:memo: Add link: JP articles related to fastapi (#974)

5 years ago:memo: Fix broken link in docs (#949)
Taras Sotnikov [Sun, 16 Feb 2020 19:57:29 +0000 (20:57 +0100)] 
:memo: Fix broken link in docs (#949)

5 years ago:memo: Update release notes
Sebastián Ramírez [Sun, 16 Feb 2020 19:55:07 +0000 (20:55 +0100)] 
:memo: Update release notes

5 years ago:memo: Update release notes
Sebastián Ramírez [Sun, 16 Feb 2020 19:49:43 +0000 (20:49 +0100)] 
:memo: Update release notes

5 years ago:pencil2: Fix typo (#941)
Nikita Kolesov [Sun, 16 Feb 2020 19:51:18 +0000 (22:51 +0300)] 
:pencil2: Fix typo (#941)

5 years ago:memo: Update docs for dependencies with yield (#986)
Sebastián Ramírez [Sun, 16 Feb 2020 19:49:12 +0000 (20:49 +0100)] 
:memo: Update docs for dependencies with yield (#986)

5 years ago:memo: Update release notes
Sebastián Ramírez [Sun, 16 Feb 2020 18:48:52 +0000 (19:48 +0100)] 
:memo: Update release notes

5 years ago:sparkles: Add mermaid.js support in Markdown fenced blocks for diagrams (#985)
Sebastián Ramírez [Sun, 16 Feb 2020 18:48:20 +0000 (19:48 +0100)] 
:sparkles: Add mermaid.js support in Markdown fenced blocks for diagrams (#985)

5 years ago:memo: Update release notes
Sebastián Ramírez [Sat, 15 Feb 2020 12:26:01 +0000 (13:26 +0100)] 
:memo: Update release notes

5 years ago:construction_worker: Add GitHub actions to deploy to Netlify (#983)
Sebastián Ramírez [Sat, 15 Feb 2020 12:24:34 +0000 (13:24 +0100)] 
:construction_worker: Add GitHub actions to deploy to Netlify (#983)

5 years ago:memo: Update release notes
Sebastián Ramírez [Wed, 12 Feb 2020 20:37:05 +0000 (21:37 +0100)] 
:memo: Update release notes

5 years ago:sparkles: Allow callables (as functools.partial) in path operations (#977)
Sebastián Ramírez [Wed, 12 Feb 2020 20:36:14 +0000 (21:36 +0100)] 
:sparkles: Allow callables (as functools.partial) in path operations (#977)

5 years ago:bookmark: Release version 0.48.0 0.48.0
Sebastián Ramírez [Tue, 4 Feb 2020 04:43:07 +0000 (05:43 +0100)] 
:bookmark: Release version 0.48.0

5 years ago:memo: Update release notes
Sebastián Ramírez [Tue, 4 Feb 2020 04:42:12 +0000 (05:42 +0100)] 
:memo: Update release notes

5 years ago:white_check_mark: Lint first in tests, to error out faster (#948)
Sebastián Ramírez [Tue, 4 Feb 2020 04:41:42 +0000 (05:41 +0100)] 
:white_check_mark: Lint first in tests, to error out faster (#948)

5 years ago:mute: Log email-validator not installed only when used (#946)
Sebastián Ramírez [Tue, 4 Feb 2020 04:31:01 +0000 (05:31 +0100)] 
:mute: Log email-validator not installed only when used (#946)

5 years ago:memo: Update Peewee docs, simplify with double dependency with yield (#947)
Sebastián Ramírez [Tue, 4 Feb 2020 04:28:19 +0000 (05:28 +0100)] 
:memo: Update Peewee docs, simplify with double dependency with yield (#947)

5 years ago:memo: Add link: Create and Deploy FastAPI app to Heroku (#942)
नवुले पवन कुमार राव [Tue, 4 Feb 2020 04:25:00 +0000 (09:55 +0530)] 
:memo: Add link: Create and Deploy FastAPI app to Heroku (#942)

5 years ago:memo: Update Sanic description as it is now ASGI too :tada: (#932)
raphaelauv [Tue, 4 Feb 2020 04:14:07 +0000 (05:14 +0100)] 
:memo: Update Sanic description as it is now ASGI too :tada: (#932)

5 years ago:pencil2: Fix typos (#920)
Maciej Marzęta [Tue, 4 Feb 2020 04:04:32 +0000 (05:04 +0100)] 
:pencil2: Fix typos (#920)

5 years ago:bug: Fix body parsing (#918)
David Montague [Tue, 4 Feb 2020 04:01:59 +0000 (20:01 -0800)] 
:bug: Fix body parsing (#918)

5 years ago:pencil2: Fix typo (#916)
adursun [Tue, 4 Feb 2020 03:57:18 +0000 (06:57 +0300)] 
:pencil2: Fix typo (#916)

5 years ago:bug: Allow Any type for enums in OpenAPI (#906)
李冬冬 [Tue, 4 Feb 2020 03:37:47 +0000 (11:37 +0800)] 
:bug: Allow Any type for enums in OpenAPI (#906)

5 years ago:memo: Add article to external links (#901)
Ben [Tue, 4 Feb 2020 03:25:52 +0000 (04:25 +0100)] 
:memo: Add article to external links (#901)

5 years ago:memo: Add note about Body parameters without Pydantic (#900)
Timothée Mazzucotelli [Tue, 4 Feb 2020 03:17:20 +0000 (04:17 +0100)] 
:memo: Add note about Body parameters without Pydantic (#900)

5 years ago:bug: Fix Pydantic field clone logic with validators (#899)
Andy Smith [Tue, 4 Feb 2020 03:03:51 +0000 (22:03 -0500)] 
:bug: Fix Pydantic field clone logic with validators (#899)

5 years ago:bug: Fix middleware docs link (#893)
linchiwei123 [Tue, 4 Feb 2020 02:27:10 +0000 (10:27 +0800)] 
:bug: Fix middleware docs link (#893)

5 years ago:memo: Update release notes
Sebastián Ramírez [Sat, 18 Jan 2020 18:08:24 +0000 (19:08 +0100)] 
:memo: Update release notes

5 years ago:recycle: Update default API title from "Fast API" to "FastAPI" for consistency ...
Sebastián Ramírez [Sat, 18 Jan 2020 18:07:42 +0000 (19:07 +0100)] 
:recycle: Update default API title from "Fast API" to "FastAPI" for consistency (#890)

5 years ago:bookmark: Release version 0.47.1 0.47.1
Sebastián Ramírez [Sat, 18 Jan 2020 17:06:47 +0000 (18:06 +0100)] 
:bookmark: Release version 0.47.1

5 years ago:memo: Update release notes
Sebastián Ramírez [Sat, 18 Jan 2020 17:06:20 +0000 (18:06 +0100)] 
:memo: Update release notes

5 years ago:lock: Fix clone field implementation to handle sub-models in response_model (#889)
Sebastián Ramírez [Sat, 18 Jan 2020 17:03:51 +0000 (18:03 +0100)] 
:lock: Fix clone field implementation to handle sub-models in response_model (#889)

5 years ago:bug: Fix FastAPI serialization of Pydantic ORM mode blocking the event loop (#888)
Sebastián Ramírez [Sat, 18 Jan 2020 16:32:57 +0000 (17:32 +0100)] 
:bug: Fix FastAPI serialization of Pydantic ORM mode blocking the event loop (#888)

5 years ago:bookmark: Release version 0.47.0 0.47.0
Sebastián Ramírez [Sat, 18 Jan 2020 16:14:59 +0000 (17:14 +0100)] 
:bookmark: Release version 0.47.0

5 years ago:memo: Update release notes
Sebastián Ramírez [Sat, 18 Jan 2020 16:14:03 +0000 (17:14 +0100)] 
:memo: Update release notes

5 years ago:memo: Refactor docs, "Tutorial - User Guide" and "Advanced User Guide" (#887)
Sebastián Ramírez [Sat, 18 Jan 2020 15:21:54 +0000 (16:21 +0100)] 
:memo: Refactor docs, "Tutorial - User Guide" and "Advanced User Guide" (#887)

5 years ago:art: Tweak external links, Markdown format, typos (#881)
Sebastián Ramírez [Fri, 17 Jan 2020 15:24:05 +0000 (16:24 +0100)] 
:art: Tweak external links, Markdown format, typos (#881)