Shawn Routhier [Thu, 13 Dec 2012 19:29:35 +0000 (11:29 -0800)]
-n [master]
Clean up ATF issues:
describe patch to ATF code for solaris 11
remove unneeded options for use on solaris 11
comment out unused hash test
[rt32089]
Shawn Routhier [Wed, 28 Nov 2012 21:54:09 +0000 (13:54 -0800)]
[master]
Tidy up dhclient.8 file:
make use of man sections consistent for dhclient.conf, dhclient-script
and dhclient.lease
make port port-number and VAR=val VAR=value
correct desciptionof to description of
[ISC-Bugs #17368]
Shawn Routhier [Mon, 26 Nov 2012 20:14:27 +0000 (12:14 -0800)]
[master]
[rt31231]
Check the status when trying to read from a connection
and don't ask for more if we seem to have a closed
connection.
[ISC-Bugs #31231]
Shawn Routhier [Fri, 16 Nov 2012 23:02:13 +0000 (15:02 -0800)]
[master]
+- Add support for a simple check that the server id in a request message
+ to a failover peer matches the server id of the server. This support
+ is enabled by editing the file includes/site.h and uncommenting the
+ definition for SERVER_ID_CHECK. The option has several restrictions
+ and issues - please read the comment in the site.h file before
+ enabling it.
+ [ISC-Bugs #31463]
Shawn Routhier [Tue, 13 Nov 2012 20:56:02 +0000 (12:56 -0800)]
[master]
The client now passes information about the options it requested
from the server to the script code via environment variables.
These variables are of the form requested_<option_name>=1 with
the option name being the same as used in the new_* and old_*
variables. [ISC-Bugs #29068]
Shawn Routhier [Thu, 11 Oct 2012 21:30:24 +0000 (14:30 -0700)]
[master]
[ISC-Bugs #26108]
Add a compile time option, enable-secs-byteorder, to deal with
clients that do the byte ordering on the secs field incorrectly.
This field should be in network byte order but some clients
get it wrong. When this option is enabled the server will examine
the secs field and if it looks wrong (high byte non zero and low
byte zero) swap the bytes. The default is disabled. This option
is only useful when doing load balancing within failover.
Shawn Routhier [Tue, 9 Oct 2012 21:08:26 +0000 (14:08 -0700)]
[master]
[rt30320]
When processing a failover request with an unexpected name
create an option block the relationship_name instead of using
the one from the incoming message. This avoids problems when
the option is freed.
Also add code to free the relationship_name from the incoming
mesasage when we free the message.
Shawn Routhier [Tue, 9 Oct 2012 20:28:14 +0000 (13:28 -0700)]
[master]
Relax the requirements for deleting an A or AAAA record.
Previously the DDNS removal code required both the A or AAAA
record and the TXT record to exist. This requirement could
cause problems if something interrupted the removal leaving
the TXT record alone. This relaxation was codified in RFC 4703.
[ISC-Bugs #30734]
Shawn Routhier [Fri, 17 Aug 2012 19:05:49 +0000 (12:05 -0700)]
[rt30281]
Modify the renew_lease6() code to properly handle a lease time
that is reduced rather than extended.
Fix the ATF tests for mdb6 and add a new test to check the
above condition.
make check no longer tries to run atf when ATF was not enabled
(make check target does not make much sense with tests disabled,
but it shouldn't fail complaining about missing atf-run)
Shawn Routhier [Mon, 13 Aug 2012 23:22:32 +0000 (16:22 -0700)]
[rt29771]
[rt29770]
[rt29846]
Tidy up man pages, mostly convert a period followed by 1
or 3 spaces to a period followed by 2 spaces. This also
covers tickets 29770 and 29846
Stephen Morris [Wed, 4 Jul 2012 16:06:32 +0000 (17:06 +0100)]
[rt25901_atf] Minor corrections to some files
Minor corrections to some of the atf.dox documentation. Also modified
hash_unitest.c to avoid problems in "printf" (the format string %lu was wrong
for a size_t on my machine, so an explicit cast was made to the correct type).
Shawn Routhier [Wed, 27 Jun 2012 21:33:25 +0000 (21:33 +0000)]
When attempting to convert a DUID from a client id option
into a hardware address handle unexpected client ids properly.
Thanks to Markus Hietava of Codenomicon CROSS project for the
finding this issue and CERT-FI for vulnerability coordination.
[ISC-Bugs #29852]
CVE: CVE-2012-3570
Shawn Routhier [Wed, 27 Jun 2012 21:20:19 +0000 (21:20 +0000)]
Previously the server code was relaxed to allow packets with zero
length client ids to be processed. Under some situations use of
zero length client ids can cause the server to go into an infinite
loop. As such ids are not valid according to RFC 2132 section 9.14
the server no longer accepts them. Client ids with a length of 1
are also invalid but the server still accepts them in order to
minimize disruption. The restriction will likely be tightened in
the future to disallow ids with a length of 1.
Thanks to Markus Hietava of Codenomicon CROSS project for the
finding this issue and CERT-FI for vulnerability coordination.
[ISC-Bugs #29851]
CVE: CVE-2012-3571
Shawn Routhier [Fri, 8 Jun 2012 23:28:11 +0000 (23:28 +0000)]
A problem with missing get_hw_addr function when --enable-use-sockets
was used is now solved on GNU/Linux, BSD and GNU/Hurd systems. Note
that use-sockets feature was not tested on those systems. Client and
server code no longer use MAX_PATH constant that is not defined on
GNU/Hurd systems. [ISC-Bugs 25979]
Shawn Routhier [Wed, 6 Jun 2012 23:55:01 +0000 (23:55 +0000)]
The 'no available billing' log line now also logs the name of the last
matching billing class tried before failing to provide a billing.
ISC-Bugs #21759]
Shawn Routhier [Wed, 6 Jun 2012 22:50:31 +0000 (22:50 +0000)]
Fix some issues in the code for parsing and printing options.
[ISC-Bugs #22625] - properly print options that have several fields
followed by an array of something for example "fIa"
[ISC-Bugs #27289] - properly parse options in declarations that have
several fields followed by an array of something for example "fIa"
[ISC-Bugs #27296] - properly determine if we parsed a 16 or 32 bit
value in evaluate_numeric_expression (extract-int).
[ISC-Bugs #27314] - properly parse a zero length option from
a lease file. Thanks to Marius Tomaschewski from SUSE for the report
and prototype patch for this ticket as well as ticket 27289.
Fix up some issues found by static analysis
A potential memory leak and NULL dereference in omapi.
The use of a boolean test instead of a bitwise test in dst.
[ISC-Bugs #28941]
Fix the NA and PD allocation code to handle the case where a client
provides a preference and the server doesn't have any addresses or
prefixes available. Previoulsy the server ignored the request with
this patch it replies with a NoAddrsAvail or NoPrefixAvai respone.
By default the code performs according to the errata of August 2010
for RFC 3315 section 17.2.2, to enable the previous style see the
seciton on RFC3315_PRE_ERRATA_2010_08 in includes/site.h. This option
may be removed in the future.
Thanks to Jiri Popelka at Red Hat for the patch.
[ISC-Bugs #22676]
Remove unnecessary checks in the lease query code and clean up
several compiler issues (some dereferences of NULL and treating
an int as a boolean).
[ISC-Bugs #26203]