]>
git.ipfire.org Git - thirdparty/pdns.git/log
Remi Gacogne [Mon, 2 May 2022 07:47:55 +0000 (09:47 +0200)]
Merge pull request #11596 from rgacogne/ddist-console-redundant-code
dnsdist: Remove dead code in the console
Remi Gacogne [Sat, 30 Apr 2022 14:39:54 +0000 (16:39 +0200)]
dnsdist: Remove dead code in the console
Reported by Coverity as CID 378254.
Fred Morcos [Sat, 30 Apr 2022 12:01:17 +0000 (14:01 +0200)]
Merge pull request #11590 from fredmorcos/11325-rsa-pem-import-export
RSA PEM import/export
Otto Moerbeek [Fri, 29 Apr 2022 12:17:15 +0000 (14:17 +0200)]
Merge pull request #11589 from omoerbeek/coverity-
20220429
auth: Set of Coverity fixes
Fred Morcos [Fri, 29 Apr 2022 11:25:18 +0000 (13:25 +0200)]
SignerParams PEM contents don't need to be optional anymore
We now always test PEM import/export and we expect any new signers to
implement the necessary methods for that.
Fred Morcos [Wed, 27 Apr 2022 09:45:40 +0000 (11:45 +0200)]
RSA PEM test data
Fred Morcos [Wed, 27 Apr 2022 09:45:35 +0000 (11:45 +0200)]
Formatting
Fred Morcos [Wed, 27 Apr 2022 09:43:42 +0000 (11:43 +0200)]
RSA PEM import
Fred Morcos [Wed, 27 Apr 2022 09:30:46 +0000 (11:30 +0200)]
RSA PEM export
Fred Morcos [Fri, 29 Apr 2022 10:41:14 +0000 (12:41 +0200)]
Merge pull request #11582 from fredmorcos/refactor-test-signers
Refactor signers tests
Otto Moerbeek [Fri, 29 Apr 2022 10:17:35 +0000 (12:17 +0200)]
Use better get(); writen2(); release() idiom
Fred Morcos [Fri, 29 Apr 2022 10:01:51 +0000 (12:01 +0200)]
Add missing include
Fred Morcos [Fri, 29 Apr 2022 09:56:22 +0000 (11:56 +0200)]
Fix signer tests for platforms (i.e. OpenSSL forks) without
Ed25519
Otto Moerbeek [Fri, 29 Apr 2022 09:42:48 +0000 (11:42 +0200)]
Don't leak on exception and another case that needs an annotation
Otto Moerbeek [Fri, 29 Apr 2022 07:45:56 +0000 (09:45 +0200)]
Coverity
1030062 Uninitialized scalar field
Otto Moerbeek [Fri, 29 Apr 2022 07:45:22 +0000 (09:45 +0200)]
Coverity
1401639 Division or modulo by float zero: avoid div by zero
Otto Moerbeek [Fri, 29 Apr 2022 07:43:38 +0000 (09:43 +0200)]
Coverity
1469729 Explicit null dereferenced: bail is SOA isn't set
Otto Moerbeek [Fri, 29 Apr 2022 07:42:36 +0000 (09:42 +0200)]
Coverity
1469730 Explicit null dereferenced: use a default sleep time if sr isn't set
Otto Moerbeek [Fri, 29 Apr 2022 07:41:45 +0000 (09:41 +0200)]
Coverity
1469728 Resource leak by using annotation
Otto Moerbeek [Fri, 29 Apr 2022 07:46:29 +0000 (09:46 +0200)]
Merge pull request #11587 from omoerbeek/rec-outgoing-pb-race
rec: Avoid a race in test code between processing the first query and the priming code
Remi Gacogne [Fri, 29 Apr 2022 07:31:16 +0000 (09:31 +0200)]
Merge pull request #11586 from Y7n05h/doc
dnsdist: fix wrong parameter type in document
Remi Gacogne [Fri, 29 Apr 2022 06:16:35 +0000 (08:16 +0200)]
Merge pull request #11543 from rgacogne/ddist-console-max-size-log
dnsdist: Log when a console message exceeds the maximum size
Remi Gacogne [Fri, 29 Apr 2022 06:13:26 +0000 (08:13 +0200)]
Merge pull request #11578 from rgacogne/ddist-relayed-msg
dnsdist: Include the address of the backend in 'relayed to' messages
Otto Moerbeek [Thu, 28 Apr 2022 11:38:14 +0000 (11:38 +0000)]
Avoid a race in test code between processing the first query and the priming code.
It can happen the root updating houskeeping code has not run yet when
processing the first query. In that case, we do not have root DNSKEY
records in cache. When validating the answer, rec will then go out and
fetch those, so no real issue, apart form the fact that it interferes
with our expected outgoing protobuf messages.
Same make sure the root DNSKEY records are cached before doing the actual
test query.
Y7n05h [Thu, 28 Apr 2022 08:32:07 +0000 (16:32 +0800)]
dnsdist: fix wrong parameter type in document
Signed-off-by: Y7n05h <Y7n05h@protonmail.com>
Fred Morcos [Tue, 26 Apr 2022 13:31:50 +0000 (15:31 +0200)]
Test Ed448 as part of the generic mechanism for testing signers
This also automatically tests a few things that weren't being tested before.
Remi Gacogne [Tue, 26 Apr 2022 12:31:45 +0000 (14:31 +0200)]
Merge pull request #11514 from rgacogne/ddist-api-noauth
dnsdist: Add an option for unauthenticated access to the API
Fred Morcos [Tue, 26 Apr 2022 09:14:07 +0000 (11:14 +0200)]
Avoid using magic numbers for algorithms
Fred Morcos [Tue, 26 Apr 2022 09:07:36 +0000 (11:07 +0200)]
Clean-up signer params
Fred Morcos [Wed, 20 Apr 2022 15:12:18 +0000 (17:12 +0200)]
test-signers: Use boost fixtures and print info about signers/tests
This also prints out information about what signers are available and what tests are
getting enabled. Use the `--log_level=message` argument to the boost `testrunner` to see
that information.
Fred Morcos [Mon, 25 Apr 2022 09:07:27 +0000 (11:07 +0200)]
Lint fixes (consts, boolean conditions)
Remi Gacogne [Tue, 26 Apr 2022 07:54:15 +0000 (09:54 +0200)]
dnsdist: Include the address of the backend in 'relayed to' messages
Not all backends have a name.
Remi Gacogne [Mon, 25 Apr 2022 09:55:48 +0000 (11:55 +0200)]
Merge pull request #11574 from rgacogne/ddist-1.7.1-changelog-secpoll
dnsdist: ChangeLog and secpoll update for dnsdist 1.7.1
Remi Gacogne [Mon, 25 Apr 2022 09:18:50 +0000 (11:18 +0200)]
dnsdist: Hopefully we will release 1.7.1 today
Fred Morcos [Mon, 25 Apr 2022 09:07:13 +0000 (11:07 +0200)]
Formatting
Peter van Dijk [Mon, 25 Apr 2022 08:26:51 +0000 (10:26 +0200)]
Merge pull request #11493 from fredmorcos/11325-eddsa-import-export-pem
Support PEM import and export of EdDSA keys
Peter van Dijk [Mon, 25 Apr 2022 07:59:08 +0000 (09:59 +0200)]
Merge pull request #11562 from fredmorcos/find-libdecaf-headers
Try harder to find libdecaf headers
Remi Gacogne [Mon, 25 Apr 2022 07:48:29 +0000 (09:48 +0200)]
Merge pull request #11573 from rgacogne/ddist-no-downstream
dnsdist: Better log message when no downstream server are available
Remi Gacogne [Fri, 22 Apr 2022 13:27:37 +0000 (15:27 +0200)]
dnsdist: ChangeLog and secpoll update for dnsdist 1.7.1
Otto Moerbeek [Fri, 22 Apr 2022 11:57:24 +0000 (13:57 +0200)]
Merge pull request #11570 from omoerbeek/rec-codeql-j4
rec: Reduce make -j parameter from 8 to 4 for CodeQL action, as dnsdist does.
Remi Gacogne [Fri, 22 Apr 2022 11:51:51 +0000 (13:51 +0200)]
dnsdist: Better log message when no downstream server are available
Otto Moerbeek [Fri, 22 Apr 2022 09:02:12 +0000 (11:02 +0200)]
Reduce make -j parameter from 8 to 4, as dnsdist does.
This might fix the occasional build issues with the CodeQL GH Action.
Remi Gacogne [Thu, 21 Apr 2022 08:41:42 +0000 (10:41 +0200)]
Merge pull request #11565 from rgacogne/ddist-fix-ebpf-qnames
dnsdist: Fix wrong eBPF values (qtype, counter) being inserted for qnames
Remi Gacogne [Thu, 21 Apr 2022 08:41:24 +0000 (10:41 +0200)]
Merge pull request #11544 from rgacogne/ddist-bpf-block-action
dnsdist: Properly use eBPF when the DynBlock is not set
Remi Gacogne [Thu, 21 Apr 2022 08:40:54 +0000 (10:40 +0200)]
Merge pull request #11547 from rgacogne/ddist-add-address-accessor-to-frontends
dnsdist: Add a 'getAddressAndPort()' method to DOHFrontend and TLSFrontend objects
Remi Gacogne [Thu, 21 Apr 2022 08:40:37 +0000 (10:40 +0200)]
Merge pull request #11545 from rgacogne/ddist-fix-backend-proto
dnsdist: Use the correct outgoing protocol in our ring buffers
Otto Moerbeek [Wed, 20 Apr 2022 14:25:28 +0000 (16:25 +0200)]
Merge pull request #11561 from omoerbeek/dnsdist-include-openbsd
dnsdist: include <unordered_map>
Remi Gacogne [Wed, 20 Apr 2022 12:32:14 +0000 (14:32 +0200)]
dnsdist: Fix wrong eBPF values (qtype, counter) being inserted for qnames
Fred Morcos [Wed, 20 Apr 2022 07:58:05 +0000 (09:58 +0200)]
Headers in /usr/local/include/decaf are now automatically detected
Fred Morcos [Fri, 15 Apr 2022 15:21:51 +0000 (17:21 +0200)]
Add autoconf checks for libdecaf headers
This adds a few things:
- Passing a user-defined header location through LIBDECAF_CFLAGS=-I...
- Otherwise, check the following directories for decaf.hxx:
- /usr/include
- /usr/include/decaf
- Add whichever one is picked to LIBDECAF_CFLAGS
- Then AC_CHECK_HEADER decaf.hxx using CXXFLAGS with LIBDECAF_CFLAGS
The reason for this change is that some package systems have decaf.hxx
under /usr/include and others have it under /usr/include/decaf.
Fred Morcos [Fri, 15 Apr 2022 15:21:32 +0000 (17:21 +0200)]
Whitespace
Fred Morcos [Thu, 14 Apr 2022 12:42:31 +0000 (14:42 +0200)]
Reimpl sodium
ed25519 sign & verify using the simpler detached mode
Fred Morcos [Thu, 14 Apr 2022 12:41:58 +0000 (14:41 +0200)]
Libsodium expects the pub key concatenated to the secret key buffer
Fred Morcos [Thu, 14 Apr 2022 12:41:07 +0000 (14:41 +0200)]
Print data in base64 for better debugging experience when tests fail
Fred Morcos [Mon, 11 Apr 2022 13:24:33 +0000 (15:24 +0200)]
Formatting
Fred Morcos [Mon, 11 Apr 2022 13:23:08 +0000 (15:23 +0200)]
Cleanup
Fred Morcos [Fri, 8 Apr 2022 12:32:22 +0000 (14:32 +0200)]
Libdecaf impl of Ed448 PEM import and export
Fred Morcos [Fri, 8 Apr 2022 12:20:55 +0000 (14:20 +0200)]
Libdecaf impl of
Ed25519 PEM import and export
Fred Morcos [Thu, 7 Apr 2022 12:59:49 +0000 (14:59 +0200)]
Guard libsodium PEM methods with libcrypto
These methods depend on OpenSSL for PEM import and export.
Fred Morcos [Fri, 1 Apr 2022 10:14:16 +0000 (12:14 +0200)]
Sodium impl of EDDSA PEM import
Fred Morcos [Fri, 1 Apr 2022 08:21:09 +0000 (10:21 +0200)]
OpenSSL impl of EDDSA PEM import
Fred Morcos [Fri, 1 Apr 2022 08:20:46 +0000 (10:20 +0200)]
Test data for EDDSA PEM import and export
Fred Morcos [Wed, 30 Mar 2022 08:39:03 +0000 (10:39 +0200)]
Sodium impl of EDDSA PEM export
There's no real way to serialize keys in Sodium, so we fall-back to
using OpenSSL which is available in our Sodium-based builds.
Fred Morcos [Tue, 29 Mar 2022 09:55:16 +0000 (11:55 +0200)]
Cleanup: Unused local storage
Fred Morcos [Tue, 29 Mar 2022 09:24:30 +0000 (11:24 +0200)]
OpenSSL impl of EDDSA PEM export
Fred Morcos [Tue, 29 Mar 2022 08:17:00 +0000 (10:17 +0200)]
Whitespace
Peter van Dijk [Wed, 20 Apr 2022 10:27:39 +0000 (12:27 +0200)]
Merge pull request #11564 from Habbie/circleci-docs-no-texlive
circleci: revert docs build to specific debian image, instead of the debian:testing underlying the texlive image
Peter van Dijk [Wed, 20 Apr 2022 08:31:12 +0000 (10:31 +0200)]
revert docs build to specific debian image, instead of the debian:testing underlying the texlive image
Otto Moerbeek [Tue, 19 Apr 2022 14:50:08 +0000 (16:50 +0200)]
Include <unordered_map>
On OpenBSD you don't get std::unordered_map for free
Otto Moerbeek [Tue, 19 Apr 2022 09:19:39 +0000 (11:19 +0200)]
Merge pull request #11541 from omoerbeek/rec-fix-dot-probe
Fix DoT port, as noted by ph1 on IRC
Otto Moerbeek [Tue, 19 Apr 2022 07:57:23 +0000 (09:57 +0200)]
Decide to use Dot earlier.
To keep the nsspeed table good, we need to decide to use DoT earlier.
Now the lookup and updats of the speed table occur in a proper way
(using the port that is actually used for the connetion) and when
we switch from/to DoT, the old nsspeeds are cleared by the already
existing code.
Remi Gacogne [Tue, 19 Apr 2022 07:31:03 +0000 (09:31 +0200)]
Merge pull request #11546 from rgacogne/ddist-fix-0-sized-cache
dnsdist: Raise the number of entries in a packet cache to at least 1
Remi Gacogne [Tue, 19 Apr 2022 07:30:53 +0000 (09:30 +0200)]
Merge pull request #11539 from rgacogne/rec-fix-dnssec-counters-documentation
rec: DNSSEC counters track responses sent, not actual validations performed
Remi Gacogne [Fri, 15 Apr 2022 15:18:59 +0000 (17:18 +0200)]
Merge pull request #11535 from Y7n05h/MergeParams
Merge multiple parameters in newBPFFilter
Remi Gacogne [Fri, 15 Apr 2022 15:18:45 +0000 (17:18 +0200)]
Update pdns/dnsdistdist/docs/reference/ebpf.rst
Remi Gacogne [Fri, 15 Apr 2022 12:21:57 +0000 (14:21 +0200)]
dnsdist: Fix formatting
Remi Gacogne [Fri, 15 Apr 2022 10:57:53 +0000 (12:57 +0200)]
dnsdist: Add a 'getAddressAndPort()' method to DOHFrontend and TLSFrontend objects
Remi Gacogne [Fri, 15 Apr 2022 10:46:44 +0000 (12:46 +0200)]
dnsdist: Raise the number of entries in a packet cache to at least 1
And make sure that we cannot create such an object.
Remi Gacogne [Fri, 15 Apr 2022 10:35:20 +0000 (12:35 +0200)]
dnsdist: Use the correct outgoing protocol in our ring buffers
Remi Gacogne [Fri, 15 Apr 2022 10:19:46 +0000 (12:19 +0200)]
dnsdist: Properly use eBPF when the DynBlock is not set
When the DynBlock rule does not set a specific action we use the
default one, set with `setDynBlocksAction()`, so we should follow
the same logic when determining whether to insert an eBPF block.
Y7n05h [Fri, 15 Apr 2022 09:27:23 +0000 (17:27 +0800)]
fix d_type in MapConfiguration
Remi Gacogne [Fri, 15 Apr 2022 09:15:02 +0000 (11:15 +0200)]
rec: Fix DNSSEC counters description in web/prometheus as well
Y7n05h [Fri, 15 Apr 2022 08:46:13 +0000 (16:46 +0800)]
fix errer key in access convertParamsToConfig
Signed-off-by: Y7n05h <Y7n05h@protonmail.com>
Remi Gacogne [Fri, 15 Apr 2022 08:38:08 +0000 (10:38 +0200)]
dnsdist: Prevent leaking the console's socket descriptors
I don't see any case where that could happen but better wrap the
socket descriptors in FDWrapper objects so that we cannot forget to
close them if an exception is raised, for example.
Remi Gacogne [Fri, 15 Apr 2022 08:34:44 +0000 (10:34 +0200)]
dnsdist: Log when a console message exceeds the maximum size
Otherwise one cannot know whether the server has closed the connection
or sent a too large message.
Otto Moerbeek [Thu, 14 Apr 2022 19:36:47 +0000 (21:36 +0200)]
Missing newline in dump output, noted by ph1
Otto Moerbeek [Thu, 14 Apr 2022 17:44:06 +0000 (19:44 +0200)]
Fix port, as noted by ph1 on IRC
Without this, probed DoT actually becomes regular TCP.
Y7n05h [Thu, 14 Apr 2022 15:26:22 +0000 (23:26 +0800)]
Update pdns/dnsdistdist/docs/reference/ebpf.rst
Co-authored-by: Remi Gacogne <github@coredump.fr>
Remi Gacogne [Thu, 14 Apr 2022 15:20:15 +0000 (17:20 +0200)]
rec: DNSSEC counters track responses sent, not actual validations performed
Since 4.1 these counters are updated for every response sent, even if the DNSSEC
status was fetched from the records cache and did not involve any actual
validation.
Y7n05h [Thu, 14 Apr 2022 15:25:41 +0000 (23:25 +0800)]
Update pdns/dnsdistdist/docs/reference/ebpf.rst
Co-authored-by: Remi Gacogne <github@coredump.fr>
Otto Moerbeek [Thu, 14 Apr 2022 14:24:13 +0000 (16:24 +0200)]
Merge pull request #11381 from omoerbeek/rec-dynamic-root-refresh-period
rec: Adaptive root refresh interval, normally at 80% of max-cache-ttl
Y7n05h [Thu, 14 Apr 2022 12:40:57 +0000 (20:40 +0800)]
Update document
Y7n05h [Thu, 14 Apr 2022 12:36:11 +0000 (20:36 +0800)]
Simplify the parameters of newBPFFilter
Peter van Dijk [Thu, 14 Apr 2022 12:52:41 +0000 (14:52 +0200)]
Merge pull request #11518 from fredmorcos/add-libdecaf-to-github-actions
Add libdecaf (auth) tests to Github Actions
Otto Moerbeek [Thu, 14 Apr 2022 12:24:27 +0000 (14:24 +0200)]
Refer to new root hint handling info from settings docs
Otto Moerbeek [Thu, 14 Apr 2022 12:26:25 +0000 (14:26 +0200)]
Merge pull request #11527 from omoerbeek/prep-rec-4.7.0-beta1
rec: Prep for rec-4.7.0-beta1
Y7n05h [Thu, 14 Apr 2022 09:58:17 +0000 (17:58 +0800)]
Update pdns/dnsdistdist/docs/reference/ebpf.rst
Co-authored-by: Remi Gacogne <github@coredump.fr>
Y7n05h [Thu, 14 Apr 2022 09:57:29 +0000 (17:57 +0800)]
Update pdns/dnsdist-lua-bindings.cc
Co-authored-by: Remi Gacogne <github@coredump.fr>
Otto Moerbeek [Thu, 14 Apr 2022 11:03:15 +0000 (13:03 +0200)]
Document more details of root-hints handling
Otto Moerbeek [Thu, 14 Apr 2022 10:21:01 +0000 (12:21 +0200)]
Merge pull request #11536 from omoerbeek/rec-nitems
Fix Coverity
1487923 Out-of-bounds read (wrong use of sizeof)