]> git.ipfire.org Git - thirdparty/pdns.git/log
thirdparty/pdns.git
3 years agoMerge pull request #10081 from pieterlexis/issue-7203-pdnsutil-load-zone
Peter van Dijk [Wed, 17 Feb 2021 14:27:34 +0000 (15:27 +0100)] 
Merge pull request #10081 from pieterlexis/issue-7203-pdnsutil-load-zone

pdnsutil load-zone: reject zones with broken rrs

3 years agoMerge pull request #10083 from omoerbeek/rec-doc-trace-fail
Peter van Dijk [Wed, 17 Feb 2021 14:25:50 +0000 (15:25 +0100)] 
Merge pull request #10083 from omoerbeek/rec-doc-trace-fail

rec: Document trace=fail better and warn against its shortcomings.

3 years agoMerge pull request #10087 from pieterlexis/check-MX-to-CNAME
Peter van Dijk [Wed, 17 Feb 2021 14:24:56 +0000 (15:24 +0100)] 
Merge pull request #10087 from pieterlexis/check-MX-to-CNAME

pdnsutil: Warn on CNAME targets for NS, MX and SRV

3 years agoMerge pull request #10094 from Habbie/speedtest-nsec3
Peter van Dijk [Wed, 17 Feb 2021 14:22:40 +0000 (15:22 +0100)] 
Merge pull request #10094 from Habbie/speedtest-nsec3

speedtest: add NSEC3 hashing test

3 years agoMerge pull request #10095 from rgacogne/ddist-fix-crash-dbpf-console
Remi Gacogne [Wed, 17 Feb 2021 10:49:42 +0000 (11:49 +0100)] 
Merge pull request #10095 from rgacogne/ddist-fix-crash-dbpf-console

dnsdist: Prevent a crash with DynBPF objects in client mode

3 years agoMerge pull request #10092 from omoerbeek/docs-server-proxy
Otto Moerbeek [Wed, 17 Feb 2021 10:19:45 +0000 (11:19 +0100)] 
Merge pull request #10092 from omoerbeek/docs-server-proxy

docs: Avoid some confusion about server objects

3 years agofix Makefile _SOURCES order 10094/head
Peter van Dijk [Wed, 17 Feb 2021 09:52:31 +0000 (10:52 +0100)] 
fix Makefile _SOURCES order

3 years agospeedtest: fix compiler warnings
Peter van Dijk [Wed, 17 Feb 2021 09:41:26 +0000 (10:41 +0100)] 
speedtest: fix compiler warnings

3 years agospeedtest: add NSEC3 hashing test
Peter van Dijk [Wed, 17 Feb 2021 09:39:12 +0000 (10:39 +0100)] 
speedtest: add NSEC3 hashing test

3 years agodnsdist: Prevent a crash with DynBPF objects in client mode 10095/head
Remi Gacogne [Wed, 17 Feb 2021 09:38:58 +0000 (10:38 +0100)] 
dnsdist: Prevent a crash with DynBPF objects in client mode

3 years agoQuoting 10092/head
Otto Moerbeek [Wed, 17 Feb 2021 08:00:45 +0000 (09:00 +0100)] 
Quoting

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
3 years agospelling
Otto Moerbeek [Wed, 17 Feb 2021 07:58:58 +0000 (08:58 +0100)] 
spelling

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
3 years agoAvoid some confusion about server objects
Otto [Wed, 17 Feb 2021 07:55:08 +0000 (08:55 +0100)] 
Avoid some confusion about server objects

3 years agoMerge pull request #10088 from rgacogne/ddist-start-tcp-workers-before-acceptors
Remi Gacogne [Tue, 16 Feb 2021 14:55:19 +0000 (15:55 +0100)] 
Merge pull request #10088 from rgacogne/ddist-start-tcp-workers-before-acceptors

dnsdist: Create TCP worker threads before acceptors ones

3 years agoMerge pull request #10053 from aerique/feature/python-repo-script
aerique [Tue, 16 Feb 2021 14:28:58 +0000 (15:28 +0100)] 
Merge pull request #10053 from aerique/feature/python-repo-script

Replace shell-based repo test script with a Python version

3 years agoMerge pull request #9468 from omoerbeek/rec-control-pass-fd
Otto Moerbeek [Tue, 16 Feb 2021 12:27:27 +0000 (13:27 +0100)] 
Merge pull request #9468 from omoerbeek/rec-control-pass-fd

rec: Rec control pass fd

3 years agoWrap the fd so it will be closed automatically 9468/head
Otto [Tue, 16 Feb 2021 11:22:15 +0000 (12:22 +0100)] 
Wrap the fd so it will be closed automatically

3 years agoPython version of repo test script. 10053/head
Erik Winkels [Wed, 3 Feb 2021 21:18:24 +0000 (22:18 +0100)] 
Python version of repo test script.

This replaces the Bourne shell version.

3 years agopdnsutil: Warn on CNAME targets for NS, MX and SRV 10087/head
Pieter Lexis [Tue, 16 Feb 2021 07:37:50 +0000 (08:37 +0100)] 
pdnsutil: Warn on CNAME targets for NS, MX and SRV

Fixes #10085

3 years agodnsdist: Create TCP worker threads before acceptors ones 10088/head
Remi Gacogne [Tue, 16 Feb 2021 10:43:40 +0000 (11:43 +0100)] 
dnsdist: Create TCP worker threads before acceptors ones

Otherwise we might crash when the first TCP query arrives because
we are dividing by zero when trying to select a worker.

3 years agoMerge pull request #10075 from omoerbeek/rec-setting-ecs-never-cache
Otto Moerbeek [Tue, 16 Feb 2021 10:22:48 +0000 (11:22 +0100)] 
Merge pull request #10075 from omoerbeek/rec-setting-ecs-never-cache

rec: Introduce settings to never cache EDNS Client (v4/v6) Subnet carrying replies

3 years agoApply suggestions from code review 10075/head
Otto Moerbeek [Tue, 16 Feb 2021 09:13:09 +0000 (10:13 +0100)] 
Apply suggestions from code review

Co-authored-by: Remi Gacogne <rgacogne+github@valombre.net>
3 years agoActually define the two new args
Otto [Wed, 10 Feb 2021 15:40:22 +0000 (16:40 +0100)] 
Actually define the two new args

3 years agoIntroduce settings to never cache EDNS Client (v4/v6) Subnet carrying replies.
Otto [Wed, 10 Feb 2021 09:57:36 +0000 (10:57 +0100)] 
Introduce settings to never cache EDNS Client (v4/v6) Subnet carrying replies.

While there, add a few entries to the upgrade guide.

3 years agoMerge pull request #10086 from jsoref/pip-wheel
Peter van Dijk [Tue, 16 Feb 2021 07:48:52 +0000 (08:48 +0100)] 
Merge pull request #10086 from jsoref/pip-wheel

Add wheel to pip

3 years agoAdd wheel to pip 10086/head
Josh Soref [Tue, 16 Feb 2021 03:53:49 +0000 (22:53 -0500)] 
Add wheel to pip

3 years agoDocument trace=fail better and warn against its shortcomings. 10083/head
Otto [Mon, 15 Feb 2021 14:35:33 +0000 (15:35 +0100)] 
Document trace=fail better and warn against its shortcomings.

3 years agoMerge pull request #10082 from pieterlexis/issue-8517-LUA-record-split
Pieter Lexis [Mon, 15 Feb 2021 11:26:33 +0000 (12:26 +0100)] 
Merge pull request #10082 from pieterlexis/issue-8517-LUA-record-split

docs: notes on LUA record splitting

3 years agoAdd a general note to the manpage on how file handling is changed.
Otto [Mon, 15 Feb 2021 11:06:24 +0000 (12:06 +0100)] 
Add a general note to the manpage on how file handling is changed.

Also, remove the snippets about where the files are written in
case of chroot for each file-writing command.

3 years agoAlLow - for stdout, does need a tweak in the argument parser...
Otto [Mon, 15 Feb 2021 10:42:10 +0000 (11:42 +0100)] 
AlLow - for stdout, does need a tweak in the argument parser...

3 years agoHandle all commands that dump to file
Otto [Mon, 15 Feb 2021 10:25:19 +0000 (11:25 +0100)] 
Handle all commands that dump to file

3 years agoApply suggestions from code review 10082/head
Pieter Lexis [Mon, 15 Feb 2021 09:05:57 +0000 (10:05 +0100)] 
Apply suggestions from code review

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
3 years agodocs: notes on LUA record splitting
Pieter Lexis [Mon, 15 Feb 2021 09:00:32 +0000 (10:00 +0100)] 
docs: notes on LUA record splitting

3 years agoProcess review comments; most importantly a separate type for
Otto [Mon, 15 Feb 2021 08:55:27 +0000 (09:55 +0100)] 
Process review comments; most importantly a separate type for
RecursorControlChannel::Answer

3 years agoMerge pull request #10073 from rgacogne/ddist-spoof-multiple-from-lua
Remi Gacogne [Mon, 15 Feb 2021 08:23:41 +0000 (09:23 +0100)] 
Merge pull request #10073 from rgacogne/ddist-spoof-multiple-from-lua

dnsdist: Add 'spoof' and 'spoofRaw' Lua bindings

3 years agopdnsutil load-zone: reject zones with broken rrs 10081/head
Pieter Lexis [Mon, 15 Feb 2021 08:23:01 +0000 (09:23 +0100)] 
pdnsutil load-zone: reject zones with broken rrs

3 years agoReturn command status and output as two separate items
Otto Moerbeek [Fri, 18 Dec 2020 10:49:47 +0000 (11:49 +0100)] 
Return command status and output as two separate items

3 years agodump-cache x is two args, not one
Otto Moerbeek [Mon, 14 Sep 2020 13:28:48 +0000 (15:28 +0200)] 
dump-cache x is two args, not one

3 years agoAllow dump-cache stdout
Otto Moerbeek [Mon, 14 Sep 2020 12:46:03 +0000 (14:46 +0200)] 
Allow dump-cache stdout
(a hyphen does not work due to the "funny" command line parser)

3 years agoOpen file in rec_control
Otto Moerbeek [Mon, 14 Sep 2020 12:40:40 +0000 (14:40 +0200)] 
Open file in rec_control

3 years agoRough draft of fd passing for rec_control
Otto Moerbeek [Mon, 14 Sep 2020 08:14:41 +0000 (10:14 +0200)] 
Rough draft of fd passing for rec_control

3 years agoMerge pull request #10076 from omoerbeek/rec-docs-dnsname
Pieter Lexis [Fri, 12 Feb 2021 09:06:02 +0000 (10:06 +0100)] 
Merge pull request #10076 from omoerbeek/rec-docs-dnsname

rec: Take the DNSName docs from auth, they are more complete

3 years agoMerge pull request #9 from AntagonistHQ/ddist-spoof-multiple-from-lua 10073/head
Remi Gacogne [Thu, 11 Feb 2021 15:16:09 +0000 (16:16 +0100)] 
Merge pull request #9 from AntagonistHQ/ddist-spoof-multiple-from-lua

dnsdist: add documentation about DNSQuestion:spoof

3 years agodnsdist: add documentation about DNSQuestion:spoof
Sander Hoentjen [Thu, 11 Feb 2021 15:05:44 +0000 (16:05 +0100)] 
dnsdist: add documentation about DNSQuestion:spoof

3 years agoMerge pull request #10077 from omoerbeek/rec-spoof-nearmiss-max-default
Otto Moerbeek [Wed, 10 Feb 2021 16:02:03 +0000 (17:02 +0100)] 
Merge pull request #10077 from omoerbeek/rec-spoof-nearmiss-max-default

Change spoof-nearmiss-max default to 1.

3 years agoMerge pull request #9819 from omoerbeek/better-qtype
Otto Moerbeek [Wed, 10 Feb 2021 14:53:18 +0000 (15:53 +0100)] 
Merge pull request #9819 from omoerbeek/better-qtype

Improve the way QType behaves by defining proper conversion operators and a hash function.

3 years agoUpdate pdns/recursordist/docs/settings.rst 10077/head
Otto Moerbeek [Wed, 10 Feb 2021 14:14:04 +0000 (15:14 +0100)] 
Update pdns/recursordist/docs/settings.rst

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
3 years agoChange spoof-nearmiss-max default to 1.
Otto [Wed, 10 Feb 2021 14:10:18 +0000 (15:10 +0100)] 
Change spoof-nearmiss-max default to 1.

Fixes #9845.

3 years agoTake the DNSName docs from auth, they are more complete. 10076/head
Otto [Wed, 10 Feb 2021 13:55:54 +0000 (14:55 +0100)] 
Take the DNSName docs from auth, they are more complete.

We really should be having one source for all common Lua docs.
Fixes #9608.

3 years agoAlso convert te recursor cache, adding the needed hash function for boost 9819/head
Otto Moerbeek [Tue, 8 Dec 2020 10:29:39 +0000 (11:29 +0100)] 
Also convert te recursor cache, adding the needed hash function for boost

3 years agoKeep const QType in definitions and introduce a nicer way to build
Otto Moerbeek [Mon, 7 Dec 2020 10:10:27 +0000 (11:10 +0100)] 
Keep const QType in definitions and introduce a nicer way to build
the name to number mapping and vice versa.

3 years agoSimplify boilerplates a bit by deriving the QType from the RNAME by using
Otto Moerbeek [Fri, 4 Dec 2020 17:22:41 +0000 (18:22 +0100)] 
Simplify boilerplates a bit by deriving the QType from the RNAME by using
QType::RNAME, enforcing that one must exist.

3 years agoImprove the way QType behaves by defining proper conversion
Otto Moerbeek [Fri, 4 Dec 2020 15:31:33 +0000 (16:31 +0100)] 
Improve the way QType behaves by defining proper conversion
operators and a hash function.

I converted syncres.* for starters to stop using uint16_t for qtype
and use QType everywhere.  Note that I also changed const QType&
in arg lists by QType, since it makes little sense to pass a 16 bit
value by const reference.

3 years agoMerge pull request #10022 from omoerbeek/rec-missing-prometheus-entries
Otto Moerbeek [Wed, 10 Feb 2021 07:22:45 +0000 (08:22 +0100)] 
Merge pull request #10022 from omoerbeek/rec-missing-prometheus-entries

rec: Move prometheus table to web server and add missing entries.

3 years agoMerge pull request #8 from AntagonistHQ/ddist-spoof-multiple-from-lua
Remi Gacogne [Tue, 9 Feb 2021 17:58:12 +0000 (18:58 +0100)] 
Merge pull request #8 from AntagonistHQ/ddist-spoof-multiple-from-lua

Merge dq:spoof and dq:spoofRaw and add regression tests for dq:spoof

3 years agoMerge dq:spoof and dq:spoofRaw and add regression tests for dq:spoof
Sander Hoentjen [Tue, 9 Feb 2021 16:19:40 +0000 (17:19 +0100)] 
Merge dq:spoof and dq:spoofRaw and add regression tests for dq:spoof

3 years agodnsdist: Add 'spoof' and 'spoofRaw' Lua bindings
Remi Gacogne [Tue, 9 Feb 2021 13:50:23 +0000 (14:50 +0100)] 
dnsdist: Add 'spoof' and 'spoofRaw' Lua bindings

This commits makes it possible to spoof multiple values from Lua:

```
function myfunc(dq)
  local ret = { newCA("192.0.2.1"), newCA("192.0.2.2") }
  dq:spoof(ret)
  return DNSAction.HeaderModify
end

addAction(AllRule(), LuaAction(myfunc))
```

Barely tested, need tests and documentation.

3 years agoMerge pull request #10063 from AntagonistHQ/spoof_multi
Remi Gacogne [Tue, 9 Feb 2021 13:28:55 +0000 (14:28 +0100)] 
Merge pull request #10063 from AntagonistHQ/spoof_multi

dnsdist: Add option to spoofRawAction to spoof multiple answers

3 years agoMerge pull request #10005 from Habbie/auth-4.4.1-docs
Peter van Dijk [Mon, 8 Feb 2021 11:03:48 +0000 (12:03 +0100)] 
Merge pull request #10005 from Habbie/auth-4.4.1-docs

changelog&secpoll for auth-4.4.1

3 years agoMerge pull request #8813 from RobinGeuze/checkForDuplicateMetadata
Peter van Dijk [Mon, 8 Feb 2021 10:45:48 +0000 (11:45 +0100)] 
Merge pull request #8813 from RobinGeuze/checkForDuplicateMetadata

Make check-zone also check whether there are duplicate key value pair metadatas for the zone

3 years agoMerge pull request #10070 from omoerbeek/clang-tidy-followup
Otto Moerbeek [Mon, 8 Feb 2021 10:03:06 +0000 (11:03 +0100)] 
Merge pull request #10070 from omoerbeek/clang-tidy-followup

rename a few `d_*` locals

3 years agoDo an exact comapre, since set.count can only return 0 or 1 8813/head
Robin Geuze [Wed, 12 Aug 2020 15:17:35 +0000 (17:17 +0200)] 
Do an exact comapre, since set.count can only return 0 or 1

3 years agoUpdate pdns/pdnsutil.cc
RobinGeuze [Wed, 12 Aug 2020 15:14:32 +0000 (17:14 +0200)] 
Update pdns/pdnsutil.cc

Accept textual change

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
3 years agoMake check-zone also check whether there are duplicate key value pair domaindatas...
Robin Geuze [Tue, 11 Feb 2020 17:05:09 +0000 (18:05 +0100)] 
Make check-zone also check whether there are duplicate key value pair domaindatas for the zone

3 years agoadd last two PRs and update date 10005/head
Peter van Dijk [Sat, 6 Feb 2021 21:49:02 +0000 (22:49 +0100)] 
add last two PRs and update date

3 years agoauth-4.4.1 changelog: add #10039
Peter van Dijk [Tue, 2 Feb 2021 14:24:26 +0000 (15:24 +0100)] 
auth-4.4.1 changelog: add #10039

3 years agospelling
Peter van Dijk [Mon, 25 Jan 2021 10:30:06 +0000 (11:30 +0100)] 
spelling

3 years agofix pullreq links in auth-4.4.0 docs
Peter van Dijk [Mon, 25 Jan 2021 10:26:16 +0000 (11:26 +0100)] 
fix pullreq links in auth-4.4.0 docs

3 years agochangelog&secpoll for auth-4.4.1
Peter van Dijk [Mon, 25 Jan 2021 10:25:43 +0000 (11:25 +0100)] 
changelog&secpoll for auth-4.4.1

3 years agoMerge pull request #10068 from Habbie/no-more-yum
Peter van Dijk [Mon, 8 Feb 2021 08:55:11 +0000 (09:55 +0100)] 
Merge pull request #10068 from Habbie/no-more-yum

docker builds: stop using yum on EL8 derivatives

3 years agoMerge pull request #10016 from Habbie/builder-archs
Peter van Dijk [Mon, 8 Feb 2021 08:34:31 +0000 (09:34 +0100)] 
Merge pull request #10016 from Habbie/builder-archs

builder: add arch-specific targets

3 years agoMerge pull request #10064 from omoerbeek/rec-fix-empty-cname-followup
Otto Moerbeek [Mon, 8 Feb 2021 08:33:25 +0000 (09:33 +0100)] 
Merge pull request #10064 from omoerbeek/rec-fix-empty-cname-followup

rec: Return current rcode instead of 0 if there are no CNAME records to follow

3 years agosome d_* locals 10070/head
Otto [Mon, 8 Feb 2021 08:31:20 +0000 (09:31 +0100)] 
some d_* locals

3 years agoMerge pull request #9672 from neheb/clng
Otto Moerbeek [Mon, 8 Feb 2021 08:16:22 +0000 (09:16 +0100)] 
Merge pull request #9672 from neheb/clng

clang-tidy fixes

3 years agodnf install yum so Dockerfile.rpmbuild can stay simple 10068/head
Peter van Dijk [Sun, 7 Feb 2021 19:46:53 +0000 (20:46 +0100)] 
dnf install yum so Dockerfile.rpmbuild can stay simple

3 years agoMerge pull request #10069 from mnordhoff/dns-over-https-colon-colon
Remi Gacogne [Sun, 7 Feb 2021 17:38:40 +0000 (18:38 +0100)] 
Merge pull request #10069 from mnordhoff/dns-over-https-colon-colon

dnsdist docs: Fix formatting of response map example

3 years agodnsdist docs: Fix formatting of response map example 10069/head
Matt Nordhoff [Sun, 7 Feb 2021 17:18:27 +0000 (17:18 +0000)] 
dnsdist docs: Fix formatting of response map example

3 years agodocker builds: stop using yum on EL8 derivatives
Peter van Dijk [Sun, 7 Feb 2021 13:53:45 +0000 (14:53 +0100)] 
docker builds: stop using yum on EL8 derivatives

3 years agoMerge pull request #10007 from mind04/auth-tcp-counters
Peter van Dijk [Fri, 5 Feb 2021 21:13:08 +0000 (22:13 +0100)] 
Merge pull request #10007 from mind04/auth-tcp-counters

auth: fix tcp answer counters

3 years agoMerge pull request #10029 from Habbie/actions-docker
Pieter Lexis [Fri, 5 Feb 2021 16:05:51 +0000 (17:05 +0100)] 
Merge pull request #10029 from Habbie/actions-docker

gh actions: build Docker images

3 years agoAnother missed one 9672/head
Otto [Fri, 5 Feb 2021 15:44:43 +0000 (16:44 +0100)] 
Another missed one

3 years agoMerge pull request #10060 from omoerbeek/sdig-add-dot
Otto Moerbeek [Fri, 5 Feb 2021 15:43:32 +0000 (16:43 +0100)] 
Merge pull request #10060 from omoerbeek/sdig-add-dot

sdig: add DoT

3 years agoReturn current rcode instead of 0 if there are no CNAME records to follow. 10064/head
Otto [Fri, 5 Feb 2021 15:18:55 +0000 (16:18 +0100)] 
Return current rcode instead of 0 if there are no CNAME records to follow.

Note that this is a change in behaviour. While it is for the good, it might
be existing code depends on the old 0 value...

3 years agoMissed a few locals starting with d_
Otto [Fri, 5 Feb 2021 15:03:58 +0000 (16:03 +0100)] 
Missed a few locals starting with d_

3 years agoCatch exception on stats entries init and exit on that 10022/head
Otto [Fri, 5 Feb 2021 15:00:33 +0000 (16:00 +0100)] 
Catch exception on stats entries init and exit on that

3 years agoMerge pull request #10036 from rgacogne/rec-asan-null-stack
Otto Moerbeek [Fri, 5 Feb 2021 14:41:05 +0000 (15:41 +0100)] 
Merge pull request #10036 from rgacogne/rec-asan-null-stack

rec: Set the start of the stack right away to avoid an ASAN issue

3 years agogh actions: build Docker images 10029/head
Peter van Dijk [Fri, 29 Jan 2021 21:28:16 +0000 (22:28 +0100)] 
gh actions: build Docker images

3 years agodnsdist: Add option to spoofRawAction to spoof multiple answers 10063/head
Sander Hoentjen [Fri, 5 Feb 2021 11:07:22 +0000 (12:07 +0100)] 
dnsdist: Add option to spoofRawAction to spoof multiple answers

3 years agoStray comma and document some older provider libs do no do validation at all. 10060/head
Otto [Fri, 5 Feb 2021 13:26:19 +0000 (14:26 +0100)] 
Stray comma and document some older provider libs do no do validation at all.

3 years agoDo not use local vars that start with d_, our naming convention is that
Otto [Fri, 5 Feb 2021 13:16:31 +0000 (14:16 +0100)] 
Do not use local vars that start with d_, our naming convention is that
those are fields of a class.

3 years agoMerge pull request #10061 from omoerbeek/format-option-fix
Otto Moerbeek [Fri, 5 Feb 2021 12:56:36 +0000 (13:56 +0100)] 
Merge pull request #10061 from omoerbeek/format-option-fix

fix a clang-format issue difference in opinion

3 years agoAdd dolog.hh to sdig sources
Otto [Fri, 5 Feb 2021 12:40:12 +0000 (13:40 +0100)] 
Add dolog.hh to sdig sources

3 years agoFix compilation on CentOS-7, which lacks gnutls_session_set_verify_cert().
Otto [Fri, 5 Feb 2021 12:20:30 +0000 (13:20 +0100)] 
Fix compilation on CentOS-7, which lacks gnutls_session_set_verify_cert().

Make explicit gnutls only validates the certificate if a server hostname is given.

3 years agoApply suggestions from code review
Otto Moerbeek [Fri, 5 Feb 2021 11:22:39 +0000 (12:22 +0100)] 
Apply suggestions from code review

Co-authored-by: Remi Gacogne <rgacogne+github@valombre.net>
3 years agoSetting this flag appears to fix one difference between clang-format-8 and 10 10061/head
Otto [Fri, 5 Feb 2021 11:23:59 +0000 (12:23 +0100)] 
Setting this flag appears to fix one difference between clang-format-8 and 10

3 years agoTweaks and man page updates
Otto [Fri, 5 Feb 2021 10:01:37 +0000 (11:01 +0100)] 
Tweaks and man page updates

3 years agoclang-tidy: pass by value and use std::move
Rosen Penev [Fri, 5 Feb 2021 01:16:52 +0000 (17:16 -0800)] 
clang-tidy: pass by value and use std::move

Found with modernize-pass-by-value

Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years agoclang-tidy: remove pointless std::move
Rosen Penev [Fri, 5 Feb 2021 01:08:53 +0000 (17:08 -0800)] 
clang-tidy: remove pointless std::move

Found with performance-move-const-arg

Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years agoclang-tidy: several reference conversions
Rosen Penev [Thu, 5 Nov 2020 09:10:12 +0000 (01:10 -0800)] 
clang-tidy: several reference conversions

Found with performance-unnecessary-value-param

Signed-off-by: Rosen Penev <rosenp@gmail.com>
3 years agoclang-tidy: replace bind with lambdas
Rosen Penev [Thu, 5 Nov 2020 08:47:27 +0000 (00:47 -0800)] 
clang-tidy: replace bind with lambdas

Found with modernize-avoid-bind

Signed-off-by: Rosen Penev <rosenp@gmail.com>