]>
git.ipfire.org Git - thirdparty/lxc.git/log
Josh Soref [Tue, 30 Oct 2018 07:45:15 +0000 (07:45 +0000)]
spelling: passphrase
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:44:56 +0000 (07:44 +0000)]
spelling: override
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:37:31 +0000 (07:37 +0000)]
spelling: overridden
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:37:13 +0000 (07:37 +0000)]
spelling: overlayfs
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:36:14 +0000 (07:36 +0000)]
spelling: output
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:35:39 +0000 (07:35 +0000)]
spelling: otherwise
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:26:07 +0000 (07:26 +0000)]
spelling: namespace
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:18:45 +0000 (07:18 +0000)]
spelling: loglevel
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:18:08 +0000 (07:18 +0000)]
spelling: libraries
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:17:22 +0000 (07:17 +0000)]
spelling: keepdata
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:16:39 +0000 (07:16 +0000)]
spelling: javascript
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:13:17 +0000 (07:13 +0000)]
spelling: initialize
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:12:26 +0000 (07:12 +0000)]
spelling: inherited
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:11:52 +0000 (07:11 +0000)]
spelling: implementations
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:11:19 +0000 (07:11 +0000)]
spelling: ifindices
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:09:02 +0000 (07:09 +0000)]
spelling: hoops
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:08:31 +0000 (07:08 +0000)]
spelling: hierarchy
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 17:13:36 +0000 (13:13 -0400)]
spelling: github
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:01:50 +0000 (07:01 +0000)]
spelling: feature
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:01:26 +0000 (07:01 +0000)]
spelling: explicitly
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:01:12 +0000 (07:01 +0000)]
spelling: exiting
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 07:00:01 +0000 (07:00 +0000)]
spelling: device
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:59:37 +0000 (06:59 +0000)]
spelling: describing
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:54:56 +0000 (06:54 +0000)]
spelling: could
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:55:05 +0000 (06:55 +0000)]
spelling: convenience
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:54:21 +0000 (06:54 +0000)]
spelling: control
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:53:11 +0000 (06:53 +0000)]
spelling: container
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:54:44 +0000 (06:54 +0000)]
spelling: constant
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:52:44 +0000 (06:52 +0000)]
spelling: configuration
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:52:23 +0000 (06:52 +0000)]
spelling: committer
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:52:09 +0000 (06:52 +0000)]
spelling: command
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:51:58 +0000 (06:51 +0000)]
spelling: comma
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:50:25 +0000 (06:50 +0000)]
spelling: checkpoint
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:50:12 +0000 (06:50 +0000)]
spelling: character
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:49:52 +0000 (06:49 +0000)]
spelling: capabilities
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:49:12 +0000 (06:49 +0000)]
spelling: backingstorage
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:48:09 +0000 (06:48 +0000)]
spelling: asynchronous
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:47:57 +0000 (06:47 +0000)]
spelling: array
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:47:09 +0000 (06:47 +0000)]
spelling: architecture
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:46:40 +0000 (06:46 +0000)]
spelling: answer
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:45:53 +0000 (06:45 +0000)]
spelling: ambiguous
Signed-off-by: Josh Soref <jsoref@gmail.com>
Josh Soref [Tue, 30 Oct 2018 06:45:18 +0000 (06:45 +0000)]
spelling: allocate
Signed-off-by: Josh Soref <jsoref@gmail.com>
2xsec [Tue, 23 Oct 2018 10:13:27 +0000 (19:13 +0900)]
dlog: inherit dlog fds
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Tue, 23 Oct 2018 06:20:24 +0000 (15:20 +0900)]
parse: cleanups
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Tue, 23 Oct 2018 02:38:29 +0000 (11:38 +0900)]
storage_utils: use _exit() instead of exit() in child process
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Tue, 23 Oct 2018 02:33:45 +0000 (11:33 +0900)]
storage_utils: cleanups
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Tue, 23 Oct 2018 02:30:12 +0000 (11:30 +0900)]
storage_utils: add error handling
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Christian Brauner [Sat, 20 Oct 2018 10:04:33 +0000 (12:04 +0200)]
coverity: #
1426130
Bad bit shift operation
Fixes: commit b5b12b9e759 ("criu: add feature check capability")
Cc: Adrian Reber <areber@redhat.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:59:48 +0000 (11:59 +0200)]
coverity: #
1440389
Logically dead code
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:57:02 +0000 (11:57 +0200)]
coverity: #
1440391
Dereference null return value
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:49:47 +0000 (11:49 +0200)]
cmd/lxc_init: do not hide global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:48:06 +0000 (11:48 +0200)]
tools/lxc_stop: use correct check
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:39:28 +0000 (11:39 +0200)]
start: prevent values smaller 0
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:37:39 +0000 (11:37 +0200)]
lxccontainer: remove check from goto target
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:36:26 +0000 (11:36 +0200)]
conf: remove tautological check
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:35:41 +0000 (11:35 +0200)]
conf: use O_CLOEXEC in lxc_pivot_root()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:34:35 +0000 (11:34 +0200)]
conf: remove tautological check
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:32:04 +0000 (11:32 +0200)]
state: remove tautological check
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:30:12 +0000 (11:30 +0200)]
tools/lxc_info: do not hide global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:28:11 +0000 (11:28 +0200)]
tools/lxc_top: do not hide global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:23:55 +0000 (11:23 +0200)]
tools/lxc_copy: do not hide global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:22:02 +0000 (11:22 +0200)]
monitord: do not hide global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:13:59 +0000 (11:13 +0200)]
cgfsng: move increment out of branch
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:09:54 +0000 (11:09 +0200)]
commands: simplify
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sat, 20 Oct 2018 09:03:41 +0000 (11:03 +0200)]
confile: do not overwrite global variable
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 23:57:40 +0000 (01:57 +0200)]
coverity: update .travis.yml
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 23:54:55 +0000 (01:54 +0200)]
coverity: update .travis.yml
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 23:48:39 +0000 (01:48 +0200)]
coverity: update .travis.yml
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 23:42:56 +0000 (01:42 +0200)]
coverity: update .travis.yml
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 23:34:15 +0000 (01:34 +0200)]
coverity: update .travis.yml
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 22:22:18 +0000 (00:22 +0200)]
autotools: compiler based hardening
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Fri, 19 Oct 2018 22:06:32 +0000 (00:06 +0200)]
start: simplify
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2xsec [Fri, 19 Oct 2018 05:34:13 +0000 (14:34 +0900)]
tree-wide: coding style fixes
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
[christian.brauner@ubuntu.com: cleanup if-branches in confile.c]
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2xsec [Fri, 19 Oct 2018 02:51:51 +0000 (11:51 +0900)]
parse: fix uninitialized value
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Christian Brauner [Wed, 17 Oct 2018 16:36:28 +0000 (18:36 +0200)]
parse: protect against config updates during parse
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 17 Oct 2018 13:16:27 +0000 (15:16 +0200)]
confile: fix append_unexp_config_line()
Reported-by: 2xsec dh48.jeong@samsung.com
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 18 Oct 2018 12:38:09 +0000 (14:38 +0200)]
raw_syscalls: ensure function always returns value
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Thu, 18 Oct 2018 10:50:13 +0000 (12:50 +0200)]
include: simplify strlcpy()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2xsec [Thu, 18 Oct 2018 06:16:54 +0000 (15:16 +0900)]
string_utils: fix global buffer overflow issue
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Christian Brauner [Wed, 17 Oct 2018 13:23:41 +0000 (15:23 +0200)]
autotools: fix --disable-commands builds
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Sun, 14 Oct 2018 20:22:21 +0000 (22:22 +0200)]
lxc-init: log to /dev/console
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Stéphane Graber [Sat, 13 Oct 2018 02:32:08 +0000 (22:32 -0400)]
checkconfig: Handle missing kernel version
https://github.com/lxc/lxd/issues/5151
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Christian Brauner [Fri, 12 Oct 2018 19:23:07 +0000 (21:23 +0200)]
autools: use -fno-strict-aliasing
The gcc implementation and the C standard are not to be considered sane
in this respect. We don't want to risk reordering of writes when the
compiler incorrectly *thinks* two types do not alias each other.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2xsec [Fri, 12 Oct 2018 07:05:31 +0000 (16:05 +0900)]
monitor: fix coding standard
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Fri, 12 Oct 2018 06:05:43 +0000 (15:05 +0900)]
commands_utils: improve code redundancy to make abstract unix socket name
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Fri, 12 Oct 2018 02:19:04 +0000 (11:19 +0900)]
monitor: checking name too long to make monitor sock name
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Fri, 12 Oct 2018 01:36:42 +0000 (10:36 +0900)]
monitor: log cleanups
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Adrian Reber [Thu, 11 Oct 2018 13:10:12 +0000 (13:10 +0000)]
checkpoint: fix running do_dump()
Testing 'lxc <container> stop --stateful' crashed LXD:
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0xe8 pc=0x7f3198ff0592]
runtime stack:
runtime.throw(0x117fe4a, 0x2a)
/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/panic.go:616 +0x81
runtime.sigpanic()
/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/signal_unix.go:372 +0x28e
goroutine 375 [syscall]:
runtime.cgocall(0xef38e3, 0xc420731630, 0x29)
/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang/src/runtime/cgocall.go:128 +0x64 fp=0xc4207315f0 sp=0xc4207315b8 pc=0x410fc4
gopkg.in/lxc/go-lxc%2ev2._Cfunc_go_lxc_migrate(0x7f316c001220, 0xc400000001, 0xc420302460, 0xc4205d6080, 0x0)
_cgo_gotypes.go:752 +0x4d fp=0xc420731630 sp=0xc4207315f0 pc=0x909d7d
gopkg.in/lxc/go-lxc%2ev2.(*Container).Migrate.func4(0x7f316c001220, 0xc400000001, 0xc420302460, 0xc4205d6080, 0x0)
/share/go/src/gopkg.in/lxc/go-lxc.v2/container.go:1798 +0x160 fp=0xc420731668 sp=0xc420731630 pc=0x91b970
gopkg.in/lxc/go-lxc%2ev2.(*Container).Migrate(0xc4207a52f0, 0x1, 0xc42051ec00, 0x20, 0x0, 0x0, 0x0, 0x0, 0x101, 0x10000000, ...)
/share/go/src/gopkg.in/lxc/go-lxc.v2/container.go:1798 +0x29f fp=0xc420731760 sp=0xc420731668 pc=0x9160ef
The commit
5a087e056f94 introduced a second parameter (conf) to the
cgroup escape() function which was never set in do_dump(). Instead of
taking it from opts->handler->conf it is now used from c->lxc_conf.
Fixes: 5a087e056f94 ("cgroups: don't escape if lxc.cgroup.keep is true")
Suggested-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Adrian Reber <areber@redhat.com>
Christian Brauner [Wed, 10 Oct 2018 11:06:21 +0000 (13:06 +0200)]
conf: verify_start_hooks() after lxc.mount.entry
Fixes: https://discuss.linuxcontainers.org/t/are-lxc-mount-entry-available-when-lxc-hook-start-is-validated/2906/3
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Wed, 10 Oct 2018 11:53:00 +0000 (13:53 +0200)]
conf: log prlimit setup
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
2xsec [Wed, 10 Oct 2018 09:51:26 +0000 (18:51 +0900)]
fix post section script error for rpm install
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Wed, 10 Oct 2018 09:21:41 +0000 (18:21 +0900)]
fix rpm packaging error for static library
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Wed, 10 Oct 2018 06:00:45 +0000 (15:00 +0900)]
parse: fix uninitialized pointer access
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
2xsec [Wed, 10 Oct 2018 05:50:32 +0000 (14:50 +0900)]
confile: remove unused variable
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Christian Brauner [Mon, 8 Oct 2018 20:53:16 +0000 (22:53 +0200)]
test: test invalid config keys
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Oct 2018 20:49:57 +0000 (22:49 +0200)]
parse: do not mask failed parse
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Oct 2018 19:08:10 +0000 (21:08 +0200)]
netns_ifaddrs: check for NETLINK_DUMP_STRICT_CHK
Make use of the new socket option, NETLINK_DUMP_STRICT_CHK, that
userspace can use via setsockopt to request strict checking of headers
and attributes on dump requests.
To get dump features such as kernel side filtering based on data in
the header or attributes appended to the dump request, userspace
must call setsockopt() for NETLINK_DUMP_STRICT_CHK and a non-zero
value. This is necessary to make use of the IFA_TARGET_NETNSID property.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Oct 2018 19:10:29 +0000 (21:10 +0200)]
macro: add SOL_NETLINK
This allows to set netlink socket properties.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Oct 2018 18:55:55 +0000 (20:55 +0200)]
macro: add NETLINK_DUMP_STRICT_CHK
This adds support for the new socket option, NETLINK_DUMP_STRICT_CHK,
that userspace can use via setsockopt to request strict checking of
headers and attributes on dump requests.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Christian Brauner [Mon, 8 Oct 2018 15:20:08 +0000 (17:20 +0200)]
attach: fix missing pthread.h include
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>