]> git.ipfire.org Git - thirdparty/strongswan.git/log
thirdparty/strongswan.git
3 years agoMerge branch 'ikev2-kdf-modularization'
Tobias Brunner [Thu, 14 Apr 2022 17:03:03 +0000 (19:03 +0200)] 
Merge branch 'ikev2-kdf-modularization'

This modularizes the IKEv2 key derivation, which makes certification (e.g.
FIPS) easier because it allows the two steps (PRF/prf+) to be implemented
by already certified third-party libraries.

For the existing third-party libraries, the two KDFs are implemented via
the respective library's HKDF implementation.  A generic implementation,
based on existing PRFs, is provided by the new kdf plugin.

3 years agokeymat_v2: Use plugin-provided KDF_PRF to derive SKEYSEED
Tobias Brunner [Tue, 15 Mar 2022 08:49:43 +0000 (09:49 +0100)] 
keymat_v2: Use plugin-provided KDF_PRF to derive SKEYSEED

3 years agounit-tests: Hand out an actual shared secret and pubkey in mock KE implementation
Tobias Brunner [Tue, 15 Mar 2022 10:59:53 +0000 (11:59 +0100)] 
unit-tests: Hand out an actual shared secret and pubkey in mock KE implementation

Makes this a bit more realistic and makes key derivation via OpenSSL's
HKDF work during tests.

3 years agowolfssl: Implement HMAC-based IKEv2 PRFs via wolfSSL's HKDF implementation
Tobias Brunner [Tue, 15 Mar 2022 08:41:11 +0000 (09:41 +0100)] 
wolfssl: Implement HMAC-based IKEv2 PRFs via wolfSSL's HKDF implementation

3 years agobotan: Implement HMAC-based IKEv2 PRFs via Botan's HKDF implementation
Tobias Brunner [Tue, 15 Mar 2022 08:34:10 +0000 (09:34 +0100)] 
botan: Implement HMAC-based IKEv2 PRFs via Botan's HKDF implementation

3 years agoopenssl: Implement HMAC-based IKEv2 PRFs via OpenSSL's HKDF implementation
Tobias Brunner [Mon, 14 Mar 2022 17:17:11 +0000 (18:17 +0100)] 
openssl: Implement HMAC-based IKEv2 PRFs via OpenSSL's HKDF implementation

3 years agokdf: Implement wrapper for IKEv2 PRFs
Tobias Brunner [Mon, 14 Mar 2022 16:16:17 +0000 (17:16 +0100)] 
kdf: Implement wrapper for IKEv2 PRFs

3 years agotest-vectors: Add vectors for HMAC-based IKEv2 PRFs
Tobias Brunner [Mon, 14 Mar 2022 16:08:39 +0000 (17:08 +0100)] 
test-vectors: Add vectors for HMAC-based IKEv2 PRFs

3 years agocrypto: Add new KDF type for IKEv2 PRFs
Tobias Brunner [Mon, 14 Mar 2022 15:56:32 +0000 (16:56 +0100)] 
crypto: Add new KDF type for IKEv2 PRFs

3 years agocrypto: Adapt kdf_t interface to support KDFs with fixed output length
Tobias Brunner [Mon, 14 Mar 2022 15:54:13 +0000 (16:54 +0100)] 
crypto: Adapt kdf_t interface to support KDFs with fixed output length

3 years agowolfssl: Implement prf+ via wolfSSL's HKDF implementation
Tobias Brunner [Wed, 16 Feb 2022 15:42:55 +0000 (16:42 +0100)] 
wolfssl: Implement prf+ via wolfSSL's HKDF implementation

3 years agobotan: Implement prf+ via Botan's HKDF implementation
Tobias Brunner [Wed, 16 Feb 2022 15:23:38 +0000 (16:23 +0100)] 
botan: Implement prf+ via Botan's HKDF implementation

3 years agocrypto: Remove unused prf_plus_t
Tobias Brunner [Tue, 15 Feb 2022 13:20:07 +0000 (14:20 +0100)] 
crypto: Remove unused prf_plus_t

3 years agokdf: Implement prf+ directly without relying on prf_plus_t
Tobias Brunner [Tue, 15 Feb 2022 13:18:14 +0000 (14:18 +0100)] 
kdf: Implement prf+ directly without relying on prf_plus_t

3 years agokeymat_v1: Derive CHILD_SA keys without using prf_plus_t
Tobias Brunner [Tue, 15 Feb 2022 09:13:53 +0000 (10:13 +0100)] 
keymat_v1: Derive CHILD_SA keys without using prf_plus_t

We already expand skeyid_e in a similar fashion so do this analogous
without relying on prf_plus_t.

3 years agounit-tests: Use plugin-provided prf+ in unit test
Tobias Brunner [Tue, 15 Feb 2022 12:43:58 +0000 (13:43 +0100)] 
unit-tests: Use plugin-provided prf+ in unit test

This tests the params API and the counter overflow.

3 years agotls-hkdf: Use plugin-provided prf+
Tobias Brunner [Mon, 14 Feb 2022 16:09:15 +0000 (17:09 +0100)] 
tls-hkdf: Use plugin-provided prf+

3 years agokeymat_v2: Use plugin-provided prf+ to derive keys
Tobias Brunner [Mon, 14 Feb 2022 15:19:42 +0000 (16:19 +0100)] 
keymat_v2: Use plugin-provided prf+ to derive keys

3 years agoappveyor: Enable kdf plugin on old images with OpenSSL 1.0.2/1.1.0
Tobias Brunner [Thu, 17 Feb 2022 09:15:22 +0000 (10:15 +0100)] 
appveyor: Enable kdf plugin on old images with OpenSSL 1.0.2/1.1.0

HKDF with expand-only mode is only available since OpenSSL 1.1.1.

3 years agoandroid: Build and load kdf plugin for prf+
Tobias Brunner [Tue, 15 Feb 2022 13:29:36 +0000 (14:29 +0100)] 
android: Build and load kdf plugin for prf+

Not necessary with newer versions of OpenSSL, but our BoringSSL release
does not support HKDF yet.

3 years agotesting: Load kdf plugin in all scenarios that require it
Tobias Brunner [Mon, 14 Feb 2022 15:25:32 +0000 (16:25 +0100)] 
testing: Load kdf plugin in all scenarios that require it

Once we use plugin-provided prf+() these won't work otherwise.

3 years agokeymat_v2: Refactor CHILD_SA key derivation so it only needs one prf+ call
Tobias Brunner [Mon, 14 Feb 2022 14:48:17 +0000 (15:48 +0100)] 
keymat_v2: Refactor CHILD_SA key derivation so it only needs one prf+ call

3 years agokeymat_v2: Refactor IKE key derivation so it only needs one prf+ call
Tobias Brunner [Mon, 14 Feb 2022 14:19:20 +0000 (15:19 +0100)] 
keymat_v2: Refactor IKE key derivation so it only needs one prf+ call

3 years agoopenssl: Add a prf+ implementation based on OpenSSL's HKDF implementation
Tobias Brunner [Fri, 11 Feb 2022 15:38:34 +0000 (16:38 +0100)] 
openssl: Add a prf+ implementation based on OpenSSL's HKDF implementation

The HKDF-Expand() function defined in RFC 5869 is basically the same as
IKEv2's prf+(), so we can use the former to implement the latter.
However, we can only support HMAC-based PRFs this way, which should be
fine as others are rarely used.

3 years agokdf: Add plugin that provides a default prf+ implementation
Tobias Brunner [Fri, 11 Feb 2022 13:49:49 +0000 (14:49 +0100)] 
kdf: Add plugin that provides a default prf+ implementation

3 years agotest-vectors: Add test vectors for prf+
Tobias Brunner [Fri, 11 Feb 2022 12:58:12 +0000 (13:58 +0100)] 
test-vectors: Add test vectors for prf+

3 years agoplugin-feature: Add plugin feature for KDFs
Tobias Brunner [Fri, 11 Feb 2022 10:57:34 +0000 (11:57 +0100)] 
plugin-feature: Add plugin feature for KDFs

3 years agoplugin-feature: Remove 'default' case in plugin_feature_un|load()
Tobias Brunner [Fri, 11 Feb 2022 10:55:36 +0000 (11:55 +0100)] 
plugin-feature: Remove 'default' case in plugin_feature_un|load()

3 years agotest-vectors: Add support for KDF test vectors
Tobias Brunner [Fri, 11 Feb 2022 11:03:38 +0000 (12:03 +0100)] 
test-vectors: Add support for KDF test vectors

3 years agocrypto-factory: Use actual plugin name when testing during construction
Tobias Brunner [Wed, 16 Feb 2022 16:24:17 +0000 (17:24 +0100)] 
crypto-factory: Use actual plugin name when testing during construction

3 years agocrypto-tester: Add facility to test KDFs
Tobias Brunner [Thu, 10 Feb 2022 17:30:50 +0000 (18:30 +0100)] 
crypto-tester: Add facility to test KDFs

3 years agovici: Report registered KDFs
Tobias Brunner [Wed, 9 Feb 2022 15:20:00 +0000 (16:20 +0100)] 
vici: Report registered KDFs

3 years agostroke: List registered KDFs
Tobias Brunner [Wed, 9 Feb 2022 15:18:30 +0000 (16:18 +0100)] 
stroke: List registered KDFs

3 years agocrypto-factory: Add constructor and methods to create KDFs
Tobias Brunner [Wed, 9 Feb 2022 15:16:20 +0000 (16:16 +0100)] 
crypto-factory: Add constructor and methods to create KDFs

Using some arguments directly in the constructor will allow us to fall
back on other implementations.

3 years agopkcs5: Rename kdf_t to avoid conflict
Tobias Brunner [Wed, 9 Feb 2022 15:08:30 +0000 (16:08 +0100)] 
pkcs5: Rename kdf_t to avoid conflict

3 years agotransform: Add private transform for KDFs
Tobias Brunner [Wed, 9 Feb 2022 14:54:47 +0000 (15:54 +0100)] 
transform: Add private transform for KDFs

3 years agocrypto: Add interface for key derivation functions
Tobias Brunner [Wed, 9 Feb 2022 10:54:28 +0000 (11:54 +0100)] 
crypto: Add interface for key derivation functions

3 years agoMerge branch 'labeled-ipsec'
Tobias Brunner [Thu, 14 Apr 2022 16:43:16 +0000 (18:43 +0200)] 
Merge branch 'labeled-ipsec'

This adds support for labeled IPsec with SELinux (and a proprietary mode
that can be used to match child configs).  For SELinux support, compile
with --enable-selinux.

Other changes include a combined start action (trap|start), avoiding
initiating duplicate CHILD_SAs, updating reqids if dynamic traffic
selectors change, removing reqid errors on policy updates, or querying
specific CHILD_SAs with vici's list-sas command.

Closes #3075

3 years agotesting: Add DSCP scenario that uses simple labels
Tobias Brunner [Thu, 14 Apr 2022 12:13:07 +0000 (14:13 +0200)] 
testing: Add DSCP scenario that uses simple labels

Instead of creating two IKE_SAs with different identities, this scenario
uses simple labels to select the correct child config.

3 years agoswanctl: Add options to filter CHILD_SAs in --list-sas
Tobias Brunner [Wed, 2 Jun 2021 12:46:03 +0000 (14:46 +0200)] 
swanctl: Add options to filter CHILD_SAs in --list-sas

3 years agovici: Add options to only return specific CHILD_SAs in list-sas()
Tobias Brunner [Wed, 2 Jun 2021 12:37:39 +0000 (14:37 +0200)] 
vici: Add options to only return specific CHILD_SAs in list-sas()

3 years agotesting: Copy comments to test log
Tobias Brunner [Wed, 2 Jun 2021 12:29:55 +0000 (14:29 +0200)] 
testing: Copy comments to test log

3 years agoswanctl: Report labels in --list-* commands
Tobias Brunner [Tue, 21 Dec 2021 11:18:21 +0000 (12:18 +0100)] 
swanctl: Report labels in --list-* commands

3 years agovici: Report security label on CHILD_SA, policies and configs
Tobias Brunner [Tue, 21 Dec 2021 11:10:34 +0000 (12:10 +0100)] 
vici: Report security label on CHILD_SA, policies and configs

3 years agovici: Make security labels and mode configurable
Tobias Brunner [Tue, 21 Dec 2021 10:56:32 +0000 (11:56 +0100)] 
vici: Make security labels and mode configurable

3 years agokernel-netlink: Forward labels from acquires
Tobias Brunner [Tue, 21 Dec 2021 10:33:06 +0000 (11:33 +0100)] 
kernel-netlink: Forward labels from acquires

3 years agotrap-manager: Add support to handle acquires with security labels
Tobias Brunner [Tue, 21 Dec 2021 10:26:50 +0000 (11:26 +0100)] 
trap-manager: Add support to handle acquires with security labels

3 years agokernel-handler: Log security label received with acquire
Tobias Brunner [Tue, 21 Dec 2021 10:26:12 +0000 (11:26 +0100)] 
kernel-handler: Log security label received with acquire

3 years agokernel-interface: Optionally pass security label with an acquire
Tobias Brunner [Tue, 21 Dec 2021 10:22:36 +0000 (11:22 +0100)] 
kernel-interface: Optionally pass security label with an acquire

3 years agoike-sa: Accept optional security label when initiating CHILD_SAs
Tobias Brunner [Mon, 20 Dec 2021 15:16:00 +0000 (16:16 +0100)] 
ike-sa: Accept optional security label when initiating CHILD_SAs

3 years agochild-rekey: Maintain security label during rekeying
Tobias Brunner [Mon, 20 Dec 2021 15:10:19 +0000 (16:10 +0100)] 
child-rekey: Maintain security label during rekeying

3 years agoselinux: Add plugin to install trap policies with generic labels
Tobias Brunner [Wed, 2 Feb 2022 14:51:06 +0000 (15:51 +0100)] 
selinux: Add plugin to install trap policies with generic labels

After establishing an IKE_SA, we check if any of its child configs
define generic SELinux labels and install trap policies for them if
necessary narrowed to the current (virtual) IPs.

3 years agoike-sa: Add helper to determine an IKE_SA's dynamic hosts
Tobias Brunner [Wed, 2 Feb 2022 14:45:57 +0000 (15:45 +0100)] 
ike-sa: Add helper to determine an IKE_SA's dynamic hosts

3 years agotrap-manager: Add facility to install externally managed trap policies
Tobias Brunner [Tue, 1 Feb 2022 19:17:50 +0000 (20:17 +0100)] 
trap-manager: Add facility to install externally managed trap policies

This allows managing trap policies outside of the trap manager.

We'll use this to create trap policies with generic labels if trap policies
can't (or won't) be used (e.g. as responder for roadwarriors).

3 years agochild-sa: Allocate a new reqid if dynamic traffic selectors are updated
Tobias Brunner [Thu, 3 Feb 2022 16:10:46 +0000 (17:10 +0100)] 
child-sa: Allocate a new reqid if dynamic traffic selectors are updated

If update_sa() is called and dynamic traffic selectors are changed using
new addresses, this might cause issues if we continue to use a reqid that
doesn't match the updated traffic selectors.  For instance, if the initiator
then uses make-before-break reauth from the new IP.  It's also a particular
problem in the SELinux case where multiple CHILD_SAs with specific labels
all share the same (trap) policy with generic label.  However, SAs created
after the update would not match due to the new reqid.

3 years agokernel-netlink: Allow reqid updates for policies again
Tobias Brunner [Fri, 4 Feb 2022 08:37:37 +0000 (09:37 +0100)] 
kernel-netlink: Allow reqid updates for policies again

This was originally added with 1551d8b13d14 ("kernel-netlink: reject
policy refcount if the reqid differs").  Since then we added code to
allocate constant reqids for the same TS, which pretty much avoids the
previous issues.

However, the reqid might have to be changed due to MOBIKE updates. And
because reqids are allocated for a complete set of traffic selectors and
not individual pairs, this can create a problem with drop policies as
those will use the old reqid (they are installed with the same priority,
reqid etc. to replace the actual IPsec policies), while unmodified
replacement policies will use the new one.  A similar issue exists for
CHILD_SAs with SELinux contexts as those all use duplicate policies (same
generic label) but can't all be updated concurrently.

3 years agokernel-interface: Add support to change the reqid in update_sa()
Tobias Brunner [Thu, 3 Feb 2022 16:10:12 +0000 (17:10 +0100)] 
kernel-interface: Add support to change the reqid in update_sa()

3 years agokernel-wfp: Use new UDP ports in update_sa()
Tobias Brunner [Thu, 3 Feb 2022 16:08:58 +0000 (17:08 +0100)] 
kernel-wfp: Use new UDP ports in update_sa()

3 years agochild-sa: Support dynamically updating trap policies
Tobias Brunner [Thu, 3 Feb 2022 13:46:59 +0000 (14:46 +0100)] 
child-sa: Support dynamically updating trap policies

3 years agochild-create: Add support to handle security labels
Tobias Brunner [Wed, 2 Feb 2022 09:40:16 +0000 (10:40 +0100)] 
child-create: Add support to handle security labels

With SELinux and without a specific label from an acquire, we abort
establishing the CHILD_SA (for the first one we prefer a childless IKE_SA,
but since that's a separate extension, we fall back to letting the initial
CHILD_SA fail as we won't propose a label).

If trap policies are not installed already (e.g. because it's impossible to
do so like as responder for roadwarriors), this will require installing
them dynamically once the IKE_SA is established.

3 years agochild-create: Consider security label when comparing CHILD_SAs
Tobias Brunner [Mon, 20 Dec 2021 14:58:46 +0000 (15:58 +0100)] 
child-create: Consider security label when comparing CHILD_SAs

3 years agochild-sa: Add support for security labels
Tobias Brunner [Mon, 20 Dec 2021 14:28:07 +0000 (15:28 +0100)] 
child-sa: Add support for security labels

In SELinux mode we install the configured label on the policies and the
negotiated one on the SAs.  This is how it usually is configured where the
policy/configuration has a generic context and the SAs will get the actual
context of the flows assigned (the latter matches the former, so flows
match the policies but will trigger an acquire if no matching SA exists).

In the simple mode we don't pass the label to the kernel and to avoid
duplicate policy errors we also don't use it to acquire unique reqids.

3 years agokernel-interface: Optionally consider security label when allocating reqids
Tobias Brunner [Mon, 20 Dec 2021 14:11:37 +0000 (15:11 +0100)] 
kernel-interface: Optionally consider security label when allocating reqids

3 years agopeer-cfg: Consider security labels when selecting child configs
Tobias Brunner [Mon, 10 Jan 2022 17:31:34 +0000 (18:31 +0100)] 
peer-cfg: Consider security labels when selecting child configs

3 years agochild-cfg: Add method to select a security label
Tobias Brunner [Tue, 11 Jan 2022 09:15:53 +0000 (10:15 +0100)] 
child-cfg: Add method to select a security label

3 years agochild-cfg: Add optional security label and mode
Tobias Brunner [Mon, 20 Dec 2021 12:49:56 +0000 (13:49 +0100)] 
child-cfg: Add optional security label and mode

3 years agokernel-netlink: Add support for optional security label on SAs and policies
Tobias Brunner [Mon, 20 Dec 2021 14:02:42 +0000 (15:02 +0100)] 
kernel-netlink: Add support for optional security label on SAs and policies

3 years agoencoding: Remove unused TS_TYPE and ADDRESS encodings
Tobias Brunner [Thu, 13 Jan 2022 13:26:06 +0000 (14:26 +0100)] 
encoding: Remove unused TS_TYPE and ADDRESS encodings

3 years agots-payload: Add support for TS of type TS_SECLABEL
Tobias Brunner [Mon, 10 Jan 2022 16:39:56 +0000 (17:39 +0100)] 
ts-payload: Add support for TS of type TS_SECLABEL

The security labels can be retrieved in a separate list from the
regular traffic selectors.  We currently only plan to support a single
security label ourselves, so when generating we don't expect a list.

3 years agotraffic-selector-substructure: Add support for TS_SECLABEL
Tobias Brunner [Mon, 10 Jan 2022 16:34:22 +0000 (17:34 +0100)] 
traffic-selector-substructure: Add support for TS_SECLABEL

Changes how regular address range traffic selectors are parsed as the
IKE parser currently doesn't provide sub-type parsing.

Also removed a lot of unused method definitions.

3 years agotraffic-selector: Add TS_SECLABEL type
Tobias Brunner [Mon, 10 Jan 2022 15:35:38 +0000 (16:35 +0100)] 
traffic-selector: Add TS_SECLABEL type

3 years agoleak-detective: Whitelist selinux_check_access()
Tobias Brunner [Fri, 4 Feb 2022 07:17:54 +0000 (08:17 +0100)] 
leak-detective: Whitelist selinux_check_access()

3 years agosec-label: Add enum for security label mode
Tobias Brunner [Thu, 27 Jan 2022 13:49:39 +0000 (14:49 +0100)] 
sec-label: Add enum for security label mode

3 years agosec-label: Add class to represent security labels
Tobias Brunner [Mon, 20 Dec 2021 10:23:37 +0000 (11:23 +0100)] 
sec-label: Add class to represent security labels

In accordance with SELinux, we include the null-terminator in the encoding
for now.

3 years agoconfigure: Add option to link against libselinux
Tobias Brunner [Fri, 17 Dec 2021 16:13:27 +0000 (17:13 +0100)] 
configure: Add option to link against libselinux

3 years agovici: Make combination of 'trap' and 'start' configurable
Tobias Brunner [Thu, 16 Dec 2021 15:51:04 +0000 (16:51 +0100)] 
vici: Make combination of 'trap' and 'start' configurable

3 years agoenum: Add helper to parse enum flags from strings
Tobias Brunner [Fri, 17 Dec 2021 14:19:02 +0000 (15:19 +0100)] 
enum: Add helper to parse enum flags from strings

Individual flag names are separated by |.

3 years agoike: Treat action_t as flags so 'start' and 'trap' can be combined
Tobias Brunner [Thu, 16 Dec 2021 15:34:37 +0000 (16:34 +0100)] 
ike: Treat action_t as flags so 'start' and 'trap' can be combined

While combining the actions could cause duplicates (while the SA is
initiated, traffic might trigger the trap and the initiation of another
CHILD_SA), the previous commit should avoid most duplicates.  If reuse_ikesa
is disabled, duplicates can't be prevented, though.

3 years agoenum: Allow specifying the name used when none of the flags are set
Tobias Brunner [Fri, 17 Dec 2021 13:25:44 +0000 (14:25 +0100)] 
enum: Allow specifying the name used when none of the flags are set

3 years agochild-create: Abort initiating a duplicate CHILD_SA
Tobias Brunner [Thu, 20 May 2021 16:11:58 +0000 (18:11 +0200)] 
child-create: Abort initiating a duplicate CHILD_SA

This could happen if an acquire is triggered while we respond to a
CREATE_CHILD_SA request from the peer, or if an acquire is triggered
while an IKE_SA (with its existing CHILD_SAs) is reestablished (also
with break-before-make reauthentication).  Also catches multiple
manual initiations.

Note that this ignores the traffic selectors from acquires (narrowing to
them seems rare in practice anyway).

Duplicates can still get created if e.g. both peers initiate them
concurrently.

3 years agochild-create: Just abort CREATE_CHILD_SA request if nonce creation fails
Tobias Brunner [Thu, 20 May 2021 15:55:54 +0000 (17:55 +0200)] 
child-create: Just abort CREATE_CHILD_SA request if nonce creation fails

No need to send an illegal request with just an error notify.

3 years agokernel-listener: Use a struct to pass data from acquires
Tobias Brunner [Thu, 16 Dec 2021 12:50:38 +0000 (13:50 +0100)] 
kernel-listener: Use a struct to pass data from acquires

3 years agokernel-netlink: Read protocol of acquire not from template
Tobias Brunner [Fri, 28 May 2021 11:36:04 +0000 (13:36 +0200)] 
kernel-netlink: Read protocol of acquire not from template

If a policy with IPComp template triggers an acquire, we get two, one for
an IPComp, one for ESP/AH SA.  However, the triggering template of the trap
policy (where we get the reqid from), will be the same in both acquires,
IPComp, which we ignore, so no acquire was actually forwarded.

3 years agoike-sa: Use a struct to pass optional arguments when initiating CHILD_SAs
Tobias Brunner [Wed, 19 May 2021 12:16:20 +0000 (14:16 +0200)] 
ike-sa: Use a struct to pass optional arguments when initiating CHILD_SAs

3 years agoike: Don't reset optional CHILD_SA properties when migrating child-creating tasks
Tobias Brunner [Thu, 20 May 2021 09:43:39 +0000 (11:43 +0200)] 
ike: Don't reset optional CHILD_SA properties when migrating child-creating tasks

These are set via methods, which are not called again after migration
(e.g. when retrying due to INVALID_KE or when moving queued tasks), so we
don't want to clear these values.

3 years agocirrus: Use FreeBSD 12.3
Tobias Brunner [Thu, 14 Apr 2022 16:38:43 +0000 (18:38 +0200)] 
cirrus: Use FreeBSD 12.3

This should fix this error thrown by autoreconf:

ld-elf.so.1: /usr/local/lib/perl5/5.32/mach/CORE/libperl.so.5.32: Undefined symbol "strerror_l@FBSD_1.6"

3 years agoike: Track unprocessed initial IKE messages like half-open IKE_SAs
Tobias Brunner [Fri, 4 Jun 2021 16:11:46 +0000 (18:11 +0200)] 
ike: Track unprocessed initial IKE messages like half-open IKE_SAs

This should make the DoS limits (cookie_threshold[_ip] and block_threshold)
more accurate so that it won't be possible to create lots of jobs from
spoofed IP addresses before half-open IKE_SAs are actually created from
these jobs to enforce those limits.

Note that retransmits are tracked as half-open SAs until they are
processed/dismissed as the check only happens in checkout_by_message().

Increasing the count in process_message_job_create() avoids issues with
missing calls to track_init() before calling checkout_by_message() (e.g.
when processing fragmented IKEv1 messages, which are reinjected via a
process message job).

3 years agoreceiver: Add per-IP cookie threshold
Tobias Brunner [Fri, 18 Mar 2022 14:13:06 +0000 (15:13 +0100)] 
receiver: Add per-IP cookie threshold

Because the global cookie threshold is higher than the per-IP block
threshold, it was previously possible for an attacker to block a legitimate
user by sending spoofed IKE_SA_INIT packets from that user's IP.

The timespan for requiring cookies is now also not extended anymore with
every IKE_SA_INIT received during the calm down period.  Because this
allowed an attacker, after initially triggering the global cookie threshold,
to force cookies for all clients by sending just a single spoofed
IKE_SA_INIT every 10 seconds.

We keep track of reaching the per-IP threshold in segments of the hashed
IP addresses, so only a (random, due to chunk_hash()'s random key) subset
of clients will receive cookies, if single IPs are targeted.

The default global threshold is increased a bit.

3 years agoreceiver: Use a time based limit to switch COOKIE secrets
Tobias Brunner [Fri, 4 Jun 2021 11:41:31 +0000 (13:41 +0200)] 
receiver: Use a time based limit to switch COOKIE secrets

If we are under attack and there are lots of requests, we might hit
the previous use count limit pretty quickly and may switch secrets multiple
times a second, which renders the 10 second default lifetime of COOKIEs
pointless and prevents legitimate clients from sending requests with valid
COOKIEs.

3 years agolgtm: Fix query for chunk_from_chars()
Tobias Brunner [Thu, 14 Apr 2022 13:16:38 +0000 (15:16 +0200)] 
lgtm: Fix query for chunk_from_chars()

`Block` has apparently been deprecated and renamed to `BlockStmt` a while
ago.  Support for `Block` was recently removed completely.

3 years agotraffic-selector: Avoid out-of-bound array access when calculating range
Tobias Brunner [Wed, 16 Mar 2022 10:45:49 +0000 (11:45 +0100)] 
traffic-selector: Avoid out-of-bound array access when calculating range

This happens for `/0` subnet masks.  In practice, it's not an issue because
if `bytes` is 0, then so are `netbits`, `bits` and `mask`.  So the two
incorrectly addressed array elements are not actually modified.  The first
operation is a `&= 0xff` and the second a `|= 0`, so nothing changes.
But some tools might not consider the values and report this as undefined
behavior, which it technically is.

3 years agoMerge branch 'pfkey-exclude-routes'
Tobias Brunner [Tue, 15 Mar 2022 13:04:19 +0000 (14:04 +0100)] 
Merge branch 'pfkey-exclude-routes'

Avoid unnecessary exclude routes on FreeBSD where these can cause problems.

Closes strongswan/strongswan#890

3 years agokernel-pfkey: Don't install exclude routes for locally connected peers
Tobias Brunner [Wed, 16 Feb 2022 13:47:40 +0000 (14:47 +0100)] 
kernel-pfkey: Don't install exclude routes for locally connected peers

Such routes with a gateway that equals the peer's address are problematic
on FreeBSD.  And since there is most likely a narrow route for the local
subnet anyway, the exclude routes would be redundant.

3 years agokernel-pfkey: Only install exclude route if not routing via outbound interface
Tobias Brunner [Fri, 11 Feb 2022 16:23:15 +0000 (17:23 +0100)] 
kernel-pfkey: Only install exclude route if not routing via outbound interface

When installing routes based on remote traffic selectors, it can be
necessary to install an exclude route for the remote peer to avoid a
routing loop and continue to be able to reach it via IKE/ESP.

However, such routes are only necessary, if the routes we install don't
go via outbound interface.  That's the case when using VIPs and routing
via TUN devices, or when using internal source IPs and routing via
their interfaces.

Installing such exclude routes if not necessary can cause issues on
FreeBSD (EINVAL when sending packets to the peer).

3 years agokernel-netlink: Remove unimplemented XFRM_OFFLOAD_IPV6 flag
Leon Romanovsky [Mon, 21 Feb 2022 13:35:30 +0000 (15:35 +0200)] 
kernel-netlink: Remove unimplemented XFRM_OFFLOAD_IPV6 flag

The XFRM_OFFLOAD_IPV6 flag was never implemented in the kernel and there
are no plans to do so.

Kernel patch: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7c76ecd9c99b6e9a771d813ab1aa7fa428b3ade1

Closes strongswan/strongswan#916

3 years agoREADME: Added link to docs.strongswan.org
Andreas Steffen [Wed, 2 Mar 2022 20:55:43 +0000 (21:55 +0100)] 
README: Added link to docs.strongswan.org

3 years agotesting: Increase memory on winnetou even more
Tobias Brunner [Tue, 1 Mar 2022 09:10:37 +0000 (10:10 +0100)] 
testing: Increase memory on winnetou even more

3 years agotls-server: Use correct error alerts if client doesn't send a certificate
Tobias Brunner [Tue, 1 Mar 2022 09:05:26 +0000 (10:05 +0100)] 
tls-server: Use correct error alerts if client doesn't send a certificate

TLS 1.3 defines a specific alert for this and for TLS 1.2, RFC 5246,
section 7.4.6 defines handshake_failure as correct response.

3 years agoopenssl: Don't unload providers
Tobias Brunner [Wed, 23 Feb 2022 16:29:02 +0000 (17:29 +0100)] 
openssl: Don't unload providers

There is a conflict between atexit() handlers registered by OpenSSL and
some executables (e.g. swanctl or pki) to deinitialize libstrongswan.
Because plugins are usually loaded after atexit() has been called, the
handler registered by OpenSSL will run before our handler.  So when the
latter destroys the plugins it's a bad idea to try to access any OpenSSL
objects as they might already be invalid.

Fixes: f556fce16b60 ("openssl: Load "legacy" provider in OpenSSL 3 for algorithms like MD4, DES etc.")
Closes strongswan/strongswan#921

3 years agoUse wolfSSL 5.2.0 for tests
Tobias Brunner [Tue, 22 Feb 2022 08:35:01 +0000 (09:35 +0100)] 
Use wolfSSL 5.2.0 for tests