]> git.ipfire.org Git - thirdparty/glibc.git/log
thirdparty/glibc.git
25 hours agoelf: Add DL_ADDRESS_WITHOUT_RELOC [BZ #33088] master
H.J. Lu [Sun, 15 Jun 2025 03:38:54 +0000 (11:38 +0800)] 
elf: Add DL_ADDRESS_WITHOUT_RELOC [BZ #33088]

Add DL_ADDRESS_WITHOUT_RELOC to force an address into a general purpose
register to prevent loading it into a vector register directly before
run-time relocation.  This is an updated fix for BZ #33088.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Reviewed-by: Florian Weimer <fweimer@redhat.com>
27 hours agostdlib: Fix __libc_message_impl iovec size (BZ 32947)
Adhemerval Zanella [Wed, 25 Jun 2025 19:33:24 +0000 (16:33 -0300)] 
stdlib: Fix __libc_message_impl iovec size (BZ 32947)

The iovec size should account for all substrings between each conversion
specification.  For the format:

  "abc %s efg"

The list of substrings are:

  ["abc ", arg, " efg]

which is 2 times the number of maximum arguments *plus* one.

This issue triggered 'out of bounds' errors by stdlib/tst-bz20544 when
glibc is built with experimental UBSAN support [1].

Besides adjusting the iovec size, a new runtime and check is added to
avoid wrong __libc_message_impl usage.

Checked on x86_64-linux-gnu.

[1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/ubsan-undef

Co-authored-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
31 hours agoAArch64: Avoid memset ifunc in cpu-features.c [BZ #33112]
Wilco Dijkstra [Fri, 27 Jun 2025 14:10:55 +0000 (14:10 +0000)] 
AArch64: Avoid memset ifunc in cpu-features.c [BZ #33112]

During early startup memcpy or memset must not be called since many targets
use ifuncs for them which won't be initialized yet.  Security hardening may
use -ftrivial-auto-var-init=zero which inserts calls to memset.  Redirect
memset to memset_generic by including dl-symbol-redir-ifunc.h in cpu-features.c.
This fixes BZ #33112.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
5 days agomalloc: Cleanup tcache_init()
Wilco Dijkstra [Thu, 3 Apr 2025 18:05:24 +0000 (18:05 +0000)] 
malloc: Cleanup tcache_init()

Cleanup tcache_init() by using the new __libc_malloc2 interface.

Reviewed-by: Cupertino Miranda <cupertino.miranda@oracle.com>
5 days agomalloc: replace instances of __builtin_expect with __glibc_unlikely
William Hunt [Thu, 26 Jun 2025 15:07:14 +0000 (15:07 +0000)] 
malloc: replace instances of __builtin_expect with __glibc_unlikely

Replaced all instances of __builtin_expect to __glibc_unlikely
within malloc.c and malloc-debug.c.  This improves the portability
of glibc by avoiding calls to GNU C built-in functions.  Since all
the expected results from calls to __builtin_expect were 0,
__glibc_likely was never used as a replacement.  Multiple
calls to __builtin_expect within a single if statement have
been replaced with one call to __glibc_unlikely, which wraps
every condition.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
5 days agomalloc: refactored aligned_OK and misaligned_chunk
William Hunt [Wed, 25 Jun 2025 11:35:05 +0000 (11:35 +0000)] 
malloc: refactored aligned_OK and misaligned_chunk

Renamed aligned_OK to misaligned_mem as to be similar
to misaligned_chunk, and reversed any assertions using
the macro.  Made misaligned_chunk call misaligned_mem after
chunk2mem rather than bitmasking with the malloc alignment
itself, since misaligned_chunk is meant to test the data
chunk itself rather than the header, and the compiler
will optimise the addition so the ternary operator is not
needed.

Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
5 days agomanual: Clarify renameat documentation
Jitka Obselkova [Sat, 14 Jun 2025 09:19:46 +0000 (11:19 +0200)] 
manual: Clarify renameat documentation

Clarify the meaning of renameat arguments.

Reviewed-by: Collin Funk <collin.funk1@gmail.com>
5 days agoRevert "manual: Clarify renameat documentation"
Florian Weimer [Thu, 26 Jun 2025 12:22:58 +0000 (14:22 +0200)] 
Revert "manual: Clarify renameat documentation"

This reverts commit abc2e954af77f8d10f4f54754520814590e79830.
Reason for revert: Wrong version of the patch.

5 days agoelf: Add missing DSO dependencies for tst-rtld-no-malloc-{audit,preload}
Florian Weimer [Thu, 26 Jun 2025 09:38:00 +0000 (11:38 +0200)] 
elf: Add missing DSO dependencies for tst-rtld-no-malloc-{audit,preload}

Fixes commit c1560f3f75c0e892b5522c16f91b4e303f677094
("elf: Switch to main malloc after final ld.so self-relocation").

Reviewed-by: Frédéric Bérat <fberat@redhat.com>
6 days agopowerpc: Remove modf optimization
Adhemerval Zanella [Mon, 16 Jun 2025 13:17:36 +0000 (10:17 -0300)] 
powerpc: Remove modf optimization

The generic implementation is slight more optimized than the powerpc
one, where it has a more optimized inf/nan check (by not using FP
unit checks, along with branch prediction hints), and removed one
branch by issuing trunc instead of a combination of floor/ceil (which
also generated less code).

On power10 with gcc 14.2.1:

reciprocal-throughput        master         patch        difference
workload-0_1                 1.1351        0.9067            20.12%
workload-1_maxint            1.4230        0.9040            36.47%
workload-maxint_maxfloat     1.5038        0.9076            39.65%
workload-integral            1.1280        0.9111            19.23%

latency                      master         patch        difference
workload-0_1                 1.1440        2.7117          -137.03%
workload-1_maxint            4.0556        2.7070            33.25%
workload-maxint_maxfloat     3.2122        2.7164            15.43%
workload-integral            3.2381        2.7281            15.75%

Checked on powerpc64le-linux-gnu.
Reviewed-by: Sachin Monga <smonga@linux.ibm.com>
6 days agopowerpc: Remove modff optimization
Adhemerval Zanella [Mon, 16 Jun 2025 13:17:35 +0000 (10:17 -0300)] 
powerpc: Remove modff optimization

The generic implementation is slight more optimized than the powerpc
one, where it has a more optimized inf/nan check (by not using FP
unit checks, along with branch prediction hints), and removed one
branch by issuing trunc instead of a combination of floor/ceil (which
also generated less code).

On power10 with gcc 14.2.1:

reciprocal-throughput        master        patch        difference
workload-0_1                 1.5210       1.3942             8.34%
workload-1_maxint            2.0926       1.3940            33.38%
workload-maxint_maxfloat     1.7851       1.3940            21.91%
workload-integral            1.5216       1.3941             8.37%

latency                      master        patch        difference
workload-0_1                 1.5928       2.6337           -65.35%
workload-1_maxint            3.2929       2.6337            20.02%
workload-maxint_maxfloat     1.9697       2.6341           -33.73%
workload-integral            2.0597       2.6337           -27.87%

Checked on powerpc64le-linux-gnu.
Reviewed-by: Sachin Monga <smonga@linux.ibm.com>
6 days agomanual: Add missing free to open_memstream example [BZ #27866]
Ravina Jain [Tue, 24 Jun 2025 15:06:25 +0000 (20:36 +0530)] 
manual: Add missing free to open_memstream example [BZ #27866]

Reviewed-by: Collin Funk <collin.funk1@gmail.com>
7 days agoLinux: Convert '__close_nocancel_nostatus' to a standalone handler
Maciej W. Rozycki [Tue, 24 Jun 2025 20:17:25 +0000 (21:17 +0100)] 
Linux: Convert '__close_nocancel_nostatus' to a standalone handler

Make '__close_nocancel_nostatus' standalone.  This is a generic version
analogous to '__close_nocancel'.  Platforms may choose to implement an
inline variant instead where the syscall invocation code sequence is
short enough to be beneficial over a function call.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
7 days agoLinux: Fix '__close_nocancel_nostatus' clobbering 'errno' [BZ #33035]
Maciej W. Rozycki [Tue, 24 Jun 2025 20:17:25 +0000 (21:17 +0100)] 
Linux: Fix '__close_nocancel_nostatus' clobbering 'errno' [BZ #33035]

Fix fallout from commit c181840c93d3 ("Consolidate non cancellable close
call") that caused '__close_nocancel_nostatus' to clobber 'errno' on a
close(2) failure, a 2.27 regression.

The problem came from a rewrite from 'close_not_cancel_no_status' to
'__close_nocancel_nostatus' switching from an inline implementation that
used INTERNAL_SYSCALL macro (which stays away from 'errno') to a call to
'__close_nocancel' function that uses INLINE_SYSCALL_CALL macro (which
does poke at 'errno').

Implement '__close_nocancel_nostatus' in terms of INTERNAL_SYSCALL_CALL
then, which leaves 'errno' intact.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
7 days agoinet: Implement inet_ntoa on top of inet_ntop
Adhemerval Zanella [Wed, 4 Jun 2025 20:42:44 +0000 (17:42 -0300)] 
inet: Implement inet_ntoa on top of inet_ntop

Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: Collin Funk <collin.funk1@gmail.com>
Reviewed-by: DJ Delorie <dj@redhat.com>
7 days agoresolv: Optimize inet_ntop
Adhemerval Zanella [Wed, 4 Jun 2025 20:42:43 +0000 (17:42 -0300)] 
resolv: Optimize inet_ntop

The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:

$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
    38.53%  bench-inet_ntop  libc.so               [.] __printf_buffer
    18.69%  bench-inet_ntop  libc.so               [.] __printf_buffer_write
    11.01%  bench-inet_ntop  libc.so               [.] _itoa_word
     8.02%  bench-inet_ntop  bench-inet_ntop_ipv4  [.] bench_start
     6.99%  bench-inet_ntop  libc.so               [.] __memmove_avx_unaligned_erms
     3.86%  bench-inet_ntop  libc.so               [.] __strchrnul_avx2
     2.82%  bench-inet_ntop  libc.so               [.] __strcpy_avx2
     1.90%  bench-inet_ntop  libc.so               [.] inet_ntop4
     1.78%  bench-inet_ntop  libc.so               [.] __vsprintf_internal
     1.55%  bench-inet_ntop  libc.so               [.] __sprintf_chk
     1.18%  bench-inet_ntop  libc.so               [.] __GI___inet_ntop

$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
    35.44%  bench-inet_ntop  libc.so               [.] __printf_buffer
    14.35%  bench-inet_ntop  libc.so               [.] __printf_buffer_write
    10.27%  bench-inet_ntop  libc.so               [.] __GI___inet_ntop
     7.93%  bench-inet_ntop  libc.so               [.] _itoa_word
     7.00%  bench-inet_ntop  libc.so               [.] __sprintf_chk
     6.20%  bench-inet_ntop  libc.so               [.] __vsprintf_internal
     5.26%  bench-inet_ntop  libc.so               [.] __strchrnul_avx2
     5.05%  bench-inet_ntop  bench-inet_ntop_ipv6  [.] bench_start
     3.70%  bench-inet_ntop  libc.so               [.] __memmove_avx_unaligned_erms
     2.11%  bench-inet_ntop  libc.so               [.] __printf_buffer_done

A new implementation is used instead:

  * The printf usage is replaced with an expanded function that prints
    either an IPv4 octet or an IPv6 quartet;

  * The strcpy is replaced with a memcpy (since ABIs usually tends to
    optimize the latter);

  * For IPv6, the '::' shorthanding is done in-place instead of using
    a temporary buffer.

  * An temporary buffer is used iff the size if larger than
    INET_ADDRSTRLEN/INET6_ADDRSTRLEN.

  * Inline is used for both inet_ntop4 and inet_ntop6,

The code is significand rewrote, so I take this requires a new license.

The performance results on aarch64 Neoverse1 with gcc 14.2.1:

* master

aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
  "inet_ntop_ipv4": {
   "workload-ipv4-random": {
    "duration": 1.43067e+09,
    "iterations": 8e+06,
    "reciprocal-throughput": 178.572,
    "latency": 179.096,
    "max-throughput": 5.59997e+06,
    "min-throughput": 5.58359e+06
   }
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
  "inet_ntop_ipv6": {
   "workload-ipv6-random": {
    "duration": 1.68539e+09,
    "iterations": 4e+06,
    "reciprocal-throughput": 421.307,
    "latency": 421.388,
    "max-throughput": 2.37357e+06,
    "min-throughput": 2.37311e+06
   }
  }

* patched

aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
  "inet_ntop_ipv4": {
   "workload-ipv4-random": {
    "duration": 1.06133e+09,
    "iterations": 5.6e+07,
    "reciprocal-throughput": 18.8482,
    "latency": 19.0565,
    "max-throughput": 5.30555e+07,
    "min-throughput": 5.24755e+07
   }
  }
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
  "inet_ntop_ipv6": {
   "workload-ipv6-random": {
    "duration": 1.01246e+09,
    "iterations": 2.4e+07,
    "reciprocal-throughput": 42.5576,
    "latency": 41.8139,
    "max-throughput": 2.34976e+07,
    "min-throughput": 2.39155e+07
   }
  }

Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
7 days agoresolve: Proper indent resolv/inet_ntop.c
Adhemerval Zanella [Wed, 4 Jun 2025 20:42:42 +0000 (17:42 -0300)] 
resolve: Proper indent resolv/inet_ntop.c

Reviewed-by: DJ Delorie <dj@redhat.com>
7 days agobenchtests: Add IPv6 inet_ntop benchmark
Adhemerval Zanella [Wed, 4 Jun 2025 20:42:41 +0000 (17:42 -0300)] 
benchtests: Add IPv6 inet_ntop benchmark

Random IP addresses in the full range.  There is no extra workload
to check the effectiveness '::' optimization for a set of 0-oct
sets (although it would be a possible workload).
Reviewed-by: DJ Delorie <dj@redhat.com>
7 days agobenchtests: Add IPv4 inet_ntop benchmark
Adhemerval Zanella [Wed, 4 Jun 2025 20:42:40 +0000 (17:42 -0300)] 
benchtests: Add IPv4 inet_ntop benchmark

Random IP addresses in the full range.
Reviewed-by: Collin Funk <collin.funk1@gmail.com>
Reviewed-by: DJ Delorie <dj@redhat.com>
8 days agoriscv: linux: Add support for getrandom vDSO
Xi Ruoyao [Thu, 19 Jun 2025 16:25:32 +0000 (00:25 +0800)] 
riscv: linux: Add support for getrandom vDSO

Linux kernel >= 6.16 has getrandom() in vDSO for RISC-V.  Enable the use
of it in Glibc so it would benefit the programs using the Glibc high
quality random number functions.

Link: https://git.kernel.org/torvalds/c/ee0d03053e70
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
8 days agoposix: Fix fnmatch build with gcc-16
Adhemerval Zanella [Fri, 20 Jun 2025 14:35:56 +0000 (11:35 -0300)] 
posix: Fix fnmatch build with gcc-16

The master branch started to enable some warnings due to optimization
that were only triggered with -Os [1].  Enable the suppression regardless
of optimization level.

Checked on aarch64-linux-gnu build.

[1] https://gcc.gnu.org/pipermail/gcc-regression/2025-June/082378.html
Reviewed-by: Sam James <sam@gentoo.org>
Reviewed-by: Collin Funk <collin.funk1@gmail.com>
8 days agopowerpc: use .machine power10 in POWER10 assembler sources
Andreas Schwab [Mon, 23 Jun 2025 09:37:23 +0000 (11:37 +0200)] 
powerpc: use .machine power10 in POWER10 assembler sources

They were misattributed as POWER9 sources.

10 days agohurd: Remove a duplicate entry from 'tests-unsupported'.
Collin Funk [Tue, 17 Jun 2025 03:14:19 +0000 (20:14 -0700)] 
hurd: Remove a duplicate entry from 'tests-unsupported'.

When building on GNU/Hurd the following warnings repeat themselves:

    ../Rules:400: target '/home/collin/obj/glibc/io/test-lfs.out' given more than once in the same rule
    ../Rules:400: target '/home/collin/obj/glibc/io/test-lfs.out' given more than once in the same rule

This is because commit 73b854e955 (hurd: Mark more memory-hungry tests
as unsupported, 2025-01-12) added it to 'tests-unsupported' even though
it was already added by decf02d382 (hurd: Mark two tests as unsupported,
2023-04-13).
Message-ID: <54dc6bf7e0dbedb1b19356f41fec843c1c523b11.1750130025.git.collin.funk1@gmail.com>

10 days agohurd: Fix redefinition of 'P2ALIGN'.
Collin Funk [Tue, 17 Jun 2025 03:45:14 +0000 (20:45 -0700)] 
hurd: Fix redefinition of 'P2ALIGN'.

When building on GNU/Hurd warnings like the following occur:

    ../sysdeps/x86_64/multiarch/strnlen-evex-base.S:53:10: warning: "P2ALIGN" redefined
       53 | # define P2ALIGN(...)   .p2align 4,, 6
          |          ^~~~~~~
    In file included from /usr/include/x86_64-gnu/mach/x86_64/syscall_sw.h:30,
                     from ../sysdeps/mach/sysdep.h:21,
                     from ../sysdeps/mach/x86/sysdep.h:31,
                     from ../sysdeps/x86_64/multiarch/strnlen-evex-base.S:24:
    /usr/include/x86_64-gnu/mach/x86_64/asm.h:78:9: note: this is the location of the previous definition
       78 | #define P2ALIGN(p2)     .p2align p2     /* gas-specific */
          |         ^~~~~~~

The fix is to undefine the macro from system headers in sysdep.h so that
it can be properly defined in assembly files where its definition
depends on whether string functions are being compiled for
wide-characters or not.
Message-ID: <721cd3a1bae1a553857db1dd69761a175f611364.1750131904.git.collin.funk1@gmail.com>

12 days agoresource/Makefile: Split and sort tests
Martin Coufal [Sat, 14 Jun 2025 09:08:18 +0000 (11:08 +0200)] 
resource/Makefile: Split and sort tests

Split and sort tests in resource/Makefile.

Reviewed-by: Arjun Shankar <arjun@redhat.com>
12 days agomalloc: Link large tcache tests with $(shared-thread-library)
Florian Weimer [Thu, 19 Jun 2025 04:30:12 +0000 (06:30 +0200)] 
malloc: Link large tcache tests with $(shared-thread-library)

Introduce tests-link-with-libpthread to list tests that
require linking with libpthread, and use that to generate
dependencies on $(shared-thread-library) for all multi-threaded tests.

Fixes build failures of commit cde5caa4bb21d5c474b9e4762cc847bcbc70e481
("malloc: add testing for large tcache support") on Hurd.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
12 days agox86: Update tst-gnu2-tls2 tests
H.J. Lu [Mon, 9 Jun 2025 00:17:49 +0000 (08:17 +0800)] 
x86: Update tst-gnu2-tls2 tests

Update tst-gnu2-tls2 tests to set XMM0...XMM7 to all 1s in malloc to
verify that XMM registers are preserved when _dl_tlsdesc_dynamic is
called by clearing vectors with zeroed XMM registers before
_dl_tlsdesc_dynamic and using these XMM registers to clear vectors
after _dl_tlsdesc_dynamic.  This improves the BZ #31372 test.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Reviewed-by: Sam James <sam@gentoo.org>
13 days agoi386: Update ___tls_get_addr to preserve vector registers
H.J. Lu [Sun, 8 Jun 2025 21:22:10 +0000 (05:22 +0800)] 
i386: Update ___tls_get_addr to preserve vector registers

Compiler generates the following instruction sequence for dynamic TLS
access:

leal tls_var@tlsgd(,%ebx,1), %eax
call ___tls_get_addr@PLT

CALL instruction is transparent to compiler which assumes all registers,
except for EFLAGS, AX, CX, and DX, are unchanged after CALL.  But
___tls_get_addr is a normal function which doesn't preserve any vector
registers.

1. Rename the generic __tls_get_addr function to ___tls_get_addr_internal.
2. Change ___tls_get_addr to a wrapper function with implementations for
FNSAVE, FXSAVE, XSAVE and XSAVEC to save and restore all vector registers.
3. dl-tlsdesc-dynamic.h has:

_dl_tlsdesc_dynamic:
/* Like all TLS resolvers, preserve call-clobbered registers.
   We need two scratch regs anyway.  */
subl $32, %esp
cfi_adjust_cfa_offset (32)

It is wrong to use

movl %ebx, -28(%esp)
movl %esp, %ebx
cfi_def_cfa_register(%ebx)
...
mov %ebx, %esp
cfi_def_cfa_register(%esp)
movl -28(%esp), %ebx

to preserve EBX on stack.  Fix it with:

movl %ebx, 28(%esp)
movl %esp, %ebx
cfi_def_cfa_register(%ebx)
...
mov %ebx, %esp
cfi_def_cfa_register(%esp)
movl 28(%esp), %ebx

4. Update _dl_tlsdesc_dynamic to call ___tls_get_addr_internal directly.
5. Add have-test-mtls-traditional to compile tst-tls23-mod.c with
traditional TLS variant to verify the fix.
6. Define DL_RUNTIME_RESOLVE_REALIGN_STACK in sysdeps/x86/sysdep.h.

This fixes BZ #32996.

Co-Authored-By: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
13 days agomanual: Clarify renameat documentation
Jitka Obselkova [Sat, 14 Jun 2025 09:19:46 +0000 (11:19 +0200)] 
manual: Clarify renameat documentation

Clarify the meaning of renameat arguments.

Signed-off-by: Jitka Obselkova <jobselko@redhat.com>
Reviewed-by: Collin Funk <collin.funk1@gmail.com>
13 days agoposix: Add nonnull attribute to glob_pattern_p.
Collin Funk [Sat, 7 Jun 2025 23:20:27 +0000 (16:20 -0700)] 
posix: Add nonnull attribute to glob_pattern_p.

* posix/glob.h (glob_pattern_p): Add __nonnull ((1)) since this function
expects a string and does not check for NULL.

Signed-off-by: Collin Funk <collin.funk1@gmail.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
13 days agomath: Simplify and optimize modf implementation
Adhemerval Zanella [Mon, 16 Jun 2025 13:17:34 +0000 (10:17 -0300)] 
math: Simplify and optimize modf implementation

Refactor the generic implementation to use math_config.h definitions,
and add an alternative one if the ABI supports truncf instructions
(gated through math-use-builtins-trunc.h).

The generic implementation generates similar code on x86_64, while
the optimization one for aarch64 (where truncf is supported as a
builtin by through frintz), the improvements are:

reciprocal-throughput           master    patch    difference
workload-0_1                    3.0595   3.0698        -0.34%
workload-1_maxint               5.1747   3.0542        40.98%
workload-maxint_maxfloat        3.4391   3.0349        11.75%
workload-integral               3.2732   3.0293         7.45%

latency                         master    patch    difference
workload-0_1                    3.5267   4.7107       -33.57%
workload-1_maxint               6.9074   4.7282        31.55%
workload-maxint_maxfloat        3.7210   4.7506       -27.67%
workload-integral               3.8634   4.8137       -24.60%

Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
13 days agomath: Simplify and optimize modff implementation
Adhemerval Zanella [Mon, 16 Jun 2025 13:17:33 +0000 (10:17 -0300)] 
math: Simplify and optimize modff implementation

Refactor the generic implementation to use math_config.h definitions,
and add an alternative one if the ABI supports truncf instructions
(gated through math-use-builtins-trunc.h).

The generic implementation generates similar code for x86_64, while
the optimization path aarch64 (where truncf is supported as a builtin)
through frintz), the improvements are:

reciprocal-throughput           master     patch    difference
workload-0_1                    3.0740    3.0326         1.35%
workload-1_maxint               5.2231    3.0436        41.73%
workload-maxint_maxfloat        4.0962    3.0551        25.42%
workload-integral               3.7093    3.0612        17.47%

latency                         master     patch    difference
workload-0_1                    3.5521    4.7313       -33.20%
workload-1_maxint               6.7148    4.7314        29.54%
workload-maxint_maxfloat        4.0458    4.7518       -17.45%
workload-integral               3.9719    4.7427       -19.40%

Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
13 days agoAArch64: Improve codegen SVE log1p helper
Luna Lamb [Wed, 18 Jun 2025 16:12:19 +0000 (16:12 +0000)] 
AArch64: Improve codegen SVE log1p helper

Improve codegen by packing coefficients.
4% and 2% improvement in throughput microbenchmark on Neoverse V1, for acosh
and atanh respectively.

Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
13 days agoAArch64: Optimise SVE FP64 Hyperbolics
Dylan Fleming [Wed, 18 Jun 2025 16:19:22 +0000 (16:19 +0000)] 
AArch64: Optimise SVE FP64 Hyperbolics

Reworke SVE FP64 hyperbolics to use the SVE FEXPA
instruction.

Also update the special case handelling for large
inputs to be entirely vectorised.

Performance improvements on Neoverse V1:

cosh_sve: 19% for |x| < 709, 5x otherwise
sinh_sve: 24% for |x| < 709, 5.9x otherwise
tanh_sve: 12% for |x| < 19,  9x otherwise

Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
13 days agoAArch64: Optimize SVE exp functions
Dylan Fleming [Wed, 18 Jun 2025 16:17:12 +0000 (16:17 +0000)] 
AArch64: Optimize SVE exp functions

Improve performance of SVE exps by making better use
of the SVE FEXPA instruction.

Performance improvement on Neoverse V1:
exp2_sve:   21%
exp2f_sve:  24%
exp10f_sve: 23%
expm1_sve:  25%

Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
13 days agosparc: Fix sparc32 Fix argument passing to __libc_start_main (BZ 32981)
Adhemerval Zanella [Fri, 13 Jun 2025 14:23:44 +0000 (11:23 -0300)] 
sparc: Fix sparc32 Fix argument passing to __libc_start_main (BZ 32981)

Commit 404526ee2e58f3c075253943ddc9988f4bd6b80c changed _start to write
the last argument to __libc_start_main without taking into consideration
that the function did not create a full stack frame, which leads to
overwriting the argv[0].

13 days agoFix termios related targets
Andreas Schwab [Wed, 18 Jun 2025 11:17:29 +0000 (13:17 +0200)] 
Fix termios related targets

Move Linux-specific termios headers and tests from misc to termios subdir
and install newly added bits/termios-cbaud.h.

13 days agomalloc: Cleanup _mid_memalign
Wilco Dijkstra [Wed, 28 May 2025 14:44:10 +0000 (14:44 +0000)] 
malloc: Cleanup _mid_memalign

Remove unused 'address' parameter from _mid_memalign and callers.
Fix off-by-one alignment calculation in __libc_pvalloc.

Reviewed-by: DJ Delorie <dj@redhat.com>
13 days agoaarch64: simplify calls to __libc_arm_za_disable in assembly
Yury Khrustalev [Mon, 16 Jun 2025 09:01:22 +0000 (10:01 +0100)] 
aarch64: simplify calls to __libc_arm_za_disable in assembly

There is no functional change in this patch.

We remove stores and loads to stack, return address signing, and redundant
CFI directives before and after call to __libc_arm_za_disable().

The __libc_arm_za_disable implementation follows special calling convention
that allows to avoid most of the operations that would be necessary for a
call to a normal function (see [1] for details).

First, we rely on __libc_arm_za_disable() not clobbering certain registers,
and we put return address into one of these registers. Now we don't need
to store it on stack, so we don't need to sign return address using PAC.

Second, as a result of the above, we don't need to update the CFI offset.

This patch provides small optimisation avoiding unnecessary store and load
on stack also simplifies assembly code and CFI directives.

[1]: https://github.com/ARM-software/abi-aa/blob/main/aapcs64/aapcs64.rst

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
13 days agoaarch64: GCS: use internal struct in __alloc_gcs
Yury Khrustalev [Wed, 16 Apr 2025 18:08:47 +0000 (19:08 +0100)] 
aarch64: GCS: use internal struct in __alloc_gcs

No functional change here, just a small refactoring to simplify
using __alloc_gcs() for allocating shadow stacks.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
13 days agopowerpc: Remove assembler workarounds
Andreas Schwab [Thu, 5 Jun 2025 08:24:46 +0000 (10:24 +0200)] 
powerpc: Remove assembler workarounds

Now that we require at least binutils 2.39 the support for POWER9 and
POWER10 instructions can be assumed.

2 weeks agomalloc: Fix tests-malloc-largetcache tests
Adhemerval Zanella [Tue, 17 Jun 2025 17:22:49 +0000 (14:22 -0300)] 
malloc: Fix tests-malloc-largetcache tests

The commit cde5caa4bb21d5c474b9e4762cc847bcbc70e481 added the
tests-malloc-largetcache without adjusting the previous entry.  The
make check fails with:

  make[1]: Entering directory '/path/to/glibc'
  make  subdir=csu -C csu ..=../ tests
  make[2]: Entering directory '/path/to/glibc/csu'
  make[2]: *** No rule to make target ')', needed by 'tests'.  Stop.
  make[2]: Leaving directory '/path/to/csu'
  make[1]: *** [Makefile:484: csu/tests] Error 2

2 weeks agoAdd TCPI_OPT_USEC_TS from Linux 6.14 and TCPI_OPT_TFO_CHILD from 6.15 to netinet...
Jeremy Harris [Sat, 31 May 2025 07:57:20 +0000 (08:57 +0100)] 
Add TCPI_OPT_USEC_TS from Linux 6.14 and TCPI_OPT_TFO_CHILD from 6.15 to netinet/tcp.h.

This patch adds the TCPI_OPT_USEC_TS constant from Linux 6.14 to
sysdeps/gnu/netinet/tcp.h

This patch adds the TCPI_OPT_TFO_CHILD constant from Linux 6.15 to
sysdeps/gnu/netinet/tcp.h

Signed-off-by: Jeremy Harris <jgh@exim.org>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 weeks agolinux/termios: regression test for termios speed functions
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:45 +0000 (18:35 -0700)] 
linux/termios: regression test for termios speed functions

Test that runs through a fairly large combination of the various
termios speed functions, for the new speed_t interface, for the old
speed_t interface (if enabled), and for the new baud_t interface.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
2 weeks agoinclude/array_length.h: add array_foreach[_const] macros
H. Peter Anvin [Thu, 12 Jun 2025 01:35:44 +0000 (18:35 -0700)] 
include/array_length.h: add array_foreach[_const] macros

Add simple-to-use iterator macros for arrays.  They are used instead
of explicit for statements, like:

      /* Test all common speeds */
      array_foreach_const (ts, test_speeds)
test (fd, *ts);

In this case, ts will be a const pointer to each of the elements of
test_speeds in turn.

Named array_foreach*() to allow for other kinds of equivalent iterator
macros in the future.

Signed-off-by: "H. Peter Anvin" (Intel) <hpa@zytor.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 weeks agotermios: unify the naming of the termios speed fields
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:43 +0000 (18:35 -0700)] 
termios: unify the naming of the termios speed fields

The generic code has __ispeed and __ospeed; Linux has c_ispeed and
c_ospeed. Use an anonymous union member to allow both set of names on
all platforms.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
2 weeks agotermios: add new baud_t interface, defined to be explicitly numeric
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:42 +0000 (18:35 -0700)] 
termios: add new baud_t interface, defined to be explicitly numeric

Add an explicitly numeric interface for baudrate setting. For glibc,
this only announces what is a fair accompli, but this is a plausible
way forward for standardization, and may be possible to infill on
non-compliant systems. The POSIX committee has stated:

[https://www.austingroupbugs.net/view.php?id=1916#c7135]

A future version of this standard is expected to add at least
the following symbolic constants for use as values of objects
of type speed_t: B57600, B115200B230400B460800, and
B921600.

Implementations are encouraged to propose additional
interfaces which will make it possible to set and query a
wider range of speeds than just those enumerated by the
constants beginning with B. If a set of common interfaces
emerges between several implementations, a future version of
this standard will likely add those interfaces.

This is exactly that interface.

The use of the term "baud" is due to the need to have a term
contrasting "speed", and it is already well established as a legacy
term -- including in the names of the legacy Bxxx
constants. Futhermore, it *is* valid from the point of view that the
termios interface fundamentally emulates an RS-232 serial port as far
as the application software is concerned.

The documentation states that for the current version of glibc,
speed_t == baud_t, but explicitly declares that this may not be the
case in the future.

Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 weeks agomanual: document all the termios Bxxx constants in the manual
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:41 +0000 (18:35 -0700)] 
manual: document all the termios Bxxx constants in the manual

Add all the Bxxx constants defined in the now-generic
<bits/termios-baud.h> in the manual.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
2 weeks agotermios: merge the termios baud definitions
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:40 +0000 (18:35 -0700)] 
termios: merge the termios baud definitions

Now all platforms unconditionally use the "sane" definitions of the
termios baud constants. Unify them into a common file.

Note: I have made them explicitly unsigned to avoid problems with
compiler warnings for comparisons of unequal signedness or
similar. These constants were historically octal on most platforms,
and so unsigned by default.

Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 weeks agohurd+generic/termios: make speed_t an unsigned int
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:39 +0000 (18:35 -0700)] 
hurd+generic/termios: make speed_t an unsigned int

POSIX requires that speed_t is an unsigned integer type, so change the
generic speed_t definition to be an unsigned int instead of a plain
int.

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
2 weeks agotermios: change the generic cfsetspeed() to support arbitrary speeds
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:38 +0000 (18:35 -0700)] 
termios: change the generic cfsetspeed() to support arbitrary speeds

The generic implementaion of cfsetspeed() had an internal table of
permitted baud rates, which was enforced even on an implementation
supporting arbitrary baud rates. This was to be able to *also* accept
numeric constants as well as Bxxx values.

This fundamentally makes no sense; not only does it go against the
documented behavior of cfsetspeed() which is to take the same input
as cfset[io]speed(), but it means cfsetspeed() is broken with regard
to a platform supporting arbitrary speeds.

With Linux converted to arbitrary baud rates, the only remaining case
of non-arbitrary baud rates appears to be Hurd with USE_OLD_TTY, which
one can presume being a legacy case that few if any people care about,
and so simply strip out this code and make cfsetspeed() rely on
cfsetospeed() to validate acceptable speed constants.

If a new platform is introduced which does not have arbitrary baud
rate support, using non-baud rate Bxxx constants (highly not
recommended; should be abstracted at the glibc level) but such
aliasing is desired, it should be supported by cfset[io]speed() as
well, and belongs in the platform-specific code.

Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 weeks agohurd/termios: remove USE_OLD_TTY
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:37 +0000 (18:35 -0700)] 
hurd/termios: remove USE_OLD_TTY

Hurd with USE_OLD_TTY was the only remaining platform with speed_t not
containing a proper baud rate. From the looks of it, that code has
long since bitrotted.

Remove the vestiges of USE_OLD_TTY.

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
2 weeks agolinux: implement arbitrary and split speeds in termios
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:36 +0000 (18:35 -0700)] 
linux: implement arbitrary and split speeds in termios

Linux has supported arbitrary speeds and split speeds in the kernel
since 2008 on all platforms except Alpha (fixed in 2020), but glibc
was never updated to match. This is further complicated by POSIX uses
of macros for the cf[gs]et[io]speed interfaces, rather than plain
numbers, as it really ought to have.

On most platforms, the glibc ABI includes the c_[io]speed fields in
struct termios, but they are incorrectly used. On MIPS and SPARC, they
are entirely missing.

For backwards compatibility, the kernel will still use the legacy
speed fields unless they are set to BOTHER, and will use the legacy
output speed as the input speed if the latter is 0 (== B0). However,
the specific encoding used is visible to user space applications,
including ones other than the one running.

- SPARC and MIPS get a new struct termios, and tc[gs]etattr() is
  versioned accordingly. However, the new struct termios is set to be
  a strict extension of the old one, which means that cf* interfaces
  other than the speed-related ones do not need versioning.
- The Bxxx constants are redefined as equivalent to their integer
  values and the legacy Bxxx constants are renamed __Bxxx.
- cf[gs]et[io]speed() and cfsetspeed() are versioned accordingly.
- tcgetattr() and cfset[io]speed() are adjusted to always keep the
  c_[io]speed fields correct (unlike earlier versions), but to
  canonicalize the representation to ALSO configure the legacy fields
  if a valid legacy representation exists.
- tcsetattr(), too, canonicalizes the representation in this way
  before passing it to the kernel, to maximize compatibility with
  older applications/tools.
- The old IBAUD0 hack is removed; it is no longer necessary since
  even the legacy c_cflag baud rate fields have had separate input
  values for a long time.

Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 weeks agolinux/termios/powerpc: deal with powerpc-unique ioctl emulation
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:35 +0000 (18:35 -0700)] 
linux/termios/powerpc: deal with powerpc-unique ioctl emulation

The powerpc architecture, only, emulates the termios ioctls using the
glibc termios structure. Export the real kernel ones as the termios2
interface; although the kernel doesn't call it termios2, it is exactly
the termios2 interface, and it avoids the namespace clash between the
emulated ioctls and the real kernel ioctls.

Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 weeks agolinux/ioctls: use <linux/sockios.h> for sockios ioctls
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:34 +0000 (18:35 -0700)] 
linux/ioctls: use <linux/sockios.h> for sockios ioctls

In the kernel, these are <linux/sockios.h>. The differences between
<linux/sockios.h> and the copied data in <bits/ioctls.h> are minor;
mainly some #ifdefs, so try to use <linux/sockios.h> directly; it is
hopefully clean enough these days to use directly.

Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 weeks agoio: replace local_isatty() with a proper function __isatty_nostatus()
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:33 +0000 (18:35 -0700)] 
io: replace local_isatty() with a proper function __isatty_nostatus()

Replace local_isatty() inlined in libio with a proper function
__isatty_nostatus(). This allows simpler system-specific
implementations that don't need to touch errno at all.

Note: I left the prototype in include/unistd.h (the internal header
file.) It didn't much make sense to me to put it in a different header
(not-cancel.h), but perhaps someone can elucidate the need.

Add such an implementation for Linux, with a generic fallback.

Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 weeks agotermios: make __tcsetattr() the internal interface
H. Peter Anvin (Intel) [Thu, 12 Jun 2025 01:35:32 +0000 (18:35 -0700)] 
termios: make __tcsetattr() the internal interface

There is a prototype for an internal __tcsetattr() function in
include/termios.h, but tcsetattr without __ were still declared as the
actual functions.

Make this match the comment and make __tcsetattr() an internal
interface. This will be required to version struct termios for Linux on
MIPS and SPARC.

Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
2 weeks agoUpdate advisory GLIBC-SA-2025-0003 and GLIBC-SA-2025-0004
Carlos O'Donell [Mon, 16 Jun 2025 22:16:18 +0000 (18:16 -0400)] 
Update advisory GLIBC-SA-2025-0003 and GLIBC-SA-2025-0004

Add Fix-Commit information for backported fixes.

2 weeks agomalloc: Sort tests-exclude-largetcache in Makefile
H.J. Lu [Mon, 16 Jun 2025 21:52:27 +0000 (05:52 +0800)] 
malloc: Sort tests-exclude-largetcache in Makefile

This fixes:

FAIL: lint-makefiles

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
2 weeks agoppc64le: Revert "powerpc: Optimized strcmp for power10" (CVE-2025-5702)
Carlos O'Donell [Mon, 16 Jun 2025 17:09:57 +0000 (13:09 -0400)] 
ppc64le: Revert "powerpc: Optimized strcmp for power10" (CVE-2025-5702)

This reverts commit 3367d8e180848030d1646f088759f02b8dfe0d6f

Reason for revert: Power10 strcmp clobbers non-volatile vector
registers (Bug 33056)

Tested on ppc64le without regression.

2 weeks agoppc64le: Revert "powerpc : Add optimized memchr for POWER10" (Bug 33059)
Carlos O'Donell [Wed, 11 Jun 2025 13:33:45 +0000 (09:33 -0400)] 
ppc64le: Revert "powerpc : Add optimized memchr for POWER10" (Bug 33059)

This reverts commit b9182c793caa05df5d697427c0538936e6396d4b

Reason for revert: Power10 memchr clobbers v20 vector register
(Bug 33059)

This is not a security issue, unlike CVE-2025-5745 and
CVE-2025-5702.

Tested on ppc64le without regression.

2 weeks agoppc64le: Revert "powerpc: Fix performance issues of strcmp power10" (CVE-2025-5702)
Carlos O'Donell [Wed, 11 Jun 2025 13:43:50 +0000 (09:43 -0400)] 
ppc64le: Revert "powerpc: Fix performance issues of strcmp power10" (CVE-2025-5702)

This reverts commit 90bcc8721ef82b7378d2b080141228660e862d56

This change is in the chain of the final revert that fixes the CVE
i.e. 3367d8e180848030d1646f088759f02b8dfe0d6f

Reason for revert: Power10 strcmp clobbers non-volatile vector
registers (Bug 33056)

Tested on ppc64le with no regressions.

2 weeks agoppc64le: Revert "powerpc: Optimized strncmp for power10" (CVE-2025-5745)
Carlos O'Donell [Wed, 11 Jun 2025 13:19:17 +0000 (09:19 -0400)] 
ppc64le: Revert "powerpc: Optimized strncmp for power10" (CVE-2025-5745)

This reverts commit 23f0d81608d0ca6379894ef81670cf30af7fd081

Reason for revert: Power10 strncmp clobbers non-volatile vector
registers (Bug 33060)

Tested on ppc64le with no regressions.

2 weeks agomalloc: add testing for large tcache support
Cupertino Miranda [Mon, 16 Jun 2025 12:51:53 +0000 (12:51 +0000)] 
malloc: add testing for large tcache support

This patch adds large tcache support tests by re-executing malloc tests
using the tunable:  glibc.malloc.tcache_max=1048576
Test names are postfixed with "largetcache".

Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
2 weeks agomalloc: add tcache support for large chunk caching
Cupertino Miranda [Fri, 13 Jun 2025 15:29:59 +0000 (15:29 +0000)] 
malloc: add tcache support for large chunk caching

Existing tcache implementation in glibc seems to focus in caching
smaller data size allocations, limiting the size of the allocation to
1KB.

This patch changes tcache implementation to allow to cache any chunk
size allocations.  The implementation adds extra bins (linked-lists)
which store chunks with different ranges of allocation sizes. Bin
selection is done in multiples in powers of 2 and chunks are inserted in
growing size ordering within the bin.  The last bin contains all other
sizes of allocations.

This patch although by default preserves the same implementation,
limitting caches to 1KB chunks, it now allows to increase the max size
for the cached chunks with the tunable glibc.malloc.tcache_max.

It also now verifies if chunk was mmapped, in which case __libc_free
will not add it to tcache.

Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
2 weeks agoAlways check lockf64 return value
H.J. Lu [Sun, 15 Jun 2025 03:01:30 +0000 (11:01 +0800)] 
Always check lockf64 return value

On x86-64, when GCC 14.2.1 is used to build:

commit f3c82fc1b41261f582f5f9fa12f74af9bcbc88f9
Author: Radko Krkos <krkos@mail.muni.cz>
Date:   Sat Jun 14 11:07:40 2025 +0200

    io: Mark lockf() __wur [BZ #32800]

    In commit 0476597b28 flock() was marked __wur in posix/unistd.h, but not
    in io/fcntl.h, the declarations must match.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
I got

programs/locarchive.c: In function ‘open_archive’:
programs/locarchive.c:641:18: error: ignoring return value of ‘lockf64’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
  641 |           (void) lockf64 (fd, F_ULOCK, sizeof (struct locarhead));
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
programs/locarchive.c:653:14: error: ignoring return value of ‘lockf64’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
  653 |       (void) lockf64 (fd, F_ULOCK, sizeof (struct locarhead));
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
programs/locarchive.c:660:14: error: ignoring return value of ‘lockf64’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
  660 |       (void) lockf64 (fd, F_ULOCK, sizeof (struct locarhead));
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
programs/locarchive.c:679:14: error: ignoring return value of ‘lockf64’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
  679 |       (void) lockf64 (fd, F_ULOCK, sizeof (struct locarhead));
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Update locarchive.c to always check lockf64 return value.  This fixes
BZ #33089.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Reviewed-by: Florian Weimer <fweimer@redhat.com>
2 weeks agoelf: Add optimization barrier for __ehdr_start and _end
H.J. Lu [Sun, 15 Jun 2025 03:38:54 +0000 (11:38 +0800)] 
elf: Add optimization barrier for __ehdr_start and _end

rtld.c has

extern const ElfW(Ehdr) __ehdr_start attribute_hidden;
...
  _dl_rtld_map.l_map_start = (ElfW(Addr)) &__ehdr_start;
  _dl_rtld_map.l_map_end = (ElfW(Addr)) _end;

As

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120653

shows, compiler may generate run-time relocation on __ehdr_start with

movq .LC0(%rip), %xmm0
...
.section .data.rel.ro.local,"aw"
.align 8
.LC0:
.quad __ehdr_start

This won't work before run-time relocation is finished in rtld.c.  Add
optimization barrier to prevent run-time relocations against __ehdr_start
and _end.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Reviewed-by: Sam James <sam@gentoo.org>
2 weeks agohtl: move pthread_key_*, pthread_get/setspecific
gfleury [Fri, 13 Jun 2025 18:43:48 +0000 (20:43 +0200)] 
htl: move pthread_key_*, pthread_get/setspecific

Signed-off-by: gfleury <gfleury@disroot.org>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Message-ID: <20250613184440.1660335-1-gfleury@disroot.org>

2 weeks agoelf: Remove the unused _etext declaration
H.J. Lu [Sun, 15 Jun 2025 04:37:26 +0000 (12:37 +0800)] 
elf: Remove the unused _etext declaration

Since

commit 53df2ce6885da3d0e89e87dca7b095622296014f
Author: Florian Weimer <fweimer@redhat.com>
Date:   Fri Sep 8 13:02:06 2023 +0200

    elf: Remove unused l_text_end field from struct link_map

removed the only reference to _etext, also remove the unused _etext
declaration.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
2 weeks agoio: Mark lockf() __wur [BZ #32800]
Radko Krkos [Sat, 14 Jun 2025 09:07:40 +0000 (11:07 +0200)] 
io: Mark lockf() __wur [BZ #32800]

In commit 0476597b28 flock() was marked __wur in posix/unistd.h, but not
in io/fcntl.h, the declarations must match.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
2 weeks agobenchtests: Improve modf benchtest
Adhemerval Zanella [Wed, 28 May 2025 17:59:28 +0000 (14:59 -0300)] 
benchtests: Improve modf benchtest

It adds four ranges, which is how the generic implementation handles
normal numbers:

  1. Random inputs in the range [0.0, 1.0];
  2. Random inputs in the range [1.0, (double)(UINT64_C(1) << 52))];
  3. Random inputs in the range [(double)(UINT64_C(1) << 52), DBL_MAX];
  4. Random integral inputs in the range [0.0, (double)(UINT64_C(1) << 52)].

Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
2 weeks agobenchtests: Add modff benchtest
Adhemerval Zanella [Wed, 28 May 2025 17:59:27 +0000 (14:59 -0300)] 
benchtests: Add modff benchtest

It adds four ranges, which is how the generic implementation handles
normal numbers:

  1. Random inputs in the range [0.0, 1.0];
  2. Random inputs in the range [1.0, (float)(1U << 23)];
  3. Random inputs in the range [(float)(1U << 23), FLT_MAX];
  4. Random integral inputs in the range [0.0, (float)(1U << 23)].

Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
2 weeks agoriscv: Correct __riscv_hwprobe function prototype [BZ #32932]
Mark Harris [Sat, 24 May 2025 22:02:38 +0000 (15:02 -0700)] 
riscv: Correct __riscv_hwprobe function prototype [BZ #32932]

The third argument to __riscv_hwprobe is the size in bytes of the
cpu bitmask pointed to by the fourth argument, however in the access
attribute (read_only, 4, 3) it is used as an element count (i.e., the
number of unsigned longs that make up the bitmask), resulting in a
false compiler warning:

$ gcc -c hwprobe1.c
hwprobe1.c: In function 'main':
hwprobe1.c:15:11: warning: '__riscv_hwprobe' reading 1024 bytes from a region of size 128 [-Wstringop-overread]
   15 |     ret = __riscv_hwprobe (pairs, 1, sizeof(cpus), cpus, 0);
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
hwprobe1.c:9:23: note: source object 'cpus' of size 128
    9 |     unsigned long int cpus[16];
      |                       ^~~~
In file included from hwprobe1.c:1:
/usr/include/riscv64-linux-gnu/sys/hwprobe.h:66:12: note: in a call to function '__riscv_hwprobe' declared with attribute 'access (read_only, 4, 3)'
   66 | extern int __riscv_hwprobe (struct riscv_hwprobe *__pairs, size_t __pair_count,
      |            ^~~~~~~~~~~~~~~
$

The documentation (https://docs.kernel.org/arch/riscv/hwprobe.html)
claims that the cpu bitmask has the type cpu_set_t *, which would be
consistent with other functions that take a cpu bitmask such as
sched_setaffinity and sched_getaffinity.  It also uses the name
cpusetsize for the third argument, which is much more accurate than
cpu_count since it is a size in bytes and not a cpu count.  The
(read_only, 4, 3) access attribute in the glibc prototype claims
that the cpu bitmask is only read, however when flags is
RISCV_HWPROBE_WHICH_CPUS it is both read and written.

Therefore, in the glibc prototype the type of the fourth argument is
changed to cpu_set_t * to match the documentation, the name of the
third argument is changed to cpusetsize as in the documentation, and the
incorrect access attribute that applies to these arguments is removed.
Almost all existing callers pass a null pointer for the fourth
argument, however a transparent union is introduced for compatibility
with callers that cast a pointer to the old argument type, and a
macro is introduced allowing callers the ability to distinguish
between the old and new prototype when needed.

The access attributes are being specified with __fortified_attr_access,
however this macro is for fortified functions; the regular
__attr_access macro is for non-fortified functions such as this one.
Using the incorrect macro results in no access checks at fortify level
3, because it is assumed that the fortified function will be doing the
checking.  It is changed to use the correct macro so that the access
checks will work regardless of fortify level.

Also because __riscv_hwprobe is not a cancellation point, __THROW
is added, consistent with similar functions.  (However, it is omitted
from the typedef because GCC does not accept it there.)

The __wur (warn_unused_result) attribute is helpful for functions that
cannot be used safely without checking the result, however code such
as the following does not require the result to be checked and should
not produce a warning:
    struct riscv_hwprobe pair = { RISCV_HWPROBE_KEY_IMA_EXT_0, 0 };
    __riscv_hwprobe (&pair, 1, 0, NULL, 0);
    if (pair.value & RISCV_HWPROBE_EXT_ZBB) ...
Therefore this attribute is omitted.

The comment claiming that the second argument to the ifunc selector
is a pointer to the vDSO function is corrected.  It is a pointer to
the regular glibc function (which returns errors as positive values),
not the vDSO function (which returns errors as negative values).

Fixes commit 426d0e1aa8f17426d13707594111df712d2b8911 ("riscv: Add
Linux hwprobe syscall support").

Fixes: BZ #32932
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
Signed-off-by: Mark Harris <mark.hsj@gmail.com>
Reviewed-by: Palmer Dabbelt <palmer@dabbelt.com>
Acked-by: Palmer Dabbelt <palmer@dabbelt.com>
3 weeks agoresolv: Add test for getaddrinfo returning FQDN in ai_canonname
Sergey Kolosov [Tue, 3 Jun 2025 20:10:20 +0000 (22:10 +0200)] 
resolv: Add test for getaddrinfo returning FQDN in ai_canonname

Test for BZ #15218.  This test verifies that getaddrinfo returns a
fully-qualified domain name in the ai_canonname field then
AI_CANONNAME is set and search domains apply.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agoaarch64: fix typo in sysdeps/aarch64/Makefile
Yury Khrustalev [Tue, 10 Jun 2025 09:48:07 +0000 (10:48 +0100)] 
aarch64: fix typo in sysdeps/aarch64/Makefile

3 weeks agoAdvisory text for CVE-2025-5745
Siddhesh Poyarekar [Thu, 5 Jun 2025 19:24:49 +0000 (15:24 -0400)] 
Advisory text for CVE-2025-5745

The fix is not available yet, so this only records the first vulnerable
commit.

Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
3 weeks agoAdvisory text for CVE-2025-5702
Siddhesh Poyarekar [Thu, 5 Jun 2025 17:29:00 +0000 (13:29 -0400)] 
Advisory text for CVE-2025-5702

The fix is not available yet, so this only records the first vulnerable
commit.

Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
3 weeks agohurd: Make __getrandom_early_init call __mach_init
Samuel Thibault [Mon, 9 Jun 2025 08:29:48 +0000 (08:29 +0000)] 
hurd: Make __getrandom_early_init call __mach_init

25d37948c9f3 ("malloc: Improve malloc initialization") moved calling malloc
initialization earlier, within _dl_sysdep_start's call to dl_main, before
__mach_init is called by _dl_init_first. But malloc initialization uses
getrandom, which needs to make RPCs.

This adds __getrandom_early_init on hurd to express that getrandom needs
__mach_init too. This also adds a guard to avoid making it create several task
and host ports.

Fixes: 25d37948c9f3 ("malloc: Improve malloc initialization")
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
3 weeks agox86: Avoid GLRO(dl_x86_cpu_features)
H.J. Lu [Sun, 8 Jun 2025 23:45:57 +0000 (07:45 +0800)] 
x86: Avoid GLRO(dl_x86_cpu_features)

In init_cpu_features, replace GLRO(dl_x86_cpu_features) with
cpu_features to avoid an extra load.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agomanual: Add a comparative example of 'clock_nanosleep' use
Maciej W. Rozycki [Fri, 6 Jun 2025 17:14:34 +0000 (18:14 +0100)] 
manual: Add a comparative example of 'clock_nanosleep' use

Add an illustrative example of how to express 'nanosleep' in terms of
'clock_nanosleep'.

3 weeks agoAArch64: Fix builderror with GCC 12.1/12.2
Wilco Dijkstra [Fri, 6 Jun 2025 13:15:30 +0000 (13:15 +0000)] 
AArch64: Fix builderror with GCC 12.1/12.2

Early versions of GCC 12 didn't support -mtune=neoverse-v2, so use
-mtune=neoverse-v1 instead.

Reported-by: Yury Khrustalev <yury.khrustalev@arm.com>
3 weeks agoLinux: Drop obsolete kernel support with `if_nameindex' and `if_nametoindex'
Maciej W. Rozycki [Thu, 5 Jun 2025 18:04:46 +0000 (19:04 +0100)] 
Linux: Drop obsolete kernel support with `if_nameindex' and `if_nametoindex'

Support for the SIOCGIFINDEX ioctl(2) Linux ABI (0x8933 command, called
SIOGIFINDEX in the API originally) was added with kernel version 2.1.14
for AF_INET6 sockets, followed by general support with version 2.1.22.
The Linux API was then updated by adding the current SIOCGIFINDEX name
with kernel version 2.1.68, back in Nov 1997.

All these kernel versions are well below our current default required
minimum of 3.2.0, let alone some platform higher version requirements.

Drop support for the absence of the SIOCGIFINDEX ioctl(2) in the API or
ABI, by removing arrangements for the ENOSYS error condition.  Discard
the indirection from '__if_nameindex' to 'if_nameindex_netlink' and
adjust the implementation of '__if_nametoindex' accordingly for a better
code flow.

3 weeks agoaarch64: add __ifunc_hwcap function to be used in ifunc resolvers
Yury Khrustalev [Thu, 24 Apr 2025 15:58:46 +0000 (16:58 +0100)] 
aarch64: add __ifunc_hwcap function to be used in ifunc resolvers

Add a new helper function __ifunc_hwcap() as a portable way to
access HWCAP elements via the parameter(s) passed to an ifunc
resolver checking the _IFUNC_ARG_HWCAP bit in the first parameter
and size of the buffer in the second parameter.

Note that 0 is returned when the requested element is not available
or does not correspond to a valid AT_HWCAP{,2,...} value.

Also add relevant tests.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
3 weeks agoaarch64: add support for hwcap3,4
Yury Khrustalev [Wed, 12 Mar 2025 15:28:24 +0000 (15:28 +0000)] 
aarch64: add support for hwcap3,4

Add basic support for hwcap3 and hwcap4 in dynamic loader and
ifunc resolvers.

Describe new backward-compatible prototype for GNU indirect
function resolvers that use a pointer to uint64_t array in
stead of a pointer to the __ifunc_arg_t struct.

This patch also adds macro _IFUNC_HWCAP_MAX to specify current
number of hwcap elements.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
3 weeks agomanual: Document futimens and utimensat
Arjun Shankar [Wed, 4 Jun 2025 11:08:58 +0000 (13:08 +0200)] 
manual: Document futimens and utimensat

Document futimens and utimensat.  Also document the EINVAL error
condition for futimes.  It is inherited by futimens and utimensat as
well.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agomanual: Document unlinkat
Arjun Shankar [Wed, 4 Jun 2025 11:08:57 +0000 (13:08 +0200)] 
manual: Document unlinkat

Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agomanual: Document renameat
Arjun Shankar [Wed, 4 Jun 2025 11:08:56 +0000 (13:08 +0200)] 
manual: Document renameat

Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agomanual: Document mkdirat
Arjun Shankar [Wed, 4 Jun 2025 11:08:55 +0000 (13:08 +0200)] 
manual: Document mkdirat

Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agomanual: Document faccessat
Arjun Shankar [Wed, 4 Jun 2025 11:08:54 +0000 (13:08 +0200)] 
manual: Document faccessat

Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agomanual: Expand Descriptor-Relative Access section
Arjun Shankar [Wed, 4 Jun 2025 11:08:53 +0000 (13:08 +0200)] 
manual: Expand Descriptor-Relative Access section

Improve the clarity of the paragraphs describing common flags and add a
list of common error conditions for descriptor-relative functions.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agoMakefile: Avoid $(objpfx)/ in makefiles
Florian Weimer [Wed, 4 Jun 2025 15:44:19 +0000 (17:44 +0200)] 
Makefile: Avoid $(objpfx)/ in makefiles

If paths with both $(objpfx)/ and $(objpfx) (which already includes
a trailing slash) appear during the build, this can trigger unexpected
rebuilds, or incorrect concurrent rebuilds.

3 weeks agomanual: Document error codes missing for 'inet_pton'
Maciej W. Rozycki [Wed, 4 Jun 2025 15:27:20 +0000 (16:27 +0100)] 
manual: Document error codes missing for 'inet_pton'

Add documentation for EAFNOSUPPORT error code returned, and the possible
return values on non-success.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agomanual: Document error codes missing for 'if_nametoindex'
Maciej W. Rozycki [Wed, 4 Jun 2025 15:27:20 +0000 (16:27 +0100)] 
manual: Document error codes missing for 'if_nametoindex'

Add documentation for ENODEV error code returned and refer to 'socket'
for further possible codes from the underlying function call.

While changing the text clarify the description by mentioning 'ifname'.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agomanual: Document error codes missing for 'if_indextoname'
Maciej W. Rozycki [Wed, 4 Jun 2025 15:27:20 +0000 (16:27 +0100)] 
manual: Document error codes missing for 'if_indextoname'

Add documentation for ENXIO error code returned and refer to 'socket'
for further possible codes from the underlying function call.

While changing the text clarify the description by mentioning 'ifname'
and replace @code tags with @var ones where referring to a function
parameter.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agoposix: fix building regex when _LIBC isn't defined
Cœur [Tue, 3 Jun 2025 08:27:35 +0000 (10:27 +0200)] 
posix: fix building regex when _LIBC isn't defined

Reviewed-by: Florian Weimer <fweimer@redhat.com>
3 weeks agolocaledata: Use the name North Macedonia.
Collin Funk [Tue, 3 Jun 2025 19:50:15 +0000 (12:50 -0700)] 
localedata: Use the name North Macedonia.

The name "the former Yugoslav Republic of Macedonia" is no longer in use
since the signing of the Prespa Agreement [1][2].  This resolved the
country's naming dispute with Greece and changed the name to "North
Macedonia".

The name field of this locale/iso-3166.def is not used, so this does not
affect binaries.

[1] https://en.wikipedia.org/wiki/Prespa_Agreement
[2] https://treaties.un.org/Pages/showDetails.aspx?objid=0800000280544ac1

Signed-off-by: Collin Funk <collin.funk1@gmail.com>
Reviewed-by: Florian Weimer <fweimer@redhat.com>
4 weeks agomalloc: Count tcache entries downwards
Wilco Dijkstra [Wed, 9 Apr 2025 17:41:22 +0000 (17:41 +0000)] 
malloc: Count tcache entries downwards

Currently tcache requires 2 global variable accesses to determine
whether a block can be added to the tcache.  Change the counts array
to 'num_slots' to indicate the number of entries that could be added.
If 'num_slots' reaches zero, no more blocks can be added.  If the entries
pointer is not NULL, at least one block is available for allocation.

Now each tcache bin can support a different maximum number of entries,
and they can be individually switched on or off (a zero initialized
num_slots+entry means the tcache bin is not available for free or malloc).

Reviewed-by: DJ Delorie <dj@redhat.com>
4 weeks agosparc: Fix argument passing to __libc_start_main (BZ 32981)
Adhemerval Zanella [Fri, 30 May 2025 15:40:04 +0000 (12:40 -0300)] 
sparc: Fix argument passing to __libc_start_main (BZ 32981)

sparc start.S does not provide the final argument for
__libc_start_main, which is the highest stack address used to
update the __libc_stack_end.A

This fixes elf/tst-execstack-prog-static-tunable on sparc64.
On sparcv9 this does not happen because the kernel puts an
auxv value, which turns to point to a value in the stack itself.

Checked on sparc64-linux-gnu.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
4 weeks agolocaledata: Refer to Eswatini instead of Swaziland.
Collin Funk [Tue, 3 Jun 2025 08:53:12 +0000 (10:53 +0200)] 
localedata: Refer to Eswatini instead of Swaziland.

The name was changed in 2018 [1].

The name is not used in locale/programs/ld-address.c so this does not
change any binaries or data.

[1] https://www.un.org/en/about-us/member-states/eswatini

Signed-off-by: Collin Funk <collin.funk1@gmail.com>
Reviewed-by: Florian Weimer <fweimer@redhat.com>
4 weeks agosigaction: don't sign-extend sa_flags
наб [Tue, 3 Jun 2025 08:53:12 +0000 (10:53 +0200)] 
sigaction: don't sign-extend sa_flags

Before:
  rt_sigaction(SIGBUS, {sa_handler=0x55abb9960139, sa_mask=[], sa_flags=SA_RESTORER|SA_RESETHAND|SA_SIGINFO|0xffffffff00000000, sa_restorer=0x7fb1b2a82050}, NULL, 8) = 0

After:
  rt_sigaction(SIGBUS, {sa_handler=0x7f6a70dce139, sa_mask=[], sa_flags=SA_RESTORER|SA_RESETHAND|SA_SIGINFO, sa_restorer=0x7f6a70c28f60}, NULL, 8) = 0

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Reviewed-by: Florian Weimer <fweimer@redhat.com>