]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
5 years agoswitch to using virtual_server_get_process_by_name()
Alan T. DeKok [Mon, 1 Jun 2020 23:22:13 +0000 (19:22 -0400)] 
switch to using virtual_server_get_process_by_name()

instead of unlang_interpret_synchronous()

This change means that we have to run our own event loop.  But,
it also means that we just call the proto modules to do all of
the processing.  Which means that unit_test_module no longer
needs to know about any magic packet codes.  The proto_radius_auth
etc. functions take care of all of that.

5 years agoremove old cruft
Alan T. DeKok [Mon, 1 Jun 2020 23:21:08 +0000 (19:21 -0400)] 
remove old cruft

most of these had manual "update control cleartext-password"
which isn't necessary, as that's done in unit_test_module.conf

Also added "accept" in a few places, as it will be needed soon.

5 years agoremove assertion
Alan T. DeKok [Mon, 1 Jun 2020 23:05:09 +0000 (19:05 -0400)] 
remove assertion

it's no longer necessary, and unit_test_module doesn't always
add FDs to the event loop

5 years agomove error message to later in the code
Alan T. DeKok [Mon, 1 Jun 2020 23:04:21 +0000 (19:04 -0400)] 
move error message to later in the code

5 years agouse wait_for_event, to be the same as fr_worker()
Alan T. DeKok [Mon, 1 Jun 2020 22:48:03 +0000 (18:48 -0400)] 
use wait_for_event, to be the same as fr_worker()

5 years agoadd test case for "call"
Alan T. DeKok [Mon, 1 Jun 2020 22:33:22 +0000 (18:33 -0400)] 
add test case for "call"

5 years agomake "call" work correctly
Alan T. DeKok [Mon, 1 Jun 2020 22:29:31 +0000 (18:29 -0400)] 
make "call" work correctly

and fix virtual_server_get_process_by_name()

5 years agoset name / debug_name for "call"
Alan T. DeKok [Mon, 1 Jun 2020 20:44:41 +0000 (16:44 -0400)] 
set name / debug_name for "call"

5 years agoinitialize "dl" to shut up scanner
Alan T. DeKok [Mon, 1 Jun 2020 20:36:17 +0000 (16:36 -0400)] 
initialize "dl" to shut up scanner

5 years agoshould should be module_method_t*, not **
Alan T. DeKok [Mon, 1 Jun 2020 20:26:27 +0000 (16:26 -0400)] 
should should be module_method_t*, not **

5 years agofree this, too
Alan T. DeKok [Mon, 1 Jun 2020 20:17:38 +0000 (16:17 -0400)] 
free this, too

5 years agomove "get process function / ctx" to common API
Alan T. DeKok [Mon, 1 Jun 2020 17:07:46 +0000 (13:07 -0400)] 
move "get process function / ctx" to common API

where we may be able to use it with unit_test_module

5 years agoexplictly free it
Alan T. DeKok [Mon, 1 Jun 2020 16:41:33 +0000 (12:41 -0400)] 
explictly free it

5 years agoswtich to using our own dl_loader ctx
Alan T. DeKok [Mon, 1 Jun 2020 15:44:19 +0000 (11:44 -0400)] 
swtich to using our own dl_loader ctx

5 years agowe no longer need to link against libfreeradius-radius
Alan T. DeKok [Mon, 1 Jun 2020 15:13:28 +0000 (11:13 -0400)] 
we no longer need to link against libfreeradius-radius

5 years agofr_cap_net_raw: Don't return an error if the capability is already in the effective set
Arran Cudbard-Bell [Mon, 1 Jun 2020 15:35:57 +0000 (10:35 -0500)] 
fr_cap_net_raw: Don't return an error if the capability is already in the effective set

5 years agoOutput what script we're calling
Arran Cudbard-Bell [Sun, 31 May 2020 17:04:02 +0000 (12:04 -0500)] 
Output what script we're calling

5 years agouse standard names
Alan T. DeKok [Sun, 31 May 2020 13:40:46 +0000 (09:40 -0400)] 
use standard names

5 years agomore pedantic checks for re-registration
Alan T. DeKok [Sun, 31 May 2020 13:24:23 +0000 (09:24 -0400)] 
more pedantic checks for re-registration

if it's the same func / type / whatever, just return the same thing.
If it's different, error out.

5 years agothese need to link to the io library, too
Alan T. DeKok [Sat, 30 May 2020 23:02:38 +0000 (19:02 -0400)] 
these need to link to the io library, too

5 years agoverify that unit_test_module can send and receive dhcpv4 packets
Alan T. DeKok [Sat, 30 May 2020 22:46:32 +0000 (18:46 -0400)] 
verify that unit_test_module can send and receive dhcpv4 packets

5 years agoadd client function for unit_test_module
Alan T. DeKok [Sat, 30 May 2020 22:46:13 +0000 (18:46 -0400)] 
add client function for unit_test_module

5 years agomore sanity checks
Alan T. DeKok [Sat, 30 May 2020 22:45:29 +0000 (18:45 -0400)] 
more sanity checks

that the "default" virtual server exists, and has the same
namespace as we were told to use

5 years agocheck that unit_test_module can send CoA-Request packets
Alan T. DeKok [Sat, 30 May 2020 15:15:30 +0000 (11:15 -0400)] 
check that unit_test_module can send CoA-Request packets

5 years agoallow for "server dhcpv4"
Alan T. DeKok [Sat, 30 May 2020 15:01:16 +0000 (11:01 -0400)] 
allow for "server dhcpv4"

and fall back to "server default" if the protocol-specific
server does not exist.

5 years agolet's parse "-p"
Alan T. DeKok [Sat, 30 May 2020 14:15:12 +0000 (10:15 -0400)] 
let's parse "-p"

5 years agoFix redis-setup.sh
Arran Cudbard-Bell [Sat, 30 May 2020 00:50:31 +0000 (19:50 -0500)] 
Fix redis-setup.sh

5 years agocc smarter than bb 3469/head
Arran Cudbard-Bell [Fri, 29 May 2020 17:35:09 +0000 (12:35 -0500)] 
cc smarter than bb

5 years agotrunk: Remove unecessary assert
Arran Cudbard-Bell [Fri, 29 May 2020 17:16:39 +0000 (12:16 -0500)] 
trunk: Remove unecessary assert

5 years agowe don't use RST any more
Alan T. DeKok [Fri, 29 May 2020 17:00:15 +0000 (13:00 -0400)] 
we don't use RST any more

5 years agoremove the last bits of RADIUS specific knowledge
Alan T. DeKok [Fri, 29 May 2020 16:34:17 +0000 (12:34 -0400)] 
remove the last bits of RADIUS specific knowledge

the program should now handle both CoA packets, which it didn't
before.  And, once the protocol libraries are updated a bit,
also handle dhcpv4 and dhcpv6

5 years agoadd function to turn unlang ok / fail to reply packet code
Alan T. DeKok [Fri, 29 May 2020 16:31:39 +0000 (12:31 -0400)] 
add function to turn unlang ok / fail to reply packet code

in reality, this function just gets asked ok / fail as a bool, and
returns the appropriate packet code.

This is for use only by unit_test_module.  That program runs
unlang, and then needs to set the correct reply packet type.
This reply packet type depends both on the request packet type,
and on the unlang status ok / fail.

In order to make unit_test_module protocol agnostic, we export
a function in the RADIUS library to help it out.

5 years agoexport functions which return ok / fail packet codes
Alan T. DeKok [Fri, 29 May 2020 16:25:09 +0000 (12:25 -0400)] 
export functions which return ok / fail packet codes

these functions are only for use with unit_test_module

5 years agodhcpv4: Don't conflate src and dst MACs when broadcasting
Terry Burton [Thu, 28 May 2020 18:26:39 +0000 (19:26 +0100)] 
dhcpv4: Don't conflate src and dst MACs when broadcasting

5 years agoinitialize variables
Alan T. DeKok [Fri, 29 May 2020 13:34:41 +0000 (09:34 -0400)] 
initialize variables

the scanner cannot see that a called function will initialize
this structure, so we have to do it here.

5 years agoshut up compiler.
Alan T. DeKok [Fri, 29 May 2020 13:27:24 +0000 (09:27 -0400)] 
shut up compiler.

5 years agotypo
Alan T. DeKok [Fri, 29 May 2020 13:22:39 +0000 (09:22 -0400)] 
typo

5 years agoarmour FDs against more issues, and assert that kqueue won't lock
Alan T. DeKok [Fri, 29 May 2020 12:51:23 +0000 (08:51 -0400)] 
armour FDs against more issues, and assert that kqueue won't lock

5 years agosimplify the code
Alan T. DeKok [Fri, 29 May 2020 00:05:52 +0000 (20:05 -0400)] 
simplify the code

5 years agoremove more hard-coded RADIUS things.
Alan T. DeKok [Thu, 28 May 2020 16:17:16 +0000 (12:17 -0400)] 
remove more hard-coded RADIUS things.

We will need to test other protocols at some point, so fixing
this is reasonable

5 years agowe don't use the "unit_test" virtual server for anything
Alan T. DeKok [Thu, 28 May 2020 16:07:47 +0000 (12:07 -0400)] 
we don't use the "unit_test" virtual server for anything

the rest of the code uses the "default" virtual server.

5 years agoremove more hard-coded "radius"
Alan T. DeKok [Thu, 28 May 2020 16:06:43 +0000 (12:06 -0400)] 
remove more hard-coded "radius"

5 years agoFix _tmpl_to_type
Arran Cudbard-Bell [Thu, 28 May 2020 23:38:12 +0000 (18:38 -0500)] 
Fix _tmpl_to_type

5 years agovalue: Fix referencing
Arran Cudbard-Bell [Thu, 28 May 2020 23:32:14 +0000 (18:32 -0500)] 
value: Fix referencing

5 years agopair: Fix pair copy
Arran Cudbard-Bell [Thu, 28 May 2020 23:27:59 +0000 (18:27 -0500)] 
pair: Fix pair copy

5 years agoRemove unused box
Arran Cudbard-Bell [Thu, 28 May 2020 23:22:35 +0000 (18:22 -0500)] 
Remove unused box

5 years agosnmp: Use the proper boxing functions
Arran Cudbard-Bell [Thu, 28 May 2020 23:02:11 +0000 (18:02 -0500)] 
snmp: Use the proper boxing functions

5 years agointerpreter: Allow frame states to be allocated without allocating memory for a frame...
Arran Cudbard-Bell [Thu, 28 May 2020 23:00:41 +0000 (18:00 -0500)] 
interpreter: Allow frame states to be allocated without allocating memory for a frame state structure

It's useful for scratch space where we don't need to store state between calls

5 years agoRemove unused tmpl functions
Arran Cudbard-Bell [Thu, 28 May 2020 19:41:32 +0000 (14:41 -0500)] 
Remove unused tmpl functions

5 years agoQuiet clang scan
Arran Cudbard-Bell [Thu, 28 May 2020 18:42:16 +0000 (13:42 -0500)] 
Quiet clang scan

5 years agoUse structs for ifid and ethernet
Arran Cudbard-Bell [Thu, 28 May 2020 18:33:26 +0000 (13:33 -0500)] 
Use structs for ifid and ethernet

5 years agoMore FR_DBUFF_RESERVE/MAX variants
Arran Cudbard-Bell [Thu, 28 May 2020 17:24:46 +0000 (12:24 -0500)] 
More FR_DBUFF_RESERVE/MAX variants

5 years agodbuff: Separate creating parent list from advancement
Arran Cudbard-Bell [Wed, 27 May 2020 17:15:29 +0000 (12:15 -0500)] 
dbuff: Separate creating parent list from advancement

5 years agomanually create CHAP-Password
Alan T. DeKok [Thu, 28 May 2020 14:31:48 +0000 (10:31 -0400)] 
manually create CHAP-Password

5 years agoallow specifying `-p protocol` for radius, dhcpv4, etc
Alan T. DeKok [Thu, 28 May 2020 14:11:16 +0000 (10:11 -0400)] 
allow specifying `-p protocol` for radius, dhcpv4, etc

5 years agoremove manual encoding of CHAP password
Alan T. DeKok [Thu, 28 May 2020 13:31:02 +0000 (09:31 -0400)] 
remove manual encoding of CHAP password

it's not used and not needed.

5 years agoremove unused attributes
Alan T. DeKok [Thu, 28 May 2020 13:25:01 +0000 (09:25 -0400)] 
remove unused attributes

5 years agotime used should always be "now"
Alan T. DeKok [Wed, 27 May 2020 15:35:40 +0000 (11:35 -0400)] 
time used should always be "now"

5 years agocache interface MAC
Alan T. DeKok [Wed, 27 May 2020 14:08:47 +0000 (10:08 -0400)] 
cache interface MAC

so that we can automatically add a Server-Id attribute

5 years agounnecessary whitespace
Alan T. DeKok [Wed, 27 May 2020 14:08:27 +0000 (10:08 -0400)] 
unnecessary whitespace

5 years agoadd API to get ethernet address from interface
Alan T. DeKok [Wed, 27 May 2020 13:57:08 +0000 (09:57 -0400)] 
add API to get ethernet address from interface

5 years agodefine and decode ethernet address for client / server ID
Alan T. DeKok [Wed, 27 May 2020 13:10:06 +0000 (09:10 -0400)] 
define and decode ethernet address for client / server ID

5 years agodocument multicast + unicast default listeners
Alan T. DeKok [Wed, 27 May 2020 12:37:41 +0000 (08:37 -0400)] 
document multicast + unicast default listeners

5 years agolet's have this compile, okay?
Alan T. DeKok [Wed, 27 May 2020 12:34:17 +0000 (08:34 -0400)] 
let's have this compile, okay?

5 years agomove functions to better location
Alan T. DeKok [Mon, 25 May 2020 23:20:33 +0000 (19:20 -0400)] 
move functions to better location

5 years agoReword cassandra-install.sh
Arran Cudbard-Bell [Tue, 26 May 2020 16:29:29 +0000 (11:29 -0500)] 
Reword cassandra-install.sh

5 years agoTypo
Arran Cudbard-Bell [Tue, 26 May 2020 03:46:40 +0000 (22:46 -0500)] 
Typo

5 years agopair/value: Remove final calls to memsteal and bstrsteal
Arran Cudbard-Bell [Tue, 26 May 2020 03:34:50 +0000 (22:34 -0500)] 
pair/value: Remove final calls to memsteal and bstrsteal

5 years agoinet: Static buffer size
Arran Cudbard-Bell [Mon, 25 May 2020 23:24:31 +0000 (18:24 -0500)] 
inet: Static buffer size

5 years agoexpose fr_dhcpv6_option_find() function
Alan T. DeKok [Mon, 25 May 2020 23:14:11 +0000 (19:14 -0400)] 
expose fr_dhcpv6_option_find() function

5 years agoACK the client ID if the admin didn't add one
Alan T. DeKok [Mon, 25 May 2020 21:38:35 +0000 (17:38 -0400)] 
ACK the client ID if the admin didn't add one

We also need to set a server identifier somewhere

5 years agoclean up.
Alan T. DeKok [Mon, 25 May 2020 21:09:47 +0000 (17:09 -0400)] 
clean up.

* if we have interface but no ipaddr, then try to set ipaddr
  from a link-local address on that interface

* check for multicast differently.  We assume that the admin
  will configure one link-local "listen" section, and another
  multicase "listen" section

* set src_ipaddr == ipaddr for link-local addresses

* for multicast, require interface to be set, AND set src_ipaddr
  to the link-local address on that interface

5 years agoadd fr_interface_to_ipaddr()
Alan T. DeKok [Mon, 25 May 2020 21:03:19 +0000 (17:03 -0400)] 
add fr_interface_to_ipaddr()

which grabs an IP from an interface

5 years agoNAKs are 1 byte
Alan T. DeKok [Mon, 25 May 2020 21:02:43 +0000 (17:02 -0400)] 
NAKs are 1 byte

5 years agoset packet->code
Alan T. DeKok [Mon, 25 May 2020 15:27:16 +0000 (11:27 -0400)] 
set packet->code

5 years agoRemove more memsteal and bstrsteal
Arran Cudbard-Bell [Mon, 25 May 2020 21:16:58 +0000 (16:16 -0500)] 
Remove more memsteal and bstrsteal

5 years agoradclient: Fix radclient_init return check
Arran Cudbard-Bell [Mon, 25 May 2020 17:43:15 +0000 (12:43 -0500)] 
radclient: Fix radclient_init return check

5 years agoIs it cap causing travis to fail?
Arran Cudbard-Bell [Mon, 25 May 2020 17:27:31 +0000 (12:27 -0500)] 
Is it cap causing travis to fail?

5 years agohalf the test is to make sure the process can do its own cap requesting
Arran Cudbard-Bell [Mon, 25 May 2020 16:46:22 +0000 (11:46 -0500)] 
half the test is to make sure the process can do its own cap requesting

5 years agodl: Remove search path from dl_loader_init and default to the libdir set by autoconf
Arran Cudbard-Bell [Mon, 25 May 2020 16:41:03 +0000 (11:41 -0500)] 
dl: Remove search path from dl_loader_init and default to the libdir set by autoconf

add dl_search_path_prepend and dl_search_path_append to add extra components to the search path, and use those to add auxilliary search paths.

Hopefully have better luck loading the dictionary validation libraries now...

5 years agomore typos
Arran Cudbard-Bell [Mon, 25 May 2020 16:09:49 +0000 (11:09 -0500)] 
more typos

5 years agoAdd this back in...
Arran Cudbard-Bell [Mon, 25 May 2020 15:39:12 +0000 (10:39 -0500)] 
Add this back in...

5 years agotypo
Alan T. DeKok [Mon, 25 May 2020 14:59:18 +0000 (10:59 -0400)] 
typo

5 years agonot all binaries are radiusd
Alan T. DeKok [Mon, 25 May 2020 14:55:55 +0000 (10:55 -0400)] 
not all binaries are radiusd

5 years agodo setcap on travis for unit_test_module and radiusd
Alan T. DeKok [Mon, 25 May 2020 14:50:59 +0000 (10:50 -0400)] 
do setcap on travis for unit_test_module and radiusd

so that we can do ICMP tests, ARP tests, DHCPv4 raw socket tests,
among others.

5 years agoTypo
Arran Cudbard-Bell [Mon, 25 May 2020 14:51:30 +0000 (09:51 -0500)] 
Typo

5 years agosocket: Put cap command on a different line
Arran Cudbard-Bell [Mon, 25 May 2020 14:32:12 +0000 (09:32 -0500)] 
socket: Put cap command on a different line

5 years agoicmp: Move instantiation functions
Arran Cudbard-Bell [Mon, 25 May 2020 14:16:29 +0000 (09:16 -0500)] 
icmp: Move instantiation functions

Make a get cap failure, a fatal error (if we're not running as root)

5 years agoTypo
Arran Cudbard-Bell [Mon, 25 May 2020 13:19:10 +0000 (08:19 -0500)] 
Typo

5 years agopair: Remove more memsteal uses
Arran Cudbard-Bell [Mon, 25 May 2020 03:13:38 +0000 (22:13 -0500)] 
pair: Remove more memsteal uses

5 years agopair: remove more bstrsteal uses
Arran Cudbard-Bell [Mon, 25 May 2020 02:49:39 +0000 (21:49 -0500)] 
pair: remove more bstrsteal uses

5 years agoFix const issues
Arran Cudbard-Bell [Mon, 25 May 2020 02:47:01 +0000 (21:47 -0500)] 
Fix const issues

5 years agovalue/pair: Consistency fixes in assignment APIs
Arran Cudbard-Bell [Mon, 25 May 2020 02:22:02 +0000 (21:22 -0500)] 
value/pair: Consistency fixes in assignment APIs

5 years agos/fr_pair_value_strcpy/fr_pair_value_strdup/g
Arran Cudbard-Bell [Mon, 25 May 2020 00:10:13 +0000 (19:10 -0500)] 
s/fr_pair_value_strcpy/fr_pair_value_strdup/g

5 years agovalue: Remove some calls to fr_value_box_bstrsteal
Arran Cudbard-Bell [Mon, 25 May 2020 00:05:47 +0000 (19:05 -0500)] 
value: Remove some calls to fr_value_box_bstrsteal

5 years agoyubikey: Just trim the existing buffer, don't allocate a new one
Arran Cudbard-Bell [Sun, 24 May 2020 22:17:41 +0000 (17:17 -0500)] 
yubikey: Just trim the existing buffer, don't allocate a new one

5 years agopair/value: Add utility functions for clearing values
Arran Cudbard-Bell [Sun, 24 May 2020 22:11:20 +0000 (17:11 -0500)] 
pair/value: Add utility functions for clearing values

5 years agovalue/pair: Add re-alloc functions to change the length of a buffer
Arran Cudbard-Bell [Sun, 24 May 2020 21:39:31 +0000 (16:39 -0500)] 
value/pair: Add re-alloc functions to change the length of a buffer

5 years agovalue: Remove bstrnsteal functions
Arran Cudbard-Bell [Sun, 24 May 2020 20:04:40 +0000 (15:04 -0500)] 
value: Remove bstrnsteal functions

5 years agoJust clear the value, don't trash the metadata
Arran Cudbard-Bell [Sun, 24 May 2020 20:03:16 +0000 (15:03 -0500)] 
Just clear the value, don't trash the metadata