]>
git.ipfire.org Git - thirdparty/dovecot/core.git/log
Timo Sirainen [Sun, 30 Apr 2017 09:31:48 +0000 (12:31 +0300)]
dsync: Try to commit transactions every dsync_commit_msgs_interval messages
This was first attempted to be implemented by
ec0cc8fa647794e44a1afaa448f495a713048dc4 , but it was later partially
reverted by
5973d496b16721af6d2c1fa90b016aacddf13554 . This current
commit should fix its problems.
Timo Sirainen [Tue, 16 May 2017 14:53:23 +0000 (17:53 +0300)]
auth: If passdb/userdb ldap has blocking=yes, auth master shouldn't connect to ldap
Stephan Bosch [Mon, 8 May 2017 10:49:39 +0000 (12:49 +0200)]
util: script: Increased the major protocol version due to earlier changes.
Stephan Bosch [Tue, 9 May 2017 11:33:23 +0000 (13:33 +0200)]
util: script: Amended protocol with the ability to convey a set of environment variables that are passed to the script.
The acceptable environment variables are selected using the -e parameter; others are ignored silently.
Stephan Bosch [Mon, 8 May 2017 10:48:08 +0000 (12:48 +0200)]
util: script: Amended the protocol to pass arguments escaped to prevent problems with newlines.
Newlines are used as argument delimiters in the protocol, which will cause problems.
Stephan Bosch [Tue, 9 May 2017 11:43:39 +0000 (13:43 +0200)]
lib-program-client: local: Fixed use of unterminated string array of environment variables in exec_child().
Stephan Bosch [Tue, 9 May 2017 12:22:06 +0000 (14:22 +0200)]
lib-program-client: Made the test suite ignore the protocol version.
Aki Tuomi [Mon, 15 May 2017 12:35:37 +0000 (15:35 +0300)]
mail-crypt-plugin: Set copy-hook only if save_version > 0
Otherwise we might use it in read-only mode, too.
Timo Sirainen [Wed, 10 May 2017 09:44:25 +0000 (12:44 +0300)]
doveadm mailbox status: Add "firstsaved" field.
Timo Sirainen [Thu, 4 May 2017 16:59:41 +0000 (19:59 +0300)]
imapc: Try to merge STOREs together as much as possible when syncing
Timo Sirainen [Fri, 5 May 2017 12:20:05 +0000 (15:20 +0300)]
lib-storage: Avoid unnecessary UIDNEXT lookups after saving a mail
The vsize checking code was expecting that this would always be a cheap
operation, but with imapc code it could trigger a remote STATUS (UIDNEXT)
call. Do this only when we've checked that this mailbox is updating vsize
header at all.
Timo Sirainen [Fri, 12 May 2017 12:42:31 +0000 (15:42 +0300)]
imapc-quota: Avoid sending unnecessarily many GETQUOTA[ROOT] commands
The last_refresh == ioloop_timeval check didn't work, because the refresh
itself updated ioloop_timeval. This caused a single quota lookup to issue
multiple GETQUOTA[ROOT] commands to imapc.
Josef 'Jeff' Sipek [Fri, 12 May 2017 09:44:27 +0000 (12:44 +0300)]
lib-storage: add a mail user pre-deinit vfunc
This allows plugins to perform checks right before the deinit call.
Timo Sirainen [Fri, 12 May 2017 08:13:09 +0000 (11:13 +0300)]
lib-storage: Add missing ATTR_FORMAT to mail_set_mail_cache_corrupted()
Stephan Bosch [Fri, 12 May 2017 00:37:22 +0000 (02:37 +0200)]
Added doc/man/doveadm-save.1 to .gitignore.
Aki Tuomi [Thu, 11 May 2017 06:24:57 +0000 (09:24 +0300)]
doc: Add manpage for doveadm-save
Aki Tuomi [Tue, 9 May 2017 11:01:07 +0000 (14:01 +0300)]
lib-storage: Use new mail_cache_set_seq_corrupted_reason
Aki Tuomi [Tue, 9 May 2017 11:00:38 +0000 (14:00 +0300)]
lib-index: Add mail_cache_set_seq_corrupted_reason
Marks a seq in cache corrupted, and removes
that instead of the whole cache.
Aki Tuomi [Tue, 9 May 2017 11:29:04 +0000 (14:29 +0300)]
lib-index: Add mail_cache_expunge_count
It can be called to correctly handle cache counters
when records are removed.
Aki Tuomi [Wed, 10 May 2017 09:40:27 +0000 (12:40 +0300)]
ssl-proxy-openssl: Fix comparison to stricly boolean
Josef 'Jeff' Sipek [Tue, 9 May 2017 09:51:49 +0000 (12:51 +0300)]
{lib,lib-fts}: fix builds with BSD make
Without this change, BSD make doesn't know how to make a couple of the
generated files because the BUILT_SOURCES file names don't match exactly
the left hand sides of the rules. (GNU make somehow manages to match the
rule even though it is not an exact match.)
Josef 'Jeff' Sipek [Tue, 9 May 2017 09:43:46 +0000 (12:43 +0300)]
lib: use full path to unicode data script
This is a step toward fixing builds where object dir != source dir.
Josef 'Jeff' Sipek [Tue, 9 May 2017 09:42:48 +0000 (12:42 +0300)]
lib-fts: use full path to word-properties script
This is a step toward fixing builds where object dir != source dir.
Josef 'Jeff' Sipek [Tue, 9 May 2017 09:36:40 +0000 (12:36 +0300)]
lib-fts: download data files into srcdir
This is a step toward fixing builds where object dir != source dir.
Josef 'Jeff' Sipek [Tue, 9 May 2017 09:34:40 +0000 (12:34 +0300)]
lib: download unicode data into srcdir
This is a step toward fixing builds where object dir != source dir.
Josef 'Jeff' Sipek [Wed, 10 May 2017 07:55:49 +0000 (10:55 +0300)]
remove mystery file that appears to be unused
Timo Sirainen [Tue, 2 May 2017 15:40:43 +0000 (18:40 +0300)]
master: Send SIGQUIT to processes running at deinit to close socket listeners.
This allows Dovecot to be restarted even when some lmtp/doveadm process is
running for a long time. Otherwise it would keep the inet_listener socket
open and prevent the new Dovecot from binding to the port.
Timo Sirainen [Tue, 2 May 2017 13:13:08 +0000 (16:13 +0300)]
lib-master: When running under master, close listeners immediately on SIGQUIT
Timo Sirainen [Tue, 2 May 2017 15:39:06 +0000 (18:39 +0300)]
lib-master: Remove listener's IO earlier if possible
This is needed for the next change to work properly.
Timo Sirainen [Tue, 2 May 2017 12:56:40 +0000 (15:56 +0300)]
master: Wait more precisely 5 secs at deinit for child processes to die.
Use milliseconds granularity instead of seconds.
Timo Sirainen [Tue, 2 May 2017 12:41:41 +0000 (15:41 +0300)]
lib: Use lib_signals_syscall_error() for write() failure in signal handler
Timo Sirainen [Tue, 2 May 2017 12:41:04 +0000 (15:41 +0300)]
lib: Add lib_signals_syscall_error()
Timo Sirainen [Tue, 2 May 2017 12:38:00 +0000 (15:38 +0300)]
lib: Add dec2str_buf()
Timo Sirainen [Tue, 9 May 2017 10:15:42 +0000 (13:15 +0300)]
man: Fix doveadm-flags examples
Patch by Frank Ebert
Aki Tuomi [Tue, 9 May 2017 09:25:49 +0000 (12:25 +0300)]
auth: Do not use AUTH_SUBSYS_MECH in logging when request->mech is NULL
This can happen when a lookup is done instead of authentication.
Fixes auth: Panic: file auth-request.c: line 2560 (get_log_prefix): assertion failed: (auth_request->mech != NULL)
Josef 'Jeff' Sipek [Tue, 9 May 2017 07:07:55 +0000 (10:07 +0300)]
configure: Remove --with-storages parameter
Just compile all the storages, since the only benefit in limiting them
is to save a tiny bit of disk space. The recently added imapc quota code
fails to link if imapc storage isn't compiled in. This is the simplest
way to fix that.
Aki Tuomi [Thu, 6 Apr 2017 13:09:00 +0000 (16:09 +0300)]
lib-master,login-common: Add dual cert support
Adds new settings ssl_alt_cert and ssl_alt_key
Phil Carmody [Mon, 6 Mar 2017 17:42:18 +0000 (19:42 +0200)]
lib-fs: unit tests for fs-api/fs-posix
A core component, really ought to be covered by the unit tests.
This barely scrapes the surface, but is better than nothing:
filesystem/files/iterators, read/write/exists, good and bad cases.
Signed-off-by: Phil Carmody <phil@dovecot.fi>
Aki Tuomi [Mon, 8 May 2017 09:24:52 +0000 (12:24 +0300)]
passdb-imap: Make sure ssl verification is possible with current settings
Aki Tuomi [Mon, 8 May 2017 09:24:21 +0000 (12:24 +0300)]
passdb-imap: Add ssl_ca_file setting
Allow setting SSL trust roots from a file
Aki Tuomi [Fri, 28 Apr 2017 17:28:23 +0000 (20:28 +0300)]
passdb-imap: Add option to control certificate verification
Turn it on by default
Aki Tuomi [Mon, 8 May 2017 10:35:35 +0000 (13:35 +0300)]
lib-ssl-iostream: Support IP address SANs
Stephan Bosch [Sun, 6 Nov 2016 00:33:04 +0000 (01:33 +0100)]
lib-lda: mail-send: Compose var_expand table only once.
Stephan Bosch [Sun, 6 Nov 2016 12:17:26 +0000 (13:17 +0100)]
lib-lda: mail-send: Fixed debug message in mail_send_rejection() to use correct address.
Stephan Bosch [Sat, 5 Nov 2016 16:44:07 +0000 (17:44 +0100)]
lib-lda: Fixed indentation in mail-send.c.
Aki Tuomi [Thu, 4 May 2017 06:14:17 +0000 (09:14 +0300)]
mail-crypt: Re-encrypt mails when copying/moving
Otherwise the mail cannot be opened after moving
Timo Sirainen [Fri, 5 May 2017 09:35:23 +0000 (12:35 +0300)]
imap: Set FETCH transactions hidden only when \Seen flags are implicitly set
This simplifies implementing some plugins and has no downsides to core
functionality.
Timo Sirainen [Thu, 4 May 2017 14:31:47 +0000 (17:31 +0300)]
lib-storage: Fix memory leak in mail_search_args_simplify()
The leaks happened when search args were already initialized (which they
usually were at this point) and some of the args were dropped entirely.
Improved the unit test to initialize search args before calling the
simplify, so valgrind would notice if there are any leaks.
Stephan Bosch [Mon, 3 Apr 2017 22:32:07 +0000 (00:32 +0200)]
lib-http: client: Fixed race condition between DNS refresh lookup and a soft connection timeout.
The refreshing DNS lookup cleared all the IPs, but the soft connection timeout (and maybe other code) still relied on them.
Adding tests everywhere for host->ips_count == 0 is annoying, so I changed the DNS lookup code such that the stale IPs remain present while the DNS lookup is being performed.
The pending lookup prevents new connections through http_client_host_refresh(), so this will not create potentially useless connections.
Timo Sirainen [Tue, 2 May 2017 09:18:40 +0000 (12:18 +0300)]
lib-imap: imap_append_string_for_humans() - Change CR/LF to space
Practically this shouldn't matter, because in email headers a CR/LF is
always followed by a space/tab. But maybe this can be used for some
other purposes in future, and it makes the unit tests clearer. :)
Timo Sirainen [Tue, 2 May 2017 14:57:40 +0000 (17:57 +0300)]
lmtp: Fix assert-crash when proxy overrides mail_max_lock_timeout
Time unit is required or the call fails.
Timo Sirainen [Tue, 2 May 2017 12:02:25 +0000 (15:02 +0300)]
lib-master: Add comments to struct master_service_connection
Stephan Bosch [Mon, 1 May 2017 20:23:36 +0000 (22:23 +0200)]
lib-index: mail-index-transaction-export: Fixed handling of transaction_flag_updates_have_non_internal() return value.
Found using Clang -Wstrict-bool.
Stephan Bosch [Mon, 1 May 2017 20:19:43 +0000 (22:19 +0200)]
lib-imap-client: Fixed NULL check in assertion to be proper boolean.
Found using Clang -Wstrict-bool.
Aki Tuomi [Fri, 28 Apr 2017 11:42:31 +0000 (14:42 +0300)]
auth: Organize code into two unit tests
auth-cache needs special setup
Timo Sirainen [Fri, 28 Apr 2017 11:35:36 +0000 (14:35 +0300)]
lib-storage: When save is aborted, close dest_mail without crashing
Fixes:
Panic: file mail-index-transaction-update.c: line 1023 (mail_index_update_ext): assertion failed: (seq > 0 && (seq <= mail_index_view_get_messages_count(t->view) || seq <= t->last_new_seq))
Because cache was still attempted to be updated, but the mail was already
expunged from index.
Timo Sirainen [Fri, 28 Apr 2017 11:06:43 +0000 (14:06 +0300)]
lib-storage: Move backend code to a common index_storage_save_abort_last()
Aki Tuomi [Thu, 27 Apr 2017 11:09:08 +0000 (14:09 +0300)]
auth: Log reason for skipping passdb
Aki Tuomi [Fri, 28 Apr 2017 09:49:37 +0000 (12:49 +0300)]
auth: Add test suite for username filter
Aki Tuomi [Fri, 28 Apr 2017 09:51:20 +0000 (12:51 +0300)]
auth: Add username_filter for passdb block
username_filter lets you specify one or more pattern(s) for
including or excluding users. exclusion patterns are denoted
with ! prefix.
if any exclude matches the username, passdb will be skipped.
if any inclusions is specified, and the username does not match
one of them, passdb will be skipped.
Aki Tuomi [Thu, 27 Apr 2017 08:53:13 +0000 (11:53 +0300)]
auth: Use MECH subsystem when logging error about skipping all password databases
Otherwise it will assert-crash because all password databases were skipped.
Aki Tuomi [Fri, 28 Apr 2017 07:25:14 +0000 (10:25 +0300)]
auth: Refactor auth to use libauth.la
This makes writing new unit tests easier, as you can link
to libauth.la.
Timo Sirainen [Thu, 27 Apr 2017 09:54:20 +0000 (12:54 +0300)]
lib-storage: mail_search_arg_to_imap() - Fix writing invalid keywords
Just write the original invalid keyword string as output. It might not be
entirely invalid - just invalid within this mailbox (e.g. a mailbox doesn't
allow new keywords).
Timo Sirainen [Thu, 27 Apr 2017 09:53:18 +0000 (12:53 +0300)]
lib-storage: Fix searching when search query has invalid keywords.
For example "SEARCH KEYWORD ]" was returning all mails instead of nothing.
Timo Sirainen [Thu, 27 Apr 2017 09:50:13 +0000 (12:50 +0300)]
lib-index: mail_index_update_keywords() - don't assert if adding/removing 0 keywords
Although it would be nice for the caller to check it, it's easier to do
here. It's mainly a problem with mailbox_keywords_create_valid() that may
unexpectedly create empty keywords.
Timo Sirainen [Wed, 26 Apr 2017 20:41:03 +0000 (23:41 +0300)]
quota: imapc backend now never enforces the quota itself
It just causes a lot of GETQUOTA/GETQUOTAROOT calls to remove. In theory we
could make this optional, but I doubt anyone would want it.
Timo Sirainen [Wed, 26 Apr 2017 20:43:24 +0000 (23:43 +0300)]
lib-storage: Fix crash in mail_get_parts() with a special plugin
If plugin hooks into mail_get_stream() which causes data->parts to be set,
this code crashed with:
Panic: file index-mail.c: line 1163 (index_mail_parse_body): assertion failed: (data->parser_ctx != NULL)
Timo Sirainen [Wed, 26 Apr 2017 20:13:20 +0000 (23:13 +0300)]
imapc: Don't send NOOP on sync if MAILBOX_SYNC_FLAG_FAST is set
Fast syncing should do only the minimal amount of work.
Timo Sirainen [Wed, 26 Apr 2017 12:04:23 +0000 (15:04 +0300)]
imap: Allow plugins to hook into syncing.
Ideally all of the existing pieces in the syncing code would start using
this at some point, so their code could be moved to a more logical location.
Timo Sirainen [Wed, 26 Apr 2017 11:57:40 +0000 (14:57 +0300)]
imap: Move struct imap_sync_context to imap-sync-private.h
Timo Sirainen [Tue, 18 Apr 2017 12:55:08 +0000 (15:55 +0300)]
lib-storage: mail_search_arg_to_imap() - minor keywords writing optimization
Avoid an extra str_delete() by checking whether the parenthesis are needed.
Timo Sirainen [Tue, 18 Apr 2017 12:51:39 +0000 (15:51 +0300)]
lib-storage: mail_search_arg_to_imap() - minor FLAGS writing optimization
Avoid an extra str_delete() by immediately calculating whether the
parenthesis are needed.
Timo Sirainen [Tue, 18 Apr 2017 12:38:59 +0000 (15:38 +0300)]
lib: Add bits_is_power_of_two()
Andriy Syrovenko [Sun, 16 Apr 2017 22:14:02 +0000 (01:14 +0300)]
auth: Fixed dovecot/auth hanging when child ntlm_auth crashes while processing an authentication request
Timo Sirainen [Wed, 26 Apr 2017 11:20:49 +0000 (14:20 +0300)]
imapc: Fix memory leak when closing mailbox with delayed changes
Timo Sirainen [Tue, 25 Apr 2017 09:39:04 +0000 (12:39 +0300)]
imapc: Use UID SEARCH instead of SEARCH
UIDs work better for some broken IMAP servers, so it's safer to use it.
Keep using sequences for ESEARCH, since servers supporting it aren't at
least yet known to be broken and the search result with sequences is
smaller.
Timo Sirainen [Mon, 24 Apr 2017 14:59:53 +0000 (17:59 +0300)]
quota: Add imapc backend
This allows using imapc storage with imapc quota. The quota acts as
read-only, so it's used only when the current quota usage is explicitly
asked.
The quota can be looked up using either a mailbox name or quota root name.
By default INBOX's quota is looked up. If there are multiple quota roots
returned for the mailbox, only the first quota root returned by the
QUOTAROOT reply is used.
Timo Sirainen [Mon, 24 Apr 2017 14:58:53 +0000 (17:58 +0300)]
quota: Fix namespace deduplication when mailboxes don't have paths.
Nothing requires a mailbox path for quota backends, especially imapc.
Still do namespace deduplication based on alias_for settings.
Timo Sirainen [Mon, 24 Apr 2017 14:10:10 +0000 (17:10 +0300)]
imapc: include imapc-client.h in imapc-storage.h
It was already required to be able to successfully include imapc-storage.h.
Timo Sirainen [Mon, 24 Apr 2017 15:13:13 +0000 (18:13 +0300)]
imap-plugins: Use client_add_capability() for adding dynamic capabilities
Timo Sirainen [Mon, 24 Apr 2017 15:51:53 +0000 (18:51 +0300)]
imap: Use client_add_capability() for adding all dynamic capabilities
Timo Sirainen [Mon, 24 Apr 2017 15:12:55 +0000 (18:12 +0300)]
imap: Add client_add_capability()
Timo Sirainen [Mon, 24 Apr 2017 10:29:13 +0000 (13:29 +0300)]
imapc: Add imapc_features=fetch-bodystructure
This allows using the remote IMAP server's BODY and BODYSTRUCTURE replies.
Timo Sirainen [Mon, 24 Apr 2017 10:27:43 +0000 (13:27 +0300)]
lib-storage: Add mail_storage.nonbody_access_fields
This avoids index_mail_update_access_parts_pre() from opening the mail
stream unnecessarily for fields that can be looked up via other methods
by the storage.
Timo Sirainen [Mon, 24 Apr 2017 10:05:48 +0000 (13:05 +0300)]
lib-storage: Add index_mail_get_cached_body[structure]()
This just moves the code to these functions without changing any of the
logic.
Timo Sirainen [Mon, 24 Apr 2017 11:04:01 +0000 (14:04 +0300)]
lib-imap: Make imap_bodystructure_parse_args() public
Timo Sirainen [Mon, 24 Apr 2017 09:50:10 +0000 (12:50 +0300)]
lib-imap: Add imap_write_arg() to write only a single arg
Timo Sirainen [Sun, 23 Apr 2017 16:57:11 +0000 (19:57 +0300)]
lib-imap-client: Fix imapc_client_get_capabilities() when called without connections
Timo Sirainen [Sun, 23 Apr 2017 14:19:36 +0000 (17:19 +0300)]
imapc: Fix crash in mailbox_exists() when LAYOUT isn't imapc.
Especially breaks LAYOUT=none.
Timo Sirainen [Sun, 23 Apr 2017 10:35:18 +0000 (13:35 +0300)]
imapc: Support imapc_features=search without ESEARCH extension
Timo Sirainen [Sun, 23 Apr 2017 16:14:54 +0000 (19:14 +0300)]
imapc: Make sure client is logged in when checking capabilities
Especially with imapc_features=delay-login the capability could have been
looked at before the client was even connected.
Timo Sirainen [Sun, 23 Apr 2017 15:51:02 +0000 (18:51 +0300)]
imapc: Add imapc_mailbox.capabilities
Use it instead of imapc_client_get_capabilities(). Simplifies the
following patch.
Timo Sirainen [Sun, 23 Apr 2017 15:57:15 +0000 (18:57 +0300)]
imapc: Rename imapc_storage_has_modseqs() to imapc_mailbox_has_modseqs()
Simplifies the following patch.
Timo Sirainen [Fri, 21 Apr 2017 09:54:17 +0000 (12:54 +0300)]
cassandra: Use fallback consistency for CASS_ERROR_LIB_NO_HOSTS_AVAILABLE errors
I'm not entirely sure if this is always appropriate, but at least this error
happens every time when attempting to use write_consistency=two when there
is only a single Cassandra node.
Timo Sirainen [Fri, 21 Apr 2017 17:59:55 +0000 (20:59 +0300)]
dsync-server: Fix support for dsync_features=empty-header-workaround
Fixes:
Panic: Unknown key: empty_hdr_workaround
Timo Sirainen [Fri, 21 Apr 2017 10:36:27 +0000 (13:36 +0300)]
*-login: Require client_vfuncs.send_raw_data() to be set
This removes backwards compatibility for managesieve-login.
Timo Sirainen [Fri, 21 Apr 2017 10:35:33 +0000 (13:35 +0300)]
*-login: Add client_vfuncs.send_raw_data()
This allows login plugins to hook into seeing all the data that is sent to
the imap/pop3 client.
Timo Sirainen [Fri, 21 Apr 2017 10:27:18 +0000 (13:27 +0300)]
imap: Add imap_client_vfuncs.send_tagline()
This allows plugins to catch all the IMAP command replies.
Timo Sirainen [Tue, 18 Apr 2017 07:23:37 +0000 (10:23 +0300)]
*-login: Unload plugins at deinit.
Timo Sirainen [Wed, 19 Apr 2017 12:01:19 +0000 (15:01 +0300)]
lib-storage: Allow mail_add_temp_wanted_fields() to be called before mail_set_seq*()
Quota plugin was already doing this, but it didn't actually work. It was
also crashing with imapc:
Panic: file mail-cache-lookup.c: line 341 (mail_cache_field_exists): assertion failed: (seq > 0)