]> git.ipfire.org Git - thirdparty/elfutils.git/log
thirdparty/elfutils.git
23 months agotests: run-lfs-symbols.sh needs gawk
Sam James [Wed, 19 Jul 2023 23:16:38 +0000 (00:16 +0100)] 
tests: run-lfs-symbols.sh needs gawk

With awk=mawk, I get:
```
FAIL: run-lfs-symbols.sh
========================

First sanity-check that LFS detection works.
checking ./testfile-nolfs
awk: line 3: syntax error at or near /
FAIL run-lfs-symbols.sh (exit status: 2)
```

* tests/run-lfs-symbols.sh: Call 'gawk' instead of 'awk'.

Signed-off-by: Sam James <sam@gentoo.org>
2 years agoSECURITY: new file
Frank Ch. Eigler [Mon, 3 Jul 2023 14:19:23 +0000 (10:19 -0400)] 
SECURITY: new file

Policy drafted in April 2023.

https://inbox.sourceware.org/elfutils-devel/20230407005600.GB10746@redhat.com/

Added links to README, and mentioned in configury/spec files for installation.

Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
2 years agolibelf: Replace list of elf_getdata_rawchunk results with a tree
Mark Wielaard [Wed, 21 Jun 2023 16:05:12 +0000 (18:05 +0200)] 
libelf: Replace list of elf_getdata_rawchunk results with a tree

elf_getdata_rawchunks did a linear search to see if a chunk was
already fetched. Replace this list with a binary search tree to make
lookup faster when a lot of Elf_Data_Chunk were created.

       * libelf/libelfP.h (Elf_Data_Chunk): Remove next field.
       (struct Elf): Change the rawchunks type from Elf_Data_Chunk *
       to void *.
       * elf_getdata_rawchunk.c (chunk_compare): New static function.
       (elf_getdata_rawchunk): Use tsearch instead of a manual linked
       list.
       * elf_end.c (free_chunk): New static function.
       (elf_end): Call tdestroy instead of walking linked list.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agobackends: Update list of RISC-V relocations
Andreas Schwab [Mon, 26 Jun 2023 14:32:13 +0000 (16:32 +0200)] 
backends: Update list of RISC-V relocations

* backends/riscv_reloc.def: Add IRELATIVE, PLT32, SET_ULEB128,
SUB_ULEB128.

Signed-off-by: Andreas Schwab <schwab@suse.de>
2 years agolibelf: Sync elf.h from glibc
Andreas Schwab [Mon, 26 Jun 2023 14:30:19 +0000 (16:30 +0200)] 
libelf: Sync elf.h from glibc

Adds new RISC-V relocations.

* elf.h: Update from glibc.

Signed-off-by: Andreas Schwab <schwab@suse.de>
2 years agodebuginfod: Fix formatting in debuginfod_config_cache
Mark Wielaard [Thu, 22 Jun 2023 12:45:56 +0000 (14:45 +0200)] 
debuginfod: Fix formatting in debuginfod_config_cache

The formatting of debuginfod_config_cache in debuginfod-client.c was
slightly off making it hard to see the program logic. Make sure lines
are < 76 chars, and if { } else { } indentation follows GNU style.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agotests: Use -N for run-readelf-self.sh.
Mark Wielaard [Sat, 17 Jun 2023 19:57:59 +0000 (21:57 +0200)] 
tests: Use -N for run-readelf-self.sh.

The test doesn't really need to resolve all addresses
and -N is really slow.

* tests/run-readelf-self.sh: Add -N.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agotests: Split up run-strip-reloc.sh test in three subtests
Mark Wielaard [Sat, 17 Jun 2023 19:37:41 +0000 (21:37 +0200)] 
tests: Split up run-strip-reloc.sh test in three subtests

This test can take a very long time under valgrind (on s390x).
Split it into three tests for kernel modules, self-test and ppc64.
That way the tests can run in parallel and each individual
test produces a result (so the buildbot won't time out).

Also change the comparison to elfcmp instead of doing
readelf -a on both and compare the textual output.

* tests/run-strip-reloc.sh: Split out generic part into...
* tests/strip-reloc-subr.sh: ...this file.
* tests/run-strip-reloc-ko.sh: New file.
* tests/run-strip-reloc-ppc64.sh: New file.
* tests/run-strip-reloc-self.sh: New file.
* tests/Makefile.am (TESTS): Remove run-strip-reloc.sh.
Add run-strip-reloc-ko.sh, run-strip-reloc-self.sh and
run-strip-reloc-ppc64.sh
(EXTRA_DIST): Remove run-strip-reloc.sh. Add
strip-reloc-subr.sh, run-strip-reloc-ko.sh,
run-strip-reloc-self.sh and run-strip-reloc-ppc64.sh.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agotests: Really split run-copymany-sections.sh into separate tests
Mark Wielaard [Sat, 17 Jun 2023 12:56:12 +0000 (14:56 +0200)] 
tests: Really split run-copymany-sections.sh into separate tests

The previous commit 4fac1627c "tests: Split run-copymany-sections.sh
into separate tests" duplicated the tests because they were still
also done in the new test-copymany-subr.sh. Remove them really this
time. Also don't source test-subr.sh twice, test-copymany-subr.sh
already sources it, so the subtests don't have to also do it again.

* tests/test-copymany-subr.sh: Remove actual tests.
* tests/run-copymany-be32.sh: Remove . $srcdir/test-subr.sh.
* tests/run-copymany-be64.sh: Likewise.
* tests/run-copymany-le32.sh: Likewise.
* tests/run-copymany-le64.sh: Likewise.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agotests: Split run-copymany-sections.sh into separate tests
Mark Wielaard [Sat, 17 Jun 2023 12:03:36 +0000 (14:03 +0200)] 
tests: Split run-copymany-sections.sh into separate tests

This test can take a very long time under valgrind (on s390x).
Split it into four tests for big/little endian, 32/64 bit.
That way the tests can run in parallel and each individual
test produces a result (so the buildbot won't time out).

* tests/run-copymany-sections.sh: Delete and move
generic part into...
* tests/test-copymany-subr.sh: ... here.
* tests/run-copymany-be32.sh: New big endian 32 bit tests.
* tests/run-copymany-be64.sh: New big endian 64 bit tests.
* tests/run-copymany-le32.sh: New little endian 32 bit tests.
* tests/run-copymany-le64.sh: New little endian 64 bit tests.
* tests/Makefile.am (TESTS): Remove run-copymany-sections.sh,
add run-copymany-be32.sh, run-copymany-le32.sh,
run-copymany-be64.sh and run-copymany-le64.sh.
(EXTRA_DIST): Remove run-copymany-sections.sh. Add
test-copymany-subr.sh, run-copymany-be32.sh,
run-copymany-le32.sh, run-copymany-be64.sh and
run-copymany-le64.sh.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agotests: Use readelf -N -w in run-strip-reloc.sh
Mark Wielaard [Sat, 17 Jun 2023 00:33:33 +0000 (02:33 +0200)] 
tests: Use readelf -N -w in run-strip-reloc.sh

With -N the test runs 4 times faster. And the address lookup is not
essential for the test.

* tests/run-strip-reloc.sh: Use readelf -N -w.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agotests: Add a bit less and slightly smaller sections for addsections
Mark Wielaard [Fri, 16 Jun 2023 23:40:38 +0000 (01:40 +0200)] 
tests: Add a bit less and slightly smaller sections for addsections

The run-copymany-sections.sh testcase adds 64K sections (twice)
to a couple of times. Each section is just 6 bytes long, but each
data section is malloced and freed. That adds up. And is especially
slow when running under valgrind.

Reduce the number of sections added to 32K (twice) and make each
section data just one single zero byte.

* tests/addsections.c (add_sections): Don't strdup and free
the string ".extra", but just add the empty string.
* tests/run-copymany-sections.sh: Call addsections with
32768 instead of 65535.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agodebuginfod: PR29696: enlarge run-debuginfod-federation-metrics.sh workload again
Frank Ch. Eigler [Fri, 16 Jun 2023 15:18:19 +0000 (11:18 -0400)] 
debuginfod: PR29696: enlarge run-debuginfod-federation-metrics.sh workload again

Now that the bug is fixed, we can let debuginfod have all the traffic.

Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
2 years agodebuginfod: PR29696: Removed secondary fd close in cache config causing a race condition
Ryan Goldberg [Fri, 16 Jun 2023 14:20:04 +0000 (10:20 -0400)] 
debuginfod: PR29696: Removed secondary fd close in cache config causing a race condition

Signed-off-by: Ryan Goldberg <rgoldber@redhat.com>
2 years agoreport_r_debug: handle `-z separate-code' and find more modules
Luke Diamand [Fri, 12 May 2023 19:11:45 +0000 (20:11 +0100)] 
report_r_debug: handle `-z separate-code' and find more modules

Looking at some cores in eu-stack, I found that they were not being
backtraced.

This was because elfutils had not found some modules (e.g. libc-2.22.so)
in report_r_debug.

That is because it has a limit on the number of link map entries it will
look at, to avoid loops in corrupted core files.

The example I found had:
- 36 elements
- 109 iterations

See also discussion here:

    https://sourceware.org/pipermail/elfutils-devel/2023q2/006149.html

Signed-off-by: Luke Diamand <ldiamand@roku.com>
2 years agoPR30316: debuginfod wal checkpointing
Frank Ch. Eigler [Mon, 8 May 2023 15:05:48 +0000 (11:05 -0400)] 
PR30316: debuginfod wal checkpointing

Add a "--scan-checkpoint=NUM" option to debuginfod to control forced
synchronization & sqlite -wal checkpointing for the multithreaded
scanning process.  In absence of this, a server that's busy with other
read & write operations can accumulate potentially large SQLITE WAL
temporary files.  This option causes the server to take intermittent
quiescent breaks during scanning, during which the -wal file can be
processed and truncated.

Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
2 years agodebuginfod: PR30378: better compression for _files table
Frank Ch. Eigler [Fri, 5 May 2023 17:56:23 +0000 (13:56 -0400)] 
debuginfod: PR30378: better compression for _files table

Split the _files table into two links into a new _fileparts table,
interning the dirname and basename of each file name string.  This
reduces storage requirements for many thousands of almost-identical
long paths that are evident in large builds like kernels.

This is unfortunately a schema-breaking change, so requires reindexing
of the corpus.

While in the vicinity, the file scan work queue is changed from a
<set> to an <unordered_set>.  The intent is that files be scanned in a
more random sequence instead of sorted.  If they're sorted, then files
that contain errors will tend to be retried over and over again at the
next scan cycle, even at the expense of making progress on the other
files in the queue.

Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
2 years agobackends: Add set_initial_registers_tid callback for LoongArch
Youling Tang [Tue, 9 May 2023 11:20:31 +0000 (19:20 +0800)] 
backends: Add set_initial_registers_tid callback for LoongArch

This patch implements the set_initial_registers_tid hook for LoongArch.

Signed-off-by: Liwei Ge <geliwei@openanolis.org>
Signed-off-by: Youling Tang <tangyouling@loongson.cn>
2 years agobackends: Add core_note callback for LoongArch
Youling Tang [Fri, 7 Apr 2023 02:59:28 +0000 (10:59 +0800)] 
backends: Add core_note callback for LoongArch

Signed-off-by: Youling Tang <tangyouling@loongson.cn>
2 years agobackends: Add frame pointer unwinding for LoongArch
Youling Tang [Fri, 7 Apr 2023 02:59:27 +0000 (10:59 +0800)] 
backends: Add frame pointer unwinding for LoongArch

If we don't find any debug information for a given frame, we usually
cannot unwind any further. However, the binary in question might have
been compiled with frame pointers, in which case we can look up the
well known frame pointer locations in the stack snapshot and use them
to bridge the frames without debug information.

Signed-off-by: Liwei Ge <geliwei@openanolis.org>
Signed-off-by: Youling Tang <tangyouling@loongson.cn>
2 years agobackends: Add initial return value location support for LoongArch
Youling Tang [Fri, 7 Apr 2023 02:59:26 +0000 (10:59 +0800)] 
backends: Add initial return value location support for LoongArch

LoongArch ELF ABI specification - Return values:
https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html#_return_values

Signed-off-by: Liwei Ge <geliwei@openanolis.org>
Signed-off-by: Youling Tang <tangyouling@loongson.cn>
2 years agobackends: Add abi_cfi and register_info callbacks for LoongArch
Youling Tang [Fri, 7 Apr 2023 02:59:24 +0000 (10:59 +0800)] 
backends: Add abi_cfi and register_info callbacks for LoongArch

LoongArch Reference Manual - Volume 1:
https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html

LoongArch ELF ABI:
https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html

Signed-off-by: Liwei Ge <geliwei@openanolis.org>
Signed-off-by: Youling Tang <tangyouling@loongson.cn>
2 years agoelfcompress: Don't compress if section already compressed unless forced
Mark Wielaard [Fri, 21 Apr 2023 23:45:43 +0000 (01:45 +0200)] 
elfcompress: Don't compress if section already compressed unless forced

Before commit a5b07cdf9 "support ZSTD compression algorithm"
elfcompress would not try to compress a section if it already
had the requested compression type (or was already uncompressed)
unless the --force flag was given. An else if construct was changed
to an if in the commit causing elfcompress to warn (in verbose mode)
but then still try to (re)compress the section.

Add an explicit check so if nothing needs (un)compressing, the file
isn't changed.

The diff looks large, but git diff -b -w is just:

+     if (force || type != schtype)
+       {
          if (shdr->sh_type != SHT_NOBITS
              && (shdr->sh_flags & SHF_ALLOC) == 0)
            {
@@ -554,6 +556,7 @@ process_file (const char *fname)
              printf ("[%zd] %s ignoring %s section\n", ndx, sname,
                      (shdr->sh_type == SHT_NOBITS ? "no bits" : "allocated"));
        }
+   }

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibdwfl: Fix memory leak in unzip()
John Gallagher [Fri, 28 Apr 2023 06:04:31 +0000 (23:04 -0700)] 
libdwfl: Fix memory leak in unzip()

state.input_buffer is not freed if the file is found to not be
compressed with the compression algorithm unzip() is trying to use.

Signed-off-by: John Gallagher <john@gllghr.com>
2 years agoPR30377: fix debuginfod -r -X combination
Frank Ch. Eigler [Fri, 21 Apr 2023 21:04:08 +0000 (17:04 -0400)] 
PR30377: fix debuginfod -r -X combination

Until this fix, debuginfod -r -X '.*' didn't trigger groom-time removal
of everything, because the -I include regex overrode it.  Corrected logic
to match the scan-time tie-breaking between -I / -X.

Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
2 years agotestsuite: Avoid C99 compatibility issues in run-native-test.sh
Florian Weimer [Sat, 22 Apr 2023 19:37:09 +0000 (21:37 +0200)] 
testsuite: Avoid C99 compatibility issues in run-native-test.sh

Include <unistd.h> for the pause function, and add the return type
of main.  Avoids an implicit function declaration and implicit int.

Signed-off-by: Florian Weimer <fweimer@redhat.com>
2 years agoreadelf: display dynamic symtab without section headers
Di Chen [Mon, 27 Mar 2023 02:01:05 +0000 (10:01 +0800)] 
readelf: display dynamic symtab without section headers

This commit adds a new option "-D/--use-dynamic" to support printing the
dynamic symbol table from the PT_DYNAMIC segment. By using the
PT_DYNAMIC segment, eu-readelf can go through the contents of dynamic
section entries and the values of each tag. From that, we can get the
address and size of the dynamic symbol table, the address of the string
table, etc.

By using the new option "-D/--use-dynamic", eu-readelf can list the
symbols without section headers.

Example:
  $ ./src/readelf -Ds a.out
      0: 0000000000000000      0 NOTYPE  LOCAL  DEFAULT    UNDEF
      1: 0000000000000000      0 FUNC    GLOBAL DEFAULT    UNDEF __libc_start_main@GLIBC_2.34 (2)
      2: 0000000000000000      0 NOTYPE  WEAK   DEFAULT    UNDEF __gmon_start__

https://sourceware.org/bugzilla/show_bug.cgi?id=28873

Signed-off-by: Di Chen <dichen@redhat.com>
2 years agotests: Limit the number of concurrent requests in debuginfod-federation
Mark Wielaard [Fri, 14 Apr 2023 16:10:48 +0000 (18:10 +0200)] 
tests: Limit the number of concurrent requests in debuginfod-federation

It seems doing 100 parallel requests can crash some versions of
libmicrohttpd so limit the number a little to the number of processors
times 4, with a max of 64.

      * tests/run-debuginfod-federation-metrics.sh: Use nproc * 4, or 64
      for seq curl requests.
      * tests/run-debuginfod-federation-sqlite.sh: Likewise.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoreadelf: Handle NULL shdr in section_name
Mark Wielaard [Thu, 6 Apr 2023 14:58:13 +0000 (16:58 +0200)] 
readelf: Handle NULL shdr in section_name

In some error cases we want to show the section name but cannot
because the section header is corrupt or NULL. Make sure the
section_name always returns "???" in that case.

* src/readelf.c (section_name): Check for shdr == NULL.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agobackends: Check results for NULL early in dwarf_peeled_die_type
Mark Wielaard [Thu, 6 Apr 2023 14:49:27 +0000 (16:49 +0200)] 
backends: Check results for NULL early in dwarf_peeled_die_type

Calling dwarf_peeled_die_type with a NULL results pointer is an error,
check early that result is not NULL so dwarf_formref_die and
dwarf_peel_type won't try to set the NULL Dwarf_Die.

* backends/libebl_CPU.h (dwarf_peeled_die_type): Move check
        for results == NULL to start of function.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoPR30348: debuginfod: retry partial archive scans
Frank Ch. Eigler [Thu, 13 Apr 2023 17:11:56 +0000 (13:11 -0400)] 
PR30348: debuginfod: retry partial archive scans

On some public debuginfod servers, it was observed that errors
may occur during individual archive scanning operations.  That's
fine, but previous code still went ahead and marked the archive
"done" by inserting a record into the *_file_mtime_scanned table.

New code ensures that exceptions propagate for these cases, and an
archive that encountered an error while scanning will be retried
later.

Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
2 years agobackends: add checks for _GLOBAL_OFFSET_TABLE_ on loongarch
Youling Tang [Sat, 1 Apr 2023 03:18:53 +0000 (11:18 +0800)] 
backends: add checks for _GLOBAL_OFFSET_TABLE_ on loongarch

Add handling of _GLOBAL_OFFSET_TABLE_.

Before applying the patch:
$ ./src/elflint --gnu-ld ./src/elflint
section [35] '.symtab': _GLOBAL_OFFSET_TABLE_ symbol value 0x68548
does not match .got.plt section address 0x68238

After applying the patch:
$ ./src/elflint --gnu-ld ./src/elflint
No errors

Signed-off-by: Liwei Ge <geliwei@openanolis.org>
Signed-off-by: Youling Tang <tangyouling@loongson.cn>
2 years agobackends: Add new relocation type handling for LoongArch
Youling Tang [Sat, 1 Apr 2023 06:43:44 +0000 (14:43 +0800)] 
backends: Add new relocation type handling for LoongArch

Add new relocation type handling.

Signed-off-by: Youling Tang <tangyouling@loongson.cn>
2 years agolibelf: Sync elf.h from glibc.
Youling Tang [Sat, 1 Apr 2023 06:43:43 +0000 (14:43 +0800)] 
libelf: Sync elf.h from glibc.

Adds R_LARCH_*.

Signed-off-by: Youling Tang <tangyouling@loongson.cn>
2 years agodebuginfod: When retrieving files from cache, update atime manually
Jan Alexander Steffens (heftig) [Fri, 24 Mar 2023 00:48:05 +0000 (01:48 +0100)] 
debuginfod: When retrieving files from cache, update atime manually

The cache cleaning logic requires atime to be correct (strictatime or
relatime) but some users on Linux only have noatime.

Attempt to update the atime manually so that the cache works properly.

Signed-off-by: Jan Alexander Steffens (heftig) <heftig@archlinux.org>
2 years agodebuginfod: Don't touch access time of new files
Jan Alexander Steffens (heftig) [Fri, 24 Mar 2023 00:48:04 +0000 (01:48 +0100)] 
debuginfod: Don't touch access time of new files

Instead of copying the mtime, which might be far in the past, don't
touch the access time. This will prevent cache cleaning from considering
the file as old immediately.

Signed-off-by: Jan Alexander Steffens (heftig) <heftig@archlinux.org>
2 years agodebuginfod-client.c: Avoid sscanf on mixed-case component of string
Aaron Merey [Thu, 30 Mar 2023 18:11:23 +0000 (14:11 -0400)] 
debuginfod-client.c: Avoid sscanf on mixed-case component of string

sscanf is used to get the value of x-debuginfod-size from the http
headers.  The format string used assumes that the header field name
is entirely lower case.  However mixed-case field names are possible,
resulting in the value not being read.

Fix this by removing "x-debuginfod-size" from the format string.

Signed-off-by: Aaron Merey <amerey@redhat.com>
2 years agonuke a top-level ChangeLog blurb that duplicated the debuginfod/ChangeLog
Frank Ch. Eigler [Wed, 29 Mar 2023 20:48:15 +0000 (16:48 -0400)] 
nuke a top-level ChangeLog blurb that duplicated the debuginfod/ChangeLog

2 years agodebuginfod: Replace futimes with futimens
Jan Alexander Steffens (heftig) [Fri, 24 Mar 2023 00:48:03 +0000 (01:48 +0100)] 
debuginfod: Replace futimes with futimens

Similar to what 8c4aa0ef998191ed828a37190dc179b91649938a did for ar and
strip, replace the non-standard futimes with the POSIX futimens.

Signed-off-by: Jan Alexander Steffens (heftig) <heftig@archlinux.org>
2 years agodebuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size...
lilydjwg [Wed, 29 Mar 2023 15:02:36 +0000 (23:02 +0800)] 
debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header

Signed-off-by: lilydjwg <lilydjwg@gmail.com>
2 years agoLoongArch: implemented a basic machine flag check
Alexey Sheplyakov [Mon, 20 Mar 2023 14:45:02 +0000 (18:45 +0400)] 
LoongArch: implemented a basic machine flag check

With this patch I can use eu-elflint to verify LoongArch ELF
binaries. Previously eu-elflint was complaining about invalid
machine flags:

$ ./src/elflint --gnu-ld ./src/elflint
invalid machine flags: 0x43
$ echo $?
1

    * backends/loongarch_symbol.c (loongarch_init): Hook
    machine_flag_check.
    * backends/loongarch_symbol.c (loongarch_machine_flag_check):
    New function.

https://sourceware.org/bugzilla/show_bug.cgi?id=30251

Signed-off-by: Alexey Sheplyakov <asheplyakov@basealt.ru>
2 years agodebuginfod-client.c: Skip empty file creation for cancelled queries
Aaron Merey [Fri, 17 Mar 2023 15:20:50 +0000 (11:20 -0400)] 
debuginfod-client.c: Skip empty file creation for cancelled queries

Empty files in the client cache are used to indicate that contacted
servers could not find a requested resource.  Future queries for this
resource will not be attempted until the cache_miss_s duration has
passed.

Currently these empty files are also created when a query is cancelled
through the client's progressfn.  This can occur, for example, when a
user cancels a download with ctrl-c.

This prevents user-cancelled queries from being retried promptly without
having to modify cache_miss_s.  Fix this by skipping the creation of an
empty cache file when progressfn cancels a query.

Signed-off-by: Aaron Merey <amerey@redhat.com>
2 years agotests: skip '(null)' symname frames in backtrace tests
Mark Wielaard [Sat, 4 Mar 2023 20:55:56 +0000 (21:55 +0100)] 
tests: skip '(null)' symname frames in backtrace tests

Some setups might have some frames for unknown (null) functions
in the thread backtrace. Skip these frames instead of failing
immediately.

    * tests/backtrace.c (callback_verify): Check and skip nulls_seen.

https://sourceware.org/bugzilla/show_bug.cgi?id=29176

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoconfigure.ac contains Bashisms
Mark Wielaard [Sun, 5 Mar 2023 12:09:34 +0000 (13:09 +0100)] 
configure.ac contains Bashisms

Autoconf scripts are supposed to be written in POSIX-compatible shell
language. elfutils commits 0ffe2874e75d48cb88936e119e5284ff2bf664d9
and 3fa98a6f29b0f370e32549ead7eb897c839af980 introduced Bashisms to
configure.ac that cause errors when /bin/sh is not Bash.

Example error when /bin/sh is Dash:

./configure: 8748: test: xyes: unexpected operator

The cause of the error is the use of a non-existent == operator in
expressions passed to the 'test' built-in command. POSIX shell
specifies only an = operator for testing string equality.

  * configure.ac: Replace == by = in use_msan and enable_demangler
  comparisons.

https://sourceware.org/bugzilla/show_bug.cgi?id=30196

Reported-by: Matt Whitlock <sourceware@mattwhitlock.name>
Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoFix static build when zstd is enabled for libelf
Mark Wielaard [Fri, 3 Mar 2023 16:10:30 +0000 (17:10 +0100)] 
Fix static build when zstd is enabled for libelf

When doing a static build (as with --enable-gcov) the build fails
because the executables aren't linked with -lzstd. Also the
run-debuginfod-query-retry.sh test relies on libdebuginfod.so.1 which
isn't there.

Fix by adding $(zstd_LIBS) to the static libelf lines and using the
debuginfod-find executable itself in the testcase.

    * src/Makefile.am (libelf): When BUILD_STATIC add $(zstd_LIBS)
    * tests/Makefile.am (libelf): Likewise.
    * tests/run-debuginfod-query-retry.sh: Use debuginfod-find instead
      of libdebuginfod.so.1

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoPrepare for 0.189 elfutils-0.189
Mark Wielaard [Fri, 3 Mar 2023 15:13:52 +0000 (16:13 +0100)] 
Prepare for 0.189

Set version to 0.189
Update NEWS and elfutils.spec.in
Set copyright year in configure.ac and printversion.
Regenerate po/*.po files.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibelf: Document and make ELFCOMPRESS_ZSTD usable with old system elf.h
Mark Wielaard [Fri, 3 Mar 2023 14:37:18 +0000 (15:37 +0100)] 
libelf: Document and make ELFCOMPRESS_ZSTD usable with old system elf.h

Make sure that even if the system elf.h doesn't have ELF_COMPRESS_ZSTD
defined it can still be used as constant. Also update libelf.h
documentation and add new feature to NEWS.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoreadelf: Fix use-after-free ebl pointer issue
Mark Wielaard [Fri, 3 Mar 2023 13:13:49 +0000 (14:13 +0100)] 
readelf: Fix use-after-free ebl pointer issue

With -flto gcc 13 sees that we use the ebl pointer after closing and
freeing it.

In function â€˜process_elf_file’,
    inlined from â€˜process_dwflmod’ at readelf.c:818:3:
readelf.c:1070:6: error: pointer â€˜ebl_18’ used after â€˜free’ [-Werror=use-after-free]
 1070 |   if (pure_ebl != ebl)
      |      ^
In function â€˜ebl_closebackend’,
    inlined from â€˜process_elf_file’ at readelf.c:1068:3,
    inlined from â€˜process_dwflmod’ at readelf.c:818:3:
../libebl/eblclosebackend.c:47:7: note: call to â€˜free’ here
   47 |       free (ebl);
      |       ^

Fix by only calling ebl_closebackend after using it in the comparison.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibdw: Fix dwarf_getscopes memory leak on error
Mark Wielaard [Wed, 22 Feb 2023 22:34:00 +0000 (23:34 +0100)] 
libdw: Fix dwarf_getscopes memory leak on error

When there is an error in dwarf_getscopes after the initial scopes
have been allocated, e.g. when looking for the inlined scopes, then
the scopes would leak. Fix this by explicitly free the scopes on error.

https://sourceware.org/bugzilla/show_bug.cgi?id=29434

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibcpu: Remove the need of NMNES by using enum
Yonggang Luo [Sat, 17 Dec 2022 16:52:02 +0000 (00:52 +0800)] 
libcpu: Remove the need of NMNES by using enum

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibdw: Use elf_rawdata when checking .debug section
Mark Wielaard [Mon, 20 Feb 2023 15:42:56 +0000 (16:42 +0100)] 
libdw: Use elf_rawdata when checking .debug section

.debug sections are raw bytes and don't need conversion even when host
and file have different endian order.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibelf: memmove any extra bytes left by elf_cvt_gnuhash conversion
Mark Wielaard [Mon, 20 Feb 2023 15:32:57 +0000 (16:32 +0100)] 
libelf: memmove any extra bytes left by elf_cvt_gnuhash conversion

Otherwise some undefined bytes might be left in the buffer. Now they
might still be not useful, but at least they are as defined in the
file.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoNEWS: Add old version code names
Mark Wielaard [Thu, 23 Feb 2023 09:42:15 +0000 (10:42 +0100)] 
NEWS: Add old version code names

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoUpdate m4 files from autoconf-archive
Mark Wielaard [Tue, 21 Feb 2023 21:27:59 +0000 (22:27 +0100)] 
Update m4 files from autoconf-archive

Update m4/ax_check_compile_flag.m4 and m4/ax_cxx_compile_stdcxx.m4
to autoconf-archive-2023.02.20.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoconfigure: Check for and -Wuse-after-free=3 when available
Mark Wielaard [Tue, 21 Feb 2023 12:12:38 +0000 (13:12 +0100)] 
configure: Check for and -Wuse-after-free=3 when available

gcc already includes -Wuse-after-free=2 in -Wall. -Wuse-after-free=3
also warns for indeterminate pointers in equality expressions.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibasm: Fix use-after-free issue with circular single linked list cleanup
Mark Wielaard [Fri, 17 Feb 2023 13:52:04 +0000 (14:52 +0100)] 
libasm: Fix use-after-free issue with circular single linked list cleanup

Pointed out by gcc 12 with -Wuse-after-free=3

In function â€˜free_section’
asm_end.c:552:17: error: pointer â€˜data’ used after â€˜free’ [-Werror=use-after-free]
  552 |     while (oldp != scnp->content);
      |            ~~~~~^~~~~~~~~~~~~~~~
asm_end.c:550:9: note: call to â€˜free’ here
  550 |         free (oldp);
      |         ^~~~~~~~~~~

Fix by freeing scnp->content last.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoNEWS: Mention linking with libstdc++ or using --disable-demangler
Mark Wielaard [Fri, 17 Feb 2023 20:17:10 +0000 (21:17 +0100)] 
NEWS: Mention linking with libstdc++ or using --disable-demangler

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibdw: check that DWARF strings are null-terminated
Aleksei Vetrov [Tue, 14 Feb 2023 20:30:02 +0000 (20:30 +0000)] 
libdw: check that DWARF strings are null-terminated

It is expected from libdw to return strings that are null-terminated to
avoid overflowing ELF data.

* Add calculation of a safe prefix inside string sections, where any
  string will be null-terminated.

* Check if offset overflows the safe prefix in dwarf_formstring.

Signed-off-by: Aleksei Vetrov <vvvvvv@google.com>
2 years agoconfigure: Error when demangler is enabled, but libstdc++ support isn't
Mark Wielaard [Wed, 15 Feb 2023 16:00:30 +0000 (17:00 +0100)] 
configure: Error when demangler is enabled, but libstdc++ support isn't

There have been a couple of cases where demangler support has been
accidentially been disabled because libstdc++ wasn't there/installed
during build. Make it an error if --disable-demangler isn't explicitly
given.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agodoc: Add .TP before -g in debuginfod.8
Mark Wielaard [Tue, 14 Feb 2023 20:03:38 +0000 (21:03 +0100)] 
doc: Add .TP before -g in debuginfod.8

Fixes indentation of -g option.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibdw: Correct data end checkfor deref_type operand in dwarf_getlocation
Mark Wielaard [Tue, 14 Feb 2023 19:24:30 +0000 (20:24 +0100)] 
libdw: Correct data end checkfor deref_type operand in dwarf_getlocation

In __libdw_intern_expression we checked for one byte too many.
We only need one byte for the size and (at least one) for the uleb128
DIE reference.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibdw: Handle DW_OP_GNU_uninit in dwarf_getlocation
Mark Wielaard [Fri, 10 Feb 2023 12:56:58 +0000 (13:56 +0100)] 
libdw: Handle DW_OP_GNU_uninit in dwarf_getlocation

dwarf_getlocation would return an error when it saw a
DW_OP_GNU_uninit. Handle it by simply recognizing as a no argument
operation.

DW_OP_GNU_uninit is emitted by GCC as a marker to flag the location
expression as referring to an uninitialized value.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibdw, readelf, elflint: Add get_(u|s)leb128 guards
Mark Wielaard [Wed, 8 Feb 2023 15:53:24 +0000 (16:53 +0100)] 
libdw, readelf, elflint: Add get_(u|s)leb128 guards

Add sanity check making sure an leb128 isn't being read beyond the
end of the current data segment. Most code already had these guards,
but some were missing. This makes sure an appropriate error is
generated instead.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibdw: check memory access in get_(u|s)leb128
Aleksei Vetrov [Mon, 13 Feb 2023 20:10:05 +0000 (20:10 +0000)] 
libdw: check memory access in get_(u|s)leb128

__libdw_get_uleb128 and __libdw_get_sleb128 should check if addrp has
already reached the end before unrolling the first step. It is done by
moving __libdw_max_len to the beginning of the function, which can
notice, that addrp is beyond the end. Then we just check the result of
this function.

Signed-off-by: Aleksei Vetrov <vvvvvv@google.com>
2 years agobackends: Handle DW_TAG_unspecified_type in dwarf_peeled_die_type
Mark Wielaard [Thu, 26 Jan 2023 17:19:15 +0000 (18:19 +0100)] 
backends: Handle DW_TAG_unspecified_type in dwarf_peeled_die_type

binutils 2.40 introduces DW_TAG_unspecified_type for assembly
functions with an unknown return type. This breaks the
run-funcretval.sh testcase because dwfl_module_return_value_location
returns an error for such functions because it cannot determine the
return value location. Fix that by treating DW_TAG_unspecified_type
as if the DIE doesn't have a DW_AT_type.

Also update the testcase to explicitly checking for
DW_TAG_unspecified_type and printing "returns unspecified type".

https://sourceware.org/bugzilla/show_bug.cgi?id=30047

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoconfigure: Add --enable-sanitize-memory
Ilya Leoshkevich [Mon, 13 Feb 2023 16:45:51 +0000 (17:45 +0100)] 
configure: Add --enable-sanitize-memory

Add support for clang Memory Sanitizer [1], which detects the usage of
uninitialized values. While elfutils itself is already checked with
valgrind, checking code that depends on elfutils requires elfutils to
be built with MSan.

MSan is not linked into shared libraries, and is linked into
executables statically. Therefore, unlike the other sanitizers, MSan
needs to be configured fairly early, since we need to drop
-D_FORTIFY_SOURCE [2], -Wl,-z,defs and --no-undefined.

Disable a few tests that run for more than 5 minutes due to test files
being statically linked with MSan.

[1] https://clang.llvm.org/docs/MemorySanitizer.html
[2] https://github.com/google/sanitizers/issues/247

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
2 years agobackends: Support returning lvalue and rvalue references
Ilya Leoshkevich [Mon, 13 Feb 2023 16:45:50 +0000 (17:45 +0100)] 
backends: Support returning lvalue and rvalue references

On the low level, they are the same as pointers. The change needs to be
done for all backends, so define a function and a macro to avoid
repetition. Also add a native test, which has to be implemented in C++.
Add the configure check for it.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
2 years agoprintversion: Fix unused variable
Ilya Leoshkevich [Mon, 13 Feb 2023 16:45:49 +0000 (17:45 +0100)] 
printversion: Fix unused variable

clang complains:

    debuginfod.cxx:354:1: error: unused variable 'apba__' [-Werror,-Wunused-const-variable]
    ARGP_PROGRAM_BUG_ADDRESS_DEF = PACKAGE_BUGREPORT;
    ^
    ../lib/printversion.h:47:21: note: expanded from macro 'ARGP_PROGRAM_BUG_ADDRESS_DEF'
      const char *const apba__ __asm ("argp_program_bug_address")
                        ^

The default linkage for consts in C++ is internal, so declare them
extern. While at it, remove the debuginfod workaround for
argp_program_version_hook.

Co-developed-by: Mark Wielaard <mark@klomp.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
2 years agotests: Ignore dwfl-report-offline-memory
Ilya Leoshkevich [Mon, 13 Feb 2023 16:45:48 +0000 (17:45 +0100)] 
tests: Ignore dwfl-report-offline-memory

It's showing up in git status when configuring in the source directory.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
2 years agoconfigure: Add --disable-demangler
Ilya Leoshkevich [Wed, 8 Feb 2023 19:52:25 +0000 (20:52 +0100)] 
configure: Add --disable-demangler

__cxa_demangle is normally implemented in the C++ runtime library,
instrumenting which for MSan is a hassle. Add a knob for disbling it.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
2 years agoconfigure: Use -fno-addrsig if possible
Ilya Leoshkevich [Wed, 8 Feb 2023 19:52:24 +0000 (20:52 +0100)] 
configure: Use -fno-addrsig if possible

By default, clang produces .llvm_addrsig sections [1]. The GNU
toolchain does not know how to handle them yet [2], so just ask clang
not to generate them for the time being.

[1] https://llvm.org/docs/Extensions.html#sht-llvm-addrsig-section-address-significance-table
[2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105625

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
2 years agoreadelf: Fix set but not used parameter
Ilya Leoshkevich [Wed, 8 Feb 2023 19:52:22 +0000 (20:52 +0100)] 
readelf: Fix set but not used parameter

clang complains:

    readelf.c:12205:72: error: parameter 'desc' set but not used [-Werror,-Wunused-but-set-parameter]
    handle_bit_registers (const Ebl_Register_Location *regloc, const void *desc,
                                                                           ^

Mark Wielaard says:

    It is never really used since as far as I can see we don't have any
    backend with a core register sets where a register doesn't have a
    number of bits which isn't a multiple of 8 (only ia64 has some 1
    bit registers, but those don't seem part of the core register set).

    If we do accidentally try to handle such a register having an abort
    is also not very nice. Lets just warn and return/continue.

https://sourceware.org/bugzilla/show_bug.cgi?id=30084

Co-developed-by: Mark Wielaard <mark@klomp.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
2 years agolibasm: Fix xdefault_pattern initialization
Ilya Leoshkevich [Wed, 8 Feb 2023 19:52:20 +0000 (20:52 +0100)] 
libasm: Fix xdefault_pattern initialization

clang complains:

    asm_newscn.c:48:22: error: field 'pattern' with variable sized type 'struct FillPattern' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
      struct FillPattern pattern;
                         ^

Fix by using a union instead. Define the second union member to be a
char array 1 byte larger than struct FillPattern. This should be legal
according to 6.7.9:

    If an object that has static or thread storage duration is not
    initialized explicitly, then ... if it is a union, the first named
    member is initialized (recursively) according to these rules, and
    any padding is initialized to zero bits.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
2 years agoaddr2line: Do not test demangling in run-addr2line-i-test.sh
Ilya Leoshkevich [Mon, 6 Feb 2023 22:25:09 +0000 (23:25 +0100)] 
addr2line: Do not test demangling in run-addr2line-i-test.sh

There is run-addr2line-i-demangle-test.sh for that.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
2 years agoInitialize reglocs for VMCOREINFO
Ilya Leoshkevich [Mon, 6 Feb 2023 22:25:08 +0000 (23:25 +0100)] 
Initialize reglocs for VMCOREINFO

MSan complains:

    Uninitialized value was created by an allocation of 'reglocs' in the stack frame
       #0 0x562d35c686f0 in handle_core_note elfutils/src/readelf.c:12674:3
       #const Ebl_Register_Location *reglocs;
    ==1006199==WARNING: MemorySanitizer: use-of-uninitialized-value
       #0 0x562d35c68a2a in handle_core_note elfutils/src/readelf.c:12692:11
       #colno = handle_core_registers (ebl, ebl->elf, desc + regs_offset,
       #                               reglocs, nregloc);

Strictly speaking, this is not a problem, because nregloc == 0, but for
other note types we initialize it anyway, so do it here as well.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
2 years agoreadelf: Fix set but not used variable
Ilya Leoshkevich [Mon, 6 Feb 2023 22:25:07 +0000 (23:25 +0100)] 
readelf: Fix set but not used variable

clang complains:

    readelf.c:10250:10: error: variable 'nculist' set but not used [-Werror,-Wunused-but-set-variable]
      size_t nculist = 0;
             ^

Fix by deleting it.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
2 years agodebuginfod-client.c: Download section even if cached executable didn't contain it.
Aaron Merey [Wed, 8 Feb 2023 02:15:33 +0000 (21:15 -0500)] 
debuginfod-client.c: Download section even if cached executable didn't contain it.

Before attempting to download a section, cache_find_section tries to
extract the section from existing files in the cache. If it's determined
that the section must not exist, cache_find_section returns -ENOENT to
indicate that the download should be skipped.

This patch fixes a bug where cache_find_section returns -ENOENT even
though the section exists.  If the cache contains the executable but
not the debuginfo with the given build-id and the section only exists
in the debuginfo (such as any of the .debug_* sections), then
debuginfod_find_section returns -ENOENT even if the section could be
downloaded.

Fix this by having cache_find_section not return -ENOENT unless cached
debuginfo was able to be read.

Signed-off-by: Aaron Merey <amerey@redhat.com>
2 years agodebuginfod: Make sure there is only one typedef for debuginfod_client
Mark Wielaard [Mon, 6 Feb 2023 09:21:58 +0000 (10:21 +0100)] 
debuginfod: Make sure there is only one typedef for debuginfod_client

Both debuginfod.h and libdwfl.h have a simple typedef for struct
debuginfod_client. Some compilers pedantically warn when including
both headers that such typedefs are only officially supported in
C11. So guard them with _ELFUTILS_DEBUGINFOD_CLIENT_TYPEDEF to
make them happy.

https://sourceware.org/bugzilla/show_bug.cgi?id=30077

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agotests: Check ELFUTILS_DISABLE_DEMANGLE in run-addr2line-C-test.sh
Mark Wielaard [Fri, 3 Feb 2023 12:44:17 +0000 (13:44 +0100)] 
tests: Check ELFUTILS_DISABLE_DEMANGLE in run-addr2line-C-test.sh

https://sourceware.org/bugzilla/show_bug.cgi?id=30072

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibdw: Search for abstract origin in the correct CU
Mark Wielaard [Sat, 21 Jan 2023 23:31:57 +0000 (00:31 +0100)] 
libdw: Search for abstract origin in the correct CU

With gcc -flto the abstract origin of an inlined subroutine
could be in a different CU. dwarf_getscopes might return an
empty scope if it cannot find the abstract origin scope. So
make sure to search in the

We also tried to add the origin match in pc_record directly
in the current inlined scope. This always failed, causing
to do a needless traversal, followed by the full CU scan in
dwarf_getscopes. Just always stop the pc_record search and
then do the CU origin_match in dwarf_getscopes.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoaddr2line: -C should not try to handle optional (ignored) argument
Mark Wielaard [Sun, 22 Jan 2023 19:50:53 +0000 (20:50 +0100)] 
addr2line: -C should not try to handle optional (ignored) argument

The --demangle option takes an option (ignored) argument. Since -C
is the short option of --demangle it also takes that optional
argument. But that means that something like -Cfi is like -C got
fi as argument, while the user expects -Cfi to be like -C -f -i.

Separate the --demangle and -C options. --demangle still takes
an optional (ignored) argument, but -C doesn't take any arguments
so -Cfi acts the same as -fiC.

Also fix --target, -b, so that it is properly ignored (and not
accidentially enables demangling).

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibdwfl: add check for elf_memory return value
Aleksei Vetrov [Wed, 25 Jan 2023 14:16:57 +0000 (14:16 +0000)] 
libdwfl: add check for elf_memory return value

elf_memory call in __libdw_open_elf_memory can return NULL. It was not
checked and led to the null pointer dereference.

Signed-off-by: Aleksei Vetrov <vvvvvv@google.com>
2 years agotests: run-debuginfod-query-retry.sh /bin/sh might not have a build-id
Mark Wielaard [Thu, 19 Jan 2023 22:53:33 +0000 (23:53 +0100)] 
tests: run-debuginfod-query-retry.sh /bin/sh might not have a build-id

If /bin/sh wasn't build with build-id the test fails because
debuginfod-find will not be able to even try to fetch something.
Use libdebuginfod.so.1 instead as test file because we just
build that and configure makes sure we always produce a build-id.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agobackends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files
Mark Wielaard [Thu, 19 Jan 2023 22:04:04 +0000 (23:04 +0100)] 
backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files

Using the NONE relocation doesn't do anything, but is harmless.

This fixes several (self) tests on sparc that use elflint to
check files are valid ELF.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoreadelf: Check compression status of .debug section data
Mark Wielaard [Tue, 10 Jan 2023 17:18:05 +0000 (18:18 +0100)] 
readelf: Check compression status of .debug section data

The various print_debug_*_section functions didn't get the section
data in the same way. Add a new get_debug_elf_data function that
gets the (possibly relocated) section data and that checks (and
warns) if the data might still be compressed in a way that we
cannot decompress.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoFix typos from codespell
Sam James [Fri, 13 Jan 2023 22:16:07 +0000 (22:16 +0000)] 
Fix typos from codespell

debuginfod/ChangeLog:

* debuginfod-client.c: Typo simultaniously.

doc/ChangeLog:

* debuginfod.8: Typo succesfully.

lib/ChangeLog:

* dynamicsizehash_concurrent.c: Typo modul.
* system.h: Typo dependend.

libdwfl/ChangeLog:

* open.c: Typo non-existant.

src/ChangeLog:

* nm.c: Typo Covert.
* strings.c: Likewise.

tests/ChangeLog:

* elfstrmerge.c: Typo outselves.
* run-debuginfod-extraction.sh: Typo accidentially.
* run-debuginfod-fd-prefetch-caches.sh: Likewise.

Signed-off-by: Sam James <sam@gentoo.org>
2 years agodebuginfod-find.1: note on how to find a comp_dir
Serhei Makarov [Tue, 10 Jan 2023 16:20:13 +0000 (11:20 -0500)] 
debuginfod-find.1: note on how to find a comp_dir

doc/ChangeLog:

* debuginfod-find.1: add a note to DESCRIPTION section for the 'source'
  subcommand, clarifying where to find the CU compilation-directory.

I'm looking at how to improve and document the workflow for using
debuginfod-find to study the behaviour of packaged software on a system, e.g.
in conjunction with a tracing tool like SystemTap. You can read the exact
compiled source code with debuginfod-find source and use that to figure out
which source code locations are interesting to trace. But that process has
several non-obvious or inconvenient steps.

This patch is a clarification to the debuginfod-find source man page pointing
out the eu-readelf command that can show the comp_dir in downloaded debuginfo.
Since debuginfod-find source could be picked up and used by a developer
unfamiliar with DWARF terminology, I think such a clarification saves time
for newbies figuring out what a CU compilation-directory is.

Signed-off-by: Serhei Makarov <serhei@serhei.io>
2 years agodebuginfod PR29975 & PR29976: decrease default concurrency
Frank Ch. Eigler [Tue, 10 Jan 2023 22:59:35 +0000 (17:59 -0500)] 
debuginfod PR29975 & PR29976: decrease default concurrency

... based on rlimit (rlimig -n NUM)
... based on cpu-affinity (taskset -c A,B,C,D ...)

Signed-off-by: Frank Ch. Eigler <fche@redhat.com>
2 years agodebuginfod-client: Use CURLOPT_PROTOCOLS_STR for libcurl >= 7.85.0
Mark Wielaard [Tue, 10 Jan 2023 22:20:41 +0000 (23:20 +0100)] 
debuginfod-client: Use CURLOPT_PROTOCOLS_STR for libcurl >= 7.85.0

https://sourceware.org/bugzilla/show_bug.cgi?id=29926

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agosupport ZSTD compression algorithm
Martin Liska [Tue, 29 Nov 2022 09:59:30 +0000 (10:59 +0100)] 
support ZSTD compression algorithm

config/ChangeLog:

* libelf.pc.in: Add LIBLZSTD to Requires.private.

ChangeLog:

* configure.ac: Detect ZSTD streaming API.

libelf/ChangeLog:

* Makefile.am: Use zstd_LIBS.
* elf_compress.c:
(__libelf_compress): Split into ...
(__libelf_compress_zlib): ... this.
(do_zstd_cleanup): New.
(zstd_cleanup): New.
(__libelf_compress_zstd): New.
(__libelf_decompress): Switch in between zlib and zstd.
(__libelf_decompress_zlib): Renamed from __libelf_decompress.
(__libelf_decompress_zstd): New.
(__libelf_decompress_elf): Dispatch in between compression
algorithms.
(elf_compress): Likewise.
* elf_compress_gnu.c (elf_compress_gnu): Call with
ELFCOMPRESS_ZLIB.
* libelfP.h (__libelf_compress): Add new argument.
(__libelf_decompress): Add chtype argument.

src/ChangeLog:

* elfcompress.c (enum ch_type): Add ZSTD.
(parse_opt): Parse "zstd".
(get_section_chtype): New.
(process_file): Support zstd compression.
(main): Add zstd to help.
* readelf.c (elf_ch_type_name): Rewrite with switch.

tests/ChangeLog:

* Makefile.am: Add ELFUTILS_ZSTD if zstd is enabled.
* run-compress-test.sh: Test zstd compression algorithm
for debug sections.

2 years agolibdwfl: Don't undef _
Mark Wielaard [Wed, 21 Dec 2022 15:40:29 +0000 (16:40 +0100)] 
libdwfl: Don't undef _

A couple of files undefined _, which is defined in lib/eu-config.h as
gettext helper macro. This seems unnecessary and arbitrary.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoAdd support for Synopsys ARCv2 processors
Shahab Vahedi [Wed, 21 Dec 2022 11:27:05 +0000 (12:27 +0100)] 
Add support for Synopsys ARCv2 processors

There is no regression in tests for an x86_64 build, while the new
hello_arc_hs4.ko is added as well.  This is the only meaningful
test that I could add at the moment, given the features supported
by this port.

$ cat tests/test-suite.log
  ==========================================
     elfutils 0.188: tests/test-suite.log
  ==========================================

  # TOTAL: 236
  # PASS:  235
  # SKIP:  1
  # XFAIL: 0
  # FAIL:  0
  # XPASS: 0
  # ERROR: 0

  .. contents:: :depth: 2

  SKIP: run-lfs-symbols.sh
  ========================

  LFS testing is irrelevant on this system
  SKIP run-lfs-symbols.sh (exit status: 77)

$ cat tests/run-strip-reloc.sh.log
  runtest hello_i386.ko
  runtest hello_x86_64.ko
  runtest hello_ppc64.ko
  runtest hello_s390.ko
  runtest hello_aarch64.ko
  runtest hello_m68k.ko
  runtest hello_riscv64.ko
  runtest hello_csky.ko
  runtest hello_arc_hs4.ko            <-- [ new ARC HS4 test ]
  runtest /home/shahab/pahole_pkg/elfutils-git/bld_arc/src/strip
  runtest /home/shahab/pahole_pkg/elfutils-git/bld_arc/src/strip.o
  runtest strip-uncompressed.o
  runtest strip-compressed.o
  runtest testfile-debug-rel-ppc64.o
  runtest testfile-debug-rel-ppc64-z.o
  runtest testfile-debug-rel-ppc64-g.o
  PASS run-strip-reloc.sh (exit status: 0)

Signed-off-by: Shahab Vahedi <shahab@synopsys.email>
2 years agolib: Remove -ffunction-sections for xmalloc
Mark Wielaard [Tue, 20 Dec 2022 22:20:52 +0000 (23:20 +0100)] 
lib: Remove -ffunction-sections for xmalloc

The build used -ffunction-sections just for one file.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibcpu: Use __asm instead of asm to mark variables as used
Yonggang Luo [Sat, 17 Dec 2022 16:52:03 +0000 (00:52 +0800)] 
libcpu: Use __asm instead of asm to mark variables as used

This block of code can not be removed. As it's contains a goto label
enomem that been used elsewhere.

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
2 years agodebuginfod: Define CURL_AT_LEAST_VERSION if necessary
Mark Wielaard [Wed, 21 Dec 2022 17:21:08 +0000 (18:21 +0100)] 
debuginfod: Define CURL_AT_LEAST_VERSION if necessary

Older curl.h don't define CURL_AT_LEAST_VERSION, so define it
ourselves because it is nicer than doing hex encoded version
comparisons.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoPR29926: debuginfod: Fix usage of deprecated CURLINFO_*
Andrew Paprocki [Wed, 21 Dec 2022 16:15:00 +0000 (11:15 -0500)] 
PR29926: debuginfod: Fix usage of deprecated CURLINFO_*

The `CURLINFO_SIZE_DOWNLOAD_T` and `CURLINFO_CONTENT_LENGTH_DOWNLOAD_T`
identifiers are `enum`s, not pre-processor definitions, so the current
`#ifdef` logic is not selecting the newer API.  This results in the
older identifiers being used and they now generate errors when compiled
against Curl 7.87, which has silently deprecated them, causing GCC to
emit `-Werror=deprecated-declarations`.

Instead, the newer identifiers were added in Curl 7.55, so explicitly
check for `CURL_AT_LEAST_VERSION(7, 55, 0)` instead of the current
logic.  This eliminates the error when compiling against Curl 7.87.

Ref: https://github.com/curl/curl/pull/1511

Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
2 years agoDo not use relative include paths in library files.
Mark Wielaard [Tue, 20 Dec 2022 13:53:43 +0000 (14:53 +0100)] 
Do not use relative include paths in library files.

Rely on include dirs being set up correctly. Setup libdw AM_CPPFLAGS
to include libebl directory. In libdwfl note that debuginfod.h is a
generated file in the builddir. Only include it in the one file
debuginfod-client.c that really needs it.

Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agoAdd support for LoongArch
Hengqi Chen [Sat, 3 Dec 2022 13:47:07 +0000 (21:47 +0800)] 
Add support for LoongArch

This implements initial support for the LoongArch architecture.

Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
2 years agolibdwfl: Read no more than required in dwfl_segment_report_module
Gavin Li [Wed, 30 Nov 2022 17:26:19 +0000 (18:26 +0100)] 
libdwfl: Read no more than required in dwfl_segment_report_module

Since read_portion and the standard dwfl_elf_phdr_memory_callback
functions make sure to read at least minread bytes there is no need
for dwfl_segment_report_module to check and adjust the data to the
actual buffer size read. Reading beyond the end of the expected data
size (if the buffer read is much larger) actually causes issues when
passing the data to elfXX_xlatetom() because it is possible that
src->d_size is not a multiple of recsize (for ELF_T_DYN, recsize is 16
while the minimum required alignment is 8), causing elfXX_xlatetom()
to return ELF_E_INVALID_DATA.

Signed-off-by: Gavin Li <gavin@matician.com>
Signed-off-by: Mark Wielaard <mark@klomp.org>
2 years agolibdw: Change typeof -> __typeof in memory-access.h
Yonggang Luo [Thu, 20 Oct 2022 18:25:52 +0000 (02:25 +0800)] 
libdw: Change typeof -> __typeof in memory-access.h

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>