Jeremy Allison [Wed, 15 Oct 1997 21:53:59 +0000 (21:53 +0000)]
ipc.c: Adding Andrews become_root code to the main branch.
locking.c: Adding Andrews become_root code to the main branch.
pipes.c: Fixing the close_file issue.
proto.h: The usual.
reply.c: Move smb_pass into NTDOMAIN defined code. Fixing the close_file issue.
server.c: Fixing the close_file issue.
trans2.c: Fixing the close_file issue.
uid.c: Adding Andrews become_root code to the main branch.
Jeremy (jallison@whistle.com)
Luke Leighton [Wed, 15 Oct 1997 19:16:38 +0000 (19:16 +0000)]
smb.h smbparse.c pipenetlog.c :
whoops, the SAM Logon structure was wrong. updated this, and
cifsntdomain.txt. more debug info in pipenetlog.c. the crash
is somewhere around deal_with_credentials().
byteorder.h :
put in uint8, uint16 and uint32 typecasts around debug info, because
sign extending was resulting in ffffffe8 being displayed instead of e8.
credentials.c :
some debugging info, because i'm tracking a coredump. without gdb.
nothing like making things difficult.
reply.c :
whoops, missed this (important) bit from paul's code, which tells
the NT workstation that the MACHINE$ entry doesn't already exist,
and we're going to create a default entry with a password "machine"
right now.
Andrew Tridgell [Wed, 15 Oct 1997 09:15:45 +0000 (09:15 +0000)]
fixed the freeze on logout bug. The fix has several parts:
1) add a new parameter to queue_netbios_packet(), the "reply_id", this
is the id that should be used when sending a further response to the
packet (such as a response after we get back a reply to a name query
after senidnga WACK). reply_id is 0 (meaning unused) in most cases.
2) fix the id used in the reply in add_name_respond() from
response_name_query_register()
3) remember to remove the response record at the end of
response_name_query_register()
4) get the right IP address (it was 0.0.0.0) in
response_name_query_register()
5) add a new field reply_id to struct response_record
Andrew Tridgell [Wed, 15 Oct 1997 04:51:23 +0000 (04:51 +0000)]
fixed a stack overflow bug in api_lsa_req_chal()
changed the order of arguments to smbhash() in credentials.c. Luke,
when you changed from E1() to smbhash() you didn't notice that the
arguments are in a different order. This is why your new code was
failing.
NT logon still fails, but now gets to SAMLOGON. It shouldn't take much
to get it working now.
Luke Leighton [Tue, 14 Oct 1997 18:37:55 +0000 (18:37 +0000)]
byteorder.h:
created a RW_PIVAL macro which was missing.
smbparse.c:
smb_io_dom_sid() was storing its sub-authorities as uint16s instead
of uint32s. used the DBG_RW_PIVAL macro instead of DBG_RW_PSVAL.
pipentlsa.c:
not sure. something to do with the Query Info reply.
pipeutil.c:
make_rpc_reply() had the packed representation field set to 0x0100 0000
instead of 0x1000 0000, which had the interesting result of turning all
uint32 and uint16 field byte ordering the other way round!
If you click on a filename you can then see all the commits and
changes that have been made to it over time. You can also download any
version of the file or find the differences between any two versions.
All of this is not dependent on the state of your local CVS sandbox,
so it can be used to find out the "true" state of the tree at any
time.
If you suspect some sort of CVS problem (like a change getting
reverted) then please use the above URL to work out what has
happened. You should be able to see exactly who made what changes and
when.
Luke Leighton [Sun, 12 Oct 1997 14:17:55 +0000 (14:17 +0000)]
ipc.c:
debugging info. found that data = NULL because of short packet length
indicated from the ntlsaRPC pipe _royally_ stuffs NT's packet handling.
maybe this should go down as a service denial bug to the ntbugtraq list.
pipes.c lsaparse.c smbparse.c :
added more debug stuff. added length of header to data_len in MSRPC
fragment_length field (0x18 bytes short) which caused the above bug
from NT 4.0. oops.
Updated mirrors, combined Sources and Sources&Binaries as our binaries
are now with our sources.
Have requested that mirror sites remove the old 'binaries' tree.
Paul.
I have to admit that I'm not very good at writing Makefiles.
This one will simply create an object file from each of the .c files
in the directory. These could be linked into a static library, but
I'm not sure that this is worthwhile. If anyone wants to improved on
what I've got here, please do! crh -)-----
After generating some discussion, listening to the opinions, and thinking
about it for a while, I've decided to move the tree & list code into a
separate subdirectory.
Jeremy Allison [Fri, 10 Oct 1997 01:32:26 +0000 (01:32 +0000)]
nmblookup.c: Added -A ability to do status on ip address.
smb.h: Added defines we will need for NT SMB calls.
trans2.c: Fixed SMB_QUERY_FILE_ALT_NAME_INFO return - this is only
for short name returns (and only used when you negotiate NT SMB calls
to boot !).
Jeremy (jallison@whistle.com)
Jeremy Allison [Thu, 9 Oct 1997 18:40:52 +0000 (18:40 +0000)]
local.h: Fix spelling mistake :-).
namedbsubnet.c: Stop registering 1x name unless we can be a local master.
reply.c: Remove ERRbaddirectory code.
server.c: Remove abort() - use exit_server() instead.
trans2.c: Remove ERRbaddirectory code.
Jeremy (jallison@whistle.com)
This is my library of lists and trees. My hope is to replace all of the
hard coded linked lists that are currently used in Samba with calls to
these modules. This should make the code simpler, smaller, and (I hope)
faster. The tree code, in particular, should speed up processing where
large lists are involved.
Luke Leighton [Wed, 8 Oct 1997 21:36:42 +0000 (21:36 +0000)]
added a dummy function (space in front so make proto doesn't pick it up)
to call the unused static functions in pipes.c. avoids need to move
#if UNDEFINED_NTDOMAIN about, to stop compiler warnings while code is
being developed, but might be released as-is.
Jeremy Allison [Wed, 8 Oct 1997 20:34:13 +0000 (20:34 +0000)]
Makefile: Split definitions for SGI4,5,6.
includes.h: Split definitions for SGI4,5,6.
pipes.c: Moved Luke's #ifdef to remove warnings.
quotas.c: Two changes for FreeBSD and SGI.
server.c: Quota changes for large filesystems.
Jeremy (jallison@whistle.com)
Jeremy Allison [Wed, 8 Oct 1997 00:21:39 +0000 (00:21 +0000)]
ipc.c: Added ERROR_MORE_DATA error if client buffer too small.
server.c: Allow admin_user on read only shares. I think this is
safe but it needs looking at.
Jeremy (jallison@whistle.com)
I rewrote the name_mangle() and name_len().
The interface is the same, but I've simplified the code a bit and added
a few comments. I tested the changes and the output is the same as that
produced by the original (at least, it was in all of my tests). CRH
Jeremy Allison [Tue, 7 Oct 1997 18:46:19 +0000 (18:46 +0000)]
locking.c: Added fix for race condition in slow share mode code.
lsaparse.c: #ifdef'ed out code so this will compile - LUKE PLEASE CHECK THIS.
pipes.c: #ifdef'ed out code so this will compile - LUKE PLEASE CHECK THIS.
server.c: Fixed last known oplock race condition.
smb.h: Re-removed USE_OPLOCK defines - someone checked in an old version.
smbparse.c: #ifdef'ed out code so this will compile - LUKE PLEASE CHECK THIS.
Jeremy (jallison@whistle.com)
Jeremy Allison [Mon, 6 Oct 1997 19:50:51 +0000 (19:50 +0000)]
Finally ! Found & fixed crash bug with logging message when deleting
invalid share mode entries. Thanks to berg@wienrg.aut.alcatel.at (Dietmar Berg)
for the stack backtrace.
Jeremy (jallison@whistle.com)
Jeremy Allison [Mon, 6 Oct 1997 17:52:25 +0000 (17:52 +0000)]
client.c: Changed shadowed variable.
locking.c: Removed USE_OPLOCKS - now the default.
params.c: Removed unused variable.
proto.h: Updated.
reply.c: Removed USE_OPLOCKS - now the default.
server.c: Removed USE_OPLOCKS - now the default.
smb.h: Removed USE_OPLOCKS - now the default.
smbparse.c: Changed shadowed variable.
status.c: Removed USE_OPLOCKS - now the default.
util.c: Removed USE_OPLOCKS - now the default.
Jeremy (jallison@whistle.com)
Luke Leighton [Sun, 5 Oct 1997 11:56:08 +0000 (11:56 +0000)]
smb.h:
added more structures, this time for the use in the query and response
of the LSA_XXXX functions. next target: the NTLOGON mailslots (10 minutes
work).
smbparse.c:
tidying. adding some more sub-structure functions.
Luke Leighton [Sat, 4 Oct 1997 16:51:43 +0000 (16:51 +0000)]
proto.h:
- recreated, as usual.
smb.h:
- added RPC_HDR structure - the 18 byte MSRPC header
smbparse.c:
- added smb_io_rpc_hdr() function to read/write the RPC_HDR structure.
util.c:
- added align2, align4, align_offset functions.
- added skip_unicode_string, unistrcpy, unistrncpy functions.
- modified unistrcpy and unistrncpy to return the number of unicode
characters returned, effectively making skip_unicode_string redundant.