s3-libsmbclient: Fix incomplete description of function return values in libsmbclient.h.

Fix bug #7345.
(cherry picked from commit ce565b0498608714e2c4f7c9f9373dddcbfba568)
(cherry picked from commit 8dd1f920fb74d62a8f841a81f38feb0b0d689cc8)

s3-docs: Improve "winbind nss info" section in man smb.conf.

Karolin
(cherry picked from commit 20fc769179377bf037f4d5efe1afbaf77d4c9292)
(cherry picked from commit fb1b0901ec93afe998145bb7a7549bbdb13c712c)
(cherry picked from commit d73fa06540ba1b08815a7b15ce7ef3b14cf668cf)

Fix bug #7288 - SMB job IDs in CUPS job names wrong.

Based on a patch from Michael Karcher <samba@mkarcher.dialup.fu-berlin.de>.

I think this is the correct fix. It causes cups_job_submit to use
print_parse_jobid(), which I've moved into printing/lpq_parse.c (to allow the
link to work).

It turns out the old print_parse_jobid() was *broken*, in that the pjob
filename was set as an absolute path - not relative to the sharename (due to it
not going through the VFS calls).

This meant that the original code doing a strncmp on the first part of the
filename would always fail - it starts with a "/", not the relative pathname of
PRINT_SPOOL_PREFIX ("smbprn.").

This fix could fix some other mysterious printing bugs - probably the ones
Guenther noticed where job control fails on non-cups backends.

Contains c79ca41baf15b4ef7eb287d343b17a53ba41e852 and
92332fb2368c641db1552d1f2a2f7b3deaa11519 from master.

Jeremy.
(cherry picked from commit 12936bfeb36ae867b52fe48d0f6d3d17d5c8b110)
(cherry picked from commit 302e9b1c027ff3bddbdeb16f97aa6159311e439d)

libwbclient: Re-Fix a bug that was fixed with e5741e27c4c

> r21878: Fix a bug with smbd serving a windows terminal server: If winbind
> decides smbd to be idle it might happen that smbd needs to do a winbind
> operation (for example sid2name) as non-root. This then fails to get the
> privileged pipe. When later on on the same connection another authentication
> request comes in, we try to do the CRAP auth via the non-privileged pipe.
>
> This adds a winbindd_priv_request_response() request that kills the existing
> winbind pipe connection if it's not privileged.

The fix for this was lost during the conversion to libwbclient.

Thanks to Ira Cooper <samba@ira.wakeful.net> for pointing this out!

Volker
(cherry picked from commit 3dab33103f4eddabdb908498200d888dfa6ae5a9)

s3:winbindd: make "smbcontrol winbindd validate-cache" reliable again

commit 73577205cf81644e7fe853eaf3e6459f7f443096
(s3:winbindd: fix problems with SIGCHLD handling (bug #7317))
broke this.

metze
(cherry picked from commit eb9b7d0363669574de8ec380089407890f15eac2)
(cherry picked from commit 7f8741da4e713f657e876f66c3f31455aea8a729)

s3:winbindd: remove unused variables

metze
(cherry picked from commit e18ddb6036f5e0a2211e89a7c9b5514c30a653cf)
(cherry picked from commit c64c867c307d32b8ec17d6e079395e0e9b604f00)
(cherry picked from commit 18f8b48a1143f7b39572de63362b6c30b81709cb)

s3:winbindd: fix problems with SIGCHLD handling (bug #7317)

The main problem is that we call CatchChild() within the
parent winbindd, which overwrites the signal handler
that was registered by winbindd_setup_sig_chld_handler().

That means winbindd_sig_chld_handler() and winbind_child_died()
are never triggered when a winbindd domain child dies.
As a result will get "broken pipe" for all requests to that domain.

To reduce the risk of similar bugs in future we call
CatchChild() in winbindd_reinit_after_fork() now.

We also use a full winbindd_reinit_after_fork() in the
cache validation child now instead instead of just resetting
the SIGCHLD handler by hand. This will also fix possible
tdb problems on systems without pread/pwrite and disabled mmap
as we now correctly reopen the tdb handle for the child.

metze
(cherry picked from commit 73577205cf81644e7fe853eaf3e6459f7f443096)
(cherry picked from commit e0ece652956292cc67383535a0fa174b5015d91e)
(cherry picked from commit 26bdc249310b71dc45e087347e456c9f5b0f4f9b)

s3:winbindd: correctly retry if the netlogon pipe gets disconnected during a logon call

This fixes hopefully the last part of bug #7295.

metze
(cherry picked from commit 4c6cde99c0751a073120d8bc36d40922d8027344)
(cherry picked from commit 482518fcafb18bda1f084ebf1906a2ad02436b80)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 6d24f28f52fb0e21943a1639c426cf7f825d15e7)

s3:winbindd_reconnect: don't only reconnect on NT_STATUS_UNSUCCESSFUL

metze
(cherry picked from commit 6bd5a2a3739938f95fce23ab2da652c9b5a48111)
(cherry picked from commit 169628fcb656ba5987a99bd50c7f588b731eae51)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 30c048c124ece9648e0ec00991780b57af90201e)

s3:winbindd_cm: invalidate connection if cm_connect_netlogon() fails

metze
(cherry picked from commit 94a4bcd2f0c0464e192556679c6636639cb307ea)
(cherry picked from commit c046ae8428fb62ff2749689e7c738f1a2e8f8251)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 61a353807ccefef98fa83e5abcebfe879cdf4337)

s3:winbindd: consistently use TALLOC_FREE(conn->foo_pipe) is we create a new connection

metze
(cherry picked from commit 4f391fedac7111683d13f2d79fee7c0dbc27f86e)
(cherry picked from commit c462e54142c00fdd81c2847d16a75119b1cc89fc)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 4ef6370eaaa307ccfd74012a4b9397312ff747eb)

s3:winbindd_cm: use rpccli_is_connected() helper function

metze
(cherry picked from commit d980c06a994d032a833adc8d56d2f2c037f8fdaf)
(cherry picked from commit aa7d54ed04585a183a88363406ed7f3244b24d85)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit ff9277fb804e7d99a7e80d67c70b962b6199a4e3)

s3:winbindd_cm: use cli_state_is_connected() helper function

metze
(cherry picked from commit 408a3eb35a0e61b5d66a3b48ebbd1a6796672d0f)
(cherry picked from commit 00a93190d2cae31cd2213b810ea348c055670399)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 21afa222ab9502ecb33decd16fe540d6d855ff13)

s3:rpc_client: return at least 10 sec as old timeout in rpccli_set_timeout() instead of 0

metze
(cherry picked from commit 3e70da3f470eeb122f95477fb48d89939f501b3e)
(cherry picked from commit 60861fba533027b6c9a0ff704b95dcf631ea3ca3)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 5ae76f3beac43e7064b0304df24be84642882372)

s3:rpc_client: add set_timeout hook to rpc_cli_transport

metze
(cherry picked from commit 99664ad15460530b6fb44957b6c57823f09884bf)
(cherry picked from commit 89164eb8363ffc0b951256578be48d37ddba46b1)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit b462bc1724b3bdf9052566e683f9748ea6730169)

s3:rpc_client: add rpccli_is_connected()

metze
(cherry picked from commit 4f41b53487ac9bc96c7960e8edab464558656373)
(similar to commit 958b49323968740e2cbf69dc2a0a5dd57d5bcf87)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit a8a1a6c77a2148a729f6b285f3f945ffd5501256)

s3:rpc_client: don't mix layers and keep a reference to cli_state in the caller

We should not rely on the backend to have a reference to the cli_state.
This will make it possible for the backend to set its cli_state reference
to NULL, when the transport is dead.

metze
(cherry picked from commit dc09b12681ea0e6d4c2b0f1c99dfeb1f23019c65)
(cherry picked from commit 1e2e47da82aeb249dce431541738a62cb139aebb)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 582b1cdeb6c0b2145b55930421e8d48ad4754d04)

s3:rpc_transport_np: use cli_state_is_connected() helper

metze
(cherry picked from commit b862351da8624df893ec77e020a456c1d23c58ed)
(cherry picked from commit 8c2f4426ce178ac33748cfba01532ec2fd205710)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 3ea35cd6bb61806ed502e4cd3f386c35a6f58156)

s3:libsmb: add cli_state_is_connected() function

metze
(cherry picked from commit d7bf30ef92031ffddcde3680b38e602510bcae24)
(cherry picked from commit 589f73924273e8a9b54669f42a92381661dcb33f)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 5a4bdb706b97857da67c791b81039b4bc4031c76)

s3:libsmb: don't let cli_shutdown() segfault with a NULL cli_state

metze
(similar to commit 47e10ab9a85960c78af807b66b99bcd139713644)
(cherry picked from commit 957c0d4a5ee67ac70e576155a0f2f6f84cdb1596)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit e6d5238c8403e848a43e6c7a2d3ca6422e8becd4)

s3:rpc_transport_np: handle trans rdata like the output of a normal read

Inspired by bug #7159.

metze
(cherry picked from commit 911287285cc4c8485b75edfad3c1ece901a69b0b)
(cherry picked from commit e2739a2bf37e654c37cbea6e510f63a7ce4adfea)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 2ce1bcd4e4430f311decb73b659c9b615d5bb4e9)

s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response.

Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit 36493bf2f6634b84c57107bcb86bcbf3e82e80fc)
(similar to commit b58b359881c91ec382cfa1d6ba3007b8354b29cb)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 6166e1809516e6ab5911b56b20a4128b088828cf)

Fix broken pipe handling

Metze is right: If we have *any* error at the socket level, we just can
not continue.

Also, apply some defensive programming: With this async stuff someone else
might already have closed the socket.
(cherry picked from commit f140bf2e6578e45b8603d4a6c5feef9a3b735804)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 67b51cc9e773fcbbc2b942a1de256e2c5b695008)

s3:rpc_client: close the socket when pipe is broken

Signed-off-by: Bo Yang <boyang@samba.org>
(similar to commit aa70e44cd0576e5280e24cf35000369a47dd958f)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 407b9577febff6dfbe29106d783d64c41d6fe4e4)

s3: fix crash in winbindd (similar to commit f8cc0e88fbbb082ead023e0cb437b1e12cf35459)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit be9a46c9cae2d05a7eb54e871e05480bd8caa609)

s3-docs: Fix typo in man idmap_ad.

Karolin
(cherry picked from commit 6389fac6db2f54d148222009b5e209cef5c6bdd7)
(cherry picked from commit 39dbf73a6fb4ad45eac259124b70042994d4f215)
(cherry picked from commit 1038d91f3c6d2be0a594226059c5379d3e2ffe58)

s3:lib/time: remove TIME_T_MIN/MAX defines

we already get them from lib/util/time.h
(cherry picked from commit f5729dbb6e720cb6076ea053f1ad0680259e6b39)

The last two patches address bug #7352 (TIME_T_MAX defines inconsistent).
(cherry picked from commit be86206167acb55bee2722c48a5ea09535cf2b99)

lib/util: move TIME_T_MIN/MAX defines into header file (cherry picked from commit 571ee54b791b93ad46e09ed563ef4a5582dcf0c8)
(cherry picked from commit 32b0c2c2c1d0e8f69de264f2c3c3b1d473f9ec4f)

WHATSNEW: Start release notes for Samba 3.4.8.

Karolin
(cherry picked from commit 6af316b30898cc2933d8a5925a62f4c8187fd6aa)

Second part of fix for bug #7159 - client rpc_transport doesn't cope with bad server data returns.

If server returns zero on a NP read. Report pipe broken.
Prevents client from looping if it thinks there should be
more data.

Jeremy.
(cherry picked from commit 0055e33dbed0e81548464d01bcf864255bab3159)
(cherry picked from commit f5ca9f84e9b511c2ba7a4280b1997daa441f9877)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit c150cf25f1aa5f034baa08360d5be9b8b532b7cb)

First part of fix for bug #7159 - client rpc_transport doesn't cope with bad server data returns.

Ensure that subreq is *always* talloc_free'd in the _done
function, as it has an event timeout attached. If the
read requests look longer than the cli->timeout, then
the timeout fn is called with already freed data.

Jeremy.
(cherry picked from commit ad77ae1d5870e06f8587ecf634e0b6bdcbb950d7)
(similar to commit 6e5b6b5acb30869eb63b25ed1406014101a5e89d)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 0223d59ea950c8180047fd5de6c85f92c4e37ad2)

s3: Fix bug 7326 -- can't write with vfs_full_audit active
(cherry picked from commit d232dd9df261ff251fd624b2b984355d247bb301)

s3: signals are processed twice in child.

Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit 8c8bb51de1ac2baa46ac0736fae12c034288e5d4)

Fix bug #7206 (duplicate signal handler, signals are processed twice in child
process).
(cherry picked from commit e41d9e75084170fa41a9e313fa79bf351f879840)

Fix bug 7310 - DOS attribute inconsistency with MS Office

On rename we need to set the archive bit on the renamed file.

Jeremy
(cherry picked from commit d5029023e1a44e1bfcbd4e5822d937fa03ba5a1b)

Fix bug 7307 - man net usershare mistake

Fix bad usage message, reported by headset001@yahoo.com.

Jeremy.
(cherry picked from commit e14a6fbf8c9e4d16b2727e48c708ceccfd157e59)
(cherry picked from commit 9620f5fbe64910d86cae51345156a1a4dd71e231)
(cherry picked from commit 41c5ab50749b36557af7e2a16076d330d1c0063b)

Fix bug 7297 - smbd crashes with CUPS printers and no [printers] share defined.

Ensure we don't dereference an array with an index of -1.

Jeremy.
(cherry picked from commit e4127ab299e654777c43d983b2e0a158baa7d79a)
(cherry picked from commit fcb4c51e79f648ae02f77784d46bcc9c7331d3cb)

s3 ntlm_auth: Don't malloc data that will be talloc_free()d

This fixes bug #7290
Thanks to Mohan <mohann@silver-peak.com> for the bug report.
(cherry picked from commit 36ecc6bed9bbf7ed6437433d89ec9d49da43e5ee)

Fix bug #7269 - Job management commands don't work for CUPS queues.

Samba needs to retrieve pjob->sysjob from the CUPS response (as
is done in the iprint backend).
(cherry picked from commit 1790e88f0f9c4fae90dcb53101f70c97ba6a6a5d)
(cherry picked from commit dc83d031398819c1b2c57aacf4f34c304cf09682)

s3-printing: Fix "printer admin" functionality.

Fix bug #7255 ("printer admin" parameter does not work as expected).
(cherry picked from commit 0d6d068bc4f76c2816f969fcce6013e1945794d4)
(cherry picked from commit e74ced9f90ade37fa7bd179a91803f775c77e25b)
(cherry picked from commit a99d9e7678de17486bf34320ef0fda071b24197a)

s3-spoolss: Fix value-needed calculation in_spoolss_EnumPrinterData().

Guenther

Fix bug #7256 (incorrect value-needed calculation in
_spoolss_EnumPrinterData()).
(cherry picked from commit 400801c2314c5effd5165e77cdefc833dee1b6b2)
(cherry picked from commit 78ef22a6f297dcc8045e2479a3af6c1cba34ad16)

s3: Fix an uninitialized variable read

Found by Laurent Gaffie <laurent.gaffie@gmail.com>

Thanks for that,

Volker

Fix bug #7254 (An uninitialized variable read could cause an smbd crash).
(cherry picked from commit 9280051bfba337458722fb157f3082f93cbd9f2b)
(cherry picked from commit 3373b973ef892f013dbf6a1df805de158c0ff4e2)

s3:release-scripts: fix create-tarball to treat vendor patch level correctly
(cherry picked from commit b845025daf2da85eb1af6cbfa7878cf59a32f2a6)
(cherry picked from commit 95c6a5a782caa77bc8bbe75de6ca249bc255507e)
(cherry picked from commit 64fbfee4d322381b8b877feaf1f71b778a88b7f4)

s3: re-run make samba3-idl.

Guenther

The last 16 patches address bug #6727 (Printer issues on 3.4.x).
(cherry picked from commit 7586069115f9b385bba40c7c022a5b516463736f)

s3-spoolss: let _spoolss_DeletePrinterData call into _spoolss_DeletePrinterDataEx.

Guenther
(cherry picked from commit ef9d6580efc55ee040458b7cd76ebdc2e1276e98)
(cherry picked from commit beeb98c693cba71573b1ff7fc6b0349ea4eda8ca)

s3-libads: fix get_remote_printer_publishing_data after spoolss_EnumPrinterDataEx IDL change.

Guenther
(cherry picked from commit 9d5aa986357983fb6a422c0990a3f134e44874d5)

s3-rpcclient: fix rpcclient after spoolss_EnumPrinterDataEx IDL change.

Guenther
(cherry picked from commit becbb624eb90b84ff20b128de1aee5f5acfc3dbc)
(cherry picked from commit e6168075943bf01af1bcf8c0b0ff50b4dc1de82d)

s3-net: fix net after spoolss_EnumPrinterDataEx IDL change.

Guenther
(cherry picked from commit a99ac4f236d9a93d4ca8bd874cbab89b155c644a)
(cherry picked from commit 9c752851bc7291edf05e364ef2f8f387a9984bfa)

s3-spoolss: fix _spoolss_EnumPrinterDataEx after idl

Guenther
(cherry picked from commit 55326549852a3ab1114a8cb1536578ae02183eb8)
(cherry picked from commit 6e677a1242115f57b84eff254ed55af2651df771)

spoolss: fix spoolss_EnumPrinterDataEx IDL.

Guenther
(cherry picked from commit 4df1047e8398a9af4df94c7e245d993d1f60ef5f)
(cherry picked from commit a947b5f827884c18f0f4535f7be7e7cd5b42ee9c)

s3-rpcclient: fix rpcclient after spoolss_GetPrinterData{Ex} IDL change.

Guenther
(cherry picked from commit 345eba78f7fc72f067cd3d95a7698081e09be85f)

s3-spoolss: fix _spoolss_GetPrinterDataEx after IDL change.

Guenther
(cherry picked from commit fbb6d00eed6bca960aa53a5967a2dea426cacfe2)
(cherry picked from commit 017c4ac6c1c2a19345d1f79acf8179a995f38cb5)

s3-spoolss: let _spoolss_GetPrinterData call into _spoolss_GetPrinterDataEx.

Guenther
(cherry picked from commit 697e615843e83d097c5479858a324195450f6c87)

spoolss: rollback GetPrinterData{Ex} IDL.

Guenther
(cherry picked from commit 45195a2689f59be434037274f616083fd8930ffa)

s3-net: fix net after spoolss_SetPrinterData{Ex} IDL change.

Guenther
(cherry picked from commit b2adbea53007d560f95c09af407c1c51a8e78d14)

s3-rpcclient: fix rpcclient after spoolss_SetPrinterData{Ex} IDL change.

Guenther
(cherry picked from commit 4956650369156dfff96ccc827e55697ec642240d)
(cherry picked from commit 7711fe5ca643b32a3873a94d21dc5ec9155ef940)

s3-spoolss: fix _spoolss_SetPrinterData{Ex} after IDL change.

Guenther
(cherry picked from commit 9a934832797c3e72859770719e05d19a5eefa14d)
(cherry picked from commit 20cc464b000beab223aea4b58ff974da9a943806)

s3-spoolss: let _spoolss_SetPrinterData call into _spoolss_SetPrinterDataEx.

Guenther
(cherry picked from commit 167dca0cbf18baf40dd923f6f92421123d34b5a3)
(cherry picked from commit 6f9d646f8071543287466a4a616246b32c80e2ca)

spoolss: rollback SetPrinterData{Ex} IDL.

Guenther
(cherry picked from commit 8c00f95c8d86f2c3c73ce84d3cc0f038d8e0ceb2)

s3:build: Fix automatic building of vfs_tsmsm if gpfs and dmapi are present.

Michael
(cherry picked from commit 9113e14b291c10c824d2d8ea5cb28ffc0adcb63b)

Fix bug #7231 (vfs_tsmsm not built automatically).
(cherry picked from commit 8087ceb42d72f2a07f70e8ab5462775a08303546)
(cherry picked from commit de89fcc1f60d7f287f87507d2187d4ca8966791c)

s3: Fix a NULL pointer dereference

Found by Laurent Gaffie <laurent.gaffie@gmail.com>.

Thanks!

Volker
(cherry picked from commit 25452a2268ac7013da28125f3df22085139af12d)

Fix bug #7229 (NULL pointer dereference).
(cherry picked from commit bf40d130a1761daa14ce6a2cf3d02dbd9095c2b5)
(cherry picked from commit 6e8c643688a323c9a68baa9f015cffec65d75115)

vfs_netatalk: Segfault if hide files or veto files has no ".AppleDouble"

Fix bug #1206 (netatalk vfs causes segfaults in samba).
(cherry picked from commit 531a9ebd52fe65196bb01632a296b40a92a43b4c)
(cherry picked from commit 12dc7210fdba44d4df87102d44ee1bb7fc51f9f3)

WHATSNEW: Start release notes for Samba 3.4.8.

Karolin
(cherry picked from commit cf679452b32de243cea61349f93e661f61ba4988)

VERSION: Raise version number up to 3.4.8.

Karolin
(cherry picked from commit 16f92f795d8403988919f0890445acffa249e29a)

Revert "Fix bug #7067 - Linux asynchronous IO (aio) can cause smbd to fail to respond to a read or write."

This reverts commit c81c109a6ce83741bb5149a51ceb4ab30855e9f9.

This fixes bug #7222 (All users have full rigths on all shares)(CVE-2010-0728).

WHATSNEW: Prepare release notes for Samba 3.4.7.

Karolin

WHATSNEW: Start release notes for Samba 3.4.7.

Karolin
(cherry picked from commit c8fbbbb888a6cc67e603ba04510f5504596b67d8)

VERSION: Raise version number up to 3.4.7.

Karolin
(cherry picked from commit b280381ed338920b1746d0b2b7cd6ea6eb1f92b9)

WHATSNEW: Fix typo.

Karolin
(cherry picked from commit 7ca9130556239eca52ecf8586c19e77780851d93)

WHATSNEW: Update changes since 3.4.5.

Karolin
(cherry picked from commit 7b195c33584ed1c8125c174518fe8e3cd5337ded)

librpc/ndr: don't overwrite the content in ndr_push_relative_ptr2_end()

metze
(cherry picked from commit 76aa37f653fec2d511921768381db7da661750cb)

The last 25 patches address bug #6888 (REGRESSION: printing support for 64 bit
windows clients broken).
(cherry picked from commit 58b089f2176e564bf5563fbffa034cd22525ed6e)

spoolss: use ndr_push_spoolss_PrinterInfo2 hand-marshalled version (moves devmode relative pointer down to sd).

Guenther
(cherry picked from commit 31a097560efddfabf31c4cc54e683603ee24521f)

spoolss: add spoolss_security_descriptor.

Guenther
(cherry picked from commit 18564787e2f169cac26d361201c1a954b7e263b7)

s3: re-run make samba3-idl.

Guenther
(cherry picked from commit d35eb81c50340ed2ac14cdb9965fd13876ea8e64)

security: make two bitmaps public.

Guenther
(cherry picked from commit f10a2d773d141f67319e19b45c40101bb9cb6cf4)
(cherry picked from commit b9748d59c09ffe9de7cbb953939cf89017dc8087)

spoolss: make two bitmaps public.

Guenther
(cherry picked from commit b64cd9857086f56e1e698ae34e51413b6414eb0b)

spoolss: make all security descriptors and devicemodes 4 byte aligned and add missing subcontexts.

Guenther
(cherry picked from commit 8f52957369bf8ce7591d5d9a1436ccb7e384c612)
(cherry picked from commit a4cb14987143c2c1f28e82e5b6476e079ea051d3)

spoolss: set NDR_RELATIVE_REVERSE flag for various unions that have relative pointers.

Guenther
(cherry picked from commit 6d0a39741dacd81e33b25a91fa28cdf983d10d84)
(cherry picked from commit 93aab77e24ecdd95ced8efe0c0f7bcdfb5ed2a1b)

ndr_spoolss_buf: use LIBNDR_FLAG_NO_NDR_SIZE in NDR_SPOOLSS_SIZE_*

metze
(cherry picked from commit 2059a165ee6f4d231aa4075d8ddea70b8df8944f)
(cherry picked from commit 3174acb66089b649ec2b859c1ef673814c44ffa4)

spoolss: use subcontext in NDR_SPOOLSS_PUSH_ENUM_OUT macro.

metze
(cherry picked from commit a4c3aeb79306190b09e284a6a28e3b40fbc5823b)
(cherry picked from commit 4a8dda5b149a82b83d22dc7b0cf77573ef35580d)

libndr: fix ndr_size_* calculation with relative reverse buffers

metze
(cherry picked from commit 8310f02414efd3b792857ed20c636c4c114e1ba2)
(cherry picked from commit 56a6011221aec94b64ac4499b825ff96d1ed22b4)

libndr: for now align reverse relative pointers to 2 bytes by default.

This is just a hack and we should let the callers use FLAG_ALIGN2
explicit in future.

metze
(cherry picked from commit 4a76d29374769ba4c075b8d5767498848d2e17d6)
(cherry picked from commit 00d97b0a06bd1c2d0cb6d15b5560f2850323c1a9)

libndr: implement LIBNDR_RELATIVE_REVERSE handling

This is based on Guenther's initial code.

metze
(cherry picked from commit 31c7780c16651b284009874cf3da04587dc36d19)
(cherry picked from commit 33d03a884eefad8d8c43f3dbe457866282219965)

libndr: store a subcontext buffer size in ndr_push_subcontext_start.

Guenther
(cherry picked from commit 05347754ee61f06466d6d9b7f390001992f793ce)
(cherry picked from commit 4efead4bea29aee555473e1350c3f5671b56c829)

libndr: give an error when ndr_push_relative_ptr2_start()/_end() is used with the RELATIVE_REVERSE flag

metze
(cherry picked from commit b5f9c44da55abb28222441a7e064a2a25891981f)
(cherry picked from commit 2f8872bdff4f193043f5195f11ec6a8b44e0f8f1)

libndr: add LIBNDR_FLAG_NO_RELATIVE_REVERSE so that relative reverse processing can be disabled for single structure elements.

Guenther
(cherry picked from commit a2c34296fa6ca2ffb69cb69698a9b5f81803e8a8)
(cherry picked from commit a026311c81bc8d7f154dad96b77c6121432384a3)

libndr: add LIBNDR_FLAG_RELATIVE_REVERSE flag.

Guenther
(cherry picked from commit ee13a51b0514ec3ac4ca9c532c2b101a08ec9784)
(cherry picked from commit d0eb23b3cd9dbdd174d2c0cdbcdb41fbf2a6df53)

libndr: change subcontext buffer allocation to allocate on subcontext_start.

Guenther
(cherry picked from commit c9fa97b01774d767acfabaf1eec7a6aad1510440)
(cherry picked from commit d2bb2f150a8cf4e18c0bbbc357e237261942dccb)

librpc/ndr: make ndr_push_relative_ptr2() static

metze
(cherry picked from commit d4606cd2663823831d61a98ee719d6121cdcf450)

librpc/ndr_krb5pac: use ndr_push_relative_ptr2_start()/_end()

metze
(cherry picked from commit e03591111a1b9c2f05c29a7afac4641f23f455f4)
(cherry picked from commit 8abc4b5dc5e06e846f0966c74a75f22e27504287)

librpc/ndr_drsblobs: use ndr_push_relative_ptr2_start()/_end()

metze
(cherry picked from commit b423bd2115e006f9af5d40cf5b651e03739d53a0)
(cherry picked from commit c495dd164771cfc8358713c5b07ddd07642fd33c)

spoolss: fix relative pointers in ndr_push_spoolss_DriverInfo101.

Guenther
(cherry picked from commit bfd6edb3e9339d602eb6514ff50c3bb6c671174e)
(cherry picked from commit 8232ada560194fc967cfcb4cb3d14e55e221c321)

s3: re-run make full_idl.

Guenther
(cherry picked from commit 9be36f59cfd1d973feeb045da975aafc869abfbd)

pidl: use ndr_push_relative_ptr2_start and ndr_push_relative_ptr2_end.

Guenther
(cherry picked from commit a049d75193b284fe9efb28d303ea46ba407e5a7a)
(cherry picked from commit c1c56a0ebd6a8c777d8aa8b7d45858d03e7dce57)

libndr: add ndr_push_relative_ptr2_start and ndr_push_relative_ptr2_end.

Guenther
(cherry picked from commit f52de6e2293de4a7ba4726025dd936228b51b5b5)

Fix bug #7154 - mangling method = hash can crash storing a name not containing a '.'

Fix use of uninitialized variable. This can lead to crashes if
mangling = hash processes names with no '.'.

Jeremy.
(cherry picked from commit df13b1303a751962d8f7d5298b39e4a7500fef15)
(cherry picked from commit 7eaeb891c8aee880fb06733f998b2feb95ef9c36)

Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised value(s) error when "mangling method = hash"

The charset array allocated in init_chartest() is allocated
by MALLOC, but only some elements of it being set after allocation. Fix is to
memset to zero after allocation.

Jeremy.
(cherry picked from commit a4e8210ba7d6d471cb9f17754244393b9c1e5930)
(cherry picked from commit fcca63d5fd0b900bc4bdcfbfb21b14f655abbbf7)

Fix bug #6557 - Do not work VFS full_audit

Re-arrange the operations order so SMB_VFS_CONNECT is done
first as root (to allow modules to correctly initialize themselves).

Reviewed modules to check if they needed CONNECT invoked as
a user (which we previously did) and it turns out any of them
that cared needed root permissions anyway.

Jeremy.
(cherry picked from commit 2eb33851a753cbd5594d44243802388cff5ae152)

WHATSNEW: Update changes since 3.4.5.

Karolin
(cherry picked from commit 05e26adc494ad9066e2d4f438368a782db553916)

cifs.upcall: allocate a talloc context for smb_krb5_unparse_name

cifs.upcall calls smb_krb5_unparse_name with a NULL talloc context.
Older versions of this function though will conditionally use
SMB_REALLOC instead of TALLOC_REALLOC when a NULL context is passed
in. To make it more consistent, just spawn a talloc context that
we can pass into this function.

Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=565446
https://bugzilla.samba.org/show_bug.cgi?id=6868

Reported-by: Ludek Finstrle <luf@seznam.cz>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit a8cc2fa09ed43a167f62711bef363a5ac335dc78)

Fix bug #6868 (make bin/cifs.upcall fails).
(cherry picked from commit fa8d57323c0ff4f92f0aca57b41d237340121720)

s3-docs: Add missing para end tag.

Karolin
(cherry picked from commit b78de63ef3cde53e3aabbe46654aac5a335f16a8)
(cherry picked from commit d3738dbe1cabb0ad0acf5f8c9b5e8106285ca9a1)