cgroup: Do not use TLS for buffer that is longer than one page

There seems to be a compiler bug that causes memory corruption in any
spawned threads. This used to materialize mostly in downloading files
when cURL spawned a thread to call the glibc resolver.

See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81142
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Enable lots more compiler warnings

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transaction: Drop unused set status callback

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

libpakfire: Initialize strings correctly

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Fix wrong operator to check if flag is set

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor join function to avoid format errors

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transaction: Fix truncation of integer when showing transaction

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Fix any issues with falling through a switch statement

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

string: Silence a couple of format error warnings

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Fix any incorrect format arguments throughout the code base

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Make old-style functions new-style functions

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Makefile: Do not try to include from non-existant directory

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

string: inline must be the first word in a declaration

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Break if we could not allocate memory on dump

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: grammar: Ensure we always free a dumped parser

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: scanner: Abort if we could not allocate memory

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: string: Free string after the replace test

Generally, we do not free stuff in the tests (because we don't care
about any leaks), but I wanted to see a clear valgrind result on this
one...

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Initialize some more variables in the grammar

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Initialize some more variables

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Leak less memory

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

downloader: Drop old functions

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dist: Refactor downloading sources

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

string: Remove unused chrcnt function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

downloader: Initialize utime

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Remove split function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

package: Split descriptions using strtok()

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Drop pakfire_parser_get_split

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dist: No longer use pakfire_parser_get_split()

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

string: Refactor replacement function once again

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

downloader: Fail if we did not get a schema

It is quite unlikely that we are ending up here, but if we do, the
download with fail cleanly.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

mount: Do not call mount with an empty filesystem type

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dist: Drop our own source mirror

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

downloader: This is the beginning of a rather large rewrite

The downloader code has become very complicated because we have large
functions that perform everything at once.

This patch splits a lot of functionality into smaller steps which are
easier to handle, allow better expansion and so on. You know?

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

progress: Fix division by zero when calculating ETA

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

progress: Implement child progress

This can be used if we need to propagate progress to an upstream
progress indicator.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: progressbar: Increment the size of the bar buffer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: progressbar: Dynamically allocate all buffers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

progress: Set a default start action

If some application is not using the progress feature, at least we have
a log message about what is happening...

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire: Enable progressbar

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

progressbar: Drop old implementation

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

downloader: Use new progress indicator

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Migrate to new progress indicator

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

compress: Migrate to the new progress indicator

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Use the new progress implementation

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

progress: Implement an increment function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

progress: Implement setting the title as a separate call

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Drop tests for the progressbar module

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

_pakfire: Drop the Python wrapper for the progress bar

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

python: hub: Use an external progressbar module

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

progress: Add a new abstraction to indicate progress

The pakfire library has a progressbar object which is complicated to
handle when functions are called from Python, etc.

This new abstraction allows easy handling of progress inside the library
and other applications can hook into it and show the desired status in
whatever way they like.

This patch also implements a classic progressbar in the CLI utils.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Keep log messages in the logger

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Always send everything to the parent logger, too

This patch will make sure that we log everything to the parent logger,
too.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Send all build-related stuff to the build logger

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Log the UUID of the source package

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Refactor the logger

We now have the option to directly write something directly into the
build logger.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Set the default log level to INFO

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Properly crash if we are not handling a CLI argument

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Fix parsing command options

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Keep all appdata in the same struct

This is mainly to make the static analyzer happy which fails to track
any strings allocated and stored in the appdata struct.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: Make the static analyzer happy to free p

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Add implicit dist() when a makefile is passed

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Return better error codes when archives could not be opened

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: build: Show the build log

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Add log callback

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Silence mapping UID/GID messages

This is waaaay to verbose in debug mode.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Add color functions

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Drop old pakfire-builder Python script

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Implement "image create"

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Implement repo compose

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Fix passing around command line arguments

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Implement the build command

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Implement dist command

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Implement shell

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Add info command

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Show more information in build mode

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

libpakfire: Make pakfire_has_flag() public

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Add flag to signal that we are running in build mode

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Remove double error message

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Add other basic commands

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Update help text

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire-builder: Add repolist command

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Move pakfire/pakfire-builder into a single file

There is no point to have subdirectory for only one file when everything
else is going into the lib.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Move any kind of actions into the library so we can re-use them

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Include headers of the library in a more explicit way

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Implement scaffolding for pakfire-builder

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: pakfire: Implement --yes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

libpakfire: Move loglevel into flags on create for Pakfire

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

libpakfire: Drop old CLI functions

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Implement interactive selection of solutions

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Do not compile with -fno-analyzer

The flex/bison-generated code is having too many problems to make this
output any useful.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Implement the confirm callback

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Check very early whether we can install the source package

It might still fail, but at least we tried to solve this here before
extracting the build environment and so on.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

config: Move the strip functions into the string library

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

downloader: Log cURL stuff to the debug log

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

config: Fix read-out-of-bounds when stripping the entire string

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Skip checking files in /usr/lib/valgrind

valgrind is a special case which we cannot harden very well, so we just
skip checking those files.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Do not fail if we did not find a dynamic section

Some files might not have these. That should not be an error, because
those files will fail their checks later on.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Silence a message that an interpreter has been found

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

string: Accept NULL as an empty replacement

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

config: Refactor data model and iterating over sections

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>