TunnelsManager: Report activation errors through the activationDelegate

Don't report activation errors through completion handlers

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: Write versions from both app and extension

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: file_log doesn't need the message type

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: Tag the entries in the merged log

So we know which entry is from the app and which is from the network
extension.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: Use ringlogger for logging from the app

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: ringlogger.c: Trim trailing newlines

Signed-off-by: Roopesh Chander <roop@roopc.net>

Logging: Use ringlogger for logging from the extension

Signed-off-by: Roopesh Chander <roop@roopc.net>

Avoid using 'VPN' in code where possible

Signed-off-by: Roopesh Chander <roop@roopc.net>

mv WireGuard/WireGuard/VPN/ WireGuard/WireGuard/Tunnel/

Signed-off-by: Roopesh Chander <roop@roopc.net>

Commit untested ringlogger code

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Remove useless whitespace

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Settings: better padding calculation

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Fixed hacky logo display for settings

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

More formatting nits and cyclomatic complexity fixes

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

More linter warnings fixed, enabled more swiftlint rules, project cleanup

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Tons more swiftlint warnings fixed. Still a few remaining.

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Added swiftlint and fixed all errors (and a bunch, but not all, warnings)

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Zip importing: importFromFile should take a completionHandler

Deletion of the being-imported file should be done in the
completionHandler.

Signed-off-by: Roopesh Chander <roop@roopc.net>

ErrorPresenter: Support onPresented for showErrorAlert(title:,message:)

Signed-off-by: Roopesh Chander <roop@roopc.net>

Zip importing: Handle spaces in filenames correctly

Previously, if a filename of a .conf file inside the zip file
contained spaces, it was not imported.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Supply missing pieces of path change

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Fixed a potential race condition, better naming on PacketTunnelSettingsGenerator methods

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Added an (unfinished) NWPathMonitor implementation for reconnecting on network changes

Signed-off-by: Eric Kuck <eric@bluelinelabs.com>

Revert pure-go network monitoring and add wgSetConfig

This reverts commit 99f0e457c34480f25582d7b4ed509404712c648c and adds a
function too.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

State restoration: Don't create duplicate mainVC and tunnelsListVC

This creates a duplicate tunnels manager, leading to problems tracking
tunnel statuses.

To reproduce the bug that this commit fixes, you can do the following:
1. Remove all tunnels
2. Run in Xcode
3. Import zip with ~10 tunnels
4. Stop app in Xcode
5. Run in Xcode
6. Turn on 1st tunnel, after it's on, turn off
Turn on 2nd tunnel, after it's on, turn off
...
After 6-8 tunnels, the spinner doesn't show up, indicating that the
status is not being tracked.

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Error out only on no-internet scenario

The other scenario happens even during reloading of a tunnel for activation.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Remove the feature of waiting for another tunnel to deactivate

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Deactivate only when the status becomes 'connected'

Signed-off-by: Roopesh Chander <roop@roopc.net>

Allow turning off the status switch of a waiting tunnel

It just means the waiting should be cancelled

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Handle status change in TunnelsManager

Rather than in TunnelContainer.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error handling: alertText() can be nil

Indicating that no alert is to be shown for that error.

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Don't act on status change on tunnelProviders we don't have

That causes errors we don't want, and duplicate notifications.

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Always call the completion handler before returning

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Debugging helpers for tunnel status

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Handle deactivation of a waiting tunnel

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnels list: Fix AutoLayout error during deletion of a tunnel

Signed-off-by: Roopesh Chander <roop@roopc.net>

Settings: Dynamic Type support

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel edit: Dynamic Type support

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel detail: Dynamic Type support

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnels list: Dynamic Type support for the add button at the center

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnels list: Dynamic Type support for the table view

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: Declare keyLength constant and use that wherever applicable

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Observe status for all tunnels in one block

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Remove unused variables

Signed-off-by: Roopesh Chander <roop@roopc.net>

Zip: Fix comment

Signed-off-by: Roopesh Chander <roop@roopc.net>

Version bump

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

PacketTunnelProvider: Show log timestamp

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

wireguard-go-bridge: account for network changes

Everytime the network changes, we need to recreate the UDP socket,
because the ephemeral listen port is tied to the old physical interface.
As well, we need to re-set the IP addresses for each endpoint, so that
they're passed to getaddrinfo and are then resolved using DNS46.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Zip: Increase size of buffer used to read data from the archive

Signed-off-by: Roopesh Chander <roop@roopc.net>

Settings: Export log: Perform file operations in a background thread

Signed-off-by: Roopesh Chander <roop@roopc.net>

On-Demand: TunnelViewModel: Make activate-on-demand methods static

Signed-off-by: Roopesh Chander <roop@roopc.net>

On-Demand: Move detail text to TunnelViewModel

Signed-off-by: Roopesh Chander <roop@roopc.net>

Plist: Handle crypto export

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Make strings consistent

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

State restoration: Restore tunnel detail view

Signed-off-by: Roopesh Chander <roop@roopc.net>

Main VC: No need to refresh statuses if the tunnelsManager isn't initialized yet

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnels list: Deselect rows correctly

Do it like UITableViewController.clearsSelectionOnViewWillAppear would.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Settings: Exporting configs as zip should open document picker

Because:
- Exporting UI should be consistent with importing UI
- UIActivityVC takes a long time to open

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error handling: Use ErrorPresenter.showErrorAlert() instead of per-VC showErrorAlert() methods

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error handling: Use WireGuardAppError and WireGuardResult throughout the app

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error handling: Introduce a WireGuardResult type to handle errors in callbacks across the app

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error handling: Introduce a WireGuardAppError protocol to manage errors

The alert strings shall be located next to where the errors are declared.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error handling: Cleanup Tunnels Manager errors

Signed-off-by: Roopesh Chander <roop@roopc.net>

Error presenter: Always handle the passed error

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel detail: Cell status switch should be toggled only after the alert presentation completes

Signed-off-by: Roopesh Chander <roop@roopc.net>

Refactoring: Consolidate file deletion into a separate function

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: Logging: Log file should begin with version numbers and tunnel name

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: Logging: Make it clear which calls to wg_log use String and which use StaticString

Signed-off-by: Roopesh Chander <roop@roopc.net>

Settings: Add timestamp to exported log

And remove the exported log afterwards.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Refactor out VPN-handling stuff from tunnels list VC to the main VC

Signed-off-by: Roopesh Chander <roop@roopc.net>

VPN: Error out when tunnel activation fails because there's no internet

Signed-off-by: Roopesh Chander <roop@roopc.net>

Settings: Export log file

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: Write log to file

Signed-off-by: Roopesh Chander <roop@roopc.net>

Info.plist: Add app group id for accessing from both the app and the network extension

Signed-off-by: Roopesh Chander <roop@roopc.net>

Xcode: Add app groups capability

Signed-off-by: Roopesh Chander <roop@roopc.net>

It's 'WiFi', not 'Wifi'

Signed-off-by: Roopesh Chander <roop@roopc.net>

NE: All DNS queries must first go through the VPN's DNS servers

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel view model: Invalidate the configuration object when updating allowedIPs using the 'Exclude private IPs' switch

Signed-off-by: Roopesh Chander <roop@roopc.net>

Config file parser: Be case-insensitive to attribute keys in the config file

Signed-off-by: Roopesh Chander <roop@roopc.net>

Config file parser: Fix typo

Signed-off-by: Roopesh Chander <roop@roopc.net>

Exporting: Export to zip in a background thread

Signed-off-by: Roopesh Chander <roop@roopc.net>

Exporting: Refactor out zip exporting into a separate class

Signed-off-by: Roopesh Chander <roop@roopc.net>

Exporting: No need to check for duplicate names - we disallow it at creation time itself

Signed-off-by: Roopesh Chander <roop@roopc.net>

Importing: Import from zip in a background thread

Signed-off-by: Roopesh Chander <roop@roopc.net>

Importing: Refactor out zip importing into a separate class

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnels manager: After saving after activating on-demand, reload tunnel

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnels manager: Need to keep VPN-on-demand tunnels's status under observation

Because they can turn on automatically, even while the app is in the foreground.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel detail: Show VPN-on-demand information

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnels manager: Keep track of NETunnelProviderManager's isOnDemandEnabled property

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel edit: Update for VPN-on-demand changes

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel view model: VPN-on-demand stuff shouldn't be part of the tunnel model

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model, Tunnels manager: Rewrite the model for VPN-on-demand

The VPN-on-demand settings should not be part of the tunnel
configuration. Rather, the onDemandRules stored in the
tunnel provider configuration serve as the one place
where the VPN-on-demand settings are stored.

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: Support for on-demand rules

Signed-off-by: Roopesh Chander <roop@roopc.net>

Tunnel edit, Tunnel view model: UI for providing On-Demand activation options

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: Add activationType to tunnel configuration

We make sure existing tunnel serializations can be deserialized correctly.

We also bump up the tunnelConfigurationVersion, because the tunnel
configuration contents have changed.

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: ActivityType enum to represent VPN-on-demand options

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: TunnelConfiguration: Add explicit conformance to Decodable

Signed-off-by: Roopesh Chander <roop@roopc.net>

Model: Ensure that a TunnelConfiguration always has a valid array of peers

Signed-off-by: Roopesh Chander <roop@roopc.net>

VPN: When activating while another tunnel is active, deactivate the other tunnel

Signed-off-by: Roopesh Chander <roop@roopc.net>

TunnelsManager: startDeactivation() need not take a completion handler

Because the completion handler pattern doesn't fit in this case.

Signed-off-by: Roopesh Chander <roop@roopc.net>