Timo Sirainen [Tue, 30 Jun 2015 10:58:15 +0000 (13:58 +0300)]
doveadm: Added doveadm_username to specify the username for authentication.
The default is still "doveadm" and the server side doesn't currently support
anything except "doveadm".
Timo Sirainen [Tue, 30 Jun 2015 09:18:08 +0000 (12:18 +0300)]
istream filters: If parent's i_stream_stat() fails, copy the stream_errno.
This doesn't actually change any functionality yet, since most
i_stream_stat() callers aren't using i_stream_get_error().
Timo Sirainen [Tue, 30 Jun 2015 09:17:35 +0000 (12:17 +0300)]
lib: istream_file.stat() fails, set stream_errno and error string.
For now we'll also keep logging the error since everybody isn't using
i_stream_get_error().
Timo Sirainen [Tue, 23 Jun 2015 09:31:21 +0000 (11:31 +0200)]
lib-storage: Set MAILBOX_SELECT/NONEXISTENT for namespace prefix even if no flags are wanted.
This fixes doveadm commands attempting to access such nonexistent mailbox
prefixes.
Timo Sirainen [Wed, 17 Jun 2015 13:37:37 +0000 (16:37 +0300)]
fs-posix: Hide temporary files from fs_iter_*()
Those could exist just because another process is just using them to create
new files to the directory. Although they could also be older files caused
by earlier crashes. It would probably be a good idea to have fs_iter_*()
delete the old temporary files automatically.
Timo Sirainen [Wed, 17 Jun 2015 11:04:42 +0000 (14:04 +0300)]
fts-solr: Avoid sending too large queries to Solr due to listing wanted mailboxes.
This is mainly a problem if there are a lot of mailboxes and "All Mails"
virtual mailbox. For now hardcoded to send max 10 mailboxes in the query,
afterwards it just returns matches in all the mailboxes and we'll filter out
the unwanted mailboxes.
Timo Sirainen [Wed, 17 Jun 2015 10:55:37 +0000 (13:55 +0300)]
fts-solr: Removed assert to fix indexing multiple mailboxes.
fts plugin may want to do last-uid lookup for a new mailbox while we still
have posting open for the previous one.
Timo Sirainen [Wed, 17 Jun 2015 10:12:37 +0000 (13:12 +0300)]
fts-tika: Fixed crashes when indexing larger attachments with fts-solr.
We were mixing ioloops without switching back to the original ioloop in the
middle. Also io_remove() at deinit caused another timeout to be added, so
this needs to be done while original ioloop is active or we'll just leak the
just-added timeout in io_loop_destroy() and crash later.
Timo Sirainen [Wed, 17 Jun 2015 09:21:52 +0000 (12:21 +0300)]
lib-fs: Call o_stream_nfinish() automatically for all backends in fs_write_stream_finish()
Otherwise each backend needs to do it internally. fs-metawrap for example
was missing this and causing assert-crashes.
Phil Carmody [Wed, 17 Jun 2015 08:42:53 +0000 (11:42 +0300)]
lib: test-data-stack - simplify #if-ing out of DEBUG-only fatal test
With no canaries, nothing can be tested, so just reduce this to a trivial
1-line return on the non-DEBUG case.
Phil Carmody [Wed, 17 Jun 2015 08:42:30 +0000 (11:42 +0300)]
lib: test-data-stack - ensure t_push() and t_pop() are balanced in fatal tests
If the t_pop() unexpectedly succeeds, we won't want to do another one upon
entering the function again.
Timo Sirainen [Wed, 17 Jun 2015 08:31:02 +0000 (11:31 +0300)]
auth: Added allow_real_nets setting.
The difference to allow_nets is that it matches against the connection's
"real IP" rather than what the connection told was the original client's IP
address (%{rip} vs %{real_rip})
This means that all FS operations have a 10% chance of failing, except reads
have a 30% chance of failing. If the read fails, it'll fail somewhere
between offsets 2000-3000 (the default is 0, so it'll fail at the start of
file).
The supported operations are: wait metadata prefetch read write lock exists
stat copy rename delete iter. "all" applies to all of them.
The supported ranges are: read-range, write-range, iter-range.
Phil Carmody [Mon, 15 Jun 2015 11:54:58 +0000 (14:54 +0300)]
director: explicitly mark _disconnect() helper static to match proto
No functional change, compiler would not have exported the symbol, this
just shuts up sparse.
Timo Sirainen [Mon, 15 Jun 2015 11:51:46 +0000 (14:51 +0300)]
fs-metawrap: If written file unexpectedly shrinks, return error instead of assert-crash.
This shouldn't be happening, but we can't fully control it so an error is
better.
Phil Carmody [Mon, 15 Jun 2015 11:31:19 +0000 (14:31 +0300)]
lib-test: test_expect_error_string() to match a single known message
This gives us very fine control over what is acceptable as an expected warning.
Alas you have to do it for each message individually.
Phil Carmody [Mon, 15 Jun 2015 11:31:19 +0000 (14:31 +0300)]
lib-test: let tests invoke i_warning/i_error behaviour
Error-handling paths should be testable too. Permit a test case to register
that a known number of warnings/errors are to be expected, and to verify
that those warnings did occur afterwards. Too many messages will fail the
test exactly as it did in the past, they're unexpected messages. However,
too few messages will also cause the test case to fail.
Phil Carmody [Mon, 15 Jun 2015 11:31:19 +0000 (14:31 +0300)]
lib-test: flush test-assert failure messages
Diagnostic output to stderr may overtake these stdout logs if the streams
are combined by the shell or on the console. fflush() might help realign
them.
Phil Carmody [Mon, 15 Jun 2015 11:25:07 +0000 (14:25 +0300)]
lib: array - permit array_swap with uninitialised arrays
Before initialisation, all fields are blank, so the element_size field
is not the actual size, and the i_assert would fire.
Timo Sirainen [Thu, 11 Jun 2015 16:21:16 +0000 (19:21 +0300)]
lib-index: Avoid writing tail offset update to transaction log if it's not necessary.
This should avoid extra writes that do nothing but update the tail offset.
mdbox's map requires this behavior, so disable it for it. For others it
might cause the next sync to read more data unnecessarily, but it should be
worth the extra cost of write most of the times.
Timo Sirainen [Wed, 10 Jun 2015 17:29:35 +0000 (20:29 +0300)]
lmtp: Fixed assert-crash on anvil lookup failures.
If anvil_client_query() fails, it immediately calls the callback and returns
NULL. So we need to increase anvil_queries even before calling
anvil_client_query()
Timo Sirainen [Tue, 9 Jun 2015 16:32:09 +0000 (19:32 +0300)]
dict-sql: Don't try to optimize finding a matching map by using the previous match.
In some setups multiple maps can match and it's important that the matching
is done in the same order always, otherwise the results could become
somewhat random.
Timo Sirainen [Wed, 3 Jun 2015 20:56:32 +0000 (23:56 +0300)]
fts: Added "doveadm fts lookup" command.
This is mainly useful for debugging lib-fts. It doesn't perform any of the
lib-fts tokenization / filtering so you can do raw lookups.
Timo Sirainen [Wed, 3 Jun 2015 19:30:05 +0000 (22:30 +0300)]
indexer: Improved handling multiple indexing requests to the same mailbox.
If a request arrives for a mailbox that we were already indexes, the
previous code simply sent the indexing request to the existing worker
process. This could have caused a lot of requests to be buffered to the same
mailbox if the indexing took a long time, which could have taken a while to
process even though they weren't really doing anything indexing work.
The new code instead just keeps track in memory that when the earlier
indexing is finished, it's done again once to finish any pending changes.
Teemu Huovila [Wed, 3 Jun 2015 13:47:25 +0000 (16:47 +0300)]
lib-lda: Fixed crash in mail_deliver_get_log_var_expand_table().
Discovered by clang static analyzer. This caused crashes with older versions
of Pigeonhole.
Timo Sirainen [Tue, 2 Jun 2015 21:46:23 +0000 (00:46 +0300)]
lib-fts: fts-filter API changed to have a non-pointer vfuncs variable.
The main benefit being that the fts-filter implementations can save a few
lines of code.
Timo Sirainen [Tue, 2 Jun 2015 18:56:03 +0000 (21:56 +0300)]
lib-fts: Added string_t *token to struct fts_filter
This makes the work a bit easier for simple filters that don't need any
state but want to use a string_t.