]> git.ipfire.org Git - thirdparty/sqlite.git/log
thirdparty/sqlite.git
14 months agoOnly allow variables in LIMIT clauses if the LIMIT is within a LATERAL subquery
drh [Mon, 22 Jul 2024 16:59:35 +0000 (16:59 +0000)] 
Only allow variables in LIMIT clauses if the LIMIT is within a LATERAL subquery
and the variable resolves to another FROM clause term to the left of the
subquery.  We cannot allow variables from outer contexts because the LIMIT
value is computed before the cursors in the outer context have been initialized.

FossilOrigin-Name: 0a2531c3a3750fd22360595274eb97fa66d17a90502180b7b11adc5b136da5ed

14 months agoAllow LIMIT expressions to appear in any outer context.
drh [Mon, 22 Jul 2024 16:15:25 +0000 (16:15 +0000)] 
Allow LIMIT expressions to appear in any outer context.

FossilOrigin-Name: c9d3427de5b55303279449023b7d7957821bfe97089547dcafcfb913806745ed

14 months agoDo not allow LIMIT and OFFSET to be expressions except for in a LATERAL.
drh [Mon, 22 Jul 2024 13:55:44 +0000 (13:55 +0000)] 
Do not allow LIMIT and OFFSET to be expressions except for in a LATERAL.

FossilOrigin-Name: 10347821376db1d33895fa794ac093ec6c2cc28daebe9adfd2578cbd1b3ce386

14 months agoAllow LIMIT and OFFSET to contain variables from prior terms of the
drh [Mon, 22 Jul 2024 00:46:10 +0000 (00:46 +0000)] 
Allow LIMIT and OFFSET to contain variables from prior terms of the
FROM clause in a LATERAL subquery.
[forum:/forumpost/dfe2cd37ca3a9a80|Forum post dfe2cd37ca3a9a80]

FossilOrigin-Name: 4f0515138acb5f04b5b2f8b9efa47e1b09f35060fb260dad44617dd88ae1bab8

14 months agoMerge debugging output fixes from trunk into the lateral-join branch.
drh [Sun, 21 Jul 2024 23:36:32 +0000 (23:36 +0000)] 
Merge debugging output fixes from trunk into the lateral-join branch.

FossilOrigin-Name: 9182e999524bf55bf6a336c02ff5fb129a89ee7ed6fd859d4050ba1dbffcf4df

14 months agoFixes to TreeView debugging output for VALUES clauses.
drh [Sun, 21 Jul 2024 23:34:52 +0000 (23:34 +0000)] 
Fixes to TreeView debugging output for VALUES clauses.

FossilOrigin-Name: b6aed8bcb06edc7f0221fd707d5adc227856fe62dbcaae5ffe1fb4faa5c542e1

14 months agoImproved debugging output when using PRAGMA vdbe_addoptrace:
drh [Sun, 21 Jul 2024 23:10:55 +0000 (23:10 +0000)] 
Improved debugging output when using PRAGMA vdbe_addoptrace:
Show the range of opcodes being checked for Column-to-Copy conversion.

FossilOrigin-Name: 2c122026db979a099a3d1a14ae1e01a0a64a559905ea414b2d80ed7dc3e04846

14 months agoFix to the case of a LATERAL subquery that references a prior table that
drh [Sun, 21 Jul 2024 21:37:33 +0000 (21:37 +0000)] 
Fix to the case of a LATERAL subquery that references a prior table that
uses a covering index. [forum:/forumpost/fc29fa4f14|Forum post fc29fa4f14].

FossilOrigin-Name: 6d863172dc736169bd5c303fab5d2fc47324261f29cdabb692781cd0fd609c87

14 months agoAssert added to ensure that LATERAL subqueries are materialized instead of
drh [Sun, 21 Jul 2024 18:03:07 +0000 (18:03 +0000)] 
Assert added to ensure that LATERAL subqueries are materialized instead of
implemented as a co-routine.

FossilOrigin-Name: 6c14b94fb678c70e32519f3e0141f80e6efb3015340a84eb355ab371c5e9facd

14 months agoFix LATERAL subqueries so that they are able to reference other subqueries
drh [Sun, 21 Jul 2024 10:35:55 +0000 (10:35 +0000)] 
Fix LATERAL subqueries so that they are able to reference other subqueries
to their left that are implemented as co-routines.  See
[forum:/forumpost/dfe2cd37ca3a9a80|Forum post dfe2cd37ca3a9a80].

FossilOrigin-Name: 31e175fcd0ff823941d4f0f53f7bc6a65fb5b00de78cdb6a9d622cc96b6a6f15

14 months agoFix rule (1c-ii) of the fromClauseTermCanBeCoroutine() decision so that it
drh [Sat, 20 Jul 2024 17:38:56 +0000 (17:38 +0000)] 
Fix rule (1c-ii) of the fromClauseTermCanBeCoroutine() decision so that it
work with LATERAL.  Add testcase() macros to verify bitmask conditions are
all checked.

FossilOrigin-Name: 23d83a41eab35d16bfc960d62d3b29f7bd465d0507bbc68c72b880553f34b58e

14 months agoFix an oversized allocation in sqlite3ExprCodeIN().
dan [Sat, 20 Jul 2024 16:11:12 +0000 (16:11 +0000)] 
Fix an oversized allocation in sqlite3ExprCodeIN().

FossilOrigin-Name: d7be326a80e7b3aa8fd6e5e059c04e6ad3feaffcb20b1e3c251d7195ddc1be8b

14 months agoAdd testcase() macros to bitmap tests in the new code.
drh [Sat, 20 Jul 2024 14:06:16 +0000 (14:06 +0000)] 
Add testcase() macros to bitmap tests in the new code.

FossilOrigin-Name: 874bc7bc25e4733bfbb1d0989aa3eed62138ff99e7f31c6753646ea7994cad67

14 months agoRemove an unnecessary error offset assignment.
drh [Sat, 20 Jul 2024 09:36:04 +0000 (09:36 +0000)] 
Remove an unnecessary error offset assignment.

FossilOrigin-Name: 4ee74b7224ce2d1523295f7aef6dbf56e6071f9673eeff102eeb59b52b991857

14 months agoOptimizations and improved comments.
drh [Sat, 20 Jul 2024 08:31:52 +0000 (08:31 +0000)] 
Optimizations and improved comments.

FossilOrigin-Name: 84b80233e7f1afd9ed2c0c63f2d641891d9ed06cc160fee55c75a6fd77af6144

14 months agoDo not do an early abort if a lateral subquery is an empty set.
drh [Sat, 20 Jul 2024 03:57:10 +0000 (03:57 +0000)] 
Do not do an early abort if a lateral subquery is an empty set.

FossilOrigin-Name: 9e50d338ebd974b5d1b8baf4c7a400abded28ee997414e896c2e8b9d61d39a94

14 months ago"LATERAL" may not be a keyword, as that would cause problems for legacy
drh [Sat, 20 Jul 2024 03:19:40 +0000 (03:19 +0000)] 
"LATERAL" may not be a keyword, as that would cause problems for legacy
databases that have tables named "lateral".  It has to be parsed as an
identifier.

FossilOrigin-Name: 8217bddaf8c0697799c7518746996665bbd1f5a327315d18091a6ab3250f1112

14 months agoExperimental implementation of LATERAL JOIN.
drh [Sat, 20 Jul 2024 01:19:18 +0000 (01:19 +0000)] 
Experimental implementation of LATERAL JOIN.

FossilOrigin-Name: 3c045a96bc65713e5544af82b8547cdcdf93fa20f9b7b0851d77f8c090cc650b

14 months agoMinor typo fixes in test-script-interpreter.md.
stephan [Thu, 18 Jul 2024 19:17:29 +0000 (19:17 +0000)] 
Minor typo fixes in test-script-interpreter.md.

FossilOrigin-Name: bf54b26092ded2e6acc779acfb960364f05c665c7626c38ffae61caae5636184

14 months agoFix a problem in FTS5 where it reports the wrong error code following an OOM.
drh [Thu, 18 Jul 2024 18:44:44 +0000 (18:44 +0000)] 
Fix a problem in FTS5 where it reports the wrong error code following an OOM.

FossilOrigin-Name: 0c1cc4071edcd3e465779bbb17ea3ee6ddaa7c93c4fde55e5f3e07aa4b45783b

14 months agoFixes for platforms with 32-bit pointers that require 64-bit values to be aligned.
dan [Wed, 17 Jul 2024 18:38:34 +0000 (18:38 +0000)] 
Fixes for platforms with 32-bit pointers that require 64-bit values to be aligned.

FossilOrigin-Name: 539e4f661767ef90aef8d995f1f75fd5f550703bba1517cd3caff84a4afe2b37

14 months agoAdd extra assert() statements to the fixes on this branch. alignment-fixes
dan [Wed, 17 Jul 2024 16:27:36 +0000 (16:27 +0000)] 
Add extra assert() statements to the fixes on this branch.

FossilOrigin-Name: 81b6360050eea95e4367de1b41b5864a640b4d1c5c8fc3bea3b96ed770cb0325

14 months agoSlight doc touchup for [af41a1e6fc8b36e9bf65] based on feedback. No code changes.
stephan [Mon, 15 Jul 2024 10:11:21 +0000 (10:11 +0000)] 
Slight doc touchup for [af41a1e6fc8b36e9bf65] based on feedback. No code changes.

FossilOrigin-Name: be7b1fc0c5d8cda971b471dfcb4637212bfff4f42b1e074077a381cc493d877a

14 months agoImprove one of the JS test cases.
stephan [Sat, 13 Jul 2024 18:16:40 +0000 (18:16 +0000)] 
Improve one of the JS test cases.

FossilOrigin-Name: 3767d8bef2dfa661b56c1bfaa4695e32ce26874154e4a322f0d599c257c6fc70

14 months agoFixes for platforms with 32-bit pointers that require 64-bit values to be aligned.
dan [Sat, 13 Jul 2024 16:53:56 +0000 (16:53 +0000)] 
Fixes for platforms with 32-bit pointers that require 64-bit values to be aligned.

FossilOrigin-Name: 2212d7488ed4ec2839ffa45cb9567056b36519434834634e4ecc441c330694d7

14 months agoAdd JS binding for sqlite3_column_decltype().
stephan [Sat, 13 Jul 2024 15:42:30 +0000 (15:42 +0000)] 
Add JS binding for sqlite3_column_decltype().

FossilOrigin-Name: 5252d292b14f6ed99b09f6330b19effd488c2b23ff6ea33311321a065d3f6ce2

14 months agoJS doc touchups. No code changes.
stephan [Sat, 13 Jul 2024 15:21:35 +0000 (15:21 +0000)] 
JS doc touchups. No code changes.

FossilOrigin-Name: a8e240495ff7e0cd38301ef2de215a7cc10fea832311bd19ca2592858ee4e6ff

14 months agoAdd JS bindings for sqlite3_stmt_busy() and sqlite3_stmt_explain().
stephan [Sat, 13 Jul 2024 14:07:47 +0000 (14:07 +0000)] 
Add JS bindings for sqlite3_stmt_busy() and sqlite3_stmt_explain().

FossilOrigin-Name: b772edfb44143107d4993bde600d0f4c45184f29a4deee403105c64748c36523

14 months agoAdd missing sqlite3_bind_parameter_name() binding to JS.
stephan [Sat, 13 Jul 2024 13:22:32 +0000 (13:22 +0000)] 
Add missing sqlite3_bind_parameter_name() binding to JS.

FossilOrigin-Name: 6dcfcc7e1c0772b11aec750bb75899a5c8e452735ecf5028c001fbaa7aa6fda0

14 months agoAdd JS bindings and tests for sqlite3_interrupted(), is_interrupted(), and db_readonly().
stephan [Sat, 13 Jul 2024 12:50:42 +0000 (12:50 +0000)] 
Add JS bindings and tests for sqlite3_interrupted(), is_interrupted(), and db_readonly().

FossilOrigin-Name: 5589ba5651d80479ae555429340fc74390ff07d3e05ba770bb7d82490211e00d

14 months agoRemove a stray/harmless duplicate wasm function export entry.
stephan [Sat, 13 Jul 2024 11:47:44 +0000 (11:47 +0000)] 
Remove a stray/harmless duplicate wasm function export entry.

FossilOrigin-Name: 5402e4fb1cbd7a2c3dee6ebfb492a076d05daa66f747d18602338874405829df

14 months agoAdd several convenience links to the OPFS VFS concurrency tester app for launching...
stephan [Sat, 13 Jul 2024 01:40:36 +0000 (01:40 +0000)] 
Add several convenience links to the OPFS VFS concurrency tester app for launching it with various combinations of options.

FossilOrigin-Name: 397d6a18f173a46b60a867fc45611045c76316d6602a3df8b4dc4ba45e1348ce

14 months agoAdd an option to the opfs-sahpool VFS which tells it to ignore a previous init failur...
stephan [Sat, 13 Jul 2024 01:02:57 +0000 (01:02 +0000)] 
Add an option to the opfs-sahpool VFS which tells it to ignore a previous init failure and retry, as an opt-in workaround for a browser quirk which occasionally denies OPFS access on the first attempt and permits it on subsequent attempts. This resolves [https://github.com/sqlite/sqlite-wasm/issues/79|issue #79 of the npm distribution].

FossilOrigin-Name: fbf3948a4ba27c6ebf55b24e7463b20026439f04d1974bafe78df5c5bc958f59

14 months agoRename the new opfs-sahpool init-retry flag to the suitably descriptive, and suitably... sahpool-reinit-fallback
stephan [Sat, 13 Jul 2024 00:55:55 +0000 (00:55 +0000)] 
Rename the new opfs-sahpool init-retry flag to the suitably descriptive, and suitably onerous, forceReinitIfPreviouslyFailed, based on feedback.

FossilOrigin-Name: c9f0a6090258534a3d81066df5610229183a8457fc60d5034b4b94d9a29796e4

14 months agosqldiff: fail if the 2nd db argument cannot be opened read-only.
stephan [Fri, 12 Jul 2024 14:41:16 +0000 (14:41 +0000)] 
sqldiff: fail if the 2nd db argument cannot be opened read-only.

FossilOrigin-Name: e8b33525fc2b4d609a7be9acc43fbc66638effaa7b092b48568ded6c53c4f4db

14 months agoWork around a difficult-to-trigger Atomics API message-passing quirk in the OPFS...
stephan [Fri, 12 Jul 2024 13:49:54 +0000 (13:49 +0000)] 
Work around a difficult-to-trigger Atomics API message-passing quirk in the OPFS VFS which appears in rare instances in some browsers when running high I/O loads. This resolves [https://github.com/sqlite/sqlite-wasm/issues/12 | issue #12 of the npm distribution].

FossilOrigin-Name: af41a1e6fc8b36e9bf65a5bb0154e1ce7eb99903cb5a3e4779322527c29d8780

14 months agosqldiff: if the first db argument does not exist, fail instead of creating an empty...
stephan [Fri, 12 Jul 2024 13:45:15 +0000 (13:45 +0000)] 
sqldiff: if the first db argument does not exist, fail instead of creating an empty db. Resolving that for the second argument is trickier, as discussed in [forum:ec2d429e32 | forum post ec2d429e32].

FossilOrigin-Name: 0547ccf776c6054732437bffb8b2fe2ed5194ef817c2593f8cec4a3e2b749720

15 months agoReformulate the forceReinitIfFailed handling based on feedback, to correct the type...
stephan [Thu, 11 Jul 2024 19:50:17 +0000 (19:50 +0000)] 
Reformulate the forceReinitIfFailed handling based on feedback, to correct the type-checking and resolve a potential race condition.

FossilOrigin-Name: c4f468309158f9b951137461213fb269d96d15c331256cf392a56c9bed231460

15 months agoRemove the timing and counter metrics from the OPFS VFS, as they're long-since unused... opfs-errant-op
stephan [Thu, 11 Jul 2024 14:07:46 +0000 (14:07 +0000)] 
Remove the timing and counter metrics from the OPFS VFS, as they're long-since unused so are just wasted CPU cycles.

FossilOrigin-Name: 67c035c34fb916e66bfe115a132660771e8fa2921e6d46756975c5df3ebcd73c

15 months agoAdd some docs explaining [64f4f3cd878b1a72].
stephan [Thu, 11 Jul 2024 12:57:58 +0000 (12:57 +0000)] 
Add some docs explaining [64f4f3cd878b1a72].

FossilOrigin-Name: 4fdf9a322fccf7d68b03d07a42a526f18f951e2e19228b7d41e01121b667cc86

15 months agoProposed workaround for the "errant op" case in the OPFS VFS, as discussed in [https...
stephan [Thu, 11 Jul 2024 12:36:28 +0000 (12:36 +0000)] 
Proposed workaround for the "errant op" case in the OPFS VFS, as discussed in [https://github.com/sqlite/sqlite-wasm/issues/12 | issue #12 of the npm distribution].

FossilOrigin-Name: 64f4f3cd878b1a723caa0cd54b21f10fdb27d4e2ecb19fc233cbc8dd9d06f259

15 months agoAdd an option to force the opfs-sahpool VFS init to re-run after it fails on a first...
stephan [Thu, 11 Jul 2024 11:04:17 +0000 (11:04 +0000)] 
Add an option to force the opfs-sahpool VFS init to re-run after it fails on a first attempt, as a workaround for flaky environments where initial access to OPFS sync access handles is rejected but then permitted on a second attempt. Reported and discussed in [https://github.com/sqlite/sqlite-wasm/issues/79|issue #79 of the npm distribution].

FossilOrigin-Name: 5286e0f654d91a4ebee51fcabaab696e17ff07bb18990b401a31bd3d1213e695

15 months agoRename some JS files for consistency. This affects only the build process, not the...
stephan [Wed, 10 Jul 2024 08:33:52 +0000 (08:33 +0000)] 
Rename some JS files for consistency. This affects only the build process, not the deliverables.

FossilOrigin-Name: bcef3f71a2f68768819d9f716f2c29e752fb173df1506469c8669d95ecc2ff50

15 months agoFix a use-after-free that could occur following an OOM introduced by [d8cedbe0].
dan [Mon, 8 Jul 2024 17:39:52 +0000 (17:39 +0000)] 
Fix a use-after-free that could occur following an OOM introduced by [d8cedbe0].

FossilOrigin-Name: 4fabfacfcf38e129949d3e4e2c3ffde3da3cd40d9d12c97ca29bc7c3604db6ed

15 months agoImprove the error message returned when fts5 finds a row is missing from its content...
dan [Mon, 8 Jul 2024 16:01:49 +0000 (16:01 +0000)] 
Improve the error message returned when fts5 finds a row is missing from its content table.

FossilOrigin-Name: 9b1afd4acb8cf9738154e921dcb074d895bbcc4742bf1016ef9f045a0da78bc8

15 months agoUse a mini Bloom filter to help reduce the number of pointless searches for
drh [Fri, 5 Jul 2024 13:55:59 +0000 (13:55 +0000)] 
Use a mini Bloom filter to help reduce the number of pointless searches for
prior SubrtnSig objects when generating code for IN operators with subqueries
as their right operand.

FossilOrigin-Name: d8cedbe055b40a0ea4e5d47845b535162e9fcb0d0f88c03211797ab64d2d56fb

15 months agoImproved reuse of subqueries associated with IN operators, especially when
drh [Fri, 5 Jul 2024 09:56:11 +0000 (09:56 +0000)] 
Improved reuse of subqueries associated with IN operators, especially when
the IN operator is duplicated due to predicate push-down.

FossilOrigin-Name: c9a3498113074bbcd9a8c8d30286fef6c6a49ad2c84b90ec0f5a148389d6245c

15 months agoSmall performance optimizations. reuse-subqueries
drh [Fri, 5 Jul 2024 01:05:34 +0000 (01:05 +0000)] 
Small performance optimizations.

FossilOrigin-Name: 99fd34b58a9b09af20f1f1a3c37137ae55159310c8af97806550eeee6adc4fc5

15 months agoAdd test cases to in7.test.
dan [Thu, 4 Jul 2024 18:56:26 +0000 (18:56 +0000)] 
Add test cases to in7.test.

FossilOrigin-Name: 07817efc10a6ab59dcb18ad218a3bb5a5d49a724c51296d5c8d7e386b0e0c789

15 months agoDisable the reuse of IN-clause subqueries if the subquery is an explicit
drh [Thu, 4 Jul 2024 18:26:41 +0000 (18:26 +0000)] 
Disable the reuse of IN-clause subqueries if the subquery is an explicit
"SELECT ALL".  The ALL keyword is almost never used in actual practice (most
developers don't even know it can be used) so this should not interfere with
the optimization, but it does give us a convenient way to turn it off for
testing purposes.

FossilOrigin-Name: a81299be2ce203dcc28e7d0ba24791cbfba80e1ee3e1564469a226cac8adb17d

15 months agoUpdate EXPLAIN output to include P4_SUBRTNSIG.
dan [Thu, 4 Jul 2024 17:49:34 +0000 (17:49 +0000)] 
Update EXPLAIN output to include P4_SUBRTNSIG.

FossilOrigin-Name: 61e56923c80d72d6467ec703b4946b251abf591649fa9e8e579667d7cbd25682

15 months agoBe more aggressive about reusing subqueries that appear on the RHS of IN
drh [Thu, 4 Jul 2024 16:57:11 +0000 (16:57 +0000)] 
Be more aggressive about reusing subqueries that appear on the RHS of IN
operators that have been replicated due to the predicate push-down optimization.

FossilOrigin-Name: 2accf32b6e45a396503c29eecc14a103bcc7b4c313cde921b26b489704060177

15 months agoAdd comment using the name "predicate push-down optimization" to what we have
drh [Thu, 4 Jul 2024 11:15:32 +0000 (11:15 +0000)] 
Add comment using the name "predicate push-down optimization" to what we have
also called "WHERE-clause push down".  No changes to code.

FossilOrigin-Name: be77fe701c7b7d3407800e1ed6a4c8be14035831790419cc99362bff41c65b60

15 months agoFor shell completion, use pragma_table_xinfo instead of pragma_table_info, so that...
stephan [Thu, 4 Jul 2024 09:45:23 +0000 (09:45 +0000)] 
For shell completion, use pragma_table_xinfo instead of pragma_table_info, so that generated columns are handled, as reported in [forum:f0735e05d8d7e857|forum post f0735e05d8d7e857].

FossilOrigin-Name: a204ffc06b468c2edf8f11ccf3de639edd4f8282e69a44ceeb68a4d3a43e77ea

15 months agoWhen constructing an ephermeral table to use as the right-hand side of
drh [Wed, 3 Jul 2024 20:19:33 +0000 (20:19 +0000)] 
When constructing an ephermeral table to use as the right-hand side of
an IN operator, also construct a Bloom filter to speed membership testing.

FossilOrigin-Name: baa83b460c677c210c7fa3f20314d7e05f305aed8a69026bc5fa106a3de4ea38

15 months agoShow the creation of IN-operator Bloom filters in the EXPLAIN QUERY PLAN output. in-bloom
drh [Wed, 3 Jul 2024 20:10:42 +0000 (20:10 +0000)] 
Show the creation of IN-operator Bloom filters in the EXPLAIN QUERY PLAN output.

FossilOrigin-Name: c10a1b99d47a4c93bdb16e646f6a21add570d6dbb34fd91a32f8abacdb28712b

15 months agoAdd a new sqlite3FaultSim() call to OP_NotFound to use for testing purposes.
drh [Wed, 3 Jul 2024 18:56:56 +0000 (18:56 +0000)] 
Add a new sqlite3FaultSim() call to OP_NotFound to use for testing purposes.

FossilOrigin-Name: 84fd275bfd8afada50d3a5ac491d2b866671f8f0d2496bd240cf4bfdd74e7399

15 months agoUse a Bloom filter to improve performance of IN operators when the RHS of
drh [Wed, 3 Jul 2024 17:51:48 +0000 (17:51 +0000)] 
Use a Bloom filter to improve performance of IN operators when the RHS of
the IN operator is a subquery.

FossilOrigin-Name: 1933496539c19cbf429a39d6b0b1c6b1b2af50733a3c4aea4920990ced652f6a

15 months agoAdd assert() statements to FTS5 to hush-up warnings from scan-build.
drh [Tue, 2 Jul 2024 13:54:46 +0000 (13:54 +0000)] 
Add assert() statements to FTS5 to hush-up warnings from scan-build.

FossilOrigin-Name: 77a76654e64c05f2c67be120f579fc60924ff51a9d0fa2cf9eb158f40171b5f5

15 months agoReword the deliberate_fall_through macro along the lines suggested by
drh [Tue, 2 Jul 2024 12:16:29 +0000 (12:16 +0000)] 
Reword the deliberate_fall_through macro along the lines suggested by
[forum:/forumpost/7ec11023dd|forum post 7ec11023dd] so that it works better
with LLVM, while preserving compatibility with MSVC and older GCCs.

FossilOrigin-Name: fc248a4a0a232a95a79e24e57faedb5d824c3bf0aa62054b72339257dc9c18b3

15 months agoIn the CLI, if the XDG_CONFIG_HOME environment variable is not set, then also
drh [Tue, 2 Jul 2024 11:30:10 +0000 (11:30 +0000)] 
In the CLI, if the XDG_CONFIG_HOME environment variable is not set, then also
search in ~/.config/sqlite3/sqliterc for the initialization file.
See [forum:/forumpost/5cc6d059e9e092ed|forum thread 5cc6d059e9e092ed].

FossilOrigin-Name: 33841c9c3cb57beeb3884d4b0715d26199926b7d3e4d3dd1ab6f5603b5a62591

15 months agoFix a typo in a comment in a test case. No changes to code.
drh [Sat, 29 Jun 2024 15:57:55 +0000 (15:57 +0000)] 
Fix a typo in a comment in a test case.  No changes to code.

FossilOrigin-Name: f501166de4f967b7e2e895f180308630e3c88b12bc51823a0a124ee5089eae4f

15 months agoAdd a NEVER() around a branch in sqlite3ExprAffinity() that is designed to
drh [Sat, 29 Jun 2024 12:22:32 +0000 (12:22 +0000)] 
Add a NEVER() around a branch in sqlite3ExprAffinity() that is designed to
prevent an infinite loop, but which can now never be reached due to recent
changes.

FossilOrigin-Name: da0b794852f8ccba5bd30395892044ec71b148075608406867785395e1f50b31

15 months agoUpdate fts5 comment/docs to include the order matches are visited in by the xPhraseFi...
dan [Fri, 28 Jun 2024 18:21:30 +0000 (18:21 +0000)] 
Update fts5 comment/docs to include the order matches are visited in by the xPhraseFirst/xPhraseNext API.

FossilOrigin-Name: e41930ef5b883c0f2a6b7eb9606021d14a3df145bc94cb0d508af22b4db7f168

15 months agoAdditional steps to make sure calls to sqlite3ExprToRegister() are sane.
drh [Fri, 28 Jun 2024 18:07:10 +0000 (18:07 +0000)] 
Additional steps to make sure calls to sqlite3ExprToRegister() are sane.

FossilOrigin-Name: 1c42d7176b228791f99bc9971d92a9ab67b1e2956ca4f8d934bd1a3e596d6c80

15 months agoDo not convert an expression node that is already TK_REGISTER into a
drh [Fri, 28 Jun 2024 17:14:00 +0000 (17:14 +0000)] 
Do not convert an expression node that is already TK_REGISTER into a
new TK_REGISTER.  This is a follow-up to [663f5dd32d9db832] that fixes a
bug discovered by dbsqlfuzz.

FossilOrigin-Name: fcb669cfaa8a59ca710504d5aaa1936f65a6da8ff13473ad84458f97a6fd1f49

15 months agoFix an incorrect tcl comment that appeared in many fts5 test files.
dan [Mon, 24 Jun 2024 18:06:15 +0000 (18:06 +0000)] 
Fix an incorrect tcl comment that appeared in many fts5 test files.

FossilOrigin-Name: d07085e2035b52a7edd27980523225e59c5bf851fb4a6de975f03e653b937c9c

15 months agoFix some problems with calling fts5 api functions from within non-full-text queries.
dan [Mon, 24 Jun 2024 16:08:01 +0000 (16:08 +0000)] 
Fix some problems with calling fts5 api functions from within non-full-text queries.

FossilOrigin-Name: 56d265f956fe6433b625c6d732e55f387af3f643e705316f5a6f709d63731669

15 months agoEnhance the output of ".scanstats vm" to include the absolute number of ticks for...
dan [Mon, 24 Jun 2024 14:53:14 +0000 (14:53 +0000)] 
Enhance the output of ".scanstats vm" to include the absolute number of ticks for each VM instruction, instead of just the percentage of the total.

FossilOrigin-Name: 1535828335d2b0eccebae952ed2bc70cc0cd893bd4b079d26b80deff9b5f752b

15 months agoRevert Lemon so that it only shows -D options that are actually used. Though
drh [Wed, 19 Jun 2024 18:54:04 +0000 (18:54 +0000)] 
Revert Lemon so that it only shows -D options that are actually used.  Though
the change to display the options in sorted order is retained.

FossilOrigin-Name: e54eb217c9508c19aee085b111a1323c9009f014ba4db6019918e27002c4ca8c

15 months agoIn lemon, show all the -D options in the generated header, even if none of them
drh [Wed, 19 Jun 2024 18:46:44 +0000 (18:46 +0000)] 
In lemon, show all the -D options in the generated header, even if none of them
are used.

FossilOrigin-Name: 2aa009c38bb207ac59b9bbd6f8e0d7315697b3fd6a01f9431f29a3c7ccad53e7

15 months agoEnhance lemon.c so that when it shows the compile-time options in the header
drh [Wed, 19 Jun 2024 16:38:17 +0000 (16:38 +0000)] 
Enhance lemon.c so that when it shows the compile-time options in the header
comment of the generated output file, it shows all options, even those not
used, and it shows them in sorted order.

FossilOrigin-Name: eed76e6698eabe47c6bf9696599ce1c2f7aa428cf60f39d0566fbd0d1f6c4c62

15 months agoRemove some extraneous flags from the fiddle-debug build. Internal doc tweaks in...
stephan [Wed, 19 Jun 2024 11:08:58 +0000 (11:08 +0000)] 
Remove some extraneous flags from the fiddle-debug build. Internal doc tweaks in the main wasm makefile.

FossilOrigin-Name: afae2c9e6fba0820c9be8d06a2e301a74167e4457bada45fe57b5fd9287d2e8b

15 months agoMinor cleanups in the new fiddle build code.
stephan [Tue, 18 Jun 2024 22:03:28 +0000 (22:03 +0000)] 
Minor cleanups in the new fiddle build code.

FossilOrigin-Name: d356aebdd450bedc1ecbbdd266effe53c7badbd74ed7e6db8d0c31318d99a35f

15 months agoRework the fiddle build to build separate debug and non-debug bundles, with the latte...
stephan [Tue, 18 Jun 2024 21:50:30 +0000 (21:50 +0000)] 
Rework the fiddle build to build separate debug and non-debug bundles, with the latter in ./fiddle-debug.

FossilOrigin-Name: a9f1758f1cbe7b7d0c87dfb060f52d03c6ea0e066c079891a8ff354073997f9e

15 months agoRemove an extraneous CSS file and import its CSS into the one HTML file which uses it.
stephan [Tue, 18 Jun 2024 20:47:05 +0000 (20:47 +0000)] 
Remove an extraneous CSS file and import its CSS into the one HTML file which uses it.

FossilOrigin-Name: 66085ca42388e8de741712150541a3e0afb06b3e23e738aa9ff687e9fc494c50

15 months agoAdd fiddle-debug make target to ext/wasm. It builds the same target files as a non...
stephan [Tue, 18 Jun 2024 20:40:11 +0000 (20:40 +0000)] 
Add fiddle-debug make target to ext/wasm. It builds the same target files as a non-debug build, as opposed to a new copy, but adds various debug-related flags.

FossilOrigin-Name: 993143c5c39fb6ee15b0661cec8fed436ff04543b528a3796534f5e3a44799f5

15 months agoAdd instructions for how to do debugging builds of the CLI on Windows.
drh [Tue, 18 Jun 2024 19:36:04 +0000 (19:36 +0000)] 
Add instructions for how to do debugging builds of the CLI on Windows.

FossilOrigin-Name: abe81c18614b41c78cf3edeaaf8d85d5d2dbdcf331b580f1c98f80d3726d8189

15 months agoUpdate sqlite3_analyzer to report on the number of WITHOUT ROWID tables and
drh [Tue, 18 Jun 2024 12:19:13 +0000 (12:19 +0000)] 
Update sqlite3_analyzer to report on the number of WITHOUT ROWID tables and
to provide separate aggregate statistics for WITHOUT and WITH ROWID tables.

FossilOrigin-Name: 4152894433c3a292d983b1c196664a0c46e406eccd7e644a64fa443fdb204825

15 months agoInternal doc typo fixes, as reported in the forum. No code changes.
stephan [Tue, 18 Jun 2024 09:58:39 +0000 (09:58 +0000)] 
Internal doc typo fixes, as reported in the forum. No code changes.

FossilOrigin-Name: ea16b286b4344c1833ca3d17b6d315fb4ddcb99bcc232ff6444debeb634881f2

15 months agoRemove some dead JS code.
stephan [Sun, 16 Jun 2024 17:06:50 +0000 (17:06 +0000)] 
Remove some dead JS code.

FossilOrigin-Name: 754e6e059b740435475c1869feeaca39585b262d5c27210e0fbddbbcc202c4d5

15 months agoDo not omit the ORDER BY clause from a recursive CTE just because the
drh [Fri, 14 Jun 2024 23:13:54 +0000 (23:13 +0000)] 
Do not omit the ORDER BY clause from a recursive CTE just because the
query that contains the CTE also contains an ORDER BY clause.  Plus
other changes imported from the recursive-cte-orderby-fix branch.

FossilOrigin-Name: 13242289c5d412b706f50fc7e1553032ea3a52d41a3e34e155432adaf0551481

15 months agoRemove some dead JS code. Improve the exception-to-C-result-code conversion to accoun...
stephan [Wed, 12 Jun 2024 22:15:25 +0000 (22:15 +0000)] 
Remove some dead JS code. Improve the exception-to-C-result-code conversion to account for the case of a file disappearing while the OPFS VFS is waiting to acquire a lock on it.

FossilOrigin-Name: 5bd9fd5f61e7cd1ed3b44c5cabc759c154c98eb40ad10d29e61f142aaa062ddf

15 months agoRemove some JS docs which no longer apply. No code changes.
stephan [Wed, 12 Jun 2024 21:01:44 +0000 (21:01 +0000)] 
Remove some JS docs which no longer apply. No code changes.

FossilOrigin-Name: f253cab3359270045a3ae9f5e9eadc1cfc8844181db127165bfdf49d5f99efb1

15 months agoFix a problem with rolling back hot journals using the unix-dotfile VFS.
dan [Wed, 12 Jun 2024 15:50:35 +0000 (15:50 +0000)] 
Fix a problem with rolling back hot journals using the unix-dotfile VFS.

FossilOrigin-Name: a44703135e8dd3cc67e548e1aa3c42e71df127fb7b593ccfc06025ec42a501fd

15 months agoOmit tests that depend on sqlite3_release_memory() in lock5.test when running the... unix-dotfile-fix
dan [Wed, 12 Jun 2024 15:29:37 +0000 (15:29 +0000)] 
Omit tests that depend on sqlite3_release_memory() in lock5.test when running the memsubsys1 or memsubsys2 permutations.

FossilOrigin-Name: 9d63033bf46ddf0f4d9d4ef06d56357fe6165f2370cd19cf81c2f7f61ce224fc

15 months agoOPFS VFS: change the xCheckReservedLock() impl to always return false, as discussed...
stephan [Wed, 12 Jun 2024 12:36:02 +0000 (12:36 +0000)] 
OPFS VFS: change the xCheckReservedLock() impl to always return false, as discussed in [forum:a2f573b00cda1372|forum thread a2f573b00cda1372]. This does not impact any current tests, and may have no direct impact at all because of how that VFS handles locking, but is hypothetically a more correct solution than the previous one.

FossilOrigin-Name: c298b8ba2dcd01fa28b79a78bb4986fa0282755a0a36b7f38b93096ac31f521e

15 months agoDoc updates in JS code. No functional changes.
stephan [Wed, 12 Jun 2024 12:17:03 +0000 (12:17 +0000)] 
Doc updates in JS code. No functional changes.

FossilOrigin-Name: 587ed3a5d283898ad0e67ccee86a0a4ccc432fa292c0a3534e9e6ec70a7b7780

15 months agoDo not attempt to run hot journal rollback tests in lock5.test with the "inmemory_jou...
dan [Wed, 12 Jun 2024 11:41:18 +0000 (11:41 +0000)] 
Do not attempt to run hot journal rollback tests in lock5.test with the "inmemory_journal" permutation, which cannot generate hot journals.

FossilOrigin-Name: 1e6fa95b88cace9e6cac476863d57cfd8de483f83c922ff964b77cbaee6e9ae4

15 months agoSlight API doc tweak for xCheckReservedLock(), based on forum feedback. No code changes.
stephan [Wed, 12 Jun 2024 11:39:29 +0000 (11:39 +0000)] 
Slight API doc tweak for xCheckReservedLock(), based on forum feedback. No code changes.

FossilOrigin-Name: 2af7a96f6868a4529d689702926b350a4c00082f14da0ded5a8eaea295682d17

15 months agoHandle the case where unix-dotfile is used with URI parameter nolock=1.
dan [Tue, 11 Jun 2024 20:28:56 +0000 (20:28 +0000)] 
Handle the case where unix-dotfile is used with URI parameter nolock=1.

FossilOrigin-Name: 3925a5b904e159d54455cfc73fe837a9c6ea3a6d60da63afde3242b4d6f67c90

15 months agoFix a problem with rolling back hot journals using the unix-dotfile VFS.
dan [Tue, 11 Jun 2024 20:03:32 +0000 (20:03 +0000)] 
Fix a problem with rolling back hot journals using the unix-dotfile VFS.

FossilOrigin-Name: 4ae3300b79e03381fd7f1033bb7978bb6367369790f17c3bdacac51e205edaf9

16 months agoRemove some dead JS code and update some JS docs.
stephan [Tue, 11 Jun 2024 17:04:43 +0000 (17:04 +0000)] 
Remove some dead JS code and update some JS docs.

FossilOrigin-Name: 6935ac71bad3d36cc519f0325ae4447a674f257309d020cdc0741160fcce0580

16 months agoWhen compiling shell.c in SQLITE_SHELL_FIDDLE mode, ensure that the shell_main_exit...
stephan [Tue, 11 Jun 2024 17:04:02 +0000 (17:04 +0000)] 
When compiling shell.c in SQLITE_SHELL_FIDDLE mode, ensure that the shell_main_exit goto label is reachable.

FossilOrigin-Name: 06e6f64533563ab9c059b773e5f0d78085df716f2624e547b7259f6789c3ffe0

16 months agoChange constant expressions to pre-computed constants, because apparently
drh [Tue, 11 Jun 2024 14:36:56 +0000 (14:36 +0000)] 
Change constant expressions to pre-computed constants, because apparently
MSVC on ARM requires that.
[forum:/forumpost/4feb1685cced0a8e|Forum thread 4feb1685cced0a8e].

FossilOrigin-Name: 6c103aee6f146869a3e0c48694592f2e4c6b57ecdb4450f46e762c38b4e686f1

16 months agoImproved header comment on the sqlite3FpDecode() implementation.
drh [Mon, 10 Jun 2024 12:43:03 +0000 (12:43 +0000)] 
Improved header comment on the sqlite3FpDecode() implementation.
For the fpdecode() SQL function (available in debug builds only) limit
the value of the third parameter (mxRound) to be positive.

FossilOrigin-Name: 56af06fa12104a1fe119d7087746011183af053834eac72d0fb69f60d98054c6

16 months agoDisable the omit-noop-join optimization when there are 64 or more terms in
drh [Sun, 9 Jun 2024 17:34:03 +0000 (17:34 +0000)] 
Disable the omit-noop-join optimization when there are 64 or more terms in
the ORDER BY clause.

FossilOrigin-Name: 40de3939792e17df25598b3e60d1cebcecde2b00832acd55604f14b21398a9a7

16 months agoAllow the query planner access to the argument of LIMIT even if that
drh [Thu, 6 Jun 2024 23:56:36 +0000 (23:56 +0000)] 
Allow the query planner access to the argument of LIMIT even if that
argument is a bound parameter.

FossilOrigin-Name: c4a9dda2809c6e0e3d928e11e5553ead82cd9df551bcd35b11a7d869ef80ab8e

16 months agoOmit bogus tests accidentally added by the privious commit. var-in-limit
drh [Thu, 6 Jun 2024 23:22:32 +0000 (23:22 +0000)] 
Omit bogus tests accidentally added by the privious commit.

FossilOrigin-Name: e94dfe9928750dd98145d4d9920b298f7b0868703b487f86e0db77a41d53ccf9

16 months agoBetter optimize queries that use parameters in the LIMIT clause.
drh [Thu, 6 Jun 2024 15:03:16 +0000 (15:03 +0000)] 
Better optimize queries that use parameters in the LIMIT clause.

FossilOrigin-Name: e58cb304d1e0ec6e30260a165aaccc2cf096ce6c999efb06683c4ef600ee12ef