]> git.ipfire.org Git - thirdparty/samba.git/log
thirdparty/samba.git
14 years agos3:modules:nfs4_acls: improve fix for bug #8330
Michael Adam [Thu, 28 Jul 2011 07:49:34 +0000 (09:49 +0200)] 
s3:modules:nfs4_acls: improve fix for bug #8330

simplify the check insmbacl4_find_equal_special()

Signed-off-by: Michael Adam <obnox@samba.org>
14 years agos3:modules fix Bug 8330 NFSv4 ACL merging logic is broken
Christian Ambach [Wed, 27 Jul 2011 12:46:00 +0000 (14:46 +0200)] 
s3:modules fix Bug 8330 NFSv4 ACL merging logic is broken

we should not merge ACEs with different flags (e.g. CI/OI/I/)
Otherwise ACLs get wrong entries and thus wrong semantics

Example:
ACL:BUILTIN\Users:ALLOWED/0x0/FULL
ACL:BUILTIN\Users:ALLOWED/I/READ
got merged to
ACL:BUILTIN\Users:ALLOWED/I/FULL

This is not the same and also leads to wrong displays
in the Windows ACL dialog

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Wed Jul 27 16:03:51 CEST 2011 on sn-devel-104

14 years agos3:lib/events: Fix a bug in run_poll_events().
Stefan Metzmacher [Mon, 8 Aug 2011 16:49:06 +0000 (18:49 +0200)] 
s3:lib/events: Fix a bug in run_poll_events().

Ignore fd events without EVENT_FD_READ or EVENT_FD_WRITE also in
run_events_poll(). They are ignore when building the array
for the syscall in event_add_to_poll_args(), so we need to
ignore them run_events_poll() too.

metze

Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Aug  9 10:11:54 CEST 2011 on sn-devel-104
(cherry picked from commit 020032e114c0e966acf24f24e707942219d60cf3)

Fix bug #8358 (smbd exits with NT_STATUS_INTERNAL_ERROR in run_poll_events()).

14 years agos3:smb2_server: make sure we grant credits on async read/write operations (bug #8357)
Stefan Metzmacher [Sat, 6 Aug 2011 08:19:21 +0000 (10:19 +0200)] 
s3:smb2_server: make sure we grant credits on async read/write operations (bug #8357)

Currently we skip, the "gone async" interim response on read and write,
this caused the aio code path to grant 0 credits to the client
in the read/write responses.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Aug  7 22:23:57 CEST 2011 on sn-devel-104
(cherry picked from commit 47bffb9b9243dc72d7305cd9ec3e63e176841bf5)

14 years agos3/swat: use strlcat instead of strncat to fix build on old Linux distros
Björn Jacke [Thu, 4 Aug 2011 14:25:08 +0000 (16:25 +0200)] 
s3/swat: use strlcat instead of strncat to fix build on old Linux distros

SLES 9's glibc for example had weird macros where the use of strncat resulted
in the use of strcat which we don't allow.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Thu Aug  4 17:50:24 CEST 2011 on sn-devel-104
(cherry picked from commit d3b4d75364210e2d2a4a1cd806f28b0021f22909)

Fix bug #8362 (build issue on old glibc systems).

14 years agos3:web/swat: use strtoll() instead of atoi/atol/atoll
Stefan Metzmacher [Fri, 5 Aug 2011 17:48:38 +0000 (19:48 +0200)] 
s3:web/swat: use strtoll() instead of atoi/atol/atoll

This is more portable, as we have a strtoll replacement
in lib/replace.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Aug  6 11:55:45 CEST 2011 on sn-devel-104
(cherry picked from commit a6be0820d09b3f3eabfbb5f4356add303aa8a494)

Fix bug #8347 (CVE-2011-2522 regression for HP-UX, AIX and OSF).

14 years agoWHATSNEW: Update release notes.
Karolin Seeger [Sun, 7 Aug 2011 19:22:46 +0000 (21:22 +0200)] 
WHATSNEW: Update release notes.

Karolin

14 years agos3: Fix smb2 handling error returns from aio
Volker Lendecke [Tue, 2 Aug 2011 19:16:26 +0000 (21:16 +0200)] 
s3: Fix smb2 handling error returns from aio

Found when reading with aio_fork beyond the end of file.

Metze, Jeremy, please check!

Without this we get

[2011/08/02 21:02:54.082661,  0] lib/util.c:778(smb_panic_s3)
  PANIC (pid 2302): smbd/smb2_read.c:593: Type mismatch: name[NULL] expected[struct smbd_smb2_read_state]
[2011/08/02 21:02:54.094316,  0] lib/util.c:882(log_stack_trace)
  BACKTRACE: 23 stack frames:
   #0 bin/smbd(log_stack_trace+0x2d) [0xb72873d8]
   #1 bin/smbd(smb_panic_s3+0x7c) [0xb7287529]
   #2 bin/smbd(smb_panic+0x2f) [0xb7277e1f]
   #3 /root/git/s3-work/source3/bin/libtalloc.so.2 [0xb6c6bc48]
   #4 /root/git/s3-work/source3/bin/libtalloc.so.2 [0xb6c6ec79]
   #5 /root/git/s3-work/source3/bin/libtalloc.so.2(_talloc_get_type_abort+0x34) [0xb6c6ecb3]
   #6 bin/smbd [0xb6fbc405]
   #7 bin/smbd(_tevent_req_notify_callback+0x4a) [0xb729a85a]
   #8 bin/smbd [0xb729a888]
   #9 bin/smbd(_tevent_req_done+0x19) [0xb729aa73]
   #10 bin/smbd [0xb6fae517]
   #11 bin/smbd [0xb6fad258]
   #12 bin/smbd(smbd_aio_complete_aio_ex+0xf5) [0xb6fad6e8]
   #13 /root/git/inst/modules/vfs/aio_fork.so [0xb66d4992]
   #14 bin/smbd(run_events_poll+0x400) [0xb7297df2]
   #15 bin/smbd(smbd_process+0xd75) [0xb6f9d3a7]
   #16 bin/smbd [0xb756f07b]
   #17 bin/smbd(run_events_poll+0x400) [0xb7297df2]
   #18 bin/smbd [0xb7298254]
   #19 bin/smbd(_tevent_loop_once+0x9e) [0xb72986ac]
   #20 bin/smbd(main+0x185c) [0xb7570e59]
   #21 /lib/i686/cmov/libc.so.6(__libc_start_main+0xe5) [0xb6b08455]
   #22 bin/smbd [0xb6f14e01]

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Aug  2 22:33:15 CEST 2011 on sn-devel-104
(cherry picked from commit 5068a0d14df8cc6f1b4517c64f4356abc6606b58)

Fix bug #8343 (SMB2 crash reading with aio_fork beyond the end of file).

14 years agoFix bug 7462 - Non-standard SA_RESETHAND is used in ...lib/tevent/tevent_signal.c
Jeremy Allison [Mon, 1 Aug 2011 18:49:10 +0000 (11:49 -0700)] 
Fix bug 7462 - Non-standard SA_RESETHAND is used in ...lib/tevent/tevent_signal.c

Make SA_RESETHAND conditional on its existance.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Aug  1 22:03:45 CEST 2011 on sn-devel-104
(cherry picked from commit 0c67efdd68b9808542c090b9fd9920e4e37d85d0)

14 years agoFix bug #8341 - libsmbclient segfault when feed the root of a mounted share via an uri
Alban Browaeys [Mon, 1 Aug 2011 23:40:22 +0000 (16:40 -0700)] 
Fix bug #8341 - libsmbclient segfault when feed the root of a mounted share via an uri

Fix null deref.
(cherry picked from commit cf0c36ab9a5129878b92a52d22aa814eaa737a4c)

14 years agos3: dbwrap_ctdb.c: Fix bug #8303 #ifdef CTDB_CONTROL_SCHEDULE_FOR_DELETION issue
Björn Baumbach [Tue, 12 Jul 2011 15:32:55 +0000 (17:32 +0200)] 
s3: dbwrap_ctdb.c: Fix bug #8303 #ifdef CTDB_CONTROL_SCHEDULE_FOR_DELETION issue

Check for HAVE_CTDB_CONTROL_SCHEDULE_FOR_DELETION_DECL instead of
CTDB_CONTROL_SCHEDULE_FOR_DELETION, which is an enum member and not a
define.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jul 12 18:56:30 CEST 2011 on sn-devel-104
(cherry picked from commit b807c58b655f1ffbf849f5de9eef66136bdb4a52)

14 years agoSecond part of bugfix for bug #8335 - file copy aborts with smb2_validate_message_id...
Jeremy Allison [Fri, 29 Jul 2011 18:17:03 +0000 (11:17 -0700)] 
Second part of bugfix for bug #8335 - file copy aborts with smb2_validate_message_id: bad message_id

Modify the credit granting algorithm to closer to what I believe
Windows does.

Split up max_credits into 1/16ths, and then scale
the requested credits by how many 16ths have been
currently granted. Less than 1/16th == grant all
requested (100%), scale down as more have been
granted. Never ask for less than 1 if the client
asked for at least 1.

14 years agoFirst part of bugfix for bug #8335 - file copy aborts with smb2_validate_message_id...
Jeremy Allison [Fri, 29 Jul 2011 18:16:51 +0000 (11:16 -0700)] 
First part of bugfix for bug #8335 - file copy aborts with smb2_validate_message_id: bad message_id

Set default max credits to 8192 now this has been documented in the
SMB2 spec.

14 years agos3:loadparm: fix the reload of the configuration: also reload activated registry...
Michael Adam [Fri, 22 Jul 2011 08:11:52 +0000 (10:11 +0200)] 
s3:loadparm: fix the reload of the configuration: also reload activated registry shares

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jul 22 16:53:49 CEST 2011 on sn-devel-104
(cherry picked from commit efbe1602bd014eada4811f336bdccbf4692d3807)

The last 2 patches address bug 8327 (config reload fails to reload shares from
registry).

14 years agos3:loadparm: add reload_registry_shares() - reload only those shares already loaded...
Michael Adam [Fri, 22 Jul 2011 08:10:43 +0000 (10:10 +0200)] 
s3:loadparm: add reload_registry_shares() - reload only those shares already loaded (cherry picked from commit ec113a58a4dc4e4f3ea03f7818eb312325f69482)

14 years agonbt: fix WinXP S3 domain join: alignment of nbt_netlogon_response_from_pdc
Andrew Bartlett [Wed, 27 Jul 2011 02:04:26 +0000 (12:04 +1000)] 
nbt: fix WinXP S3 domain join: alignment of nbt_netlogon_response_from_pdc

This fixes WinXP joining a Samba3 domain, which was broken on hosts
with an even number of characters in the host name.  The alignment
requested in the structure was ignored because of the overall
NDR_NOALIGN set on the packet.

Andrew Bartlett

Fix bug #8326 (WinXP cannot join a Samba3 domain with a 'even' hostname).

14 years agoFix bug #8324 - smbclient cannot list directories from a big-endian machine.
Jeremy Allison [Tue, 26 Jul 2011 22:16:29 +0000 (15:16 -0700)] 
Fix bug #8324 - smbclient cannot list directories from a big-endian machine.

Two uses of the setup array are not being correctly byte-swapped to little
endian.

14 years agos3:torture: remove a file accidentially committed with 3b2fe4728d6d916508b677e696ecad...
Michael Adam [Tue, 17 May 2011 12:30:13 +0000 (14:30 +0200)] 
s3:torture: remove a file accidentially committed with 3b2fe4728d6d916508b677e696ecad88f8b7b9fd

Fix bug #8329 (a code file was accidentially commited).

14 years agos3:idmap_tdb2: remove the undocumented option of the silly name "tdb:idmap2.tdb"
Michael Adam [Fri, 24 Jun 2011 08:15:02 +0000 (10:15 +0200)] 
s3:idmap_tdb2: remove the undocumented option of the silly name "tdb:idmap2.tdb"

In ancient times, when ctdb had not support for persistent databases and
tdb2 was introduced as a two-layer solution and it was more important than
today to be able to change the location of the permanent database file
because it had to reside on shared storage.

But these were times when idmap_tdb2 was not even officially released.
Nowadays, with ctdb handling the persistent idmap2.tdb database, the path
is stripped anyways, so this undocumented option has become unnecessary
and is hence removed.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Jul 27 05:37:57 CEST 2011 on sn-devel-104
(cherry picked from commit 3276060da4e7d495bd5cf5cbf7237e64d948ee77)

The last 10 patches address
bug #8328 (final cleanup of idmap_tdb2 code and docs needed for release).

14 years agos3:idmap_tdb2: remove a legacy comment (cherry picked from commit 67cd2f9d867fad1f7df...
Michael Adam [Thu, 9 Jun 2011 11:36:54 +0000 (13:36 +0200)] 
s3:idmap_tdb2: remove a legacy comment (cherry picked from commit 67cd2f9d867fad1f7df2d6a6a5cdb723336ac495)

14 years agos3:idmap_tdb2: remove legacy comment (cherry picked from commit 4b5ada3d27198b49771ac...
Michael Adam [Thu, 9 Jun 2011 11:35:21 +0000 (13:35 +0200)] 
s3:idmap_tdb2: remove legacy comment (cherry picked from commit 4b5ada3d27198b49771acb70ae979087235be783)

14 years agos3:idmap_tdb2: remove superfluous initialization with bogus comment (cherry picked...
Michael Adam [Thu, 9 Jun 2011 11:34:04 +0000 (13:34 +0200)] 
s3:idmap_tdb2: remove superfluous initialization with bogus comment (cherry picked from commit 551185573899b6e608863f833633d40ae04458d8)

14 years agos3:idmap_tdb2: fix a legacy comment that does not apply any more (cherry picked from...
Michael Adam [Thu, 9 Jun 2011 11:07:54 +0000 (13:07 +0200)] 
s3:idmap_tdb2: fix a legacy comment that does not apply any more (cherry picked from commit 7d3dc2164b3929c642127659593e69fc865a6184)

14 years agos3:doc: add an example with idmap script to the idmap_tdb2 manpage (cherry picked...
Michael Adam [Fri, 24 Jun 2011 09:38:05 +0000 (11:38 +0200)] 
s3:doc: add an example with idmap script to the idmap_tdb2 manpage (cherry picked from commit 86973eee43605a3680fb51470a81ea9ca7f1b515)

14 years agos3:docs: remove legacy text from the example in the idmap_tdb2 manpage (cherry picked...
Michael Adam [Fri, 24 Jun 2011 09:36:33 +0000 (11:36 +0200)] 
s3:docs: remove legacy text from the example in the idmap_tdb2 manpage (cherry picked from commit 2f253c2791ccb2421f26f563e3983ee950da1d05)

14 years agos3:doc: clarify the idmap script section in the idmap_tdb2 manpage (cherry picked...
Michael Adam [Fri, 24 Jun 2011 09:35:51 +0000 (11:35 +0200)] 
s3:doc: clarify the idmap script section in the idmap_tdb2 manpage (cherry picked from commit 4daab85ae60f2821a1d9d98f1edff6a318e8e3c1)

14 years agos3:docs:idmap_tdb2: update the documentation of idmap script
Michael Adam [Fri, 24 Jun 2011 08:59:04 +0000 (10:59 +0200)] 
s3:docs:idmap_tdb2: update the documentation of idmap script

to reflect the new variant "idmap config * : script" of configuring the idmap script
(cherry picked from commit 2aa19b4aeb9de43a0e2b94ad1202f2068b29c710)

14 years agos3:idmap_tdb2: deprecate the idmap:script parameter and use "idmap config * : script...
Michael Adam [Tue, 7 Jun 2011 16:00:36 +0000 (18:00 +0200)] 
s3:idmap_tdb2: deprecate the idmap:script parameter and use "idmap config * : script" instead

With this patch, "idmap config * : script" will override "idmap : script".
If "idmap : script" is present, a deprecation warning will be printed in any
case. If "idmap config * : script" is not set, then the value of "idmap :script"
will be used for backwards compatibility.
(cherry picked from commit b6c82f18f17cdded771d285930566c1d104686aa)

14 years agoWHATSNEW: Start release notes for 3.6.0.
Karolin Seeger [Tue, 26 Jul 2011 20:40:15 +0000 (22:40 +0200)] 
WHATSNEW: Start release notes for 3.6.0.

Karolin

14 years agoVERSION: Bump version up to 3.6.0.
Karolin Seeger [Tue, 26 Jul 2011 20:38:09 +0000 (22:38 +0200)] 
VERSION: Bump version up to 3.6.0.

Karolin

14 years agoWHATSNEW: Update changes since rc2.
Karolin Seeger [Tue, 26 Jul 2011 20:06:04 +0000 (22:06 +0200)] 
WHATSNEW: Update changes since rc2.

Karolin

14 years agos3:utils/net_afs fix compiler warnings
Christian Ambach [Fri, 15 Jul 2011 13:44:36 +0000 (15:44 +0200)] 
s3:utils/net_afs fix compiler warnings

this also fixes the usage displays of net afs

14 years agos3:lib/afs fix the build with --with-vfs-afsacl
Christian Ambach [Fri, 15 Jul 2011 13:54:25 +0000 (15:54 +0200)] 
s3:lib/afs fix the build with --with-vfs-afsacl

This fixes the second piece of Bug #8263

14 years agos3:lib/afs fix the build with --with-fake-kaserver
Christian Ambach [Fri, 15 Jul 2011 13:27:07 +0000 (15:27 +0200)] 
s3:lib/afs fix the build with --with-fake-kaserver

This fixes one piece of Bug #8263

14 years agoFix bug 8314] - smbd crash with unknown user.
Jeremy Allison [Fri, 22 Jul 2011 23:42:51 +0000 (16:42 -0700)] 
Fix bug 8314] - smbd crash with unknown user.

All other auth modules code with being called with
auth_method->private_data being NULL, make the auth_server
module cope with this too.

14 years agos3 swat: Create random nonce in CGI mode
Kai Blin [Tue, 12 Jul 2011 06:08:24 +0000 (08:08 +0200)] 
s3 swat: Create random nonce in CGI mode

In CGI mode, we don't get access to the user's password, which would
reduce the hash used so far to parameters an attacker can easily guess.
To work around this, read the nonce from secrets.tdb or generate one if
it's not there.
Also populate the C_user field so we can use that for token creation.

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3 swat: Add time component to XSRF token
Kai Blin [Sat, 9 Jul 2011 07:52:07 +0000 (09:52 +0200)] 
s3 swat: Add time component to XSRF token

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3 swat: Add XSRF protection to printer page
Kai Blin [Fri, 8 Jul 2011 13:06:13 +0000 (15:06 +0200)] 
s3 swat: Add XSRF protection to printer page

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3 swat: Add XSRF protection to password page
Kai Blin [Fri, 8 Jul 2011 13:05:38 +0000 (15:05 +0200)] 
s3 swat: Add XSRF protection to password page

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3 swat: Add XSRF protection to shares page
Kai Blin [Fri, 8 Jul 2011 13:04:48 +0000 (15:04 +0200)] 
s3 swat: Add XSRF protection to shares page

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3 swat: Add XSRF protection to globals page
Kai Blin [Fri, 8 Jul 2011 13:04:12 +0000 (15:04 +0200)] 
s3 swat: Add XSRF protection to globals page

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3 swat: Add XSRF protection to wizard page
Kai Blin [Fri, 8 Jul 2011 13:03:44 +0000 (15:03 +0200)] 
s3 swat: Add XSRF protection to wizard page

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3 swat: Add XSRF protection to wizard_params page
Kai Blin [Fri, 8 Jul 2011 13:03:15 +0000 (15:03 +0200)] 
s3 swat: Add XSRF protection to wizard_params page

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3 swat: Add XSRF protection to viewconfig page
Kai Blin [Fri, 8 Jul 2011 13:02:53 +0000 (15:02 +0200)] 
s3 swat: Add XSRF protection to viewconfig page

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3 swat: Add XSRF protection to status page
Kai Blin [Fri, 8 Jul 2011 10:58:53 +0000 (12:58 +0200)] 
s3 swat: Add XSRF protection to status page

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3 swat: Add support for anti-XSRF token
Kai Blin [Fri, 8 Jul 2011 10:57:43 +0000 (12:57 +0200)] 
s3 swat: Add support for anti-XSRF token

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3 swat: Allow getting the user's HTTP auth password
Kai Blin [Fri, 8 Jul 2011 10:56:21 +0000 (12:56 +0200)] 
s3 swat: Allow getting the user's HTTP auth password

Signed-off-by: Kai Blin <kai@samba.org>
14 years agos3-swat: Fix typo.
Karolin Seeger [Sun, 24 Jul 2011 19:09:38 +0000 (21:09 +0200)] 
s3-swat: Fix typo.

Thanks to Simo for reporting!

Karolin
(cherry picked from commit 9f73c1990a19daa899fa5345530a867e69a5be94)
(cherry picked from commit bcb052c29212954a3ed10c9f095c51e4e0a96af5)

14 years agos3 swat: Fix possible XSS attack (bug #8289)
Kai Blin [Thu, 7 Jul 2011 08:03:33 +0000 (10:03 +0200)] 
s3 swat: Fix possible XSS attack (bug #8289)

Nobuhiro Tsuji of NTT DATA SECURITY CORPORATION reported a possible XSS attack
against SWAT, the Samba Web Administration Tool. The attack uses reflection to
insert arbitrary content into the "change password" page.

This patch fixes the reflection issue by not printing user-specified content on
the website anymore.

Signed-off-by: Kai Blin <kai@samba.org>
14 years agorelease-scripts/create-tarball: always create a tag in form of samba-${version}
Stefan Metzmacher [Tue, 28 Jun 2011 10:52:37 +0000 (12:52 +0200)] 
release-scripts/create-tarball: always create a tag in form of samba-${version}

metze
(cherry picked from commit 84d9cdb5112e55ae8a1e525ca2b8cef2ae606f22)

14 years agoSecond part of fix for bug 8310 - toupper_ascii() is broken on big-endian systems.
Jeremy Allison [Tue, 19 Jul 2011 20:08:31 +0000 (13:08 -0700)] 
Second part of fix for bug 8310 - toupper_ascii() is broken on big-endian systems.

Re-add:
    smb_ucs2_t toupper_w(smb_ucs2_t v);
    bool isupper_w(smb_ucs2_t v);
    smb_ucs2_t tolower_w(smb_ucs2_t v);
    bool islower_w(smb_ucs2_t v);

and ensure they are called whenever we are operating on smb_ucs2_t
variables. I'd like to make the definition of smb_ucs2_t incompatible
with int and codepoint_t so they can't be mixed, but that's a patch
for another time.

14 years agoFirst part of fix for bug 8310 - toupper_ascii() is broken on big-endian systems
Jeremy Allison [Tue, 19 Jul 2011 19:21:23 +0000 (12:21 -0700)] 
First part of fix for bug 8310 - toupper_ascii() is broken on big-endian systems

Remove
int toupper_ascii(int c);
int tolower_ascii(int c);
int isupper_ascii(int c);
int islower_ascii(int c);

and replace with their _m equivalents, as they are identical.

14 years agoFix bug #8307 - brl_close_fnum does not call SMB_VFS_BRL_UNLOCK_WINDOWS on all locks
Jeremy Allison [Sat, 16 Jul 2011 04:36:13 +0000 (21:36 -0700)] 
Fix bug #8307 - brl_close_fnum does not call SMB_VFS_BRL_UNLOCK_WINDOWS on all locks

Reported by herb@samba.org. Remove the (premature) optimization
on file close.

14 years agoWHATSNEW: Update changes since rc2.
Karolin Seeger [Wed, 13 Jul 2011 19:52:32 +0000 (21:52 +0200)] 
WHATSNEW: Update changes since rc2.

Karolin

14 years agos3:smb2_create: use smbd_calculate_access_mask() instead of smbd_check_open_rights()
Stefan Metzmacher [Sun, 10 Jul 2011 11:09:06 +0000 (13:09 +0200)] 
s3:smb2_create: use smbd_calculate_access_mask() instead of smbd_check_open_rights()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jul 11 22:45:01 CEST 2011 on sn-devel-104
(cherry picked from commit f5d320ac0fb74d4ad95a03969366096e9b074379)

The last 10 patches address bug #8102 (domuser can change ACL from his files
over the network).

14 years agos3:smb2_tcon: return the correct maximal_access on the share
Stefan Metzmacher [Sun, 10 Jul 2011 11:02:11 +0000 (13:02 +0200)] 
s3:smb2_tcon: return the correct maximal_access on the share

metze
(cherry picked from commit a1046389ffcc476456ac76cb701a4325d1c42ef9)

14 years agos3:smbd: return the real share access mask in the SMBtconX response
Stefan Metzmacher [Mon, 11 Jul 2011 14:12:57 +0000 (16:12 +0200)] 
s3:smbd: return the real share access mask in the SMBtconX response

metze
(cherry picked from commit 58eed1b295afeff6acfb8c1f10b0bb02280fd491)

14 years agos3:smbd: use smbd_calculate_access_mask() also for fake_files
Stefan Metzmacher [Sun, 10 Jul 2011 11:59:40 +0000 (13:59 +0200)] 
s3:smbd: use smbd_calculate_access_mask() also for fake_files

metze
(cherry picked from commit 581d8fa36b73abab030168dc35fb631ccd42a388)

14 years agos3:smbd: check the share level access mask in smbd_calculate_access_mask()
Stefan Metzmacher [Sun, 10 Jul 2011 11:03:51 +0000 (13:03 +0200)] 
s3:smbd: check the share level access mask in smbd_calculate_access_mask()

I think we should reject invalid access early,
before we might create new files.

Also smbd_check_open_rights() is only called if the file existed.

metze
(cherry picked from commit 896f105ed40dc04f83bcbfac367b309c8d957f86)

14 years agos3:smbd: make smbd_calculate_access_mask() non-static
Stefan Metzmacher [Sun, 10 Jul 2011 11:00:25 +0000 (13:00 +0200)] 
s3:smbd: make smbd_calculate_access_mask() non-static

metze
(cherry picked from commit ce66d4e4a885add09edfa8e6d5eab0f3b5d63081)

14 years agos3:smbd/msdfs: let create_conn_struct() check the share security descriptor
Stefan Metzmacher [Tue, 12 Jul 2011 15:31:13 +0000 (17:31 +0200)] 
s3:smbd/msdfs: let create_conn_struct() check the share security descriptor

metze
(cherry picked from commit 18f967a24881aa899b39f7676fc70a7f7aaca07b)

14 years agos3: Fix bug 8102
Volker Lendecke [Tue, 5 Jul 2011 09:13:07 +0000 (11:13 +0200)] 
s3: Fix bug 8102

We can't allow open with access that has been denied via the share
security descriptor

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jul  5 16:21:54 CEST 2011 on sn-devel-104
(cherry picked from commit 4deca5d72804a40e68158a1183f5633dabf24761)

14 years agos3: Calculate&store the maximum share access mask
Volker Lendecke [Mon, 4 Jul 2011 16:35:21 +0000 (18:35 +0200)] 
s3: Calculate&store the maximum share access mask

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 720fa46f9443ccbe471b265f1c2b9cb9782a3c26)

14 years agos3: Return "granted" from share_access_check
Volker Lendecke [Mon, 4 Jul 2011 15:02:34 +0000 (17:02 +0200)] 
s3: Return "granted" from share_access_check

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 1c022d2e414607633323e65abbc63bb3aeaaa6a4)

14 years agos3:smb2_server: add some comments about change_to_user() and change_to_root_user()
Stefan Metzmacher [Fri, 8 Jul 2011 07:08:39 +0000 (09:08 +0200)] 
s3:smb2_server: add some comments about change_to_user() and change_to_root_user()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jul  8 13:45:46 CEST 2011 on sn-devel-104
(cherry picked from commit dbfb88aef30a755c29015bff4699eb17925a4988)

The last 3 patches address bug #8292 (Disable SMB2 for 3.6).

14 years agos3:smb2_server: call change_to_root_user() or smbd_smb2_request_check_tcon()
Stefan Metzmacher [Thu, 7 Jul 2011 14:38:33 +0000 (16:38 +0200)] 
s3:smb2_server: call change_to_root_user() or smbd_smb2_request_check_tcon()

For all requests which don't operate on a tcon, we should call
change_to_root_user(), to match the SMB1 behavior.

For SMB1 we do the following operations without AS_USER:

/* 0x70 */ { "SMBtcon",reply_tcon,0},
/* 0x71 */ { "SMBtdis",reply_tdis,DO_CHDIR},
/* 0x72 */ { "SMBnegprot",reply_negprot,0},
/* 0x73 */ { "SMBsesssetupX",reply_sesssetup_and_X,0},
/* 0x74 */ { "SMBulogoffX",reply_ulogoffX, 0}, /* ulogoff doesn't give a valid TID */
/* 0x75 */ { "SMBtconX",reply_tcon_and_X,0},
...
/* 0x2b */ { "SMBecho",reply_echo,0},
...
/* 0xa4 */ { "SMBntcancel",reply_ntcancel, 0 },

For SMB2tdis we still call smbd_smb2_request_check_tcon()
as close_cnum() calls change_to_root_user() when needed.

metze

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit eea210eba7c20e6d04b13cf8ccd3011ee7c99157)

14 years agos3:smb2_server: there's no reason to check the session id twice on a smb2_tcon request
Stefan Metzmacher [Mon, 4 Jul 2011 13:57:20 +0000 (15:57 +0200)] 
s3:smb2_server: there's no reason to check the session id twice on a smb2_tcon request

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jul  4 17:34:13 CEST 2011 on sn-devel-104
(cherry picked from commit 7c96e96e9881ec1ad7b41f0ab241a5b0ac17b93f)

14 years agoWHATSNEW: Update changes since rc2.
Karolin Seeger [Wed, 13 Jul 2011 19:21:23 +0000 (21:21 +0200)] 
WHATSNEW: Update changes since rc2.

Karolin

14 years agoVERSION: Set version to 3.6.0rc3.
Karolin Seeger [Wed, 13 Jul 2011 19:20:56 +0000 (21:20 +0200)] 
VERSION: Set version to 3.6.0rc3.

Karolin

14 years agoFix bug #Bug 8304 - Uninitialized variable referenced in error path.
Jeremy Allison [Tue, 12 Jul 2011 20:06:13 +0000 (13:06 -0700)] 
Fix bug #Bug 8304 - Uninitialized variable referenced in error path.

princ must not be used uninitialized. auth_data is not used at all.

14 years agoFix bug 8305 - nmbd segfaults - when using "smbtree ..." (cherry picked from commit...
Günter Kukkukk [Wed, 13 Jul 2011 13:10:13 +0000 (06:10 -0700)] 
Fix bug 8305 - nmbd segfaults - when using "smbtree ..." (cherry picked from commit 102a931c8081559423fb25b3a4d445b6f2e790ac)

14 years agos3-docs: Remove manpages for ldb tools.
Karolin Seeger [Tue, 12 Jul 2011 19:11:34 +0000 (21:11 +0200)] 
s3-docs: Remove manpages for ldb tools.

Fix bug #8297 (ldb tools man pages should be removed from the release tar
ball).

Thanks to Björn for reporting!

Karolin

14 years agoFix bug #8293 - SMB2 doesn't rotate the log files often enough.
Jeremy Allison [Thu, 7 Jul 2011 21:59:41 +0000 (14:59 -0700)] 
Fix bug #8293 - SMB2 doesn't rotate the log files often enough.

Move the num_requests field out of the smb1 struct into the generic
struct smbd_server_connection struct. Use it to count SMB2 requests
as well as SMB1 and ensure that check_log_size() is called every 50
SMB2 requests.

14 years agos3-waf: split out LIBCLI_WINREG_INTERNAL as LIBCLI_WINREG was pulling in rpc server...
Günther Deschner [Fri, 8 Jul 2011 15:17:17 +0000 (17:17 +0200)] 
s3-waf: split out LIBCLI_WINREG_INTERNAL as LIBCLI_WINREG was pulling in rpc server code in undesired places.

Andreas, please check.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jul  8 18:34:44 CEST 2011 on sn-devel-104
(cherry picked from commit f4add4fbf545313f5d24e0d9e5c9eb0f8fac630a)

Conflicts:

source3/rpc_server/wscript_build
source3/wscript_build

The last 21 patches address bug #8214 (printer driver upgrade fails, causing
smbd to exit on startup).

14 years agos3-printing: remove tdb migration invalid printer name checks
David Disseldorp [Tue, 5 Jul 2011 13:04:02 +0000 (15:04 +0200)] 
s3-printing: remove tdb migration invalid printer name checks

WERR_INVALID_PRINTER_NAME only needed to be handled when printing tdb
migration used spoolss, with winreg such errors are no longer possible.

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jul  7 19:15:34 CEST 2011 on sn-devel-104
(cherry picked from commit e5955903fdc5ed6f8660b72db0716d4da25c711c)

14 years agos3-printing: fill info2_mask in printer migration
David Disseldorp [Tue, 5 Jul 2011 09:34:47 +0000 (11:34 +0200)] 
s3-printing: fill info2_mask in printer migration

Also fix possibly uninitialised status return from
printing_tdb_migrate_printer().
(cherry picked from commit 5dd8185d852afc3843253c9471326677f8816a77)

14 years agos3-printing: make sure to first migrate the printers then the security descriptor.
Günther Deschner [Tue, 5 Jul 2011 12:01:40 +0000 (14:01 +0200)] 
s3-printing: make sure to first migrate the printers then the security descriptor.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit cfc3b6e5f79f253e83dfbd13d47b671deb5801b3)

14 years agos3-printing: remove spoolss pipe from migration library, only using winreg finally.
Günther Deschner [Tue, 5 Jul 2011 00:33:23 +0000 (02:33 +0200)] 
s3-printing: remove spoolss pipe from migration library, only using winreg finally.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit 57bbb32c64db1027e2b9ae1aef7f5f3b33ae3882)

14 years agos3-printing: use winreg interface for migration, instead of spoolss.
Günther Deschner [Mon, 4 Jul 2011 17:47:07 +0000 (19:47 +0200)] 
s3-printing: use winreg interface for migration, instead of spoolss.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit 8f3d5f5333a61922c4ea7ff1e1d244978958e857)

Conflicts:

source3/printing/nt_printing_migrate.c

14 years agos3-printing: safe a ton of roundtrips by reusing existing winreg binding_handles.
Günther Deschner [Mon, 4 Jul 2011 22:55:35 +0000 (00:55 +0200)] 
s3-printing: safe a ton of roundtrips by reusing existing winreg binding_handles.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit 72b1f8be5619ed778c4aa0b967f6a4f34d7e9de8)

Conflicts:

source3/rpc_server/spoolss/srv_spoolss_nt.c

14 years agos3-printing: use winreg_internal functions.
Günther Deschner [Mon, 4 Jul 2011 22:16:03 +0000 (00:16 +0200)] 
s3-printing: use winreg_internal functions.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit 0a1ec73b965f66977a90fb7febb3b56b52ebab20)

Conflicts:

source3/rpc_server/spoolss/srv_spoolss_nt.c

14 years agos3-printing: add winreg_internal functions.
Günther Deschner [Mon, 4 Jul 2011 22:16:47 +0000 (00:16 +0200)] 
s3-printing: add winreg_internal functions.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit ada5380d2090179fc57eee66e2b46788f4944db0)

Conflicts:

source3/rpc_server/spoolss/srv_spoolss_nt.c
source3/rpc_server/spoolss/srv_spoolss_util.c

14 years agos3-printing: add winreg_printer_binding_handle and remove most of srv_spoolss_util.c.
Günther Deschner [Mon, 4 Jul 2011 18:09:54 +0000 (20:09 +0200)] 
s3-printing: add winreg_printer_binding_handle and remove most of srv_spoolss_util.c.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit a762eda519c995214c041170e2615c5c51b2a2b1)

Conflicts:

source3/rpc_server/spoolss/srv_spoolss_util.c

14 years agos3-printing: add rpc_client/cli_winreg_spoolss.c
Günther Deschner [Mon, 4 Jul 2011 17:47:29 +0000 (19:47 +0200)] 
s3-printing: add rpc_client/cli_winreg_spoolss.c

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit f2be8378b92669092f8444df038f769fc9312ff4)

14 years agos3-waf: make LIBCLI_SPOOLSS a shared library
Günther Deschner [Tue, 5 Jul 2011 09:29:37 +0000 (11:29 +0200)] 
s3-waf: make LIBCLI_SPOOLSS a shared library

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit a0fc64a88ee6f1f45d4c2b95d6773eccab50ebb4)

14 years agos3-printing: move spoolss_create_default_devmode/secdesc to init_spoolss.h
Günther Deschner [Tue, 5 Jul 2011 00:15:35 +0000 (02:15 +0200)] 
s3-printing: move spoolss_create_default_devmode/secdesc to init_spoolss.h

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit 43cf3a28dc539351da8a316e0e52a8292ec40cc7)

14 years agos3-printing: move driver_info_ctr_to_info8 to init_spoolss.h
Günther Deschner [Tue, 5 Jul 2011 00:12:24 +0000 (02:12 +0200)] 
s3-printing: move driver_info_ctr_to_info8 to init_spoolss.h

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit 74e416031b2fc5d9c6af30f692d5b73cb1942cf4)

14 years agos3-printing: move os2 related functions to printing/nt_printing_os2.c.
Günther Deschner [Mon, 4 Jul 2011 23:24:48 +0000 (01:24 +0200)] 
s3-printing: move os2 related functions to printing/nt_printing_os2.c.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>
(cherry picked from commit dd5375b4a1798c856fa9c104baa36c137d664b9d)

Conflicts:

source3/rpc_server/spoolss/srv_spoolss_util.c

14 years agos3-printing: open up a winreg pipe handle for the migration code.
Günther Deschner [Fri, 1 Jul 2011 13:39:11 +0000 (15:39 +0200)] 
s3-printing: open up a winreg pipe handle for the migration code.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jul  4 15:06:41 CEST 2011 on sn-devel-104
(cherry picked from commit ff94539f276bdef73bd12c67bff1f34e697ccbfc)

14 years agos3-net: use printing_migrate library, and eliminate duplicate code.
Günther Deschner [Fri, 1 Jul 2011 13:02:26 +0000 (15:02 +0200)] 
s3-net: use printing_migrate library, and eliminate duplicate code.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jul  1 17:57:09 CEST 2011 on sn-devel-104
(cherry picked from commit bafd7212eb4c82e86874b2f80ddf5c04b2d180b9)

Conflicts:

source3/utils/net_printing.c

14 years agos3-printing: split out printing migration code into a smaller library.
Günther Deschner [Fri, 1 Jul 2011 12:57:32 +0000 (14:57 +0200)] 
s3-printing: split out printing migration code into a smaller library.

Guenther
(cherry picked from commit e02abd6c83708f297b1985bb1bdc7d5dfbc924b2)

Conflicts:

source3/printing/nt_printing_migrate.c
source3/wscript_build

14 years agos3-printing: skip migration of non-existent printers
David Disseldorp [Wed, 15 Jun 2011 12:59:49 +0000 (14:59 +0200)] 
s3-printing: skip migration of non-existent printers

Skip tdb migration of printer and security descriptor entries which
refer to non-existent printers.

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jun 30 10:54:23 CEST 2011 on sn-devel-104
(cherry picked from commit c9e3f6ab02bdc354a9b656f62744ee66fe9e9e67)

14 years agos3-printing: fill devicemode size in migrate_printer()
David Disseldorp [Wed, 15 Jun 2011 10:46:55 +0000 (12:46 +0200)] 
s3-printing: fill devicemode size in migrate_printer()

Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit a36ce0735ff6cad8124bd63a056a71d9495b238c)

14 years agos3-waf: stop building smbtortre4.
Günther Deschner [Thu, 12 May 2011 12:33:15 +0000 (14:33 +0200)] 
s3-waf: stop building smbtortre4.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu May 12 15:35:02 CEST 2011 on sn-devel-104
(cherry picked from commit c1ac023b588e1ca676cbbf542ca6f93aa199ad32)

14 years agoWHATSNEW: Add changes since rc2.
Karolin Seeger [Tue, 5 Jul 2011 18:39:53 +0000 (20:39 +0200)] 
WHATSNEW: Add changes since rc2.

Karolin

14 years agos3:smb2 fix smbd crash on premature end of smb2 conn (Bug 8286)
Christian Ambach [Mon, 4 Jul 2011 15:55:54 +0000 (17:55 +0200)] 
s3:smb2 fix smbd crash on premature end of smb2 conn (Bug 8286)

when smbd tries to clean up locks after a premature end of a smb2
connection, lock_db has already been freed and so it crashes

this patch changes the order in which items are freed so that
lock_db is still around when it is needed

14 years agos3:nmbd_subnetdb: close all sockets attached to a subnet in close_subnet() (bug ...
Stefan Metzmacher [Thu, 30 Jun 2011 08:09:56 +0000 (10:09 +0200)] 
s3:nmbd_subnetdb: close all sockets attached to a subnet in close_subnet() (bug #8276)

metze
(cherry picked from commit 75e9f2110876137a57632d223248ac51dbfc4569)

14 years agos3:smbldap: make smbldap_connect_system self contained
Gregor Beck [Tue, 21 Jun 2011 06:16:56 +0000 (08:16 +0200)] 
s3:smbldap: make smbldap_connect_system self contained

The last patches address bug #8253 (winbindd panics if verify_idpool() fails).

14 years agos3:smbldap: add a destructor to smbldap_state, just in case
Gregor Beck [Tue, 21 Jun 2011 06:06:28 +0000 (08:06 +0200)] 
s3:smbldap: add a destructor to smbldap_state, just in case

14 years agos3:smbldap: let smbldap_free_struct do what it claims to
Gregor Beck [Tue, 21 Jun 2011 06:02:53 +0000 (08:02 +0200)] 
s3:smbldap: let smbldap_free_struct do what it claims to