]> git.ipfire.org Git - thirdparty/curl.git/log
thirdparty/curl.git
4 years agourldata: remove 'local_ip' from the connectdata struct
Daniel Stenberg [Tue, 26 Jan 2021 13:14:06 +0000 (14:14 +0100)] 
urldata: remove 'local_ip' from the connectdata struct

As the info is already stored in the transfer handle anyway, there's no
need to carry around a duplicate buffer for the life-time of the handle.

Closes #6534

4 years agourldata: remove duplicate port number storage
Daniel Stenberg [Tue, 26 Jan 2021 10:04:33 +0000 (11:04 +0100)] 
urldata: remove duplicate port number storage

... and use 'int' for ports. We don't use 'unsigned short' since -1 is
still often used internally to signify "unknown value" and 0 - 65535 are
all valid port numbers.

Closes #6534

4 years agourldata: remove the duplicate 'ip_addr_str' field
Daniel Stenberg [Tue, 26 Jan 2021 09:46:49 +0000 (10:46 +0100)] 
urldata: remove the duplicate 'ip_addr_str' field

... as the numerical IP address is already stored and kept in 'primary_ip'.

Closes #6534

4 years agoselect: convert Curl_select() to private static function
Daniel Stenberg [Tue, 26 Jan 2021 08:32:49 +0000 (09:32 +0100)] 
select: convert Curl_select() to private static function

The old function should not be used anywhere anymore (the only remaining
gskit use has to be fixed to instead use Curl_poll or none at all).

The static function version is now called our_select() and is only built
if necessary.

Closes #6531

4 years agoCurl_chunker: shrink the struct
Daniel Stenberg [Mon, 25 Jan 2021 16:42:59 +0000 (17:42 +0100)] 
Curl_chunker: shrink the struct

... by removing a field, converting the hex index into a byte and
rearranging the order. Cuts it down from 48 bytes to 32 on x86_64.

Closes #6527

4 years agocurl: include the file name in --xattr/--remote-time error msgs
Daniel Stenberg [Tue, 26 Jan 2021 16:02:39 +0000 (17:02 +0100)] 
curl: include the file name in --xattr/--remote-time error msgs

4 years agocurl: s/config->global/global/ in single_transfer()
Daniel Stenberg [Tue, 26 Jan 2021 15:55:50 +0000 (16:55 +0100)] 
curl: s/config->global/global/ in single_transfer()

4 years agocurl: move fprintf outputs to warnf
Daniel Stenberg [Tue, 26 Jan 2021 15:52:03 +0000 (16:52 +0100)] 
curl: move fprintf outputs to warnf

For setting and getting time of the download. To make the outputs
respect --silent etc.

Reported-by: Viktor Szakats
Fixes #6533
Closes #6535

4 years agongtcp2: Fix http3 upload stall
Tatsuhiro Tsujikawa [Mon, 25 Jan 2021 08:59:22 +0000 (17:59 +0900)] 
ngtcp2: Fix http3 upload stall

Closes #6521

4 years agongtcp2: Fix stack buffer overflow
Tatsuhiro Tsujikawa [Mon, 25 Jan 2021 09:39:00 +0000 (18:39 +0900)] 
ngtcp2: Fix stack buffer overflow

Closes #6521

4 years agowarnless.h: remove the prototype for curlx_ultosi
Daniel Stenberg [Tue, 26 Jan 2021 15:32:03 +0000 (16:32 +0100)] 
warnless.h: remove the prototype for curlx_ultosi

Follow-up to 217552503ff3

4 years agowarnless: remove curlx_ultosi
Daniel Stenberg [Tue, 26 Jan 2021 08:26:48 +0000 (09:26 +0100)] 
warnless: remove curlx_ultosi

... not used anywhere

Closes #6530

4 years agolib: remove conn->data uses
Patrick Monnerat [Sun, 24 Jan 2021 17:57:02 +0000 (18:57 +0100)] 
lib: remove conn->data uses

Closes #6515

4 years agopingpong: remove the 'conn' struct member
Daniel Stenberg [Mon, 25 Jan 2021 16:23:33 +0000 (17:23 +0100)] 
pingpong: remove the 'conn' struct member

... as it's superfluous now when Curl_easy is passed in and we can
derive the connection from that instead and avoid the duplicate copy.

Closes #6525

4 years agohostip/proxy: remove conn->data use
Daniel Stenberg [Sun, 24 Jan 2021 22:41:58 +0000 (23:41 +0100)] 
hostip/proxy: remove conn->data use

Closes #6513

4 years agourl: reduce conn->data references
Daniel Stenberg [Sun, 24 Jan 2021 22:32:24 +0000 (23:32 +0100)] 
url: reduce conn->data references

... there are a few left but let's keep them to last

Closes #6512

4 years agoscripts/singleuse: add curl_easy_option*
Daniel Stenberg [Tue, 26 Jan 2021 08:30:30 +0000 (09:30 +0100)] 
scripts/singleuse: add curl_easy_option*

4 years agotest410: fix for windows
Jay Satiro [Mon, 25 Jan 2021 06:06:35 +0000 (01:06 -0500)] 
test410: fix for windows

- Pass the very long request header via file instead of command line.

Prior to this change the 49k very long request header string was passed
via command line and on Windows that is too long so it was truncated and
the test would fail (specifically msys CI).

Closes https://github.com/curl/curl/pull/6516

4 years agolibssh2: move data from connection object to transfer object
Daniel Stenberg [Mon, 25 Jan 2021 09:44:30 +0000 (10:44 +0100)] 
libssh2: move data from connection object to transfer object

Readdir data, filenames and attributes are strictly related to the
transfer and not the connection. This also reduces the total size of the
fixed connectdata struct.

Closes #6519

4 years agoRELEASE-NOTES: synced
Daniel Stenberg [Mon, 25 Jan 2021 13:40:17 +0000 (14:40 +0100)] 
RELEASE-NOTES: synced

4 years agolib: remove conn->data uses
Patrick Monnerat [Wed, 20 Jan 2021 23:38:52 +0000 (00:38 +0100)] 
lib: remove conn->data uses

Closes #6499

4 years agohyper: remove the conn->data references
Daniel Stenberg [Thu, 21 Jan 2021 15:49:14 +0000 (16:49 +0100)] 
hyper: remove the conn->data references

Closes #6508

4 years agotravis: build ngtcp2 --with-gnutls
Daniel Stenberg [Thu, 21 Jan 2021 12:32:33 +0000 (13:32 +0100)] 
travis: build ngtcp2 --with-gnutls

... since they disable it by default since a few days back.

Closes #6506
Fixes #6493

4 years agohostip: remove conn->data from resolver functions
Daniel Stenberg [Wed, 20 Jan 2021 09:15:43 +0000 (10:15 +0100)] 
hostip: remove conn->data from resolver functions

This also moves the 'async' struct from the connectdata struct into the
Curl_easy struct, which seems like a better home for it.

Closes #6497

4 years agostrerror: skip errnum >= 0 assertion on windows
Jay Satiro [Thu, 21 Jan 2021 07:46:07 +0000 (02:46 -0500)] 
strerror: skip errnum >= 0 assertion on windows

On Windows an error number may be greater than INT_MAX and negative once
cast to int.

The assertion is checked only in debug builds.

Closes https://github.com/curl/curl/pull/6504

4 years agodoh: make Curl_doh_is_resolved survive a NULL pointer
Daniel Stenberg [Thu, 21 Jan 2021 22:31:19 +0000 (23:31 +0100)] 
doh: make Curl_doh_is_resolved survive a NULL pointer

... if Curl_doh() returned a NULL, this function gets called anyway as
in a asynch procedure. Then the doh struct pointer is NULL and signifies
an OOM situation.

Follow-up to 6246a1d8c6776

4 years agowolfssh: remove conn->data references
Daniel Stenberg [Thu, 21 Jan 2021 12:46:59 +0000 (13:46 +0100)] 
wolfssh: remove conn->data references

... and repair recent build breakage

Closes #6507

4 years agohttp: empty reply connection are not left intact
Daniel Stenberg [Thu, 21 Jan 2021 06:58:36 +0000 (07:58 +0100)] 
http: empty reply connection are not left intact

... so mark the connection as closed in this condition to prevent that
verbose message to wrongly appear.

Reported-by: Matt Holt
Bug: https://twitter.com/mholt6/status/1352130240265375744
Closes #6503

4 years agochunk/encoding: remove conn->data references
Daniel Stenberg [Wed, 20 Jan 2021 09:58:12 +0000 (10:58 +0100)] 
chunk/encoding: remove conn->data references

... by anchoring more functions on Curl_easy instead of connectdata

Closes #6498

4 years agolib: save a bit of space with some structure packing
Erik Olsson [Sat, 16 Jan 2021 21:17:51 +0000 (22:17 +0100)] 
lib: save a bit of space with some structure packing

- Reorder some internal struct members so that less padding is used.

This is an attempt at saving a bit of space by packing some structs
(using pahole to find the holes) where it might make sense to do
so without losing readability.

I.e., I tried to avoid separating fields that seem grouped
together (like the cwd... fields in struct ftp_conn for instance).
Also abstained from touching fields behind conditional macros as
that quickly can get complicated.

Closes https://github.com/curl/curl/pull/6483

4 years agoINSTALL.md: fix typo
Daniel Stenberg [Wed, 20 Jan 2021 21:45:12 +0000 (22:45 +0100)] 
INSTALL.md: fix typo

Found-by: Marcel Raad
4 years agohttp: get CURLOPT_REQUEST_TARGET working with a HTTP proxy
Fabian Keil [Tue, 19 Jan 2021 10:13:41 +0000 (11:13 +0100)] 
http: get CURLOPT_REQUEST_TARGET working with a HTTP proxy

Added test 1613 to verify.

Closes #6490

4 years agoMerge branch 'bagder/curl_range-data-conn'
Daniel Stenberg [Wed, 20 Jan 2021 13:59:24 +0000 (14:59 +0100)] 
Merge branch 'bagder/curl_range-data-conn'

4 years agoftp: remove conn->data leftover
Daniel Stenberg [Wed, 20 Jan 2021 08:30:10 +0000 (09:30 +0100)] 
ftp: remove conn->data leftover

4 years agocurl_range: remove conn->data
Daniel Stenberg [Wed, 20 Jan 2021 08:29:45 +0000 (09:29 +0100)] 
curl_range: remove conn->data

Closes #6496

4 years agoINSTALL: now at 85 operating systems
Daniel Stenberg [Wed, 20 Jan 2021 13:58:05 +0000 (14:58 +0100)] 
INSTALL: now at 85 operating systems

4 years agoquiche: fix unused parameter ‘conn’
Daniel Stenberg [Wed, 20 Jan 2021 08:16:12 +0000 (09:16 +0100)] 
quiche: fix unused parameter ‘conn’

Follow-up to 2bdec0b3

4 years agotransfer: fix ‘conn’ undeclared mistake for iconv build
Daniel Stenberg [Wed, 20 Jan 2021 08:13:14 +0000 (09:13 +0100)] 
transfer: fix ‘conn’ undeclared mistake for iconv build

Follow-up to 219d9f8620d

4 years agodoh: allocate state struct on demand
Daniel Stenberg [Tue, 19 Jan 2021 14:57:24 +0000 (15:57 +0100)] 
doh: allocate state struct on demand

... instead of having it static within the Curl_easy struct. This takes
away 1176 bytes (18%) from the Curl_easy struct that aren't used very
often and instead makes the code allocate it when needed.

Closes #6492

4 years agosocks: use the download buffer instead
Daniel Stenberg [Tue, 19 Jan 2021 14:30:59 +0000 (15:30 +0100)] 
socks: use the download buffer instead

The SOCKS code now uses the generic download buffer for temporary
storage during the connection procedure, instead of having its own
private 600 byte buffer that adds to the connectdata struct size. This
works fine because this point the buffer is allocated but is not use for
download yet since the connection hasn't completed.

This reduces the connection struct size by 22% on a 64bit arch!

The SOCKS buffer needs to be at least 600 bytes, and the download buffer
is guaranteed to never be smaller than 1000 bytes.

Closes #6491

4 years agourldata: make magic be the first struct field
Daniel Stenberg [Tue, 19 Jan 2021 07:23:52 +0000 (08:23 +0100)] 
urldata: make magic be the first struct field

By making the `magic` identifier the same size and at the same place
within the structs (easy, multi, share), libcurl will be able to more
reliably detect and safely error out if an application passes in the
wrong handle to APIs. Easier to detect and less likely to cause crashes
if done.

Such mixups can't be detected at compile-time due to them being
typedefed void pointers - unless `CURL_STRICTER` is defined.

Closes #6484

4 years agohttp_chunks: correct and clarify a comment on hexnumber length
Daniel Stenberg [Tue, 19 Jan 2021 13:23:11 +0000 (14:23 +0100)] 
http_chunks: correct and clarify a comment on hexnumber length

... and also rename the define for max length.

Closes #6489

4 years agocurl_path: remove conn->data use
Daniel Stenberg [Tue, 19 Jan 2021 09:43:44 +0000 (10:43 +0100)] 
curl_path: remove conn->data use

Closes #6487

4 years agotransfer: remove conn->data use
Daniel Stenberg [Tue, 19 Jan 2021 09:24:35 +0000 (10:24 +0100)] 
transfer: remove conn->data use

Closes #6486

4 years agoquic: remove conn->data use
Daniel Stenberg [Tue, 19 Jan 2021 08:48:40 +0000 (09:48 +0100)] 
quic: remove conn->data use

Closes #6485

4 years agoAdd test1181: Proxy request with --proxy-header "Connection: Keep-Alive"
Fabian Keil [Sat, 16 Jan 2021 14:55:08 +0000 (15:55 +0100)] 
Add test1181: Proxy request with --proxy-header "Connection: Keep-Alive"

4 years agoAdd test1180: Proxy request with -H "Proxy-Connection: Keep-Alive"
Fabian Keil [Sat, 16 Jan 2021 14:45:28 +0000 (15:45 +0100)] 
Add test1180: Proxy request with -H "Proxy-Connection: Keep-Alive"

At the moment the test fails as curl sends two Proxy-Connection
headers.

4 years agoc-hyper: avoid duplicated Proxy-Connection headers
Daniel Stenberg [Mon, 18 Jan 2021 09:35:47 +0000 (10:35 +0100)] 
c-hyper: avoid duplicated Proxy-Connection headers

4 years agohttp: make providing Proxy-Connection header not cause duplicated headers
Daniel Stenberg [Sun, 17 Jan 2021 17:20:06 +0000 (18:20 +0100)] 
http: make providing Proxy-Connection header not cause duplicated headers

Fixes test 1180

Bug: https://curl.se/mail/lib-2021-01/0095.html
Reported-by: Fabian Keil
Closes #6472

4 years agoruntests: preprocess DISABLED to allow conditionals
Daniel Stenberg [Mon, 18 Jan 2021 08:35:29 +0000 (09:35 +0100)] 
runtests: preprocess DISABLED to allow conditionals

... with this function provided, we can disable tests for specific
environments and setups directly within this file.

Closes #6477

4 years agoruntests: turn preprocessing into a separate function
Daniel Stenberg [Mon, 18 Jan 2021 08:16:41 +0000 (09:16 +0100)] 
runtests: turn preprocessing into a separate function

... and remove all other variable substitutions as they're now done once
and for all in the preprocessor.

4 years agolib/Makefile.inc: convert to listing each file on its own line
Daniel Stenberg [Thu, 14 Jan 2021 07:46:11 +0000 (08:46 +0100)] 
lib/Makefile.inc: convert to listing each file on its own line

... to make it diff friendlier and easier to read.

Closes #6448

4 years agoftplistparser: remove use of conn->data
Daniel Stenberg [Mon, 18 Jan 2021 21:59:25 +0000 (22:59 +0100)] 
ftplistparser: remove use of conn->data

Closes #6482

4 years agolib: more conn->data cleanups
Daniel Stenberg [Mon, 18 Jan 2021 10:56:50 +0000 (11:56 +0100)] 
lib: more conn->data cleanups

Closes #6479

4 years agovtls: reduce conn->data use
Patrick Monnerat [Wed, 13 Jan 2021 16:01:31 +0000 (17:01 +0100)] 
vtls: reduce conn->data use

Closes #6474

4 years agohyper: deliver data to application with Curl_client_write
Daniel Stenberg [Sun, 17 Jan 2021 22:49:15 +0000 (23:49 +0100)] 
hyper: deliver data to application with Curl_client_write

... just as the native code path does. Avoids sending too large data
chunks in the callback and more.

Reported-by: Gisle Vanem
Fixes #6462
Closes #6473

4 years agogopher: remove accidental conn->data leftover
Daniel Stenberg [Mon, 18 Jan 2021 21:57:56 +0000 (22:57 +0100)] 
gopher: remove accidental conn->data leftover

4 years agolibssh: avoid plain free() of libssh-memory
Daniel Stenberg [Mon, 18 Jan 2021 15:40:39 +0000 (16:40 +0100)] 
libssh: avoid plain free() of libssh-memory

Since curl's own memory debugging system redefines free() calls to track
and fiddle with memory, it cannot be used on memory allocated by 3rd
party libraries.

Third party libraries SHOULD NOT require free() to release allocated
resources for this reason - and libs can use separate healp allocators
on some systems (like Windows) so free() doesn't necessarily work
anyway.

Filed as an issue with libssh: https://bugs.libssh.org/T268

Closes #6481

4 years agosend: assert that Curl_write_plain() has a ->conn when called
Daniel Stenberg [Mon, 18 Jan 2021 07:55:13 +0000 (08:55 +0100)] 
send: assert that Curl_write_plain() has a ->conn when called

To help catch bad invokes.

Closes #6476

4 years agotest410: verify HTTPS GET with a 49K request header
Daniel Stenberg [Sat, 16 Jan 2021 22:22:04 +0000 (23:22 +0100)] 
test410: verify HTTPS GET with a 49K request header

skip test 410 for mesalink in the CI as it otherwise hangs "forever"

4 years agolib: pass in 'struct Curl_easy *' to most functions
Daniel Stenberg [Fri, 8 Jan 2021 16:58:15 +0000 (17:58 +0100)] 
lib: pass in 'struct Curl_easy *' to most functions

... in most cases instead of 'struct connectdata *' but in some cases in
addition to.

- We mostly operate on transfers and not connections.

- We need the transfer handle to log, store data and more. Everything in
  libcurl is driven by a transfer (the CURL * in the public API).

- This work clarifies and separates the transfers from the connections
  better.

- We should avoid "conn->data". Since individual connections can be used
  by many transfers when multiplexing, making sure that conn->data
  points to the current and correct transfer at all times is difficult
  and has been notoriously error-prone over the years. The goal is to
  ultimately remove the conn->data pointer for this reason.

Closes #6425

4 years agodocs: fix typos in NEW-PROTOCOL.md 6471/head
Emil Engler [Sun, 17 Jan 2021 11:54:34 +0000 (12:54 +0100)] 
docs: fix typos in NEW-PROTOCOL.md

This fixes a misspelled "it" and a grammatically wrong "-ing" suffix.

Closes #6471

4 years agoRELEASE-NOTES: synced
Daniel Stenberg [Sat, 16 Jan 2021 21:49:25 +0000 (22:49 +0100)] 
RELEASE-NOTES: synced

4 years agocmake: expose CURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG
Razvan Cojocaru [Mon, 11 Jan 2021 11:00:36 +0000 (13:00 +0200)] 
cmake: expose CURL_DISABLE_OPENSSL_AUTO_LOAD_CONFIG

This does for cmake builds what --disable-openssl-auto-load-config
does for autoconf builds.

Closes https://github.com/curl/curl/pull/6435

4 years agotest1918: verify curl_easy_option_by_name() and curl_easy_option_by_id()
Daniel Stenberg [Fri, 15 Jan 2021 12:04:20 +0000 (13:04 +0100)] 
test1918: verify curl_easy_option_by_name() and curl_easy_option_by_id()

... and as a practical side-effect, make sure that the
Curl_easyopts_check() function is asserted in debug builds, which we
want to detect mismatches between the options list in easyoptions.c and
the options in curl.h

Found-by: Gisle Vanem
Bug: https://github.com/curl/curl/commit/08e8455dddc5e48e58a12ade3815c01ae3da3b64#commitcomment-45991815

Closes #6461

4 years agoeasyoptions: add the missing AWS_SIGV4
Gisle Vanem [Fri, 15 Jan 2021 12:12:51 +0000 (13:12 +0100)] 
easyoptions: add the missing AWS_SIGV4

Follow-up from AWS_SIGV4

4 years agoschannel_verify: fix safefree call typo
Daniel Stenberg [Fri, 15 Jan 2021 07:17:14 +0000 (08:17 +0100)] 
schannel_verify: fix safefree call typo

Follow-up from e87ad71d1ba00519

Closes #6459

4 years agomime: make sure setting MIMEPOST to NULL resets properly
Daniel Stenberg [Thu, 14 Jan 2021 15:31:42 +0000 (16:31 +0100)] 
mime: make sure setting MIMEPOST to NULL resets properly

... so that a function can first use MIMEPOST and then set it to NULL to
reset it back to a blank POST.

Added test 584 to verify the fix.

Reported-by: Christoph M. Becker
Fixes #6455
Closes #6456

4 years agomulti: set the PRETRANSFER time-stamp when we switch to PERFORM
Daniel Stenberg [Thu, 14 Jan 2021 13:24:07 +0000 (14:24 +0100)] 
multi: set the PRETRANSFER time-stamp when we switch to PERFORM

... instead of at end of the DO state. This makes the timer more
accurate for the protocols that use the DOING state (such as FTP), and
simplifies how the function (now called init_perform) is called.

The timer will then include the entire procedure up to PERFORM -
including all instructions for getting the transfer started.

Closes #6454

4 years agoCURLINFO_PRETRANSFER_TIME.3: clarify
Daniel Stenberg [Thu, 14 Jan 2021 13:22:25 +0000 (14:22 +0100)] 
CURLINFO_PRETRANSFER_TIME.3: clarify

... the timer *does* include the instructions for getting the remote
file.

Ref: #6452
Closes #6453

4 years agoschannel: plug a memory-leak
Gisle Vanem [Thu, 14 Jan 2021 16:09:37 +0000 (17:09 +0100)] 
schannel: plug a memory-leak

... when built without -DUNICODE.

Closes #6457

4 years agogitattributes: Set batch files to CRLF line endings on checkout
Jay Satiro [Wed, 13 Jan 2021 07:03:57 +0000 (02:03 -0500)] 
gitattributes: Set batch files to CRLF line endings on checkout

If a batch file is run without CRLF line endings (ie LF-only) then
arbitrary behavior may occur. I consider that a bug in Windows, however
the effects can be serious enough (eg unintended code executed) that
we're fixing it in the repo by requiring CRLF line endings for batch
files on checkout.

Prior to this change the checked-out line endings of batch files were
dependent on a user's git preferences. On Windows it is common for git
users to have automatic CRLF conversion enabled (core.autocrlf true),
but those users that don't would run into this behavior.

For example a user has reported running the Visual Studio project
generator batch file (projects/generate.bat) and it looped forever.
Output showed that the Windows OS interpreter was occasionally jumping
to arbitrary points in the batch file and executing commands. This
resulted in unintended files being removed (a removal sequence called)
and looping forever.

Ref: https://serverfault.com/q/429594
Ref: https://stackoverflow.com/q/232651
Ref: https://www.dostips.com/forum/viewtopic.php?t=8988
Ref: https://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
Ref: https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#_core_autocrlf

Bug: https://github.com/curl/curl/discussions/6427
Reported-by: Ganesh Kamath
Closes https://github.com/curl/curl/pull/6442

4 years agotool_operate: spellfix a comment
Daniel Stenberg [Thu, 14 Jan 2021 12:40:12 +0000 (13:40 +0100)] 
tool_operate: spellfix a comment

4 years agoROADMAP: refreshed
Daniel Stenberg [Thu, 14 Jan 2021 08:48:42 +0000 (09:48 +0100)] 
ROADMAP: refreshed

o removed HSTS - already implemented
o added HTTPS RR records
o mention HTTP/3 completion

4 years agohttp_chunks: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 10:53:41 +0000 (11:53 +0100)] 
http_chunks: remove Curl_ prefix from static functions

4 years agotransfer: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 10:52:41 +0000 (11:52 +0100)] 
transfer: remove Curl_ prefix from static functions

4 years agotftp: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 10:51:50 +0000 (11:51 +0100)] 
tftp: remove Curl_ prefix from static functions

4 years agomulti: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 10:50:43 +0000 (11:50 +0100)] 
multi: remove Curl_ prefix from static functions

4 years agoldap: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 10:47:41 +0000 (11:47 +0100)] 
ldap: remove Curl_ prefix from static functions

4 years agodoh: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 10:46:14 +0000 (11:46 +0100)] 
doh: remove Curl_ prefix from static functions

4 years agoasyn-ares: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 10:43:35 +0000 (11:43 +0100)] 
asyn-ares: remove Curl_ prefix from static functions

4 years agovtls: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 08:26:13 +0000 (09:26 +0100)] 
vtls: remove Curl_ prefix from static functions

4 years agobearssl: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 07:53:40 +0000 (08:53 +0100)] 
bearssl: remove Curl_ prefix from static functions

4 years agombedtls: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 07:45:23 +0000 (08:45 +0100)] 
mbedtls: remove Curl_ prefix from static functions

4 years agowolfssl: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 07:42:36 +0000 (08:42 +0100)] 
wolfssl: remove Curl_ prefix from static functions

4 years agonss: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 07:36:10 +0000 (08:36 +0100)] 
nss: remove Curl_ prefix from static functions

4 years agognutls: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 07:28:10 +0000 (08:28 +0100)] 
gnutls: remove Curl_ prefix from static functions

4 years agoopenssl: remove Curl_ prefix from static functions
Daniel Stenberg [Wed, 13 Jan 2021 07:18:22 +0000 (08:18 +0100)] 
openssl: remove Curl_ prefix from static functions

... as we reserve this prefix to library-wide functions.

Closes #6443

4 years agonss: get the run-time version instead of build-time
Daniel Stenberg [Wed, 13 Jan 2021 15:01:57 +0000 (16:01 +0100)] 
nss: get the run-time version instead of build-time

Closes #6445

4 years agotool_doswin: Restore original console settings on CTRL signal
Jay Satiro [Thu, 19 Nov 2020 21:49:24 +0000 (16:49 -0500)] 
tool_doswin: Restore original console settings on CTRL signal

- Move Windows terminal init code from tool_main to tool_doswin.

- Restore the original console settings on CTRL+C and CTRL+BREAK.

Background: On Windows the curl tool changes the console settings to
enable virtual terminal processing (eg color output) if supported
(ie Win 10). The original settings are restored on exit but prior to
this change were not restored in the case of the CTRL signals.

Windows VT behavior varies depending on console/powershell/terminal;
refer to the discussion in #6226.

Assisted-by: Rich Turner
Closes https://github.com/curl/curl/pull/6226

4 years agogen.pl: fix perl syntax
Daniel Stenberg [Tue, 12 Jan 2021 07:12:13 +0000 (08:12 +0100)] 
gen.pl: fix perl syntax

Follow-up to 324cf1d2e

4 years agohelp: update to current codebase
Emil Engler [Tue, 12 Jan 2021 06:34:52 +0000 (07:34 +0100)] 
help: update to current codebase

This commit bumps the help to the current state of the project.

Closes #6437

4 years agodocs: fix line length bug in gen.pl
Emil Engler [Mon, 11 Jan 2021 19:27:58 +0000 (20:27 +0100)] 
docs: fix line length bug in gen.pl

The script warns if the length of $opt and $desc is > 78. However, these
two variables are on totally separate lines so the check makes no sense.
Also the $bitmask field is totally forgotten. Currently this leads to
two warnings within `--resolve` and `--aws-sigv4`.

Closes #6438

4 years agodocs: fix wrong documentation in help.d
Emil Engler [Mon, 11 Jan 2021 19:12:48 +0000 (20:12 +0100)] 
docs: fix wrong documentation in help.d

curl does not list all categories when you invoke "--help" without any
parameters.

Closes #6436

4 years agoaws-sigv4.d: polish the wording
Daniel Stenberg [Mon, 11 Jan 2021 21:37:41 +0000 (22:37 +0100)] 
aws-sigv4.d: polish the wording

Make it shorter and imperative form

Closes #6439

4 years agomisc: fix typos
Fabian Keil [Thu, 7 Jan 2021 20:11:17 +0000 (21:11 +0100)] 
misc: fix typos

Bug: https://curl.se/mail/lib-2021-01/0063.html
Closes #6434

4 years agomulti_runsingle: bail out early on data->conn == NULL
Daniel Stenberg [Mon, 11 Jan 2021 08:37:44 +0000 (09:37 +0100)] 
multi_runsingle: bail out early on data->conn == NULL

As that's a significant error condition and scan-build warns for NULL
pointer dereferences if we don't.

Closes #6433

4 years agomulti: skip DONE state if there's no connection left for ftp wildcard
Daniel Stenberg [Mon, 11 Jan 2021 09:01:49 +0000 (10:01 +0100)] 
multi: skip DONE state if there's no connection left for ftp wildcard

... to avoid running in that state with data->conn being NULL.

4 years agolibssh2: fix "Value stored to 'readdir_len' is never read"
Daniel Stenberg [Mon, 11 Jan 2021 08:18:30 +0000 (09:18 +0100)] 
libssh2: fix "Value stored to 'readdir_len' is never read"

Detected by scan-build

4 years agoconnect: mark intentional ignores of setsockopt return values
Daniel Stenberg [Sun, 10 Jan 2021 23:13:01 +0000 (00:13 +0100)] 
connect: mark intentional ignores of setsockopt return values

Pointed out by Coverity

Closes #6431