]>
git.ipfire.org Git - thirdparty/sqlite.git/log
drh [Mon, 23 Nov 2020 21:05:29 +0000 (21:05 +0000)]
Syntactic changes to work around a bug in gcov 9.3.0. No changes to the
generated code for release builds.
FossilOrigin-Name:
4f1573b146193e5d552981a9d1d11e50da4da4a843f790e4af1cf0cc19a0b020
drh [Mon, 23 Nov 2020 17:36:06 +0000 (17:36 +0000)]
In os_unix.c, put ALWAYS() on unreachable branches associated with pathname
normalization.
FossilOrigin-Name:
b45a08e3c7edfa76b699d3e29f28daa5bd08039668ec57121e4e85edf36150f1
dan [Mon, 23 Nov 2020 15:30:16 +0000 (15:30 +0000)]
Fix a test script problem causing crash8.test to fail when run with leak-sanitizer.
FossilOrigin-Name:
2c437f7a2c87129d00c71fa569315b68e0ba9514041d93503350c9ae9f080f17
drh [Mon, 23 Nov 2020 14:50:43 +0000 (14:50 +0000)]
Allow "substring()" as an alias for "substr()" for compatibility with other
SQL engines.
FossilOrigin-Name:
aa2ee5754c9f8378c4d490ca756a6415042904477727f0d86e9c0190b5e8b275
dan [Fri, 20 Nov 2020 14:16:41 +0000 (14:16 +0000)]
Add file doc/vdbesort-memory.md, containing notes on the way vdbesort.c uses heap memory.
FossilOrigin-Name:
07f53899a929cce93f17c0332819610c9517c7e54e00092af20efd746cf84438
drh [Thu, 19 Nov 2020 21:12:08 +0000 (21:12 +0000)]
The xFullPathname method of the unix VFS now normalizes the filenames by
omitting surplus "/", "/./" and "/../" strings.
FossilOrigin-Name:
c38dec6f52c01614c1bee8356daf0fcd9f708d029116e9bff51e06719a730dde
drh [Thu, 19 Nov 2020 21:01:11 +0000 (21:01 +0000)]
More test case changes so that shared-cache mode tests all work
with normalized database names.
FossilOrigin-Name:
6f0d5f0949130a4688319adf05d37c5ccd683ca9ad2dacb7ce433a5fe18ac3c3
drh [Thu, 19 Nov 2020 20:07:24 +0000 (20:07 +0000)]
Fix the tkt3793 test case so that work even when filenames are normalized.
FossilOrigin-Name:
e85d32ac6c82d39f5dc9b28f881d5d72f5e5a7e16df12c19315bfa8edea1b0b4
drh [Thu, 19 Nov 2020 19:43:46 +0000 (19:43 +0000)]
Use an ephemeral table rather than a RowSet to remember rowids in the
two-pass UPDATE algorithm, as this uses much less memory for large UPDATEs.
FossilOrigin-Name:
842c432772e6cd8464cdb7bfdb38789adeea9aa9e0486d4034cc9841f085f517
drh [Wed, 18 Nov 2020 23:44:41 +0000 (23:44 +0000)]
If a read() or pread() indicates that the database file is unreadable due to
filesystem damage, then it returns SQLITE_IOERR_CORRUPTFS which is then
converted into SQLITE_CORRUPT before being returned to the application.
FossilOrigin-Name:
849e4e14fd06eda512381f5f8aa65f75ad0a955e835da7c63526a53cf5e8f4dc
drh [Wed, 18 Nov 2020 21:50:05 +0000 (21:50 +0000)]
Improvements to the mechanism that attempts to report SQLITE_CORRUPT if
pread() says that the underlying filesystem is corrupt.
FossilOrigin-Name:
b887c7504e7edeba758f3c1203c6cc56eef499fe05e7e6c6d82939bf7d78c57f
dan [Wed, 18 Nov 2020 20:55:01 +0000 (20:55 +0000)]
Update cksumvfs.c so that if SQLITE_AMALGAMATION is defined, SQLITE_CKSUMVFS_STATIC is implied.
FossilOrigin-Name:
184e9d782dfbad8011b5b0043b3fd8e5a369ed7076e37e14b301483ce5ffe5db
dan [Wed, 18 Nov 2020 18:36:43 +0000 (18:36 +0000)]
Add test infrastructure for cksumvfs. And update cksumvfs so that it works in concert with version 2 VFSs. No changes to core SQLite.
FossilOrigin-Name:
43d4801df5dc4625f6829ed8246758493842b2416ba609ee0423ef63155cece2
dan [Wed, 18 Nov 2020 14:30:53 +0000 (14:30 +0000)]
Fix a problem causing sqlite3_carray_bind() to return an undefined value.
FossilOrigin-Name:
083203a549d3cf26991d8626b308ff1e9e44be6abb72ab3d38e5fd53c99aed7f
dan [Wed, 18 Nov 2020 14:12:20 +0000 (14:12 +0000)]
Update test code to fix a problem with SQLITE_OMIT_VIRTUAL_TABLE builds.
FossilOrigin-Name:
29c779a07bf6ede1ec2cdb4695d801a5c113ab4b12d6cd22bcee8d2adb06891e
drh [Wed, 18 Nov 2020 12:48:48 +0000 (12:48 +0000)]
On unix, for certain error codes of read()/pread() return
SQLITE_IOERR_CORRUPTFS instead of SQLITE_IOERR_READ. And then convert this
error into SQLITE_CORRUPT prior to returning back to the application.
FossilOrigin-Name:
9538ea8447e7b07c05197d6ff2208d3e97b45798736c85b63e8f0c7a3a98c1f3
drh [Tue, 17 Nov 2020 21:26:13 +0000 (21:26 +0000)]
Claw back most of the performance lost in the previous commit.
FossilOrigin-Name:
df8ce2675b070fcdc338918e7652a26ffc90439fe399ceac206fadf8a93a681f
dan [Tue, 17 Nov 2020 21:09:56 +0000 (21:09 +0000)]
Fix trivial memory leaks in the shell and sqldiff programs.
FossilOrigin-Name:
272793e5edc47e431be77d589718a001f2696869e3e15f1371a1890645a995a7
dan [Tue, 17 Nov 2020 18:25:48 +0000 (18:25 +0000)]
Fix test file busy2.test so that it works with the "inmemory_journal" permutation.
FossilOrigin-Name:
b192fdddb63ac56fd6725032af110a069baac52347c0012c130bf34f3cbe69e4
drh [Tue, 17 Nov 2020 14:41:37 +0000 (14:41 +0000)]
Add a single-argument form to the CARRAY table-valued function, with
content bound using the sqlite3_carray_bind() interface that is included
with the extension.
FossilOrigin-Name:
7b229cb1202be203a87b8f47d284313f357deb1e6dfeb94bba7b46744c33512e
drh [Mon, 16 Nov 2020 18:45:21 +0000 (18:45 +0000)]
Enhance the unix VFS so that it removes extra "/", "/./" and "/../" from
the database filename.
FossilOrigin-Name:
7ba89d3e5c68d970ed26c2ec6e6e34bae535c2cc0b22a022d20ac9ff4527b8ab
drh [Sat, 14 Nov 2020 20:03:34 +0000 (20:03 +0000)]
Modify UPDATE so that two-pass updates on a rowid table use an ephemeral
table to store rowids rather than a RowSet. This uses less memory, though
it is slower.
FossilOrigin-Name:
4673096dd8c5ed7aed098ff518a6d01d35c40fad991b89fddd91c19a727a4308
drh [Thu, 12 Nov 2020 18:16:01 +0000 (18:16 +0000)]
Improved diagnostics output with ".wheretrace 0x800". No changes to
non-debug builds.
FossilOrigin-Name:
772ae83c61c87a9004a614d8ec120ba843286bff1edbd20b987fd592ced84d79
drh [Wed, 11 Nov 2020 19:11:44 +0000 (19:11 +0000)]
Fix a typo in a comment. No changes to code.
FossilOrigin-Name:
572f1ed59d29e74f810c74ef9e72ebc94c2d3e04befc03a1f88034f04a9c60a8
drh [Sun, 8 Nov 2020 20:44:30 +0000 (20:44 +0000)]
Use NEVER and ALWAYS macros to confirm that the return value from
sqlite3ExprSkipCollateAndLikely() is never NULL in some of its use cases.
FossilOrigin-Name:
76d2eb86e109fc3cbdba2e8175c22ed7660b59bb9315f6c55c565587f33ad43b
drh [Fri, 6 Nov 2020 16:48:55 +0000 (16:48 +0000)]
Add ALWAYS() to conditionals associated with SHM locking that are always true.
FossilOrigin-Name:
b599e89076d60afede7d2b3503b9338ca863d0c2d25799afe4080a6186386ea9
drh [Thu, 5 Nov 2020 19:13:44 +0000 (19:13 +0000)]
Suppress errors associated with TEMP triggers that reference objects in
non-TEMP databases. This is a continuation of the fix for ticket #3810
shown in check-in [
ba1afc040171810d ]
from [/timeline?c=trunk:
200908061743 |2009-08-06], based on a bug report in
[forum:/forumpost/
157dc791df |forum post
157dc791df ]
FossilOrigin-Name:
991ca9b26bacd8f6b64498057fe28f2068466a220f372fd365b6685f583f0e92
drh [Thu, 5 Nov 2020 14:50:21 +0000 (14:50 +0000)]
drh [Mon, 2 Nov 2020 00:40:05 +0000 (00:40 +0000)]
Fix an another OSS-Fuzz discovered assertion fault due to ALTER TABLE and
strange triggers.
FossilOrigin-Name:
6646d7898ca1d2f71ec906d9613fbfc5c59c6cf05f053529e6e32ab826d1cb78
drh [Sat, 31 Oct 2020 18:58:37 +0000 (18:58 +0000)]
Add the -tabs command-line option to the CLI.
FossilOrigin-Name:
7d01e84dc49074e6364267eea9fd20d46a457d2498121a0f218fbf482692392d
dan [Sat, 31 Oct 2020 16:33:01 +0000 (16:33 +0000)]
Update the ALTER TABLE command to correctly handle UPDATE ... FROM statements within trigger programs.
FossilOrigin-Name:
3e6af890406b58da1c4aebec4d483be7ab0fdb589ef7a4c4e987d6bde18d6b97
drh [Mon, 26 Oct 2020 18:14:12 +0000 (18:14 +0000)]
Always create a statement journal when using the OP_ParseSchema opcode,
as you never know when it might fail. See the discussion on
[forum:/forumpost/
daa2c728cc |forum post
daa2c728cc ].
FossilOrigin-Name:
aa512f72cf5adfece6299db17bd122aeff0cdee2a25f83f60e2ebb05e99c9591
dan [Mon, 26 Oct 2020 16:22:31 +0000 (16:22 +0000)]
Ensure that the table argument passed to Tcl_GetIndexFromObjStruct() in the sessions module test code is declared "static".
FossilOrigin-Name:
80eba105d6d1b49ba8ca2ad4e14ddec2de0bdc2f6686c2f8a1c1d24fc1fe846f
dan [Mon, 26 Oct 2020 13:24:36 +0000 (13:24 +0000)]
Prevent fts5 tokenizer unicode61 from considering '\0' to be a token characters, even if other characters of class "Cc" are.
FossilOrigin-Name:
b7b7bde9b7a03665e3691c6d51118965f216d2dfb1617f138b9f9e60e418ed2f
drh [Thu, 22 Oct 2020 18:50:30 +0000 (18:50 +0000)]
Minor tweaks to query planning weights so that when STAT4 is enabled
and functioning, a full table scan is more likely to be selected if
that seems like the fastest solution. Only do this when STAT4 info
is available because an error has a large potential downside.
FossilOrigin-Name:
0e7e113d9f2c929c1f8a85e2cfad8e2e60f0e8770212b5e5320fb2a2c42911f8
drh [Thu, 22 Oct 2020 18:16:17 +0000 (18:16 +0000)]
drh [Thu, 22 Oct 2020 15:47:48 +0000 (15:47 +0000)]
Sometimes it makes sense to do a full table scan rather than try to use
an index when most of the rows will be selected. This branch is trying to
tune the query planner to make that happen more often.
FossilOrigin-Name:
0f42099ad65855c94af8472f3a6fddac7fc2a82e8fdfcc06a298eb6683a28688
drh [Tue, 20 Oct 2020 14:40:53 +0000 (14:40 +0000)]
Fix the sqlite3_hard_heap_limit() so that it works with sqlite3_realloc64()
in addition to sqlite3_malloc64(). Improvements to OOM processing and
debugging aids in the fuzzcheck utility.
FossilOrigin-Name:
602d7369166d406a26834aa47d71d565a17d377d32e41f308821a50b41f91896
drh [Tue, 20 Oct 2020 12:37:51 +0000 (12:37 +0000)]
Fix an assert() inside of debug-only code that can fail following an OOM.
FossilOrigin-Name:
79da254f41a0d7d5fdc57f0cc40b3560bfcf7f79eed24a9fada1b6b4ca3adb5a
drh [Mon, 19 Oct 2020 20:49:54 +0000 (20:49 +0000)]
Fix an incorrect table ref-count in the new recursive CTE logic that might
result in a reference to freed memory following a syntax error.
FossilOrigin-Name:
75a0288871ccb2a69a636cbb328fe19045a0d0ef96a193ecd118b9a196784d2d
drh [Mon, 19 Oct 2020 12:35:08 +0000 (12:35 +0000)]
Enhance recursive common table expressions to support two or more
recursive terms.
FossilOrigin-Name:
77e64647ec429c6e0d884abbd00dabebe738f89544a4984d6fd7a702b928ccfd
drh [Mon, 19 Oct 2020 01:44:43 +0000 (01:44 +0000)]
New test cases for recursive CTEs with multiple recursive terms.
FossilOrigin-Name:
cd5182bd6f5969ba0812275f471224908296960358013327cebbe0c52b820f04
drh [Mon, 19 Oct 2020 01:23:48 +0000 (01:23 +0000)]
Allow multiple recursive terms in the compound SELECT of a recursive CTE.
This facilitates writing a query to find find the connected components of
an undirected graph.
FossilOrigin-Name:
5481fa8c79c34f434e99ab633ff3d0942a309a74fb0cf38e3d3617b51d5d21dd
mistachkin [Sun, 18 Oct 2020 18:35:34 +0000 (18:35 +0000)]
drh [Sat, 17 Oct 2020 22:13:16 +0000 (22:13 +0000)]
Fix the SQLITE_DESERIALIZE_FREEONCLOSE flag so that it works as it is
documented to work.
See [forum:/forumpost/
ba1dff667a |forum post
ba1dff667a ]
FossilOrigin-Name:
d6fac8a1d3efeb2c4f03dae437b5b314765c93770a70603803a8039291dbcabb
drh [Sat, 17 Oct 2020 19:09:04 +0000 (19:09 +0000)]
Fix an incorrect printf() in debugging logic in where.c.
Problem reported [forum:/info/
80a9c47769772207 |by forum post
80a9c47769772207 ].
FossilOrigin-Name:
883da4dadc88809192e4ed2f753f8883471fb43aa330bc58b017c66e1acedc6c
drh [Thu, 15 Oct 2020 17:59:38 +0000 (17:59 +0000)]
Minor fixes to the cksumvfs documentation in the header comment of the source
file. Enhance speedtest1.c so that it can more easily do performance
comparisons of cksumvfs.
FossilOrigin-Name:
ed3bb818f58b75c087f2875331ec944397b6c61a5b14d8af4b9ec6f376bd1872
drh [Thu, 15 Oct 2020 14:37:27 +0000 (14:37 +0000)]
The windows VFS accepts query parameter "exclusive=true" to cause it to
take a mandatory file lock, preventing other applications from even
reading the file.
FossilOrigin-Name:
05b573fdb27abec7d75aa1375325d45043cfd674f5b346fb341f001d7e04d160
mistachkin [Wed, 14 Oct 2020 21:31:20 +0000 (21:31 +0000)]
mistachkin [Wed, 14 Oct 2020 21:30:56 +0000 (21:30 +0000)]
drh [Wed, 14 Oct 2020 15:46:29 +0000 (15:46 +0000)]
Enhanced documentation for sqlite3_vtab_nochange() to make it clear that
it is an optimization and that virtual table implementations should be
prepared for it to always return false.
FossilOrigin-Name:
3e2643619d122616663688533977d6c60d45a269b4e2bdc330fd3ee5d39f2e03
dan [Mon, 12 Oct 2020 18:09:16 +0000 (18:09 +0000)]
Fix some fts5 problems with signed integer overflow causing segfaults in -ftrapv builds.
FossilOrigin-Name:
7e17c2f4b7dc9b563d0b4da949bb134dc7c4fc9c86ce03891432a884ca6409d5
drh [Mon, 12 Oct 2020 17:57:29 +0000 (17:57 +0000)]
Improved quoting of the table name argument for the ".import" command
of the CLI. See [forum:
34591fefbe |forum post
34591fefbe ].
FossilOrigin-Name:
ce97b56d63d6e03b909e049a0a62251d98c7bf643448193a28b42a5871899387
drh [Mon, 12 Oct 2020 16:54:28 +0000 (16:54 +0000)]
Add options --data-only and --nosys to the ".dump" command in the CLI.
FossilOrigin-Name:
57123b14a71027c21cb5eee089fcbc9330d07bf9091b01aecc4f9e3b9e4f7b09
dan [Mon, 12 Oct 2020 15:27:50 +0000 (15:27 +0000)]
Fix ALTER TABLE so that it can run even if the schema contains unknown collation sequences.
FossilOrigin-Name:
bc4bb9433fed519386511796cce475d74100b8ed707cdbffd8cbdf683b0faf35
drh [Mon, 12 Oct 2020 14:56:47 +0000 (14:56 +0000)]
Add the --nosys option to the .schema command in the CLI.
FossilOrigin-Name:
b72ee694532c0c5d2285dd580154546eb592fd6892cad9ad7a49e98737adb974
dan [Mon, 12 Oct 2020 14:29:11 +0000 (14:29 +0000)]
Fix UPDATE FROM statements on virtual tables that are declared WITHOUT ROWID.
FossilOrigin-Name:
bcb0bc6a7b7006f07adb7266b1fecca39bf85a0adea6d78a341623a3546f2c2a
drh [Mon, 12 Oct 2020 13:24:00 +0000 (13:24 +0000)]
Fix BEGIN IMMEDIATE and BEGIN EXCLUSIVE so that they work even if one or
more of the database files in the connection are read-only. Test cases
for this are in TH3.
FossilOrigin-Name:
2fa08c3963f008d4723c3f4f4496abcb6d4b575c85ba4a911a6aed5730b5948b
drh [Wed, 7 Oct 2020 11:24:45 +0000 (11:24 +0000)]
In the CSV extension, use SQLITE_TRANSIENT rather than SQLITE_STATIC on
return values that can in fact change.
FossilOrigin-Name:
54b54f02c66c5aeaa3504c52a04614e2fb4d7260da8367840d5ea5a71cdc2fda
dan [Mon, 5 Oct 2020 16:41:56 +0000 (16:41 +0000)]
Allow fts5 trigram tables created with detail=column or detail=none to optimize LIKE and GLOB queries. Allow case-insensitive tables to optimize GLOB as well as LIKE.
FossilOrigin-Name:
64782463be62b72b5cd0bfaa7c9b69aa487d807c5fe0e65a272080b7739fd21b
dan [Sat, 3 Oct 2020 19:16:36 +0000 (19:16 +0000)]
Do not apply affinities when creating entries for automatic indexes on views. Fix for [
95302bdb ].
FossilOrigin-Name:
df12f097224ebc9473d9e2a8933bd7efed6490d09af2c012c9b59a7892369b7f
dan [Sat, 3 Oct 2020 17:06:02 +0000 (17:06 +0000)]
Fix a segfault caused by running "column LIKE NULL" against an fts5 table using the trigram tokenizer. Fix for [
e33ee62575fc22 ].
FossilOrigin-Name:
6e72a08de764077f2bba6f7e3b99ea29001941671a971f2ccf7ceeb9c682fb1a
dan [Sat, 3 Oct 2020 14:36:06 +0000 (14:36 +0000)]
FTS5 does not handle tokens that contain embedded nul characters. Prevent the trigram tokenizer from returning such tokens. Fix for [
2ba5930b2 ].
FossilOrigin-Name:
b1d048748c054575425a4bebf0c5d09962f9329d5ce6a978cf54e508b238584c
dan [Fri, 2 Oct 2020 15:15:18 +0000 (15:15 +0000)]
Fix some test code so that testfixture can build with SQLITE_OMIT_WAL defined.
FossilOrigin-Name:
dd009cd7aec3598e930806907601f4f0f9b0021ea99fa6c5e29e88f1246066ed
drh [Fri, 2 Oct 2020 13:48:57 +0000 (13:48 +0000)]
Additional corner-case fixes for the in-scan-vs-index or OP_SeekScan
optimization.
FossilOrigin-Name:
ad5ab24ebd557e7af1d92ab3fbcb3747c04da5ad4ed779fb6391dc94042687dd
drh [Fri, 2 Oct 2020 12:49:06 +0000 (12:49 +0000)]
Remove an incorrect assert() from the OP_SeekScan opcode.
FossilOrigin-Name:
c0400f8c0bcb85ba39004feff753eae2f8e82065539e52b5788febd7644c417b
drh [Fri, 2 Oct 2020 12:42:51 +0000 (12:42 +0000)]
Fix a faulty assert() statement. Add new test cases.
FossilOrigin-Name:
80ecdb3da4558bb08ee3ec6edbde906ad5b3b8182e672b5ba0d5dfa8041cee0a
drh [Fri, 2 Oct 2020 11:55:07 +0000 (11:55 +0000)]
For the OP_SeekScan optimization, the OP_IdxGT does not necessarily come
right after the OP_SeekGE. So use the P2 operand of OP_SeekScan to point
to the first instruction after OP_IdxGT. Problem found by dbsqlfuzz.
FossilOrigin-Name:
091d71939411bf2079098f09ddc0525f11f380119fd27114e2b3eec9a8ac0db4
drh [Fri, 2 Oct 2020 02:02:18 +0000 (02:02 +0000)]
Disable the OP_SeekScan opcode of the in-scan-vs-index optimization when
in PRAGMA reverse_unordered_selects mode, as the OP_SeekScan only works
with forwards scans. Thanks to OSSFuzz for pointing out the problem to
us.
FossilOrigin-Name:
c75c3a3b756635bfdab44e4b56a337e4a88af3a8803cd3e9a67abf3d0d3450dc
dan [Thu, 1 Oct 2020 17:24:36 +0000 (17:24 +0000)]
Add experimental "trigram" tokenizer to fts5.
FossilOrigin-Name:
c4e8ec7907de7cb9e610ef9f4930caf5c046618151fb4f61d5716b9fa3f31423
dan [Thu, 1 Oct 2020 17:15:12 +0000 (17:15 +0000)]
Add the -trigram option to the fts5txt2db.tcl script.
FossilOrigin-Name:
a394dd260252e7b7dcbc90fd321dfd40d9375f0598ea52b01001c568cbdbafce
dan [Thu, 1 Oct 2020 16:10:22 +0000 (16:10 +0000)]
Add tests for the trigram tokenizer. Fix minor issues.
FossilOrigin-Name:
897ced99b44085012aa44d3264940dcbd4c77b295a894a1b58fb2c03a0f7fee8
drh [Thu, 1 Oct 2020 15:46:21 +0000 (15:46 +0000)]
Fix the OP_SeekScan opcode so that its variable names do not cause problems
for the test/vdbe-compress.tcl script.
FossilOrigin-Name:
7a78274a072324b94d6f79e5b7a198b2fa9321ff5d6a528b51f57d3ee95c765b
drh [Thu, 1 Oct 2020 14:38:39 +0000 (14:38 +0000)]
Remove a debugging printf() accidentally left in the previous check-in.
FossilOrigin-Name:
e9d1efa597fb073dc4bc4286e03059a350ed05d3e6476cd3247e6cde626f458b
drh [Thu, 1 Oct 2020 14:36:15 +0000 (14:36 +0000)]
The IN-early-out optimization does not work for virtual tables. Do
not try to use it there. Fix for ticket [
2d5a3163563d559f ]. Test
cases in TH3.
FossilOrigin-Name:
dbec6910d9648f4907373c818a5cb347a2e487784208751ccecfacca752ff99d
dan [Wed, 30 Sep 2020 20:35:37 +0000 (20:35 +0000)]
Add experimental unicode-aware trigram tokenizer to fts5. And support for LIKE and GLOB optimizations for fts5 tables that use said tokenizer.
FossilOrigin-Name:
0d7810c1aea93c0a3da1ccc4911dbce8a1b6e1dbfe1ab7e800289a0c783b5985
drh [Wed, 30 Sep 2020 18:06:51 +0000 (18:06 +0000)]
Improved query optimization for multi-column indexes where the second or
later columns are constrained by an IN operator and the earlier index columns
limit the search to a small number of rows. Use the new OP_SeekScan opcode
which does scanning of the relevant range of the index but gives up and
falls back to doing a seek if the number of rows scanned grows to large,
in order to guard against pathological cases where the estimated number
of rows to be scanned is far too small.
FossilOrigin-Name:
4a43430fd23f88352c33b29c4c105b72f6dc821f94bf362040c41a1648c402e5
drh [Wed, 30 Sep 2020 18:03:22 +0000 (18:03 +0000)]
For the OP_SeekScan opcode, adjust the number of steps run before giving
up based on the estimated number of comparisons needed to perform a seek.
FossilOrigin-Name:
dc4172e6b8e1f62dc7329a3adb2223f290bc4c8055c265e88182ef432f4bcf10
drh [Wed, 30 Sep 2020 17:32:22 +0000 (17:32 +0000)]
Back out the incorrect optimization of check-in [
e51ecadcbdef5ce6 ] as
ticket [
5c4e7aa793943803 ] reports a case where the optimization does not
work.
FossilOrigin-Name:
7395e96b8cc370c8ac2657fb805915b0992a15d80f8bf256d277b423fec64675
drh [Wed, 30 Sep 2020 15:36:03 +0000 (15:36 +0000)]
In the query flattener when substituting expression Y in place of expression X,
if X is marked has having come from an ON or USING clause of a LEFT JOIN, then
be sure that all subexpressions of Y, not just the root node of Y, are
similarly marked. Otherwise, if Y is an AND operator, it will be split up
during WHERE clause analysis and the subexpressions will not get the special
treatment needed by LEFT JOIN ON/USING clauses.
Fix for ticket [
66e4b0e271c47145 ].
FossilOrigin-Name:
69f9eb7343a416c5ab426c8e1b9f0ae576544b4ccc5d87f5481c8ff884f696e1
shearer [Wed, 30 Sep 2020 09:17:53 +0000 (09:17 +0000)]
drh [Wed, 30 Sep 2020 00:48:45 +0000 (00:48 +0000)]
Add an sqlite3FaultSim() call to btreeNext() to make it easier to
simulate I/O errors in calls to sqlite3BtreeNext(), and in OP_SeekScan.
FossilOrigin-Name:
29cca775d3f5411624f0a8d55d34a038a24f1009d25b097315adb64e70c4b299
drh [Wed, 30 Sep 2020 00:10:22 +0000 (00:10 +0000)]
In the OP_SeekScan opcode, changes to pOp must occur after the call
to VdbeBranchTaken() so that the VdbeBranchTaken() attributes the branch
to the correct opcode.
FossilOrigin-Name:
61fbe7aa7cc0e8fe3e6b1c5aec277183d8cd7c86b1e835c38e0b37a9b8063343
drh [Tue, 29 Sep 2020 23:52:25 +0000 (23:52 +0000)]
The OP_SeekScan opcode is a no-op if the cursor is not pointing to a valid
row upon entry.
FossilOrigin-Name:
4afc96b5fe80bd192a23e0230edc207e641931c3bf48296b1a385c786386f1b7
drh [Tue, 29 Sep 2020 20:22:19 +0000 (20:22 +0000)]
Coverage testing of the OP_SeekScan opcode. Fix a problem that comes up when
OP_SeekScan reaches the end of the table.
FossilOrigin-Name:
9e57e758a6a33f54d28a546b4eebfb5cfacef30dc4e0207e43bb9d2c06fc3439
drh [Tue, 29 Sep 2020 17:29:11 +0000 (17:29 +0000)]
Improved comments on the new OP_SeekScan opcode.
FossilOrigin-Name:
6110fdd5bb7b4ae5c065404c802ae726362ef084966b73cffe58c4bfb98689d2
drh [Tue, 29 Sep 2020 16:05:09 +0000 (16:05 +0000)]
Improved performance by manually in-lining the sqlite3VdbeIdxKeyCompare()
routine for the OP_IdxGT opcode and its kin.
FossilOrigin-Name:
2206a2c848a122ee220c89427f9be0460cba0706f58852139d7b37184ce29a29
drh [Tue, 29 Sep 2020 15:32:54 +0000 (15:32 +0000)]
Typo fix to repair the early-out optimization. Also avoid unnecessary
OP_SeekHit opcodes.
FossilOrigin-Name:
8fd7d8dfcd515aa6b65d6eb27b033d3b3a31db467b9100cc13c62bc60113019e
drh [Tue, 29 Sep 2020 01:48:46 +0000 (01:48 +0000)]
The OP_SeekScan opcode works, but using it requires disabling the
IN-earlyout optimization because the OP_IfNoHope opcode might move the
cursor.
FossilOrigin-Name:
f3c36b840c9a29c0add28039db216f4207a308e5057fc76e3f0004024a8267ac
drh [Mon, 28 Sep 2020 19:51:54 +0000 (19:51 +0000)]
Revisiting the IN-scan optimization to try to fix it for the corner case
where the statistics deceive the query planner into using a scan when
an indexed lookup would be better. This check-in changes the code
generation to do the IN-scan using a new OP_SeekScan opcode. That new
opcode is designed to abandon the scan and fall back to a seek if
it doesn't find a match quickly enough. For this work-in-progress check-in,
OP_SeekScan is still a no-op and OP_SeekGE still ends up doing all the work.
FossilOrigin-Name:
d720b6981eeb0ffdb14494ca63eca298ee724ae4ad4863c7c7cbfdad7fa52519
drh [Mon, 28 Sep 2020 15:49:43 +0000 (15:49 +0000)]
Small performance improvement and size reduction by reducing the size of
the WhereTerm object.
FossilOrigin-Name:
43f7ddad800acf40917c5cc3d926640dbec17c34d5f1cbbb74bd80f44eeed0a5
drh [Mon, 28 Sep 2020 13:34:05 +0000 (13:34 +0000)]
Avoid the possibility of integer overflow on the --pagecache option to
the CLI. See [forum:
10a2892377 |forum post
10a2892377 ]
FossilOrigin-Name:
d3d13df31a97648f952beb2e1a783f947a80ec843227985ad9ebd14452d2f654
mistachkin [Mon, 21 Sep 2020 20:18:44 +0000 (20:18 +0000)]
Fix harmless compiler warning seen with MSVC.
FossilOrigin-Name:
4591ee03d7a1ef3f0f6ad0629493fdb7a1c0ddb3277a9e87aa244cb0ca770593
dan [Mon, 21 Sep 2020 14:53:21 +0000 (14:53 +0000)]
In fts5 integrity checks, do not compare the contents of the index against an external content table unless specifically requested.
FossilOrigin-Name:
782163693f37aeb65209bebbaeb6659a36881b8c4b4bec778b366658488bf966
drh [Sun, 20 Sep 2020 13:33:28 +0000 (13:33 +0000)]
Remove a new assert() that the compiler finds is always true at compile-time,
to avoid a compiler warning.
FossilOrigin-Name:
8bbaee238593741da107b92b254cb5f0cf8b6bcc760bf2b25d20e46c8edee2a9
drh [Sun, 20 Sep 2020 12:10:28 +0000 (12:10 +0000)]
Attempt to silence harmless static analyzer warnings in Lemon and in the
Lemon-generated parser.
FossilOrigin-Name:
de8ce22a46c90afa5475cd24c28b7a82b26410dc72d662af2f9d9e5e528e0eec
dan [Thu, 17 Sep 2020 21:11:25 +0000 (21:11 +0000)]
Fix a typo in the documentation comment for sqlite3_preupdate_hook().
FossilOrigin-Name:
4542d194e2fef5e21e1c3679914bd9e21fab31cfb111cf640524fb3514a8afa3
dan [Thu, 17 Sep 2020 17:01:16 +0000 (17:01 +0000)]
Fix a problem in sqlite-expert causing it to ignore equality constraints on the second or subsequent columns of a multi-column PRIMARY KEY.
FossilOrigin-Name:
c666c85a433fbc83edef4dbfb0399672e570f5d7979ab61cb39ff5488595d822
dan [Thu, 17 Sep 2020 15:16:50 +0000 (15:16 +0000)]
Fix a problem in fts5 causing the in-memory hash table to be flushed more often than necessary.
FossilOrigin-Name:
9a55601d072bcd1ac0f6f1633216c7c8b3ff3e037451e2cfd285cbe19b60b9fc
dan [Thu, 17 Sep 2020 14:16:02 +0000 (14:16 +0000)]
Fix a "jump depends on unitialized value" valgrind/asan error in fts5.
FossilOrigin-Name:
66f94d623c16b4527e42f0519e32ec78eaf9ee6fd61ee7d0eb657cc59a8f7d68