]> git.ipfire.org Git - thirdparty/dracut.git/log
thirdparty/dracut.git
4 years agofix(base): tr needs to be installed
Andre Russ [Tue, 24 Aug 2021 21:38:41 +0000 (21:38 +0000)] 
fix(base): tr needs to be installed

4 years agofix(crypt-gpg): tr needs to be installed
Andre Russ [Tue, 24 Aug 2021 21:38:14 +0000 (21:38 +0000)] 
fix(crypt-gpg): tr needs to be installed

4 years agofix(nvmf): validate_ip_conn
Charles Rose [Mon, 23 Aug 2021 14:14:16 +0000 (09:14 -0500)] 
fix(nvmf): validate_ip_conn

Fix how ifname for a given local_address is found.
Fix logic to detect presence of ifname and route.

Signed-off-by: Charles Rose <charles.rose@dell.com>
4 years agofix(usrmount): do not empty _dev variable
Alexander Tsoy [Mon, 16 Aug 2021 15:54:34 +0000 (18:54 +0300)] 
fix(usrmount): do not empty _dev variable

Currently $_dev is always overridden with the value returned by
label_uuid_to_dev(). This results in an empty value if $_dev is a
device path. Fix this by calling label_uuid_to_dev() conditionally.

Bug: https://bugs.gentoo.org/807971
Fixes: d3532978de04c78f53664dad7b37705a49a7ee54
4 years agofix(iscsi): add support for the new iscsiadm "no-wait" (-W) command
Thomas Blume [Thu, 1 Jul 2021 08:36:09 +0000 (10:36 +0200)] 
fix(iscsi): add support for the new iscsiadm "no-wait" (-W) command

remove connection timeout for iscsi firmware targets serving system root

4 years agofix(kernel-modules): detect block device's hardware driver
Pingfan Liu [Wed, 28 Jul 2021 10:13:43 +0000 (18:13 +0800)] 
fix(kernel-modules): detect block device's hardware driver

On hostonly mode, the platform driver is not copied blindless. There
should be a way to detect the real hardware driver, which probes a block
device.

/sys/dev/block/major:minor is a symbol link, which points to the real
device, recording the hardware stack. And those info can help to
identify the associated drivers for the hardware stack.

Signed-off-by: Pingfan Liu <piliu@redhat.com>
---
v2 -> v3:
  address shellcheck in dracut-functions.sh
v1 -> v2:
  remove local variable _extra_mod
  shorten subject

4 years agofix(kernel-modules): add blk_mq_alloc_disk and blk_cleanup_disk to blockfuncs
Lukas Nykryn [Thu, 12 Aug 2021 09:46:35 +0000 (11:46 +0200)] 
fix(kernel-modules): add blk_mq_alloc_disk and blk_cleanup_disk to blockfuncs

Since kernel 5-14 those are used by many drivers for example:
xen-blkfront, loop, nbd, pd

4 years agofix(network-manager): write DHCP filename option to dhcpopts file
Beniamino Galvani [Mon, 9 Aug 2021 07:01:32 +0000 (09:01 +0200)] 
fix(network-manager): write DHCP filename option to dhcpopts file

Anaconda parses the 'filename' variable [1] set in /tmp/net.$netif.dhcpopts to
determine the name of the kickstart file to use.

[1] https://github.com/rhinstaller/anaconda/blob/anaconda-35.21-1/dracut/fetch-kickstart-net.sh#L31-L34

4 years agofix(install): use size_t to avoid -Wsign-compare warning
Shreenidhi Shedi [Mon, 9 Aug 2021 04:58:06 +0000 (10:28 +0530)] 
fix(install): use size_t to avoid -Wsign-compare warning

Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
4 years agofix(install): improve gettid definition
Shreenidhi Shedi [Mon, 9 Aug 2021 04:55:35 +0000 (10:25 +0530)] 
fix(install): improve gettid definition

Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
4 years agofix(install): validate return values log.c
Shreenidhi Shedi [Sun, 8 Aug 2021 18:56:23 +0000 (00:26 +0530)] 
fix(install): validate return values log.c

Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
4 years agofix(install): rectify unused function args in log.c
Shreenidhi Shedi [Sun, 8 Aug 2021 18:51:10 +0000 (00:21 +0530)] 
fix(install): rectify unused function args in log.c

Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
4 years agofix(install): use wrapper for asprintf
Shreenidhi Shedi [Sun, 8 Aug 2021 18:23:13 +0000 (23:53 +0530)] 
fix(install): use wrapper for asprintf

Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
4 years agofix(squash): apply FIPS and libpthread workaround
Kairui Song [Mon, 9 Aug 2021 10:23:43 +0000 (18:23 +0800)] 
fix(squash): apply FIPS and libpthread workaround

There are some workarounds in dracut.sh for FIPS/libpthread covering
some hidden lib dependency issues. These workarounds didn't take effect
for the squash loader since the squash loader is installed
independently. So apply these workarounds again.

Also skip the lib detection code, since these extra installed libs
are small, and squash loader contents are dropped after switch root,
won't be an issue to be always installed. And this makes the code
cleaner.

Signed-off-by: Kairui Song <kasong@redhat.com>
4 years agofix(cms): reload NetworkManager connections
Beniamino Galvani [Wed, 4 Aug 2021 07:37:31 +0000 (09:37 +0200)] 
fix(cms): reload NetworkManager connections

When NetworkManager is running as systemd service, it's not enough to write
connection files; the module should also tell NetworkManager to reload the
connections from disk so that any new connection can be auto-activated.

https://bugzilla.redhat.com/show_bug.cgi?id=1975929

4 years agofix(network-manager): check for nm-initrd-generator in both /usr/{libexec,lib}
Beniamino Galvani [Mon, 9 Aug 2021 07:28:46 +0000 (09:28 +0200)] 
fix(network-manager): check for nm-initrd-generator in both /usr/{libexec,lib}

Sice commit 22d6863ef1b2 ("fix(network-manager): cope with distributions not
using `libexec`") nm-initrd-generator can be installed in either /usr/libexec
or /usr/lib. Change other modules to check for the binary in both locations.

4 years agofix(install): use unsigned int instead of unsigned
Shreenidhi Shedi [Mon, 19 Jul 2021 16:00:06 +0000 (21:30 +0530)] 
fix(install): use unsigned int instead of unsigned

Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
4 years agofix(install): reduce cppcheck warnings
Shreenidhi Shedi [Mon, 19 Jul 2021 15:57:41 +0000 (21:27 +0530)] 
fix(install): reduce cppcheck warnings

Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
4 years agofix(network-manager): ensure safe content of /tmp/dhclient."$ifname".dhcpopts
Thomas Haller [Tue, 27 Jul 2021 14:04:58 +0000 (16:04 +0200)] 
fix(network-manager): ensure safe content of /tmp/dhclient."$ifname".dhcpopts

NetworkManager leaves state files behind in "/run/NetworkManager/devices".
These files are in keyfile format (glib's GKeyFile API [1]).

From the statefile, the dracut module writes a .dhcpopts file. And other users
want to parse that file, for example anaconda ([2]). To be fair,
anaconda seems to parse a different file, so I am a bit confused who
uses this file how. In any case, it seems somebody might be tempted to
execute this as a script.

We need to write the .dhcpopts file in a format that is defined and easy
to handle from a shell script. As already previously, this format is
a bash script that sets certain variables. That means, to load the file,
the user could execute it as bash script. But this is dangerous, as the
file contains potentially untrusted data from the network.
Optimally, users still don't trust the .dhcpopts file to be safe for
executing! It would be better if users too try to parse the file
instead of executing it. That is not trivial however because in face
of special characters, as we use bash's `printf '%q'` to escape the values
and parsing bash escaping is not trivial.

Anyway, make sure we properly quote and handle the content so that also
executing is safe. In the best case, there are no special characters
that require escaping, and naive parsing can be done with `sed`.
Otherwise, executing is now also supposed to be safe.

In this case we parse DHCP options from the state file. They are themselves
backslash escaped UTF-8 strings (C escape sequences), which then are stored
via keyfile API. The properly parse them, we would first need to load the file
with GKeyFile (which undoes one level of backslash escaping) and then
use g_str_compress() (to undo the second level). We mimic that with
shell.

[1] https://github.com/rhinstaller/anaconda/blob/b3411d6780aa0d76ee1e81a38710ec05a2d1978b/dracut/fetch-kickstart-net.sh#L30
[2] https://developer.gnome.org/glib/stable/glib-Key-value-file-parser.html

Signed-off-by: Thomas Haller <thaller@redhat.com>
4 years agodocs: add a note about other network modules in 'man dracut.cmdline'
Beniamino Galvani [Thu, 8 Jul 2021 09:16:46 +0000 (11:16 +0200)] 
docs: add a note about other network modules in 'man dracut.cmdline'

4 years agofix(integrity): add support for loading multiple EVM x509 certs
Stefan Berger [Fri, 18 Jun 2021 17:26:29 +0000 (13:26 -0400)] 
fix(integrity): add support for loading multiple EVM x509 certs

Add support for loading EVM x509 certs from a directory that the user can
specify with the EVMKEYSDIR variable in the evm config file. By default
the additional certs are loaded from /etc/keys/evm.

Support for multiple EVM keys allows the usage in a system of files with
signed metadata from multiple parties.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
4 years agofix(base): do not quote $initargs for switch_root
Mike Gilbert [Fri, 23 Jul 2021 18:35:07 +0000 (14:35 -0400)] 
fix(base): do not quote $initargs for switch_root

We want word splitting to occur so that the arguments are passed
separately, and we don't end up passing an empty string if no arguments
are specified.

Bug: https://bugs.gentoo.org/803548
Fixes: 2fabaaa62dcfd31e593ca45e1374e55adae29d6b
4 years agofix(squash): remove tailing '/' when installing ld.so.conf.d
Kairui Song [Fri, 30 Jul 2021 13:54:11 +0000 (21:54 +0800)] 
fix(squash): remove tailing '/' when installing ld.so.conf.d

This tailing '/' will result in following error:

dracut-install: ERROR: installing '/etc/ld.so.conf.d/'
dracut: FAILED: /usr/lib/dracut/dracut-install -D /var/tmp/dracut.kEFQLs/initramfs -d /etc/ld.so.conf.d/

Signed-off-by: Kairui Song <kasong@redhat.com>
4 years agofix(network-manager): include nm-daemon-helper binary
Beniamino Galvani [Tue, 3 Aug 2021 14:10:14 +0000 (16:10 +0200)] 
fix(network-manager): include nm-daemon-helper binary

Since version 1.32, NetworkManager launches a tiny external helper to determine
the hostname via reverse DNS resolution through glibc's nss-dns. Include the
binary.

4 years agofix(base): repair installing dracut-util
Zoltán Böszörményi [Wed, 14 Jul 2021 12:29:55 +0000 (14:29 +0200)] 
fix(base): repair installing dracut-util

inst_binary uses ${dracutsysrootdir} internally to find the source
file.

Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
4 years agofix(kernel-modules): add more modules on RISC-V
Andreas Schwab [Sat, 12 Jun 2021 14:09:00 +0000 (16:09 +0200)] 
fix(kernel-modules): add more modules on RISC-V

Include the same extra modules for ARM also on RISC-V and add drivers/mmc/host
and drivers/spi to the list.

4 years agofix(dracut-systemd): do not use Requires for vconsole-setup.service
Zbigniew Jędrzejewski-Szmek [Tue, 20 Jul 2021 10:18:27 +0000 (12:18 +0200)] 
fix(dracut-systemd): do not use Requires for vconsole-setup.service

systemd-vconsole-setup.service may fail if the user specifies a missing keymap,
see [1,2,3], or font. This is unfortunate, but the system should not refuse
boot. It is better to continue, possible without the desired font or keymap.
All other systemd services that depend on systemd-vconsole-setup.service do so
without a hard Requires=.

(In particular, systemd-vconsole-setup internally will try to do as much setup
as possible, and will load the font even if it cannot load the keymap and vice
versa.)

[1] https://fedoraproject.org/wiki/Common_F34_bugs#kbd-legacy-media
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1955162
[3] https://bugzilla.redhat.com/show_bug.cgi?id=1955793

4 years agofix(squash): keep ld cache under initdir
Pingfan Liu [Fri, 9 Jul 2021 03:55:16 +0000 (11:55 +0800)] 
fix(squash): keep ld cache under initdir

When running kdump on PowerPC, the following bug is hit:
[    0.391629] Freeing unused kernel memory: 5568K
[    0.391634] This architecture does not have kernel memory protection.
/bin/sh: error while loading shared libraries: libc.so.6: cannot open shared object file: No such file or directory
[    0.392214] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00007f00
[    0.392214]
[    0.392223] CPU: 6 PID: 1 Comm: init Not tainted 4.18.0-319.el8.ppc64le #1
[    0.392228] Call Trace:
[    0.392234] [c00000000c703c10] [c000000008ecb94c] dump_stack+0xb0/0xf4 (unreliable)
[    0.392243] [c00000000c703c50] [c000000008167324] panic+0x148/0x3c4
[    0.392249] [c00000000c703cf0] [c000000008170474] do_exit+0xcd4/0xd40
[    0.392255] [c00000000c703dc0] [c0000000081705b0] do_group_exit+0x60/0x110
[    0.392261] [c00000000c703e00] [c000000008170684] sys_exit_group+0x24/0x30
[    0.392268] [c00000000c703e20] [c00000000800b408] system_call+0x5c/0x70

This is due to the non-conventional library path:
ldd /bin/bash
        linux-vdso64.so.1 (0x00007fffbdc90000)
        libtinfo.so.6 => /lib64/libtinfo.so.6 (0x00007fffbda80000)
        libdl.so.2 => /lib64/libdl.so.2 (0x00007fffbda50000)
        libc.so.6 => /lib64/glibc-hwcaps/power9/libc-2.28.so (0x00007fffbd830000)
                            ^^^
        /lib64/ld64.so.2 (0x00007fffbdcb0000)

ldd finds the path by libc.so.6 -> /usr/lib64/libc.so.6 ->
/usr/lib64/glibc-hwcaps/power9/libc-2.28.so and cache the result. So
when dracut_install, it only saw
'/usr/lib64/glibc-hwcaps/power9/libc-2.28.so' and blind to
'/usr/lib64/libc.so.6'

In the final kdumpimg, the symlink /usr/lib64/libc.so.6 is not created,
hence ld.so can not find the /usr/lib64/glibc-hwcaps/power9/libc-2.28.so

On the other hand, during the process of building kdumpimg, all of dynamic library info
have been cached in ld.so.cache. Hence this bug can be simplely resolved
by keeping ld cache under $initdir/etc.

Signed-off-by: Pingfan Liu <piliu@redhat.com>
---
v3 -> v4:
  use inst() instead of copy
v2 -> v3:
  fix format by shfmt -s -w modules.d/99squash/module-setup.sh
v1 -> v2:
  cp -r /etc/ld.so* instead of move, since after switch-root, initdir
can not be seen any longer

4 years agofix(dracut-install): tweaks to get_real_file()
Zoltán Böszörményi [Sun, 18 Jul 2021 08:28:37 +0000 (10:28 +0200)] 
fix(dracut-install): tweaks to get_real_file()

Fix potential memory leaks in two locations and use
_exit(EXIT_FAILURE) if asprintf(&abspath, ...) fails.

Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
4 years agofix(qeth_rules): check the existence of /sys/devices/qeth/*/online beforehand
Coiby Xu [Wed, 14 Jul 2021 07:26:10 +0000 (15:26 +0800)] 
fix(qeth_rules): check the existence of /sys/devices/qeth/*/online beforehand

On s390x KVM machines, the follow errors occurred,
    $ kdumpctl rebuild
    kdump: Rebuilding /boot/initramfs-4.18.0-321.el8.s390xkdump.img
    /usr/lib/dracut/modules.d/95qeth_rules/module-setup.sh: line 13: /sys/devices/qeth/*/online: No such file or directory
    /usr/lib/dracut/modules.d/95qeth_rules/module-setup.sh: line 13: /sys/devices/qeth/*/online: No such file or directory

because s390x KVM uses virtual devices and /sys/devices/qeth/*/online
doesn't exist. Eliminate this error by checking the existence
beforehand.

4 years agofix(network-manager): don't pull in systemd-udev-settle
Dusty Mabe [Tue, 29 Jun 2021 19:11:00 +0000 (15:11 -0400)] 
fix(network-manager): don't pull in systemd-udev-settle

We get a nice warning about it being deprecated:

```
systemd-udev-settle.service is deprecated. Please fix nm-initrd.service not to pull it in.
```

The service is deprecated because its purpose was to wait for the
discovery of all hardware, but it didn't guarantee that (see the
systemd-udev-settle man page).

NM now runs as an independent service and can deal with devices showing
up at any point, but it does need udev to be started. For now just
Want/After systemd-udev-trigger.

4 years agofix: SC2046: Quote this to prevent word splitting
Masahiro Matsuya [Tue, 29 Jun 2021 09:09:57 +0000 (18:09 +0900)] 
fix: SC2046: Quote this to prevent word splitting

4 years agofix: SC2086: Double quote to prevent globbing and word splitting
Masahiro Matsuya [Mon, 14 Jun 2021 00:04:03 +0000 (09:04 +0900)] 
fix: SC2086: Double quote to prevent globbing and word splitting

4 years agofix(url-lib): make pre-pivot hook separetely per nfs mount
Masahiro Matsuya [Fri, 11 Jun 2021 01:40:04 +0000 (10:40 +0900)] 
fix(url-lib): make pre-pivot hook separetely per nfs mount

4 years agofix(mksh): requires printf
Tomasz Paweł Gajc [Fri, 11 Jun 2021 10:11:17 +0000 (12:11 +0200)] 
fix(mksh): requires printf

4 years agofix(crypt-gpg): execute --card-status on each try
LinkTed [Mon, 21 Jun 2021 17:15:01 +0000 (19:15 +0200)] 
fix(crypt-gpg): execute --card-status on each try

If the gpg card is not inserted before the --card-status command is
executed then the public key is not linked with the card. Therefore,
the LUKS partition cannot be decrypted. To solve this, the
--card--status command is executed on each try.

4 years agofix(dracut.sh): handle symlinks appropriately while using '-i' option
Kairui Song [Fri, 11 Jun 2021 18:25:09 +0000 (02:25 +0800)] 
fix(dracut.sh): handle symlinks appropriately while using '-i' option

[[ -d $symlink ]] will return true if the symlink points to a directory.
So the symlink will not be copied, instead a directory is created with
the symlink name and the content is copied.

Signed-off-by: Kairui Song <kasong@redhat.com>
4 years agofix(dracut.sh): handle '-i' option to include files beginning with '.'
Hari Bathini [Fri, 11 Jun 2021 09:50:28 +0000 (15:20 +0530)] 
fix(dracut.sh): handle '-i' option to include files beginning with '.'

While including a directory using '--include' option, the file and
subdirectory names that begin with '.' are not included. Also, dracut
throws a warning message when a subdirectory is empty or only has
files or subdirectories that begin with '.'.

For example, while trying to include /tmpdata directory with the
below tree:

  # tree -a /tmpdata
  /tmpdata
  ├── .anothertestdir
  ├── testdir
  │   └── .testsubdir
  └── .testfile

dracut throws the below warning message:

  # dracut --include /tmpdata /root
  cp: cannot stat '/tmpdata/testdir/*': No such file or directory
  #

and this is how the included /tmpdata directory tree looks:

  # tree -a root
  root
  └── testdir

No file or directory beginning with '.' is included & also, copying
/tmpdata/testdir reported "No such file or directory" warning. Using
'.' instead of '*' in the below command will fix the warning whether
the directory being copied is empty or only has files or directories
that begin with dot:

  $DRACUT_CP -t "$object_destdir" "$dracutsysrootdir$objectname"/*

Also, enable 'dotglob' temporarily to include files and directories
beginning with a `.' in the results of pathname expansion of source
directory being included.

Signed-off-by: Hari Bathini <hbathini@linux.ibm.com>
4 years agofix(network-manager): support teaming under NM+systemd
Dusty Mabe [Thu, 24 Jun 2021 18:41:08 +0000 (14:41 -0400)] 
fix(network-manager): support teaming under NM+systemd

Previously when NM was run without dbus then teaming would come
up appropriately [1], but now that dbus exists we also need to
include some supporting infrastructure to allow for it to work
again.

[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/d689380cfc5734a29b1302d68027190e1a606265

4 years agofix(squash): create relative symlinks
Kairui Song [Thu, 10 Jun 2021 08:45:03 +0000 (16:45 +0800)] 
fix(squash): create relative symlinks

Don't use absolute path, or it may resolve to wrong files after unpack
the initramfs to a sub path on a running system.

Signed-off-by: Kairui Song <kasong@redhat.com>
4 years agofix(fips): handle s390x OSTree systems
Jonathan Lebon [Thu, 17 Jun 2021 14:47:33 +0000 (10:47 -0400)] 
fix(fips): handle s390x OSTree systems

On s390x, the `BOOT_IMAGE` karg injected by the bootloader is not a path
to the kernel image, but rather an integer describing the index of the
menu entry selected. Because of the way the s390x bootloader works,
there is no information retained about e.g. the path of the kernel that
was loaded.

This causes issues for the FIPS code which assumes that `BOOT_IMAGE` is
a path to the kernel image to derive the HMAC path. In non-OSTree
systems, this ends up working anyway, because the kernel is located at
the root of the boot partition.  In OSTree systems, this is not the
case. However, OSTree systems use BLS configs, and they are named in
reverse order of precedence (i.e. menu ordering). So from the
`BOOT_IMAGE` integer, we can figure out which BLS entry was selected.

Add some code to do just this on s390x. This isn't completely foolproof,
because it presumes that (1) BLS configs were used to populate the
bootloader (and that they were exactly in the same state they currently
are when `zipl` was run), and (2) there are no other menu entries
originating from outside the BLS configs. However, if these assumptions
are wrong we would simply fail the boot, which is currently what is
happening anyway.

See also:
https://github.com/openshift/os/pull/546
https://github.com/ibm-s390-linux/s390-tools/issues/78

Tested-by: Muhammad Adeel <muhammad.adeel@ibm.com>
4 years agofix(multipath): get config. dir from configuration
David Tardon [Tue, 1 Jun 2021 13:06:01 +0000 (15:06 +0200)] 
fix(multipath): get config. dir from configuration

4 years agofix(install): add a missing ret value assignment
Frantisek Sumsal [Fri, 18 Jun 2021 12:35:04 +0000 (14:35 +0200)] 
fix(install): add a missing ret value assignment

Spotted when reconfiguring LGTM for RHEL 9 dracut repo.

4 years agofix(network-manager): pull in network.target in nm-initrd.service
Dusty Mabe [Fri, 25 Jun 2021 19:27:37 +0000 (15:27 -0400)] 
fix(network-manager): pull in network.target in nm-initrd.service

Otherwise units with `After=network.target` won't have any effect.

4 years agofeat(squash): install umount util
Kairui Song [Tue, 22 Jun 2021 13:49:20 +0000 (21:49 +0800)] 
feat(squash): install umount util

Also install umount binary, make it possible to cleanup squash overlay
mounts. This is useful for other tools reusing the dracut initramfs built
with squash module enabled.

Signed-off-by: Kairui Song <kasong@redhat.com>
4 years agofix(tpm2-tss): typo in depends()
Matthias Berndt [Tue, 1 Jun 2021 17:32:48 +0000 (19:32 +0200)] 
fix(tpm2-tss): typo in depends()

There is no systemd-udev module, only systemd-udevd

4 years agofix(crypt): remove quotes from cryptsetupopts
lapseofreason [Tue, 8 Jun 2021 14:01:58 +0000 (16:01 +0200)] 
fix(crypt): remove quotes from cryptsetupopts

Fixes #1528.

4 years agodocs: update NEWS.md and AUTHORS 055
Harald Hoyer [Thu, 27 May 2021 12:12:40 +0000 (14:12 +0200)] 
docs: update NEWS.md and AUTHORS

4 years agofix(fs-lib): install fsck utilities
Tomasz Paweł Gajc [Sat, 22 May 2021 10:01:19 +0000 (12:01 +0200)] 
fix(fs-lib): install fsck utilities

4 years agofix(integrity): require ALLOW_METADATA_WRITES to come from EVM config file
Stefan Berger [Wed, 12 May 2021 13:26:11 +0000 (09:26 -0400)] 
fix(integrity): require ALLOW_METADATA_WRITES to come from EVM config file

Upcoming versions of EVM will not require the ALLOW_METADATA_WRITES anymore,
therefore we remove it from the script and require it to be set in the EVM
config file variable EVM_ACTIVATION_BITS for those versions that need it.

Patch 9 in this patch set deprecates the EVM_ALLOW_METADATA_WRITES flag:
https://lore.kernel.org/linux-integrity/20210514152753.982958-1-roberto.sassu@huawei.com/

Suggested-by: Roberto Sassu <roberto.sassu@huawei.com>
Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
4 years agofix(install): configure logging earlier
Marcos Mello [Mon, 24 May 2021 19:16:03 +0000 (16:16 -0300)] 
fix(install): configure logging earlier

There are log_error() and log_debug() calls in parse_argv().

4 years agofix(warpclock): minor cleanups
Jóhann B. Guðmundsson [Tue, 18 May 2021 10:34:46 +0000 (10:34 +0000)] 
fix(warpclock): minor cleanups

- Removing shell mode lines
- Remove uncessary file requirements
- Remove hard coded path to binary
- Add missing license header
- Document sections
- refactor install section

4 years agofix(dash): minor cleanups
Jóhann B. Guðmundsson [Tue, 18 May 2021 13:19:28 +0000 (13:19 +0000)] 
fix(dash): minor cleanups

- Remove hard coded path to binary
- Add missing license header
- Document sections
- refactor install section

4 years agofix(mksh): minor cleanups
Jóhann B. Guðmundsson [Tue, 18 May 2021 14:14:11 +0000 (14:14 +0000)] 
fix(mksh): minor cleanups

- Remove hard coded path to binary
- Add missing license header
- Document sections
- refactor install section

4 years agofeat(install): add default value for --firmwaredirs
Marcos Mello [Mon, 24 May 2021 00:04:20 +0000 (21:04 -0300)] 
feat(install): add default value for --firmwaredirs

If not specified, use /lib/firmware.

4 years agofix(dracut-functions): get_maj_min without get_maj_min_cache_file set
Harald Hoyer [Fri, 21 May 2021 10:19:32 +0000 (12:19 +0200)] 
fix(dracut-functions): get_maj_min without get_maj_min_cache_file set

If `get_maj_min_cache_file` is unset `get_maj_min()` would error out.

Fix it to work without a cache file set.

4 years agofix(dracut): pipe hardlink output to `dinfo`
Harald Hoyer [Fri, 21 May 2021 09:30:47 +0000 (11:30 +0200)] 
fix(dracut): pipe hardlink output to `dinfo`

Otherwise the output is cluttered with:
```
Mode:           real
Files:          1364
Linked:         5 files
Compared:       0 xattrs
Compared:       384 files
Saved:          12.84 KiB
Duration:       0.052674 seconds
```

4 years agofix(install): sane default --kerneldir
Marcos Mello [Thu, 20 May 2021 18:41:26 +0000 (15:41 -0300)] 
fix(install): sane default --kerneldir

If --kerneldir is not specified, use /lib/modules/$(uname -r).

Fixes #1505

4 years agofix(bash): minor cleanups
Jóhann B. Guðmundsson [Tue, 18 May 2021 12:39:34 +0000 (12:39 +0000)] 
fix(bash): minor cleanups

- Remove hard coded path to binary
- Add missing license header
- Document sections
- refactor install section

4 years agofix(squash): don't mount the mount points if already mounted
Kairui Song [Tue, 6 Apr 2021 18:11:41 +0000 (02:11 +0800)] 
fix(squash): don't mount the mount points if already mounted

It is possible that user setup some early mount in the rootfs even
earlier, so just be more robust and cover that case too.

Signed-off-by: Kairui Song <kasong@redhat.com>
4 years agoci: add shfmt to Fedora containers
Harald Hoyer [Mon, 17 May 2021 11:07:09 +0000 (13:07 +0200)] 
ci: add shfmt to Fedora containers

4 years agofix(base): add missing `str_replace` to `dracut-dev-lib.sh`
Harald Hoyer [Tue, 18 May 2021 08:13:56 +0000 (10:13 +0200)] 
fix(base): add missing `str_replace` to `dracut-dev-lib.sh`

```
dracut-dev-lib.sh: line 92: str_replace: command not found
dracut-dev-lib.sh: line 98: /var/tmp/dracut.sabKZg/initramfs/initqueue/finished/devexists-.sh: No such file or directory
dracut-dev-lib.sh: line 83: /var/tmp/dracut.sabKZg/initramfs/emergency/80-.sh: No such file or directory
```

4 years agofeat(dracut.sh): detect running in a container
Harald Hoyer [Mon, 17 May 2021 12:22:10 +0000 (14:22 +0200)] 
feat(dracut.sh): detect running in a container

Don't try to `mknod` by setting DRACUT_NO_MKNOD.
Don't try to `cp` extended attributrs by setting DRACUT_NO_XATTR.

4 years agofix(base): split out `dracut-dev-lib.sh`
Harald Hoyer [Mon, 17 May 2021 09:00:22 +0000 (11:00 +0200)] 
fix(base): split out `dracut-dev-lib.sh`

To share the `wait_for_dev` function and use it without side effects on
install time, split out the needed functions in an extra library.

4 years agofix(dracut-util): print error message with trailing newline
Lars Wendler [Fri, 14 May 2021 14:00:27 +0000 (16:00 +0200)] 
fix(dracut-util): print error message with trailing newline

Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
4 years agofix(packit): downstream has renamed the master branch to main
Jóhann B. Guðmundsson [Fri, 14 May 2021 13:46:23 +0000 (13:46 +0000)] 
fix(packit): downstream has renamed the master branch to main

4 years agodocs: update NEWS.md and AUTHORS 054
Harald Hoyer [Fri, 14 May 2021 12:10:36 +0000 (14:10 +0200)] 
docs: update NEWS.md and AUTHORS

4 years agoci: run the integration tests on more distributions
Harald Hoyer [Wed, 12 May 2021 11:40:53 +0000 (13:40 +0200)] 
ci: run the integration tests on more distributions

Add OpenSuse and Arch Linux to limited tests.

Only run the full tests against the latest stable Fedora version
to reduce the workload.

Also remove the `hung_task_panic=1` on the kernel command line, as qemu
tends to be really slow in non-kvm mode.

4 years agoci: create a fedora rawhide container
Harald Hoyer [Fri, 14 May 2021 10:33:41 +0000 (12:33 +0200)] 
ci: create a fedora rawhide container

Remove Fedora 34 for now, as it is fedora:latest

4 years agofeat(systemd-sysext): introducing the systemd-sysext module
Jóhann B. Guðmundsson [Wed, 12 May 2021 10:25:48 +0000 (10:25 +0000)] 
feat(systemd-sysext): introducing the systemd-sysext module

Introducing the systemd-sysext module.

4 years agodocs: document testing with containers
Harald Hoyer [Wed, 12 May 2021 13:09:08 +0000 (15:09 +0200)] 
docs: document testing with containers

4 years agofix(dracut): prevent symbolic links containing `//`
Harald Hoyer [Wed, 12 May 2021 13:09:35 +0000 (15:09 +0200)] 
fix(dracut): prevent symbolic links containing `//`

Results in `usr/lib64 -> ..//usr/lib` for Arch Linux otherwise.

4 years agofix(network-manager): cope with distributions not using `libexec`
Harald Hoyer [Wed, 12 May 2021 13:10:30 +0000 (15:10 +0200)] 
fix(network-manager): cope with distributions not using `libexec`

4 years agofix: cope with distributions with `/usr/etc` files
Harald Hoyer [Wed, 12 May 2021 13:11:55 +0000 (15:11 +0200)] 
fix: cope with distributions with `/usr/etc` files

4 years agofix(nbd): assume nbd version >= 3.8
Harald Hoyer [Wed, 12 May 2021 13:12:54 +0000 (15:12 +0200)] 
fix(nbd): assume nbd version >= 3.8

This reduces the quirks.

4 years agofix(iscsi): replace sed call with bash internals
Harald Hoyer [Wed, 12 May 2021 13:13:52 +0000 (15:13 +0200)] 
fix(iscsi): replace sed call with bash internals

This removes a fork/exec and additionally gives more information in debug logs.

4 years agofix: make testsuite pass on OpenSuse and Arch
Harald Hoyer [Fri, 7 May 2021 07:58:28 +0000 (09:58 +0200)] 
fix: make testsuite pass on OpenSuse and Arch

This removes some hard assumptions about the file system layout.

It also hardens the tests with network interface renaming rules and
guards.

4 years agofix(crypt-gpg): cope with different scdaemon location
Harald Hoyer [Wed, 12 May 2021 14:48:52 +0000 (16:48 +0200)] 
fix(crypt-gpg): cope with different scdaemon location

On Arch things are different for some reason.

4 years agofix(url-lib): fix passing args
Mikhail Novosyolov [Wed, 12 May 2021 15:16:01 +0000 (18:16 +0300)] 
fix(url-lib): fix passing args

Fixes: 8e84fa726 ("fix(url-lib): shellcheck for modules.d/45url-lib")
Behaviour introduced by that commit made the following to be run:
curl "--globoff --location --retry 3 --fail --show-error" http://192.168.1.173:8000/test.ks
instead of:
curl --globoff --location --retry 3 --fail --show-error http://192.168.1.173:8000/test.ks

This broke downloading kickstart file in anaconda-dracut.

4 years agofix: adding crc32c for ext3
Jóhann B. Guðmundsson [Wed, 12 May 2021 18:49:28 +0000 (18:49 +0000)] 
fix: adding crc32c for ext3

Noticed that ext3 is still being used in the wild so let's add it to the crc32c list
so downstream does not have to carry a patch for it.

4 years agoci: ensure pigz is installed in the CI containers
Harald Hoyer [Wed, 12 May 2021 13:46:39 +0000 (15:46 +0200)] 
ci: ensure pigz is installed in the CI containers

pigz speeds up things considerably. Although pigz is already installed
by default, explicitely adding it makes sure, it will not disappear
unnoticed.

4 years agoci: add cpio and pigz to arch container
Harald Hoyer [Wed, 12 May 2021 13:24:48 +0000 (15:24 +0200)] 
ci: add cpio and pigz to arch container

4 years agoci: really, really cleanup the arch container
Harald Hoyer [Wed, 12 May 2021 12:43:01 +0000 (14:43 +0200)] 
ci: really, really cleanup the arch container

4 years agoci: cleanup the arch container
Harald Hoyer [Wed, 12 May 2021 12:33:03 +0000 (14:33 +0200)] 
ci: cleanup the arch container

4 years agoci: don't use `rpm` to determine the kernel version
Harald Hoyer [Wed, 12 May 2021 12:19:58 +0000 (14:19 +0200)] 
ci: don't use `rpm` to determine the kernel version

for `/etc/profile.d/dracut-test.sh`

4 years agoci: build container images and push to ghcr.io
Harald Hoyer [Wed, 12 May 2021 08:09:29 +0000 (10:09 +0200)] 
ci: build container images and push to ghcr.io

4 years agofix: deprecate gummiboot
Jóhann B. Guðmundsson [Mon, 10 May 2021 16:45:40 +0000 (16:45 +0000)] 
fix: deprecate gummiboot

Gummiboot was merged into systemd and official became systemd-boot in 2015 ( 6 years ago )
and no longer was being maintained as Gummiboot from that point.

It's safe to say distribution should have migrated to sd-boot by now so let's deprecate
it.

4 years agofix(install): handle $LIB in ldd output parsing
Jaroslav Jindrak [Fri, 7 May 2021 13:11:55 +0000 (15:11 +0200)] 
fix(install): handle $LIB in ldd output parsing

The ldd output can contain the variable $LIB, which is a documented feature of
ldd. In a previous commit [0], dracut-install received support for this
variable, but that was later reverted [1] due to issues [2][3] on Gentoo ARM64.

The part before '=>' does not necessarily refer to an existing file (e.g. due
to the usage of $LIB) and thus [1] could be seen as a regression to anyone
that uses this ldd feature. This PR combines both cases together and whenever
it find a '$' character (i.e. a variable) on the left side of the '=>' symbol,
it uses the right hand path (and thus uses evaluation done by ldd), otherwise
falls back to the behavior set by [1].

Reproducer that was presented to me:

$ grep "ibz.so" /etc/ld.so.preload || cat << EOF >> /etc/ld.so.preload
/\$LIB/libz.so.1.2.11
EOF
$ mkdir -p /var/tmp/dracut.xitk6p/initramfs
$ strace /usr/lib/dracut/dracut-install -D /var/tmp/dracut.xitk6p/initramfs -l /bin/bash 2>&1|grep ibz
$ rm -rf /var/tmp/dracut.xitk6p/

[0] 45404a2
[1] 6d886bb
[2] #471
[3] https://bugs.gentoo.org/667752

4 years agofeat(systemd-journald): introducing the systemd-journald module
Jóhann B. Guðmundsson [Thu, 6 May 2021 13:54:04 +0000 (13:54 +0000)] 
feat(systemd-journald): introducing the systemd-journald module

4 years agochore(tree): move html files to the dosc directory
Jóhann B. Guðmundsson [Tue, 4 May 2021 14:14:18 +0000 (14:14 +0000)] 
chore(tree): move html files to the dosc directory

Moving the html files into the docs directory.

4 years agochore(install): move install to src directory
Jóhann B. Guðmundsson [Thu, 6 May 2021 13:29:19 +0000 (13:29 +0000)] 
chore(install): move install to src directory

Moving install to the src directory

4 years agofeat(systemd-rfkill): introducing the systemd-rfkill module
Jóhann B. Guðmundsson [Wed, 5 May 2021 19:00:38 +0000 (19:00 +0000)] 
feat(systemd-rfkill): introducing the systemd-rfkill module

Introducing the systemd-rfkill module

4 years agofeat(systemd-ldconfig): introducing the systemd-ldconfig module
Jóhann B. Guðmundsson [Wed, 5 May 2021 16:06:36 +0000 (16:06 +0000)] 
feat(systemd-ldconfig): introducing the systemd-ldconfig module

Introducing the systemd-ldconfig module

4 years agofix: add a missing tmpfilesconfdir global variable
Jóhann B. Guðmundsson [Wed, 5 May 2021 09:41:02 +0000 (09:41 +0000)] 
fix: add a missing tmpfilesconfdir global variable

Adding a missing tmpfilesconfdir global variable

4 years agofeat(systemd-tmpfiles): introducing the systemd-tmpfiles module
Jóhann B. Guðmundsson [Wed, 5 May 2021 09:26:26 +0000 (09:26 +0000)] 
feat(systemd-tmpfiles): introducing the systemd-tmpfiles module

Introducing the systemd-tmpfiles module

4 years agorefactor(systemd-networkd): cosmetic move to 01
Jóhann B. Guðmundsson [Thu, 6 May 2021 11:49:29 +0000 (11:49 +0000)] 
refactor(systemd-networkd): cosmetic move to 01

Moving systemd-networkd to 01 systemd namespace to keep everything in
order.

4 years agofix(base): suppress calls to getarg in build phase
Harald Hoyer [Thu, 6 May 2021 07:10:54 +0000 (09:10 +0200)] 
fix(base): suppress calls to getarg in build phase

Setting `DEBUG_MEM_LEVEL` in the build phase prevents
`setmemdebug()` to call `getargnum`, which would use `dracut-getarg`
in the initrd runtime phase.

No more:

```
modules.d/99base/dracut-lib.sh: line 217: dracut-getarg: command not found
```

4 years agofix(dracut-functions): implement a cache for get_maj_min
Renaud Métrich [Wed, 5 May 2021 13:46:08 +0000 (15:46 +0200)] 
fix(dracut-functions): implement a cache for get_maj_min

On systems with a large number of devices, usually multipath devices,
dracut can spend a lot of time stat'ing the devices to collect the
major/minor numbers, leading to huge slowness rebuilding the initramfs
when stat'ing devices is slow (seen with oracleasm file systems in
particular).
This commit implements a basic cache stored in a file under
DRACUT_TMPDIR storing the major:minor corresponding to the specified
device.

Reproducer: create N loopback devices used as a LVM extension to volume
group hosting the root file system

  # LVMVG="rhel"
  # NDEVICES=200
  # mkdir devices; for i in $(seq 1 $NDEVICES); do
    truncate -s 10m devices/$i; losetup loop$i devices/$i
  done
  # vgextend $LVMVG $(/bin/ls -1 /dev/loop[0-9]*)

With standard code (tested with RHEL8.3 dracut):

  # dracut -f --debug /tmp/initramfs.img $(uname -r) >/tmp/debug 2>&1
  # grep -c "stat -L -c" /tmp/debug
  2440

With this code:

  # dracut -f --debug /tmp/initramfs.img $(uname -r) >/tmp/debug_optim 2>&1
  # grep -c "stat -L -c" /tmp/debug_optim
  205

Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
4 years agofix(fips): add dh and ecdh ciphers
David Tardon [Wed, 5 May 2021 14:05:17 +0000 (16:05 +0200)] 
fix(fips): add dh and ecdh ciphers

4 years agofix: shellcheck 0.7.2
Harald Hoyer [Tue, 4 May 2021 14:36:22 +0000 (16:36 +0200)] 
fix: shellcheck 0.7.2

github action `luizm/action-sh-checker@v0.2.2` uses `shellcheck-0.7.2`,
which detects more non-posix shell code and complains accordingly.