repo: Avoid reading past the end of the key buffer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Avoid double brackets in section name

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Ensure /etc/pakfire/repos exists before writing files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Create a new network namespace unless running interactively

This will deny any internet connectivity in the build environment, but
will allow users in an interative shell to use the network.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Set HOME in shell environment

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

progressbar: Don't join rendering thread when it has never been started

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelists: Silence a compiler warning that a comment contains /*

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "packages: Ensure that the pool is internalized for packages w/o repo"

This reverts commit 2fcc2e22f92577c8bf572a3276445fd6869eb158.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Make pattern matching less eager

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Add newline to python3_version output

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Fix off-by-one error when deleting files

The last file was never deleted.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Sort the filelist before writing the package

This is probably not strictly necessary, but is nicer for humans.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transaction: Don't print empty string

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Fix function declaration for yy_scan_bytes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

downloader: Actually check whether title is set

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

db: Free correct value

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packages: Fix my messy code and use proper return codes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

package: Don't make types array static

Let the compiler decide what is best.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Skip requires which are provided by the same package

This will avoid that the dependency resolution has to deal with
dependencies which should not really exist.

Fixes: #13000
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packages: Ensure that the pool is internalized for packages w/o repo

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

package: Add function to check whether a depenency matches

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

package: Use self-provides function from libsolv

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transaction: Add error message when digest isn't set

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix compiler warning

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix checking scriptlets for any dependencies

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Do not link against libsolv-ext any more

We do not use anything that is part of this library.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

find-provides/requires: Drop Perl handling

This is now done in a separate script

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Sort the filelist after scanning

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Call better things for Python 3

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Only send Perl files to the perl dependency scripts

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Add pattern filtering to walk

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Add a function to check whether the path matches a pattern

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

find-requires: Fix matching Python paths

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

perl: Re-indent scripts

No functional changes.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

perl.req: Don't call perl.prov

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

perl: Behave like the other dependency scripts

The only argument will be the BUILDROOT path and the filelist will be
passed to stdin.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

perl.req: Drop Fedora-specific stuff

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

scripts: Update perl.{prov,req} from RPM

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Refactor dependency scanning

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

scripts: Log BUILDROOT when it cannot be found

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dependencies: Ignore newline

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Make pakfire_jail_exec_script private

We don't need anything else to call this.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Drop superfluous arguments that are never used from convenience function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Pass filelists into dependency scripts

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Refactor pakfire_jail_exec_script

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Refactor pakfire_jail_exec

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Add new way to communicate with child processes

In order to read and write to the child process, a new interface is
being added.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Add command that reads from stdin and writes it back

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Remove extra % in formatting string

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transaction: Drop file conflicts check

We cannot use this in IPFire since we don't have librpm.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Always prefer excludes first, then includes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Add exception for root user when reading subuid/subgid

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Copy more stat attributes

This is useful for any hardlink detection

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Makefile: Don't install test programs into the system

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dependencies: Consume any excess space

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dependencies: Log any invalid dependencies

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: dependencies: Add tests for dependencies with excess space

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Use pkg-config to find gpgme

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

find-requires: Make pkg-config aware of other installed .pc files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

find-provides: Process all .so files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire-builder: shell: Allow passing --install multiple times

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Fix appending to variables with inheritance

Fixes: #12997
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

test: Add a simple test program for the parser

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: parser: Check if appending variables works

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix splitting the filelist

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Split filelist on spaces, too

Sometimes, we append items to the filelist using the += which will not
create a new line. Therefore we need to split on spaces, too.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

repo: Slightly refactor scanning

No functional changes.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Unify include/exclude pattern matching

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Strip the leading ! from excluded files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Set a default PATH to avoid using login shells everywhere

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix collecting pre-requires from scriptlets

--login is required to set the path correctly, and we now throw away any
errors from which.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Run scriptlets in a login shell

Otherwise, PATH is not set properly.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

db: Set correct absolute path for read filelists

This prevents Pakfire from deleteing files in the host system.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

.gitignore: Ignore ~/tests/stub/root

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Do not try to compress source packages as hard

There is no point in wasting too many CPU cycles on compressing already
compressed tarballs, etc, but we do want a little bit of compression for
patches, etc.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail.c: It should have been the other way round, Michael :-)

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

extract: Prevent pakfire from removing any symlinks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transactions: Add hack to ensure UsrMove works

This is the only way to avoid chaos, but it is ugly.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Reset required autotools to something that is in Debian stable

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure.ac: Do not use AC_PROG_CC_STDC anymore

On Ubuntu 22.04 LTS, this resolves:

> configure.ac:100: warning: The macro `AC_PROG_CC_STDC' is obsolete.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail.c: Include sys/wait.h before linux/wait.h

This is necessary for compiling Pakfire on Ubuntu 22.04 LTS.

Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Fix missing space in CFLAGS

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Update CFLAGS (again)

This commit tidies up how we build the CFLAGS variable (as there is no
point in putting together an auxiliary variable first).

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Add macros for ninja & meson

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Update CFLAGS

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Drop CFLAGS for architectures we no longer support

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Create function to call dependency scripts

This makes it easier to call this function many times.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire-builder: Add switches to enable/disable repositories

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire-builder: shell: Add --disable-snapshot

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

_pakfire: Fix SEGV on repr(repo)

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Allow creating shells without a snapshot

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Only require libarchive >= 3.4.0

We used to require a couple more recent functions, but that code has
been dropped, and so we can go back a little.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

check-rpaths: Normalize paths before checking the whitelist

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

find-requires: Skip any interpreters without absolute paths

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Include cmake macros

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strip: Include PIE files

Fixes: #12999
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Don't print message when a package is being written

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dist: Pass absolute path when searching for files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Scanning requires an absolute path

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

contrib: Increase priority of local and decrease bootstrap

We prefer using packages from the local repository as they are usually
newer or being tested. The bootstrap repository should always be used as
last resort.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>