]> git.ipfire.org Git - thirdparty/lxc.git/log
thirdparty/lxc.git
6 years agogpg: use proxy, if http_proxy is set
Marco Dickert [Thu, 28 Feb 2019 09:03:16 +0000 (10:03 +0100)] 
gpg: use proxy, if http_proxy is set

Signed-off-by: Marco Dickert <marco@misterunknown.de>
6 years agoattach: use move_fd in lxc_proc_close_ns_fd
Wolfgang Bumiller [Mon, 25 Feb 2019 16:05:24 +0000 (17:05 +0100)] 
attach: use move_fd in lxc_proc_close_ns_fd

Previously this set `ctx->ns_fd[*]` to `-EBADF` until commit
fd2a88b190eb ("attach: cleanup macros lxc_proc_close_ns_fd",
but there are some code paths where we call this before
later calling `lxc_proc_put_context_info` which would call
this function again with the file descriptors still
unchanged.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
6 years agoconf: cleanup macros suggest_default_idmap
Christian Brauner [Fri, 22 Feb 2019 21:15:09 +0000 (22:15 +0100)] 
conf: cleanup macros suggest_default_idmap

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros write_id_mapping
Christian Brauner [Fri, 22 Feb 2019 21:12:20 +0000 (22:12 +0100)] 
conf: cleanup macros write_id_mapping

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros setup_mount_entries
Christian Brauner [Fri, 22 Feb 2019 21:07:26 +0000 (22:07 +0100)] 
conf: cleanup macros setup_mount_entries

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros make_anonymous_mount_file
Christian Brauner [Fri, 22 Feb 2019 21:06:47 +0000 (22:06 +0100)] 
conf: cleanup macros make_anonymous_mount_file

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros lxc_fill_autodev
Christian Brauner [Fri, 22 Feb 2019 21:04:14 +0000 (22:04 +0100)] 
conf: cleanup macros lxc_fill_autodev

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros lxc_pivot_root
Christian Brauner [Fri, 22 Feb 2019 20:59:57 +0000 (21:59 +0100)] 
conf: cleanup macros lxc_pivot_root

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros lxc_chroot
Christian Brauner [Fri, 22 Feb 2019 20:56:55 +0000 (21:56 +0100)] 
conf: cleanup macros lxc_chroot

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros remount_all_slave
Christian Brauner [Fri, 22 Feb 2019 20:49:48 +0000 (21:49 +0100)] 
conf: cleanup macros remount_all_slave

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: simplify idmaptool_on_path_and_privileged
Christian Brauner [Fri, 22 Feb 2019 20:41:41 +0000 (21:41 +0100)] 
conf: simplify idmaptool_on_path_and_privileged

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agolxc-attach: switch to attach_run_wait
Christian Brauner [Thu, 21 Feb 2019 19:28:24 +0000 (20:28 +0100)] 
lxc-attach: switch to attach_run_wait

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years ago.travis: remove coverity
Christian Brauner [Thu, 21 Feb 2019 09:56:13 +0000 (10:56 +0100)] 
.travis: remove coverity

It hasn't worked reliably for us for a long time. Remove it until such time as
someone cares enough to fix it.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years ago.travis: give coverity one more try
Christian Brauner [Thu, 21 Feb 2019 09:47:13 +0000 (10:47 +0100)] 
.travis: give coverity one more try

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoattach: cleanup macros lxc_attach_terminal_[...]
Christian Brauner [Wed, 20 Feb 2019 23:35:52 +0000 (00:35 +0100)] 
attach: cleanup macros lxc_attach_terminal_[...]

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoattach: cleanup macros lxc_put_attach_clone_[...]
Christian Brauner [Wed, 20 Feb 2019 23:21:57 +0000 (00:21 +0100)] 
attach: cleanup macros lxc_put_attach_clone_[...]

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoattach: cleanup macros in_same_namespace
Christian Brauner [Wed, 20 Feb 2019 23:18:59 +0000 (00:18 +0100)] 
attach: cleanup macros in_same_namespace

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoattach: cleanup macros lxc_proc_close_ns_fd
Christian Brauner [Wed, 20 Feb 2019 23:12:15 +0000 (00:12 +0100)] 
attach: cleanup macros lxc_proc_close_ns_fd

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agotravis: run coccinelle
Christian Brauner [Wed, 20 Feb 2019 20:11:46 +0000 (21:11 +0100)] 
travis: run coccinelle

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agotravis: run coccinelle
Christian Brauner [Wed, 20 Feb 2019 19:44:16 +0000 (20:44 +0100)] 
travis: run coccinelle

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros suggest_default_idmap
Christian Brauner [Tue, 19 Feb 2019 22:49:14 +0000 (23:49 +0100)] 
conf: cleanup macros suggest_default_idmap

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros get{g,u}name
Christian Brauner [Tue, 19 Feb 2019 22:48:06 +0000 (23:48 +0100)] 
conf: cleanup macros get{g,u}name

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros get_minimal_idmap
Christian Brauner [Tue, 19 Feb 2019 22:47:49 +0000 (23:47 +0100)] 
conf: cleanup macros get_minimal_idmap

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros lxc_execute_bind_init
Christian Brauner [Tue, 19 Feb 2019 22:47:26 +0000 (23:47 +0100)] 
conf: cleanup macros lxc_execute_bind_init

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros remount_all_slave
Christian Brauner [Tue, 19 Feb 2019 22:47:05 +0000 (23:47 +0100)] 
conf: cleanup macros remount_all_slave

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros idmaptool_on_path_[...]
Christian Brauner [Tue, 19 Feb 2019 22:46:34 +0000 (23:46 +0100)] 
conf: cleanup macros idmaptool_on_path_[...]

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros setup_proc_filesystem
Christian Brauner [Tue, 19 Feb 2019 22:46:11 +0000 (23:46 +0100)] 
conf: cleanup macros setup_proc_filesystem

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros setup_sysctl_parameters
Christian Brauner [Tue, 19 Feb 2019 22:45:43 +0000 (23:45 +0100)] 
conf: cleanup macros setup_sysctl_parameters

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros mount_entry_on_generic
Christian Brauner [Tue, 19 Feb 2019 22:45:24 +0000 (23:45 +0100)] 
conf: cleanup macros mount_entry_on_generic

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros mount_entry_create_dir_file
Christian Brauner [Tue, 19 Feb 2019 22:45:03 +0000 (23:45 +0100)] 
conf: cleanup macros mount_entry_create_dir_file

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros parse_propagationopts
Christian Brauner [Tue, 19 Feb 2019 22:44:08 +0000 (23:44 +0100)] 
conf: cleanup macros parse_propagationopts

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros parse_mntopts
Christian Brauner [Tue, 19 Feb 2019 22:43:45 +0000 (23:43 +0100)] 
conf: cleanup macros parse_mntopts

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros lxc_chroot
Christian Brauner [Tue, 19 Feb 2019 22:43:27 +0000 (23:43 +0100)] 
conf: cleanup macros lxc_chroot

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros lxc_mount_auto_mounts
Christian Brauner [Tue, 19 Feb 2019 22:43:04 +0000 (23:43 +0100)] 
conf: cleanup macros lxc_mount_auto_mounts

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros pin_rootfs
Christian Brauner [Tue, 19 Feb 2019 22:42:45 +0000 (23:42 +0100)] 
conf: cleanup macros pin_rootfs

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: cleanup macros run_script_argv
Christian Brauner [Tue, 19 Feb 2019 22:42:25 +0000 (23:42 +0100)] 
conf: cleanup macros run_script_argv

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: auto free run_buffer
Christian Brauner [Tue, 19 Feb 2019 22:41:48 +0000 (23:41 +0100)] 
conf: auto free run_buffer

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands_utils: auto free lxc_add_state_client
Christian Brauner [Tue, 19 Feb 2019 22:21:50 +0000 (23:21 +0100)] 
commands_utils: auto free lxc_add_state_client

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands_utils: auto close lxc_cmd_sock_get_state
Christian Brauner [Tue, 19 Feb 2019 22:21:08 +0000 (23:21 +0100)] 
commands_utils: auto close lxc_cmd_sock_get_state

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocve-2019-5736: add test
Christian Brauner [Tue, 19 Feb 2019 17:19:18 +0000 (18:19 +0100)] 
cve-2019-5736: add test

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agotree-wide: s/steal_fd/move_fd/g
Christian Brauner [Mon, 18 Feb 2019 21:13:42 +0000 (22:13 +0100)] 
tree-wide: s/steal_fd/move_fd/g

Suggested-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands: cleanup macros lxc_cmd_init()
Christian Brauner [Sun, 17 Feb 2019 13:46:25 +0000 (14:46 +0100)] 
commands: cleanup macros lxc_cmd_init()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands: cleanup macros lxc_cmd_init
Christian Brauner [Sun, 17 Feb 2019 13:44:20 +0000 (14:44 +0100)] 
commands: cleanup macros lxc_cmd_init

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands: cleanup macros lxc_cmd_accept()
Christian Brauner [Sun, 17 Feb 2019 13:42:51 +0000 (14:42 +0100)] 
commands: cleanup macros lxc_cmd_accept()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands: cleanup macros lxc_cmd_add_state_client
Christian Brauner [Sun, 17 Feb 2019 13:39:55 +0000 (14:39 +0100)] 
commands: cleanup macros lxc_cmd_add_state_client

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands: cleanup macros lxc_cmd()
Christian Brauner [Sun, 17 Feb 2019 13:36:52 +0000 (14:36 +0100)] 
commands: cleanup macros lxc_cmd()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands: use __do_close_prot_errno
Christian Brauner [Sun, 17 Feb 2019 13:32:14 +0000 (14:32 +0100)] 
commands: use __do_close_prot_errno

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agomacro: introduce steal_fd()
Christian Brauner [Sun, 17 Feb 2019 13:31:40 +0000 (14:31 +0100)] 
macro: introduce steal_fd()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands: cleanup macros in lxc_cmd_console()
Christian Brauner [Sun, 17 Feb 2019 13:24:30 +0000 (14:24 +0100)] 
commands: cleanup macros in lxc_cmd_console()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands: move declaration into tighter scope
Christian Brauner [Sun, 17 Feb 2019 13:21:09 +0000 (14:21 +0100)] 
commands: move declaration into tighter scope

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agolxc-usernsexec: use cleanup macros
Christian Brauner [Sat, 9 Feb 2019 11:05:46 +0000 (12:05 +0100)] 
lxc-usernsexec: use cleanup macros

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agolxc-user-nic: use cleanup macros
Christian Brauner [Sat, 9 Feb 2019 11:02:22 +0000 (12:02 +0100)] 
lxc-user-nic: use cleanup macros

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agolxc-init: use cleanup macros
Christian Brauner [Sat, 9 Feb 2019 10:57:07 +0000 (11:57 +0100)] 
lxc-init: use cleanup macros

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocgroup_utils: use __do_free
Christian Brauner [Sat, 9 Feb 2019 10:51:04 +0000 (11:51 +0100)] 
cgroup_utils: use __do_free

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoattach: use __do_free
Christian Brauner [Sat, 9 Feb 2019 10:46:15 +0000 (11:46 +0100)] 
attach: use __do_free

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoaf_unix: use __do_free
Christian Brauner [Sat, 9 Feb 2019 10:36:18 +0000 (11:36 +0100)] 
af_unix: use __do_free

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agostart: move variable into tighter scope
Christian Brauner [Sat, 9 Feb 2019 10:32:45 +0000 (11:32 +0100)] 
start: move variable into tighter scope

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agonetwork: do not log false friends
Christian Brauner [Fri, 15 Feb 2019 22:50:34 +0000 (23:50 +0100)] 
network: do not log false friends

The netlink functions just return -1 and not specific negative errno values so
logging them doesn't make any sense.

Fixes: https://discuss.linuxcontainers.org/t/warning-in-the-container-log/4072/2
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: do not log devpts umount2() failure
Christian Brauner [Fri, 15 Feb 2019 22:42:30 +0000 (23:42 +0100)] 
conf: do not log devpts umount2() failure

We're not acting based on the return value so don't log anything.

Fixes: https://discuss.linuxcontainers.org/t/warning-in-the-container-log/4072/2
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoapparmor: Improve testing on apparmor python script
Hervé Beraud [Tue, 12 Feb 2019 22:47:25 +0000 (23:47 +0100)] 
apparmor: Improve testing on apparmor python script

Compare command output to already existing container-rules file

Signed-off-by: Hervé Beraud <hberaud@redhat.com>
6 years agoapparmor: catch config file opening error
Hervé Beraud [Tue, 12 Feb 2019 21:48:51 +0000 (22:48 +0100)] 
apparmor: catch config file opening error

Improve config file error opening management
and improve main code block.

Execute this python script during CI to avoid
regressions

Signed-off-by: Hervé Beraud <hberaud@redhat.com>
6 years agostring_utils.h: fix wrong licensing
Christian Brauner [Mon, 11 Feb 2019 21:13:34 +0000 (22:13 +0100)] 
string_utils.h: fix wrong licensing

liblxc has always been meant to be LGPLv2.1+ as reflected by the many
downstreams projects and bindings which are themselves under LGPLv2.1+ or other
licenses which would be incompatible with linking against a GPLv2+ library.

It's pretty normal for a library to be LGPL while binaries are GPL as a GPL
library would only ever be usable by other GPL-only projects, which isn't the
case for very many of the liblxc downstreams.

The issue here is really carelessness. None of those GPL headers were put there
intentionally, instead being wrongly copy/pasted from other parts of the
codebase which is indeed intended to be GPLv2+. This is also made clear in our
CONTRIBUTING file in this repository:

Licensing for new files:
------------------------

LXC is made of files shipped under a few different licenses.

Anything that ends up being part of the LXC library needs to be released
under LGPLv2.1+ or a license compatible with it (though the latter will
only be accepted for cases where the code originated elsewhere and was
imported into LXC).

Language bindings for the libraries need to be released under LGPLv2.1+.

Anything else (non-libraries) needs to be Free Software and needs to be
allowed to link with LGPLv2.1+ code (if needed). LXC upstream prefers
LGPLv2.1+ or GPLv2 for those.

When introducing a new file into the project, please make sure it has a
copyright header making clear under which license it's being released
and if it doesn't match the criteria described above, please explain
your decision on the lxc-devel mailing-list when submitting your patch.

This is intended to switch over files to LGPLv2.1+ to which end we have
collected ACKs from relevant people.
/* Affected People */
Christian Brauner <christian.brauner@ubuntu.com>
Fabrice Fontaine <fontaine.fabrice@gmail.com>
Josh Soref <jsoref@gmail.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Acked-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Acked-by: Josh Soref <jsoref@gmail.com>
6 years agosyscall_wrappers: fix wrong licensing
Christian Brauner [Mon, 11 Feb 2019 16:30:26 +0000 (17:30 +0100)] 
syscall_wrappers: fix wrong licensing

/* Affected People */
Christian Brauner <christian.brauner@ubuntu.com>
Aleksa Sarai <cyphar@cyphar.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoringbuf.h: fix wrong licensing
Christian Brauner [Mon, 11 Feb 2019 16:29:31 +0000 (17:29 +0100)] 
ringbuf.h: fix wrong licensing

/* Affected People */
Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocompiler: fix wrong licensing
Christian Brauner [Mon, 11 Feb 2019 16:23:52 +0000 (17:23 +0100)] 
compiler: fix wrong licensing

/* Affected People */
Christian Brauner <christian.brauner@ubuntu.com>

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoparse: handle \r
Christian Brauner [Sun, 10 Feb 2019 22:55:17 +0000 (23:55 +0100)] 
parse: handle \r

Closes #2838.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agococcinelle: use standard exit identifiers
Christian Brauner [Sat, 9 Feb 2019 10:23:54 +0000 (11:23 +0100)] 
coccinelle: use standard exit identifiers

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agococcinelle: s/while({1,true})/for(;;)/
Christian Brauner [Fri, 8 Feb 2019 22:57:06 +0000 (23:57 +0100)] 
coccinelle: s/while({1,true})/for(;;)/

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agococcinelle: add coccinelle support
Christian Brauner [Fri, 8 Feb 2019 22:56:51 +0000 (23:56 +0100)] 
coccinelle: add coccinelle support

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agolxc-init: exit with error on wait failure
Christian Brauner [Sat, 9 Feb 2019 00:35:44 +0000 (01:35 +0100)] 
lxc-init: exit with error on wait failure

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agostart: prevent signed-issues
Christian Brauner [Sat, 9 Feb 2019 00:33:18 +0000 (01:33 +0100)] 
start: prevent signed-issues

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocgfsng: remove unnecessary check
Christian Brauner [Sat, 9 Feb 2019 00:31:52 +0000 (01:31 +0100)] 
cgfsng: remove unnecessary check

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands: remove unnecessary check
Christian Brauner [Sat, 9 Feb 2019 00:28:52 +0000 (01:28 +0100)] 
commands: remove unnecessary check

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoREADME: add LGTM
Christian Brauner [Wed, 6 Feb 2019 11:23:17 +0000 (12:23 +0100)] 
README: add LGTM

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agolxc-unshare: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:47:18 +0000 (07:47 +0100)] 
lxc-unshare: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agooverlay: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:46:13 +0000 (07:46 +0100)] 
overlay: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agorbd: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:44:13 +0000 (07:44 +0100)] 
rbd: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agonbd: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:42:50 +0000 (07:42 +0100)] 
nbd: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agolvm: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:39:51 +0000 (07:39 +0100)] 
lvm: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoloop: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:38:02 +0000 (07:38 +0100)] 
loop: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoterminal: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:26:19 +0000 (07:26 +0100)] 
terminal: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agostring_utils: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:30:00 +0000 (07:30 +0100)] 
string_utils: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agostorage: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:32:21 +0000 (07:32 +0100)] 
storage: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agostart: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:25:12 +0000 (07:25 +0100)] 
start: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agopam_cgfs: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:33:48 +0000 (07:33 +0100)] 
pam_cgfs: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agonetwork: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:27:29 +0000 (07:27 +0100)] 
network: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agonamespace: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:23:19 +0000 (07:23 +0100)] 
namespace: remove stack allocations

Switch to a static stack instead of allocating a new one. There's really
no point in doing all of the dance to get the current pagesize.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agomonitor: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:31:16 +0000 (07:31 +0100)] 
monitor: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agolxccontainer: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:19:56 +0000 (07:19 +0100)] 
lxccontainer: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconfile: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:12:17 +0000 (07:12 +0100)] 
confile: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agoconf: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:08:44 +0000 (07:08 +0100)] 
conf: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands_utils: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:06:02 +0000 (07:06 +0100)] 
commands_utils: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocommands: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:02:07 +0000 (07:02 +0100)] 
commands: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agolxc_user_nic: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:01:50 +0000 (07:01 +0100)] 
lxc_user_nic: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocgroups: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:01:33 +0000 (07:01 +0100)] 
cgroups: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agolxcmntent: remove stack allocations
Christian Brauner [Tue, 5 Feb 2019 06:00:58 +0000 (07:00 +0100)] 
lxcmntent: remove stack allocations

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocompiler: -Wnested-externs hardening
Christian Brauner [Tue, 5 Feb 2019 22:50:43 +0000 (23:50 +0100)] 
compiler: -Wnested-externs hardening

Warn if an extern declaration is encountered within a function.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocompiler: -Wdate-time hardening
Christian Brauner [Tue, 5 Feb 2019 22:49:48 +0000 (23:49 +0100)] 
compiler: -Wdate-time hardening

Warn when macros __TIME__, __DATE__ or __TIMESTAMP__ are encountered as
they might prevent bit-wise-identical reproducible compilations.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocompiler: -Werror=shift-overflow=2 hardening
Christian Brauner [Tue, 5 Feb 2019 22:48:32 +0000 (23:48 +0100)] 
compiler: -Werror=shift-overflow=2 hardening

Warn about left shift overflows. This warning is enabled by default in
C99 and C++11 modes (and newer).

-Wshift-overflow=2
This warning level also warns about left-shifting 1 into the sign bit,
unless C++14 mode (or newer) is active.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
6 years agocompiler: -Werror=shift-count-overflow hardening
Christian Brauner [Tue, 5 Feb 2019 22:47:31 +0000 (23:47 +0100)] 
compiler: -Werror=shift-count-overflow hardening

Warn if shift count >= width of type.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>