packager: Return an archive

This is an attempt to have the packager return an object instead of a
loose path so that we can do more things with the result.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Fail if we were not given a package pointer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Add function to unlink an archive

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

path: Add function to format a path and normalize it straight away

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Refactor composing the filename

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Stop expanding variables if the string becomes empty

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Always copy the namespace to the stack

This avoids using strdupa() which will result in those functions not
being possible to be inlined.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Simplify declaration matching

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parsers: Statically allocate the namespace

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Slightly improve expanding variables

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor stripping namespaces

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Don't try to expand empty strings

This is just a fast path to avoid doing unnecessary work.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Cleanup expanding variables

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Compile regular expressions only once

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Remove a dead assignment

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Write a better implementation to replace newlines

This performs the operating on the existing buffer and should be more
straight forward than the previous one.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Use existing string functions for copying strings

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Avoid a potential double-free on early exits

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Fix return code handling when merging parsers

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor reading from file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Map the data into buffer to read it faster

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: Create a convenience function to map files into memory

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor listing namespaces

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Add a function to search for a match in string array

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Use string functions to manage filelists

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Minor cleanup when searching for a template

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor creating declarations

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Tidy up for finding declarations

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor joining strings

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor creating a new parser

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dist: Free the context after reading the makefile

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Fix the parser tester

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Free transaction after performing the install check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

dist: Release the context after we are done

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Fail if the context wasn't freed in the end

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Make the buffers significantly smaller

We don't really need that much buffer space here and it probably allows
for better CPU caching if the entire struct is smaller.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Refactor processing Perl dependencies

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Implement to stream a filelist into stdin

This is an improved implementation that even supports writing some data
if there is not enough buffer space to write the full filename at once.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Simplify mounting the ccache

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Only copy regular source files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

transaction: In build mode, always install the best set of packages

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Allow uninstalling and downgrading packages

This is required if we want to be able to obsolete things here.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Don't try to perform ELF checks on start files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

macros: Package /usr/lib*/cmake in development packages

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Support stripping binaries without a Build ID

We should not have these in practise, but there might be cases where we
cannot extract the ID correctly.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Simplify error message when build dependencies cannot be installed

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Add a function to dump a string array

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Don't uninstall source packages by accident

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Call pool_setarchpolicy() directly

This will avoid any builtin logic from libsolv which considers ix86
alternatives which we don't support here.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Skip any invalid DWARF sections

On some start files in glibc, this error is thrown and I think it is
safe to just ignore it.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ELF: Actually return NULL if there is no Build ID

Before, we allocated an empty string which is unnecessary and confused
me further down the line.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Ensure to register SIGWINCH in the parent process

This makes the entire terminal resizing work again...

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: progressbar: Fix integer underflow

It could happen that we required more space than had and then the
expandable part of the progressbar became negative.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Add the debuglink only when we have extracted the debuginfo

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Add function to merge multiple strings into an array

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Create directories where we are creating the files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Rename functions

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Don't try to extract debuginfo from *.o files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Strip any LTO information

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Rename to self

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Skip script interpreter check for ELF files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Skip linting kernel modules

There is pretty much nothing we can do with them.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Move skipping files we never want to lint

This saves us from initializing the linter and reading the entire
payload.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Remove extra step when installing any custom packages

Since there is only one place where this happens, we can also add this
all to the existing large transaction.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Install source package/update in one step

This patch makes launching a new environment even faster. Everything
will always be resolved in one go and installed in one huge transaction.
Any dependency errors will be caught really early on and we will have
less noise in the console/log.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Find pre-requirements without a shell script

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pty: Add helper function to stream a buffer into stdin

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: which: Fix return code on invalid input

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

package: Allow building noarch on any host architecture

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Skip valgrind for the SSP check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Whitelist the runtime linker for the SSP check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Never try to strip any firmware

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix order of arguments to set the arch

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Don't clear the entire buffer when resetting a string

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: setn: Don't copy anything if length is zero

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Create a function to copy a fixed-length string

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

string: Choose a more sensible error code when we run out of space

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Remove headers for removed functions

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Exclude *.py[co] and *.packlist from BUILDROOT check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Set PKG_CONFIG_PATH a little bit elegantly

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

env: Add a function to append values

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Create buildroot outside the build environment

This will help us to avoid all the path maths and we will simply
bind-mount the temporary directory into the build environment instead.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

CLI: Remove option to pass the build ID

I don't think we need this and currently it is a no-op.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: build: Use the correct macros to check for errors

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: build: Pass the configuration

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Always globally load the test configuration file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Drop PAKFIRE_PRIVATE

Everything is now private so we won't need this guard any more.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

CLI: Create a convenience function to set up a build environment

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fix conflicting flag name

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

CLI: Only pass distro globally for all build commands

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

CLI: Rename config to args

We use the name config for too many things it was not very clear where
things were coming from. Hence this change.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cli: Remove legacy distro configuration loading code

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Pass the configuration to Pakfire

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Fix them after the recent changes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Pass the configuration as a config object

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Create and manage the Pakfire instance ourselves

This allows us to pass arguments around easier and keep the
configuration closer together.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

debian: Install all files in the main package

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

pakfire: Tell the compiler that we always expect a path for openat()

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

strings: Copy strings a lot when appending to an array

The static analyzer thinks we are leaking memory, and so we have to make
things a little bit easier for it.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Implement buildroot check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>