]> git.ipfire.org Git - thirdparty/openldap.git/log
thirdparty/openldap.git
2 years agoITS#9121 dynlist: cleanup unused code
Howard Chu [Wed, 30 Nov 2022 18:14:15 +0000 (18:14 +0000)] 
ITS#9121 dynlist: cleanup unused code

2 years agoITS#9929 preserve e_name for memberOf values
Howard Chu [Mon, 14 Nov 2022 17:48:24 +0000 (17:48 +0000)] 
ITS#9929 preserve e_name for memberOf values

2 years agoITS#9929: more performance tweaks
Howard Chu [Thu, 3 Nov 2022 17:42:36 +0000 (17:42 +0000)] 
ITS#9929: more performance tweaks

For simple (non-nested) member compares, avoid unnecessary fetches
of dyngroups that can't match the filter.
cache filter/entry instance info across multiple dyn entries to
avoid refetching each filter entry for each dyngruop test.

2 years agoITS#9929 slapo-dynlist: more performance tweaks
Howard Chu [Wed, 19 Oct 2022 15:21:42 +0000 (16:21 +0100)] 
ITS#9929 slapo-dynlist: more performance tweaks

Minimize cost of dynamic lists while still making them filterable:
require their attrs to be explicitly mapped if filtering is to be supported.

Also check config scope in compare op

2 years agoITS#9955
Quanah Gibson-Mount [Mon, 5 Dec 2022 16:30:24 +0000 (16:30 +0000)] 
ITS#9955

2 years agoITS#9955 liblunicode: fix buffer size in UTF8bvnormalize
Howard Chu [Thu, 24 Nov 2022 21:32:51 +0000 (21:32 +0000)] 
ITS#9955 liblunicode: fix buffer size in UTF8bvnormalize

output buffer may overrun 1 byte for specially crafted approxMatch search filters.
Not exploitable, no operational or security impact.

2 years agoITS#9951
Quanah Gibson-Mount [Mon, 5 Dec 2022 16:27:10 +0000 (16:27 +0000)] 
ITS#9951

2 years agoITS#9951 Postpone releasing a connection reference while in cn=monitor
Ondřej Kuzník [Wed, 16 Nov 2022 15:37:55 +0000 (15:37 +0000)] 
ITS#9951 Postpone releasing a connection reference while in cn=monitor

2 years agoITS#9947
Quanah Gibson-Mount [Mon, 5 Dec 2022 16:25:47 +0000 (16:25 +0000)] 
ITS#9947

2 years agoITS#9947 Fix race in epoch.c and simplify
Ondřej Kuzník [Mon, 7 Nov 2022 09:44:12 +0000 (09:44 +0000)] 
ITS#9947 Fix race in epoch.c and simplify

2 years agoITS#9940
Quanah Gibson-Mount [Mon, 5 Dec 2022 16:24:13 +0000 (16:24 +0000)] 
ITS#9940

2 years agoITS#9940 back-mdb: fully init empty DN in tool_entry_get
Howard Chu [Tue, 1 Nov 2022 17:13:23 +0000 (17:13 +0000)] 
ITS#9940 back-mdb: fully init empty DN in tool_entry_get

2 years agocleanup
Quanah Gibson-Mount [Tue, 1 Nov 2022 17:09:35 +0000 (17:09 +0000)] 
cleanup

2 years agoITS#9045
Quanah Gibson-Mount [Tue, 1 Nov 2022 17:07:08 +0000 (17:07 +0000)] 
ITS#9045

2 years agoITS#9045 Do not share cn=config entries with outside code
Ondřej Kuzník [Wed, 26 Oct 2022 14:55:18 +0000 (15:55 +0100)] 
ITS#9045 Do not share cn=config entries with outside code

config_back_entry_get currently returns the entry directly without
securing the rwlock, which is unsafe. However we can't keep holding it
on return in case the caller decides to hold onto the entry
indefinitely, hence rlock+entry_dup+runlock.

2 years agoITS#9942
Quanah Gibson-Mount [Tue, 1 Nov 2022 17:04:47 +0000 (17:04 +0000)] 
ITS#9942

2 years agoITS#9942 back-mdb: always release entries from Add ops
Howard Chu [Thu, 27 Oct 2022 14:47:00 +0000 (15:47 +0100)] 
ITS#9942 back-mdb: always release entries from Add ops

2 years agoITS#9598 Do not track olcIncomingConnections in lloadd/test007
Ondřej Kuzník [Mon, 31 Oct 2022 09:26:12 +0000 (09:26 +0000)] 
ITS#9598 Do not track olcIncomingConnections in lloadd/test007

Some values we export in cn=monitor are not managed in a single place,
instead, a task exists that gathers a snapshot of the lloadd state and
stores it for monitor consumption. This exposes a race between the test
reading it out and lloadd updating this cached copy. While we still have
to rely on a shell, rather than being intelligent about whether or not
we should emit a readout into search.out or wait and try again (which is
what test004-monitor does), just filter this attribute out.

2 years agoITS#9941
Quanah Gibson-Mount [Tue, 1 Nov 2022 17:02:51 +0000 (17:02 +0000)] 
ITS#9941

2 years agoITS#9941 Fix asyncmeta manpage to clarify that only round-robin scheduling is used...
Nadezhda Ivanova [Thu, 27 Oct 2022 09:58:43 +0000 (12:58 +0300)] 
ITS#9941 Fix asyncmeta manpage to clarify that only round-robin scheduling is used for target connections.

2 years agoITS#9899
Quanah Gibson-Mount [Tue, 1 Nov 2022 16:58:47 +0000 (16:58 +0000)] 
ITS#9899

2 years agoITS#9899 fix use of non-standard u_char/u_int types
Howard Chu [Wed, 26 Oct 2022 15:33:30 +0000 (16:33 +0100)] 
ITS#9899 fix use of non-standard u_char/u_int types

2 years agoITS#9935, ITS#9936, ITS#9937
Quanah Gibson-Mount [Tue, 25 Oct 2022 19:14:54 +0000 (19:14 +0000)] 
ITS#9935, ITS#9936, ITS#9937

2 years agoITS#9937 libldap: fix put_simple_filter() with invalid filter
Howard Chu [Thu, 20 Oct 2022 11:38:02 +0000 (12:38 +0100)] 
ITS#9937 libldap: fix put_simple_filter() with invalid filter

Add check for trivial input string.

2 years agoITS#9936 slapcat/slapschema: fix free of subtree cmdline option
Howard Chu [Thu, 20 Oct 2022 11:27:01 +0000 (12:27 +0100)] 
ITS#9936 slapcat/slapschema: fix free of subtree cmdline option

Must dup arg since subtree may also come from parsed URL.

2 years agoITS#9935 slapd UTF8StringValidate: fix read past end of string
Howard Chu [Thu, 20 Oct 2022 11:20:00 +0000 (12:20 +0100)] 
ITS#9935 slapd UTF8StringValidate: fix read past end of string

Harmless, length check at end of routine would have returned an
error anyway.

2 years agoITS#9930
Quanah Gibson-Mount [Tue, 25 Oct 2022 16:05:05 +0000 (16:05 +0000)] 
ITS#9930

2 years agoITS#9930 fix cn=config / write_waiter deadlock
Howard Chu [Fri, 14 Oct 2022 14:19:22 +0000 (15:19 +0100)] 
ITS#9930 fix cn=config / write_waiter deadlock

If a writer is blocked and a config pause is pending, just
close the blocked connection. Don't wait around for a slow
client to catch up.

2 years agoFix ITS#9912 description
Quanah Gibson-Mount [Mon, 17 Oct 2022 17:10:02 +0000 (17:10 +0000)] 
Fix ITS#9912 description

2 years agoFix description of ITS#9860
Quanah Gibson-Mount [Mon, 17 Oct 2022 16:43:45 +0000 (16:43 +0000)] 
Fix description of ITS#9860

2 years agoITS#9925
Quanah Gibson-Mount [Thu, 13 Oct 2022 15:46:05 +0000 (15:46 +0000)] 
ITS#9925

2 years agoITS#9925 Fix some ancient #ifdef checks
Connor Smith [Mon, 3 Oct 2022 10:11:10 +0000 (11:11 +0100)] 
ITS#9925 Fix some ancient #ifdef checks

Use #elif defined(...) for HAVE_WINSOCK and MACOS. All other instances
of these macros use #ifdef or similar. A compiler may warn about them
not being defined.

In libraries/liblber/sockbuf.c, (DOS && PCNFS) and (DOS && NCSA) were
replaced with HAVE_PCNFS and HAVE_NCSA, respectively. It seems logical
to do the same at the only remaining occurrence of DOS, PCNFS, and NCSA.

Use #if HARDCODE_DATA consistently, replacing two instances of #ifdef.
HARDCODE_DATA is always defined, and this way you can set HARDCODE_DATA
to 0 and have it work, rather than it going down the wrong branch and
failing in these two cases.

2 years agoITS#9907 Move TLS context cleanup into lload_global_destroy
Ondřej Kuzník [Wed, 12 Oct 2022 10:01:53 +0000 (11:01 +0100)] 
ITS#9907 Move TLS context cleanup into lload_global_destroy

2 years agoITS#9926 test085 additional fix
Howard Chu [Tue, 11 Oct 2022 14:25:29 +0000 (15:25 +0100)] 
ITS#9926 test085 additional fix

Git doesn't recreate empty directories, make it explicitly

2 years agoITS#9931
Quanah Gibson-Mount [Thu, 13 Oct 2022 15:44:58 +0000 (15:44 +0000)] 
ITS#9931

2 years agoITS#9931 test scripts: fix BSD vs GNU date syntax
Howard Chu [Tue, 11 Oct 2022 16:03:34 +0000 (17:03 +0100)] 
ITS#9931 test scripts: fix BSD vs GNU date syntax

2 years agoITS#9931 test082 fix sed portability
Howard Chu [Tue, 11 Oct 2022 14:21:43 +0000 (15:21 +0100)] 
ITS#9931 test082 fix sed portability

2 years agoITS#9931 test scripts: fix BSD vs GNU date syntax
Howard Chu [Tue, 11 Oct 2022 14:14:54 +0000 (15:14 +0100)] 
ITS#9931 test scripts: fix BSD vs GNU date syntax

2 years agoITS#9931 test079: fix ldapsearch invocations
Howard Chu [Tue, 11 Oct 2022 13:06:46 +0000 (14:06 +0100)] 
ITS#9931 test079: fix ldapsearch invocations

2 years agoITS#9929
Quanah Gibson-Mount [Mon, 10 Oct 2022 17:08:53 +0000 (17:08 +0000)] 
ITS#9929

2 years agoITS#9929 dynlist: avoid unnecessary search for dynamic lists
Howard Chu [Sun, 9 Oct 2022 10:51:54 +0000 (11:51 +0100)] 
ITS#9929 dynlist: avoid unnecessary search for dynamic lists

Was broken if only dynamic lists were configured, and not groups. Optional config URIs were being ignored. Don't prevent returning dynamic lists if dynamic groups were part of search.

3 years agoITS#9926
Quanah Gibson-Mount [Thu, 6 Oct 2022 16:44:15 +0000 (16:44 +0000)] 
ITS#9926

3 years agoITS#9926 drop symlinks from homedir testdata
Howard Chu [Thu, 6 Oct 2022 14:31:44 +0000 (15:31 +0100)] 
ITS#9926 drop symlinks from homedir testdata

Create them when running the test script instead.

3 years agoITS#9926 Drop unneeded symlinks from source
Ondřej Kuzník [Thu, 6 Oct 2022 13:50:55 +0000 (14:50 +0100)] 
ITS#9926 Drop unneeded symlinks from source

3 years agoMerge remote-tracking branch 'origin/mdb.RE/0.9' into OPENLDAP_REL_ENG_2_6
Quanah Gibson-Mount [Tue, 4 Oct 2022 14:29:39 +0000 (14:29 +0000)] 
Merge remote-tracking branch 'origin/mdb.RE/0.9' into OPENLDAP_REL_ENG_2_6

3 years agoPrepare for release (0.9.30)
Quanah Gibson-Mount [Tue, 4 Oct 2022 14:23:03 +0000 (14:23 +0000)] 
Prepare for release (0.9.30)

3 years agoITS#9915
Quanah Gibson-Mount [Mon, 3 Oct 2022 20:26:19 +0000 (20:26 +0000)] 
ITS#9915

3 years agoITS#9915 - Clarify quoting should only be used with slapd.conf configurations
Quanah Gibson-Mount [Mon, 3 Oct 2022 16:49:31 +0000 (16:49 +0000)] 
ITS#9915 - Clarify quoting should only be used with slapd.conf configurations

3 years agoITS#9917
Quanah Gibson-Mount [Mon, 3 Oct 2022 19:26:22 +0000 (19:26 +0000)] 
ITS#9917

3 years agoITS#9917 Remove 'h' and 'p' from options[] in client tools
Thomas Daniels [Mon, 19 Sep 2022 22:30:05 +0000 (00:30 +0200)] 
ITS#9917 Remove 'h' and 'p' from options[] in client tools

The options -h and -p got removed from client tools in commit
66af4cfd5d3c559fcdf6d722b02fa66416b95f01. However, they were still
present in the options[] array in several client tools source files. So,
if one of those tools got executed with -h or -p followed by a value,
this lead to the error "unrecognized option -", without mentioning
which option was problematic. Removing 'h' and 'p' from options[] fixes
this.

3 years agoITS#9919
Quanah Gibson-Mount [Mon, 3 Oct 2022 16:40:10 +0000 (16:40 +0000)] 
ITS#9919

3 years agoITS#9924
Quanah Gibson-Mount [Mon, 3 Oct 2022 16:35:42 +0000 (16:35 +0000)] 
ITS#9924

3 years agoITS#9924 slapo-deref: plug memleak
Howard Chu [Thu, 29 Sep 2022 15:02:57 +0000 (16:02 +0100)] 
ITS#9924 slapo-deref: plug memleak

memory alloc'd by bvarray_dup must be freed by bvarray_free, not regular free.

3 years agoITS#9919 - Mark infrequently used functions as cold rather than manually putting...
Mike Hommey [Thu, 3 Feb 2022 23:48:06 +0000 (08:48 +0900)] 
ITS#9919 - Mark infrequently used functions as cold rather than manually putting them in a separate section

3 years agoITS#9030
Quanah Gibson-Mount [Mon, 26 Sep 2022 16:52:55 +0000 (16:52 +0000)] 
ITS#9030

3 years agoITS#9892
Quanah Gibson-Mount [Mon, 26 Sep 2022 16:50:01 +0000 (16:50 +0000)] 
ITS#9892

3 years agoITS#9907 Some tools consider abandoned global data a leak
Ondřej Kuzník [Thu, 15 Sep 2022 08:15:55 +0000 (09:15 +0100)] 
ITS#9907 Some tools consider abandoned global data a leak

3 years agoITS#9892 Free operation data at the end of a transaction
Ondřej Kuzník [Thu, 15 Sep 2022 08:14:10 +0000 (09:14 +0100)] 
ITS#9892 Free operation data at the end of a transaction

3 years agoITS#9030 - Use sys/cachectl.h rather than asm/cachectl.h on mips
Mike Hommey [Thu, 6 Jun 2019 00:06:06 +0000 (09:06 +0900)] 
ITS#9030 - Use sys/cachectl.h rather than asm/cachectl.h on mips

It also contains the cacheflush function declaration.

3 years agoITS#9913
Quanah Gibson-Mount [Mon, 12 Sep 2022 21:28:55 +0000 (21:28 +0000)] 
ITS#9913

3 years agoITS#9339
Quanah Gibson-Mount [Mon, 12 Sep 2022 21:27:18 +0000 (21:27 +0000)] 
ITS#9339

3 years agoITS#9912
Quanah Gibson-Mount [Mon, 12 Sep 2022 21:24:53 +0000 (21:24 +0000)] 
ITS#9912

3 years agoITS#9437
Quanah Gibson-Mount [Mon, 12 Sep 2022 21:16:29 +0000 (21:16 +0000)] 
ITS#9437

3 years agoITS#9908
Quanah Gibson-Mount [Mon, 12 Sep 2022 21:15:17 +0000 (21:15 +0000)] 
ITS#9908

3 years agoITS#6035
Quanah Gibson-Mount [Mon, 12 Sep 2022 21:13:35 +0000 (21:13 +0000)] 
ITS#6035

3 years agoITS#9817
Quanah Gibson-Mount [Mon, 12 Sep 2022 21:13:02 +0000 (21:13 +0000)] 
ITS#9817

3 years agoITS#9438
Quanah Gibson-Mount [Mon, 12 Sep 2022 21:11:52 +0000 (21:11 +0000)] 
ITS#9438

3 years agoITS#9907
Quanah Gibson-Mount [Mon, 12 Sep 2022 21:11:12 +0000 (21:11 +0000)] 
ITS#9907

3 years agoITS#9906
Quanah Gibson-Mount [Mon, 12 Sep 2022 21:10:32 +0000 (21:10 +0000)] 
ITS#9906

3 years agoITS#9913 Protect code in clients_destroy and tier_destroy
Ondřej Kuzník [Fri, 2 Sep 2022 12:23:17 +0000 (13:23 +0100)] 
ITS#9913 Protect code in clients_destroy and tier_destroy

3 years agoITS#9339 Free remembered cookies on syncinfo free
Ondřej Kuzník [Fri, 2 Sep 2022 12:00:17 +0000 (13:00 +0100)] 
ITS#9339 Free remembered cookies on syncinfo free

3 years agoITS#9817 One more leak plugged
Ondřej Kuzník [Fri, 2 Sep 2022 11:58:48 +0000 (12:58 +0100)] 
ITS#9817 One more leak plugged

3 years agoITS#9907 Do not redefine variables inherited from slapd
Ondřej Kuzník [Fri, 2 Sep 2022 11:56:25 +0000 (12:56 +0100)] 
ITS#9907 Do not redefine variables inherited from slapd

3 years agoITS#9912 slapd: urls comes from optarg, not allocated
Howard Chu [Fri, 2 Sep 2022 03:01:46 +0000 (04:01 +0100)] 
ITS#9912 slapd: urls comes from optarg, not allocated

May leak on Windows if set in registry. Don't care.

3 years agoITS#9437 Create testdir before we need it
Ondřej Kuzník [Thu, 1 Sep 2022 10:13:37 +0000 (11:13 +0100)] 
ITS#9437 Create testdir before we need it

3 years agoITS#9908 slapd-tester: plug LDAP* leak on bind retries
Ondřej Kuzník [Wed, 31 Aug 2022 16:28:42 +0000 (17:28 +0100)] 
ITS#9908 slapd-tester: plug LDAP* leak on bind retries

3 years agoITS#6035 Plug olcAuthIDRewrite cn=config leak
Ondřej Kuzník [Wed, 31 Aug 2022 12:53:13 +0000 (13:53 +0100)] 
ITS#6035 Plug olcAuthIDRewrite cn=config leak

3 years agoITS#9817 Fix leaks and nul-terminate string passed to ldap_bv2dn
Ondřej Kuzník [Tue, 30 Aug 2022 12:22:45 +0000 (13:22 +0100)] 
ITS#9817 Fix leaks and nul-terminate string passed to ldap_bv2dn

3 years agoITS#9438 slapo-remoteauth: plug config leaks
Ondřej Kuzník [Wed, 31 Aug 2022 11:37:13 +0000 (12:37 +0100)] 
ITS#9438 slapo-remoteauth: plug config leaks

3 years agoITS#9907 Plug shutdown related leaks in lloadd
Ondřej Kuzník [Tue, 30 Aug 2022 12:25:18 +0000 (13:25 +0100)] 
ITS#9907 Plug shutdown related leaks in lloadd

3 years agoITS#9907 Do not redefine variables inherited from slapd
Ondřej Kuzník [Tue, 30 Aug 2022 12:24:01 +0000 (13:24 +0100)] 
ITS#9907 Do not redefine variables inherited from slapd

3 years agoITS#9906 Do not leak cn=monitor related allocs in lloadd
Ondřej Kuzník [Tue, 30 Aug 2022 12:21:32 +0000 (13:21 +0100)] 
ITS#9906 Do not leak cn=monitor related allocs in lloadd

3 years agoITS#9906 Do not touch subsys members after mss_destroy called
Ondřej Kuzník [Tue, 30 Aug 2022 12:17:27 +0000 (13:17 +0100)] 
ITS#9906 Do not touch subsys members after mss_destroy called

3 years agoITS#9897
Quanah Gibson-Mount [Tue, 30 Aug 2022 16:10:15 +0000 (16:10 +0000)] 
ITS#9897

3 years agoITS#9897 fix dynlist to ignore entries with wrong objectclass
Howard Chu [Mon, 8 Aug 2022 17:03:59 +0000 (18:03 +0100)] 
ITS#9897 fix dynlist to ignore entries with wrong objectclass

3 years agoITS#9904
Quanah Gibson-Mount [Mon, 29 Aug 2022 16:39:15 +0000 (16:39 +0000)] 
ITS#9904

3 years agoITS#9904 ldap_url_parsehosts: check for strdup failure
Howard Chu [Thu, 25 Aug 2022 15:13:21 +0000 (16:13 +0100)] 
ITS#9904 ldap_url_parsehosts: check for strdup failure

Avoid unnecessary strdup in IPv6 addr parsing, check for strdup
failure when dup'ing scheme.

Code present since 2000, 8da110a9e726dbc612b302feafe0109271e6bc59

3 years agoITS#9904
Quanah Gibson-Mount [Wed, 24 Aug 2022 18:23:30 +0000 (18:23 +0000)] 
ITS#9904

3 years agoITS#9904 ldif_open_url: check for ber_strdup failure
Howard Chu [Wed, 24 Aug 2022 13:40:51 +0000 (14:40 +0100)] 
ITS#9904 ldif_open_url: check for ber_strdup failure

Code present since 1999, df8f7cbb9b79be3be9205d116d1dd0b263d6861a

3 years agoITS#9900 - Regenerate configure
Quanah Gibson-Mount [Wed, 24 Aug 2022 18:19:53 +0000 (18:19 +0000)] 
ITS#9900 - Regenerate configure

3 years agoITS#9900
Quanah Gibson-Mount [Wed, 24 Aug 2022 18:19:39 +0000 (18:19 +0000)] 
ITS#9900

3 years agoITS#9900 configure.ac: fix bashism
Howard Chu [Wed, 10 Aug 2022 18:32:35 +0000 (19:32 +0100)] 
ITS#9900 configure.ac: fix bashism

Broken in 629cafc98d4cd2ec1eec83979d69008c01b4d238 ITS#8707

3 years agoITS#9898, ITS#9899, ITS#9901
Quanah Gibson-Mount [Wed, 24 Aug 2022 18:19:06 +0000 (18:19 +0000)] 
ITS#9898, ITS#9899, ITS#9901

3 years agoITS#9901 libldap: fix non-std printf %p arguments
Michael Osipov [Tue, 9 Aug 2022 15:33:35 +0000 (17:33 +0200)] 
ITS#9901 libldap: fix non-std printf %p arguments

3 years agoITS#9899 libldap: fix non-std syntax in cyrus.c
Howard Chu [Tue, 9 Aug 2022 17:13:31 +0000 (18:13 +0100)] 
ITS#9899 libldap: fix non-std syntax in cyrus.c

Broken in 3cd50fa8b32a21040a9892e2a8a7a9dfc7541ce6 for ITS#9189

3 years agoITS#9898 tests: fix slapd-addel non-std syntax
Howard Chu [Tue, 9 Aug 2022 17:11:30 +0000 (18:11 +0100)] 
ITS#9898 tests: fix slapd-addel non-std syntax

Broken in f5bef58cae5e16d56c48b1efd55249fa7ce54cc6

3 years agoITS#9894 - Regenerate configure
Quanah Gibson-Mount [Wed, 24 Aug 2022 17:46:20 +0000 (17:46 +0000)] 
ITS#9894 - Regenerate configure

3 years agoITS#9894
Quanah Gibson-Mount [Wed, 24 Aug 2022 15:52:54 +0000 (15:52 +0000)] 
ITS#9894

3 years agoITS#9894 don't use gmake-specific features
Howard Chu [Sun, 7 Aug 2022 01:42:33 +0000 (02:42 +0100)] 
ITS#9894 don't use gmake-specific features

3 years agoITS#9895
Quanah Gibson-Mount [Wed, 24 Aug 2022 15:51:10 +0000 (15:51 +0000)] 
ITS#9895