]> git.ipfire.org Git - thirdparty/dovecot/core.git/log
thirdparty/dovecot/core.git
14 years agodbox: Fixed reading attachments for compressed mails.
Timo Sirainen [Fri, 3 Dec 2010 10:15:48 +0000 (10:15 +0000)] 
dbox: Fixed reading attachments for compressed mails.

14 years agodbox: Added dbox_file_get_plaintext_size() for easily getting it.
Timo Sirainen [Fri, 3 Dec 2010 10:15:20 +0000 (10:15 +0000)] 
dbox: Added dbox_file_get_plaintext_size() for easily getting it.

14 years agoLog login pid/id for internal failures to allow matching errors between processes.
Timo Sirainen [Fri, 3 Dec 2010 10:05:38 +0000 (10:05 +0000)] 
Log login pid/id for internal failures to allow matching errors between processes.

14 years agolib-storage: Fixed storing newlines at the end of base64 attachments.
Timo Sirainen [Fri, 3 Dec 2010 09:10:12 +0000 (09:10 +0000)] 
lib-storage: Fixed storing newlines at the end of base64 attachments.

14 years agoistream-base64-encoder: Fixed reading when parent stream returned little data.
Timo Sirainen [Fri, 3 Dec 2010 09:09:10 +0000 (09:09 +0000)] 
istream-base64-encoder: Fixed reading when parent stream returned little data.

14 years agoCompiler warning fixes.
Timo Sirainen [Fri, 3 Dec 2010 07:39:13 +0000 (07:39 +0000)] 
Compiler warning fixes.

14 years agoioloop: Don't leak memory when detecting a leaked timeout.
Timo Sirainen [Fri, 3 Dec 2010 07:12:20 +0000 (07:12 +0000)] 
ioloop: Don't leak memory when detecting a leaked timeout.

14 years agoioloop log: Added asserts
Timo Sirainen [Fri, 3 Dec 2010 07:06:34 +0000 (07:06 +0000)] 
ioloop log: Added asserts

14 years agomail storage service: Use ioloop log prefix automation.
Timo Sirainen [Fri, 3 Dec 2010 07:00:17 +0000 (07:00 +0000)] 
mail storage service: Use ioloop log prefix automation.
This properly fixes imap/pop3 when using with client_limit>1.

14 years agoioloop: Added support for per-io/timeout callback log prefix automation.
Timo Sirainen [Fri, 3 Dec 2010 06:58:38 +0000 (06:58 +0000)] 
ioloop: Added support for per-io/timeout callback log prefix automation.

14 years agoimap, pop3: Removed previous log prefix hack.
Timo Sirainen [Fri, 3 Dec 2010 06:57:58 +0000 (06:57 +0000)] 
imap, pop3: Removed previous log prefix hack.

14 years agoimap, pop3: Small optimization to last logging change.
Timo Sirainen [Fri, 3 Dec 2010 05:46:57 +0000 (05:46 +0000)] 
imap, pop3: Small optimization to last logging change.
Also added FIXMEs. This is an ugly way to change log prefixes.

14 years agoimap, pop3: Try to use the correct log prefix when service_count!=1.
Timo Sirainen [Fri, 3 Dec 2010 05:43:16 +0000 (05:43 +0000)] 
imap, pop3: Try to use the correct log prefix when service_count!=1.

14 years agolib-index: Added "transaction boundary" record for future compatibility.
Timo Sirainen [Fri, 3 Dec 2010 04:25:06 +0000 (04:25 +0000)] 
lib-index: Added "transaction boundary" record for future compatibility.

14 years agolib_init(): Call srand() with a bit better seed.
Timo Sirainen [Thu, 2 Dec 2010 22:59:42 +0000 (22:59 +0000)] 
lib_init(): Call srand() with a bit better seed.

14 years agoauth: Fail if auth client tries to use a duplicate ID.
Timo Sirainen [Thu, 2 Dec 2010 21:42:30 +0000 (21:42 +0000)] 
auth: Fail if auth client tries to use a duplicate ID.

14 years agolib-master: Try to use auth request ID numbers from wider range to ease debugging.
Timo Sirainen [Thu, 2 Dec 2010 21:42:18 +0000 (21:42 +0000)] 
lib-master: Try to use auth request ID numbers from wider range to ease debugging.

14 years agoauth: passdb credentials lookup fix when using multiple passdbs.
Timo Sirainen [Thu, 2 Dec 2010 19:10:23 +0000 (19:10 +0000)] 
auth: passdb credentials lookup fix when using multiple passdbs.
If at least one passdb returns "user unknown" and the last passdb returns
"credential lookup not supported", the proper return value is still
"user unknown".

14 years agolib-master: Added extra debug info for a "user not found" error message.
Timo Sirainen [Thu, 2 Dec 2010 17:38:08 +0000 (17:38 +0000)] 
lib-master: Added extra debug info for a "user not found" error message.

14 years agolib-index: Added a missing sanity check for expunge-guid record's uid.
Timo Sirainen [Thu, 2 Dec 2010 04:37:38 +0000 (04:37 +0000)] 
lib-index: Added a missing sanity check for expunge-guid record's uid.
This fixes a non-self healing assert-crash.

14 years agolmtp: Added lmtp_save_to_detail_mailbox setting.
Timo Sirainen [Tue, 30 Nov 2010 22:38:05 +0000 (22:38 +0000)] 
lmtp: Added lmtp_save_to_detail_mailbox setting.

14 years agomaster: Fixed crash due to recent SSL key password askpass change.
Timo Sirainen [Tue, 30 Nov 2010 15:01:06 +0000 (15:01 +0000)] 
master: Fixed crash due to recent SSL key password askpass change.

14 years agoaskpass: Removed unnecessary code.
Timo Sirainen [Tue, 30 Nov 2010 00:20:09 +0000 (00:20 +0000)] 
askpass: Removed unnecessary code.

14 years agoaskpass: Allow reading password from stdin even if it's not a tty.
Timo Sirainen [Tue, 30 Nov 2010 00:17:20 +0000 (00:17 +0000)] 
askpass: Allow reading password from stdin even if it's not a tty.

14 years agomaster: Use t_askpass() for getting the manual SSL key password.
Timo Sirainen [Tue, 30 Nov 2010 00:13:45 +0000 (00:13 +0000)] 
master: Use t_askpass() for getting the manual SSL key password.

14 years agot_askpass(): Removed a limit of 1024 bytes for the password.
Timo Sirainen [Tue, 30 Nov 2010 00:12:54 +0000 (00:12 +0000)] 
t_askpass(): Removed a limit of 1024 bytes for the password.

14 years agolmtp: Recent change broke accessing mail_temp_dir.
Timo Sirainen [Mon, 29 Nov 2010 23:58:19 +0000 (23:58 +0000)] 
lmtp: Recent change broke accessing mail_temp_dir.
Also when it happened, an error message wasn't always logged.

14 years agofs-sis: Memory leak fix.
Timo Sirainen [Mon, 29 Nov 2010 19:13:37 +0000 (19:13 +0000)] 
fs-sis: Memory leak fix.

14 years agodoveadm import: Free memory used by source storage at deinit.
Timo Sirainen [Mon, 29 Nov 2010 19:08:37 +0000 (19:08 +0000)] 
doveadm import: Free memory used by source storage at deinit.

14 years agoman: doveadm-import.1: Added missing argument descriptions.
Pascal Volk [Fri, 26 Nov 2010 23:06:24 +0000 (23:06 +0000)] 
man: doveadm-import.1: Added missing argument descriptions.

14 years agoTODO updated
Timo Sirainen [Fri, 26 Nov 2010 18:59:29 +0000 (18:59 +0000)] 
TODO updated

14 years agoauth sql/ldap: Allow using global %variables in iterate_query/filter.
Timo Sirainen [Fri, 26 Nov 2010 18:19:16 +0000 (18:19 +0000)] 
auth sql/ldap: Allow using global %variables in iterate_query/filter.
No per-query %variables are defined, but e.g. %{hostname} or %{env:*} can
be used.

14 years agologin: Fixed potential assert-crash during failed proxy authentication.
Timo Sirainen [Fri, 26 Nov 2010 17:46:49 +0000 (17:46 +0000)] 
login: Fixed potential assert-crash during failed proxy authentication.

14 years agoauth: Assume inet_listeners are auth client listeners if they exist.
Timo Sirainen [Fri, 26 Nov 2010 17:31:00 +0000 (17:31 +0000)] 
auth: Assume inet_listeners are auth client listeners if they exist.

14 years agoauth: Minor error message fix.
Timo Sirainen [Fri, 26 Nov 2010 17:27:44 +0000 (17:27 +0000)] 
auth: Minor error message fix.

14 years agoman: Added "-S socket_path" description.
Pascal Volk [Thu, 25 Nov 2010 17:44:02 +0000 (17:44 +0000)] 
man: Added "-S socket_path" description.

14 years agodoveadm: -s was already used by some mailbox commands, renamed to -S.
Timo Sirainen [Wed, 24 Nov 2010 18:56:48 +0000 (18:56 +0000)] 
doveadm: -s was already used by some mailbox commands, renamed to -S.
Also added -S to usage output.

14 years agodoveadm: Removed -s option from the usage message (according to 66428c763354)
Pascal Volk [Wed, 24 Nov 2010 17:20:33 +0000 (17:20 +0000)] 
doveadm: Removed -s option from the usage message (according to 66428c763354)

14 years agolib-storage: mail_temp_dir setting should have done %variable expansion.
Timo Sirainen [Tue, 23 Nov 2010 19:37:56 +0000 (19:37 +0000)] 
lib-storage: mail_temp_dir setting should have done %variable expansion.

14 years agodoveadm: Moved -s parameter among -u/-A parameters, since it's only used by mail...
Timo Sirainen [Tue, 23 Nov 2010 19:07:19 +0000 (19:07 +0000)] 
doveadm: Moved -s parameter among -u/-A parameters, since it's only used by mail commands.

14 years agoman: Added -s parameter.
Pascal Volk [Tue, 23 Nov 2010 18:42:27 +0000 (18:42 +0000)] 
man: Added -s parameter.

14 years agolib-index: Don't try to stat() in-memory index.
Timo Sirainen [Tue, 23 Nov 2010 18:26:38 +0000 (18:26 +0000)] 
lib-index: Don't try to stat() in-memory index.

14 years agoman: *roff syntax-fix.
Pascal Volk [Tue, 23 Nov 2010 17:39:19 +0000 (17:39 +0000)] 
man: *roff syntax-fix.

14 years agodoveadm: Added -s parameter to the usage message.
Pascal Volk [Tue, 23 Nov 2010 17:04:07 +0000 (17:04 +0000)] 
doveadm: Added -s parameter to the usage message.

14 years agoman: Make it clear that doveadm-import allows dest_parent to be ""
Timo Sirainen [Tue, 23 Nov 2010 17:05:04 +0000 (17:05 +0000)] 
man: Make it clear that doveadm-import allows dest_parent to be ""

14 years agoman: Added pointer to doveadm-import from doveadm main man page.
Timo Sirainen [Tue, 23 Nov 2010 16:55:55 +0000 (16:55 +0000)] 
man: Added pointer to doveadm-import from doveadm main man page.

14 years agomaildir: Log a warning if scanning new/ or cur/ takes over 60s.
Timo Sirainen [Tue, 23 Nov 2010 16:23:31 +0000 (16:23 +0000)] 
maildir: Log a warning if scanning new/ or cur/ takes over 60s.

14 years agolib-master: Added missing master_service_get_settings_parser() required by recent...
Timo Sirainen [Tue, 23 Nov 2010 16:11:15 +0000 (16:11 +0000)] 
lib-master: Added missing master_service_get_settings_parser() required by recent change.

14 years agolib-storage: If disable_reflink_copy_to=TRUE, disable hardlink/refcount copying.
Timo Sirainen [Tue, 23 Nov 2010 15:59:09 +0000 (15:59 +0000)] 
lib-storage: If disable_reflink_copy_to=TRUE, disable hardlink/refcount copying.

14 years agodoveadm server: Fixes to command/parameter handling.
Timo Sirainen [Tue, 23 Nov 2010 15:30:32 +0000 (15:30 +0000)] 
doveadm server: Fixes to command/parameter handling.

14 years agodoveadm: Added -s parameter to execute mail command via given doveadm socket.
Timo Sirainen [Tue, 23 Nov 2010 15:30:06 +0000 (15:30 +0000)] 
doveadm: Added -s parameter to execute mail command via given doveadm socket.

14 years agodoveadm-server: Don't disconnect client after each command.
Timo Sirainen [Tue, 23 Nov 2010 15:28:47 +0000 (15:28 +0000)] 
doveadm-server: Don't disconnect client after each command.

14 years agoimap: Make sure IDLE isn't broken too early if DONE is sent in multiple packets.
Timo Sirainen [Mon, 22 Nov 2010 19:04:13 +0000 (19:04 +0000)] 
imap: Make sure IDLE isn't broken too early if DONE is sent in multiple packets.

14 years agoquota: If user has unlimited quota, ignore any specific quota rules.
Timo Sirainen [Mon, 22 Nov 2010 18:35:07 +0000 (18:35 +0000)] 
quota: If user has unlimited quota, ignore any specific quota rules.

14 years agodoveadm-server: Fixed command parameter handling.
Timo Sirainen [Mon, 22 Nov 2010 18:21:25 +0000 (18:21 +0000)] 
doveadm-server: Fixed command parameter handling.

14 years agolib-master: Added missing anvil_client_is_connected()
Timo Sirainen [Fri, 19 Nov 2010 21:08:37 +0000 (21:08 +0000)] 
lib-master: Added missing anvil_client_is_connected()

14 years agoimap, pop3: Fixed giving any -parameters.
Timo Sirainen [Fri, 19 Nov 2010 16:24:41 +0000 (16:24 +0000)] 
imap, pop3: Fixed giving any -parameters.

14 years agoauth: If we get disconnected from anvil and can't reconnect, die.
Timo Sirainen [Thu, 18 Nov 2010 20:35:39 +0000 (20:35 +0000)] 
auth: If we get disconnected from anvil and can't reconnect, die.

14 years agoauth: Fixed assert-crash at deinit if there were clients left with pending auth requests.
Timo Sirainen [Thu, 18 Nov 2010 20:35:20 +0000 (20:35 +0000)] 
auth: Fixed assert-crash at deinit if there were clients left with pending auth requests.

14 years agosnarf: Added mbox_snarf setting to enable snarfing only optionally.
Timo Sirainen [Thu, 18 Nov 2010 19:32:50 +0000 (19:32 +0000)] 
snarf: Added mbox_snarf setting to enable snarfing only optionally.

14 years agoReplaced broken mbox-snarf plugin with a more generic snarf plugin.
Timo Sirainen [Thu, 18 Nov 2010 18:58:33 +0000 (18:58 +0000)] 
Replaced broken mbox-snarf plugin with a more generic snarf plugin.

14 years agopop3: Avoid crash when updating proctitle if client init fails.
Timo Sirainen [Thu, 18 Nov 2010 18:57:18 +0000 (18:57 +0000)] 
pop3: Avoid crash when updating proctitle if client init fails.

14 years agombox: Allow mail_privileged_group locking for INBOXes also in inbox=no namespaces.
Timo Sirainen [Thu, 18 Nov 2010 18:56:34 +0000 (18:56 +0000)] 
mbox: Allow mail_privileged_group locking for INBOXes also in inbox=no namespaces.

14 years agoconfigure: And small fix to previous --with-systemdsystemunitdir fix.
Timo Sirainen [Thu, 18 Nov 2010 18:51:34 +0000 (18:51 +0000)] 
configure: And small fix to previous --with-systemdsystemunitdir fix.

14 years agoconfigure: --with-systemdsystemunitdir wasn't working right.
Timo Sirainen [Thu, 18 Nov 2010 18:49:34 +0000 (18:49 +0000)] 
configure: --with-systemdsystemunitdir wasn't working right.

14 years agoconfigure: Use AS_HELP_STRING() macro.
Timo Sirainen [Thu, 18 Nov 2010 18:38:08 +0000 (18:38 +0000)] 
configure: Use AS_HELP_STRING() macro.

14 years agomaster: Compiling fix when systemd is enabled.
Timo Sirainen [Thu, 18 Nov 2010 18:28:40 +0000 (18:28 +0000)] 
master: Compiling fix when systemd is enabled.

14 years agoAdded support for systemd.
Timo Sirainen [Wed, 17 Nov 2010 18:40:52 +0000 (18:40 +0000)] 
Added support for systemd.
Based on patch by Christophe Fergeau

14 years agoconfigure: Use PKG_PROG_PKG_CONFIG to find pkg-config binary.
Timo Sirainen [Wed, 17 Nov 2010 18:21:46 +0000 (18:21 +0000)] 
configure: Use PKG_PROG_PKG_CONFIG to find pkg-config binary.

14 years agoistream-header-filter: Fixed header name validation to use case-insensitive comparison.
Timo Sirainen [Wed, 17 Nov 2010 18:10:46 +0000 (18:10 +0000)] 
istream-header-filter: Fixed header name validation to use case-insensitive comparison.

14 years agolib-master: If auth master login fails, make sure error message is logged.
Timo Sirainen [Wed, 17 Nov 2010 17:52:52 +0000 (17:52 +0000)] 
lib-master: If auth master login fails, make sure error message is logged.

14 years agomysql: When using multiple hosts, it never connected to more than the first one.
Timo Sirainen [Wed, 17 Nov 2010 16:55:56 +0000 (16:55 +0000)] 
mysql: When using multiple hosts, it never connected to more than the first one.

14 years agolib-sql: Connect earlier to fallback host when using multiple hosts and primary fails.
Timo Sirainen [Wed, 17 Nov 2010 16:55:44 +0000 (16:55 +0000)] 
lib-sql: Connect earlier to fallback host when using multiple hosts and primary fails.

14 years agomaster: Allow services' vsz_limit to be 0 (unlimited)
Timo Sirainen [Wed, 17 Nov 2010 14:33:46 +0000 (14:33 +0000)] 
master: Allow services' vsz_limit to be 0 (unlimited)

14 years agoServices' default vsz_limit wasn't actually using default_vsz_limit but rather 4 GB.
Timo Sirainen [Tue, 16 Nov 2010 19:58:03 +0000 (19:58 +0000)] 
Services' default vsz_limit wasn't actually using default_vsz_limit but rather 4 GB.

14 years agoFixed home=/home/./user style chrooting to work again.
Timo Sirainen [Tue, 16 Nov 2010 19:51:46 +0000 (19:51 +0000)] 
Fixed home=/home/./user style chrooting to work again.

14 years agomaster: Fail if service's vsz_limit is less than 1 kB
Timo Sirainen [Tue, 16 Nov 2010 19:32:51 +0000 (19:32 +0000)] 
master: Fail if service's vsz_limit is less than 1 kB

14 years agoimap/pop3-login: Default vsz_limit=64 caused it to be unlimited, not 64 MB.
Timo Sirainen [Tue, 16 Nov 2010 19:32:00 +0000 (19:32 +0000)] 
imap/pop3-login: Default vsz_limit=64 caused it to be unlimited, not 64 MB.

14 years agombox: Another utime()=EPERM log message hiding.
Timo Sirainen [Tue, 16 Nov 2010 18:51:37 +0000 (18:51 +0000)] 
mbox: Another utime()=EPERM log message hiding.

14 years agombox: Ignore utime()=EPERM failures when trying to set atime back.
Timo Sirainen [Tue, 16 Nov 2010 18:47:48 +0000 (18:47 +0000)] 
mbox: Ignore utime()=EPERM failures when trying to set atime back.
This happens with shared mboxes when file's owner isn't the process's euid.

14 years agoistream-base64-encoder: Set the stream seekable if parent stream is seekable.
Timo Sirainen [Mon, 15 Nov 2010 17:40:12 +0000 (17:40 +0000)] 
istream-base64-encoder: Set the stream seekable if parent stream is seekable.

14 years ago"Running standalone?" check now uses a new DOVECOT_CHILD_PROCESS environment rather...
Timo Sirainen [Mon, 15 Nov 2010 17:03:52 +0000 (17:03 +0000)] 
"Running standalone?" check now uses a new DOVECOT_CHILD_PROCESS environment rather than GENERATION.
The GENERATION environment was already set in some systems for Java.

14 years agolib-settings: Improved performance of previous duplicate key parsing change.
Timo Sirainen [Mon, 15 Nov 2010 16:49:26 +0000 (16:49 +0000)] 
lib-settings: Improved performance of previous duplicate key parsing change.

14 years agolib-settings: Fixed parsing settings when the key was duplicated to multiple roots.
Timo Sirainen [Mon, 15 Nov 2010 16:42:19 +0000 (16:42 +0000)] 
lib-settings: Fixed parsing settings when the key was duplicated to multiple roots.
Previously only the first one got the value set, now all of them get it.

14 years agoRemoved unused auth/mail_debug settings from structs.
Timo Sirainen [Mon, 15 Nov 2010 16:33:27 +0000 (16:33 +0000)] 
Removed unused auth/mail_debug settings from structs.

14 years agoistream-file: Minor error message fix.
Timo Sirainen [Mon, 15 Nov 2010 16:25:23 +0000 (16:25 +0000)] 
istream-file: Minor error message fix.

14 years agoAdded unit test for istream-base64-encoder.
Timo Sirainen [Mon, 15 Nov 2010 16:22:08 +0000 (16:22 +0000)] 
Added unit test for istream-base64-encoder.

14 years agoistream-base64-encoder: Fixed seeking to beginning of stream.
Timo Sirainen [Mon, 15 Nov 2010 16:21:45 +0000 (16:21 +0000)] 
istream-base64-encoder: Fixed seeking to beginning of stream.

14 years agoistream-base64-encoder: Don't add unwanted trailing [CR]LF
Timo Sirainen [Mon, 15 Nov 2010 16:06:58 +0000 (16:06 +0000)] 
istream-base64-encoder: Don't add unwanted trailing [CR]LF

14 years agodbox: dbox file could have been closed too early in some situations, causing EBADF...
Timo Sirainen [Mon, 15 Nov 2010 15:42:21 +0000 (15:42 +0000)] 
dbox: dbox file could have been closed too early in some situations, causing EBADF errors.

14 years agostream-base64-encoder: Added support for seeking backwards in stream.
Timo Sirainen [Mon, 15 Nov 2010 15:31:26 +0000 (15:31 +0000)] 
stream-base64-encoder: Added support for seeking backwards in stream.

14 years agoistream: Exported i_stream_default_seek()
Timo Sirainen [Mon, 15 Nov 2010 15:31:02 +0000 (15:31 +0000)] 
istream: Exported i_stream_default_seek()

14 years agosdbox: Fixed race condition when one session opens a mailbox while another is still...
Timo Sirainen [Mon, 15 Nov 2010 15:19:13 +0000 (15:19 +0000)] 
sdbox: Fixed race condition when one session opens a mailbox while another is still creating it.
This happened mostly when nonexistent INBOX was being opened by multiple
sessions at the same time.

14 years agoanvil: Don't die until all of our clients have gone.
Timo Sirainen [Wed, 10 Nov 2010 16:09:14 +0000 (16:09 +0000)] 
anvil: Don't die until all of our clients have gone.

14 years agoAdded env_get_environ_p() as more portable way of accessing environ variable.
Timo Sirainen [Tue, 9 Nov 2010 21:42:58 +0000 (21:42 +0000)] 
Added env_get_environ_p() as more portable way of accessing environ variable.
Implemented with OS X using _NSGetEnviron().

14 years agoexample-config: sendmail_path defaults to /usr/sbin/sendmail, not /usr/lib/sendmail
Timo Sirainen [Tue, 9 Nov 2010 21:17:15 +0000 (21:17 +0000)] 
example-config: sendmail_path defaults to /usr/sbin/sendmail, not /usr/lib/sendmail

14 years agoexample-config: Moved include conf.d/*.conf last in dovecot.conf.
Timo Sirainen [Tue, 9 Nov 2010 21:16:06 +0000 (21:16 +0000)] 
example-config: Moved include conf.d/*.conf last in dovecot.conf.
This fixes problems where conf.d/ files try to modify settings in dovecot.conf,
especially managesieve adding itself to protocols setting.

14 years agodsync: Don't assert-crash if trying to convert mailbox whose name is too long.
Timo Sirainen [Tue, 9 Nov 2010 21:12:35 +0000 (21:12 +0000)] 
dsync: Don't assert-crash if trying to convert mailbox whose name is too long.

14 years agoistream-[b]zlib: Corking now affects also the parent stream.
Timo Sirainen [Tue, 9 Nov 2010 21:03:34 +0000 (21:03 +0000)] 
istream-[b]zlib: Corking now affects also the parent stream.

14 years agoliblib: Delay sending log prefix updates until it's needed.
Timo Sirainen [Tue, 9 Nov 2010 20:25:36 +0000 (20:25 +0000)] 
liblib: Delay sending log prefix updates until it's needed.
This avoids sending them unnecessarily.