util: Terminate pakfire_copy() even if feof() does not work

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Silence the RUNPATH check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Remove any previously existing debuglinks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Ignore if source files don't exist

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

FHS: Permit sub-directories in /usr/src/debug

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Jenkins: Disable the broken branch check

For some reason this is (yet again) not working.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packages: Ignore dependencies starting with "#"

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

path: Convince the static analyzer that path is set

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Only call linkat() with a valid file descriptor

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Initialize tmppath in case there is an error

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

util: Implement rewind() that returns any errors

The Clang Static Analyzer complains that we don't check errno after
using rewind(). This patch adds a new version of this function which
returns an error.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Fix RELRO check

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packagelist: Fix keep going logic

This is supposed to store the last error code and return it when the
flag is set.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Fix check if we have an ELF file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "tests: Don't collect coverage information about tests"

This reverts commit bcb8a8de463b9a29969ef7acd78a58021f0bda55.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: (Re-)compress all debug information using Zstandard

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

CFLAGS: Deduplicate debugging information

  https://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html#index-fdebug-types-section

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Makefile: Link tests with -lgcov again

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

scripts: Remove the old strip script

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Actually strip binaries

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Don't complain if there is no symbol table

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Add function to replace file content from another fd

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

linter: Check that files in /usr/lib/debug are ELF and not stripped

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Fix removing items

This also now shrinks the array whenever possible so that we won't waste
any memory if the filelist shrinks by a large amount.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Clear number of entries after the filelist has been cleared

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Write the debug information directory the Build ID file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Add option to pass flags to open()

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Extract debug information into a separate file

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Extract sources in the main process again

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "configure: Link against libbfd"

This reverts commit 2a6657e51c66a5dc5cf1f5a059197d0be15a8ba1.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "stripper: Use libbfd to extract the Build ID"

This reverts commit 44ffbd6f1f47115072e8c8d4ea751f6eacb05dba.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Use libbfd to extract the Build ID

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

configure: Link against libbfd

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Extract the GNU Build ID

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Check if we actually returned a file handle

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Improve passing on error codes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Open the file only once

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

parser: Refactor unquoting strings

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Don't collect coverage information about tests

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Create a unified stripping function

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

scripts: Don't extract sources in the strip script any more

This has been moved to the stripper.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Show progress bar when stripping files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Implement copying sources

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

FHS: Permit debug sources

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Actually sort when adding files

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Drop the sort function again

The filelist was intended to be sorted all the time.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Fix return code when we run out of buffer space

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

filelist: Don't overwrite r when using a progress bar

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Run the stripping inside the jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

stripper: Keep a reference to the jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

file: Fix path when opening a file inside the jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

ctx: Set a flag when we are running inside the jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Change callback signature to include the context instead the inaccessible jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Add a function to call a custom callback inside the jail

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Pass the environment to the interactive shell

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Rename pakfire_jail_exec to pakfire_jail_exec_command

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

env: Declare the struct before importing anything

This silences a compiler warning.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Add tests for env

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Merge the basic environment with the custom environment

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Simplify reading the parser environment

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Move the environment into an extra object

This allows us to pass a custom environment to each command that we are
running. This helps us to keep the environment a lot cleaner.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Add struct to pass more stuff to commands

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Create a callback function that is called in the child process

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "file: Remove ELF detection with libelf"

This reverts commit 65fcf2eb3c4fceb81887bd969e68ceae8613e26e.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

Revert "stripper: Throw this away"

This reverts commit 76774bf62a622da82ca589519331371c71b87bf1.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Add a test to check if the log buffer limit works

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Check for matching files in a loop

When sending the filelist to scripts, we require the event loop to call
us again and again. This seems to cause a deadlock situation and we now
rather search for matching files in a loop until we have found a result
(or not).

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

packager: Sort files before writing the archive

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: log buffer: Test invalid function calls

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

log buffer: Check inputs on dequeue

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

log buffer: Since length is signed, we cannot assign -1

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Add simple tests for the log buffer

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

log buffer: Reset pointers when there is no more data

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: cgroups: Fix return code checks

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: Add check for expected return codes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Cleanup if we cannot create an eventfd

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Report correct error if clone3() failed

We should also clean up.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroups: Recursively delete cgroups

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

tests: string: Check if strings contain whitespace

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Return the correct exit code when a process has dumped

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Ignore if cgroup limits could not be applied

This should ideally not happen in a real environment, but sadly is a
restriction we have in Jenkins when we are running the tests.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Move cgroup accounting here

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Log the status code when a process exits abnormally

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroups: The static analyzer does not seem to understand how return things

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

path: Make the static analyzer happy again

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

xfer: Don't call fileno() with NULL

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

archive: Don't leak fd if archive could not be opened

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Enable accouting in the parent group

We cannot enable any of this in the child group because then we cannot
fork anything into it any more.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroup: Remove unused function to open root

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

build: Fail properly when we could not open a cgroup

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroups: Implement recursion again

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Check if we received a valid file descriptor for the cgroup

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroups: Don't automatically kill when destroying a cgroup

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroups: Always log the entire path

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroups: Use the correct function to retrieve the path

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jenkins: Enable coverage tests again

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroups: Log the entire path if we encountered a writing error

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

jail: Don't fail if we cannot enable accounting

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroups: Don't try reading memory stats when the memory controller is not enabled

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

cgroups: Fix error codes

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>