]>
git.ipfire.org Git - thirdparty/Python/cpython.git/log
Miss Islington (bot) [Tue, 25 Nov 2025 01:32:55 +0000 (02:32 +0100)]
[3.13] gh-141907: Better handle support for SHA3 for test_hashlib (GH-141908) (#141919)
gh-141907: Better handle support for SHA3 for test_hashlib (GH-141908)
* test_hashlib: better handle support for SHA3
It's possible that the SSL library supports only SHA3 algo and doesn't
have SHAKE one.
The current test wrongly detect this and set both HASH and HASHXOF to
None expecting to have the extra SHA3 attributes present but this should
only be true for SHAKE algo.
To better handle this, move the HASH condition to a dedicated try-expect
condition and check if HASHXOF is None in the relevant code effectively
checking if SHA3 is supported by the SSL library but SHAKE algo needs to
use the sha3module one.
---------
(cherry picked from commit
fee778265064c290ae1852916ff47fcc0ab4a29d )
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Co-authored-by: Christian Marangi <ansuelsmth@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Miss Islington (bot) [Mon, 24 Nov 2025 17:46:59 +0000 (18:46 +0100)]
[3.13] gh-129441: Fix some flakiness in test_instrumentation (gh-141881) (gh-141914)
Most of the `self.assertTrue(self.called)` checks are flaky because
the worker threads may sometimes finish before the main thread calls
`self.during_threads()`.
(cherry picked from commit
71126ab19c76d8227fc3b9c7c59b957ca82af4dd )
Co-authored-by: Sam Gross <colesbury@gmail.com>
Miss Islington (bot) [Mon, 24 Nov 2025 17:26:12 +0000 (18:26 +0100)]
[3.13] gh-141004: Document stack effect C APIs (GH-141843) (GH-141917)
gh-141004: Document stack effect C APIs (GH-141843)
(cherry picked from commit
e1f1df4082e2bc6cdb46be9984124c88a7b2ff0f )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Stan Ulbrych [Mon, 24 Nov 2025 16:56:15 +0000 (16:56 +0000)]
[3.13] GH-129805: Clean up some changes from GH-129806 (GH-133540) (#141165)
Co-authored-by: Brandt Bucher <brandt@python.org>
Miss Islington (bot) [Mon, 24 Nov 2025 14:59:30 +0000 (15:59 +0100)]
[3.13] gh-106318: Add examples for str.join() (GH-140315) (#141905)
Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Mon, 24 Nov 2025 14:57:50 +0000 (15:57 +0100)]
[3.13] gh-106318: Add example for str.format() (GH-137018) (#141903)
Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Hugo van Kemenade [Mon, 24 Nov 2025 14:29:49 +0000 (16:29 +0200)]
[3.13] gh-106318: Add example for str.isalpha() (GH-137557) (#141902)
Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
Miss Islington (bot) [Mon, 24 Nov 2025 14:08:14 +0000 (15:08 +0100)]
[3.13] gh-106318: Add example for str.isascii() (GH-137558) (#141899)
Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Miss Islington (bot) [Mon, 24 Nov 2025 13:40:39 +0000 (14:40 +0100)]
[3.13] gh-141004: Document `Py_ARRAY_LENGTH` (GH-141601) (GH-141896)
gh-141004: Document `Py_ARRAY_LENGTH` (GH-141601)
(cherry picked from commit
e0773eacb7e660b4fd6bd702b0a119e25ab3b012 )
Co-authored-by: Yashraj <yashrajpala8@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Miss Islington (bot) [Mon, 24 Nov 2025 13:19:53 +0000 (14:19 +0100)]
[3.13] gh-106318: Add example for str.isdecimal() (GH-137559) (#141894)
Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Miss Islington (bot) [Mon, 24 Nov 2025 03:09:40 +0000 (04:09 +0100)]
[3.13] gh-135335: Simplify preload regression test using __main__ (GH-138686) (#141887)
gh-135335: Simplify preload regression test using __main__ (GH-138686)
Simplify preload regression test using `__main__`
With the fix for gh-126631 `__main__` modules can be preloaded and the regression
test for gh-135335 can be simplified to just use a self-contained script rather
than requiring a module.
Note this assumes and implicitly tests that `__main__` is preloaded by default.
(cherry picked from commit
425f24e4fad672c211307a9f0018c8d39c4db9de )
Co-authored-by: Duane Griffin <duaneg@dghda.com>
Miss Islington (bot) [Sun, 23 Nov 2025 17:34:09 +0000 (18:34 +0100)]
[3.13] gh-141865: Fix translation of strings in `changes.py` extension (GH-141882) (#141884)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sam Gross [Sun, 23 Nov 2025 15:30:37 +0000 (10:30 -0500)]
[3.13] gh-120158: Fix inconsistent monitoring state when setting events too frequently (gh-141845) (gh-141880)
If we overflowed the global version counter (i.e., after 2*24 calls to
`_PyMonitoring_SetEvents`), we bailed out after setting global monitoring
events but before instrumenting code objects, which led to assertion errors
later on.
Also add a `time.sleep()` to `test_free_threading.test_monitoring` to avoid
overflowing the global version counter.
(cherry picked from commit
e457d60daafe66534283e0f79c81517634408e57 )
Miss Islington (bot) [Sun, 23 Nov 2025 10:16:25 +0000 (11:16 +0100)]
[3.13] gh-98552: Revert (unneeded, already done elsewhere) "flush std streams in the multiprocessing forkserver before fork (GH-141849)" (GH-141871) (#141873)
gh-98552: Revert (unneeded, already done elsewhere) "flush std streams in the multiprocessing forkserver before fork (GH-141849)" (GH-141871)
Revert (unneeded, already done elsewhere) "gh-98552: flush std streams in the multiprocessing forkserver before fork (GH-141849)"
This reverts commit
58badb1711e12b6e8b5240ab96cdd01b95012de7 .
(cherry picked from commit
614a28b3da1c898f29c34c14f59bf2d496dbd31d )
Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
Miss Islington (bot) [Sat, 22 Nov 2025 20:23:30 +0000 (21:23 +0100)]
[3.13] gh-98552: flush std streams in the multiprocessing forkserver before fork (GH-141849) (#141852)
gh-98552: flush std streams in the multiprocessing forkserver before fork (GH-141849)
* flush std streams in the multiprocessing forkserver before fork
* NEWS
(cherry picked from commit
58badb1711e12b6e8b5240ab96cdd01b95012de7 )
Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
Miss Islington (bot) [Sat, 22 Nov 2025 19:22:14 +0000 (20:22 +0100)]
[3.13] gh-101100: Fix sphinx warnings in `library/unittest.rst` (GH-140109) (#141854)
Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Miss Islington (bot) [Sat, 22 Nov 2025 18:53:14 +0000 (19:53 +0100)]
[3.13] gh-141801: Use accessors for ASN1_STRING fields in libssl (GH-141802) (#141848)
gh-141801: Use accessors for ASN1_STRING fields in libssl (GH-141802)
* gh-141801: Use accessors for ASN1_STRING fields
While ASN1_STRING is currently exposed, it is better to use the
accessors. See https://github.com/openssl/openssl/issues/29117 where, if
the type were opaque, OpenSSL's X509 objects could be much more
memory-efficient.
* Update Modules/_ssl.c
* Update Modules/_ssl.c
---------
(cherry picked from commit
c41fce08a5d7aae8fd9e3fa25e0ba521600e097c )
Co-authored-by: David Benjamin <davidben@davidben.net>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Miss Islington (bot) [Sat, 22 Nov 2025 17:18:55 +0000 (18:18 +0100)]
[3.13] gh-101100: Fix all Sphinx warnings in `Doc/library/subprocess.rst` (GH-139576) (#139788)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Paresh Joshi [Sat, 22 Nov 2025 09:38:34 +0000 (15:08 +0530)]
[3.13] gh-141612: improve `test_trampoline_works_with_forks` coverage (GH-141613) (#141826)
* gh-141612: improve `test_trampoline_works_with_forks` coverage (#141613)
(cherry picked from commit
f15f6d0ba3715c67643e58959459b0e84a67b183 )
Hugo van Kemenade [Fri, 21 Nov 2025 18:10:01 +0000 (20:10 +0200)]
[3.13] gh-141659: Fix bad file descriptor error in subprocess on AIX (GH-141660) (#141828)
Co-authored-by: Ayappan Perumal <ayappap2@in.ibm.com>
Miss Islington (bot) [Thu, 20 Nov 2025 16:35:54 +0000 (17:35 +0100)]
[3.13] Docs: Fix typo in socketserver documentation (GH-140956) (#141798)
Co-authored-by: Thomas Ballard <thomasballard0503@gmail.com>
Miss Islington (bot) [Thu, 20 Nov 2025 16:23:26 +0000 (17:23 +0100)]
[3.13] GH-137841: Open tzdata/zones file with UTF-8 encoding (GH-137872) (#141608)
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Miss Islington (bot) [Thu, 20 Nov 2025 14:30:51 +0000 (15:30 +0100)]
[3.13] gh-141004: Document `Py_MakePendingCalls` (GH-141137) (GH-141788)
gh-141004: Document `Py_MakePendingCalls` (GH-141137)
(cherry picked from commit
ce701032a3d5d3597466d5836ebe989db6eda2aa )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Miss Islington (bot) [Thu, 20 Nov 2025 13:55:17 +0000 (14:55 +0100)]
[3.13] gh-141004: Document missing `PyDateTime*` APIs (GH-141543) (GH-141792)
gh-141004: Document missing `PyDateTime*` APIs (GH-141543)
(cherry picked from commit
4273616ebfbfe2a7cfd93460a08364f5a40f89e2 )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Miss Islington (bot) [Thu, 20 Nov 2025 13:52:36 +0000 (14:52 +0100)]
[3.13] gh-141004: Document missing generator APIs (GH-141409) (GH-141790)
gh-141004: Document missing generator APIs (GH-141409)
(cherry picked from commit
2da7ecc680548804ea99d62ba4d228cfa5011671 )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Miss Islington (bot) [Thu, 20 Nov 2025 09:20:00 +0000 (10:20 +0100)]
[3.13] gh-141757: Comply with pickle protocol in test_reduce_5tuple (GH-141759) (GH-141783)
The 5th element of the __reduce__ tuple should be an iterator.
(cherry picked from commit
41b9ad5b38e913194a5cc88f0e7cfc096787b664 )
Co-authored-by: Arseny Boykov <36469655+Bobronium@users.noreply.github.com>
Miss Islington (bot) [Wed, 19 Nov 2025 20:36:32 +0000 (21:36 +0100)]
[3.13] Remove GvR from '_stdauthor' in Doc/conf.py (GH-141765) (#141768)
Co-authored-by: Guido van Rossum <guido@python.org>
Co-authored-by: Guido van Rossum <gvanrossum@microsoft.com>
Miss Islington (bot) [Wed, 19 Nov 2025 18:38:53 +0000 (19:38 +0100)]
[3.13] gh-141004: Document `Py_LOCAL` and `Py_LOCAL_INLINE` (GH-141725) (GH-141762)
gh-141004: Document `Py_LOCAL` and `Py_LOCAL_INLINE` (GH-141725)
(cherry picked from commit
3149d64c93f02217eb01c0fd82c26a685b5281c1 )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Victor Stinner [Wed, 19 Nov 2025 14:28:31 +0000 (15:28 +0100)]
[3.13] gh-141570: can_colorize: Expect fileno() to raise OSError, as documented (#141716) (#141748)
gh-141570: can_colorize: Expect fileno() to raise OSError, as documented (#141716)
In Fedora, we've been given a slightly incomplete reproducer for a problematic
Python 3.14 color-related change in argparse that leads to an exception when
Python is used from mod_wsgi: https://bugzilla.redhat.com/
2414940
mod_wsgi replaces sys.stdout with a custom object that raises OSError on .fileno():
https://github.com/GrahamDumpleton/mod_wsgi/blob/
8460dbfcd5c7108892b3cde9fab7cbc1caa27886 /src/server/wsgi_logger.c#L434-L440
This should be supported, as the documentation of fileno explicitly says:
> An OSError is raised if the IO object does not use a file descriptor.
https://docs.python.org/3.14/library/io.html#io.IOBase.fileno
The previously expected exception inherits from OSError,
so it is still expected.
Fixes https://github.com/python/cpython/issues/141570
(cherry picked from commit
96f496a949b05054d0d043c3085f00cec2f83bf5 )
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
Miss Islington (bot) [Wed, 19 Nov 2025 12:17:54 +0000 (13:17 +0100)]
[3.13] gh-140875: Fix handling of unclosed charrefs before EOF in HTMLParser (GH-140904) (GH-141746)
(cherry picked from commit
95296a9d40aa2d58502a09e86e2a93c03df23366 )
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Miss Islington (bot) [Wed, 19 Nov 2025 11:07:07 +0000 (12:07 +0100)]
[3.13] Correct class name from PullDom to PullDOM (GH-141207) (#141742)
Co-authored-by: Guo Ci <zguoci@gmail.com>
Sergey B Kirpichev [Tue, 18 Nov 2025 13:32:48 +0000 (16:32 +0300)]
[3.13] gh-141004: Document Py_HUGE_VAL/IS_FINITE/IS_INFINITE/IS_NAN (GH-141544) (#141700)
(cherry picked from commit
630cd37bfae0fc4021d9e9461b94d36e7ce6b95c )
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Petr Viktorin [Tue, 18 Nov 2025 12:34:40 +0000 (13:34 +0100)]
[3.13] gh-140691: urllib.request: Close FTP control socket if data socket can't connect (GH-140835) (GH-141657)
(cherry picked from commit
f2bce51b984f52db14d90f7bbd0b7df00b7c5637 )
Co-authored-by: codenamenam <bluetire27@gmail.com>
Miss Islington (bot) [Tue, 18 Nov 2025 11:38:38 +0000 (12:38 +0100)]
[3.13] gh-140873: Fix the singledispatchmethod documentation (GH-141523) (GH-141710)
It does not support non-descriptor callables yet.
(cherry picked from commit
d89eb2f984032836e268d1b9af9c2400cddc474e )
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Miss Islington (bot) [Tue, 18 Nov 2025 10:38:16 +0000 (11:38 +0100)]
[3.13] Add missing backticks in os and decimal docs (GH-141699) (#141706)
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Krishna Chaitanya [Tue, 18 Nov 2025 09:43:15 +0000 (15:13 +0530)]
[3.13] gh-141497: Make ipaddress.IP{v4,v6}Network.hosts() always returning an iterator (GH-141547) (GH-141695)
(cherry picked from commit
6b1bdf6c7a6c87f12a247a125e25f8e721cc731e )
Co-authored-by: Krishna Chaitanya <141550576+XChaitanyaX@users.noreply.github.com>
Miss Islington (bot) [Mon, 17 Nov 2025 19:47:04 +0000 (20:47 +0100)]
[3.13] gh-141004: Document `PyODict*` APIs (GH-141136) (GH-141678)
gh-141004: Document `PyODict*` APIs (GH-141136)
(cherry picked from commit
b3626321b6ebb46dd24acee2aa806450e70febfc )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Semyon Moroz [Mon, 17 Nov 2025 17:55:54 +0000 (21:55 +0400)]
[3.13] gh-130160: Add anchors to CLI Usage section for `cmdline` (GH-133182) (#141667)
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Miss Islington (bot) [Mon, 17 Nov 2025 16:49:41 +0000 (17:49 +0100)]
[3.13] gh-130693: Add more tests for tkinter.Text.search() (GH-130848) (GH-141669) (GH-141670)
(cherry picked from commit
8db1aadd6503ac73fd02e2c8c20c31728828e344 )
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Miss Islington (bot) [Mon, 17 Nov 2025 13:02:01 +0000 (14:02 +0100)]
[3.13] gh-141650: Fix typo in `xml.sax.saxutils.unescape` documentation (GH-141652) (#141653)
Co-authored-by: Tamzin Hadasa Kelly <tk.infinity@gmail.com>
Miss Islington (bot) [Mon, 17 Nov 2025 03:26:34 +0000 (04:26 +0100)]
[3.13] gh-137109: refactor warning about threads when forking (GH-141438) (GH-141614) (GH-141639)
[3.14] gh-137109: refactor warning about threads when forking (GH-141438) (GH-141614)
This splits the OS API specific functionality to get the number of threads out
from the fallback Python method and warning raising code itself. This way the
OS APIs can be queried before we've run
`os.register_at_fork(after_in_parent=...)` registered functions which
themselves may (re)start threads that would otherwise be detected.
This is best effort. If the OS APIs are either unavailable or fail, the
warning generating code still falls back to looking at the Python threading
state after the CPython interpreter world has been restarted and the
after_in_parent calls have been made. The common case for most Linux and macOS
environments should work today.
This also lines up with the existing TODO refactoring, we may choose to expose
this API to get the number of OS threads in the `os` module in the future.
Note: This is a simplified backport that maintains the void return type
for warn_about_fork_with_threads() and keeps PyErr_Clear() in the warning path,
as the error handling changes from
fd8f42d3d1 are not needed in 3.14.
(cherry picked from commit
0d8fb0b8523769e24f249d19dab3781a10b50e8b )
Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
Tian Gao [Sun, 16 Nov 2025 22:23:03 +0000 (14:23 -0800)]
[3.13] gh-136057: Allow step and next to step over for loops (GH-136160) (#141641)
(cherry picked from commit
8be3b2f479431f670f2e81e41b52e698c0806289 )
Miss Islington (bot) [Sun, 16 Nov 2025 19:32:16 +0000 (20:32 +0100)]
[3.13] gh-141004: Document missing `PyCFunction*` and `PyCMethod*` APIs (GH-141253) (GH-141638)
gh-141004: Document missing `PyCFunction*` and `PyCMethod*` APIs (GH-141253)
(cherry picked from commit
be699d6c7c8793d3eb464f2e5d3f10262fe3bc37 )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Miss Islington (bot) [Sun, 16 Nov 2025 18:58:19 +0000 (19:58 +0100)]
[3.13] gh-141004: Document the `PyPickleBuffer_*` C API (GH-141630) (GH-141633)
gh-141004: Document the `PyPickleBuffer_*` C API (GH-141630)
(cherry picked from commit
e33afa7ddbca3fca38f4ec4369b620c37cb092e2 )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sergey Miryanov [Sat, 15 Nov 2025 19:14:17 +0000 (00:14 +0500)]
[3.13] GH-141312: Allow only integers to longrangeiter_setstate state (GH-141317) (GH-141568)
This fixes an assertion error when the new computed start is not an integer.
(cherry picked from commit
10bec7c1eb3ee27f490a067426eef452b15f78f9 )
Gregory P. Smith [Sat, 15 Nov 2025 04:45:28 +0000 (20:45 -0800)]
[3.13] gh-140938: Raise ValueError for infinite inputs to stdev/pstdev (GH-141531) (#141584)
gh-140938: Raise ValueError for infinite inputs to stdev/pstdev (GH-141531)
Raise ValueError for infinite inputs to stdev/pstdev
---
(cherry picked from commit
f0a8bc737ab2f04d4196eee154cb1e17e26ad585 )
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Pablo Galindo Salgado [Sat, 15 Nov 2025 03:17:49 +0000 (03:17 +0000)]
[3.13] gh-141579: Fix perf_jit backend in sys.activate_stack_trampoline() (GH-141580) (#141582)
Miss Islington (bot) [Sat, 15 Nov 2025 01:23:03 +0000 (02:23 +0100)]
[3.13] gh-136442: Fix unittest to return exit code 5 when setUpClass raises an exception (GH-136487) (#141577)
gh-136442: Fix unittest to return exit code 5 when setUpClass raises an exception (GH-136487)
(cherry picked from commit
53d65c840e038ce9a5782fbd3da963c7aba90570 )
Co-authored-by: Takuya UESHIN <ueshin@happy-camper.st>
Hugo van Kemenade [Fri, 14 Nov 2025 22:51:36 +0000 (00:51 +0200)]
[3.13] GH-139596: Cease caching config.cache & ccache in GH Actions (GH-141429) (#141569)
(cherry picked from commit
a2442fda6e04d2b7c34490e44000f4dd12daf962 )
Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
Miss Islington (bot) [Fri, 14 Nov 2025 16:24:37 +0000 (17:24 +0100)]
[3.13] gh-139344: Remove pending removal notice for undeprecated importlib.resources API (GH-141507) (GH-141557)
(cherry picked from commit
49e74210cb652d8bd538a4cc887f507396cfc893 )
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Miss Islington (bot) [Fri, 14 Nov 2025 15:58:19 +0000 (16:58 +0100)]
[3.13] gh-141004: Document `PyOS_InterruptOccurred` (GH-141526) (GH-141550)
gh-141004: Document `PyOS_InterruptOccurred` (GH-141526)
(cherry picked from commit
ef90261be508b97d682589aac8f00065a9585683 )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Thu, 13 Nov 2025 18:05:43 +0000 (19:05 +0100)]
[3.13] gh-141004: Document `PyErr_RangedSyntaxLocationObject` (GH-141521) (#141524)
gh-141004: Document `PyErr_RangedSyntaxLocationObject` (GH-141521)
PyErr_RangedSyntaxLocationObject
(cherry picked from commit
196f1519cd2d8134d7643536f13f2b2844bea65d )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Thu, 13 Nov 2025 15:14:32 +0000 (16:14 +0100)]
[3.13] gh-141004: Document `PyCode_Optimize` (GH-141378) (GH-141515)
gh-141004: Document `PyCode_Optimize` (GH-141378)
(cherry picked from commit
d7862e9b1bd8f82e41c4f2c4dad31e15707d856f )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Miss Islington (bot) [Thu, 13 Nov 2025 15:09:23 +0000 (16:09 +0100)]
[3.13] gh-141004: Document C APIs for dictionary keys, values, and items (GH-141009) (GH-141513)
gh-141004: Document C APIs for dictionary keys, values, and items (GH-141009)
(cherry picked from commit
f72768f30e6ed9253eb3b6374b4395dfcaf4842a )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Miss Islington (bot) [Thu, 13 Nov 2025 12:58:46 +0000 (13:58 +0100)]
[3.13] gh-140748: socket_helper.transient_internet: Unwrap UrlError.__cause__ (GH-140749) (GH-141506)
(cherry picked from commit
75a1cbdd38b142b359849eae16a2ecc12f6b3881 )
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Petr Viktorin [Thu, 13 Nov 2025 12:28:57 +0000 (13:28 +0100)]
[3.13] gh-138189: Document type slots, and other constants, as part of Limited API (GH-138190) (GH-141193)
(cherry picked from commit
d81e1ef0f3a7c63f5d246e4cf918700016b72489 )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Miss Islington (bot) [Thu, 13 Nov 2025 11:57:58 +0000 (12:57 +0100)]
[3.13] gh-140601: Refactor ElementTree.iterparse() tests (GH-141499) (GH-141503)
Split existing tests on smaller methods and move them to separate class.
Rename variable "content" to "it".
Use BytesIO instead of StringIO.
Add few more tests.
(cherry picked from commit
2fbd39666663cb5ca1c0e3021ce2e7bc72331020 )
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Miss Islington (bot) [Thu, 13 Nov 2025 11:35:01 +0000 (12:35 +0100)]
[3.13] gh-103847: fix cancellation safety of `asyncio.create_subprocess_exec` (GH-140805) (#141447)
gh-103847: fix cancellation safety of `asyncio.create_subprocess_exec` (GH-140805)
(cherry picked from commit
ef474cfafbdf3aa383fb1334a7ab95cef9834ced )
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Peter Bierma [Wed, 12 Nov 2025 23:02:58 +0000 (18:02 -0500)]
[3.13] gh-141004: Document `PyType_SUPPORTS_WEAKREFS` (GH-141408) (GH-141487)
* gh-141004: Document `PyType_SUPPORTS_WEAKREFS` (GH-141408)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
(cherry picked from commit
9cd5427d9619b96db20d0347a136b3d331af71ae )
Miss Islington (bot) [Wed, 12 Nov 2025 22:59:55 +0000 (23:59 +0100)]
[3.13] gh-141004: Document `PyRun_InteractiveOneObject` (GH-141405) (GH-141486)
gh-141004: Document `PyRun_InteractiveOneObject` (GH-141405)
(cherry picked from commit
26b7df2430cd5a9ee772bfa6ee03a73bd0b11619 )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Miss Islington (bot) [Wed, 12 Nov 2025 22:44:01 +0000 (23:44 +0100)]
[3.13] gh-124111: Fix TCL 9 thread detection (GH-141483)
(cherry picked from commit
dc0987080ed66c662e8e0b24cdb8c179817bd697 )
Co-authored-by: Michael Cho <michael@michaelcho.dev>
Miss Islington (bot) [Wed, 12 Nov 2025 22:03:51 +0000 (23:03 +0100)]
[3.13] gh-141442: Add escaping to iOS testbed arguments (GH-141443) (#141480)
Xcode concatenates the test argument array, losing quoting in the process.
(cherry picked from commit
558936bec1f1e0f8346063a8cb2b2782d085178e )
Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Cody Maloney [Wed, 12 Nov 2025 21:37:06 +0000 (13:37 -0800)]
[3.13] gh-141311: Avoid assertion in BytesIO.readinto() (GH-141333) (GH-141478)
Fix error in assertion which causes failure if pos is equal to PY_SSIZE_T_MAX.
Fix undefined behavior in read() and readinto() if pos is larger that the size
of the underlying buffer.
(cherry picked from commit
7d54374f9c7d91e0ef90c4ad84baf10073cf1d8a )
Miss Islington (bot) [Wed, 12 Nov 2025 18:40:22 +0000 (19:40 +0100)]
[3.13] gh-141412: Use reliable target URL for urllib example (GH-141475)
The endpoint used for demonstrating reading URLs is no longer
stable. This change substitutes a target over which we have more
control.
(cherry picked from commit
fbcac799518e0cb29fcf5f84ed1fa001010b9073 )
Co-authored-by: Bob Kline <bkline@users.noreply.github.com>
Miss Islington (bot) [Wed, 12 Nov 2025 17:03:55 +0000 (18:03 +0100)]
[3.13] gh-141004: Document `Py_MATH_{E, PI, TAU}` constants (GH-141373) (#141472)
gh-141004: Document `Py_MATH_{E, PI, TAU}` constants (GH-141373)
(cherry picked from commit
f1330b35b8eb43904dfed0656acde80c08d63176 )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Wed, 12 Nov 2025 15:42:18 +0000 (16:42 +0100)]
[3.13] gh-132657: add regression test for `PySet_Contains` with unhashable type (GH-141411) (#141467)
gh-132657: add regression test for `PySet_Contains` with unhashable type (GH-141411)
(cherry picked from commit
2ac738d325a6934e39fecb097f43d4d4ed97a2b9 )
Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com>
Mohsin Mehmood [Wed, 12 Nov 2025 10:40:14 +0000 (15:40 +0500)]
[3.13] gh-141314: Fix TextIOWrapper.tell() assertion failure with standalone carriage return (GH-141331) (GH-141452)
The assertion was checking wrong variable (skip_back vs skip_bytes).
(cherry picked from commit
af80fac42548719ede7241bfbab3c2c0775b4760 )
Miss Islington (bot) [Wed, 12 Nov 2025 09:57:08 +0000 (10:57 +0100)]
[3.13] gh-141370: document undefined behavior of Py_ABS() (GH-141439) (GH-141455)
(cherry picked from commit
20f53df07d42c495a08c73a3d54b8dd9098a62f0 )
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Peter Bierma [Wed, 12 Nov 2025 02:08:28 +0000 (21:08 -0500)]
[3.13] gh-141004: Document `PyBytes_Repr` and `PyBytes_DecodeEscape` (GH-141407) (GH-141441)
* gh-141004: Document `PyBytes_Repr` and `PyBytes_DecodeEscape` (GH-141407)
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
(cherry picked from commit
37e2762ee12c2d7fc465938d7161a9a0640bd71f )
Miss Islington (bot) [Wed, 12 Nov 2025 00:13:19 +0000 (01:13 +0100)]
[3.13] gh-137952: update `csv.Sniffer().has_header()` docs to describe the actual off-by-onish behavior (GH-137953) (#141435)
gh-137952: update `csv.Sniffer().has_header()` docs to describe the actual off-by-onish behavior (GH-137953)
* checks 21, not 20
* Say "header" instead of "first row" to disambiguate per review.
---------
(cherry picked from commit
0d7b48a8f5de5c1c6d57e1cf7194b6fb222d92e5 )
Co-authored-by: Maurycy Pawłowski-Wieroński <maurycy@maurycy.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Wed, 12 Nov 2025 00:10:07 +0000 (01:10 +0100)]
[3.13] gh-138775: fix handle `python -m base64` stdin correct with EOF signal (GH-138776) (#141433)
gh-138775: fix handle `python -m base64` stdin correct with EOF signal (GH-138776)
* fix: handle stdin correct with EOF single.
* fix: flollow the comments when pipe stdin use buffer
* Apply suggestions from code review
* fix: apply review comments in Lib/base64.py
* fix: address comments
* Reword comment and NEWS entry.
---------
(cherry picked from commit
f5c2a41f9a6b3be95c5be9dbae0a4a3342d356dc )
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: yihong <zouzou0208@gmail.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Miss Islington (bot) [Tue, 11 Nov 2025 21:48:36 +0000 (22:48 +0100)]
[3.13] gh-141004: Document `PyFile_OpenCode` and `PyFile_OpenCodeObject` (GH-141413) (GH-141426)
gh-141004: Document `PyFile_OpenCode` and `PyFile_OpenCodeObject` (GH-141413)
(cherry picked from commit
2befce86e699fdbb6610949b029bad56a0d0780f )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Tue, 11 Nov 2025 19:42:01 +0000 (20:42 +0100)]
[3.13] gh-139533: fix refs to code without proper markups on turtledemo doc (GH-139534) (#141422)
gh-139533: fix refs to code without proper markups on turtledemo doc (GH-139534)
(cherry picked from commit
c903d768322989e9f8ba79e38ee87e14c85c5430 )
gh-139533: fix refs to code without proper markups on turtledemo documentation
Co-authored-by: Marco Barbosa <aureliobarbosa@gmail.com>
Miss Islington (bot) [Tue, 11 Nov 2025 17:28:52 +0000 (18:28 +0100)]
[3.13] gh-141004: Document `PyType_Unwatch` (GH-141414) (GH-141419)
gh-141004: Document `PyType_Unwatch` (GH-141414)
(cherry picked from commit
759a048d4bea522fda2fe929be0fba1650c62b0e )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sergey B Kirpichev [Tue, 11 Nov 2025 13:52:05 +0000 (16:52 +0300)]
[3.13] gh-141004: document Py_INFINITY and Py_NAN macros (GH-141145) (#141400)
(cherry picked from commit
d69447445cbacf7537bf59c5c683a3b17060312d )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Tue, 11 Nov 2025 06:09:28 +0000 (07:09 +0100)]
[3.13] gh-140379: add hyperlinks to list and set (GH-140399) (#141387)
gh-140379: add hyperlinks to list and set (GH-140399)
add hyperlinks to list and set
(cherry picked from commit
92741c59f89e114474bdb2cb539107ef6bae0b9c )
Co-authored-by: Krishna Chaitanya <141550576+XChaitanyaX@users.noreply.github.com>
Miss Islington (bot) [Tue, 11 Nov 2025 05:21:20 +0000 (06:21 +0100)]
[3.13] gh-140485: Catch ChildProcessError in multiprocessing resource tracker (GH-141132) (#141385)
gh-140485: Catch ChildProcessError in multiprocessing resource tracker (GH-141132)
(cherry picked from commit
9cb8c52d5e9a83efe4fa3878db06befd9df52f54 )
Co-authored-by: Victor Stinner <vstinner@python.org>
Miss Islington (bot) [Tue, 11 Nov 2025 04:58:30 +0000 (05:58 +0100)]
[3.13] gh-140578: Doc: Remove sencence implying that concurrent.futures.ThreadPoolExecutor does not exist (GH-140689) (#141383)
gh-140578: Doc: Remove sencence implying that concurrent.futures.ThreadPoolExecutor does not exist (GH-140689)
* Doc: Remove sencence implying that concurrent.futures.ThreadPoolExecutor does not exist
Closes GH-140578
* Add NEWS.d entry for gh-140578
---------
(cherry picked from commit
46b58e1bb9e1e17d855588935f5a259be960a3a1 )
Co-authored-by: Louis <paternal@users.noreply.github.com>
Co-authored-by: Louis Paternault <spalax@gresille.org>
Miss Islington (bot) [Mon, 10 Nov 2025 21:42:04 +0000 (22:42 +0100)]
[3.13] gh-141004: Document missing frame APIs (GH-141189) (GH-141380)
gh-141004: Document missing frame APIs (GH-141189)
(cherry picked from commit
86513f6c2ebdd1fb692c39b84786ea41d88c84fd )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Mon, 10 Nov 2025 17:52:22 +0000 (18:52 +0100)]
[3.13] gh-141004: Document `PyType_FastSubclass` (GH-141313) (GH-141369)
gh-141004: Document `PyType_FastSubclass` (GH-141313)
(cherry picked from commit
ed0a5fd8cacb1964111d03ff37627f6bea5e6026 )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Miss Islington (bot) [Mon, 10 Nov 2025 16:40:53 +0000 (17:40 +0100)]
[3.13] gh-139707: Specify `winreg`, `msvcrt` and `winsound` module availability in docs (GH-140429) (GH-141350)
(cherry picked from commit
13fa313bebed71d8bc64f1cfdaf4b2f1ddd3ce5f )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Mon, 10 Nov 2025 15:02:45 +0000 (16:02 +0100)]
[3.13] gh-141343: Fix swapped words in `sorted` doc (GH-141356)
(cherry picked from commit
59b793b0dd76d37229fe6d379cd5fe76023d15f1 )
Co-authored-by: Yongzi Li <204532581+Yzi-Li@users.noreply.github.com>
Petr Viktorin [Mon, 10 Nov 2025 14:06:58 +0000 (15:06 +0100)]
[3.13] Clarify argument/result ownership/validity for PyModule_* functions (GH-141159) (GH-141191)
(cherry picked from commit
ffd64737d00277eea1c4721d278a0951168d07ca )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Miss Islington (bot) [Mon, 10 Nov 2025 12:46:06 +0000 (13:46 +0100)]
[3.13] gh-140500: Update download.html instructions (GH-141320) (#141346)
Co-authored-by: Karina Souza <97332018+KarinaS0uza@users.noreply.github.com>
Co-authored-by: Joseph Anthony Pasquale Holsten <joseph@josephholsten.com>
Miss Islington (bot) [Mon, 10 Nov 2025 10:11:39 +0000 (11:11 +0100)]
[3.13] gh-141004: Document `pyctype.h` macros (GH-141272) (GH-141339)
gh-141004: Document `pyctype.h` macros (GH-141272)
(cherry picked from commit
df192616212f80aaa2f672b722b925943dbd3b78 )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Mon, 10 Nov 2025 00:49:30 +0000 (01:49 +0100)]
[3.13] gh-141004: Document `Py_DTSF_*` macros (GH-141310) (GH-141330)
gh-141004: Document `Py_DTSF_*` macros (GH-141310)
(cherry picked from commit
9b0179fa87fee39df0f75bd84fc2dd75f1d00553 )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Mon, 10 Nov 2025 00:08:09 +0000 (01:08 +0100)]
[3.13] gh-62480: De-personalize "Partial mocking" section in `unittest.mock` examples (GH-141321) (#141327)
gh-62480: De-personalize "Partial mocking" section in `unittest.mock` examples (GH-141321)
* Refine some wording in unittest partial mock doc
Some of the descriptions were addressed in first person,
but have now been changed to address the user reading the documentation instead.
(cherry picked from commit
b618731781c31d4b5b75d199dfc14993ffd66e37 )
Co-authored-by: KarnbirKhera <166065758+KarnbirKhera@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Miss Islington (bot) [Mon, 10 Nov 2025 00:07:25 +0000 (01:07 +0100)]
[3.13] gh-62480: De-personalize "Mocking Unbound Methods" section in `unittest.mock` examples (GH-141322) (#141325)
gh-62480: De-personalize "Mocking Unbound Methods" section in `unittest.mock` examples (GH-141322)
* Rewrite Mocking Unbound Methods paragraph to second person
(cherry picked from commit
ec85d3cbfe315086805c33bb64c28a8509098829 )
Co-authored-by: Elena O <31424287+oklena@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Miss Islington (bot) [Sun, 9 Nov 2025 20:01:33 +0000 (21:01 +0100)]
[3.13] gh-141004: Document `PySuper_Type` (GH-141315) (GH-141319)
gh-141004: Document `PySuper_Type` (GH-141315)
(cherry picked from commit
14c62227f9fa11fb743f9e03dcc5aab553de1098 )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Sun, 9 Nov 2025 18:09:43 +0000 (19:09 +0100)]
[3.13] gh-141004: Document `PyClassMethod*` and `PyStaticMethod*` APIs (GH-141296) (GH-141309)
gh-141004: Document `PyClassMethod*` and `PyStaticMethod*` APIs (GH-141296)
(cherry picked from commit
807db68ddd8572cfa825373bc13461b02691f4d9 )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Miss Islington (bot) [Sun, 9 Nov 2025 17:55:02 +0000 (18:55 +0100)]
[3.13] gh-141004: Document `PyFunction_SetKwDefaults` (GH-141294) (GH-141305)
gh-141004: Document `PyFunction_SetKwDefaults` (GH-141294)
(cherry picked from commit
18529b580b59b8d075641da6c685bef377eb0a7b )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Miss Islington (bot) [Sun, 9 Nov 2025 17:20:18 +0000 (18:20 +0100)]
[3.13] gh-141004: Document `PyExceptionInstance*` APIs (GH-141301) (GH-141303)
gh-141004: Document `PyExceptionInstance*` APIs (GH-141301)
(cherry picked from commit
b5a0c72492800c7e999b87adfcfeabaacb4ecb97 )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Miss Islington (bot) [Sun, 9 Nov 2025 16:28:26 +0000 (17:28 +0100)]
[3.13] gh-141004: Document `Py_func_type_input` (GH-141273) (GH-141299)
gh-141004: Document `Py_func_type_input` (GH-141273)
(cherry picked from commit
8dd849828636bb3989c6d5d20f8790a3fb770fc4 )
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Miss Islington (bot) [Sun, 9 Nov 2025 15:50:46 +0000 (16:50 +0100)]
[3.13] gh-141004: document `curses` C API (GH-141254) (#141293)
gh-141004: document `curses` C API (GH-141254)
(cherry picked from commit
dbe40904a78a0c8ffa25fb64e6ff1e14e6e7ba5a )
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Miss Islington (bot) [Sun, 9 Nov 2025 15:39:53 +0000 (16:39 +0100)]
[3.13] gh-141004: Document `PyWeakref_CheckRefExact` (GH-141279) (GH-141291)
gh-141004: Document `PyWeakref_CheckRefExact` (GH-141279)
(cherry picked from commit
60155329a0a83a2b9e740f0c0de41c9d44f5a053 )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Peter Bierma [Sun, 9 Nov 2025 15:37:13 +0000 (10:37 -0500)]
[3.13] gh-141004: Document deprecated aliases for memory allocation (GH-141146) (GH-141289)
* gh-141004: Document deprecated aliases for memory allocation (GH-141146)
(cherry picked from commit
1d738dea6364de004f8cec7c6309d6bbd3b996c7 )
Bénédikt Tran [Sun, 9 Nov 2025 14:57:26 +0000 (15:57 +0100)]
[3.13] gh-140530: fix a reference leak in an error path for `raise exc from cause` (GH-140908) (#141283)
gh-140530: fix a reference leak in an error path for `raise exc from cause` (#140908)
Fix a reference leak in `raise E from T` when `T` is an exception
subtype for which `T.__new__` does not return an exception instance.
(cherry picked from commit
0c77e7c23b5c270a3142105542c56c59b59c52a0 )
Bénédikt Tran [Sun, 9 Nov 2025 13:31:49 +0000 (14:31 +0100)]
[3.13] gh-100218: correctly set `errno` when `socket.if_{nametoindex,indextoname}` raise `OSError` (GH-140905) (#141285)
Previously, socket.if_nametoindex() and socket.if_indextoname() could raise
an `OSError` with a `None` errno. Now, the errno from libc is propagated.
(cherry picked from commit
3ce2d57b2f02030353af314d89c5f6215d2f5c96 )
Miss Islington (bot) [Sun, 9 Nov 2025 10:19:35 +0000 (11:19 +0100)]
[3.13] gh-141127: Clarify os.symlink() documentation for argument order (GH-141144) (#141277)
gh-141127: Clarify os.symlink() documentation for argument order (GH-141144)
(cherry picked from commit
7ae440f262c99ba9a3327237f83c9290dc963028 )
Co-authored-by: Chilla Kalyan <127284726+chillakalyan@users.noreply.github.com>
Miss Islington (bot) [Sat, 8 Nov 2025 19:28:32 +0000 (20:28 +0100)]
[3.13] gh-141004: Document `Py_BUILD_ASSERT*` macros (GH-141266) (GH-141270)
gh-141004: Document `Py_BUILD_ASSERT*` macros (GH-141266)
(cherry picked from commit
0ac890bea79d3e0162c8909b0999f626f1141d89 )
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>