drh [Tue, 24 Jun 2025 15:58:32 +0000 (15:58 +0000)]
Range check the column index on the sqlite3_preupdate_old() interface
and return SQLITE_MISUSE if too large.
[forum:/forumpost/b617e497287235d0|Forum post b617e49728].
stephan [Sat, 21 Jun 2025 14:38:53 +0000 (14:38 +0000)]
Rework how JS's oo1.DB.exec() flags its Stmt objects to make certain Stmt APIs illegal (i.e. throwing) if called while that Stmt is being step()ped by DB.exec() (which can happen via client-provided per-result-row callbacks). This is an internal change only - the API is unaffected. Remove some unrelated dead code.
stephan [Thu, 19 Jun 2025 10:25:50 +0000 (10:25 +0000)]
Expose the column metadata APIs to WASM (which does not require a non-default sqlite3.c build, contrary to my prior mistaken claims). This adds only 424 bytes to sqlite3.wasm and 660 bytes to sqlite3.js.
stephan [Wed, 18 Jun 2025 15:37:04 +0000 (15:37 +0000)]
Export the column-metadata APIs to WASM. Doing so requires a non-default build of sqlite3.c, so this is a proof-of-concept branch saved just in case SQLITE_ENABLE_COLUMN_METADATA ever becomes the default for sqlite3.c.
stephan [Wed, 18 Jun 2025 15:22:50 +0000 (15:22 +0000)]
Add the --enable-column-metadata flag to the configure script (off by default). It's only available in the canonical build, not the autoconf build, because it changes how sqlite3.c gets generated.
stephan [Wed, 18 Jun 2025 14:17:18 +0000 (14:17 +0000)]
Eliminate configure/build discrepancies in how 'make tclextension-...' works vs other makefile-side handling of the extension, conforming to the former.
drh [Wed, 18 Jun 2025 14:14:46 +0000 (14:14 +0000)]
Change the definition of SQLITE_DYNAMIC to a function that has exactly
the same type as sqlite3_destructor_type, in an effort to work around
possible legacy compiler bugs.
stephan [Wed, 18 Jun 2025 11:11:30 +0000 (11:11 +0000)]
Add the --tclConfig.sh FILE flag to buildtclext.tcl to eliminate the discrepancy between the configure-time-detected tclConfig.sh and the one auto-detected by the tclextension family of makefile targets. Add the tclextension-all target to run all of the various tclextension-... targets in their natural order to facilitate testing changes like this one. Update the --help text to note that --with-tclsh should only be used if there's a specific need, and that --with-tcl is generall preferred. This is in response to [https://github.com/termux/termux-packages/issues/23268 | Termux ticket 23268].
stephan [Tue, 17 Jun 2025 20:50:51 +0000 (20:50 +0000)]
tea: remove the vsatisfies 8.6- enforcement from the extension because at least one platform with tcl 8.6 is inexplicably failing it. [forum:fde857fb8101a4be | Forum post fde857fb8101a4be]
stephan [Tue, 17 Jun 2025 14:37:31 +0000 (14:37 +0000)]
proj.tcl portability fixes and cleanups suggested in [forum:7b218c3c9f|forum post 7b218c3c9f]. Branching so that it can be tested on msys/cygwin/haiku before committing to it.
dan [Tue, 17 Jun 2025 11:36:39 +0000 (11:36 +0000)]
Avoid writing frames with no checksums into the wal file if a savepoint is rolled back after dirty pages have already been spilled into the wal file. Possible fix for [forum:/forumpost/b490f726db | forum post b490f726db].
drh [Mon, 16 Jun 2025 17:36:11 +0000 (17:36 +0000)]
Fix an issue going back to version 3.39.0 with transitive IS constraints
in queries that make use of RIGHT JOIN. Problem reported by
[forum:/forumpost/68f29a2005|forum post 68f29a2005].
drh [Mon, 16 Jun 2025 15:34:26 +0000 (15:34 +0000)]
Make the show-%p-az-zero hack of the previous check-in configurable at
run-time using the 0x100000 bit of either .treetrace or .wheretrace.
As before, this is all a no-op except for debugging builds.
dan [Thu, 12 Jun 2025 07:35:38 +0000 (07:35 +0000)]
Have sqlite3_setlk_timeout() take the database handle mutex. This fixes an assert() failure that could occur if sqlite3_setlk_timeout() were called on a threadsafe handle.
drh [Tue, 10 Jun 2025 19:52:21 +0000 (19:52 +0000)]
Improved selection of the divisor when subdividing nested Bitvec objects.
This fixes a potential stack overflow that can occur when the database size
is within 60 pages of the maximum allowed by the file format.
drh [Tue, 10 Jun 2025 16:02:29 +0000 (16:02 +0000)]
Improved diagnostics for Bitvec: Add the sqlite3ShowBitvec() routine that
can be called from a debugger (only available with SQLITE_DEBUG). Add new
output opcodes for sqlite3BitvecBuiltinTest().
drh [Fri, 6 Jun 2025 23:02:03 +0000 (23:02 +0000)]
Update the "msort" function in Lemon so that it works with lists of any
length, and also so that the sort is stable. This patch was motivated by
[forum:/forumpost/63750d717c9ed961|forum post 63750d717c] but was
independently developed, then tested by temporarily setting LISTSIZE to 2.
drh [Thu, 5 Jun 2025 18:28:54 +0000 (18:28 +0000)]
Enhance the FSDIR virtual table with a new "level" column. The query planner
knows how to optimize to avoid search deeper than the maximum requested level.
stephan [Wed, 4 Jun 2025 18:34:20 +0000 (18:34 +0000)]
tea build: add an info-exists check after a 'scan' call, as scan does not create its target vars on error. Problem reported at [forum:fde857fb8101a4be | forum post fde857fb8101a4be] and triggers when the 'vsatisfies' test for the host's Tcl version fails (so the build would fail anyway, but will fail more informatively with this fix).
stephan [Tue, 3 Jun 2025 18:10:59 +0000 (18:10 +0000)]
Apply the duplicate 'export default' workaround to the (untested and unsupported) node-specific build rules in mkwasmbuilds.c to resolve a problem reported off-list by Thomas Steiner.
dan [Mon, 2 Jun 2025 18:48:36 +0000 (18:48 +0000)]
Fixes to ensure SQLITE_ENABLE_SETLK_TIMEOUT builds use a blocking lock and do not call xSleep() when (a) opening a snapshot transaction, and (b) when blocked by another process running recovery.
drh [Mon, 2 Jun 2025 18:34:17 +0000 (18:34 +0000)]
Improve the accuracy of affinity and collating sequence analysis for
NATURAL JOINs to the left of RIGHT JOINs where source tables are views
or subqueries. Initial problem report in
[forum:/forumpost/829306db47|forum post 829306db47].
stephan [Mon, 2 Jun 2025 15:10:41 +0000 (15:10 +0000)]
TEA: remove the stale man page and references to the MSC makefiles from the README.txt. Based on discussion at [forum:87e6660191a472c5 | forum post 87e6660191a472c5]. A couple of weeks ago we internally discussed pulling in the MSC makefiles from the 3.49 tree but they are stale and possibly unused, so opted against it for the time being.
drh [Sun, 1 Jun 2025 21:38:35 +0000 (21:38 +0000)]
Fix an off-by-one error in the size computation of a vdbe-sorter.
[forum:/forumpost/c1cc8b057a|Forum post c1cc8b057a].
Problem introduced by checkin [d4307a0d43f42e96].
drh [Sat, 31 May 2025 18:26:37 +0000 (18:26 +0000)]
New makefile target "xdevtest" works like "releasetest" except that it
omits the "verify-source" dependency so that it can be run with uncommitted
changes in the source tree.
drh [Sat, 31 May 2025 16:17:14 +0000 (16:17 +0000)]
Relax query flattener constraint (3b) and thereby allow flattening the RHS of
a LEFT JOIN even if the RHS contains a virtual table. This was previously
disallowed by [9dbae1df75219e2a] as a performance optimization. It
turns out that the constraint causes performance issues, and we do not have
a record of any performance issue that it solves.
drh [Fri, 30 May 2025 19:55:46 +0000 (19:55 +0000)]
When synthesizing an ON constraint from a USING or NATURAL, if the left-hand
side is coming from a RIGHT JOIN, be sure to set the EP_CanBeNull flag so that
the optimizer knows to check for NULL even if the column has a NOT NULL
constraint. Fix for the problem reported by
[forum:/forumpost/4fc70203b61c7e12|forum post 4fc70203b61]
stephan [Fri, 30 May 2025 16:08:31 +0000 (16:08 +0000)]
Configure-related fixes and additions, most notably integration of self-tests for proj.tcl's APIs. Teaish make-install fixes based on the discussion in [forum:87e6660191a472c5 | forum thread 87e6660191a472c5].
dan [Fri, 30 May 2025 11:14:11 +0000 (11:14 +0000)]
Add "include <stddef.h>" to fts5 and rtree to ensure that they use the system version of the offsetof() macro when it is available, as the built-in version triggers ubsan errors with clang.
stephan [Fri, 30 May 2025 10:18:09 +0000 (10:18 +0000)]
Squelch an interesting but harmless struct initialization warning emitted after an emsdk update. Fix JS breakage introduced by changes in Emscripten 4.0.7: manually export the HEAPxyz symbols which used to be exposed by default.
stephan [Thu, 29 May 2025 20:29:13 +0000 (20:29 +0000)]
Fix the missing -lm link flag for the sqlite3 shell when building the autoconf bundle with --disable-static-shell, as reported in [forum:5adf1c932a | forum post 5adf1c932a].