]> git.ipfire.org Git - thirdparty/sqlite.git/log
thirdparty/sqlite.git
4 years agoFix VDBE coverage macros. compare-opcode-opt
drh [Mon, 29 Mar 2021 19:47:39 +0000 (19:47 +0000)] 
Fix VDBE coverage macros.

FossilOrigin-Name: ebe100de55ccdf6abccde5d8e6e96099b6e8dc3527f1441265e2b86b6661a66b

4 years agoOmit the SQLITE_STOREP2 and SQLITE_KEEPNULL options from the comparison
drh [Mon, 29 Mar 2021 18:53:47 +0000 (18:53 +0000)] 
Omit the SQLITE_STOREP2 and SQLITE_KEEPNULL options from the comparison
opcodes, allowing them to run faster.  This required refactoring the
vector comparison logic, which in turn required changing OP_ElseNotEq into
OP_ElseEq.

FossilOrigin-Name: 380b46054b6a9b67e57357815e8e94057253fa3cce838ae76e5d5031c6bd26b2

4 years agoAdd the OP_ZeroOrNull opcode and use it to compute boolean values for
drh [Mon, 29 Mar 2021 14:40:48 +0000 (14:40 +0000)] 
Add the OP_ZeroOrNull opcode and use it to compute boolean values for
scalar comparisons, rather than the SQLITE_STOREP2 parameter to the comparison
opcode.

FossilOrigin-Name: 93781b6f10a94fb273204b95156a8b90e07071f28c89e7966c659a0f44f60e98

4 years agoThe comparison opcodes (ex: OP_Eq) now set the iCompare flag so that the
drh [Mon, 29 Mar 2021 13:47:20 +0000 (13:47 +0000)] 
The comparison opcodes (ex: OP_Eq) now set the iCompare flag so that the
result of comparison can be used by subsequent OP_Jump or OP_ElseNotEq
opcodes.

FossilOrigin-Name: bd00df8f07b7163b0712590d2bb517e838a36c994dc47d7b39b5a07d14e6e6af

4 years agoAlternative implementation of the comparison opcode speed-up of
drh [Sun, 28 Mar 2021 23:37:56 +0000 (23:37 +0000)] 
Alternative implementation of the comparison opcode speed-up of
check-in [4a8805d9a66dc888] that should pass muster with UBSAN.

FossilOrigin-Name: afb18f64541effaeaada2d72c7c91adfe5ec3e2b1418c0bc281083125fb5badb

4 years agoDocument the "%token" directive for Lemon. This directive has been in place
drh [Sun, 28 Mar 2021 20:44:01 +0000 (20:44 +0000)] 
Document the "%token" directive for Lemon.  This directive has been in place
for a while, but was previously undocumented.

FossilOrigin-Name: 36624d3740a8d095eee061bcc5037deabddb88a53444ec1a956a8af7684efa43

4 years agoFor the sqlite3_bind_text16 TCL binding used for testing, ensure that there
drh [Sat, 27 Mar 2021 16:21:34 +0000 (16:21 +0000)] 
For the sqlite3_bind_text16 TCL binding used for testing, ensure that there
are at least 3 terminating zeros, so that there will always be a \u0000
character even if the original byte sequence is an odd number of bytes.

FossilOrigin-Name: c23d092f37c535f88a47e9f55aa7b2fd40cfd5c50eec9191a68073d7f9141ecd

4 years agoIn the sqlite3_bind_text and sqlite3_bind_text16 TCL commands of the test
drh [Fri, 26 Mar 2021 23:59:37 +0000 (23:59 +0000)] 
In the sqlite3_bind_text and sqlite3_bind_text16 TCL commands of the test
suite, ensure that the string is zero-terminated if the size argument is
negative.

FossilOrigin-Name: f472fd64434cb2eac169587faa34bec489bc82002d529bc72dbfbba5251e5517

4 years agoRemove old testcases() macros. Also remove surplus end-of-line whitespace.
drh [Wed, 24 Mar 2021 23:30:06 +0000 (23:30 +0000)] 
Remove old testcases() macros.  Also remove surplus end-of-line whitespace.

FossilOrigin-Name: 54b41915ed8ef993b4116b2de00f3f4bba7570a1d28ad6bb93ba158a6b89eff3

4 years agoComment improvements to on the distinct-agg optimization. Show a line in
drh [Wed, 24 Mar 2021 19:44:01 +0000 (19:44 +0000)] 
Comment improvements to on the distinct-agg optimization.  Show a line in
the EQP output when using an ephemeral table to implement DISTINCT on an
aggregate.

FossilOrigin-Name: 037ca79e6032ca962b4f6182187bc12a7d91170d73630c8cd6fb191d2c183ee4

4 years agoImprovements to distinct aggregates such that they can sometimes avoid
drh [Wed, 24 Mar 2021 17:28:11 +0000 (17:28 +0000)] 
Improvements to distinct aggregates such that they can sometimes avoid
using an ephermeral table to test for duplicates if the column that is
distinct is part of an index.

FossilOrigin-Name: ef4ac0ddd297bbd38351410c5a387e1628561b3f1bec9e4c2c9d76fbe29f955a

4 years agoFix a harmless compiler warning.
drh [Wed, 24 Mar 2021 17:04:32 +0000 (17:04 +0000)] 
Fix a harmless compiler warning.

FossilOrigin-Name: 26b005a95e4f3e378e3bc40f57321ffbab72b6fc990d13b56b3121990d325f63

4 years agoFix a problem with renaming a column when there is a quoted string immediately follow...
dan [Tue, 23 Mar 2021 22:15:34 +0000 (22:15 +0000)] 
Fix a problem with renaming a column when there is a quoted string immediately following the column name somewhere in the schema.

FossilOrigin-Name: 4719fae6262aa3563f3df6aca0170c6d847bb18ab7b0e6e7609a0e7b6f0c6b1b

4 years agoAdd an ALWAYS() on a branch that is always taken.
drh [Tue, 23 Mar 2021 21:02:24 +0000 (21:02 +0000)] 
Add an ALWAYS() on a branch that is always taken.

FossilOrigin-Name: 0646d2260c523d368e3f6bc3d110a9011d35ce83bd6751ad412d8fd9a253cb7a

4 years agoTest result adjustments in test/misc7.test due to the EQP format change.
drh [Tue, 23 Mar 2021 19:39:27 +0000 (19:39 +0000)] 
Test result adjustments in test/misc7.test due to the EQP format change.

FossilOrigin-Name: d3ade8c7fe58e05af9d44a79478776b050a680c1338188f2d4b222b937e682ea

4 years agoWhen doing schema updates, try to convert (incorrect) double-quoted strings
drh [Tue, 23 Mar 2021 16:34:13 +0000 (16:34 +0000)] 
When doing schema updates, try to convert (incorrect) double-quoted strings
into (SQL-standard) single-quoted strings.

FossilOrigin-Name: 0770470488e140fa21cb5097c26d58e21da85544af8b69faced1670bbc6d6089

4 years agoTweaks to test/scanstatus.test to account for the new EQP format.
drh [Tue, 23 Mar 2021 15:39:02 +0000 (15:39 +0000)] 
Tweaks to test/scanstatus.test to account for the new EQP format.

FossilOrigin-Name: 2eb28afd01f43143a9c0cd6cea68f3095f993952d54ee06b781514a7754490cd

4 years agoChanges to test/analyzeG.test to conform to the new EXPLAIN QUERY PLAN syntax.
drh [Tue, 23 Mar 2021 15:07:17 +0000 (15:07 +0000)] 
Changes to test/analyzeG.test to conform to the new EXPLAIN QUERY PLAN syntax.

FossilOrigin-Name: d8afde1bf1d41a349a161a293533a9fdf23ff23b8f1bcc323e79e806c5c526f1

4 years agoFix a test case in bigmmap.test so that it works with the new
drh [Tue, 23 Mar 2021 14:33:35 +0000 (14:33 +0000)] 
Fix a test case in bigmmap.test so that it works with the new
EXPLAIN QUERY PLAN output format.

FossilOrigin-Name: 9ac064fe2aee4aa1423e7c8043dfec52ecf2af3e8361ebb7d9c104cca82b4d23

4 years agoAdd the ExprList.nAlloc column and use it to make the sqlite3ExprListAppend()
drh [Tue, 23 Mar 2021 14:27:35 +0000 (14:27 +0000)] 
Add the ExprList.nAlloc column and use it to make the sqlite3ExprListAppend()
routine much faster.

FossilOrigin-Name: 1d3c4662c2f522ac695d97441324069f3fc65f3fa0b87194c7094dfb8cd549f2

4 years agoEnhance the EXPLAIN QUERY PLAN output to use symbolic names to describe
drh [Tue, 23 Mar 2021 01:06:02 +0000 (01:06 +0000)] 
Enhance the EXPLAIN QUERY PLAN output to use symbolic names to describe
subqueries, where possible, instead of cryptic subquery index numbers.
And in other ways, make the EQP output cleaner and easier to read.  Little
code is changed, but many of the test results had to be tweaked to align
with the new output format.

FossilOrigin-Name: f8e28308fdb45fbdef30003320d653410d69bb8ec92eef35c4245a99e2d0603b

4 years agoMerge recent fixes from trunk. eqp-improvements
drh [Mon, 22 Mar 2021 18:53:26 +0000 (18:53 +0000)] 
Merge recent fixes from trunk.

FossilOrigin-Name: 4a343698b4ec3364b0eecb7fa074512ecac8b586aff1f977ca77f215e96e0ce5

4 years agoIncrease the version number to 3.36.0 to begin the next development cycle.
drh [Mon, 22 Mar 2021 16:50:39 +0000 (16:50 +0000)] 
Increase the version number to 3.36.0 to begin the next development cycle.

FossilOrigin-Name: 5cee689d647087a5e796da2acb247a4f469a8b39b54f59bb4ad2386647cef1bd

4 years agoFix an assert() that in preupdate-hook logic (not normally built) that same-as-3.35.3
drh [Sun, 21 Mar 2021 18:23:48 +0000 (18:23 +0000)] 
Fix an assert() that in preupdate-hook logic (not normally built) that
can be false when running VACUUM on a corrupt database file under
PRAGMA writable_schema=ON.

FossilOrigin-Name: 6bb2134027a12801de8e0c73482d94682f902024800a7e426614f65a2fe4f64c

4 years agoAdd a better comment and an assert() on the code inside sqlite3CreateIndex()
drh [Sun, 21 Mar 2021 17:52:47 +0000 (17:52 +0000)] 
Add a better comment and an assert() on the code inside sqlite3CreateIndex()
that REPLACE indexes come at the end of the index list.
[forum:/forumpost/ceb51d83f7|forum post ceb51d83f7]

FossilOrigin-Name: 71e4da136bd1b5b75a699d69fbaaaec0f9dd1a87e2a9d049a55154892b06647b

4 years agoFix the "box" output mode in the shell when statement returns zero-column
drh [Sat, 20 Mar 2021 23:15:52 +0000 (23:15 +0000)] 
Fix the "box" output mode in the shell when statement returns zero-column
rows (for example from "PRAGMA incremental_vacuum").

FossilOrigin-Name: 34439fe3aeea7cbbc817245d39c345a7f5df7a82ac15ee4d71bb9a4d818198ed

4 years agoUse the canonical name, not the AS name, when showing the MATERIALIZE or
drh [Sat, 20 Mar 2021 15:46:01 +0000 (15:46 +0000)] 
Use the canonical name, not the AS name, when showing the MATERIALIZE or
CO-ROUTINE lines for a CTE.

FossilOrigin-Name: 1b83e232c490fe6e9f999d30399faebfac6094bf940dc21dc459ed2c97657cb2

4 years agoRevise tests cases to align with the new EXPLAIN QUERY PLAN output.
drh [Sat, 20 Mar 2021 15:11:29 +0000 (15:11 +0000)] 
Revise tests cases to align with the new EXPLAIN QUERY PLAN output.

FossilOrigin-Name: 50fbd532602d2c316813046ed6be8be2991c281eb5f295c4c28520a0de73862c

4 years agoFix a faulty assert() in the OP_SkipScan opcode.
drh [Sat, 20 Mar 2021 01:00:26 +0000 (01:00 +0000)] 
Fix a faulty assert() in the OP_SkipScan opcode.
dbsqlfuzz a15a9b2ca82e812ad52f62c86cc93dca0dc72f01.
Test cases in TH3.

FossilOrigin-Name: 1805b9aaf1172e36e08271f78ebb7676bba9f3c4c28e077ee94cc31b8e7ec741

4 years agoFurther simplification of the EQP output. Only show "SUBQUERY n" if the
drh [Fri, 19 Mar 2021 19:44:56 +0000 (19:44 +0000)] 
Further simplification of the EQP output.  Only show "SUBQUERY n" if the
subquery is anonymous.

FossilOrigin-Name: 1fadd30525dbf22678ba014b78af3a0fb33047692f073b7c62a90a028081ac48

4 years agoMerge enhancements from trunk.
drh [Fri, 19 Mar 2021 19:09:24 +0000 (19:09 +0000)] 
Merge enhancements from trunk.

FossilOrigin-Name: d192d737755876293a2914fcb9a0d5efbe07f3cd281c038666ea5aa879c06321

4 years agoIn the wholenumber virtual table, increase the cost penalty for running
drh [Fri, 19 Mar 2021 17:54:43 +0000 (17:54 +0000)] 
In the wholenumber virtual table, increase the cost penalty for running
open-loop.  This appears to fix the problem reported by
[https://sqlite.org/forum/forumpost/b52a020ce4|forum post b52a020ce4].

FossilOrigin-Name: f12b54042e27b2fe99f23f97c103ee4371f8d4df3b049d9bb5d64891db56eee5

4 years agoDbsqlfuzz found a new way to make that branch in codeVectorCompare
drh [Fri, 19 Mar 2021 16:29:40 +0000 (16:29 +0000)] 
Dbsqlfuzz found a new way to make that branch in codeVectorCompare
reachable.

FossilOrigin-Name: 959272c27555e39f180d46257afe45d41da1f5df38ea269196c06741ff6a278e

4 years agoFix tokenizer's classification of EBCDIC newline.
larrybr [Fri, 19 Mar 2021 15:02:59 +0000 (15:02 +0000)] 
Fix tokenizer's classification of EBCDIC newline.

FossilOrigin-Name: 8680f6a8fb34b9c0ea9b4286888b4df5df427d2df10c782d198bc3f2fdcd0704

4 years agoRestore the NEVER() that was taken out by [f481636f1a0333c6] because that
drh [Fri, 19 Mar 2021 14:51:15 +0000 (14:51 +0000)] 
Restore the NEVER() that was taken out by [f481636f1a0333c6] because that
case is no longer reachable after the previous check-in.

FossilOrigin-Name: e3a78b2a237a2e101faf01dde913f63641da8854720a9daa4b45a9c5dfe30b1b

4 years agoFix a crash that could occur when an INSERT has more than one ON CONFLICT clause...
dan [Fri, 19 Mar 2021 14:26:24 +0000 (14:26 +0000)] 
Fix a crash that could occur when an INSERT has more than one ON CONFLICT clause, at least one of which contains an unresolvable symbol.

FossilOrigin-Name: 74208386508012326a0e88ec5b4a995d1b99607720bb05785a01c2d89ea03543

4 years agoCorrelated CTEs should not generate a materialization subroutine. If they
drh [Fri, 19 Mar 2021 13:53:34 +0000 (13:53 +0000)] 
Correlated CTEs should not generate a materialization subroutine.  If they
need to be materialized, each use case must be materialized separately.
dbsqlfuzz 01b8355086998f0a452cb31208e80b9d29ca739a.

FossilOrigin-Name: d72d865d3e8503a545603038eb26044bee42e4e8725522be678059ce6517fc8d

4 years agoImproved labeling of EXPLAIN QUERY PLAN output. Many test failures due to
drh [Fri, 19 Mar 2021 13:00:28 +0000 (13:00 +0000)] 
Improved labeling of EXPLAIN QUERY PLAN output.  Many test failures due to
the different output format.

FossilOrigin-Name: 6f8faec0222a7ca07cc1a5ed16cc08d92c6e20bbcb34851b4eff9e624de53601

4 years agoAdd a NEVER() on a branch that was made unreachable by the
drh [Thu, 18 Mar 2021 20:04:46 +0000 (20:04 +0000)] 
Add a NEVER() on a branch that was made unreachable by the
"circular reference" fix.

FossilOrigin-Name: 114d9780aecdd9f03f235fc1f2ab81ef89cb00b3bafa61cff612e939595ff5f0

4 years agoDisable a test case requiring generate_series when virtual tables are not
drh [Thu, 18 Mar 2021 18:27:37 +0000 (18:27 +0000)] 
Disable a test case requiring generate_series when virtual tables are not
available.

FossilOrigin-Name: ee86e2f4c5999a090a5d2fe8251107cf55e621a6b988f315eb82f462cc1e377d

4 years agoFix a problem causing spurious "<cte>: circular reference" errors to be reported...
dan [Thu, 18 Mar 2021 18:25:43 +0000 (18:25 +0000)] 
Fix a problem causing spurious "<cte>: circular reference" errors to be reported when there is actually a different error in the SQL statement.

FossilOrigin-Name: 9981223618782bf867dfc8988d0c634a42f569228880c5c5e00aa4ae762cfff2

4 years agoIncrease the patch level to 3.35.3.
drh [Thu, 18 Mar 2021 16:52:06 +0000 (16:52 +0000)] 
Increase the patch level to 3.35.3.

FossilOrigin-Name: 259b7c3e219873f3f679b00d3a89ecdac8a02c3472176d3a260f399e1faf3611

4 years agoFix the OP_OpenDup opcode so that it is able to duplicate a cursor that
drh [Thu, 18 Mar 2021 16:47:24 +0000 (16:47 +0000)] 
Fix the OP_OpenDup opcode so that it is able to duplicate a cursor that
was itself opened by OP_OpenDup.  Add additional verification of
ephemeral tables.  Fix for ticket [bb8a9fd4a9b7fce5].

FossilOrigin-Name: bcbe5308f3a3b94f965b0f5627cb29cce2e09343b86d757e2de889f7773576e7

4 years agoRemove unnecessary code from sqlite3BtreeClose() and add test cases. opendup-fix
drh [Thu, 18 Mar 2021 16:36:31 +0000 (16:36 +0000)] 
Remove unnecessary code from sqlite3BtreeClose() and add test cases.

FossilOrigin-Name: edbfdcaefae1e9a42c046c058341bf5b0f533c0b0cbd39543fcaa2a83d67561d

4 years agoFurther sanity checking of the OpenDup cursors.
drh [Thu, 18 Mar 2021 15:42:59 +0000 (15:42 +0000)] 
Further sanity checking of the OpenDup cursors.

FossilOrigin-Name: 0ec71cf16983697f68ab8d921d80a5f39611e4cb5e6e19cbc4a9ad6d49bfc835

4 years agoFix the dbsqlfuzz-derived authorizer in fuzzcheck to avoid creating junk
drh [Thu, 18 Mar 2021 14:36:19 +0000 (14:36 +0000)] 
Fix the dbsqlfuzz-derived authorizer in fuzzcheck to avoid creating junk
files when running rogue tests.

FossilOrigin-Name: eca21a620630b0c8d21a91ad6a8760a6c87270ab2a45cafa18bd31b305c53dba

4 years agoAutomatically close ephemeral b-trees when their last cursor is closed.
dan [Thu, 18 Mar 2021 14:31:37 +0000 (14:31 +0000)] 
Automatically close ephemeral b-trees when their last cursor is closed.

FossilOrigin-Name: 39b5af18c0580c8e92516d410f8c465bfec31b2d0be9df1cfd6a1d1a19b4fc14

4 years agoFix a problem with the filename normalizer in unix, discovered by dbsqlfuzz.
drh [Thu, 18 Mar 2021 13:55:25 +0000 (13:55 +0000)] 
Fix a problem with the filename normalizer in unix, discovered by dbsqlfuzz.

FossilOrigin-Name: ff1eca7fcdcbc550a5f23db9d85281e5373500912699a7c7ae54bc0df0547e26

4 years agoAllow instruction OP_OpenDup to duplicate cursors created by OP_OpenDup, as well...
dan [Thu, 18 Mar 2021 13:42:53 +0000 (13:42 +0000)] 
Allow instruction OP_OpenDup to duplicate cursors created by OP_OpenDup, as well as by OP_OpenEphemeral.

FossilOrigin-Name: b8de980b2fb78088ef74e053cb987bb84319d13dc96ce1e89baaaa3fe8cf1efc

4 years agoNew assert statements associated with Ephemeral cursors in the bytecode engine.
drh [Thu, 18 Mar 2021 13:19:41 +0000 (13:19 +0000)] 
New assert statements associated with Ephemeral cursors in the bytecode engine.

FossilOrigin-Name: a8ce73e2573b271d5d45838802ed1905ce5e18d5fafe0078700e79fab85457e2

4 years agoChange the name of the iDataVersion field of Btree to iBDataVersion to make
drh [Thu, 18 Mar 2021 12:36:09 +0000 (12:36 +0000)] 
Change the name of the iDataVersion field of Btree to iBDataVersion to make
it distinct from Pager.iDataVersion.

FossilOrigin-Name: e4c44c0bca317c03f8e6d3aa7cc88e5f96159a3d91c07257d408f7db028fd151

4 years agoVersion 3.35.2 union-all-flattener-limit version-3.35.2
drh [Wed, 17 Mar 2021 19:07:21 +0000 (19:07 +0000)] 
Version 3.35.2

FossilOrigin-Name: ea80f3002f4120f5dcee76e8779dfdc88e1e096c5cdd06904c20fd26d50c3827

4 years agoFix a harmless compiler warning in the appendvfs.c extension.
drh [Wed, 17 Mar 2021 19:05:59 +0000 (19:05 +0000)] 
Fix a harmless compiler warning in the appendvfs.c extension.

FossilOrigin-Name: 0ed7eb9115510511f13dca715bb2b178580648517d8d30436a992d70a2e85ac1

4 years agoIf there are already 500 or more simple SELECTs in a query, do not add more by flatte...
dan [Wed, 17 Mar 2021 14:29:37 +0000 (14:29 +0000)] 
If there are already 500 or more simple SELECTs in a query, do not add more by flattening UNION ALL sub-queries into parent join queries.

FossilOrigin-Name: 9520bed2bd87dc56543ee58123323d293e960ecd84707b77f15f41669a2c9c3d

4 years agoFix a problem in sqldiff virtual table hanlding to do with tab and other non-space...
dan [Wed, 17 Mar 2021 11:25:42 +0000 (11:25 +0000)] 
Fix a problem in sqldiff virtual table hanlding to do with tab and other non-space whitespace characters in the CREATE VIRTUAL TABLE statement.

FossilOrigin-Name: 1737e4fdfc9a3628415b234338a68a64cbbaadb23598517761e571ab7ed7ad14

4 years agoDate/time functions with no arguments (ex: date() or time()) should be
drh [Tue, 16 Mar 2021 18:41:20 +0000 (18:41 +0000)] 
Date/time functions with no arguments (ex: date() or time()) should be
non-deterministic.  Fix for ticket [2c6c8689fb5f3d2f].

FossilOrigin-Name: 1734c332e7f609769fc30f82cf7af097c2964e08900ee3e297f6a25e6df60555

4 years agoAdd tests for sqlite_rename_quotefix(). Fix a memory leak in the same. alter-quotefix
dan [Tue, 16 Mar 2021 18:24:49 +0000 (18:24 +0000)] 
Add tests for sqlite_rename_quotefix(). Fix a memory leak in the same.

FossilOrigin-Name: 531550056c38589c99c9a97b6afdbf8f34ff8d2131d74e9d42af3506e8045064

4 years agoHave ALTER TABLE RENAME COLUMN and DROP COLUMN use sqlite_rename_quotefix() to conver...
dan [Tue, 16 Mar 2021 16:14:48 +0000 (16:14 +0000)] 
Have ALTER TABLE RENAME COLUMN and DROP COLUMN use sqlite_rename_quotefix() to convert any double-quoted strings in the database schema to their single-quoted equivalents.

FossilOrigin-Name: 6446c0961077396086251670102ea7bf17d54a6b0f0ca56c6af89028a1ff9039

4 years agoIncrease the version number to 3.35.2.
drh [Tue, 16 Mar 2021 14:43:26 +0000 (14:43 +0000)] 
Increase the version number to 3.35.2.

FossilOrigin-Name: 7a211b3f09b17b758ac43c3ed14e3f90c55459077412a57baca0f7cadff47fbf

4 years agoFix recent breakage of the appendvfs extension.
drh [Tue, 16 Mar 2021 14:26:56 +0000 (14:26 +0000)] 
Fix recent breakage of the appendvfs extension.

FossilOrigin-Name: 7dbbe5b34eea31ea54a5804035d4d0dfeb09c42cd9ab337e1e64c1296decbef3

4 years agoComment and stylistic changes to the appendvfs.c implementation. appendvfs_fix
drh [Tue, 16 Mar 2021 14:12:26 +0000 (14:12 +0000)] 
Comment and stylistic changes to the appendvfs.c implementation.

FossilOrigin-Name: 25c3186aa143328157fb506a29802e87099cd14be4fa218230484a3212f20621

4 years agoMerge trunk changes into this branch.
dan [Tue, 16 Mar 2021 11:21:36 +0000 (11:21 +0000)] 
Merge trunk changes into this branch.

FossilOrigin-Name: f15d51054afb1e3fec87938f2b04a5a0d0611b08248367850450de7c4166e3d1

4 years agoFix a problem with ALTER TABLE RENAME COLUMN when used on a schema that features...
dan [Tue, 16 Mar 2021 11:11:07 +0000 (11:11 +0000)] 
Fix a problem with ALTER TABLE RENAME COLUMN when used on a schema that features generated columns.

FossilOrigin-Name: 0e255b26872b50581d470952dd98e21dd82d081885006f58d49daa4b4576b35d

4 years agoFix assert typo.
larrybr [Tue, 16 Mar 2021 07:06:29 +0000 (07:06 +0000)] 
Fix assert typo.

FossilOrigin-Name: 3aedf818c1cfc88ee1103abd8b20e787f6be1bcc4c9350963f0cd52f5ac04154

4 years agoMerge from trunk.
larrybr [Tue, 16 Mar 2021 06:50:39 +0000 (06:50 +0000)] 
Merge from trunk.

FossilOrigin-Name: eae8236f3b9bc326648d1c8fca61cb3c38f821d06fe915fd0978cffeb1f6152b

4 years agoFix appendvfs bug exposed with bigger files, and add tests for such conditions.
larrybr [Tue, 16 Mar 2021 06:41:51 +0000 (06:41 +0000)] 
Fix appendvfs bug exposed with bigger files, and add tests for such conditions.

FossilOrigin-Name: 19b1f53a1c0a14440ae8ac71660a2595d37a4a5b201055c19366c7dca75d6660

4 years agoCreate new branch named "appendvfs_fix"
larrybr [Tue, 16 Mar 2021 04:03:59 +0000 (04:03 +0000)] 
Create new branch named "appendvfs_fix"

FossilOrigin-Name: 026edd601444d86858a503ffc3be17667a62a29f09c001009d9a678400b3b0a1

4 years agoAdd internal SQL function sqlite_rename_quotefix(). For converting double-quoted...
dan [Mon, 15 Mar 2021 20:22:34 +0000 (20:22 +0000)] 
Add internal SQL function sqlite_rename_quotefix(). For converting double-quoted strings to their single-quoted counterparts in DDL statements.

FossilOrigin-Name: d874b300463ce0bbb53b7e2f88c6a12893e4fd751fcc7f810077ba108f4061ef

4 years agoVersion 3.35.1 version-3.35.1
drh [Mon, 15 Mar 2021 16:53:57 +0000 (16:53 +0000)] 
Version 3.35.1

FossilOrigin-Name: aea12399bf1fdc76af43499d4624c3afa17c3e6c2459b71c195804bb98def66a

4 years agoImprovements to the built-in ".dump" documentation in the CLI.
drh [Mon, 15 Mar 2021 15:12:10 +0000 (15:12 +0000)] 
Improvements to the built-in ".dump" documentation in the CLI.

FossilOrigin-Name: 0915f969f429a8d0b594e937e0128d5476774d9bbe4a24081dbc60273cb5bb9a

4 years agoBump the version number to 3.35.1.
drh [Mon, 15 Mar 2021 15:02:38 +0000 (15:02 +0000)] 
Bump the version number to 3.35.1.

FossilOrigin-Name: 184d5a352f098459cfb0cc029713d5d43fefc83f6cc95ce5666bd07591aaac2f

4 years agoImproved detection of conflicting indexes when doing DROP COLUMN on a column
drh [Mon, 15 Mar 2021 14:58:12 +0000 (14:58 +0000)] 
Improved detection of conflicting indexes when doing DROP COLUMN on a column
whose name is quoted in the index definition.
Fix for ticket [1c24a659e6d7f3a1].

FossilOrigin-Name: c450d0ad6b39db4bf93015d629e25f7af0d7a9779f7a987e2fc38a5ef064a182

4 years agoMake shell's .help output for .dump more accurate as to what can be dumped. cli-tweaks
larrybr [Mon, 15 Mar 2021 12:56:00 +0000 (12:56 +0000)] 
Make shell's .help output for .dump more accurate as to what can be dumped.

FossilOrigin-Name: f91d8c09a02f7a7ab354c49cd193d422074daa5eb908f17d1907a8c2b38f96a5

4 years agoCreate new branch named "cli-tweaks"
larrybr [Mon, 15 Mar 2021 12:32:35 +0000 (12:32 +0000)] 
Create new branch named "cli-tweaks"

FossilOrigin-Name: 4cf056a571cae6fded8136bc12f3a2787da37c6b52383cbf7b918827654ba4e7

4 years agoAn additional test case tkt-1c24a659-b
drh [Sun, 14 Mar 2021 20:17:06 +0000 (20:17 +0000)] 
An additional test case

FossilOrigin-Name: 7e2d7ca15a84e5bd9f2b1360232607d15c2dbcc9d30b0f1a7cdbf2865e6b1af5

4 years agoAn alternative approach for fixing ticket [1c24a659e6d7f3a1].
drh [Sun, 14 Mar 2021 19:55:40 +0000 (19:55 +0000)] 
An alternative approach for fixing ticket [1c24a659e6d7f3a1].

FossilOrigin-Name: a2adae907a28e169e64cfe69d97d7b68cb94e6ba07d2dfa995e3fbc6672fafdd

4 years agoFix a memory leak in the new code on this branch. distinct-agg-opt
dan [Sat, 13 Mar 2021 18:23:30 +0000 (18:23 +0000)] 
Fix a memory leak in the new code on this branch.

FossilOrigin-Name: 0817cf2ec08fdefd3c1d41790df7b5d6d490767757b44bb0229694023c8e40fc

4 years agoFix typos in comments and add test cases.
dan [Sat, 13 Mar 2021 17:21:24 +0000 (17:21 +0000)] 
Fix typos in comments and add test cases.

FossilOrigin-Name: 01312a3dbd92823af535dc618c68d95a2aa1cbee2501b0a9826eae3f09bec760

4 years agoUpdate generated autoconf/Makefile.msc to reflect its source.
larrybr [Fri, 12 Mar 2021 23:15:08 +0000 (23:15 +0000)] 
Update generated autoconf/Makefile.msc to reflect its source.

FossilOrigin-Name: d9f8f488ff9d47fe7bb8838e683bae4fea038f7278ef885ecf292143a0dd88ed

4 years agoFix a crash in new code on this branch.
dan [Fri, 12 Mar 2021 21:09:20 +0000 (21:09 +0000)] 
Fix a crash in new code on this branch.

FossilOrigin-Name: c05ed2a8a9c4975c69bdfa733598ed90c1509d52b3c39dedbd829ab148777e1d

4 years agoMerge latest trunk changes into this branch.
dan [Fri, 12 Mar 2021 18:33:55 +0000 (18:33 +0000)] 
Merge latest trunk changes into this branch.

FossilOrigin-Name: 198bc510d64b5794559584ad5c9de41dc966dce4eb78be15b12adba43dfcb639

4 years agoAttempt to use an index for DISTINCT aggregate queries that have GROUP BY clauses.
dan [Fri, 12 Mar 2021 18:24:31 +0000 (18:24 +0000)] 
Attempt to use an index for DISTINCT aggregate queries that have GROUP BY clauses.

FossilOrigin-Name: 3bca003cd2b2cb38d4a4e2e5f673ee0ac05bfe31247ec09e7bd379b77a31b44c

4 years agoVersion 3.35.0 version-3.35.0
drh [Fri, 12 Mar 2021 15:10:09 +0000 (15:10 +0000)] 
Version 3.35.0

FossilOrigin-Name: acd63062eb06748bfe9e4886639e4f2b54ea6a496a83f10716abbaba4115500b

4 years agoFix broken requirement marks.
drh [Fri, 12 Mar 2021 13:49:09 +0000 (13:49 +0000)] 
Fix broken requirement marks.

FossilOrigin-Name: 98d67152849e062c6de45b0e526daffc3d6cb29d563d40664a8d7140119a30b2

4 years agoFix the ".read" command in the CLI so that SQLITE_OMIT_POPEN disables
drh [Fri, 12 Mar 2021 01:49:08 +0000 (01:49 +0000)] 
Fix the ".read" command in the CLI so that SQLITE_OMIT_POPEN disables
reading from a pipeline.

FossilOrigin-Name: cea34f3cc35ad6dc67691799a219a30739f2296945d624d232bf76150c598ec0

4 years agoConform description of sqlite3changeset_op() arguments to implemented behavior, some...
larrybr [Fri, 12 Mar 2021 00:44:10 +0000 (00:44 +0000)] 
Conform description of sqlite3changeset_op() arguments to implemented behavior, some reformatting.
This is a comment-only change; no code is affected.

FossilOrigin-Name: 9d6e544c47b9a5d97bd02a658db5cd202bd1952f8ba3bc50e8cf47d7206041c0

4 years agoFix a Tcl object leak in test_session.c.
dan [Thu, 11 Mar 2021 15:57:25 +0000 (15:57 +0000)] 
Fix a Tcl object leak in test_session.c.

FossilOrigin-Name: 07150cf15ad36c7fc681a911f66db23d610ddf110a7be7f1fcefbd8750cd135a

4 years agoBug fix in appendvfs.c: Adjust the size parameter for
drh [Thu, 11 Mar 2021 13:43:29 +0000 (13:43 +0000)] 
Bug fix in appendvfs.c:  Adjust the size parameter for
SQLITE_FCNTL_SIZE_HINT to account for the prefix.

FossilOrigin-Name: 41df3bbefd63151f2ddb920066777eab8e07ecfc0edb0f71f9493debe0a4a2c4

4 years agoHave the Tcl tests support environment variable SQLITE_TEST_PATTERN_LIST, so that...
dan [Thu, 11 Mar 2021 08:49:52 +0000 (08:49 +0000)] 
Have the Tcl tests support environment variable SQLITE_TEST_PATTERN_LIST, so that if it is set it is interpreted as a list of patterns that are matched against tests file names. Only test files that match at least one pattern are run.

FossilOrigin-Name: b7c92e1d08f213865f026d8dbdc4e805fb5c119b7f206506ed06e83a878de657

4 years agoFix sanitizer complaint in fts3 code.
dan [Wed, 10 Mar 2021 20:04:21 +0000 (20:04 +0000)] 
Fix sanitizer complaint in fts3 code.

FossilOrigin-Name: 424b39eaeb578f85e58214af4b467e6e363431308ab7a327774e62fa70d3c2db

4 years agoFix further sanitizer complaints in the fts5 code.
dan [Wed, 10 Mar 2021 19:32:47 +0000 (19:32 +0000)] 
Fix further sanitizer complaints in the fts5 code.

FossilOrigin-Name: 4cb00b9d4020a51f690720c6f51009c5be8c22ef8c70807ead1d953d19784f26

4 years agoImproved testcase() related the SQLITE_MAX_ATTACHED vs. SQLITE_MAX_DB problem.
drh [Wed, 10 Mar 2021 18:21:18 +0000 (18:21 +0000)] 
Improved testcase() related the SQLITE_MAX_ATTACHED vs. SQLITE_MAX_DB problem.

FossilOrigin-Name: 27d3c00efef66ad48ed94228474dbea3ad81ea5c19425028c42cf4220920a645

4 years agoImprovement to the ATTACH-abuse authorizer logic in fuzzcheck.
drh [Wed, 10 Mar 2021 17:52:59 +0000 (17:52 +0000)] 
Improvement to the ATTACH-abuse authorizer logic in fuzzcheck.

FossilOrigin-Name: 88132f698a7a9b7d41dd1dd393592cbda130d2bf1a9fd18c509503e1891b9655

4 years agoDo not run avfs.test when testing SQLITE_OMIT_VIRTUALTABLE builds.
dan [Wed, 10 Mar 2021 17:43:18 +0000 (17:43 +0000)] 
Do not run avfs.test when testing SQLITE_OMIT_VIRTUALTABLE builds.

FossilOrigin-Name: 2ab6957a2238a2ab713a50d21dbd9921c944e8141197275bbfe7dae303fee7d0

4 years agoDo not confuse the constant SQLITE_MAX_ATTACHED with the maximum number of
drh [Wed, 10 Mar 2021 16:35:37 +0000 (16:35 +0000)] 
Do not confuse the constant SQLITE_MAX_ATTACHED with the maximum number of
schemas.  Add the new SQLITE_MAX_DB constant for the maximum number of
schemas.  [forum:/forumpost/a006d86f72|Forum post a006d86f72].

FossilOrigin-Name: 7b65fb9f7bd616f834633afd64b3448bf9ca2b6e4cc6d6c01e75d1d877c88a79

4 years agoFix test file avfs.test so that it works with SQLITE_DEFAULT_AUTOVACUUM builds. Do...
dan [Wed, 10 Mar 2021 15:10:20 +0000 (15:10 +0000)] 
Fix test file avfs.test so that it works with SQLITE_DEFAULT_AUTOVACUUM builds. Do not run avfs.test under test permutation "journaltest".

FossilOrigin-Name: 2c6078ebe797dd2cb6045b5f13e6d92a6b49393ecf96f9fd7222412f5a3eefd5

4 years agoFix a few sanitizer complaints in fts5.
dan [Wed, 10 Mar 2021 14:57:10 +0000 (14:57 +0000)] 
Fix a few sanitizer complaints in fts5.

FossilOrigin-Name: 4fe4fee00e9294fa384bd073ed8e9a2a4ad10dcf653b6ad4851e44a64443ede9

4 years agoFix a problem preventing wapptest from setting SQLITE_ENABLE_LOCKING_STYLE for OSX...
dan [Wed, 10 Mar 2021 10:43:17 +0000 (10:43 +0000)] 
Fix a problem preventing wapptest from setting SQLITE_ENABLE_LOCKING_STYLE for OSX tests. Also modify the "Sanitize" configuration in releasetest_data.tcl to subsume test item 6g.

FossilOrigin-Name: f762d7df2a41a88560a4251d744e0887f42812f8160af4f0129d22a71c0fa48b

4 years agoWhen shell has no .ar, fake its effect w.r.t. page_size and table creation/filling.
larrybr [Wed, 10 Mar 2021 06:06:16 +0000 (06:06 +0000)] 
When shell has no .ar, fake its effect w.r.t. page_size and table creation/filling.

FossilOrigin-Name: 959f5c65ea14f4716df61e250e9d5a0d69d602a2a973ad22a364e640162c2983

4 years agoAdd appendvfs.c to the MSVC makefile.
drh [Tue, 9 Mar 2021 23:38:27 +0000 (23:38 +0000)] 
Add appendvfs.c to the MSVC makefile.

FossilOrigin-Name: a6681fbb2e0c8d5a7c968f6fd458f61658fad6ac4c7eb8663762b6ac386cdae5