]> git.ipfire.org Git - thirdparty/sqlite.git/log
thirdparty/sqlite.git
4 years agoMerge recent fixes from trunk. eqp-improvements
drh [Mon, 22 Mar 2021 18:53:26 +0000 (18:53 +0000)] 
Merge recent fixes from trunk.

FossilOrigin-Name: 4a343698b4ec3364b0eecb7fa074512ecac8b586aff1f977ca77f215e96e0ce5

4 years agoIncrease the version number to 3.36.0 to begin the next development cycle.
drh [Mon, 22 Mar 2021 16:50:39 +0000 (16:50 +0000)] 
Increase the version number to 3.36.0 to begin the next development cycle.

FossilOrigin-Name: 5cee689d647087a5e796da2acb247a4f469a8b39b54f59bb4ad2386647cef1bd

4 years agoFix an assert() that in preupdate-hook logic (not normally built) that same-as-3.35.3
drh [Sun, 21 Mar 2021 18:23:48 +0000 (18:23 +0000)] 
Fix an assert() that in preupdate-hook logic (not normally built) that
can be false when running VACUUM on a corrupt database file under
PRAGMA writable_schema=ON.

FossilOrigin-Name: 6bb2134027a12801de8e0c73482d94682f902024800a7e426614f65a2fe4f64c

4 years agoAdd a better comment and an assert() on the code inside sqlite3CreateIndex()
drh [Sun, 21 Mar 2021 17:52:47 +0000 (17:52 +0000)] 
Add a better comment and an assert() on the code inside sqlite3CreateIndex()
that REPLACE indexes come at the end of the index list.
[forum:/forumpost/ceb51d83f7|forum post ceb51d83f7]

FossilOrigin-Name: 71e4da136bd1b5b75a699d69fbaaaec0f9dd1a87e2a9d049a55154892b06647b

4 years agoFix the "box" output mode in the shell when statement returns zero-column
drh [Sat, 20 Mar 2021 23:15:52 +0000 (23:15 +0000)] 
Fix the "box" output mode in the shell when statement returns zero-column
rows (for example from "PRAGMA incremental_vacuum").

FossilOrigin-Name: 34439fe3aeea7cbbc817245d39c345a7f5df7a82ac15ee4d71bb9a4d818198ed

4 years agoUse the canonical name, not the AS name, when showing the MATERIALIZE or
drh [Sat, 20 Mar 2021 15:46:01 +0000 (15:46 +0000)] 
Use the canonical name, not the AS name, when showing the MATERIALIZE or
CO-ROUTINE lines for a CTE.

FossilOrigin-Name: 1b83e232c490fe6e9f999d30399faebfac6094bf940dc21dc459ed2c97657cb2

4 years agoRevise tests cases to align with the new EXPLAIN QUERY PLAN output.
drh [Sat, 20 Mar 2021 15:11:29 +0000 (15:11 +0000)] 
Revise tests cases to align with the new EXPLAIN QUERY PLAN output.

FossilOrigin-Name: 50fbd532602d2c316813046ed6be8be2991c281eb5f295c4c28520a0de73862c

4 years agoFix a faulty assert() in the OP_SkipScan opcode.
drh [Sat, 20 Mar 2021 01:00:26 +0000 (01:00 +0000)] 
Fix a faulty assert() in the OP_SkipScan opcode.
dbsqlfuzz a15a9b2ca82e812ad52f62c86cc93dca0dc72f01.
Test cases in TH3.

FossilOrigin-Name: 1805b9aaf1172e36e08271f78ebb7676bba9f3c4c28e077ee94cc31b8e7ec741

4 years agoFurther simplification of the EQP output. Only show "SUBQUERY n" if the
drh [Fri, 19 Mar 2021 19:44:56 +0000 (19:44 +0000)] 
Further simplification of the EQP output.  Only show "SUBQUERY n" if the
subquery is anonymous.

FossilOrigin-Name: 1fadd30525dbf22678ba014b78af3a0fb33047692f073b7c62a90a028081ac48

4 years agoMerge enhancements from trunk.
drh [Fri, 19 Mar 2021 19:09:24 +0000 (19:09 +0000)] 
Merge enhancements from trunk.

FossilOrigin-Name: d192d737755876293a2914fcb9a0d5efbe07f3cd281c038666ea5aa879c06321

4 years agoIn the wholenumber virtual table, increase the cost penalty for running
drh [Fri, 19 Mar 2021 17:54:43 +0000 (17:54 +0000)] 
In the wholenumber virtual table, increase the cost penalty for running
open-loop.  This appears to fix the problem reported by
[https://sqlite.org/forum/forumpost/b52a020ce4|forum post b52a020ce4].

FossilOrigin-Name: f12b54042e27b2fe99f23f97c103ee4371f8d4df3b049d9bb5d64891db56eee5

4 years agoDbsqlfuzz found a new way to make that branch in codeVectorCompare
drh [Fri, 19 Mar 2021 16:29:40 +0000 (16:29 +0000)] 
Dbsqlfuzz found a new way to make that branch in codeVectorCompare
reachable.

FossilOrigin-Name: 959272c27555e39f180d46257afe45d41da1f5df38ea269196c06741ff6a278e

4 years agoFix tokenizer's classification of EBCDIC newline.
larrybr [Fri, 19 Mar 2021 15:02:59 +0000 (15:02 +0000)] 
Fix tokenizer's classification of EBCDIC newline.

FossilOrigin-Name: 8680f6a8fb34b9c0ea9b4286888b4df5df427d2df10c782d198bc3f2fdcd0704

4 years agoRestore the NEVER() that was taken out by [f481636f1a0333c6] because that
drh [Fri, 19 Mar 2021 14:51:15 +0000 (14:51 +0000)] 
Restore the NEVER() that was taken out by [f481636f1a0333c6] because that
case is no longer reachable after the previous check-in.

FossilOrigin-Name: e3a78b2a237a2e101faf01dde913f63641da8854720a9daa4b45a9c5dfe30b1b

4 years agoFix a crash that could occur when an INSERT has more than one ON CONFLICT clause...
dan [Fri, 19 Mar 2021 14:26:24 +0000 (14:26 +0000)] 
Fix a crash that could occur when an INSERT has more than one ON CONFLICT clause, at least one of which contains an unresolvable symbol.

FossilOrigin-Name: 74208386508012326a0e88ec5b4a995d1b99607720bb05785a01c2d89ea03543

4 years agoCorrelated CTEs should not generate a materialization subroutine. If they
drh [Fri, 19 Mar 2021 13:53:34 +0000 (13:53 +0000)] 
Correlated CTEs should not generate a materialization subroutine.  If they
need to be materialized, each use case must be materialized separately.
dbsqlfuzz 01b8355086998f0a452cb31208e80b9d29ca739a.

FossilOrigin-Name: d72d865d3e8503a545603038eb26044bee42e4e8725522be678059ce6517fc8d

4 years agoImproved labeling of EXPLAIN QUERY PLAN output. Many test failures due to
drh [Fri, 19 Mar 2021 13:00:28 +0000 (13:00 +0000)] 
Improved labeling of EXPLAIN QUERY PLAN output.  Many test failures due to
the different output format.

FossilOrigin-Name: 6f8faec0222a7ca07cc1a5ed16cc08d92c6e20bbcb34851b4eff9e624de53601

4 years agoAdd a NEVER() on a branch that was made unreachable by the
drh [Thu, 18 Mar 2021 20:04:46 +0000 (20:04 +0000)] 
Add a NEVER() on a branch that was made unreachable by the
"circular reference" fix.

FossilOrigin-Name: 114d9780aecdd9f03f235fc1f2ab81ef89cb00b3bafa61cff612e939595ff5f0

4 years agoDisable a test case requiring generate_series when virtual tables are not
drh [Thu, 18 Mar 2021 18:27:37 +0000 (18:27 +0000)] 
Disable a test case requiring generate_series when virtual tables are not
available.

FossilOrigin-Name: ee86e2f4c5999a090a5d2fe8251107cf55e621a6b988f315eb82f462cc1e377d

4 years agoFix a problem causing spurious "<cte>: circular reference" errors to be reported...
dan [Thu, 18 Mar 2021 18:25:43 +0000 (18:25 +0000)] 
Fix a problem causing spurious "<cte>: circular reference" errors to be reported when there is actually a different error in the SQL statement.

FossilOrigin-Name: 9981223618782bf867dfc8988d0c634a42f569228880c5c5e00aa4ae762cfff2

4 years agoIncrease the patch level to 3.35.3.
drh [Thu, 18 Mar 2021 16:52:06 +0000 (16:52 +0000)] 
Increase the patch level to 3.35.3.

FossilOrigin-Name: 259b7c3e219873f3f679b00d3a89ecdac8a02c3472176d3a260f399e1faf3611

4 years agoFix the OP_OpenDup opcode so that it is able to duplicate a cursor that
drh [Thu, 18 Mar 2021 16:47:24 +0000 (16:47 +0000)] 
Fix the OP_OpenDup opcode so that it is able to duplicate a cursor that
was itself opened by OP_OpenDup.  Add additional verification of
ephemeral tables.  Fix for ticket [bb8a9fd4a9b7fce5].

FossilOrigin-Name: bcbe5308f3a3b94f965b0f5627cb29cce2e09343b86d757e2de889f7773576e7

4 years agoRemove unnecessary code from sqlite3BtreeClose() and add test cases. opendup-fix
drh [Thu, 18 Mar 2021 16:36:31 +0000 (16:36 +0000)] 
Remove unnecessary code from sqlite3BtreeClose() and add test cases.

FossilOrigin-Name: edbfdcaefae1e9a42c046c058341bf5b0f533c0b0cbd39543fcaa2a83d67561d

4 years agoFurther sanity checking of the OpenDup cursors.
drh [Thu, 18 Mar 2021 15:42:59 +0000 (15:42 +0000)] 
Further sanity checking of the OpenDup cursors.

FossilOrigin-Name: 0ec71cf16983697f68ab8d921d80a5f39611e4cb5e6e19cbc4a9ad6d49bfc835

4 years agoFix the dbsqlfuzz-derived authorizer in fuzzcheck to avoid creating junk
drh [Thu, 18 Mar 2021 14:36:19 +0000 (14:36 +0000)] 
Fix the dbsqlfuzz-derived authorizer in fuzzcheck to avoid creating junk
files when running rogue tests.

FossilOrigin-Name: eca21a620630b0c8d21a91ad6a8760a6c87270ab2a45cafa18bd31b305c53dba

4 years agoAutomatically close ephemeral b-trees when their last cursor is closed.
dan [Thu, 18 Mar 2021 14:31:37 +0000 (14:31 +0000)] 
Automatically close ephemeral b-trees when their last cursor is closed.

FossilOrigin-Name: 39b5af18c0580c8e92516d410f8c465bfec31b2d0be9df1cfd6a1d1a19b4fc14

4 years agoFix a problem with the filename normalizer in unix, discovered by dbsqlfuzz.
drh [Thu, 18 Mar 2021 13:55:25 +0000 (13:55 +0000)] 
Fix a problem with the filename normalizer in unix, discovered by dbsqlfuzz.

FossilOrigin-Name: ff1eca7fcdcbc550a5f23db9d85281e5373500912699a7c7ae54bc0df0547e26

4 years agoAllow instruction OP_OpenDup to duplicate cursors created by OP_OpenDup, as well...
dan [Thu, 18 Mar 2021 13:42:53 +0000 (13:42 +0000)] 
Allow instruction OP_OpenDup to duplicate cursors created by OP_OpenDup, as well as by OP_OpenEphemeral.

FossilOrigin-Name: b8de980b2fb78088ef74e053cb987bb84319d13dc96ce1e89baaaa3fe8cf1efc

4 years agoNew assert statements associated with Ephemeral cursors in the bytecode engine.
drh [Thu, 18 Mar 2021 13:19:41 +0000 (13:19 +0000)] 
New assert statements associated with Ephemeral cursors in the bytecode engine.

FossilOrigin-Name: a8ce73e2573b271d5d45838802ed1905ce5e18d5fafe0078700e79fab85457e2

4 years agoChange the name of the iDataVersion field of Btree to iBDataVersion to make
drh [Thu, 18 Mar 2021 12:36:09 +0000 (12:36 +0000)] 
Change the name of the iDataVersion field of Btree to iBDataVersion to make
it distinct from Pager.iDataVersion.

FossilOrigin-Name: e4c44c0bca317c03f8e6d3aa7cc88e5f96159a3d91c07257d408f7db028fd151

4 years agoVersion 3.35.2 union-all-flattener-limit version-3.35.2
drh [Wed, 17 Mar 2021 19:07:21 +0000 (19:07 +0000)] 
Version 3.35.2

FossilOrigin-Name: ea80f3002f4120f5dcee76e8779dfdc88e1e096c5cdd06904c20fd26d50c3827

4 years agoFix a harmless compiler warning in the appendvfs.c extension.
drh [Wed, 17 Mar 2021 19:05:59 +0000 (19:05 +0000)] 
Fix a harmless compiler warning in the appendvfs.c extension.

FossilOrigin-Name: 0ed7eb9115510511f13dca715bb2b178580648517d8d30436a992d70a2e85ac1

4 years agoIf there are already 500 or more simple SELECTs in a query, do not add more by flatte...
dan [Wed, 17 Mar 2021 14:29:37 +0000 (14:29 +0000)] 
If there are already 500 or more simple SELECTs in a query, do not add more by flattening UNION ALL sub-queries into parent join queries.

FossilOrigin-Name: 9520bed2bd87dc56543ee58123323d293e960ecd84707b77f15f41669a2c9c3d

4 years agoFix a problem in sqldiff virtual table hanlding to do with tab and other non-space...
dan [Wed, 17 Mar 2021 11:25:42 +0000 (11:25 +0000)] 
Fix a problem in sqldiff virtual table hanlding to do with tab and other non-space whitespace characters in the CREATE VIRTUAL TABLE statement.

FossilOrigin-Name: 1737e4fdfc9a3628415b234338a68a64cbbaadb23598517761e571ab7ed7ad14

4 years agoDate/time functions with no arguments (ex: date() or time()) should be
drh [Tue, 16 Mar 2021 18:41:20 +0000 (18:41 +0000)] 
Date/time functions with no arguments (ex: date() or time()) should be
non-deterministic.  Fix for ticket [2c6c8689fb5f3d2f].

FossilOrigin-Name: 1734c332e7f609769fc30f82cf7af097c2964e08900ee3e297f6a25e6df60555

4 years agoIncrease the version number to 3.35.2.
drh [Tue, 16 Mar 2021 14:43:26 +0000 (14:43 +0000)] 
Increase the version number to 3.35.2.

FossilOrigin-Name: 7a211b3f09b17b758ac43c3ed14e3f90c55459077412a57baca0f7cadff47fbf

4 years agoFix recent breakage of the appendvfs extension.
drh [Tue, 16 Mar 2021 14:26:56 +0000 (14:26 +0000)] 
Fix recent breakage of the appendvfs extension.

FossilOrigin-Name: 7dbbe5b34eea31ea54a5804035d4d0dfeb09c42cd9ab337e1e64c1296decbef3

4 years agoComment and stylistic changes to the appendvfs.c implementation. appendvfs_fix
drh [Tue, 16 Mar 2021 14:12:26 +0000 (14:12 +0000)] 
Comment and stylistic changes to the appendvfs.c implementation.

FossilOrigin-Name: 25c3186aa143328157fb506a29802e87099cd14be4fa218230484a3212f20621

4 years agoFix a problem with ALTER TABLE RENAME COLUMN when used on a schema that features...
dan [Tue, 16 Mar 2021 11:11:07 +0000 (11:11 +0000)] 
Fix a problem with ALTER TABLE RENAME COLUMN when used on a schema that features generated columns.

FossilOrigin-Name: 0e255b26872b50581d470952dd98e21dd82d081885006f58d49daa4b4576b35d

4 years agoFix assert typo.
larrybr [Tue, 16 Mar 2021 07:06:29 +0000 (07:06 +0000)] 
Fix assert typo.

FossilOrigin-Name: 3aedf818c1cfc88ee1103abd8b20e787f6be1bcc4c9350963f0cd52f5ac04154

4 years agoMerge from trunk.
larrybr [Tue, 16 Mar 2021 06:50:39 +0000 (06:50 +0000)] 
Merge from trunk.

FossilOrigin-Name: eae8236f3b9bc326648d1c8fca61cb3c38f821d06fe915fd0978cffeb1f6152b

4 years agoFix appendvfs bug exposed with bigger files, and add tests for such conditions.
larrybr [Tue, 16 Mar 2021 06:41:51 +0000 (06:41 +0000)] 
Fix appendvfs bug exposed with bigger files, and add tests for such conditions.

FossilOrigin-Name: 19b1f53a1c0a14440ae8ac71660a2595d37a4a5b201055c19366c7dca75d6660

4 years agoCreate new branch named "appendvfs_fix"
larrybr [Tue, 16 Mar 2021 04:03:59 +0000 (04:03 +0000)] 
Create new branch named "appendvfs_fix"

FossilOrigin-Name: 026edd601444d86858a503ffc3be17667a62a29f09c001009d9a678400b3b0a1

4 years agoVersion 3.35.1 version-3.35.1
drh [Mon, 15 Mar 2021 16:53:57 +0000 (16:53 +0000)] 
Version 3.35.1

FossilOrigin-Name: aea12399bf1fdc76af43499d4624c3afa17c3e6c2459b71c195804bb98def66a

4 years agoImprovements to the built-in ".dump" documentation in the CLI.
drh [Mon, 15 Mar 2021 15:12:10 +0000 (15:12 +0000)] 
Improvements to the built-in ".dump" documentation in the CLI.

FossilOrigin-Name: 0915f969f429a8d0b594e937e0128d5476774d9bbe4a24081dbc60273cb5bb9a

4 years agoBump the version number to 3.35.1.
drh [Mon, 15 Mar 2021 15:02:38 +0000 (15:02 +0000)] 
Bump the version number to 3.35.1.

FossilOrigin-Name: 184d5a352f098459cfb0cc029713d5d43fefc83f6cc95ce5666bd07591aaac2f

4 years agoImproved detection of conflicting indexes when doing DROP COLUMN on a column
drh [Mon, 15 Mar 2021 14:58:12 +0000 (14:58 +0000)] 
Improved detection of conflicting indexes when doing DROP COLUMN on a column
whose name is quoted in the index definition.
Fix for ticket [1c24a659e6d7f3a1].

FossilOrigin-Name: c450d0ad6b39db4bf93015d629e25f7af0d7a9779f7a987e2fc38a5ef064a182

4 years agoMake shell's .help output for .dump more accurate as to what can be dumped. cli-tweaks
larrybr [Mon, 15 Mar 2021 12:56:00 +0000 (12:56 +0000)] 
Make shell's .help output for .dump more accurate as to what can be dumped.

FossilOrigin-Name: f91d8c09a02f7a7ab354c49cd193d422074daa5eb908f17d1907a8c2b38f96a5

4 years agoCreate new branch named "cli-tweaks"
larrybr [Mon, 15 Mar 2021 12:32:35 +0000 (12:32 +0000)] 
Create new branch named "cli-tweaks"

FossilOrigin-Name: 4cf056a571cae6fded8136bc12f3a2787da37c6b52383cbf7b918827654ba4e7

4 years agoAn additional test case tkt-1c24a659-b
drh [Sun, 14 Mar 2021 20:17:06 +0000 (20:17 +0000)] 
An additional test case

FossilOrigin-Name: 7e2d7ca15a84e5bd9f2b1360232607d15c2dbcc9d30b0f1a7cdbf2865e6b1af5

4 years agoAn alternative approach for fixing ticket [1c24a659e6d7f3a1].
drh [Sun, 14 Mar 2021 19:55:40 +0000 (19:55 +0000)] 
An alternative approach for fixing ticket [1c24a659e6d7f3a1].

FossilOrigin-Name: a2adae907a28e169e64cfe69d97d7b68cb94e6ba07d2dfa995e3fbc6672fafdd

4 years agoUpdate generated autoconf/Makefile.msc to reflect its source.
larrybr [Fri, 12 Mar 2021 23:15:08 +0000 (23:15 +0000)] 
Update generated autoconf/Makefile.msc to reflect its source.

FossilOrigin-Name: d9f8f488ff9d47fe7bb8838e683bae4fea038f7278ef885ecf292143a0dd88ed

4 years agoVersion 3.35.0 version-3.35.0
drh [Fri, 12 Mar 2021 15:10:09 +0000 (15:10 +0000)] 
Version 3.35.0

FossilOrigin-Name: acd63062eb06748bfe9e4886639e4f2b54ea6a496a83f10716abbaba4115500b

4 years agoFix broken requirement marks.
drh [Fri, 12 Mar 2021 13:49:09 +0000 (13:49 +0000)] 
Fix broken requirement marks.

FossilOrigin-Name: 98d67152849e062c6de45b0e526daffc3d6cb29d563d40664a8d7140119a30b2

4 years agoFix the ".read" command in the CLI so that SQLITE_OMIT_POPEN disables
drh [Fri, 12 Mar 2021 01:49:08 +0000 (01:49 +0000)] 
Fix the ".read" command in the CLI so that SQLITE_OMIT_POPEN disables
reading from a pipeline.

FossilOrigin-Name: cea34f3cc35ad6dc67691799a219a30739f2296945d624d232bf76150c598ec0

4 years agoConform description of sqlite3changeset_op() arguments to implemented behavior, some...
larrybr [Fri, 12 Mar 2021 00:44:10 +0000 (00:44 +0000)] 
Conform description of sqlite3changeset_op() arguments to implemented behavior, some reformatting.
This is a comment-only change; no code is affected.

FossilOrigin-Name: 9d6e544c47b9a5d97bd02a658db5cd202bd1952f8ba3bc50e8cf47d7206041c0

4 years agoFix a Tcl object leak in test_session.c.
dan [Thu, 11 Mar 2021 15:57:25 +0000 (15:57 +0000)] 
Fix a Tcl object leak in test_session.c.

FossilOrigin-Name: 07150cf15ad36c7fc681a911f66db23d610ddf110a7be7f1fcefbd8750cd135a

4 years agoBug fix in appendvfs.c: Adjust the size parameter for
drh [Thu, 11 Mar 2021 13:43:29 +0000 (13:43 +0000)] 
Bug fix in appendvfs.c:  Adjust the size parameter for
SQLITE_FCNTL_SIZE_HINT to account for the prefix.

FossilOrigin-Name: 41df3bbefd63151f2ddb920066777eab8e07ecfc0edb0f71f9493debe0a4a2c4

4 years agoHave the Tcl tests support environment variable SQLITE_TEST_PATTERN_LIST, so that...
dan [Thu, 11 Mar 2021 08:49:52 +0000 (08:49 +0000)] 
Have the Tcl tests support environment variable SQLITE_TEST_PATTERN_LIST, so that if it is set it is interpreted as a list of patterns that are matched against tests file names. Only test files that match at least one pattern are run.

FossilOrigin-Name: b7c92e1d08f213865f026d8dbdc4e805fb5c119b7f206506ed06e83a878de657

4 years agoFix sanitizer complaint in fts3 code.
dan [Wed, 10 Mar 2021 20:04:21 +0000 (20:04 +0000)] 
Fix sanitizer complaint in fts3 code.

FossilOrigin-Name: 424b39eaeb578f85e58214af4b467e6e363431308ab7a327774e62fa70d3c2db

4 years agoFix further sanitizer complaints in the fts5 code.
dan [Wed, 10 Mar 2021 19:32:47 +0000 (19:32 +0000)] 
Fix further sanitizer complaints in the fts5 code.

FossilOrigin-Name: 4cb00b9d4020a51f690720c6f51009c5be8c22ef8c70807ead1d953d19784f26

4 years agoImproved testcase() related the SQLITE_MAX_ATTACHED vs. SQLITE_MAX_DB problem.
drh [Wed, 10 Mar 2021 18:21:18 +0000 (18:21 +0000)] 
Improved testcase() related the SQLITE_MAX_ATTACHED vs. SQLITE_MAX_DB problem.

FossilOrigin-Name: 27d3c00efef66ad48ed94228474dbea3ad81ea5c19425028c42cf4220920a645

4 years agoImprovement to the ATTACH-abuse authorizer logic in fuzzcheck.
drh [Wed, 10 Mar 2021 17:52:59 +0000 (17:52 +0000)] 
Improvement to the ATTACH-abuse authorizer logic in fuzzcheck.

FossilOrigin-Name: 88132f698a7a9b7d41dd1dd393592cbda130d2bf1a9fd18c509503e1891b9655

4 years agoDo not run avfs.test when testing SQLITE_OMIT_VIRTUALTABLE builds.
dan [Wed, 10 Mar 2021 17:43:18 +0000 (17:43 +0000)] 
Do not run avfs.test when testing SQLITE_OMIT_VIRTUALTABLE builds.

FossilOrigin-Name: 2ab6957a2238a2ab713a50d21dbd9921c944e8141197275bbfe7dae303fee7d0

4 years agoDo not confuse the constant SQLITE_MAX_ATTACHED with the maximum number of
drh [Wed, 10 Mar 2021 16:35:37 +0000 (16:35 +0000)] 
Do not confuse the constant SQLITE_MAX_ATTACHED with the maximum number of
schemas.  Add the new SQLITE_MAX_DB constant for the maximum number of
schemas.  [forum:/forumpost/a006d86f72|Forum post a006d86f72].

FossilOrigin-Name: 7b65fb9f7bd616f834633afd64b3448bf9ca2b6e4cc6d6c01e75d1d877c88a79

4 years agoFix test file avfs.test so that it works with SQLITE_DEFAULT_AUTOVACUUM builds. Do...
dan [Wed, 10 Mar 2021 15:10:20 +0000 (15:10 +0000)] 
Fix test file avfs.test so that it works with SQLITE_DEFAULT_AUTOVACUUM builds. Do not run avfs.test under test permutation "journaltest".

FossilOrigin-Name: 2c6078ebe797dd2cb6045b5f13e6d92a6b49393ecf96f9fd7222412f5a3eefd5

4 years agoFix a few sanitizer complaints in fts5.
dan [Wed, 10 Mar 2021 14:57:10 +0000 (14:57 +0000)] 
Fix a few sanitizer complaints in fts5.

FossilOrigin-Name: 4fe4fee00e9294fa384bd073ed8e9a2a4ad10dcf653b6ad4851e44a64443ede9

4 years agoFix a problem preventing wapptest from setting SQLITE_ENABLE_LOCKING_STYLE for OSX...
dan [Wed, 10 Mar 2021 10:43:17 +0000 (10:43 +0000)] 
Fix a problem preventing wapptest from setting SQLITE_ENABLE_LOCKING_STYLE for OSX tests. Also modify the "Sanitize" configuration in releasetest_data.tcl to subsume test item 6g.

FossilOrigin-Name: f762d7df2a41a88560a4251d744e0887f42812f8160af4f0129d22a71c0fa48b

4 years agoWhen shell has no .ar, fake its effect w.r.t. page_size and table creation/filling.
larrybr [Wed, 10 Mar 2021 06:06:16 +0000 (06:06 +0000)] 
When shell has no .ar, fake its effect w.r.t. page_size and table creation/filling.

FossilOrigin-Name: 959f5c65ea14f4716df61e250e9d5a0d69d602a2a973ad22a364e640162c2983

4 years agoAdd appendvfs.c to the MSVC makefile.
drh [Tue, 9 Mar 2021 23:38:27 +0000 (23:38 +0000)] 
Add appendvfs.c to the MSVC makefile.

FossilOrigin-Name: a6681fbb2e0c8d5a7c968f6fd458f61658fad6ac4c7eb8663762b6ac386cdae5

4 years agoUpdate a comment in btree.h.
dan [Tue, 9 Mar 2021 21:20:12 +0000 (21:20 +0000)] 
Update a comment in btree.h.

FossilOrigin-Name: 9645fe1a050e8b61aea1fba2f142819c387ecb043741392c5719bf7ad303bf8b

4 years agoFix a bad comment (copy-paste error) in the byte code engine. No code changes.
drh [Tue, 9 Mar 2021 20:58:21 +0000 (20:58 +0000)] 
Fix a bad comment (copy-paste error) in the byte code engine.  No code changes.

FossilOrigin-Name: 1c01745734c7b62a8c792f743aae08dfbb9e047dc92fef8da067fec152b20fd5

4 years agoImproved comments on the NOT NULL strength reduction optimization.
drh [Tue, 9 Mar 2021 19:52:15 +0000 (19:52 +0000)] 
Improved comments on the NOT NULL strength reduction optimization.

FossilOrigin-Name: a85d72293914b48edbb39171fd591d37ffb09570d8103140a052203ec71d49ee

4 years agoExtra comments and testcase() macros associated with the new
drh [Tue, 9 Mar 2021 19:32:37 +0000 (19:32 +0000)] 
Extra comments and testcase() macros associated with the new
sqlite3ParserAddCleanup() mechanism.  No changes to release builds.

FossilOrigin-Name: c3c8691121e6cb7bfc326212cc81a7472c0e6f22e655ab024bd4bd885e1cd878

4 years agoAdd --enable-math to the amalgamation autoconf. On be default. Improved
drh [Tue, 9 Mar 2021 17:09:00 +0000 (17:09 +0000)] 
Add --enable-math to the amalgamation autoconf.  On be default.  Improved
logging of the amalgamation autoconf.

FossilOrigin-Name: 85d28b52250e1817b722dc10da3b7b73abf7539cbe7aa913b5960ae4da40d5f8

4 years agoMath functions are enabled by default in the main configure script.
drh [Tue, 9 Mar 2021 16:35:14 +0000 (16:35 +0000)] 
Math functions are enabled by default in the main configure script.

FossilOrigin-Name: b7456e0715c63308b7b3acf49eb66ecd947481400d4688ae459e2e1499447bcd

4 years agoImprovements to the configure script. Math functions are enabled
drh [Tue, 9 Mar 2021 13:53:39 +0000 (13:53 +0000)] 
Improvements to the configure script.  Math functions are enabled
by --enable-all.

FossilOrigin-Name: c79c6d18dee608e54ae31388b240cc521218309094502d8815111bb4ddf7d9ef

4 years agoUpdate the authorizer in fuzzcheck to align with dbsqlfuzz.
drh [Tue, 9 Mar 2021 13:12:58 +0000 (13:12 +0000)] 
Update the authorizer in fuzzcheck to align with dbsqlfuzz.

FossilOrigin-Name: f86d8fae3b29de014d8bfcae38a15bdb15ddceabfcfff7829f3145cfd69dff2a

4 years agoAdd tests for too-tiny appended DBs, clarify align macro.
larrybr [Mon, 8 Mar 2021 20:13:43 +0000 (20:13 +0000)] 
Add tests for too-tiny appended DBs, clarify align macro.

FossilOrigin-Name: eb40a8dea6afe6890ddda989de83f3d4ae03b112bf78bfc818dfbd57cc5b5b2a

4 years agoAdd test cases for ALTER TABLE.
dan [Mon, 8 Mar 2021 17:22:01 +0000 (17:22 +0000)] 
Add test cases for ALTER TABLE.

FossilOrigin-Name: 9c9ba36e859e330c50ed40ede4b93eeb0a5c3337240465d953a7be9115a81390

4 years agoFix a bad assert in RENAME COLUMN.
drh [Mon, 8 Mar 2021 17:17:38 +0000 (17:17 +0000)] 
Fix a bad assert in RENAME COLUMN.
dbsqlfuzz 3f0a7245b69cd08617d7d7781ebaedb0fe765a93.

FossilOrigin-Name: f13e0d12f137cd6b4e83e92bd36652431d8416e6eed4797313e061f2e390d39b

4 years agoFix a harmless compiler warning in appendvfs.c
drh [Mon, 8 Mar 2021 16:29:06 +0000 (16:29 +0000)] 
Fix a harmless compiler warning in appendvfs.c

FossilOrigin-Name: f538961a8058cc327d64c8ec317f1b4f8bbb604f90261160c6c27f26f4800682

4 years agoEnable internal functions for fuzzcheck.
drh [Mon, 8 Mar 2021 16:13:52 +0000 (16:13 +0000)] 
Enable internal functions for fuzzcheck.

FossilOrigin-Name: 79281603b951b438303130820deb6b05baeca366c2cd93be7d8909d3232bcc96

4 years agoAdded test/avfs.test (missing from branch merge for some reason.)
larrybr [Mon, 8 Mar 2021 14:32:26 +0000 (14:32 +0000)] 
Added test/avfs.test (missing from branch merge for some reason.)

FossilOrigin-Name: 08fa67053c20d223c9b5334fe2e85adc95588b91046c100d7fe8e8e2535e485f

4 years agoMerge appendvfs updates and testing.
larrybr [Mon, 8 Mar 2021 14:26:22 +0000 (14:26 +0000)] 
Merge appendvfs updates and testing.

FossilOrigin-Name: 63fcf301fedf1f3708e2226ed499a53b3e9c1d2cc2b17d4b0b736e36aff0ae74

4 years agoRequire that the appendvfs suffix mark indicate that the appended database appendvfs_tighten
drh [Mon, 8 Mar 2021 13:45:08 +0000 (13:45 +0000)] 
Require that the appendvfs suffix mark indicate that the appended database
begins at an offset that is a muliple of 512 and that the appended database
contains at least 512 bytes.

FossilOrigin-Name: aeb87cc70495dd172e170eff31fd754331d4b979c0b649ab239f8c5c0c76e695

4 years agoCorrect the precendence order for rules that determine how a database is
drh [Mon, 8 Mar 2021 13:30:29 +0000 (13:30 +0000)] 
Correct the precendence order for rules that determine how a database is
opened by appendvfs when a database is appended to another database.

FossilOrigin-Name: 92989fc56f2e81ac13f8106ec83c930f43d10715269b988ee47c9bfa53621995

4 years agoMinor comment and formatting changes.
drh [Mon, 8 Mar 2021 12:59:16 +0000 (12:59 +0000)] 
Minor comment and formatting changes.

FossilOrigin-Name: cf2add064f70c477fee1473c3196b72deb41222eb0cdbbdbdcf4a79995184e2b

4 years agoAdd tests for sqlite3 shell with -append flag.
larrybr [Mon, 8 Mar 2021 01:31:53 +0000 (01:31 +0000)] 
Add tests for sqlite3 shell with -append flag.

FossilOrigin-Name: d1790288729441d53603709df02aa5fb5f04714e2da86ce128ca81840b0b545f

4 years agoAdd grow/shrink tests. Fix truncate bug. Make appendvfs.c easier to inspect.
larrybr [Sun, 7 Mar 2021 18:55:25 +0000 (18:55 +0000)] 
Add grow/shrink tests. Fix truncate bug. Make appendvfs.c easier to inspect.

FossilOrigin-Name: c9521fa55620d0cb3cec20db7b42bc5f18876b42dca07811d1cd0f4b2907eab2

4 years agoMerge from trunk.
larrybr [Sat, 6 Mar 2021 23:49:18 +0000 (23:49 +0000)] 
Merge from trunk.

FossilOrigin-Name: 729117cdfa2d6ff24b66656e9ccc380199606b830fc338286e4dd10e8e787597

4 years agoCreate initial tests for appendvfs, and make it available as a statically loaded...
larrybr [Sat, 6 Mar 2021 23:36:47 +0000 (23:36 +0000)] 
Create initial tests for appendvfs, and make it available as a statically loaded extension.

FossilOrigin-Name: 9f33d45179f5985bd4c4f7582e94f5833a63f853c8cdc19f39cf7e3ee70177d0

4 years agoLimit parenthesis nesting depth in FTS3 expressions to
drh [Sat, 6 Mar 2021 15:13:26 +0000 (15:13 +0000)] 
Limit parenthesis nesting depth in FTS3 expressions to
SQLITE_MAX_EXPR_DEPTH.

FossilOrigin-Name: 5ddd8032ef9ecd5b53909d304c8f1375a72f270fd7810964cb4e385e25bedd4f

4 years agoEnsure the correct collation sequence is used for comparisons when delimiting a RANGE...
dan [Sat, 6 Mar 2021 14:46:24 +0000 (14:46 +0000)] 
Ensure the correct collation sequence is used for comparisons when delimiting a RANGE window.

FossilOrigin-Name: 01eae68e85b31b7a9f08733459765bbd9bf9dad592bf64f10fc2fa32e02a89c2

4 years agoFix a crash in fts3 that could occur when running a NEAR query on a corrupt database.
dan [Sat, 6 Mar 2021 13:28:07 +0000 (13:28 +0000)] 
Fix a crash in fts3 that could occur when running a NEAR query on a corrupt database.

FossilOrigin-Name: 609d94996324f3d3c12bb8cc04a2527d1d86c35cdb2267b5b34053c961158986

4 years agoFix a possible NULL pointer dereference when applying a DROP COLUMN to a
drh [Sat, 6 Mar 2021 13:02:12 +0000 (13:02 +0000)] 
Fix a possible NULL pointer dereference when applying a DROP COLUMN to a
corrupt database schema.  dbsqlfuzz 419aa525df93db6e463772c686ac6da27b46da9e

FossilOrigin-Name: 349ccf58ae4bb770805066102fc8e9e478d4da1f7a6a728223bd74eabf7b7843

4 years agoMerge last day of trunk changes, reverify build.
larrybr [Fri, 5 Mar 2021 20:52:19 +0000 (20:52 +0000)] 
Merge last day of trunk changes, reverify build.

FossilOrigin-Name: 1d67ed1c98a6bc49cce6bdc156bd6f22b3f37d33226bd62430a43aa5318f5781

4 years agoFix appendvfs bug exposed by docsapp build (in docsrc), and tighten/revise published...
larrybr [Fri, 5 Mar 2021 20:46:53 +0000 (20:46 +0000)] 
Fix appendvfs bug exposed by docsapp build (in docsrc), and tighten/revise published behavior.

FossilOrigin-Name: 7f0f2eacdb496f7f36865ba62164a48edb324a3c6baede736b4e7edf5e8b0fdb

4 years agoModify the SQLITE_DBCONFIG_ENABLE_VIEW option so that it always permits
drh [Fri, 5 Mar 2021 18:33:01 +0000 (18:33 +0000)] 
Modify the SQLITE_DBCONFIG_ENABLE_VIEW option so that it always permits
TEMP views, just as SQLITE_DBCONFIG_ENABLE_TRIGGER always permits TEMP
triggers.

FossilOrigin-Name: 83dab8b358b6832a221a58e74dd5e99b9cdea4eee65124bb6799881e867d989c

4 years agoFix problems with RETURNING clauses attached to UPDATEs on tables with virtual columns.
dan [Fri, 5 Mar 2021 15:42:15 +0000 (15:42 +0000)] 
Fix problems with RETURNING clauses attached to UPDATEs on tables with virtual columns.

FossilOrigin-Name: 6b41b136fbfc0b56a6948f2306b69fb1d69306adb86674a15a87fe3b52062512