]> git.ipfire.org Git - thirdparty/sqlite.git/log
thirdparty/sqlite.git
3 years agoWhen building fiddle from its own directory (e.g. from emacs instead of the normal... fiddle
stephan [Thu, 19 May 2022 16:49:15 +0000 (16:49 +0000)] 
When building fiddle from its own directory (e.g. from emacs instead of the normal build process), force -O0 the sake of compilation speed. The top-level build now defaults to -Oz, which is more appropriate for that case.

FossilOrigin-Name: 56b82ae806c61b95e62042ca70ed952ce01832b02da55c2b315f9201989514ab

3 years agoTweaks to the fiddle make target so that it builds with all of the same
drh [Thu, 19 May 2022 16:42:41 +0000 (16:42 +0000)] 
Tweaks to the fiddle make target so that it builds with all of the same
extensions as the standard CLI.

FossilOrigin-Name: d46a6cb97406d90b9ad1da66369454e9b8f387ffbebcdf1c386c3c21f790c16f

3 years agoAdded a toggle to swap input/output field positions and simplified setup of checkboxe...
stephan [Thu, 19 May 2022 16:30:03 +0000 (16:30 +0000)] 
Added a toggle to swap input/output field positions and simplified setup of checkboxes which toggle a CSS class on a given element.

FossilOrigin-Name: eae3ab10c813d6f051d497271be2df05f54005ec54b19a2a27d04d632bccbeac

3 years agoDefault to top/bottom layout with input on the bottom. Offer a toggle to swap input...
stephan [Thu, 19 May 2022 16:11:35 +0000 (16:11 +0000)] 
Default to top/bottom layout with input on the bottom. Offer a toggle to swap input/output positions.

FossilOrigin-Name: 362d236aca31ca2004d1e81d8e306f7a12a6cb4eeb2bab432a9c2aae5206ddd7

3 years agoNumerous layout tweaks, the most significant being that the layout now adapts to...
stephan [Thu, 19 May 2022 15:58:13 +0000 (15:58 +0000)] 
Numerous layout tweaks, the most significant being that the layout now adapts to the window size. Swapped positions of the input/output areas. This version supports, by uncommenting a few bits, a jquery.terminal-based view but alternatives to that 300kb dependency are still under investigation.

FossilOrigin-Name: 1aad3642c9fc14c25223628a309d84decc8d73a123e42d6efdc36d855b5b0666

3 years agofiddle make target now accepts fiddle_cflags=... from the CLI to overrid -Ox and...
stephan [Thu, 19 May 2022 10:58:59 +0000 (10:58 +0000)] 
fiddle make target now accepts fiddle_cflags=... from the CLI to overrid -Ox and such for one-off builds.

FossilOrigin-Name: 4609a4f8626ae3d8179cae27e391bd06ffda18e9ef9e1b78745b36c7e8dd25db

3 years agoEnsure that the output area is cleared of any init-time messages which the emscripten...
stephan [Thu, 19 May 2022 10:38:54 +0000 (10:38 +0000)] 
Ensure that the output area is cleared of any init-time messages which the emscripten bootstrapping process emits when downloading of the wasm module is slow.

FossilOrigin-Name: 1d8d0593573f9fc8e0990a292a4b3317d8a4c323d60514d0768543dd65c24d1e

3 years ago#if'd out the '.log' command in WASM builds. Cleaned up the user-visible parts of...
stephan [Thu, 19 May 2022 10:24:50 +0000 (10:24 +0000)] 
#if'd out the '.log' command in WASM builds. Cleaned up the user-visible parts of the WASM module initialization.

FossilOrigin-Name: b5fa12f824690c1022e4d69b0f5c3949324b311557a7412810741731db7e2cce

3 years agoSplit the fiddle JS code into separate pre-/post-init files to simplify editing....
stephan [Thu, 19 May 2022 09:55:14 +0000 (09:55 +0000)] 
Split the fiddle JS code into separate pre-/post-init files to simplify editing. emcc will combine these into the final fiddle.js, so the number of output deliverables does not change.

FossilOrigin-Name: d3d8ea011868bcfa11bb3fe2db78eea6e77ac1005534d9c091f9a81e03f0a7e6

3 years agoAdded an option to auto-clear the output area before submitting the input. Experiment...
stephan [Thu, 19 May 2022 09:22:16 +0000 (09:22 +0000)] 
Added an option to auto-clear the output area before submitting the input. Experimentally inverted the colors in the input/output areas.

FossilOrigin-Name: 1a1e4e7fdbd0ec61218c3a311164086316d825181f3fc1c1ec235b63488746ef

3 years agoReplaced the toggle for the notes/caveats section of the fiddle UI with a button...
stephan [Thu, 19 May 2022 01:12:23 +0000 (01:12 +0000)] 
Replaced the toggle for the notes/caveats section of the fiddle UI with a button to remove that section.

FossilOrigin-Name: 6661d60527820417bbfd01c782d242c5190252ea703fc6f56376537d5c8f6a1e

3 years ago#if'd out the '.import' command in WASM builds. Several minor cosmetic UI tweaks.
stephan [Thu, 19 May 2022 00:38:34 +0000 (00:38 +0000)] 
#if'd out the '.import' command in WASM builds. Several minor cosmetic UI tweaks.

FossilOrigin-Name: e4f87eb7c3ed16b7e431f86b7d337bb4097246d20780207b43e28fffda3d8a61

3 years ago#if out the '.load' command in WASM builds. Several UI layout tweaks.
stephan [Wed, 18 May 2022 23:40:27 +0000 (23:40 +0000)] 
#if out the '.load' command in WASM builds. Several UI layout tweaks.

FossilOrigin-Name: 67d98297f01d4274c510f5c5cb2a219aeb36fcbb7ce78b8b9ed65639a4561c73

3 years agoIn wasm builds, ifdef out shell commands which require file I/O, pipes, or which...
stephan [Wed, 18 May 2022 22:58:34 +0000 (22:58 +0000)] 
In wasm builds, ifdef out shell commands which require file I/O, pipes, or which trigger an exit() (.quit and .exit). Documented some of the quirks and limitations of the C/WASM crossover. Keep the JS code from calling into the C code after an exit() has been triggered.

FossilOrigin-Name: bee436e62a956e49b0df4a92abff2c89f2b44e21d8f593716df0331f8fc49814

3 years agoImproved handling/reporting of conditions which trigger an exit() from native code...
stephan [Wed, 18 May 2022 21:18:21 +0000 (21:18 +0000)] 
Improved handling/reporting of conditions which trigger an exit() from native code, e.g. calling the '.read' command. Added a Help button which simply submits the '.help' command. Added commented-out variants of various -Ox flags to simplify experimenting with them.

FossilOrigin-Name: bf06ddf4125d2726019fa16d312726c8551094be991509499b5688f6a68a7747

3 years agoCode style fixes: s/char const/const char/.
stephan [Wed, 18 May 2022 18:10:17 +0000 (18:10 +0000)] 
Code style fixes: s/char const/const char/.

FossilOrigin-Name: 9bf042b2eb2137239a59e421e89eb463e719b264eac3db2adae44e321b9a4ad3

3 years agoThe fiddle input/output areas now stretch and shrink as needed to account for their...
stephan [Wed, 18 May 2022 17:40:19 +0000 (17:40 +0000)] 
The fiddle input/output areas now stretch and shrink as needed to account for their available space.

FossilOrigin-Name: 4eec05457fabe8248b8fd48d6187e772b69429ed64e99f02d0ad6b1230b5835e

3 years agoIncreased default size of the fiddle output area, changed the .nullvalue default...
stephan [Wed, 18 May 2022 17:22:02 +0000 (17:22 +0000)] 
Increased default size of the fiddle output area, changed the .nullvalue default in the input area, and minor CSS tweaks.

FossilOrigin-Name: 281aaae73167828bdf0bb2c07f83622475ab29b5755ac7fb8584c8e919c0a09b

3 years agoInitial version of an sqlfiddle-style application using a WASM build of the sqlite3...
stephan [Wed, 18 May 2022 17:14:24 +0000 (17:14 +0000)] 
Initial version of an sqlfiddle-style application using a WASM build of the sqlite3 shell.

FossilOrigin-Name: af9c21c9e0caf05adac7a9fcde39a9164c89f1c78b767b6fdd74a1405a3d373f

3 years agoFix harmless compiler warnings in the new unixFullPathname implementation.
drh [Tue, 17 May 2022 15:11:57 +0000 (15:11 +0000)] 
Fix harmless compiler warnings in the new unixFullPathname implementation.

FossilOrigin-Name: f7e1ceb5b59a876cfd04a8aac0ee2b322c970555b9c361b4953d711ef6596e37

3 years agoAvoid treating constant expressions like "? IN ()" or "? NOT IN ()" as integers if...
dan [Tue, 17 May 2022 15:01:01 +0000 (15:01 +0000)] 
Avoid treating constant expressions like "? IN ()" or "? NOT IN ()" as integers if they appear in a GROUP BY or ORDER BY clause.

FossilOrigin-Name: d8b249e8cdf0babe1427d0587dbdc27a52ec06a5ef3a20dfb05a0ea4adb85858

3 years agoAdd the sqlite3_db_name() interface.
drh [Tue, 17 May 2022 14:59:05 +0000 (14:59 +0000)] 
Add the sqlite3_db_name() interface.

FossilOrigin-Name: 2ad152236c408cbb1f942b221de4bf3cbaa9c35313d7eb07a63f46b6040fc981

3 years agoAdd memory barriers to multi-threaded code in test4.c.
dan [Mon, 16 May 2022 16:55:22 +0000 (16:55 +0000)] 
Add memory barriers to multi-threaded code in test4.c.

FossilOrigin-Name: 9260f4e0fdc8066b4772999bacb5f4130ef714d4ac1967029ceacff618bc48ff

3 years agoFix a problem in test file swarmvtab3.test causing occasional failures.
dan [Mon, 16 May 2022 16:10:04 +0000 (16:10 +0000)] 
Fix a problem in test file swarmvtab3.test causing occasional failures.

FossilOrigin-Name: f935c155ef205802c16b4ebea4a3fb01bf5689662b7b4f2af56f0f9021d6d4b1

3 years agoDo not allow an index scan on an index-on-expression for a RIGHT JOIN because
drh [Sat, 14 May 2022 19:05:13 +0000 (19:05 +0000)] 
Do not allow an index scan on an index-on-expression for a RIGHT JOIN because
the index might not be positioned on the correct row when running the
the right-join no-match loop.
dbsqlfuzz 39ee60004ff027a9e2846cf76e02cd5ac0953739

FossilOrigin-Name: 2277f9ba7087dd993ac0f4007c523aa9cf74dba187f53af03d8c164886726fee

3 years agoImproved debugging comment generation for the OP_Column opcode.
drh [Sat, 14 May 2022 17:40:47 +0000 (17:40 +0000)] 
Improved debugging comment generation for the OP_Column opcode.

FossilOrigin-Name: 3e073bfddfcd652dfae8656d8978a4de427d21847fdaccfce53b6b895ad33f01

3 years agoImprovements to the decision of when to check ON constraints for an inner
drh [Sat, 14 May 2022 15:59:42 +0000 (15:59 +0000)] 
Improvements to the decision of when to check ON constraints for an inner
join that is an operand to a RIGHT JOIN.  Fix for issue identify by
[forum:/forumpost/c06b10ad7e|forum post c06b10ad7e].

FossilOrigin-Name: 9d17233c7d98bf25c1a518d067e778708b3db6d6302edd8d7e376ba0ba4f1c30

3 years agoChange an unreachable branch into an assert().
drh [Fri, 13 May 2022 23:01:28 +0000 (23:01 +0000)] 
Change an unreachable branch into an assert().

FossilOrigin-Name: 778e57a558dc3f819ca57623bcb85f58c8fbeb28bc12a1e2edbdd1244e9107c5

3 years agoTransitive equality constriants do not work on a RIGHT JOIN, since the
drh [Fri, 13 May 2022 20:11:32 +0000 (20:11 +0000)] 
Transitive equality constriants do not work on a RIGHT JOIN, since the
right-hand side might be a non-matched row.

FossilOrigin-Name: 0f96810b840dd6f209562635b21f55a7ed6210c01336fcfeb3b79e08a615a28d

3 years agoWalk back the optimization from check-in [cc458317bd77046c] that tries to
drh [Fri, 13 May 2022 19:50:29 +0000 (19:50 +0000)] 
Walk back the optimization from check-in [cc458317bd77046c] that tries to
reuse the same ephemeral cursor of a list subquery when that subquery is
reused, as it does not work in cases where the list subquery is used both
for lookups and for scans.

FossilOrigin-Name: 12ee29d632ae4b585ef6bc07d3289d00c121268945dffd5673b251d95874e3f8

3 years agoDefer generating WHERE clause constraints for a RIGHT JOIN until after the
drh [Fri, 13 May 2022 17:45:52 +0000 (17:45 +0000)] 
Defer generating WHERE clause constraints for a RIGHT JOIN until after the
ON-clause processing for the RIGHT JOIN has done its own row elimination.
This fixes and incorrect output from some RIGHT JOINs that was identified
by [forum:/forumpost/41cc3851d864c5e6|forum post 41cc3851d864c5e6].

FossilOrigin-Name: 238d9c247cf69cc77fdb1af9d42ebe258610a533ac4204e2ddf8af17f24d18c4

3 years agoRedefine the acccess rules for the Expr.w union so that the Expr.w.iJoin
drh [Fri, 13 May 2022 16:38:40 +0000 (16:38 +0000)] 
Redefine the acccess rules for the Expr.w union so that the Expr.w.iJoin
member is accessible on either EP_OuterON or EP_InnerON.

FossilOrigin-Name: 6f741d6cfb8831a3ac966257ac4519bcc8156293447bf50323c2d9b170125974

3 years agoCorrections to the header comment to the new joinE.test script. Add the
drh [Fri, 13 May 2022 15:36:47 +0000 (15:36 +0000)] 
Corrections to the header comment to the new joinE.test script.  Add the
generator TCL as a comment at the bottom of the script.

FossilOrigin-Name: 2f4456f67f64f131fc852ad9a7420eb43b57b879a9bec7e4b295f1dc0d7bfa56

3 years agoNew test cases for outer joins. Case joinE-32 currently gets an incorrect
drh [Fri, 13 May 2022 15:31:30 +0000 (15:31 +0000)] 
New test cases for outer joins.  Case joinE-32 currently gets an incorrect
answer.  See [forum:/forumpost/41cc3851d8|forum post 41cc3851d8] for the bug
report.

FossilOrigin-Name: 02b24863e6dc617c9260f79292a96b7c861d088268e77fd17204570515eb792c

3 years agoImproved names for flags on the Expr object: EP_FromJoin becames
drh [Fri, 13 May 2022 14:52:04 +0000 (14:52 +0000)] 
Improved names for flags on the Expr object:  EP_FromJoin becames
EP_OuterON and EP_InnerJoin becomes EP_InnerON.

FossilOrigin-Name: 1ffea07ff98b894729c698b681cc7433df3bbfccd8a0529a706908602a636937

3 years agoFix a harmless compiler warning in the CLI.
drh [Thu, 12 May 2022 17:09:33 +0000 (17:09 +0000)] 
Fix a harmless compiler warning in the CLI.

FossilOrigin-Name: 7a2ac303d1436a423a635db63d195097c88160ff46855194f6e630f9d3b3fa82

3 years agoEnsure that ON clauses are applied to the correct outer join.
drh [Thu, 12 May 2022 11:56:44 +0000 (11:56 +0000)] 
Ensure that ON clauses are applied to the correct outer join.

FossilOrigin-Name: c7e3a13a3288c577209be99c630fbe924e19880e8af1aa8a83b517acaa8b43d7

3 years agoAdd IS NOT DISTINCT FROM and IS DISTINCT FROM binary operators which are
drh [Thu, 12 May 2022 11:45:20 +0000 (11:45 +0000)] 
Add IS NOT DISTINCT FROM and IS DISTINCT FROM binary operators which are
equivalent to IS and IS NOT, respectively, for compatability with PostgreSQL
and hence standard SQL.

FossilOrigin-Name: db27611e172102483eaede3981d473e3d5bf93d98bc68f480398b1573876349d

3 years agoFix the ".echo" command of the CLI so that it shows the results of input
drh [Thu, 12 May 2022 11:01:41 +0000 (11:01 +0000)] 
Fix the ".echo" command of the CLI so that it shows the results of input
lines immediately, before invoking sqlite3_prepare().

FossilOrigin-Name: cf7fdabdba3a7600ea730263ca80ba80154645dfa15c31c037b780d6cb70e530

3 years agoZap stray --help output from intermediate version. echo-sql
larrybr [Wed, 11 May 2022 20:29:32 +0000 (20:29 +0000)] 
Zap stray --help output from intermediate version.

FossilOrigin-Name: deb7372b18cc8fb9d305085498fd24b3c2c17bd920ae2d03fa885af02ad47008

3 years agoChange .echo on effect so that SQL is echoed before prepare. This slightly alters...
larrybr [Wed, 11 May 2022 19:59:31 +0000 (19:59 +0000)] 
Change .echo on effect so that SQL is echoed before prepare. This slightly alters echoed output when multiple SQL statements are submitted at once. Also sync with trunk.

FossilOrigin-Name: c1eff632c41809214edea2850a93852fff66da3ca0dc393e8fe55e0976d422fd

3 years agoThe unix interface now resolves all symbolic links in filenames before
drh [Wed, 11 May 2022 17:57:43 +0000 (17:57 +0000)] 
The unix interface now resolves all symbolic links in filenames before
actually using those filenames.

FossilOrigin-Name: d55273e36e312336b8fc77dc771657d3b2c3437fbbd79f3be37701982560d634

3 years agoUse osReadlink() in os_unix.c, not readlink() directly. resolve-symlinks
drh [Wed, 11 May 2022 17:45:50 +0000 (17:45 +0000)] 
Use osReadlink() in os_unix.c, not readlink() directly.

FossilOrigin-Name: c3da4c1611cebd9f9d695892a3ffddc47d5f0db1a1ea8bd2b4f83ef7673b68de

3 years agoFor the unix VFS, rewrite the xFullPathname method so that it automatically
drh [Wed, 11 May 2022 16:46:27 +0000 (16:46 +0000)] 
For the unix VFS, rewrite the xFullPathname method so that it automatically
resolves all symbolic links, rendering a canonical pathname that contains
no symlinks.

FossilOrigin-Name: 40c9273d0e0e74e1df22e996a5d486e838f4320defd2121e2d95eeed8aea6235

3 years agoFix .import leak in CLI and add shell leak testing to debug builds and the Tcl test...
larrybr [Wed, 11 May 2022 03:42:38 +0000 (03:42 +0000)] 
Fix .import leak in CLI and add shell leak testing to debug builds and the Tcl test suite.

FossilOrigin-Name: df842ebc796a2b0c913d19d873e88d048808dc5283465271369e302a680317e4

3 years agoSync w/ trunk import-leak-plug
larrybr [Wed, 11 May 2022 03:29:52 +0000 (03:29 +0000)] 
Sync w/ trunk

FossilOrigin-Name: 1284225b0a8c7b630416be5348e99f7280f6443548ec97ffb1c85be23352b2bc

3 years agoFix a bug in the sqlite3WhereMalloc() routines that were added by
drh [Tue, 10 May 2022 23:28:12 +0000 (23:28 +0000)] 
Fix a bug in the sqlite3WhereMalloc() routines that were added by
chekc-in [f237e1d8cc41b937].  The bug was detected by dbsqlfuzz
test case 4c5e3e89bc251d28378be88233f531b84ec66901.

FossilOrigin-Name: 764b71267e0b31ff7eaf2a0def7526a1a02dce4d5b456dea060d97ed342efdd1

3 years agoMake tester.tcl work on more Windows Tcl installations. And sync w/ trunk.
larrybr [Tue, 10 May 2022 22:32:27 +0000 (22:32 +0000)] 
Make tester.tcl work on more Windows Tcl installations. And sync w/ trunk.

FossilOrigin-Name: d25fbdf8772f1c8283828424b208fc1758c82e9e28e0e52122c87db4af1c672d

3 years agoNew requirement marks.
drh [Tue, 10 May 2022 18:43:54 +0000 (18:43 +0000)] 
New requirement marks.

FossilOrigin-Name: e8479e56c615a6eb38b58e6d360bea8528ec14a9d7b0798b95d3eb513bd08f0f

3 years agoFix a stale requirement mark.
drh [Tue, 10 May 2022 18:18:45 +0000 (18:18 +0000)] 
Fix a stale requirement mark.

FossilOrigin-Name: fcda7fb1f184a31a67572aae15f3cdcd60f8aac199106a7b0f90aca251ca7017

3 years agoFix a stale requirement mark.
drh [Tue, 10 May 2022 17:42:55 +0000 (17:42 +0000)] 
Fix a stale requirement mark.

FossilOrigin-Name: 3eda4030f73384abf18b97cd8a4606e10b23e382d1b72dff7526aebfde23e0af

3 years agoFix a harmless UBSAN warning.
drh [Tue, 10 May 2022 15:55:10 +0000 (15:55 +0000)] 
Fix a harmless UBSAN warning.

FossilOrigin-Name: 8f9355028bc7baeeb10ee9a5e29f093adac6c2f149596dec0be827be4ce491cb

3 years agoSync w/ trunk
larrybr [Tue, 10 May 2022 14:57:38 +0000 (14:57 +0000)] 
Sync w/ trunk

FossilOrigin-Name: b7285f92bb9bfd8471e51ee5b6dbd7030b1f731683876e8ecca4a8c033688736

3 years agoFor CLI, add ".echo sql" dot-command.
larrybr [Tue, 10 May 2022 14:55:45 +0000 (14:55 +0000)] 
For CLI, add ".echo sql" dot-command.

FossilOrigin-Name: 35cef458ca114649ee16e00714d817d57673b96c007454946cc411ae90fd06ce

3 years agoSync w/trunk
larrybr [Tue, 10 May 2022 06:04:48 +0000 (06:04 +0000)] 
Sync w/trunk

FossilOrigin-Name: 536691ed0f76ac37f3d86e4f5b1cff15ce4c011f84cd3452b5b45bafb6bf2522

3 years agoCause most shell tests to be run under Tcl suite valgrind config.
larrybr [Tue, 10 May 2022 01:11:51 +0000 (01:11 +0000)] 
Cause most shell tests to be run under Tcl suite valgrind config.

FossilOrigin-Name: cd085b36ff777396ac2705c030c1518f8094a70a0b0ba4a628776429524d20f0

3 years agoSimplified "hidden" and "no-expand" handling in the *-expander.
drh [Tue, 10 May 2022 00:24:01 +0000 (00:24 +0000)] 
Simplified "hidden" and "no-expand" handling in the *-expander.

FossilOrigin-Name: c6c3115f3a008cf9b0d7c5c812f17e38c8a75a904032c5f05f0bea03a7340527

3 years agoCreate new branch named "echo-sql"
larrybr [Mon, 9 May 2022 18:33:14 +0000 (18:33 +0000)] 
Create new branch named "echo-sql"

FossilOrigin-Name: 042f2935c9d07668eff6ad8a071c82aa12ccbf9a783dff7b74ddd6b4c82cf573

3 years agoMinor STAT4 test case change due to the ANALYZE enhancement of
drh [Mon, 9 May 2022 17:55:34 +0000 (17:55 +0000)] 
Minor STAT4 test case change due to the ANALYZE enhancement of
[eb59c46a5aed69bc|check-in eb59c46a5aed69bc].

FossilOrigin-Name: 8ce2fecb580da53fc01c53d8de10e2cc99499094215429ba925e777717e369b2

3 years agoAdd ALWAYS() on two unreachable branches in the * expander.
drh [Mon, 9 May 2022 16:29:53 +0000 (16:29 +0000)] 
Add ALWAYS() on two unreachable branches in the * expander.

FossilOrigin-Name: 387c852375bba62df040330944c9e979a6993f95ece3443597c5fc66e34263ca

3 years agoSimplify a branch in the "*" expansion logic. New test case for an
drh [Mon, 9 May 2022 12:59:16 +0000 (12:59 +0000)] 
Simplify a branch in the "*" expansion logic.  New test case for an
INSTEAD OF trigger on a RIGHT and FULL outer join.

FossilOrigin-Name: d2717348f43b571c7bb58498e0c723331abf85de174189e66aca2c438ca26d5f

3 years agoSimplify .import leak plug and arrange for CLI to be run under valgrind.
larrybr [Mon, 9 May 2022 12:29:47 +0000 (12:29 +0000)] 
Simplify .import leak plug and arrange for CLI to be run under valgrind.

FossilOrigin-Name: 0d3e2380197aa3e725591266acaeb0d43a7e794ca9153e6c56253cdcf60720b1

3 years agoStop a memory leak in .import, and add leak complaint to CLI debug builds.
larrybr [Sat, 7 May 2022 03:53:14 +0000 (03:53 +0000)] 
Stop a memory leak in .import, and add leak complaint to CLI debug builds.

FossilOrigin-Name: f5f09368b33b6af00f96e5b8f763e7ee2d00ba6af2aee0f2ca86bb58c03d0b71

3 years agoCreate new branch named "import-leak-plug"
larrybr [Sat, 7 May 2022 02:21:17 +0000 (02:21 +0000)] 
Create new branch named "import-leak-plug"

FossilOrigin-Name: 4a4cecab23ef2aab20b1db466d045d56921590eb67563ab5a31f7b0a0f75c533

3 years agoPerserve the requested reserved-bytes size for the database file when
drh [Fri, 6 May 2022 22:29:45 +0000 (22:29 +0000)] 
Perserve the requested reserved-bytes size for the database file when
doing a VACUUM.

FossilOrigin-Name: dac6d87c71606f3ec7ce601be6d17357d323476ecb60dbb167030146783b62b2

3 years agoPrevent an infinite loop on SQLITE_ERROR_RETRY when trying to modify a
drh [Fri, 6 May 2022 00:43:06 +0000 (00:43 +0000)] 
Prevent an infinite loop on SQLITE_ERROR_RETRY when trying to modify a
corrupt schema while PRAGMA writeable_schema=ON is active.
dbsqlfuzz ded83609f475cc989c7339d45efb5151c1495501

FossilOrigin-Name: 217b33234dc3dc36b5b6add50c170869421057a56a7576d1a61767956248d5c9

3 years agoBackout check-in [9fb20a21feb8f697] which was incorrect.
drh [Thu, 5 May 2022 10:02:19 +0000 (10:02 +0000)] 
Backout check-in [9fb20a21feb8f697] which was incorrect.

FossilOrigin-Name: 99225618a83b577efbd5d13c0d1ff73e9c5a71bb43c259d7c0f22cf3479c992f

3 years agoImprovements for name resolution for parenthsized joins.
drh [Wed, 4 May 2022 18:43:39 +0000 (18:43 +0000)] 
Improvements for name resolution for parenthsized joins.

FossilOrigin-Name: 006b2d9c52201c9e836b649018519acfb47f793f70b968722440f00084e9d846

3 years agoNew test cases for RIGHT and FULL JOIN, focusing on cases that make use
drh [Wed, 4 May 2022 17:43:59 +0000 (17:43 +0000)] 
New test cases for RIGHT and FULL JOIN, focusing on cases that make use
of Bloom filters, and a bug fix related to when ON-clause constraints are
applied.

FossilOrigin-Name: 67510354e69bab98bd8095f5bedd34aae619fe2c7885975d7a6a00b7df5ece4e

3 years agoCode EP_InnerJoin constraints at the same time that EP_FromJoin constraints joinD
drh [Wed, 4 May 2022 17:30:51 +0000 (17:30 +0000)] 
Code EP_InnerJoin constraints at the same time that EP_FromJoin constraints
are coded.

FossilOrigin-Name: b57033d2af2196e2f7e5305f3504fc20da5cadeb66026d38b999fe909cab8ac5

3 years agoMerge ON-clause constraint usage fix from trunk into the joinD branch.
drh [Wed, 4 May 2022 14:46:08 +0000 (14:46 +0000)] 
Merge ON-clause constraint usage fix from trunk into the joinD branch.

FossilOrigin-Name: 0a20d4a85964fb5f2060b9522356ad2711f41d0d526ba3d2e58fc51029878298

3 years agoFix ON-clause constraint usage for FULL and RIGHT JOINs.
drh [Wed, 4 May 2022 14:45:19 +0000 (14:45 +0000)] 
Fix ON-clause constraint usage for FULL and RIGHT JOINs.

FossilOrigin-Name: 544268a723cafdf0460221f5f018e752836436bad0fac90852cec70e63d9dcde

3 years agoNew test cases using various join types and Bloom filters. Two cases
drh [Wed, 4 May 2022 11:49:26 +0000 (11:49 +0000)] 
New test cases using various join types and Bloom filters.  Two cases
differ from PG and need to be resolved.

FossilOrigin-Name: befa8cbc0682bc3269f87e392a1f3d4baacf4db7c716ea84192bb9c13c99490b

3 years agoFix CLI use of wrong allocator for free().
larrybr [Wed, 4 May 2022 03:45:32 +0000 (03:45 +0000)] 
Fix CLI use of wrong allocator for free().

FossilOrigin-Name: 9fb20a21feb8f6979812f45691e06aa3e297d7370cf0d5820523e817a4e97863

3 years agoIn the query planner, do not let tables commute across any outer join.
drh [Wed, 4 May 2022 02:01:49 +0000 (02:01 +0000)] 
In the query planner, do not let tables commute across any outer join.

FossilOrigin-Name: 8cee5388232ade91ea627bb6857eb8937d7530b5ea519e0ae6da362c37c7ed35

3 years agoTypos cleared from README.md
larrybr [Tue, 3 May 2022 21:58:24 +0000 (21:58 +0000)] 
Typos cleared from README.md

FossilOrigin-Name: be3a1879c865cff85d8b1f0cc7b95295019c28cce67c687692a3210eeea6e314

3 years agoMerge Bloom filter bug fix from trunk into the right-join branch. right-join
drh [Tue, 3 May 2022 16:26:50 +0000 (16:26 +0000)] 
Merge Bloom filter bug fix from trunk into the right-join branch.

FossilOrigin-Name: 72131ad1bda3d087e59cd4a51d87f10f65a55e658645397e1ede15f9fb1f5143

3 years agoFix a typo in a comment.
drh [Tue, 3 May 2022 16:18:25 +0000 (16:18 +0000)] 
Fix a typo in a comment.

FossilOrigin-Name: c19c3c48698bf2543d775411c62d01e629791e2f3c5317970fdbb830eacafac6

3 years agoFix the Bloom filter pull-down optimization so that it jumps to the correct
drh [Tue, 3 May 2022 14:01:48 +0000 (14:01 +0000)] 
Fix the Bloom filter pull-down optimization so that it jumps to the correct
place if it encounters a NULL key.  Fix for the bug described by
[forum:/forumpost/2482b32700384a0f|forum thread 2482b32700384a0f].

FossilOrigin-Name: 6eda9b1a7784cf6d58c8876551f67ab98e78a08e726a0579d4def5ba881985bb

3 years agoAdd assert()s to show that jumps always land an an instruction that is between
drh [Tue, 3 May 2022 12:11:16 +0000 (12:11 +0000)] 
Add assert()s to show that jumps always land an an instruction that is between
1 and Vdbe.nOp-1.  Had these assert()s been in place before, they would have
caused an assertion fault for the byte-code error reported by
[forum:/forumpost/2482b32700|forum post 2482b32700].

FossilOrigin-Name: 8f8a58feb7047d19522ca32efbe42fd9ddf49aaf9064f7373eb56a88982406a2

3 years agoOrganize the various flag bits of the ExprList_item object into a substructure
drh [Mon, 2 May 2022 20:49:30 +0000 (20:49 +0000)] 
Organize the various flag bits of the ExprList_item object into a substructure
so that the whole lot can be copied all at once.  Faster and smaller code.

FossilOrigin-Name: 5341d4bbe9a943f9cdbbdea829e18f108e98972ebb706396c50fc62fcc6a6328

3 years agoMerge trunk fixes into the right-join branch.
drh [Mon, 2 May 2022 20:14:26 +0000 (20:14 +0000)] 
Merge trunk fixes into the right-join branch.

FossilOrigin-Name: e01f4c05c21e89dcc7985e00874f288d9ba5d5d932f7284f8d970bd3145ac0c2

3 years agoImproved comments.
drh [Mon, 2 May 2022 20:04:34 +0000 (20:04 +0000)] 
Improved comments.

FossilOrigin-Name: 158b80bed61ade793ccfd979f26a5231fabc8c14697ca0141bba61bc13e3b2ba

3 years agoName resolution and "*" wildcard expansion for parenthesized FROM clauses
drh [Mon, 2 May 2022 19:59:03 +0000 (19:59 +0000)] 
Name resolution and "*" wildcard expansion for parenthesized FROM clauses
seems to work the same as PG.  The code is chaos, however, and needs some
cleanup.

FossilOrigin-Name: 6f9c0b07aadc5189c65c3ee4e6938aac10fc0d98f1cb06980f5e5d7b0308f237

3 years agoRemove a testcase() macro taht was made obsolete by [a8da85c57e07721d].
drh [Mon, 2 May 2022 15:47:57 +0000 (15:47 +0000)] 
Remove a testcase() macro taht was made obsolete by [a8da85c57e07721d].

FossilOrigin-Name: 053cf45ecaa7eac8cc64c7b2672807f736a45575a84b426263b2e1feb060b401

3 years agoDocument (in comments) that the SQLITE_FlttnUnionAll bit has a specific value
drh [Mon, 2 May 2022 15:31:06 +0000 (15:31 +0000)] 
Document (in comments) that the SQLITE_FlttnUnionAll bit has a specific value
needed by TH3.

FossilOrigin-Name: bcaa4a44749d157c5953c6f54c88b1ba29b4035f4b21fce986b7efbea372e109

3 years agoFix a harmless compiler warning in sqlite3TreeViewWinFunc() (a routine that
drh [Mon, 2 May 2022 15:23:59 +0000 (15:23 +0000)] 
Fix a harmless compiler warning in sqlite3TreeViewWinFunc() (a routine that
does not even appear in release builds).

FossilOrigin-Name: daff6070039e45df7c47b323a8352e56d1264a7bfb065fe2d79c58454c95a262

3 years agoMerge the latest trunk fixes and enhancements into the right-join branch.
drh [Mon, 2 May 2022 15:10:38 +0000 (15:10 +0000)] 
Merge the latest trunk fixes and enhancements into the right-join branch.

FossilOrigin-Name: afbcf075c1e09ae064c7b16e63501cd1d374711812664aef76bd35d02d64a2b6

3 years agoImprovement on check-in [a193749730d6cfba] so that the subroutine call to
drh [Mon, 2 May 2022 14:32:56 +0000 (14:32 +0000)] 
Improvement on check-in [a193749730d6cfba] so that the subroutine call to
the IN operator right-hand side generator from the RIGHT JOIN no-match logic
does not generate unreachable byte code.

FossilOrigin-Name: cc458317bd77046c4328715ae9e3409f3f4cd422a01162cb33405ef3a142b0a3

3 years agoBring the comments on sqlite3FindInIndex() into closer alignment with what
drh [Mon, 2 May 2022 11:24:21 +0000 (11:24 +0000)] 
Bring the comments on sqlite3FindInIndex() into closer alignment with what
that routine actually does.

FossilOrigin-Name: 40f3274745b53bb72933c1052d0e85bc74be56d3a1068e9d54dc28763a2cfef9

3 years agoDefensive code in sqlite3TreeViewWindow() to fix a compiler warning.
drh [Sat, 30 Apr 2022 19:55:28 +0000 (19:55 +0000)] 
Defensive code in sqlite3TreeViewWindow() to fix a compiler warning.

FossilOrigin-Name: b250c218b4b6327a1cae3edbc037625ba998f89ee13a9bfbc2cefd1edfc4b768

3 years agoSimplified fix to the problem with subroutine reuse in the RIGHT JOIN no-match
drh [Sat, 30 Apr 2022 18:40:22 +0000 (18:40 +0000)] 
Simplified fix to the problem with subroutine reuse in the RIGHT JOIN no-match
logic for a subquery on the right-hand side of an IN operator.  The code still
needs simplification.

FossilOrigin-Name: a193749730d6cfba617f2a64e7254c78f92bbf29b109c19055fc33f6cc643d4c

3 years agoPreserve the COLLATE operator on an index on an expression when resolving
drh [Sat, 30 Apr 2022 12:35:51 +0000 (12:35 +0000)] 
Preserve the COLLATE operator on an index on an expression when resolving
the use of that expression into a reference to the index.  See
[forum:/info/7efabf4b03328e57|forum thread 7efabf4b03328e57] for details.

FossilOrigin-Name: a8da85c57e07721dc1c918d67433d6c99ce48421e369123cc3194d855e55f7e8

3 years agoFurther improvements to codeEqualityTerm() for cases when an IN operator with
drh [Sat, 30 Apr 2022 00:06:52 +0000 (00:06 +0000)] 
Further improvements to codeEqualityTerm() for cases when an IN operator with
a right-hand side subquery is used as a constraint that needs to be processed
by the RIGHT JOIN non-matched logic.

FossilOrigin-Name: bb2798be3fb5737827eec505db2d4c8cb510d227d98fc26ce748bf2da7e8b382

3 years agoEnhance the TreeView debugging output for Expr with opcode TK_IN so as to
drh [Sat, 30 Apr 2022 00:05:37 +0000 (00:05 +0000)] 
Enhance the TreeView debugging output for Expr with opcode TK_IN so as to
show the RHS table and the subroutine address.

FossilOrigin-Name: aec1e4cd59ae874b66335e4f87322fbe31fbb752429e68bf41338db316d0a9ed

3 years agoEnhance the codeEqualityTerm() routine inside the code generator so that it is
drh [Fri, 29 Apr 2022 19:00:11 +0000 (19:00 +0000)] 
Enhance the codeEqualityTerm() routine inside the code generator so that it is
able to reuse an IN operator that has an invariant subquery on its right-hand
side while coding the non-matched loop of a RIGHT JOIN.
dbsqlfuzz 19f1102a70cf966ab249de56d944fc20dbebcfcf

FossilOrigin-Name: 56dd3065469e49320b13af039471b3f0b85e6f7368cfd97b1cdc0cf8fa8e1956

3 years agoWith TreeView, only show the table columns for a SrcItem if the data source
drh [Fri, 29 Apr 2022 17:45:39 +0000 (17:45 +0000)] 
With TreeView, only show the table columns for a SrcItem if the data source
is a subquery rather than a persistent table.

FossilOrigin-Name: 7b4a0d0fa1d8facaf5e550650d9b261eda7eb7a2a413627f2751f01c5477e1f3

3 years agoMultiple enhancements to the TreeView output for SrcItem, cherrypicked from
drh [Fri, 29 Apr 2022 17:13:52 +0000 (17:13 +0000)] 
Multiple enhancements to the TreeView output for SrcItem, cherrypicked from
the right-join experimental branch.

FossilOrigin-Name: 293afa81112e824eec2557d004a27319d484276f796936e16d64243fe24f6b68

3 years agoShow the USING clause as part of the tree-view display of SrcItem.
drh [Fri, 29 Apr 2022 17:03:25 +0000 (17:03 +0000)] 
Show the USING clause as part of the tree-view display of SrcItem.

FossilOrigin-Name: 9cba3ce577e442f83d7a2d6926e38ffe6bc45953c88ecdd384f3455890303cce

3 years agoMinor typo fix in a comment, for the benefit of broken IDE syntax highlighters.
drh [Fri, 29 Apr 2022 12:09:43 +0000 (12:09 +0000)] 
Minor typo fix in a comment, for the benefit of broken IDE syntax highlighters.

FossilOrigin-Name: 680ccecbc839373194ed2dcc1053e25512d9ea3f12f8c8963cb8fbd1a034d2f8