build: query pkg-config for readline/libedit/libeditline

Fix #686

build: don't enforce style

clang-format is a pain with behaviour depending on the version...

daemon: revert latest style change

daemon: do not query PHY for a down interface on Linux

It may wake up the device.

Fix #685

fix endless loop in redefined malloc/remalloc functions on system using uClibc

build: use environment variables to configure pip

Otherwise, it may or may not work depending on the version of pip...

build: use Ubuntu 22.04

Can't fix everything right now...

daemon: fix formatting with clang-format

Revert "build: try to build SNMP with --base-lib-cflags"

This reverts commit 3e3ba6e8dd93b2adf6a46b6345e7ff2f3ae7f962. This does
not work as it also includes -D_FORTIFY_SOURCE=x...

daemon: fix usage of calloc

First argument is the number of elements to allocate.

build: try to build SNMP with --base-lib-cflags

In the past, this was not working correctly. Let's see if the situation
has improved.

build: remove -D_FORTIFY_SOURCE= from NetSNMP CFLAGS

This is really a pain...

build: allow pip to install packages system-wide

build: bump cachix/install-nix-action from 26 to 29

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 26 to 29.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v26...v29)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: run cross-platforms test on ubuntu-latest

MacOS and Xhyve are deprecated. See:
https://github.com/cross-platform-actions/action/blob/HEAD/changelog.md#0250---2024-07-11

build: bump cross-platform-actions/action from 0.24.0 to 0.25.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.24.0 to 0.25.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

build: run clang-format

lldpd: limit tx ttl to 65535

Based on IEEE 802.1AB(2016) 9.2.5.22 txTTL:
  During normal operation, txTTL is set to whichever is the smaller of the
  values represented by Equation (1) and Equation (2):
      (msgTxInterval x msgTxHold) + 1   (1)
      65535                             (2)

Reported-by: Matt Lucius <malucius@redhat.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

client: add range restriction for tx hold and interval

Based on IEEE 802.1AB(2016) 9.2.5. The valid range of tx hold is 1-100,
the valid range of tx interval is 1-3600.

Reported-by: Matt Lucius <malucius@redhat.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

build: bump docker/build-push-action from 5 to 6

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](https://github.com/docker/build-push-action/compare/v5...v6)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Be more defensive when parsing PRETTY_NAME out of os-release

Test the result of `strtok(..)` to ensure that the line being parsed has
an `=` sign in it. This addresses a potential crash due to a NULL
pointer dereference.

Reported by: Coverity
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>

priv: disable LLDP in firmware for Intel X7xx cards on FreeBSD

build: fix inclusion of editline/readline.h

build: also test for editline/readline.h

client: provide a working prototype for readline()

osx: multiarch install package

osx: fix package build on Apple Silicon

build: use FreeBSD 13.3

build: run BSD tests on macos-12

No nested virtualization allowed for macos-14.

docs: in NEWS, mention extra capabilities

build: bump cross-platform-actions/action from 0.23.0 to 0.24.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.23.0 to 0.24.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.23.0...v0.24.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Extra capabilities bitflags and configurability.
No attempt is made to detect such functionality yet.

docs: fix spacing for code blocks

Docs (#657)

* README.md improvements

* sp

Fix macos warnings at compile time.

If this happens:

lldpd.c:1577:14: warning: variable 'pidfile' set but not used [-Wunused-but-set-variable]
        const char *pidfile = LLDPD_PID_FILE;

Then the other places using pidfile should get the same ifndef treatment

Document default behaviour for these advertisements.

oui-info format description: shall

lib: Fix a buffer underflow in _lldpctl_dump_in_atom

Do not write a zero byte before the beginning of the buffer when
_lldpctl_dump_in_atom is called with a zero length atom.

interfaces: "fix" style issue in latest commit

Depending on the version of clang, we may get different result. This is
annoying, but no time to fix that now.

interfaces: don't use wireless extensions

Fix #579

daemon: rework a bit systemd support

Use connect() as done by other implementations, notably the one in
sd_notify(2). Also add a check on socket length.

build: bump softprops/action-gh-release from 1 to 2

Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](https://github.com/softprops/action-gh-release/compare/v1...v2)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cachix/install-nix-action from 25 to 26

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 25 to 26.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v25...v26)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: use pytest-forked to replace boxed feature from xdist

This is needed because of the code switching from one namespace to
another.

build: don't use boxed feature of xdist

It has been removed from 3.0. This could be replaced by pytest-forked if
needed. I don't really remember why I was using that (I suppose it was
to avoid segfaults, due maybe to ctypes?).

build: disable gold linker in CI

This should not be needed anymore nowadays. This is a tentative to fix
the following errors with clang:

    /usr/bin/ld.gold: warning: Cannot export local symbol '__asan_check_load_add_16_RAX'

client: spell fix

docs: man page fixes

build: bump cachix/install-nix-action from 24 to 25

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 24 to 25.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v24...v25)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cross-platform-actions/action from 0.22.0 to 0.23.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.22.0 to 0.23.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.22.0...v0.23.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

docs: man page fixes

changed: network cable -> link

change -M help text in src/daemon/lldpd.c also

osx: update Brew formula

redhat: suppress extra .la file we don't want to install

redhat: fix date in changelog

release: 1.0.18

There is a small regression in support for 802.3BT. People should keep
using 1.0.17 if that's important for them.

build: bump actions/download-artifact from 3 to 4

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cross-platform-actions/action from 0.21.1 to 0.22.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.21.1 to 0.22.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.21.1...v0.22.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

daemon/netlink: fix documentation string

daemon/netlink: use a different socket for changes and queries

There is a race condition when using the same socket for both. We need
to subscribe for changes before getting the current state as we don't
want to miss an update happening while we get the initial state, but if
there is such an update, the Netlink messages we receive may not be the
ones we expect.

Fix #611

compat: add compat.h header to get forward declarations

daemon/priv: no need to define IFALIASZ

It is part of the shipped kernel header. This is a bit odd we did define
it...

daemon/lldpd: do not set interface description continuously

Otherwise, we get a continuous flow of netlink updates.

Fix #623

build: update automake for OpenBSD

build: update BSD versions, add NetBSD

build: keep using xhyve for OpenBSD

See https://github.com/cross-platform-actions/action/issues/73

build: use QEMU for testing FreeBSD/OpenBSD

FreeBSD jobs often fail with a timeout.

build: bump cachix/install-nix-action from 23 to 24

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 23 to 24.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v23...v24)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: improve const correctness and prototype declarations

String literals aren't assigned to non-const char pointers anymore, they
aren't returned via non-const char pointers, const strings aren't passed
arround via non-const pointers etc.

As a side effect, this eliminates all -Wdiscarded-qualifiers warnings.

Symbol visibility is minimized by declaring additional functions
static, i.e those which are only used inside a single translation unit.

Also, a few includes are added such that all non-static function
definitions 'see' their declarations - such that accidental differences
in signatures immedialy yield compile errors or warnings.

A few macros are also modified to emit forward declarations for
non-static functions in order to eliminate noise when compiling with
-Wmissing-prototypes.
However, it might make sense to move those non-static function
definitions from a header into a dedicated translation unit,
at some point.

build: ensure we use -Werror on Linux builds

client: fix style

client: translate dot into the short hostname

as documented in lldpcli(8):

    configure system hostname name

        Override system hostname with the provided value. By default, the
        system name is the FQDN found from the resolved value of uname
        -n.  As a special value, use "." (dot) to use the short hostname
        instead of a FQDN.

build: remove coverity

It is broken, again. The tool still advertises Travis CI, it looks
unmaintained.

daemon/lldpd: fix capitalization in help output

daemon/lldp: fix warning message about out of order TLVs

Fix #616

build: bump docker/login-action from 2 to 3

Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](https://github.com/docker/login-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump docker/metadata-action from 4 to 5

Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4 to 5.
- [Release notes](https://github.com/docker/metadata-action/releases)
- [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md)
- [Commits](https://github.com/docker/metadata-action/compare/v4...v5)

---
updated-dependencies:
- dependency-name: docker/metadata-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cross-platform-actions/action from 0.19.0 to 0.21.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.19.0 to 0.21.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.19.0...v0.21.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

lib/lldpctl: fix style

daemon/lldp: restore read support for 802.3BT

As it was said to work for most people, let's keep it. Just remove write
support for now.

build: update nixpkgs

tests/integration: also remove 802.3bt test

lib: bump API/ABI

Due to previous change, it seems safer to bump the API/ABI as it would
be easy to reuse the numbers introduced by 802.3bt.

Fix #404 (as a side-effect)

daemon/lldp: remove support for 802.3bt

It was broken and despite a tentative to fix it, it is unknown if this
is correct. This looks different from the code in Wireshark. Maybe it
was done on an earlier version of 802.3bt? As the standard is not freely
available, I cannot reasonably fix it.

daemon/protocols: fix some 802.3bt stuff

And add some tests.

lldpcli: fix capitalization

client/conf-power: Add support for 803.2bt parameters.

Signed-off-by: Andreas Hofmann <git@andreas-hofmann.org>

build: fix alignment in configure.ac

build: bump docker/setup-buildx-action from 2 to 3 (#608)

build: bump docker/setup-qemu-action from 2 to 3

Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 2 to 3.
- [Release notes](https://github.com/docker/setup-qemu-action/releases)
- [Commits](https://github.com/docker/setup-qemu-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: docker/setup-qemu-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cachix/install-nix-action from 22 to 23 (#607)

build: bump docker/build-push-action from 4 to 5 (#609)

build: bump actions/checkout from 3 to 4

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

[oss-fuzz] Issue 62435

Signed-off-by: Arjun Singh <ajsinghyadav00@gmail.com>

[bug] fix 5193822305648640 and 4673544697806848

Signed-off-by: Arjun Singh <ajsinghyadav00@gmail.com>

build: bump cross-platform-actions/action from 0.17.0 to 0.19.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.17.0 to 0.19.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.17.0...v0.19.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cross-platform-actions/action from 0.15.0 to 0.17.0 (#595)

build: try another way to workaround problem with brew

brew update is not mandatory, let's try it as a best effort.

build: try to fix CI on MacOS

github: add GitHub sponsorship