]> git.ipfire.org Git - thirdparty/sqlite.git/log
thirdparty/sqlite.git
6 years agoMinor enhancement to the pager so that it remembers if the underlying database immutable-pager
drh [Thu, 27 Sep 2018 14:24:22 +0000 (14:24 +0000)] 
Minor enhancement to the pager so that it remembers if the underlying database
files is immutable.

FossilOrigin-Name: 64db614eddd664e074021ce2fab123efc49eb250f70e55fed96f7d5ea2a32747

6 years agoDisallow the use of window functions in the recursive part of a recursive CTE.
dan [Thu, 27 Sep 2018 12:14:15 +0000 (12:14 +0000)] 
Disallow the use of window functions in the recursive part of a recursive CTE.

FossilOrigin-Name: 7fc2994434c7d9ed29c96a69c07e8eb4e97be776473c170c63f9a1bbaa09fa68

6 years agoMinor simplification: In OP_ParseSchema, read the p1 register once.
mistachkin [Thu, 27 Sep 2018 00:04:31 +0000 (00:04 +0000)] 
Minor simplification: In OP_ParseSchema, read the p1 register once.

FossilOrigin-Name: bd250533a06e4a11c1f548c3de66b8562fc627383848570d7d030cf132fd336f

6 years agoFurther improvements to the ".help" command in the CLI.
drh [Wed, 26 Sep 2018 18:02:32 +0000 (18:02 +0000)] 
Further improvements to the ".help" command in the CLI.

FossilOrigin-Name: edc3d18ecbda32d6a55de76ee7335342425c57d917e9b48814a7301a012263b2

6 years agoBegin revamping the ".help" command in the command-line shell so that it
drh [Wed, 26 Sep 2018 16:53:51 +0000 (16:53 +0000)] 
Begin revamping the ".help" command in the command-line shell so that it
can accept an argument and will do a search for commands that match that
argument.

FossilOrigin-Name: 209afb8d06466536863b89a8acb9a1a18477a06331d8cce95fc6380e1666b6f5

6 years agoTweak spellfix.c so that if SQLITE_SPELLFIX_5BYTE_MAPPINGS is defined at
dan [Wed, 26 Sep 2018 16:05:07 +0000 (16:05 +0000)] 
Tweak spellfix.c so that if SQLITE_SPELLFIX_5BYTE_MAPPINGS is defined at
compile time the Transliteration structure has space for 5 byte (instead of 4
byte) mappings.

FossilOrigin-Name: cbaf5b6c1b07b29b2c83fa01618de856d81cc1174769cb9770cb5c894cc87ace

6 years agoFix typos in the header comment for the sha1 and sha3 hash extensions
drh [Wed, 26 Sep 2018 03:43:42 +0000 (03:43 +0000)] 
Fix typos in the header comment for the sha1 and sha3 hash extensions
in the ext/misc folder.

FossilOrigin-Name: 4ed9d83a0b14a22b3ecf25785b03b5a824d260e01a608aea85231df9b816421d

6 years agoFix a problem in releasetest.tcl causing configuration "Fast-One" to fail.
dan [Tue, 25 Sep 2018 13:51:31 +0000 (13:51 +0000)] 
Fix a problem in releasetest.tcl causing configuration "Fast-One" to fail.

FossilOrigin-Name: 42e04fefbc241dd33f12abd66344a87720ae4cda6d82f2882217b3cb71be8733

6 years agoSlightly smaller and faster alternative to [507d892c3a40a0bacbd47] that
drh [Mon, 24 Sep 2018 15:39:30 +0000 (15:39 +0000)] 
Slightly smaller and faster alternative to [507d892c3a40a0bacbd47] that
fixes a problem with views that use window function as part of complex
expressions.

FossilOrigin-Name: d7c816ae15f05f21b9b213161e1044aaefc56f17e7bc4b7b551a9e04efc05855

6 years agoFix a problem with views that use window functions as part of complex expressions.
dan [Mon, 24 Sep 2018 14:51:59 +0000 (14:51 +0000)] 
Fix a problem with views that use window functions as part of complex expressions.

FossilOrigin-Name: 507d892c3a40a0bacbd47ed3c4fe2d8925a82716ae08da8401750a42782ba454

6 years agoAllow a writable virtual table to have a schema with an INTEGER PRIMARY KEY
drh [Mon, 24 Sep 2018 14:10:55 +0000 (14:10 +0000)] 
Allow a writable virtual table to have a schema with an INTEGER PRIMARY KEY
and WITHOUT ROWID.  This fixes ticket
[f25d5ceebe1d710ff61a571e395356869d8272ef].

FossilOrigin-Name: 5a38d9281b4ad63b853efa5cdd5ad4a64b19dfaf8250ef8e0e186684df1211ea

6 years agoUse compile-time options SQLITE_QUERY_PLANNER_LIMIT and
drh [Mon, 24 Sep 2018 12:37:01 +0000 (12:37 +0000)] 
Use compile-time options SQLITE_QUERY_PLANNER_LIMIT and
SQLITE_QUERY_PLANNER_LIMIT_INCR to control the value for
WhereLoopBuilder.iPlanLimit, rather than embedding magic numbers in the
code.

FossilOrigin-Name: 903e501894b2a5dd7055b5154d74d4a47a619f76e66485a4d62b6259f10723d6

6 years agoIncrease the initial value of WhereLoopBuilder.iPlanLimit to 20K. Issue
drh [Mon, 24 Sep 2018 10:47:33 +0000 (10:47 +0000)] 
Increase the initial value of WhereLoopBuilder.iPlanLimit to 20K.  Issue
a warning if the iPlanLimit reaches zero.

FossilOrigin-Name: 3dd35f51187574f47f860405309877cdbf9dc5710703dfd98cf98073b771140c

6 years agoFix a faulty assert() in the validation logic for the LEFT JOIN strength
drh [Sun, 23 Sep 2018 02:01:42 +0000 (02:01 +0000)] 
Fix a faulty assert() in the validation logic for the LEFT JOIN strength
reduction optimization.  Problem found by OSSFuzz.

FossilOrigin-Name: 2fd62fccd13e326dbd7dd730112542c6faa56e466bf4f7b8e22ced543031280c

6 years agoEnhance WhereLoopBuilder.iPlanLimit to handle a case involving the OR
drh [Sat, 22 Sep 2018 15:05:32 +0000 (15:05 +0000)] 
Enhance WhereLoopBuilder.iPlanLimit to handle a case involving the OR
optimization discovered overnight by OSSFuzz.

FossilOrigin-Name: 7b59930a1d7b664b54d5a2bc9fa385925b5f4c8f34bf401c798307e3e2dae2c6

6 years agoFix harmless compiler warning when compiled with SQLITE_OMIT_AUTHORIZATION.
mistachkin [Fri, 21 Sep 2018 23:41:18 +0000 (23:41 +0000)] 
Fix harmless compiler warning when compiled with SQLITE_OMIT_AUTHORIZATION.

FossilOrigin-Name: 50f2fa19532e0f849d61d9e2a97427cfbf64cfb787ca481ef8c860d0f24f6cfe

6 years agoComment typo fixed. No code changes.
drh [Fri, 21 Sep 2018 19:06:09 +0000 (19:06 +0000)] 
Comment typo fixed.  No code changes.

FossilOrigin-Name: 7e68cdab20f50cf776b92b2138bb4aba7cb070f2bd855dd4cbbf46d447f2dc88

6 years agoPut a limit counter on the query planner that restricts the number of
drh [Fri, 21 Sep 2018 18:43:51 +0000 (18:43 +0000)] 
Put a limit counter on the query planner that restricts the number of
index+constraint options that can be considered for each table in a join.
This prevents certain pathological queries from taking up too much time
in the query planner.

FossilOrigin-Name: 8690b5a0cc08eeb175230de45d4ca9b9f7b9b22aeebea70b8b7151f10b130969

6 years agoOptimization to the OP_MakeRecord opcode makes speed-check.sh run about
drh [Fri, 21 Sep 2018 13:07:14 +0000 (13:07 +0000)] 
Optimization to the OP_MakeRecord opcode makes speed-check.sh run about
1.1 million cycles faster, and results in a slightly smaller library.

FossilOrigin-Name: d10e63629183f6daf0c263cd4dae052a3786c8c1480b3b6a73124b3315e41951

6 years agoMinor code simplification.
drh [Thu, 20 Sep 2018 20:43:28 +0000 (20:43 +0000)] 
Minor code simplification.

FossilOrigin-Name: 22ae8a52dd2fb744f467c7dccf1d7fe7c7cef0e1dcc897dd492f897e84c9facb

6 years agoAdd the "PRAGMA legacy_alter_table=ON" command to enable the pre-3.25.0
drh [Thu, 20 Sep 2018 20:15:02 +0000 (20:15 +0000)] 
Add the "PRAGMA legacy_alter_table=ON" command to enable the pre-3.25.0
behavior of ALTER TABLE that does not modify the bodies of triggers or
views or the WHERE clause of a partial index.  Enable the legacy behavior
by default when running the xRename method of virtual tables.

FossilOrigin-Name: 7edd26ed27ed1e7eab603058f7d55f2eac45e7bd1908bfa5f32293611883b157

6 years agoCombine the Expr.pTab and Expr.pWin fields into a union named "y". Add a new
drh [Thu, 20 Sep 2018 19:02:15 +0000 (19:02 +0000)] 
Combine the Expr.pTab and Expr.pWin fields into a union named "y".  Add a new
EP_WinFunc property that is only true if Expr.y.pWin is a valid pointer.
This reduces the size of the Expr object by 8 bytes, reduces the overall
amount of code, and shaves over 1 million cycles off of the speed test.

FossilOrigin-Name: ad130bb86e74e6ce165fdbdce3a19699510f0e62071c1c7923b5a4538d888c7c

6 years agoBy default, make all "ALTER TABLE RENAME" statements executed within a virtual legacy-alter-table
dan [Thu, 20 Sep 2018 17:21:21 +0000 (17:21 +0000)] 
By default, make all "ALTER TABLE RENAME" statements executed within a virtual
table xRename() method exhibit the legacy behaviour.

FossilOrigin-Name: 71947337e98b90debb13b390119bc2a6b39dd41535151b836071ee327a31e45d

6 years agoAdd a PRAGMA that restores the legacy ALTER TABLE RENAME TO behaviour.
dan [Thu, 20 Sep 2018 08:28:01 +0000 (08:28 +0000)] 
Add a PRAGMA that restores the legacy ALTER TABLE RENAME TO behaviour.

FossilOrigin-Name: 5acad2e92c11c209bedc6ac8a709595e8070eed028ffc82af61499e5ceaa5e2b

6 years agoA minor code simplification, saved in a branch for future reference. minor-altertab-simplification
drh [Wed, 19 Sep 2018 18:17:46 +0000 (18:17 +0000)] 
A minor code simplification, saved in a branch for future reference.

FossilOrigin-Name: 5e458f4a92743effb9a3d3249767424fed8b444a05ca136c4a55d60c4d70c2cc

6 years agoFix a compilation issue in the "userauth" extension. Also fix a few test
dan [Wed, 19 Sep 2018 17:09:09 +0000 (17:09 +0000)] 
Fix a compilation issue in the "userauth" extension. Also fix a few test
script errors that occur with SQLITE_USER_AUTHENTICATION=1 builds.

FossilOrigin-Name: 221f3f572ed49d7af69a2e7c88741fa5206ea33ca59ee791eac7698bdd11ca4d

6 years agoFix the "sqlite3" command in the TCL interface so that it correctly returns
drh [Wed, 19 Sep 2018 15:08:21 +0000 (15:08 +0000)] 
Fix the "sqlite3" command in the TCL interface so that it correctly returns
an error if invoked with no arguments.

FossilOrigin-Name: 2034fa8089676132b5e2f71bdebf1af9ca141da2e173920c6e84fb974ab0f022

6 years agoFix a problem building on Android with SQLITE_ENABLE_BATCH_ATOMIC_WRITE set.
dan [Tue, 18 Sep 2018 19:40:18 +0000 (19:40 +0000)] 
Fix a problem building on Android with SQLITE_ENABLE_BATCH_ATOMIC_WRITE set.

FossilOrigin-Name: e41e50fe7430cb79f67369fe81ac9938665bfc5db59c4faaf429ceb8ca03f584

6 years agoAvoid incrementing the SQLITE_LOOKASIDE_MISS_SIZE stat before sqlite3_open()
dan [Tue, 18 Sep 2018 17:50:34 +0000 (17:50 +0000)] 
Avoid incrementing the SQLITE_LOOKASIDE_MISS_SIZE stat before sqlite3_open()
returns. Fix test script problem in lookaside.test.

FossilOrigin-Name: e461cb281959d8517296e3e4e934eba8206770b1a592cd7655b6567268da1634

6 years agoEnhance tester.tcl so that when "--malloctrace=1" is specified, the test
dan [Tue, 18 Sep 2018 17:00:06 +0000 (17:00 +0000)] 
Enhance tester.tcl so that when "--malloctrace=1" is specified, the test
generates self-contained Tcl scripts that present GUIs instead of *.sql files
that require a separate program to interpret.

FossilOrigin-Name: de2e3cbd08c00d235106c040fa472ec267ef8f1ec13c34ed7d16deac8d50b6cc

6 years agoMinor improvements to the permutations.test script. Most notably, a command
dan [Tue, 18 Sep 2018 16:06:42 +0000 (16:06 +0000)] 
Minor improvements to the permutations.test script. Most notably, a command
like "permutations.test alter%" now runs all test scripts with names that
match the LIKE pattern "alter%". Or, say, "permutations wal alter%" to run all
alter% tests in wal mode.

FossilOrigin-Name: 3e1a2f6614eacb65e1dffe64c6292c809fc5808be2d9d7d103cfc57d7b32fcd9

6 years agoFurther optimizations to the UPDATE logic to avoid making changes to partial
drh [Mon, 17 Sep 2018 20:47:38 +0000 (20:47 +0000)] 
Further optimizations to the UPDATE logic to avoid making changes to partial
indexes if none of the columns mentioned in the WHERE clause are modified by
the UPDATE.

FossilOrigin-Name: d1365a5bf0ee2f145427b81d2a593f539c3ad4705d579478703c1f65ae5f80bf

6 years agoDisable the ORDER BY LIMIT optimization in queries using window functions.
drh [Mon, 17 Sep 2018 15:19:13 +0000 (15:19 +0000)] 
Disable the ORDER BY LIMIT optimization in queries using window functions.
This fixes a problem that was introduced by check-in [206720129ed2fa8875a286]
which attempted to fix ticket [9936b2fa443fec03ff25f9].  This changes is
a fix for the follow-in tocket [510cde277783b5fb5de628].

FossilOrigin-Name: c6c9585f294710829ca24b64d70a36fd9f409261dd0661367c6c4198cdbc4c81

6 years agoFix a false-positive in the post-ALTER-TABLE schema verification logic that
drh [Mon, 17 Sep 2018 14:13:48 +0000 (14:13 +0000)] 
Fix a false-positive in the post-ALTER-TABLE schema verification logic that
prevents ALTER TABLE from working if the table being altered has a trigger
that references any column of a virtual table. Ticket [b41031ea2b537237].

FossilOrigin-Name: 84105ea4af98bd8bddbdf9dc6674bdf73c110c0685afe868ce9681da110144d7

6 years agoRestore an assert() that was present on trunk. tkt-b41031ea
drh [Mon, 17 Sep 2018 13:55:18 +0000 (13:55 +0000)] 
Restore an assert() that was present on trunk.

FossilOrigin-Name: a7b572ca7867a95f49888dc95c0dc6d726afa9fea26283be147ba422639d1307

6 years agoMinor modification to the fix on this branch to avoid adding extra conditional
dan [Mon, 17 Sep 2018 13:38:45 +0000 (13:38 +0000)] 
Minor modification to the fix on this branch to avoid adding extra conditional
compilation macros.

FossilOrigin-Name: 4d8be404dab265b51e5a6a95e83be85c22512e19a437191690c7d845c87ff259

6 years agoFix missing space in 'configure.ac' reported on the mailing list.
mistachkin [Mon, 17 Sep 2018 12:49:21 +0000 (12:49 +0000)] 
Fix missing space in 'configure.ac' reported on the mailing list.

FossilOrigin-Name: 96b00a3cd2273dd3baa8e5b7a441458b142d4d2daabc679e4fcb5ab706674e76

6 years agoAdd extra test for the fix on this branch. Also fix a
dan [Mon, 17 Sep 2018 08:27:23 +0000 (08:27 +0000)] 
Add extra test for the fix on this branch. Also fix a
pointer-compare-after-free problem that occurs in similar cases.

FossilOrigin-Name: 1856ea63b3186c2c8fa716ffe01c731397bdbbc3fbb56dc72ad0686cb7f152ca

6 years agoAdd assert()s to the new code in the previous check-in.
drh [Mon, 17 Sep 2018 00:15:21 +0000 (00:15 +0000)] 
Add assert()s to the new code in the previous check-in.

FossilOrigin-Name: b12f23a5c484cab3654721299ea0f05230eef6b14012b557f3bf2592fac0f00e

6 years agoFirst proposed fix for the ALTER TABLE problem described by ticket
drh [Sun, 16 Sep 2018 23:27:37 +0000 (23:27 +0000)] 
First proposed fix for the ALTER TABLE problem described by ticket
[b41031ea2b5372378cb3d2d]

FossilOrigin-Name: 05a9d129254e01a5f6b5e4033c105190eae386575a94b020ef3e0cbd30bbf056

6 years agoRemove an unreachable branch from the index-on-expression optimization.
drh [Sun, 16 Sep 2018 18:23:48 +0000 (18:23 +0000)] 
Remove an unreachable branch from the index-on-expression optimization.

FossilOrigin-Name: 2df2cf4f179dd88fb2530dfd338f344ac48dd052ef954dc95a136884523f7aee

6 years agoFix a memory leak in the explain extension.
drh [Sun, 16 Sep 2018 16:34:31 +0000 (16:34 +0000)] 
Fix a memory leak in the explain extension.

FossilOrigin-Name: d0c92b047a5355726aea87f38038e5bda3adf6137492919be94bd29bb847eddb

6 years agoAdd the new "explain" virtual table in ext/misc. Use this virtual table
drh [Sun, 16 Sep 2018 16:18:01 +0000 (16:18 +0000)] 
Add the new "explain" virtual table in ext/misc.  Use this virtual table
for additional test cases for the optimization that avoids updating indexes
on expressions when none of the columns changed by the UPDATE are in the
expression.

FossilOrigin-Name: 2404304cc15eaeee2744cf3c8f9cac0a544631c4f1060c5a17a78b43ca86edf0

6 years agoImproved presentation on the new code that prevents unnecessary writes to
drh [Sun, 16 Sep 2018 15:01:25 +0000 (15:01 +0000)] 
Improved presentation on the new code that prevents unnecessary writes to
expressions on indexes during an UPDATE when the expression does not reference
any of the columns that are changing.

FossilOrigin-Name: c9f045295c4577752b0847ff2027b44661e6cb15bb08b942ccb3a0ef396f3dec

6 years agoIncrease the version number to 3.26.0 as we start the next development cycle.
drh [Sat, 15 Sep 2018 21:43:14 +0000 (21:43 +0000)] 
Increase the version number to 3.26.0 as we start the next development cycle.

FossilOrigin-Name: 885f0f8252aae776a86c64bcc7da582f0ed58f2caae8ebff810a83ca339da820

6 years agoOptimization: when doing an UPDATE on a table with indexes on an expression,
drh [Sat, 15 Sep 2018 21:38:48 +0000 (21:38 +0000)] 
Optimization: when doing an UPDATE on a table with indexes on an expression,
do not update the expression indexes if they do not refer to any of the
columns of the table being updated.

FossilOrigin-Name: a71b101635ed28a4c99734dabb20bd65ef1018c1d63ac143b7321cdb0fafa5d7

6 years agoVersion 3.25.0 version-3.25.0
drh [Sat, 15 Sep 2018 04:01:47 +0000 (04:01 +0000)] 
Version 3.25.0

FossilOrigin-Name: b63af6c3bd33152742648d5d2e8dc5d5fcbcdd27df409272b6aea00a6f761760

6 years agoFix minor typos in comments that get carried over into documentation.
drh [Fri, 14 Sep 2018 17:42:47 +0000 (17:42 +0000)] 
Fix minor typos in comments that get carried over into documentation.
No changes to code.

FossilOrigin-Name: 7921dd91a1745aa79ea157b91b22c380e9331800050861ee6ca1f0efa0a97628

6 years agoUpdate releasetest.tcl to run "make test" as part of the "Fast-One"
dan [Thu, 13 Sep 2018 17:11:51 +0000 (17:11 +0000)] 
Update releasetest.tcl to run "make test" as part of the "Fast-One"
configuration.

FossilOrigin-Name: d5ebfe1c75d336dac374d9cfa257e45e77ab51f9c2f24d1af615cbbe9dd83d9b

6 years agoMake sure the %z optimization for printf() is not invoked if there has been
drh [Thu, 13 Sep 2018 17:07:12 +0000 (17:07 +0000)] 
Make sure the %z optimization for printf() is not invoked if there has been
a prior error (SQLITE_NOMEM or SQLITE_TOOBIG) associated with the same
printf() call.

FossilOrigin-Name: a2304a3474b0ca35eee0af64286ce2f7cb24d181323e128d5f04f7fe6e1c0980

6 years agoFix a requirement mark on a test script. No changes to code.
drh [Thu, 13 Sep 2018 13:17:14 +0000 (13:17 +0000)] 
Fix a requirement mark on a test script.  No changes to code.

FossilOrigin-Name: 628d5c0aa057c05c7cf84c330a51b8a44720c97250eadf0e5e8c750b7a2969c3

6 years agoFix an assert() in os_unix.c that is not true when using RBU.
dan [Wed, 12 Sep 2018 20:32:19 +0000 (20:32 +0000)] 
Fix an assert() in os_unix.c that is not true when using RBU.

FossilOrigin-Name: 028ed8618af012b51104a06cc155b45d98bc4ff833d4431b9c38fd6851a74e82

6 years agoRestrict the scope of internal-use functions in alter.c.
drh [Wed, 12 Sep 2018 15:51:56 +0000 (15:51 +0000)] 
Restrict the scope of internal-use functions in alter.c.

FossilOrigin-Name: 4396914f8e1a847d86c22fb0b91e7431cf19aa260cbec520af3564248d6897ad

6 years agoImprovements to the documentation for SQLITE_FCNTL_DATA_VERSION.
drh [Wed, 12 Sep 2018 14:28:45 +0000 (14:28 +0000)] 
Improvements to the documentation for SQLITE_FCNTL_DATA_VERSION.
No changes to code.

FossilOrigin-Name: 27837624336d2883f721310bd4dceedb77085d1008af5e12557f634936d48b8c

6 years agoFix an invalid pointer comparison triggered by renaming a table column when
dan [Wed, 12 Sep 2018 08:51:48 +0000 (08:51 +0000)] 
Fix an invalid pointer comparison triggered by renaming a table column when
there are views with explicit column names in the schema.

FossilOrigin-Name: 572de7e4e33562c72cd90790b267ba389370f21ddcaebc4db609fd76ae9b7ada

6 years agoFix some harmless compiler warnings seen with MSVC.
mistachkin [Wed, 12 Sep 2018 01:05:26 +0000 (01:05 +0000)] 
Fix some harmless compiler warnings seen with MSVC.

FossilOrigin-Name: 78862252da7f59d4737ed16f4ccf100cea27d8b421db31051afbaa8d96f24de3

6 years agoFor MSVC, migrate some commonly used shell compilation options to the library.
mistachkin [Wed, 12 Sep 2018 00:48:17 +0000 (00:48 +0000)] 
For MSVC, migrate some commonly used shell compilation options to the library.

FossilOrigin-Name: 68a71e5f4e9cbd15eb64d271008e29f40913480bac467b90fb64f0269ad75818

6 years agoFix a harmless compiler warning that arose from the ENABLE_CURSOR_HINTS
drh [Wed, 12 Sep 2018 00:21:11 +0000 (00:21 +0000)] 
Fix a harmless compiler warning that arose from the ENABLE_CURSOR_HINTS
fix of check-in [0af18674ca5b34e67e]

FossilOrigin-Name: f578e62ae6f6cc78d8281adab9fa93f3f58711879c2860bbe19f291d257dc0af

6 years agoDo not do the byte-by-byte modifications in the resetdb.test script if the
drh [Tue, 11 Sep 2018 19:05:32 +0000 (19:05 +0000)] 
Do not do the byte-by-byte modifications in the resetdb.test script if the
reserved-byte flag in the DB header is non-zero, because in that case the
bytes will be in the wrong place and the test won't work.

FossilOrigin-Name: 0af18674ca5b34e67e1685be3adcdd99a7b8650589c6a7cde7ad9ef1852a8777

6 years agoFix a problem causing ENABLE_CURSOR_HINTS builds to segfault.
dan [Tue, 11 Sep 2018 13:38:35 +0000 (13:38 +0000)] 
Fix a problem causing ENABLE_CURSOR_HINTS builds to segfault.

FossilOrigin-Name: e7033104fa8bd974a9a3d173200aa07a3aa3daade86e7eb65cad5d00b086969e

6 years agoFix a test script issue in fts3ao.test.
dan [Mon, 10 Sep 2018 19:34:06 +0000 (19:34 +0000)] 
Fix a test script issue in fts3ao.test.

FossilOrigin-Name: 74c381b573817d0212153278b5ee5d2238a27a727dcf7ee769365c47bb9fc40d

6 years agoFix a minor problem causing an incorrect cursor-hint to be generated in some
dan [Mon, 10 Sep 2018 19:27:12 +0000 (19:27 +0000)] 
Fix a minor problem causing an incorrect cursor-hint to be generated in some
cases.

FossilOrigin-Name: d879c47d7d145cbe99602b2cf70294ddc946709e8d61040942085d29e2c5b6cd

6 years agoAdd the ability for loadable extensions to access the new
drh [Mon, 10 Sep 2018 17:21:17 +0000 (17:21 +0000)] 
Add the ability for loadable extensions to access the new
sqlite3_create_window_function() interface.

FossilOrigin-Name: 3def6d8ef11702eb03ad56aeb01763ec8e4ca8ed3b570ffb680164c5c3679e4f

6 years agoFix a broken assert() in fts3.c.
dan [Mon, 10 Sep 2018 16:38:25 +0000 (16:38 +0000)] 
Fix a broken assert() in fts3.c.

FossilOrigin-Name: 564fa75195c5179d0bc86431aaff06136fc65ec63aa9839cd1114b1fbfac928b

6 years agoNew testcase() macros on virtual table xBestIndex logic.
drh [Mon, 10 Sep 2018 14:43:15 +0000 (14:43 +0000)] 
New testcase() macros on virtual table xBestIndex logic.

FossilOrigin-Name: 3bbd9c5f2f1990f7d187951474a86996650dcede12c2608484d43250ae0b30d6

6 years agoFix the LIKE optimization so that it is disabled when the LHS of the
drh [Mon, 10 Sep 2018 12:40:57 +0000 (12:40 +0000)] 
Fix the LIKE optimization so that it is disabled when the LHS of the
expression does not have TEXT affinity and the RHS is the pattern '/%'
or the RHS begins with the escape character. Fix for ticket
[c94369cae9b561b1f996d0054b].

FossilOrigin-Name: f191431d63aba187000b5cbaf3e072ff5f1b1eef6a2a407fb4d1629bda4e4e8f

6 years agoFix a problem with processing a "vtab.col IS NULL" expression within
dan [Mon, 10 Sep 2018 12:17:16 +0000 (12:17 +0000)] 
Fix a problem with processing a "vtab.col IS NULL" expression within
the WHERE clause of a query when "vtab" is a virtual table on the rhs of a
LEFT JOIN.

FossilOrigin-Name: 83da4d4104ee1870a2a95bb5fa15ee6584c655d8b314b6b8ab97592dad4ee811

6 years agoFix an unreachable branch in the new sqlite3WhereOrderByLimitOptLabel()
drh [Sat, 8 Sep 2018 20:29:04 +0000 (20:29 +0000)] 
Fix an unreachable branch in the new sqlite3WhereOrderByLimitOptLabel()
function of the query planner.

FossilOrigin-Name: 5a954533edbde58aa7158572ece7ceeb1c6e610b71f3ae45d0b8371d74f9fea5

6 years agoFix multiple issues with the ORDER BY LIMIT optimization. This is the
drh [Sat, 8 Sep 2018 20:09:46 +0000 (20:09 +0000)] 
Fix multiple issues with the ORDER BY LIMIT optimization.  This is the
proposed resolution to ticket [9936b2fa443fec03ff25].

FossilOrigin-Name: 206720129ed2fa8875a286266d05b99fb2caf8671e4b74b26a6286a2073fcd8b

6 years agoAdd a missing call to free() in Lemon.
mistachkin [Sat, 8 Sep 2018 16:55:18 +0000 (16:55 +0000)] 
Add a missing call to free() in Lemon.

FossilOrigin-Name: 8b4cf33aafe09d9009119dcbd464b54be9605af5701002ee458819efa6e2e1f9

6 years agoFix typo in the Win32-specific code for the fileio extension.
mistachkin [Sat, 8 Sep 2018 16:53:47 +0000 (16:53 +0000)] 
Fix typo in the Win32-specific code for the fileio extension.

FossilOrigin-Name: e812e5d59a699e8b82c51d465d9c0f09df6a1e6996b5499814dca99c5f8020d5

6 years agoRemove a faulty ALWAYS() macro added by check-in [8fa254aa6329bdd0].
drh [Fri, 7 Sep 2018 19:12:08 +0000 (19:12 +0000)] 
Remove a faulty ALWAYS() macro added by check-in [8fa254aa6329bdd0].

FossilOrigin-Name: fc47316e9b6b9f4c37cb7d3fe2af3f4dfb900fb5f07945dbf1239152a2d8f836

6 years agoAdd extra test case to altertab.test.
dan [Fri, 7 Sep 2018 18:56:31 +0000 (18:56 +0000)] 
Add extra test case to altertab.test.

FossilOrigin-Name: 64c3ee3c255e4630ccd5002116d66fd2af6b12dbdd4a3bee5ed413c3ef87d33a

6 years agoAdd assert() and ALWAYS() to identify two unreachable branches.
drh [Fri, 7 Sep 2018 18:52:25 +0000 (18:52 +0000)] 
Add assert() and ALWAYS() to identify two unreachable branches.

FossilOrigin-Name: 8fa254aa6329bdd085b8e2c78d8e8a698b418eda8b2d48e0082dd9cd428cef29

6 years agoFix a problem with renaming a non-temp table that has at least one temp
dan [Fri, 7 Sep 2018 15:50:31 +0000 (15:50 +0000)] 
Fix a problem with renaming a non-temp table that has at least one temp
trigger and shares its name with a temp table.

FossilOrigin-Name: ceb60bd7e5f2a0a4247bff476fc6468227305467339ae0c24591be9d2b14bdde

6 years agoMinor fixes for problems revealed by releasetest.tcl.
dan [Fri, 7 Sep 2018 11:51:21 +0000 (11:51 +0000)] 
Minor fixes for problems revealed by releasetest.tcl.

FossilOrigin-Name: 1a8aedc3376b7ae32fa7b2c367eedd483e2629908836efd10ee5bd1fe0784675

6 years agoFix an uninitialized variable in the OP_ParseSchema opcode that comes up
drh [Fri, 7 Sep 2018 11:08:31 +0000 (11:08 +0000)] 
Fix an uninitialized variable in the OP_ParseSchema opcode that comes up
only if the schema is corrupt.

FossilOrigin-Name: 725808d4c59176f71787452c7e500b563fd99cfc8ece47b1efe01d5e207efe0d

6 years agoIn all.test, do not attempt to run the RBU tests in non-RBU builds.
dan [Thu, 6 Sep 2018 20:33:11 +0000 (20:33 +0000)] 
In all.test, do not attempt to run the RBU tests in non-RBU builds.

FossilOrigin-Name: 10c3e5a0314470ee1ffc37b68445a2cb2054530346d5f5ed3ffbd6df8003cad0

6 years agoFix a harmless compiler warning in os_unix.c.
drh [Thu, 6 Sep 2018 19:36:29 +0000 (19:36 +0000)] 
Fix a harmless compiler warning in os_unix.c.

FossilOrigin-Name: b9d1fb5d44e0a6ffc00ee987f178e448d7516e579beecdeeb387e69aef588921

6 years agoFix a problem with ALTER TABLE when there are views or triggers in the schema
dan [Thu, 6 Sep 2018 18:56:36 +0000 (18:56 +0000)] 
Fix a problem with ALTER TABLE when there are views or triggers in the schema
that contain "<expr> IS NULL" expressions.

FossilOrigin-Name: 91aab32e71fcb924e24c02d5f0901f7a474760fc993a7e7436e667512cf5d3c3

6 years agoFix a problem in ALTER TABLE with SQLITE_OMIT_VIRTUALTABLE builds.
dan [Thu, 6 Sep 2018 17:47:09 +0000 (17:47 +0000)] 
Fix a problem in ALTER TABLE with SQLITE_OMIT_VIRTUALTABLE builds.

FossilOrigin-Name: fa835145e63749e06e04bd50ff992afaeae05dcdd1df597d13911f944e62076b

6 years agoFix test script problems causing SQLITE_OMIT_VIRTUALTABLE builds to fail.
dan [Thu, 6 Sep 2018 17:23:08 +0000 (17:23 +0000)] 
Fix test script problems causing SQLITE_OMIT_VIRTUALTABLE builds to fail.

FossilOrigin-Name: 37ad064e5f5704cf345d23b38b3f6d627fbcf20dbb78c8a91e96c9704760a1b8

6 years agoMerge accidental fork.
mistachkin [Thu, 6 Sep 2018 16:50:54 +0000 (16:50 +0000)] 
Merge accidental fork.

FossilOrigin-Name: ebadb7dc25b9ab544a941ceb9a18926268c21bb60de98737f6ef19915ee8e61a

6 years agoFix harmless compiler warning.
mistachkin [Thu, 6 Sep 2018 16:47:10 +0000 (16:47 +0000)] 
Fix harmless compiler warning.

FossilOrigin-Name: 88b39c46c15ab6bdd0ac9536ddb6fb09862d578d0f691c57d039b0a906f1c25c

6 years agoFix a problem causing SQLITE_OMIT_VIRTUALTABLE builds to fail.
dan [Thu, 6 Sep 2018 16:47:08 +0000 (16:47 +0000)] 
Fix a problem causing SQLITE_OMIT_VIRTUALTABLE builds to fail.

FossilOrigin-Name: 18beabc848d0ed7f5c918cbec5372a49915d889d7ffc9f475e6b208407e9ebd2

6 years agoAdd new test file "alterauth.test".
dan [Thu, 6 Sep 2018 16:24:23 +0000 (16:24 +0000)] 
Add new test file "alterauth.test".

FossilOrigin-Name: 00940265b18a3cf848602e1e0b3edbd935cb4309ef91a34b0d5746a258a47ae6

6 years agoAdd an "ALTER TABLE RENAME COLUMN" command. Upgrade "ALTER TABLE RENAME TABLE"
dan [Thu, 6 Sep 2018 16:20:09 +0000 (16:20 +0000)] 
Add an "ALTER TABLE RENAME COLUMN" command. Upgrade "ALTER TABLE RENAME TABLE"
so that it modifies references to the renamed table embedded in SQL view and
trigger definitions.

FossilOrigin-Name: 4da5998314ed2c694b0e242755930f5320af89ac5c148845392f0a2043d44d22

6 years agoMerge latest trunk changes into this branch. alter-table-rename-column
dan [Thu, 6 Sep 2018 16:17:22 +0000 (16:17 +0000)] 
Merge latest trunk changes into this branch.

FossilOrigin-Name: 8a28a326d7f72ab94c7d089dbc047e719038b6cd410068dec0d173a7655c87ca

6 years agoEnsure that the tbl_name column in the sqlite_temp_master table is updated
dan [Thu, 6 Sep 2018 16:01:37 +0000 (16:01 +0000)] 
Ensure that the tbl_name column in the sqlite_temp_master table is updated
correctly as part of a RENAME TABLE operation.

FossilOrigin-Name: ffecfca511718e39e0003b380d5113755b8a11405a5bd80cc04503d9557f0842

6 years agoAdd the randomshape.tcl test-case generator script to the util subdirectory
drh [Thu, 6 Sep 2018 14:01:56 +0000 (14:01 +0000)] 
Add the randomshape.tcl test-case generator script to the util subdirectory
of the rtree extension.

FossilOrigin-Name: 8f48991dcbb01e21d065fbba7782a6d1aebaa8065841a70a76af1e5a21f18ea4

6 years agoFix excess memory usage in the JSON parser of GEOPOLY.
drh [Thu, 6 Sep 2018 11:14:17 +0000 (11:14 +0000)] 
Fix excess memory usage in the JSON parser of GEOPOLY.

FossilOrigin-Name: 9057e27e12ded07a9ea0b2868036d3019f7bc5be3a67e3d341f56b762d3de9d9

6 years agoFix a problem with geopoly trying to update both the _shape and an auxiliary
drh [Thu, 6 Sep 2018 02:40:15 +0000 (02:40 +0000)] 
Fix a problem with geopoly trying to update both the _shape and an auxiliary
column in the same UPDATE statement.

FossilOrigin-Name: 14c955152d0580abc3df1b363789f2925e013b9c957e550b1e6ebe83a82bae6c

6 years agoMerge latest trunk changes into this branch.
dan [Wed, 5 Sep 2018 17:52:52 +0000 (17:52 +0000)] 
Merge latest trunk changes into this branch.

FossilOrigin-Name: 6f4f707f9c3c29f2437962fd5d7761876cf8e7ed7fdcb9d0ca4fd001fa226597

6 years agoFix some test script errors. And an incorrect assert() in fts5.
dan [Wed, 5 Sep 2018 17:45:17 +0000 (17:45 +0000)] 
Fix some test script errors. And an incorrect assert() in fts5.

FossilOrigin-Name: f804336f083d8d26314bb1ba34cec427675065a67cbe2bf00bb42e40752aeb33

6 years agoRemove an old testcase() macro that is no longer valid.
drh [Wed, 5 Sep 2018 16:16:56 +0000 (16:16 +0000)] 
Remove an old testcase() macro that is no longer valid.

FossilOrigin-Name: e628713338f6e584a32d5fc3436ddbd9ee8cf88401c321c1ebe7daa1e695c623

6 years agoAvoid comparing pointer values after the object that they point to has been
dan [Wed, 5 Sep 2018 14:36:05 +0000 (14:36 +0000)] 
Avoid comparing pointer values after the object that they point to has been
deleted.

FossilOrigin-Name: 2ec7e50cbc0e7a4308d51be3c9416229b187a6a8abdd982c154edc256cd6da1f

6 years agoFix minor code issues in alter.c.
dan [Wed, 5 Sep 2018 08:28:30 +0000 (08:28 +0000)] 
Fix minor code issues in alter.c.

FossilOrigin-Name: 18ba35b86f3b9813179b5f8d74e59e4860bfb800f45aabab8d6c0a6d7c97fe74

6 years agoMerge latest trunk changes into this branch.
dan [Tue, 4 Sep 2018 18:23:59 +0000 (18:23 +0000)] 
Merge latest trunk changes into this branch.

FossilOrigin-Name: ef9e088290efa9d0fc36bcdef710cadfef37c8a33f4685dad4ce113807e1cc75

6 years agoImprove the error messages emitted by RENAME TABLE.
dan [Mon, 3 Sep 2018 20:05:15 +0000 (20:05 +0000)] 
Improve the error messages emitted by RENAME TABLE.

FossilOrigin-Name: 6805b5900df5e6d3329cbad2660875ebe4069efe37b19575f527d153dc0882a1

6 years agoEnsure that FTS5 queries of the form "WHERE rowid BETWEEN ? AND ? AND tbl
dan [Mon, 3 Sep 2018 17:11:11 +0000 (17:11 +0000)] 
Ensure that FTS5 queries of the form "WHERE rowid BETWEEN ? AND ? AND tbl
MATCH ? ORDER BY rank" do rowid filtering before sorting.

FossilOrigin-Name: f1138a38bd23f201a35621a71e82c5718abddb42ab82938e9516ab9d43e4df16