build: bump cross-platform-actions/action from 0.27.0 to 0.28.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.27.0 to 0.28.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.27.0...v0.28.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-version: 0.28.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

lib/cpp: Fix memory leaks in LldpCtl

LldpCtl::GetInterfaces() and LldpAtom::GetAtomList() did not decrement ref for retrieved atoms
Ensure parent atom outlives its children atoms

lib/cpp: LldpCtl supports non default transports

added optional arg to lldpd unix socket for constructor

doc: add entry in NEWS for previous commit

daemon/priv: fix PACKET_IGNORE_OUTGOING

Switch from netpacket/packet.h to linux/if_packet.h to pick up both
sockaddr_ll and PACKET_IGNORE_OUTGOING.

Fixes case where PACKET_IGNORE_OUTGOING was compiled out due to ifdef
conditional, which caused Linux zerocopy to break.

Fixes #732

Signed-off-by: Jon Kohler <jon@nutanix.com>

build: bump cachix/install-nix-action from 30 to 31

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 30 to 31.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v30...v31)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-version: '31'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: Fix macos compile warning on macos >= 12

dmi-osx.c:37:40: warning: 'kIOMasterPortDefault' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
        service = IOServiceGetMatchingService(kIOMasterPortDefault, matching);
                                              ^~~~~~~~~~~~~~~~~~~~
                                              kIOMainPortDefault

man: clarify what the power class numbers mean for 802.3at, in dot3

man: Amend keyword colour formatted as operations and not values.

comment cleanup and spelling fixes

differentiate between setup(n) and set(v) up

daemon: fix typo in comment

Add UnregisterInterfaceCallback

SetValue: Add various string-like type support

add more missing syscalls to seccomp profile

it turned out, adding just clock_gettime64()
from #710 has not been enough for ia32 platform.

iteratively added additional syscalls, that
prevented lldpd from starting up without
bailing out with SIGSYS

build: bump cross-platform-actions/action from 0.26.0 to 0.27.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.26.0 to 0.27.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.26.0...v0.27.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

daemon: add clock_gettime64 to seccomp profile

Fix #710

debian: also install C++ header in Debian package

fix: Add lldpctl.hpp to the include list

build: bump cross-platform-actions/action from 0.25.0 to 0.26.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.25.0 to 0.26.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.25.0...v0.26.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

lib: fix warning about uninitialized variable

This is not really the case, but older compilers may not be able to
detect there is no branch when this variable is uninitialized.

build: remove hacks around NetSNMP

The workaround for -D_FORTIFY_SOURCE was failing on Fedora because it
was not robust enough. The current version was tested with:

- Fedora 41
- Debian 10
- Ubuntu Trusty (14.04)
- CentOS 7

release: 1.0.19

doc: finalize changelog

lib: format *.hpp as well

feat: Add lldpctl C++ wrapper (#693)

* feat: Add lldpctl C++ wrapper

* fix: Call the new lldpctl_watch_sync_unblock() on watch termination

* fix: Category name

client: fix global tx hold and interval setting

In the following fixed commit, I forgot to fix the transmission (tx) hold
and interval range in the global configuration setting.

Fixes: 7b9abb819337 ("client: add range restriction for tx hold and interval")
Reported-by: Fei Liu <feliu@redhat.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

lldpd: fix ttl range on ports

In the following fixed commit, I forgot to fix the ttl range for
interfaces/ports.

Fixes: a73e04f46ebe ("lldpd: limit tx ttl to 65535")
Reported-by: Fei Liu <feliu@redhat.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

daemon: use code from sd_notify(3) for handling notify socket

This also fixes a compilation error about connect().

lib: fix formatting

lib: bump library version

Also fix versioning of lldpctl_watch_sync_unblock. And add a NEWS entry.

docs: add an entry for change about AppArmor

feat: Add lldpctl_watch_sync_unblock (#696)

* feat: Add lldpctl_watch_sync_unblock

* update: Replace select by epoll

* refactor: Replace epoll by poll to support non-Linux OS

* update: Let lldpcli terminate gracefully

fix: Typo

build: bump cachix/install-nix-action from 29 to 30

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 29 to 30.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v29...v30)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

fix: add socket lock to AppArmor policy

build: query pkg-config for readline/libedit/libeditline

Fix #686

sonmp: convert deprecated inet_ntoa to inet_ntop

inet_ntoa has been marked as deprecated. Let's convert it to inet_ntop.

Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

build: stop using apheleia for C code

Related to faee60497260.

build: don't enforce style

clang-format is a pain with behaviour depending on the version...

daemon: revert latest style change

daemon: do not query PHY for a down interface on Linux

It may wake up the device.

Fix #685

fix endless loop in redefined malloc/remalloc functions on system using uClibc

build: use environment variables to configure pip

Otherwise, it may or may not work depending on the version of pip...

build: use Ubuntu 22.04

Can't fix everything right now...

daemon: fix formatting with clang-format

Revert "build: try to build SNMP with --base-lib-cflags"

This reverts commit 3e3ba6e8dd93b2adf6a46b6345e7ff2f3ae7f962. This does
not work as it also includes -D_FORTIFY_SOURCE=x...

daemon: fix usage of calloc

First argument is the number of elements to allocate.

build: try to build SNMP with --base-lib-cflags

In the past, this was not working correctly. Let's see if the situation
has improved.

build: remove -D_FORTIFY_SOURCE= from NetSNMP CFLAGS

This is really a pain...

build: allow pip to install packages system-wide

build: bump cachix/install-nix-action from 26 to 29

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 26 to 29.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v26...v29)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: run cross-platforms test on ubuntu-latest

MacOS and Xhyve are deprecated. See:
https://github.com/cross-platform-actions/action/blob/HEAD/changelog.md#0250---2024-07-11

build: bump cross-platform-actions/action from 0.24.0 to 0.25.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.24.0 to 0.25.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.24.0...v0.25.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

build: run clang-format

lldpd: limit tx ttl to 65535

Based on IEEE 802.1AB(2016) 9.2.5.22 txTTL:
  During normal operation, txTTL is set to whichever is the smaller of the
  values represented by Equation (1) and Equation (2):
      (msgTxInterval x msgTxHold) + 1   (1)
      65535                             (2)

Reported-by: Matt Lucius <malucius@redhat.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

client: add range restriction for tx hold and interval

Based on IEEE 802.1AB(2016) 9.2.5. The valid range of tx hold is 1-100,
the valid range of tx interval is 1-3600.

Reported-by: Matt Lucius <malucius@redhat.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

build: bump docker/build-push-action from 5 to 6

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5 to 6.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](https://github.com/docker/build-push-action/compare/v5...v6)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Be more defensive when parsing PRETTY_NAME out of os-release

Test the result of `strtok(..)` to ensure that the line being parsed has
an `=` sign in it. This addresses a potential crash due to a NULL
pointer dereference.

Reported by: Coverity
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>

priv: disable LLDP in firmware for Intel X7xx cards on FreeBSD

build: fix inclusion of editline/readline.h

build: also test for editline/readline.h

client: provide a working prototype for readline()

osx: multiarch install package

osx: fix package build on Apple Silicon

build: use FreeBSD 13.3

build: run BSD tests on macos-12

No nested virtualization allowed for macos-14.

docs: in NEWS, mention extra capabilities

build: bump cross-platform-actions/action from 0.23.0 to 0.24.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.23.0 to 0.24.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.23.0...v0.24.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Extra capabilities bitflags and configurability.
No attempt is made to detect such functionality yet.

docs: fix spacing for code blocks

Docs (#657)

* README.md improvements

* sp

Fix macos warnings at compile time.

If this happens:

lldpd.c:1577:14: warning: variable 'pidfile' set but not used [-Wunused-but-set-variable]
        const char *pidfile = LLDPD_PID_FILE;

Then the other places using pidfile should get the same ifndef treatment

Document default behaviour for these advertisements.

oui-info format description: shall

lib: Fix a buffer underflow in _lldpctl_dump_in_atom

Do not write a zero byte before the beginning of the buffer when
_lldpctl_dump_in_atom is called with a zero length atom.

interfaces: "fix" style issue in latest commit

Depending on the version of clang, we may get different result. This is
annoying, but no time to fix that now.

interfaces: don't use wireless extensions

Fix #579

daemon: rework a bit systemd support

Use connect() as done by other implementations, notably the one in
sd_notify(2). Also add a check on socket length.

build: bump softprops/action-gh-release from 1 to 2

Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](https://github.com/softprops/action-gh-release/compare/v1...v2)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cachix/install-nix-action from 25 to 26

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 25 to 26.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v25...v26)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: use pytest-forked to replace boxed feature from xdist

This is needed because of the code switching from one namespace to
another.

build: don't use boxed feature of xdist

It has been removed from 3.0. This could be replaced by pytest-forked if
needed. I don't really remember why I was using that (I suppose it was
to avoid segfaults, due maybe to ctypes?).

build: disable gold linker in CI

This should not be needed anymore nowadays. This is a tentative to fix
the following errors with clang:

    /usr/bin/ld.gold: warning: Cannot export local symbol '__asan_check_load_add_16_RAX'

client: spell fix

docs: man page fixes

build: bump cachix/install-nix-action from 24 to 25

Bumps [cachix/install-nix-action](https://github.com/cachix/install-nix-action) from 24 to 25.
- [Release notes](https://github.com/cachix/install-nix-action/releases)
- [Commits](https://github.com/cachix/install-nix-action/compare/v24...v25)

---
updated-dependencies:
- dependency-name: cachix/install-nix-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cross-platform-actions/action from 0.22.0 to 0.23.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.22.0 to 0.23.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.22.0...v0.23.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

docs: man page fixes

changed: network cable -> link

change -M help text in src/daemon/lldpd.c also

osx: update Brew formula

redhat: suppress extra .la file we don't want to install

redhat: fix date in changelog

release: 1.0.18

There is a small regression in support for 802.3BT. People should keep
using 1.0.17 if that's important for them.

build: bump actions/download-artifact from 3 to 4

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

build: bump cross-platform-actions/action from 0.21.1 to 0.22.0

Bumps [cross-platform-actions/action](https://github.com/cross-platform-actions/action) from 0.21.1 to 0.22.0.
- [Release notes](https://github.com/cross-platform-actions/action/releases)
- [Changelog](https://github.com/cross-platform-actions/action/blob/master/changelog.md)
- [Commits](https://github.com/cross-platform-actions/action/compare/v0.21.1...v0.22.0)

---
updated-dependencies:
- dependency-name: cross-platform-actions/action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

daemon/netlink: fix documentation string

daemon/netlink: use a different socket for changes and queries

There is a race condition when using the same socket for both. We need
to subscribe for changes before getting the current state as we don't
want to miss an update happening while we get the initial state, but if
there is such an update, the Netlink messages we receive may not be the
ones we expect.

Fix #611

compat: add compat.h header to get forward declarations

daemon/priv: no need to define IFALIASZ

It is part of the shipped kernel header. This is a bit odd we did define
it...