views: Switch logout to POST

This was deprecated in 4.1 and removed in 5.0. I missed it.

[1] https://docs.djangoproject.com/en/5.0/releases/4.1/#features-deprecated-in-4-1

Signed-off-by: Stephen Finucane <stephen@that.guru>
(cherry picked from commit 45f47e96c6c90aefac37b02e0e15052f6ba41a90)

css: make diff colors more accessible

The colors used to display patch diffs are confusing. The context color
is very similar to the added line color and the contrast between added
and removed lines is very low.

Originally, the choice of purple/blue (instead of the more common
red/green palette) may have been made with colorblindness accessibility
in mind. However, after inspecting the current colors with
colorblindness "simulators", I found that the low contrast was
consistent no matter what vision deficiency (if any) you might have.

Update the colors to use a more common red/green palette. Add background
colors to increase contrast for colorblind people. Use less confusing
colors for context and diff hunks. Use normal line height to prevent
background colors from overlapping. Use a different color for email
quotes (blue) to avoid confusion with added lines.

I have made a compilation of the current and updated color palette
previews for normal vision and all common color deficiencies. I also
included the same diff as seen from Github interface for reference.

Link: http://files.diabeteman.com/patchwork-diff-colors/
Signed-off-by: Robin Jarry <robin@jarry.cc>
(cherry picked from commit c443cd9c0e96ca21842a188f9101b1a8244535ee)

tests: Dump more info if version test fails

Signed-off-by: Stephen Finucane <stephen@that.guru>
(cherry picked from commit fa14cf8480d9e515ed7a769adbd9eab33c6d82d9)

CI: Cancel builds upon a new push

Signed-off-by: Stephen Finucane <stephen@that.guru>
(cherry picked from commit 09939ba107bde85e0b9df35c0dbbf90428789a94)

Fix version.txt

Fixes: b2374a06 ("Post-release version bump")
Signed-off-by: Stephen Finucane <stephen@that.guru>

Post-release version bump

Signed-off-by: Stephen Finucane <stephen@that.guru>

Release 3.2.1

Signed-off-by: Stephen Finucane <stephen@that.guru>

templates/submission: Fix alignment of commit message

Preformatted content must not be indented
because any space is kept in the output,
making the content wrongly indented.

When aligning message headers to the left,
the new HTML code has been indented
including some preformatted content indented with two spaces.

The fix is to remove the indent of the content.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Fixes: fe34ab2ffad3 ("patch-detail: left align message headers")
Reviewed-by: Robin Jarry <robin@jarry.cc>
Reviewed-by: Stephen Finucane <stephen@that.guru>
(cherry picked from commit 13bbc0d94ea035c149f8acd042d2998778b9efd9)

docker: Update tag

This will need to be part of our release procedure going forward.

Signed-off-by: Stephen Finucane <stephen@that.guru>

Release 3.2.0

Another smaller release, this time with no new API versions.

Signed-off-by: Stephen Finucane <stephen@that.guru>

docs: Update release note to reflect timelines

Signed-off-by: Stephen Finucane <stephen@that.guru>

dependabot: Manage GitHub Action workflows also

Signed-off-by: Stephen Finucane <stephen@that.guru>

dependabot: Ignore (most) patch update

Signed-off-by: Stephen Finucane <stephen@that.guru>

docker-compose: Remove version

This is obsolete, apparently.

Signed-off-by: Stephen Finucane <stephen@that.guru>

requirements: Bump versions

We also add a release note for the Django version bump. We should have
done both in commit 5e2f3b8c0c.

Signed-off-by: Stephen Finucane <stephen@that.guru>

Add Python 3.13 support

Signed-off-by: Stephen Finucane <stephen@that.guru>

requirements: Bump Django to 5.1.x, django-filter to 24.3.0

Signed-off-by: Stephen Finucane <stephen@that.guru>

Drop Python 3.8 support

We also add a release note for Python 3.12 support.

Signed-off-by: Stephen Finucane <stephen@that.guru>

pre-commit: Bump versions

Signed-off-by: Stephen Finucane <stephen@that.guru>

CI: docker-compose -> docker compose

Per [1].

[1] https://github.com/orgs/community/discussions/116610

Signed-off-by: Stephen Finucane <stephen@that.guru>

build(deps): update sqlparse requirement from ~=0.5.0 to ~=0.5.1

Updates the requirements on [sqlparse](https://github.com/andialbrecht/sqlparse) to permit the latest version.
- [Changelog](https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG)
- [Commits](https://github.com/andialbrecht/sqlparse/compare/0.5.0...0.5.1)

---
updated-dependencies:
- dependency-name: sqlparse
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

build(deps-dev): update django-debug-toolbar requirement

Updates the requirements on [django-debug-toolbar](https://github.com/jazzband/django-debug-toolbar) to permit the latest version.
- [Release notes](https://github.com/jazzband/django-debug-toolbar/releases)
- [Changelog](https://github.com/jazzband/django-debug-toolbar/blob/main/docs/changes.rst)
- [Commits](https://github.com/jazzband/django-debug-toolbar/compare/4.4...4.4.6)

---
updated-dependencies:
- dependency-name: django-debug-toolbar
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

build(deps): update mysqlclient requirement from ~=2.2.0 to ~=2.2.4

Updates the requirements on [mysqlclient](https://github.com/PyMySQL/mysqlclient) to permit the latest version.
- [Release notes](https://github.com/PyMySQL/mysqlclient/releases)
- [Changelog](https://github.com/PyMySQL/mysqlclient/blob/main/HISTORY.rst)
- [Commits](https://github.com/PyMySQL/mysqlclient/compare/v2.2.0...v2.2.4)

---
updated-dependencies:
- dependency-name: mysqlclient
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

build(deps): update openapi-core requirement from ~=0.19.0 to ~=0.19.2

Updates the requirements on [openapi-core](https://github.com/python-openapi/openapi-core) to permit the latest version.
- [Release notes](https://github.com/python-openapi/openapi-core/releases)
- [Commits](https://github.com/python-openapi/openapi-core/compare/0.19.0...0.19.2)

---
updated-dependencies:
- dependency-name: openapi-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

pre-commit: Everything in Python 3 now

No need to set the default Python version.

Signed-off-by: Stephen Finucane <stephen@that.guru>

build(deps): update psycopg2-binary requirement from ~=2.9.0 to ~=2.9.9

Updates the requirements on [psycopg2-binary](https://github.com/psycopg/psycopg2) to permit the latest version.
- [Changelog](https://github.com/psycopg/psycopg2/blob/master/NEWS)
- [Commits](https://github.com/psycopg/psycopg2/compare/2.9.6...2.9.9)

---
updated-dependencies:
- dependency-name: psycopg2-binary
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

build(deps): update django requirement from ~=5.0.0 to ~=5.0.7

Updates the requirements on [django](https://github.com/django/django) to permit the latest version.
- [Commits](https://github.com/django/django/compare/5.0...5.0.7)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

build(deps): update psycopg2 requirement from ~=2.9.0 to ~=2.9.9

Updates the requirements on [psycopg2](https://github.com/psycopg/psycopg2) to permit the latest version.
- [Changelog](https://github.com/psycopg/psycopg2/blob/master/NEWS)
- [Commits](https://github.com/psycopg/psycopg2/compare/2.9.6...2.9.9)

---
updated-dependencies:
- dependency-name: psycopg2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Remove unused import

Signed-off-by: Stephen Finucane <stephen@that.guru>

requirements: Bump various libraries

djangorestframework, django-filter, django-debug-toolbar, sqlparse,
python-dateutil and openapi-core all have updates.

The only change here is, yet again, openapi-core related, as we swap out
a deprecated API with its replacement.

Signed-off-by: Stephen Finucane <stephen@that.guru>

docker: Make .env file optional

I now have a standard UID and GID of 1000, making this file unnecessary.

Signed-off-by: Stephen Finucane <stephen@that.guru>

pre-commit: Bump versions

Signed-off-by: Stephen Finucane <stephen@that.guru>

trivial: Prepare for ruff bump

Signed-off-by: Stephen Finucane <stephen@that.guru>

typo fix

openapi: Add path descriptions

These are a little more detailed than the summaries.

Signed-off-by: Stephen Finucane <stephen@that.guru>

openapi: Set summary for paths

This shows up in e.g. reDoc, while the description does not. We will add
more detailed descriptions later.

Signed-off-by: Stephen Finucane <stephen@that.guru>

openapi: Fix issues with events API

The previous_delegate and current_delegate fields are nullable.

Signed-off-by: Stephen Finucane <stephen@that.guru>

openapi: Add more descriptions

Signed-off-by: Stephen Finucane <stephen@that.guru>

openapi: Add tag definitions

Signed-off-by: Stephen Finucane <stephen@that.guru>

openapi: Add component descriptions

Signed-off-by: Stephen Finucane <stephen@that.guru>

openapi: Correct security definition

It's not using bearer token format.

Signed-off-by: Stephen Finucane <stephen@that.guru>

openapi: Consistent wrapping

Signed-off-by: Stephen Finucane <stephen@that.guru>

openapi: Remove trailing slashes

Signed-off-by: Stephen Finucane <stephen@that.guru>

tox: Add tox-gh-actions config for Python 3.12

Signed-off-by: Stephen Finucane <stephen@that.guru>

CI: Set up go

Needed for the vacuum pre-commit hook.

Signed-off-by: Stephen Finucane <stephen@that.guru>

pre-commit: Switch to ruff

Signed-off-by: Stephen Finucane <stephen@that.guru>

trivial: Apply ruff fixes

Signed-off-by: Stephen Finucane <stephen@that.guru>

Replace use of datetime.datetime.utcfromtimestamp()

This is deprecated in Python 3.12.

Signed-off-by: Stephen Finucane <stephen@that.guru>

Replace use of datetime.datetime.utcnow()

This is deprecated in Python 3.12.

Signed-off-by: Stephen Finucane <stephen@that.guru>

ci: Add Python 3.12 support

Signed-off-by: Stephen Finucane <stephen@that.guru>

requirements: Bump Django to 5.x.x, django-filter to 23.5.0

One issue to address, which is caused by changes in Django commit
500e01073ad [1].

We also drop support for Django 3.2, which goes EOL in April 2024, and
Django 4.1, which already went EOL in December 2023.

[1] https://github.com/django/django/commit/500e01073ad

Signed-off-by: Stephen Finucane <stephen@that.guru>

pre-commit: Add vacuum

Lint our OpenAPI specs.

Signed-off-by: Stephen Finucane <stephen@that.guru>

pre-commit: Bump versions

Signed-off-by: Stephen Finucane <stephen@that.guru>

templates/submission: add button to copy the message ID to clipboard

Add an icon alongside the message ID to copy the message ID to the
clipboard, to ease integration with eg b4.

Signed-off-by: Ross Burton <ross.burton@arm.com>

templates/base: generalise clipbboardjs initialisation

Don't limit the clipboardjs hooking to button.btn-copy, as we may want
to use it on icons which are not buttons.

Signed-off-by: Ross Burton <ross.burton@arm.com>

templates/submission: remove duplication when writing the Message ID

The output is identical, but this removes the duplication of the Message
ID itself in the source.

Signed-off-by: Ross Burton <ross.burton@arm.com>

Upgrade to Bootstrap 3.4.1

Upgrade Bootstrap to 3.3.7

Fix docker apt install requirements

Add pkg-config dependency install for docker images. this is required
later on for mysql inside the container.

docs: Replace hyperlink with doc role

Signed-off-by: Stephen Finucane <stephen@that.guru>

readthedocs: Switch back to DirHTML builder

Looks like this got lost in the switch to the '.readthedocs.yaml'
configuration file.

Signed-off-by: Stephen Finucane <stephen@that.guru>

readthedocs: Fetch all branches

Third time lucky. As this is configured, we were only fetching the main
branch. Correct this.

Signed-off-by: Stephen Finucane <stephen@that.guru>

readthedocs: Also fetch all other branches

'stable/2.0' is a branch, not a tag.

Signed-off-by: Stephen Finucane <stephen@that.guru>

readthedocs: Also fetch tags

Signed-off-by: Stephen Finucane <stephen@that.guru>

docs: Add note about 'series' querystring arg to api-ref

Signed-off-by: Stephen Finucane <stephen@that.guru>

docs: Switch back to RTD theme

The furo theme needs more work than originally expected, and
sphinx-rtd-theme now supports Sphinx 7.

Signed-off-by: Stephen Finucane <stephen@that.guru>

tools: Add helper script to backup, restore DB

This is handier than doing it via Django and works for my simple,
local-only workflow.

Signed-off-by: Stephen Finucane <stephen@that.guru>

pre-commit: Updates

Signed-off-by: Stephen Finucane <stephen@that.guru>

tests: Remove use of deprecated method

Resolve the following warning:

  RemovedInDjango51Warning: BaseUserManager.make_random_password() is
  deprecated.

Signed-off-by: Stephen Finucane <stephen@that.guru>

tests: Add coloured runner

This is nicer to work with than a wall of red text.

Signed-off-by: Stephen Finucane <stephen@that.guru>

Remove filter for openapi-core

Effectively revert commit 4ddcdea4: the PR referenced merged a long time
ago.

Signed-off-by: Stephen Finucane <stephen@that.guru>

requirements: Bump openapi-core

Another slog. The joys of pre-v1.0.0 libraries!

Signed-off-by: Stephen Finucane <stephen@that.guru>

requirements: Bump mysqlclient to 2.1.x

Signed-off-by: Stephen Finucane <stephen@that.guru>

requirements: Unpin tblib

Shouldn't have merged the pyup bot proposed change.

Signed-off-by: Stephen Finucane <stephen@that.guru>

Pin tblib to latest version 2.0.0

requirements: Bump django-debug-toolbar to 4.1.x

Signed-off-by: Stephen Finucane <stephen@that.guru>

pyup: Don't pin unpinned dependencies

Signed-off-by: Stephen Finucane <stephen@that.guru>

Configure dependabot

lib: add missing permissions for patchwork_covercomment_id_seq

Grants UPDATE and SELECT privileges on patchwork_covercomment_id_seq table
for user 'nobody' to fix the following exception when cover comments
are being parsed:
django.db.utils.ProgrammingError: permission denied for sequence
  patchwork_covercomment_id_seq

Signed-off-by: Ali Alnubani <alialnu@nvidia.com>

lib: add missing permissions for patchwork_cover_id_seq

Grants UPDATE and SELECT privileges on patchwork_cover_id_seq table
for user 'nobody' to fix the following exception when cover letters
are being parsed:
django.db.utils.ProgrammingError: permission denied for sequence
  patchwork_cover_id_seq

Signed-off-by: Ali Alnubani <alialnu@nvidia.com>

urls: Also decode slashes in message IDs

In commit 2653fdbb2, we started encoding slashes in message IDs
presented to users. This allowed us to support message IDs containing
slashes, which are allowed per the RFC and have been seen in the wild.
However, we continue to store the original unencoded message IDs in the
database and unfortunately we neglected to reverse the decoding in the
functions for downloading patch diffs and mboxes. Address this now.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Fixes: 2653fdbb2 ("urls: Encode slashes in message IDs")
Closes: #518
Cc: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: DJ Delorie <dj@delorie.com>

Drop Python 3.7 support

Signed-off-by: Stephen Finucane <stephen@that.guru>

tox: Remove redundant environments

These were not being used.

Signed-off-by: Stephen Finucane <stephen@that.guru>

tox: Use pre-commit for pep8 environment

Avoid duplication.

Signed-off-by: Stephen Finucane <stephen@that.guru>

pre-commit: Reorder

Place faster checks first.

Signed-off-by: Stephen Finucane <stephen@that.guru>

pre-commit: Add bashate

Signed-off-by: Stephen Finucane <stephen@that.guru>

Rewrap some bash

Keep bashate happy.

Signed-off-by: Stephen Finucane <stephen@that.guru>

Bump pre-commit versions

Signed-off-by: Stephen Finucane <stephen@that.guru>

tests: Address flake8 issue

Signed-off-by: Stephen Finucane <stephen@that.guru>

docs: Switch to furo theme

The sphinx-rtd-theme theme is not compatible with Sphinx 7.x yet.

Signed-off-by: Stephen Finucane <stephen@that.guru>

readthedocs: Specify requirements

Signed-off-by: Stephen Finucane <stephen@that.guru>

readthedocs: Specify OS, tools

This is required. The error message is misleading [1].

[1] https://github.com/readthedocs/readthedocs.org/issues/8912

Signed-off-by: Stephen Finucane <stephen@that.guru>

Add readthedocs config file

We need this to maintain our docs build, which won't work with shallow
clones.

Signed-off-by: Stephen Finucane <stephen@that.guru>

lib: add missing permissions for patchwork_comment_id_seq

Grants UPDATE and SELECT privileges on patchwork_comment_id_seq table
for web and mail users to fix the following exception when comments
are parsed:
django.db.utils.ProgrammingError: permission denied for sequence
  patchwork_comment_id_seq

Fixes: 5b53f46def5f ("lib: fix table names")
Signed-off-by: Ali Alnubani <alialnu@nvidia.com>

tests: Always enable REST API

This means django-rest-framework is now a hard requirement for unit
tests. That seems reasonable.

Signed-off-by: Stephen Finucane <stephen@that.guru>

tests: Always enable XML-RPC API

Signed-off-by: Stephen Finucane <stephen@that.guru>

templates: Use REST API backend for pwclientrc

If the REST API is enabled, we should generate a pwclientrc file that
uses it by default.

Signed-off-by: Stephen Finucane <stephen@that.guru>

trivial: Move test file

Signed-off-by: Stephen Finucane <stephen@that.guru>

requirements: Bump django-debug-toolbar to 4.0.x

Signed-off-by: Stephen Finucane <stephen@that.guru>

Validate email address in from_header

Resolves #512

Signed-off-by: Nisha Poyarekar <nisha.s.menon@gmail.com>