]>
git.ipfire.org Git - thirdparty/pdns.git/log
Remi Gacogne [Mon, 19 Apr 2021 10:28:55 +0000 (12:28 +0200)]
auth: Small cleanup in SimpleMatch
Remi Gacogne [Mon, 19 Apr 2021 10:18:50 +0000 (12:18 +0200)]
auth: Prevent dereferencing std::string::end() in SimpleMatch
SimpleMatch is called with user-supplied strings in the API and the
bind backend. We might get away with it in most cases because
std::strings are null-terminated, but it's still undefined behaviour
as there is no guarantee that end() will point to the terminator.
Reported by cppcheck 2.4.1:
```
misc.hh:501:16: warning: Either the condition 'mi==d_mask.end()' is redundant or there is possible dereference of an invalid iterator: mi. [derefInvalidIteratorRedundantCheck]
while(*mi == '*') ++mi;
^
misc.hh:502:16: note: Assuming that condition 'mi==d_mask.end()' is not redundant
if (mi == d_mask.end()) return true;
^
misc.hh:501:16: note: Dereference of an invalid iterator
while(*mi == '*') ++mi;
```
Otto Moerbeek [Fri, 16 Apr 2021 14:16:13 +0000 (16:16 +0200)]
Merge pull request #10298 from phonedph1/patch-26
rec: print the covering NSEC
Remi Gacogne [Fri, 16 Apr 2021 13:52:27 +0000 (15:52 +0200)]
Merge pull request #10274 from rgacogne/ddist-tsan-fixes
dnsdist: Fix some issues reported by Thread Sanitizer
Peter van Dijk [Fri, 16 Apr 2021 13:52:20 +0000 (15:52 +0200)]
Merge pull request #10301 from Habbie/rec-docs-faq-bufsize-bis
two more comments from Otto on recursor FAQ entry about bufsizes
Otto Moerbeek [Fri, 16 Apr 2021 09:52:18 +0000 (11:52 +0200)]
Merge pull request #10300 from omoerbeek/rec-docs-thruth
Rec: recursor is actually a pretty complex piece of code
Peter van Dijk [Fri, 16 Apr 2021 09:15:14 +0000 (11:15 +0200)]
two more comments from Otto on this text
Peter van Dijk [Fri, 16 Apr 2021 09:04:38 +0000 (11:04 +0200)]
Merge pull request #10296 from Habbie/rec-docs-faq-bufsize
start off recursor FAQ with some talk about EDNS bufsizes
Otto Moerbeek [Fri, 16 Apr 2021 08:50:51 +0000 (10:50 +0200)]
escape *
Otto Moerbeek [Fri, 16 Apr 2021 08:30:04 +0000 (10:30 +0200)]
Merge pull request #10299 from phonedph1/patch-27
rec: update setting for aggressive-nsec-cache-size
Otto [Fri, 16 Apr 2021 08:28:11 +0000 (10:28 +0200)]
Avoid lines counts and be more honest: rec is a big and complex piece
of code.
Remi Gacogne [Thu, 15 Apr 2021 10:21:00 +0000 (12:21 +0200)]
dnsdist: Fix a typo in the TSAN suppressions file
Remi Gacogne [Wed, 7 Apr 2021 11:48:38 +0000 (13:48 +0200)]
dnsdist: Add a TSAN-enabled build on CircleCI
Remi Gacogne [Wed, 7 Apr 2021 10:14:00 +0000 (12:14 +0200)]
dnsdist: Add a TSAN suppressions list
Remi Gacogne [Wed, 7 Apr 2021 10:11:46 +0000 (12:11 +0200)]
dnsdist: Make IDState.age atomic when TSAN is enabled
Remi Gacogne [Wed, 7 Apr 2021 10:11:10 +0000 (12:11 +0200)]
dnsdist: Prevent a race when updating the TeeAction metrics
Remi Gacogne [Wed, 7 Apr 2021 10:10:15 +0000 (12:10 +0200)]
dnsdist: Fix race conditions in QPSAction, QPSPoolAction
Remi Gacogne [Wed, 7 Apr 2021 10:08:59 +0000 (12:08 +0200)]
dnsdist: Prevent a race when reloading TLS certificates
Remi Gacogne [Wed, 7 Apr 2021 10:07:56 +0000 (12:07 +0200)]
dnsdist: Prevent a race in the DelayPipe tests
phonedph1 [Thu, 15 Apr 2021 20:31:30 +0000 (14:31 -0600)]
rec: update setting for aggressive-nsec-cache-size
phonedph1 [Thu, 15 Apr 2021 17:38:35 +0000 (11:38 -0600)]
Update validate.cc
phonedph1 [Thu, 15 Apr 2021 16:57:15 +0000 (10:57 -0600)]
rec: print the covering NSEC
It would be nice to log not only that a name is covered, but what entry actually covers it. This is useful in debugging crazy setups.
Peter van Dijk [Thu, 15 Apr 2021 15:33:58 +0000 (17:33 +0200)]
mention dig +qr
Otto Moerbeek [Thu, 15 Apr 2021 13:05:44 +0000 (15:05 +0200)]
Merge pull request #10295 from omoerbeek/changelog-revert
Revert previous change to changelog, they should not be changed.
Peter van Dijk [Thu, 15 Apr 2021 12:34:34 +0000 (14:34 +0200)]
add numbers to diagram
Peter van Dijk [Thu, 15 Apr 2021 12:31:08 +0000 (14:31 +0200)]
add diagram
Peter van Dijk [Thu, 15 Apr 2021 12:29:35 +0000 (14:29 +0200)]
more spellcheck
Peter van Dijk [Thu, 15 Apr 2021 12:29:12 +0000 (14:29 +0200)]
spellcheck
Peter van Dijk [Thu, 15 Apr 2021 12:28:59 +0000 (14:28 +0200)]
replace IP
Peter van Dijk [Thu, 15 Apr 2021 12:27:01 +0000 (14:27 +0200)]
explain why 512 is enough
Peter van Dijk [Thu, 15 Apr 2021 12:21:44 +0000 (14:21 +0200)]
start off recursor FAQ with some talk about EDNS bufsizes
Peter van Dijk [Thu, 15 Apr 2021 11:52:36 +0000 (13:52 +0200)]
formatting nit
Otto [Thu, 15 Apr 2021 06:48:56 +0000 (08:48 +0200)]
Revert previous change to changelog, they should not be changed.
Otto Moerbeek [Thu, 15 Apr 2021 06:39:09 +0000 (08:39 +0200)]
Merge pull request #10287 from xiaolong-666/master
rec: remove delegation only (issue #7544)
xiaolong [Tue, 13 Apr 2021 02:47:20 +0000 (10:47 +0800)]
Remove `delegation-only` from the recursor #7544
Otto Moerbeek [Wed, 14 Apr 2021 08:04:29 +0000 (10:04 +0200)]
Merge pull request #10285 from omoerbeek/rec-prep-4.5.0-beta2
rec: Prep for rec-4.5.0-beta2
Otto Moerbeek [Tue, 13 Apr 2021 14:27:44 +0000 (16:27 +0200)]
Merge pull request #10291 from omoerbeek/rec-rpz-seed-error
Exception loading the RPZ seedfile is not fatal.
Peter van Dijk [Tue, 13 Apr 2021 13:46:59 +0000 (15:46 +0200)]
Merge pull request #10148 from Habbie/centos-8-stream-builds
builder, gh actions: add centos-8-stream build
Otto Moerbeek [Tue, 13 Apr 2021 13:19:00 +0000 (15:19 +0200)]
Merge pull request #10288 from omoerbeek/rec-deprecate-settings
rec: Stop using potentially offensive names internally and warn about deprecated settings.
Otto [Tue, 13 Apr 2021 13:16:09 +0000 (15:16 +0200)]
Exception loading the RPZ seedfile is not fatal.
Catch PDNSException and clear on failure.
Peter van Dijk [Fri, 9 Apr 2021 12:25:07 +0000 (14:25 +0200)]
narrower wildcard for matching centos stream
Peter van Dijk [Fri, 5 Mar 2021 10:34:20 +0000 (11:34 +0100)]
gh actions: add centos-8-stream build
Peter van Dijk [Fri, 5 Mar 2021 09:31:24 +0000 (10:31 +0100)]
builder: add centos 8 stream support
Otto Moerbeek [Tue, 13 Apr 2021 10:33:25 +0000 (12:33 +0200)]
Merge pull request #10276 from omoerbeek/rec-qm-aaaa-only
rec: First check the cache for NS name to address contents for both v4 and v6
Otto [Tue, 13 Apr 2021 09:20:57 +0000 (11:20 +0200)]
Fix comments and a redundant test from review.
Otto [Tue, 13 Apr 2021 09:03:47 +0000 (11:03 +0200)]
typos
Otto [Tue, 13 Apr 2021 08:47:38 +0000 (10:47 +0200)]
Stop using potentially offensive names internally and warn about
deprecated settings.
Otto [Mon, 12 Apr 2021 07:48:59 +0000 (09:48 +0200)]
Prep for rec-4.5.0-beta2
Otto Moerbeek [Fri, 9 Apr 2021 13:04:04 +0000 (15:04 +0200)]
Merge pull request #10245 from omoerbeek/qclass
Make QClass a class, including toString() method
Peter van Dijk [Fri, 9 Apr 2021 12:35:49 +0000 (14:35 +0200)]
Merge pull request #10281 from Habbie/dnsdist-getpool-docs
dnsdist docs: remove addPool; clarify that getPool creates pools
Peter van Dijk [Fri, 9 Apr 2021 12:05:16 +0000 (14:05 +0200)]
Merge pull request #10271 from Habbie/dnspcap-alignment
fix read alignment in dnspcap
Peter van Dijk [Fri, 9 Apr 2021 11:23:24 +0000 (13:23 +0200)]
Merge pull request #10234 from Habbie/qtype-names-csync
qtypes: check type registration; add CSYNC
Peter van Dijk [Fri, 9 Apr 2021 11:17:50 +0000 (13:17 +0200)]
Merge pull request #10171 from Habbie/lua-array-next
lua: don't destroy keys during table iteration
Peter van Dijk [Fri, 9 Apr 2021 10:45:30 +0000 (12:45 +0200)]
dnsdist docs: mention the default pool in a few places
Peter van Dijk [Fri, 9 Apr 2021 10:37:17 +0000 (12:37 +0200)]
dnsdist docs: remove addPool; clarify that getPool creates pools
Otto [Fri, 9 Apr 2021 09:50:29 +0000 (11:50 +0200)]
Do not test the individual records' ttls, they should be consistent with the ttl
of the cache entry itself.
Otto [Wed, 7 Apr 2021 12:36:18 +0000 (14:36 +0200)]
First check the cache for NS name to address contents for both
v4 and v6 before going out
This fixes #10263 here, but needs thorough reviewing and testing.
Remi Gacogne [Thu, 8 Apr 2021 07:41:23 +0000 (09:41 +0200)]
Merge pull request #10244 from rgacogne/ddist-better-docs
dnsdist: Document internal design, add tables and pictures
Remi Gacogne [Thu, 8 Apr 2021 07:40:28 +0000 (09:40 +0200)]
Merge pull request #10267 from rgacogne/ddist-dr-bindings
dnsdist: Add missing getEDNSOptions and getDO bindings for DNSResponse
Otto Moerbeek [Wed, 7 Apr 2021 15:16:19 +0000 (17:16 +0200)]
Merge pull request #10275 from omoerbeek/rec-tsan
rec: Fix a few cases discoverd by tsan:
Otto Moerbeek [Wed, 7 Apr 2021 14:00:57 +0000 (16:00 +0200)]
rec: Fix a few cases discoverd by tsan:
- The NegCache and MemRecursorCache destructors were not deadlock free
when running from testrunner. The purpose of the code in the dts
is also unclear, so delete them.
- quit-nicely uses a volatile sig_atomic_t, which is not thread-safe
according to tsan. Replace by atomic.
Otto Moerbeek [Wed, 7 Apr 2021 10:16:31 +0000 (12:16 +0200)]
Merge pull request #10272 from omoerbeek/rec-docs-reorder
rec: Reorder subjects and change titles, to make TOC more logical
Otto Moerbeek [Wed, 7 Apr 2021 09:11:15 +0000 (11:11 +0200)]
Merge pull request #10268 from omoerbeek/rec-frstm-query-addr
rec: Log local IP in dnstap messages
Otto [Wed, 7 Apr 2021 08:55:28 +0000 (10:55 +0200)]
Reorder subjects and change titles, to make TOC more logical
Peter van Dijk [Wed, 7 Apr 2021 08:53:48 +0000 (10:53 +0200)]
Merge pull request #10256 from Habbie/rfc6742-sizeof
RFC6742 types: use correct size
Peter van Dijk [Wed, 7 Apr 2021 08:20:01 +0000 (10:20 +0200)]
fix format specifier for size_t
Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Otto Moerbeek [Wed, 7 Apr 2021 08:07:09 +0000 (10:07 +0200)]
Aslo test query_address for value and query_port for presence
Peter van Dijk [Tue, 6 Apr 2021 19:48:23 +0000 (21:48 +0200)]
fix read alignment in dnspcap
Otto [Tue, 6 Apr 2021 13:19:58 +0000 (15:19 +0200)]
Log client IP in dnstap messages
Also make sure we log only if we actually sent a message, i.e.
we did not chain our request to an existing one.
Peter van Dijk [Tue, 6 Apr 2021 18:18:04 +0000 (20:18 +0200)]
more polish
Peter van Dijk [Thu, 1 Apr 2021 11:37:41 +0000 (13:37 +0200)]
rfc6742 types: use correct size
Otto Moerbeek [Tue, 6 Apr 2021 14:49:17 +0000 (16:49 +0200)]
Merge pull request #10269 from omoerbeek/auth-test-warnings
auth: Fix a few warnings as seen on OpenBSD/clang
Otto Moerbeek [Tue, 6 Apr 2021 13:39:26 +0000 (15:39 +0200)]
Merge pull request #10253 from zeha/tests-deprecated-equals
tests: stop using deprecated unittest names
Otto Moerbeek [Tue, 6 Apr 2021 13:37:23 +0000 (15:37 +0200)]
Merge pull request #10264 from omoerbeek/pmtu-v6
Also disable PMTU for v6
Otto [Tue, 6 Apr 2021 13:26:35 +0000 (15:26 +0200)]
Fix a few warnings as seen on OpenBSD/clang
Remi Gacogne [Tue, 6 Apr 2021 13:07:19 +0000 (15:07 +0200)]
dnsdist: Document that DNSResponse lacks some methods and attributes
Remi Gacogne [Tue, 6 Apr 2021 13:06:34 +0000 (15:06 +0200)]
dnsdist: Add missing getEDNSOptions and getDO bindings for DNSResponse
Otto [Tue, 6 Apr 2021 08:41:39 +0000 (10:41 +0200)]
Also disable PMTU for v6
Otto Moerbeek [Tue, 6 Apr 2021 12:25:41 +0000 (14:25 +0200)]
Merge pull request #10266 from omoerbeek/format-test-communicator
Fix formatting
Otto [Tue, 6 Apr 2021 11:24:42 +0000 (13:24 +0200)]
Fix formatting
Peter van Dijk [Tue, 6 Apr 2021 10:09:25 +0000 (12:09 +0200)]
Merge pull request #10196 from RobinGeuze/axfrPriorities
auth: implement AXFR priority level queue code
Peter van Dijk [Thu, 1 Apr 2021 16:11:18 +0000 (18:11 +0200)]
Merge pull request #10257 from omoerbeek/unordered-map
Include unordered_map
Otto [Thu, 1 Apr 2021 15:03:48 +0000 (17:03 +0200)]
Include unordered_map
Peter van Dijk [Thu, 1 Apr 2021 12:34:36 +0000 (14:34 +0200)]
fix formatting
Peter van Dijk [Thu, 1 Apr 2021 09:43:49 +0000 (11:43 +0200)]
Merge pull request #9659 from zeha/ignore-unknown-settings
Ignore unknown settings
Peter van Dijk [Thu, 1 Apr 2021 09:41:14 +0000 (11:41 +0200)]
Merge pull request #9669 from Habbie/pdns.conf-primary-secondary
auth pdns.conf, pdnsutil, pdns_control: modern aliases for master/slave
Peter van Dijk [Thu, 1 Apr 2021 09:36:21 +0000 (11:36 +0200)]
Merge pull request #10074 from pieterlexis/SVCB-improvements
SVCB improvements
Peter van Dijk [Thu, 1 Apr 2021 09:32:07 +0000 (11:32 +0200)]
Merge pull request #10121 from pieterlexis/rfc-6742-NID-LP-L32-L64
Implement RFC 6742 RR Types
Peter van Dijk [Thu, 1 Apr 2021 09:27:33 +0000 (11:27 +0200)]
Merge pull request #10252 from pieterlexis/prerel-version
Fix the package version _on_ prerelease tags
Peter van Dijk [Thu, 1 Apr 2021 09:22:46 +0000 (11:22 +0200)]
Merge pull request #10236 from mind04/pdns-rectify-opt
auth: rectify() do not update ordernames/auth when there is no need
Pieter Lexis [Thu, 1 Apr 2021 07:46:24 +0000 (09:46 +0200)]
SVCB: fix docs
Peter van Dijk [Thu, 1 Apr 2021 07:34:37 +0000 (09:34 +0200)]
Merge pull request #10248 from cFire/fix-parameter-name-dnsdist-docs
Fix typo in dnsdist docs for SuffixMatchNodeRule
Chris Hofstaedtler [Wed, 31 Mar 2021 16:31:10 +0000 (18:31 +0200)]
tests: stop using deprecated unittest names
Deprecated since Python 3.2
Kees Monshouwer [Wed, 31 Mar 2021 15:06:09 +0000 (17:06 +0200)]
pdns: add comment in extractRecord()
Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
Pieter Lexis [Wed, 31 Mar 2021 14:04:27 +0000 (16:04 +0200)]
Fix the package version _on_ prerelease tags
Closes #9842
Chris Hofstaedtler [Wed, 31 Mar 2021 14:00:23 +0000 (16:00 +0200)]
Be less smart
Chris Hofstaedtler [Thu, 29 Oct 2020 12:48:46 +0000 (13:48 +0100)]
auth,rec: add ignore-unknown-settings setting
Pieter Lexis [Thu, 25 Feb 2021 09:49:43 +0000 (10:49 +0100)]
Implement RFC 6742 RR Types
This commit implements the NID, L32, L64, and LP record types from RFC
6742. `dig` can properly parse the wiredata we send, and with the added
tests, I'm certain of the implementation.
The RFC has optional additional processing, this is not implemented.
Closes #10119
Peter van Dijk [Wed, 31 Mar 2021 12:14:35 +0000 (14:14 +0200)]
Merge pull request #10251 from Habbie/auth-local-ipv6-redux
auth: remove local-ipv6, query-local-address6 (redo of #9552). Closes #5368
Peter van Dijk [Wed, 31 Mar 2021 12:00:39 +0000 (14:00 +0200)]
Merge pull request #10217 from Habbie/auth-api-cds
auth API cryptokeys: add cds array when configured to do so. Closes #10215