]>
git.ipfire.org Git - thirdparty/pdns.git/log
Remi Gacogne [Thu, 23 Sep 2021 08:42:17 +0000 (10:42 +0200)]
speedtest: Count the system time as well as the user time
Our tests are designed to run for 100 ms of CPU time, but this is currently
measured with `ITIMER_VIRTUAL` which means only when the process is executing
in userspace. Switching to `ITIMER_PROF` would also account for the time spent
when the system is running on behalf of the process, which seems closer to what
we want.
Peter van Dijk [Thu, 23 Sep 2021 07:12:44 +0000 (09:12 +0200)]
Merge pull request #10749 from mind04/pdns-nobackend
auth: add cookie counters
Peter van Dijk [Thu, 23 Sep 2021 06:44:05 +0000 (08:44 +0200)]
fix title underline length
Peter van Dijk [Wed, 22 Sep 2021 13:21:22 +0000 (15:21 +0200)]
Merge pull request #10711 from Habbie/gh-actions-auth-backends
gh actions: test auth backends
Kees Monshouwer [Tue, 21 Sep 2021 20:44:23 +0000 (22:44 +0200)]
auth: add cookie counters
Peter van Dijk [Fri, 10 Sep 2021 10:14:11 +0000 (12:14 +0200)]
gh actions: move testing of almost all auth backends from CircleCI
Remi Gacogne [Wed, 22 Sep 2021 07:55:15 +0000 (09:55 +0200)]
Merge pull request #10745 from rgacogne/ddist-duplicate-id-on-tcp-conn
dnsdist: Don't increase the outstanding counter on a duplicated ID over TCP
Otto Moerbeek [Tue, 21 Sep 2021 14:22:44 +0000 (16:22 +0200)]
Merge pull request #10740 from omoerbeek/some-codeql-fixes
Fix "Large object passed by value" issues as spotted by CodeQL
Peter van Dijk [Tue, 21 Sep 2021 12:35:53 +0000 (14:35 +0200)]
Merge pull request #10727 from pieterlexis/svcb-generic-parse
SVCB: Accept known SVCParams in generic format
Peter van Dijk [Tue, 21 Sep 2021 12:31:19 +0000 (14:31 +0200)]
Merge pull request #10289 from pieterlexis/auth-cookies-3
Implement EDNS cookies in the auth
Peter van Dijk [Tue, 21 Sep 2021 11:07:05 +0000 (13:07 +0200)]
Merge pull request #10742 from Habbie/rec-build-without-sodium
rec: unbreak building without libsodium
Remi Gacogne [Tue, 21 Sep 2021 10:30:52 +0000 (12:30 +0200)]
dnsdist: Don't increase the outstanding counter on a duplicated ID over TCP
If the client has sent more than one concurrent query using the same query ID,
we only send one response for all of these queries, and we should not mess up
our outstanding queries counter.
Otto Moerbeek [Tue, 21 Sep 2021 10:20:55 +0000 (12:20 +0200)]
typo
Co-authored-by: Remi Gacogne <github@coredump.fr>
Otto [Tue, 21 Sep 2021 08:46:14 +0000 (10:46 +0200)]
Tweaks
Otto [Tue, 21 Sep 2021 06:59:11 +0000 (08:59 +0200)]
Mostly "Large object passed by value" fixes a spoted by CodeQL.
Plus a sign issue in a test as detected by OpenBSD/clang.
I simplified the hostog.hh template since it is used in only one place (dnsscope)
and the argument is not used there.
Remi Gacogne [Tue, 21 Sep 2021 09:43:09 +0000 (11:43 +0200)]
Merge pull request #10733 from pieterlexis/ddist-svcb-table
dnsdist: accept a table to SVCParams for newSVCRecordParameters
Peter van Dijk [Tue, 21 Sep 2021 09:16:45 +0000 (11:16 +0200)]
rec: unbreak building without libsodium
Otto Moerbeek [Tue, 21 Sep 2021 06:48:38 +0000 (08:48 +0200)]
Merge pull request #10738 from omoerbeek/rec-fix-prom-threads
Rec: fix Prometheus thread cpu usage
Otto [Mon, 20 Sep 2021 09:03:10 +0000 (11:03 +0200)]
Prometheus is a dependency for rec regress tests now
Otto Moerbeek [Mon, 20 Sep 2021 08:10:06 +0000 (08:10 +0000)]
Fix #10735: Prometheus formatting of tag values
Otto [Mon, 20 Sep 2021 07:32:30 +0000 (09:32 +0200)]
Add a regress test for Prometheus output
Remi Gacogne [Mon, 20 Sep 2021 14:42:19 +0000 (16:42 +0200)]
Merge pull request #10737 from rgacogne/coverity-
20210920
Fix issues reported by Coverity
Remi Gacogne [Mon, 20 Sep 2021 08:03:44 +0000 (10:03 +0200)]
auth: Add missing <optional> header
Remi Gacogne [Mon, 20 Sep 2021 08:03:02 +0000 (10:03 +0200)]
Credentials: Add move assignement operator
Remi Gacogne [Mon, 20 Sep 2021 07:46:49 +0000 (09:46 +0200)]
Credentials: Fix a possible overflow with a very large work factor
Reported by Coverity as CID
1462395 .
Remi Gacogne [Mon, 20 Sep 2021 07:40:00 +0000 (09:40 +0200)]
FDWrapper: Propery handle a negative descriptor in the move assignement operator
Reported by Coverity in CID
1462392 .
Peter van Dijk [Mon, 20 Sep 2021 09:37:44 +0000 (11:37 +0200)]
Merge pull request #10720 from Habbie/gh-actions-daily
gh actions: build packages & docker images only once a day
Pieter Lexis [Mon, 20 Sep 2021 09:31:53 +0000 (11:31 +0200)]
COOKIES: Use getInnerRemote to determine IP
Pieter Lexis [Fri, 17 Sep 2021 14:35:56 +0000 (16:35 +0200)]
dnsdist: accept a table to SVCParams for newSVCRecordParameters
Pieter Lexis [Mon, 20 Sep 2021 09:19:38 +0000 (11:19 +0200)]
COOKIE: Only send BADCOOKIE over UDP
Pieter Lexis [Mon, 20 Sep 2021 09:12:34 +0000 (11:12 +0200)]
Remove separate string_compare source
Pieter Lexis [Mon, 20 Sep 2021 09:02:56 +0000 (11:02 +0200)]
dnspacket: add missing include
Pieter Lexis [Wed, 15 Sep 2021 13:11:07 +0000 (15:11 +0200)]
COOKIES: remove comment
Pieter Lexis [Wed, 15 Sep 2021 08:02:40 +0000 (10:02 +0200)]
COOKIES: more constness, rm unused func
Pieter Lexis [Fri, 9 Jul 2021 09:51:50 +0000 (11:51 +0200)]
cookies: move consts to class instead of defines
Pieter Lexis [Fri, 9 Jul 2021 09:31:02 +0000 (11:31 +0200)]
Apply suggestions from code review
Co-authored-by: Remi Gacogne <github@coredump.fr>
Pieter Lexis [Wed, 2 Jun 2021 13:35:03 +0000 (15:35 +0200)]
Cookies: use constant time comparison
Pieter Lexis [Wed, 2 Jun 2021 13:31:56 +0000 (15:31 +0200)]
Move constantTimeStringEquals to its own file
Pieter Lexis [Tue, 1 Jun 2021 14:30:22 +0000 (16:30 +0200)]
Don't store validation state in cookie object
Pieter Lexis [Tue, 1 Jun 2021 11:18:54 +0000 (13:18 +0200)]
Make some cookie sizes constant, fix nits
Pieter Lexis [Tue, 13 Apr 2021 10:08:57 +0000 (12:08 +0200)]
auth: Add counter for EDNS Cookies
Pieter Lexis [Mon, 12 Apr 2021 10:58:56 +0000 (12:58 +0200)]
auth: Implement RFC 7872 and 9018 (COOKIES)
This implements the siphash-based interoperable DNS COOKIES defined in
RFC 9018 for the authoritative server. The EDNSCookieOpt struct has been
expanded to accomodate this and can now has constructors and functions
to check and generate a server cookie.
Cookies will only be sent out if the client sent a cookie and the
edns-cookie-secret setting is configures. The auth will respond with
EDNS+FORMERR when the client cookie is malformed, BADCOOKIE when the
client sent a server cookie we can't decode or is invalid and a normal
response with a cookie (either new or sent by the client) when the
cookie can be validated.
Pieter Lexis [Tue, 6 Apr 2021 21:44:51 +0000 (23:44 +0200)]
Add function to make a bytestring from hex
Pieter Lexis [Wed, 10 Jul 2019 12:32:04 +0000 (14:32 +0200)]
ComboAddress: Add toByteString() function
Pieter Lexis [Tue, 6 Apr 2021 21:15:09 +0000 (23:15 +0200)]
find crypto_shorthash in sodium for siphash-2-4
Pieter Lexis [Wed, 15 Sep 2021 12:05:18 +0000 (14:05 +0200)]
SVCB: Accept known SVCParams in generic format
Remi Gacogne [Mon, 20 Sep 2021 07:49:13 +0000 (09:49 +0200)]
Merge pull request #10718 from rgacogne/rec-ns-not-aa-in-dname-answers
rec: Only the DNAME records are authoritative in DNAME answers
Peter van Dijk [Fri, 17 Sep 2021 14:06:01 +0000 (16:06 +0200)]
Merge pull request #9662 from cmouse/patch-
1604087167
Coverity fixes
Peter van Dijk [Fri, 17 Sep 2021 12:50:02 +0000 (14:50 +0200)]
Merge pull request #10653 from rgacogne/lock-guarded-auth
auth: Convert locks to LockGuarded
Remi Gacogne [Fri, 17 Sep 2021 08:03:41 +0000 (10:03 +0200)]
Merge pull request #10157 from rgacogne/ddist-hashed-passwords
Move to hashed passwords for the web interface
Aki Tuomi [Fri, 5 Mar 2021 09:55:31 +0000 (11:55 +0200)]
comfun.cc: Fix issues
Remi Gacogne [Fri, 17 Sep 2021 07:28:03 +0000 (09:28 +0200)]
Merge pull request #10729 from rgacogne/ddist-doc-deps
dnsdist: Update the list of dependencies in the documentation
Aki Tuomi [Mon, 2 Nov 2020 07:58:10 +0000 (09:58 +0200)]
distributor.hh: Document threadname truncation
Aki Tuomi [Fri, 30 Oct 2020 20:41:47 +0000 (22:41 +0200)]
pdns: stubresolver - Ignore waitForPipe error, handled later
Aki Tuomi [Fri, 30 Oct 2020 20:41:18 +0000 (22:41 +0200)]
pdns: signingpipe - Ignore waitForPipe error, handled later
Aki Tuomi [Fri, 30 Oct 2020 20:30:22 +0000 (22:30 +0200)]
pdns: distributor - Initialize question id and callback
Aki Tuomi [Fri, 5 Mar 2021 09:57:04 +0000 (11:57 +0200)]
global: Check setsockopt return value
Aki Tuomi [Fri, 30 Oct 2020 19:47:22 +0000 (21:47 +0200)]
pdns: dnsseckeeper - Clarify cache clearing never fails
Aki Tuomi [Fri, 30 Oct 2020 19:46:11 +0000 (21:46 +0200)]
pdns: svc-records - Delete default constructor
It is not usable
Peter van Dijk [Thu, 16 Sep 2021 14:24:38 +0000 (16:24 +0200)]
Merge pull request #10660 from Habbie/auth-proxy-protocol
auth: incoming PROXY support
Remi Gacogne [Wed, 15 Sep 2021 07:44:18 +0000 (09:44 +0200)]
dnsdist: Update Outgoing regression tests for hashed credentials
Remi Gacogne [Wed, 30 Jun 2021 14:25:53 +0000 (16:25 +0200)]
dnsdist: Reduce the "non-hashed password" messages to the info level
Remi Gacogne [Wed, 30 Jun 2021 14:04:04 +0000 (16:04 +0200)]
Document that hashed credentials can be used without 'webserver-hash-plaintext-credentials'
Remi Gacogne [Wed, 30 Jun 2021 13:57:00 +0000 (15:57 +0200)]
rec: Add "hash-password" to the rec_control help
Remi Gacogne [Tue, 29 Jun 2021 10:30:22 +0000 (12:30 +0200)]
Update m4/pdns_check_libcrypto.m4
Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Remi Gacogne [Wed, 23 Jun 2021 16:00:25 +0000 (18:00 +0200)]
Credentials: Fix compilation without OpenSSL 1.1.1
Remi Gacogne [Wed, 23 Jun 2021 15:57:15 +0000 (17:57 +0200)]
Credentials: Fix formatting issues
Remi Gacogne [Wed, 23 Jun 2021 15:41:57 +0000 (17:41 +0200)]
Whitelist 'scrypt' for the spell checker
Remi Gacogne [Wed, 23 Jun 2021 15:40:41 +0000 (17:40 +0200)]
dnsdist: Convert the regression tests to the new password storage format
Remi Gacogne [Mon, 21 Jun 2021 16:30:14 +0000 (18:30 +0200)]
Credentials: Apply comments from code review
Remi Gacogne [Mon, 21 Jun 2021 16:14:55 +0000 (18:14 +0200)]
Credentials: Fix a missing semicolon
Remi Gacogne [Mon, 21 Jun 2021 16:14:15 +0000 (18:14 +0200)]
auth: Allow hashing with a custom work factor
Remi Gacogne [Mon, 21 Jun 2021 16:14:02 +0000 (18:14 +0200)]
rec: Allow hashing with a custom work factor
Remi Gacogne [Mon, 21 Jun 2021 15:53:17 +0000 (17:53 +0200)]
dnsdist: Allow hashing with a custom work factor
Remi Gacogne [Sat, 12 Jun 2021 15:40:09 +0000 (17:40 +0200)]
Use OpenSSL's scrypt for secure credential storage
Remi Gacogne [Fri, 9 Apr 2021 13:15:09 +0000 (15:15 +0200)]
rec_control, pdnsutil: Read the credentials from the terminal/stdin
Remi Gacogne [Fri, 9 Apr 2021 10:29:09 +0000 (12:29 +0200)]
Make the hashing of plaintext credentials optional
Remi Gacogne [Thu, 8 Apr 2021 16:35:51 +0000 (18:35 +0200)]
Actually check whether crypto_pwhash_str() is available
Instead of just checking if libsodium is there.
Remi Gacogne [Thu, 8 Apr 2021 16:33:59 +0000 (18:33 +0200)]
Use sodium_memcmp() if CRYPTO_memcmp() is not available
Remi Gacogne [Thu, 8 Apr 2021 16:25:14 +0000 (18:25 +0200)]
auth: Be more straightforward in pdnsutil for 'hash-password'
Remi Gacogne [Thu, 8 Apr 2021 16:24:21 +0000 (18:24 +0200)]
rec: Be more straightforward in rec_control for 'hash-password'
Remi Gacogne [Thu, 8 Apr 2021 16:20:46 +0000 (18:20 +0200)]
dnsdist: Clarify that setWebserverConfig() wants a hashed password
Remi Gacogne [Thu, 8 Apr 2021 16:19:43 +0000 (18:19 +0200)]
Run the credentials unit tests in the auth and rec as well
Remi Gacogne [Wed, 31 Mar 2021 11:42:51 +0000 (13:42 +0200)]
Fix formatting
Remi Gacogne [Wed, 31 Mar 2021 09:43:09 +0000 (11:43 +0200)]
dnsdist: Fix formatting in test-credentials_cc.cc
Remi Gacogne [Wed, 31 Mar 2021 09:35:27 +0000 (11:35 +0200)]
CircleCI: ixfrdist needs the sodium library now
Remi Gacogne [Wed, 31 Mar 2021 09:07:25 +0000 (11:07 +0200)]
dnsdist: API keys should now be hashed as well
Remi Gacogne [Wed, 31 Mar 2021 07:52:57 +0000 (09:52 +0200)]
auth: Add speed tests for the credentials class
Remi Gacogne [Wed, 31 Mar 2021 07:52:44 +0000 (09:52 +0200)]
dnsdist: Add unit tests for the credentials class
Remi Gacogne [Wed, 31 Mar 2021 07:52:03 +0000 (09:52 +0200)]
dnsdist: We want to know if the password was hashed, not if it is now
Remi Gacogne [Wed, 31 Mar 2021 07:07:16 +0000 (09:07 +0200)]
rec: Document that the webserver password and API key can be hashed
Remi Gacogne [Wed, 31 Mar 2021 07:06:45 +0000 (09:06 +0200)]
auth: Document that the webserver password and API key can be hashed
Remi Gacogne [Wed, 31 Mar 2021 07:06:18 +0000 (09:06 +0200)]
dnsdist: Document that the API key can now be hashed as well
Remi Gacogne [Tue, 30 Mar 2021 17:25:11 +0000 (19:25 +0200)]
Attempt at constant-time credentials verification without sodium
Remi Gacogne [Tue, 30 Mar 2021 15:57:33 +0000 (17:57 +0200)]
rec: Implement rec_control hash-password
Remi Gacogne [Tue, 30 Mar 2021 15:57:11 +0000 (17:57 +0200)]
auth: Implement pdnsutil hash-password
Remi Gacogne [Tue, 30 Mar 2021 15:56:45 +0000 (17:56 +0200)]
Support hashed credentials (password, API key) in the auth and rec
Remi Gacogne [Tue, 30 Mar 2021 15:55:23 +0000 (17:55 +0200)]
dnsdist: Make hashed passwords more transparent to use
Remi Gacogne [Wed, 10 Mar 2021 08:58:24 +0000 (09:58 +0100)]
dnsdist: Fix a missing space in the documentation
Remi Gacogne [Wed, 10 Mar 2021 08:48:47 +0000 (09:48 +0100)]
dnsdist: Fix a weird sentence in the documentation
Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>