]>
git.ipfire.org Git - thirdparty/pdns.git/log
Otto [Mon, 29 Nov 2021 13:48:09 +0000 (14:48 +0100)]
Fix error in test zone that auth-45 does not like
Otto [Mon, 29 Nov 2021 11:52:09 +0000 (12:52 +0100)]
One more occurence of --local-ipv6
Otto [Mon, 29 Nov 2021 10:56:25 +0000 (11:56 +0100)]
Fix v6 setup and start using a more modern auth on circleci
Otto Moerbeek [Sun, 28 Nov 2021 14:02:53 +0000 (15:02 +0100)]
Merge pull request #11041 from omoerbeek/rec-lua-blocking-docs
rec: Warn about blocking calls from Lua
Otto [Sun, 28 Nov 2021 08:20:31 +0000 (09:20 +0100)]
Warn about blocking calls from Lua
Remi Gacogne [Fri, 26 Nov 2021 15:53:48 +0000 (16:53 +0100)]
Merge pull request #11037 from rgacogne/ddist-healthcheck-reuse-tls-session
dnsdist: Reuse and save the TLS session tickets in DoT healthchecks
Otto Moerbeek [Fri, 26 Nov 2021 14:04:16 +0000 (15:04 +0100)]
Merge pull request #11030 from omoerbeek/rec-incoming-tcp-finalize
Rec incoming tcp bookkeeping
Remi Gacogne [Fri, 26 Nov 2021 13:48:16 +0000 (14:48 +0100)]
dnsdist: Use `time()` instead of `gettimeofday()`, as suggested by Otto
Otto Moerbeek [Fri, 26 Nov 2021 13:08:56 +0000 (14:08 +0100)]
typo in comment
Co-authored-by: Remi Gacogne <github@coredump.fr>
Otto Moerbeek [Fri, 26 Nov 2021 12:56:58 +0000 (13:56 +0100)]
Merge pull request #11038 from omoerbeek/rec-ci-mo-tsan-for-now
rec: Disable tsan regression runs for rec for now,
Remi Gacogne [Fri, 26 Nov 2021 12:51:13 +0000 (13:51 +0100)]
dnsdist: Update the outgoing DoT tests now that we save TLS tickets during healthchecks
Otto [Fri, 26 Nov 2021 11:21:23 +0000 (12:21 +0100)]
Disable tsan regression runs for rec for now, there is a failure
mode that if it hits makes almost all remaining test fail. Symptom
is that the auths do not start up properly.
Remi Gacogne [Fri, 26 Nov 2021 11:15:09 +0000 (12:15 +0100)]
dnsdist: Reuse and save the TLS session tickets in DoT healthchecks
This reduces the cost of the healthchecks themselves while saving the
TLS session reduces the cost of opening of a DoT connection for actual
queries later on.
In the future a refactoring of the TCP/DoT healthcheck code to be more
like the "black box" approach used for DoH would be nice to have.
Otto [Fri, 26 Nov 2021 10:40:32 +0000 (11:40 +0100)]
Only call setDropOnIdle() if we're actually have a tcp connection.
Also add extra consistency check, d_tcp and d_tcpcOnnection should
likely be squashed into a single thing.
Otto [Fri, 26 Nov 2021 09:22:15 +0000 (10:22 +0100)]
If we fall through handleRunningTCPQuestion(), we neeed to keep the connection,
there are more bytes to come. handleTCPReadResult() is now a method of a guard.
Peter van Dijk [Thu, 25 Nov 2021 10:47:04 +0000 (11:47 +0100)]
Merge pull request #11028 from Habbie/auth-4.4.1-secpoll-docs
auth 4.4.2 secpoll&docs
Peter van Dijk [Tue, 23 Nov 2021 13:54:06 +0000 (14:54 +0100)]
auth 4.4.2 secpoll&docs
Remi Gacogne [Wed, 24 Nov 2021 16:00:46 +0000 (17:00 +0100)]
Merge pull request #11031 from rgacogne/ddist-fix-missing-visibility
dnsdist: Add missing visibility attribute on `dnsdist_ffi_dnsquestion_get_qname_hash`
Remi Gacogne [Wed, 24 Nov 2021 14:58:40 +0000 (15:58 +0100)]
Merge pull request #11006 from rgacogne/ddist-show-web-config
dnsdist: Add 'showWebserverConfig'
Otto [Wed, 24 Nov 2021 14:33:38 +0000 (15:33 +0100)]
Better names
Remi Gacogne [Wed, 24 Nov 2021 14:20:55 +0000 (15:20 +0100)]
dnsdist: Fix g++/LTO warning about uninitialized dnsheaders in the unit test
Remi Gacogne [Wed, 24 Nov 2021 14:19:56 +0000 (15:19 +0100)]
dnsdist: Add missing visibility attribute on dnsdist_ffi_dnsquestion_get_qname_hash
Making it unusable from Lua FFI when dnsdist is compiled with
`-fvisibility=hidden`.
Otto [Wed, 24 Nov 2021 10:12:16 +0000 (11:12 +0100)]
Use guard objects to do the TCP connection bookkeeping and cleanup if needed.
If a policy drop is to be handled for a TCP connection, do not
answer that query, but do handle already in-flight queries and then close.
Remi Gacogne [Wed, 24 Nov 2021 13:36:32 +0000 (14:36 +0100)]
Merge pull request #10997 from rgacogne/ddist-dump-cached-session-and-connection
dnsdist: Add a function to know how many TLS sessions are currently cached
Remi Gacogne [Wed, 24 Nov 2021 13:36:01 +0000 (14:36 +0100)]
Merge pull request #11001 from rgacogne/ddist-warn-memory-leak-gnutls
dnsdist: Warn that GnuTLS 3.7.x leaks memory when validating certs
Remi Gacogne [Wed, 24 Nov 2021 13:35:50 +0000 (14:35 +0100)]
Merge pull request #10999 from rgacogne/ddist-fix-leak-in-outgoing-tls-session-reuse
dnsdist: Fix a memory leak when reusing TLS tickets for outgoing connections
Remi Gacogne [Wed, 24 Nov 2021 13:35:38 +0000 (14:35 +0100)]
Merge pull request #10993 from rgacogne/ddist-fix-10988
dnsdist: Fix compiler/static analyzer warnings
Remi Gacogne [Wed, 24 Nov 2021 09:36:30 +0000 (10:36 +0100)]
dnsdist: Apply Charles-Henri's suggestions from code review (thanks!)
Otto [Wed, 24 Nov 2021 09:10:24 +0000 (10:10 +0100)]
Add test for the case there was trailing data after the repy (#11018)
Otto Moerbeek [Tue, 23 Nov 2021 12:42:49 +0000 (13:42 +0100)]
Merge pull request #10986 from omoerbeek/gh-check-formatting
Check formatting on GH
Peter van Dijk [Tue, 23 Nov 2021 12:41:32 +0000 (13:41 +0100)]
Merge pull request #11012 from Habbie/nsec3param-minimal
auth: new default nsec3param settings
Otto Moerbeek [Tue, 23 Nov 2021 11:15:12 +0000 (12:15 +0100)]
Merge pull request #11026 from omoerbeek/rec-regr-timing1
rec: Loosen timing checks that I have seen tripping in tsan enabled tests.
Otto [Tue, 23 Nov 2021 10:53:29 +0000 (11:53 +0100)]
Give steps a name
Otto Moerbeek [Tue, 23 Nov 2021 10:25:23 +0000 (11:25 +0100)]
Merge pull request #11010 from omoerbeek/rec-zero-scope-negcache
rec: Do negcache negative results, even when wasVariable() is true
Otto [Tue, 23 Nov 2021 10:24:10 +0000 (11:24 +0100)]
Fir error reporting when starting up fails
Otto [Tue, 23 Nov 2021 10:03:44 +0000 (11:03 +0100)]
Loosen timing checks that I have seen tripping in tsan enabled tests.
There are likely more.
Otto Moerbeek [Tue, 23 Nov 2021 09:56:03 +0000 (10:56 +0100)]
Merge pull request #11019 from omoerbeek/rec-regr-vs-libfaketime
rec: Rec regr vs libfaketime
Otto Moerbeek [Tue, 23 Nov 2021 08:07:45 +0000 (09:07 +0100)]
Merge pull request #11018 from omoerbeek/rec-tcp-notify-followup
rec: Fix logic botch introduced by notify handling
Otto Moerbeek [Mon, 22 Nov 2021 14:28:42 +0000 (15:28 +0100)]
Cleanup libfaketime handling in rec regression tests
- Use the MT variant for libfaketime, we are MT after all
- It is only needed for auth and LD_PRELOAD is set by the tests where it matters
- It interacts badly with libfstrm and tsan in the recursor
- No more separate run of the dnstap test is needed
Otto [Mon, 22 Nov 2021 14:18:07 +0000 (15:18 +0100)]
When we drop a notify over TCP, terminate the connection
Otto [Mon, 22 Nov 2021 13:09:55 +0000 (14:09 +0100)]
Fix logic botch introduced by notify handing
See #10751, some extra scrutiny review is needed to make sure no
other similat issue remains.
Peter van Dijk [Mon, 22 Nov 2021 11:09:29 +0000 (12:09 +0100)]
Merge pull request #11003 from pieterlexis/upstream-changelog
docs: Use upstream changelog package
Remi Gacogne [Mon, 22 Nov 2021 08:25:07 +0000 (09:25 +0100)]
Merge pull request #11008 from rgacogne/ddist-raise-socket-buffers
dnsdist: Add a function to set the UDP recv/snd buffer sizes
Otto Moerbeek [Mon, 22 Nov 2021 07:02:08 +0000 (08:02 +0100)]
Merge pull request #11014 from kpfleming/rec-doc-improvement
rec: Add xref between allow-notify-for-file and forward-zones-file
Kevin P. Fleming [Sun, 21 Nov 2021 09:21:50 +0000 (04:21 -0500)]
rec: Add xref between allow-notify-for-file and forward-zones-file
Remi Gacogne [Fri, 19 Nov 2021 14:27:07 +0000 (15:27 +0100)]
Allow rmem, wmem in the spell checker
Remi Gacogne [Fri, 19 Nov 2021 14:07:31 +0000 (15:07 +0100)]
dnsdist: Keep the system default values for `SO_RCVBUF` and `SO_SNDBUF`
Peter van Dijk [Fri, 19 Nov 2021 11:56:39 +0000 (12:56 +0100)]
auth: new default nsec3param settings, fixes #10864
Otto Moerbeek [Fri, 19 Nov 2021 11:26:21 +0000 (12:26 +0100)]
Merge pull request #10990 from omoerbeek/rec-notify-regrr
rec: Basic notify test
Otto Moerbeek [Fri, 19 Nov 2021 11:08:44 +0000 (12:08 +0100)]
Merge pull request #11005 from omoerbeek/rec-taskq-timeval
rec: Include sys/time.h in taskqueue.hh
Otto [Fri, 19 Nov 2021 10:57:28 +0000 (11:57 +0100)]
Do cache negcache results, even when wasVariable() is true
See https://datatracker.ietf.org/doc/html/rfc7871#section-7.4
Fixes #10994
Remi Gacogne [Fri, 19 Nov 2021 08:53:26 +0000 (09:53 +0100)]
rec: Fix the size of the UDP receive buffer
Remi Gacogne [Fri, 19 Nov 2021 08:43:17 +0000 (09:43 +0100)]
Merge pull request #11007 from rgacogne/ddist-fix-bounds-checking
dnsdist: Fix Lua parameters bound checks
Remi Gacogne [Thu, 18 Nov 2021 16:38:56 +0000 (17:38 +0100)]
dnsdist: Add a function to set the UDP recv/snd buffer sizes
And raise them to
16777216 by default.
Remi Gacogne [Thu, 18 Nov 2021 16:01:32 +0000 (17:01 +0100)]
auth,rec: Refactor the setSocket*Buffer functions
Remi Gacogne [Thu, 18 Nov 2021 15:12:42 +0000 (16:12 +0100)]
dnsdist: Fix Lua parameters bound checks
Remi Gacogne [Thu, 18 Nov 2021 15:09:48 +0000 (16:09 +0100)]
dnsdist: Add 'showWebserverConfig'
Otto [Thu, 18 Nov 2021 14:42:18 +0000 (15:42 +0100)]
Include sys/time.h; needed on musl; fixes #11000
Pieter Lexis [Thu, 18 Nov 2021 12:19:23 +0000 (13:19 +0100)]
docs: Use upstream changelog package
Peter van Dijk [Thu, 18 Nov 2021 11:25:40 +0000 (12:25 +0100)]
Merge pull request #10996 from aerique/feature/update-debian-bullseye-for-repo-script
Add `rec-45` for Debian Bullseye to repo test script.
Remi Gacogne [Thu, 18 Nov 2021 10:56:33 +0000 (11:56 +0100)]
dnsdist: Warn that GnuTLS 3.7.x leaks memory when validating certs
In some configurations that we can't detect (PKCS11 support enabled,
with a default PKCS11 trust store), GnuTLS from 3.7.0 to at least
3.7.2 leaks memory when validating a server certificate. The issue
has been reported to GnuTLS and acknowledged, but there is no
available fix yet.
Remi Gacogne [Wed, 17 Nov 2021 18:03:46 +0000 (19:03 +0100)]
dnsdist: Fix a memory leak when reusing TLS tickets for outgoing connections
We were not properly freeing the memory of TLS session tickets reused
for outgoing TLS (DoT / DoH) connections.
Reported by Stéphane Bortzmeyer (many thanks!).
Remi Gacogne [Wed, 17 Nov 2021 14:53:27 +0000 (15:53 +0100)]
dnsdist: Add a function to know how many TLS sessions are currently cached
Also dump the number of cached (active and idle) outgoing connections
when requested.
Otto Moerbeek [Wed, 17 Nov 2021 14:26:44 +0000 (15:26 +0100)]
Merge pull request #10995 from rgacogne/rec-doc-typo-allow-notify-from
rec: Fix a typo in the documentation for 'allow-notify-from'
Erik Winkels [Wed, 17 Nov 2021 13:09:55 +0000 (14:09 +0100)]
Add `rec-45` for Debian Bullseye to repo test script.
Otto Moerbeek [Wed, 17 Nov 2021 11:39:58 +0000 (12:39 +0100)]
Merge pull request #10992 from omoerbeek/rec-prep-4.6.0-beta2
rec: Prep for rec-4.6.0-beta2
Remi Gacogne [Wed, 17 Nov 2021 08:56:55 +0000 (09:56 +0100)]
rec: Fix a typo in the documentation for 'allow-notify-from'
Remi Gacogne [Tue, 16 Nov 2021 16:36:03 +0000 (17:36 +0100)]
dnsdist: Fix compiler/static analyzer warnings
Otto [Tue, 16 Nov 2021 13:10:44 +0000 (14:10 +0100)]
Prep for rec-4.6.0-beta2
Remi Gacogne [Tue, 16 Nov 2021 14:43:12 +0000 (15:43 +0100)]
Merge pull request #10987 from rgacogne/ddist17-b1-changelog-secpoll
dnsdist: Add ChangeLog and secpoll update for 1.7.0-beta1
Otto Moerbeek [Tue, 16 Nov 2021 13:30:47 +0000 (14:30 +0100)]
Positive instead of negative test
Co-authored-by: Pieter Lexis <pieter@plexis.eu>
Otto [Tue, 16 Nov 2021 12:35:58 +0000 (13:35 +0100)]
Do not count notifies in record cache hits/misses
Otto [Tue, 16 Nov 2021 12:07:40 +0000 (13:07 +0100)]
Basic notify test.
It turns out a notify increments cache-hits, that feel a bit strange.
Remi Gacogne [Tue, 16 Nov 2021 09:27:15 +0000 (10:27 +0100)]
dnsdist: Fix the description of 10920 in the ChangeLog, remove useless entries
Remi Gacogne [Tue, 16 Nov 2021 09:24:56 +0000 (10:24 +0100)]
spellcheck: Allow 'XDP', 'Grié'
Remi Gacogne [Tue, 16 Nov 2021 09:17:17 +0000 (10:17 +0100)]
Merge pull request #10883 from rgacogne/ddist-pinned-maps
dnsdist: Implement filesystem pinning for eBPF maps
Remi Gacogne [Tue, 16 Nov 2021 09:04:58 +0000 (10:04 +0100)]
dnsdist: Add ChangeLog and secpoll update for 1.7.0-beta1
Otto [Tue, 16 Nov 2021 07:30:29 +0000 (08:30 +0100)]
Use clang-11
Otto Moerbeek [Tue, 16 Nov 2021 08:05:28 +0000 (09:05 +0100)]
Merge pull request #10896 from omoerbeek/more-secpoll-check
More strict secpoll.zone check
Remi Gacogne [Mon, 15 Nov 2021 17:16:35 +0000 (18:16 +0100)]
dnsdist: Switch to a uint8_t for the XDP match action type
Remi Gacogne [Mon, 15 Nov 2021 17:11:02 +0000 (18:11 +0100)]
dnsdist: Apply suggestions from code review on the new eBPF map type
Remi Gacogne [Mon, 15 Nov 2021 16:28:23 +0000 (17:28 +0100)]
contrib/xdp.py: Apply the change suggested by Pieter (thanks!)
Co-authored-by: Pieter Lexis <pieter@plexis.eu>
Remi Gacogne [Fri, 29 Oct 2021 14:56:08 +0000 (16:56 +0200)]
dnsdist: Add a sample XDP program and associated python script in contrib
Both contributed by Pierre Grié <pierre.grie@nameshield.net>.
Remi Gacogne [Thu, 28 Oct 2021 15:58:53 +0000 (17:58 +0200)]
dnsdist: Add a new eBPF map format, support external eBPF programs
Supporting external eBPF programs makes it possible to populate the
eBPF tables from dnsdist, manually or via our dynamic blocking mechanisms,
but to actually do the filtering in an external program, like an XDP one.
We cannot increase the size of eBPF programs if we want to stay
below 4k instructions for older kernels, so this commit implements
a compatibility layer with the new map format.
The 4k limit for unprivileged was removed in 5.2 but the complexity limit remains:
The complexity limit was actually changed several times since the
32k value from its introduction in Linux 3.18: it was raised to 64k
in Linux 4.7, then to 96k in Linux 4.12, again to 128k in Linux 4.14,
and at last to 1M in Linux 5.2.
Remi Gacogne [Fri, 22 Oct 2021 15:03:27 +0000 (17:03 +0200)]
dnsdist: Implement filesystem pinning for eBPF maps
This makes the filter (v4, v6 and qnames) maps persistent across a
restart and allow external programs to read and update them without
the need to use dnsdist's console.
Otto [Tue, 16 Nov 2021 07:23:35 +0000 (08:23 +0100)]
Check formatting on GH
Otto Moerbeek [Tue, 16 Nov 2021 06:30:34 +0000 (07:30 +0100)]
indent
Peter van Dijk [Mon, 15 Nov 2021 16:30:28 +0000 (17:30 +0100)]
Merge pull request #10981 from Habbie/2136-rrset-ttl
auth 2136: apply new TTL to whole RRset, not only to the added record
Otto Moerbeek [Mon, 15 Nov 2021 16:18:51 +0000 (17:18 +0100)]
Merge pull request #10980 from omoerbeek/rec-ede-issue
rec: Return the proper ede on validation failure
Peter van Dijk [Mon, 15 Nov 2021 15:28:58 +0000 (16:28 +0100)]
auth 2136: apply new TTL to whole RRset, not only to the added record
fixes #10921
Peter van Dijk [Mon, 15 Nov 2021 15:28:47 +0000 (16:28 +0100)]
auth 2136: improve some log messages
Remi Gacogne [Mon, 15 Nov 2021 13:16:21 +0000 (14:16 +0100)]
Merge pull request #10907 from rgacogne/ddist-handle-existing-edns-mac-setedns
dnsdist: Handle existing EDNS content for SetMacAddrAction/SetEDNSOptionAction
Remi Gacogne [Mon, 15 Nov 2021 13:13:36 +0000 (14:13 +0100)]
Merge pull request #10920 from rgacogne/ddist-cleanup-conns
dnsdist: Remove unreachable code in HTTP/2 connections cleanup
Otto Moerbeek [Tue, 26 Oct 2021 06:05:33 +0000 (08:05 +0200)]
no else after exit
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Otto [Mon, 25 Oct 2021 13:20:18 +0000 (15:20 +0200)]
tweaks and undo error entry
Otto [Mon, 25 Oct 2021 12:53:53 +0000 (14:53 +0200)]
Move check to a shell script
Otto [Mon, 25 Oct 2021 12:33:45 +0000 (14:33 +0200)]
More strict secpoll check; hope I got the yaml quoting right
Otto Moerbeek [Mon, 15 Nov 2021 12:35:02 +0000 (13:35 +0100)]
some more ()'s for readability
Co-authored-by: Remi Gacogne <github@coredump.fr>
Otto [Mon, 15 Nov 2021 12:08:32 +0000 (13:08 +0100)]
Add a test for ede sig expired that does not rely on external servers
Otto Moerbeek [Mon, 15 Nov 2021 10:45:48 +0000 (11:45 +0100)]
Merge pull request #10975 from omoerbeek/rec-fewer-circle-bulktests
rec: Run fewer CircleCI bulk tests