]>
git.ipfire.org Git - thirdparty/pdns.git/log
Remi Gacogne [Tue, 29 Mar 2022 16:09:28 +0000 (18:09 +0200)]
LuaWrapper: Prevent referencing a temporary object
Reported by Coverity (CIDs 120403 and 145915)
Remi Gacogne [Tue, 29 Mar 2022 15:49:41 +0000 (17:49 +0200)]
LMDB: Clarify that the base commit() method should be called in the dtor
CodeQL warns that there might some ambiguity about whether the base
or derived commit() method is called in derived classes:
https://github.com/PowerDNS/pdns/security/code-scanning/379
Peter van Dijk [Mon, 28 Mar 2022 15:58:59 +0000 (17:58 +0200)]
Merge pull request #11295 from tokred/contrib-pdnsutil-zcompl
auth: zsh completion script for pdnsutil
tokred [Sat, 5 Feb 2022 17:24:09 +0000 (18:24 +0100)]
auth: zsh completion script for pdnsutil
Remi Gacogne [Mon, 28 Mar 2022 10:10:11 +0000 (12:10 +0200)]
Merge pull request #11437 from rgacogne/ddist-healthcheck-mplexer
dnsdist: Only allocate the health-check mplexer when needed
Otto Moerbeek [Mon, 28 Mar 2022 10:08:58 +0000 (12:08 +0200)]
Merge pull request #11470 from omoerbeek/rec-scanbuild-fixes
Rec: scanbuild fixes
Peter van Dijk [Mon, 28 Mar 2022 09:53:35 +0000 (11:53 +0200)]
Merge pull request #11426 from mind04/pdns-fix-decaf-signer
decaf signer did not compile after #11414
Peter van Dijk [Mon, 28 Mar 2022 09:23:59 +0000 (11:23 +0200)]
Merge pull request #11465 from omoerbeek/docs-2022-01-prs
Fill in PR#s for Security Advisory 2022-01
Otto Moerbeek [Mon, 28 Mar 2022 09:21:44 +0000 (11:21 +0200)]
Merge pull request #11445 from omoerbeek/rec-nod-log-too-long
rec: Only log "Unable to send NOD lookup" if log-comnon-errors is set
Otto Moerbeek [Mon, 28 Mar 2022 09:07:46 +0000 (11:07 +0200)]
Comment on the two remaining scanbuild cases. At first sight these are both false positives.
Otto Moerbeek [Mon, 28 Mar 2022 08:50:52 +0000 (10:50 +0200)]
Teach scanbuild that two divisions are safe: one by adding an assert, one by using a *const* table
Otto Moerbeek [Fri, 25 Mar 2022 14:41:48 +0000 (15:41 +0100)]
Add .cacche dir for pdns/pdns
Otto Moerbeek [Fri, 25 Mar 2022 10:17:44 +0000 (11:17 +0100)]
Scanbuid fixes
AFAIKS, a few false positives remain:
Unused code Dead assignment lwres.cc asyncresolve 444 1 View Report
Logic error Division by zero pdns_recursor.cc selectWorker 2423 49 View Report
Logic error Division by zero sillyrecords.cc precsize_aton 48 32 View Report
Memory error Memory leak recursordist/rec-main.cc wipeCaches 2716 18 View Report
Remi Gacogne [Mon, 28 Mar 2022 08:14:46 +0000 (10:14 +0200)]
Merge pull request #11467 from Habbie/spelling-202203
spelling: add missed words
Peter van Dijk [Fri, 25 Mar 2022 13:16:19 +0000 (14:16 +0100)]
spelling: add missed words
Peter van Dijk [Sat, 26 Mar 2022 00:06:52 +0000 (01:06 +0100)]
Merge pull request #11447 from jsoref/linguist-dns-zones
Add linguist-language tag for dns zones
Josh Soref [Fri, 25 Mar 2022 02:19:48 +0000 (22:19 -0400)]
Add linguist-language tag for dns zones
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Otto Moerbeek [Fri, 25 Mar 2022 14:13:26 +0000 (15:13 +0100)]
Fill in PR#s for Security Advisory 2022-01
Peter van Dijk [Fri, 25 Mar 2022 12:21:52 +0000 (13:21 +0100)]
secpoll: fix typos
Peter van Dijk [Fri, 25 Mar 2022 12:00:45 +0000 (13:00 +0100)]
Merge pull request #11452 from omoerbeek/prep-docs-2022-01
rec/auth: Prep for security release 2022-01 (low severity)
Fred Morcos [Fri, 25 Mar 2022 10:39:53 +0000 (11:39 +0100)]
Merge pull request #11450 from fredmorcos/checked-stoi-empty-str-fix
`checked_stoi` fix: Don't leave `idx`/`pos` uninitialized when the input string is empty
Kees Monshouwer [Fri, 25 Mar 2022 10:10:00 +0000 (11:10 +0100)]
format decafsigners.cc
Fred Morcos [Fri, 25 Mar 2022 08:52:29 +0000 (09:52 +0100)]
Don't leave idx/pos uninitialized when input str is empty
Peter van Dijk [Fri, 25 Mar 2022 09:12:49 +0000 (10:12 +0100)]
Merge pull request #11449 from rgacogne/docs-pin-jinja2
docs: Pin jinja2 to < 3.1.0
Remi Gacogne [Fri, 25 Mar 2022 08:45:55 +0000 (09:45 +0100)]
docs: Pin jinja2 to < 3.1.0
Jinja2 3.1.0 removed deprecated code that is still used by sphinx
1.8.x, and it looks like our custom sphinx extensions are not working
with more recent versions of sphinx..
See:
- https://github.com/pallets/jinja/issues/1631
- https://github.com/readthedocs/readthedocs.org/issues/9037
and
- https://github.com/PowerDNS/pdns/pull/7712
The exact error is:
```
Extension error:
Could not import extension sphinx.builders.latex (exception: cannot import name 'contextfunction' from 'jinja2' (/dnsdist/pdns/dnsdistdist/.venv/lib/python3.7/site-packages/jinja2/__init__.py))
```
Otto Moerbeek [Fri, 25 Mar 2022 08:04:19 +0000 (09:04 +0100)]
Prep for 2022-01
Fred Morcos [Wed, 23 Mar 2022 14:02:16 +0000 (15:02 +0100)]
Merge pull request #11438 from fredmorcos/checked-conv-boundary-val-fix
Checked int conversions: Avoid checks when boundary values are equal
Otto Moerbeek [Wed, 23 Mar 2022 12:48:52 +0000 (13:48 +0100)]
Only log "Unable to send NOD lookup" if log-common-errors is set
Fixes #11440.
Otto Moerbeek [Wed, 23 Mar 2022 12:08:52 +0000 (13:08 +0100)]
Merge pull request #11443 from omoerbeek/rec-syncres-tables1
rec: Move implemenation of failed and non-resolving table to .cc file
Otto Moerbeek [Wed, 23 Mar 2022 12:08:40 +0000 (13:08 +0100)]
Merge pull request #11442 from omoerbeek/rec-docs-api-config-dir
rec: Note that api-config-dir and include-dir should be the same for updates via REST to work
Fred Morcos [Mon, 21 Mar 2022 13:52:55 +0000 (14:52 +0100)]
Checked int conversions: Avoid checks when boundary values are equal
Otto Moerbeek [Wed, 23 Mar 2022 09:38:59 +0000 (10:38 +0100)]
Move implemenation of failed and non-resolving table to .cc file
Otto Moerbeek [Wed, 23 Mar 2022 08:55:53 +0000 (09:55 +0100)]
Note that api-config-dir and include-dir should be the same for dynamic updates of config to work.
Plus fix assorted typos. Fixes #11439
Otto Moerbeek [Mon, 21 Mar 2022 11:35:51 +0000 (12:35 +0100)]
Merge pull request #11308 from omoerbeek/rec-save-parent-ns
rec: Remember parent NS set, to be able to fallback to it if needed
Otto Moerbeek [Mon, 21 Mar 2022 11:35:32 +0000 (12:35 +0100)]
Merge pull request #11396 from omoerbeek/rec-proxy-by-table
Rec: proxy by table
Otto Moerbeek [Tue, 1 Mar 2022 14:32:59 +0000 (15:32 +0100)]
proxyMapping: a table based approach to let the recursor know the actual IP address it should use for ACLS etc
Remi Gacogne [Mon, 21 Mar 2022 09:31:53 +0000 (10:31 +0100)]
Merge pull request #11436 from rgacogne/ddist-unbreak-optional
dnsdist: Fix compilation by adding a missing <optional> include in misc.cc
Remi Gacogne [Mon, 21 Mar 2022 09:27:30 +0000 (10:27 +0100)]
dnsdist: Only allocate the health-check mplexer when needed
When health-checking is disabled, or when a check delay longer than one
second is used, there is no need to allocate a new multiplexer object
every second.
Otto Moerbeek [Fri, 18 Mar 2022 16:04:52 +0000 (17:04 +0100)]
Apply suggestions from code review
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Otto Moerbeek [Fri, 18 Mar 2022 13:58:19 +0000 (14:58 +0100)]
Test for saved parent set
Otto Moerbeek [Fri, 18 Mar 2022 12:38:45 +0000 (13:38 +0100)]
Docs, and config switch (default off)
Otto Moerbeek [Fri, 18 Mar 2022 12:16:17 +0000 (13:16 +0100)]
Moved SavedParentSet class to syncres.cc
Otto Moerbeek [Tue, 15 Mar 2022 14:31:13 +0000 (15:31 +0100)]
The nsset can change, so we have to be prepared for that
Otto Moerbeek [Tue, 15 Mar 2022 12:35:54 +0000 (13:35 +0100)]
Process comment reviews
Otto Moerbeek [Fri, 4 Mar 2022 14:12:47 +0000 (15:12 +0100)]
Man page addition
Otto [Tue, 19 Oct 2021 08:48:28 +0000 (10:48 +0200)]
Remember parent NS set, to be able to fallback to it if needed
When a non-auth NS set is replaced by an auth one, remember the non-auth one if
it contains NS not in the auth set.
Use that NS set later as a fallback if resolving fails.
TODO: general validation of method, pruning the new table, tests, config switch?
Should fix #10594
Remi Gacogne [Mon, 21 Mar 2022 08:52:19 +0000 (09:52 +0100)]
dnsdist: Fix compilation by adding a missing <optional> include in misc.cc
Otherwise g++ 11.2.0 complains here:
```
misc.cc: In function ‘int makeIPv6sockaddr(const string&, sockaddr_in6*)’:
misc.cc:711:8: error: ‘optional’ is not a member of ‘std’
711 | std::optional<uint16_t> port = std::nullopt;
| ^~~~~~~~
misc.cc:61:1: note: ‘std::optional’ is defined in header ‘<optional>’; did you forget to ‘#include <optional>’?
```
Otto Moerbeek [Fri, 18 Mar 2022 15:41:22 +0000 (16:41 +0100)]
Merge pull request #11433 from omoerbeek/dnsdist-include-um
dnsdist: fix build on MacOS and OpenBSD: include <unordered_map>
Otto Moerbeek [Fri, 18 Mar 2022 14:47:39 +0000 (15:47 +0100)]
include <unordered_map>
Fred Morcos [Fri, 18 Mar 2022 14:33:01 +0000 (15:33 +0100)]
Merge pull request #11432 from fredmorcos/11429-fix-pem-import-export-on-old-ssl
Enable named curves on ECDSA key generation and import from ISC
Fred Morcos [Fri, 18 Mar 2022 14:05:59 +0000 (15:05 +0100)]
Merge pull request #11430 from fredmorcos/get-msg-from-errno-macos-fix
Make getMessageFromErrno work on broken MacOS strerror_r
Fred Morcos [Fri, 18 Mar 2022 12:00:17 +0000 (13:00 +0100)]
Enable named curves on ECDSA key generation and import from ISC
Fixes #11429
Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
Fred Morcos [Fri, 18 Mar 2022 11:47:06 +0000 (12:47 +0100)]
strerror_r on MacOS returns int despite _GNU_SOURCE being defined
Peter van Dijk [Fri, 18 Mar 2022 07:34:05 +0000 (08:34 +0100)]
Merge pull request #11423 from Habbie/auth-rfc-typo
auth docs: fix typo in RFC number
Kees Monshouwer [Thu, 17 Mar 2022 14:48:52 +0000 (15:48 +0100)]
decaf signer did not compile after #11414
Fred Morcos [Thu, 17 Mar 2022 13:39:24 +0000 (14:39 +0100)]
Merge pull request #11414 from fredmorcos/11325-ecdsa-pem
Import and export of ECDSA keys from/to PEM
Remi Gacogne [Thu, 17 Mar 2022 13:15:23 +0000 (14:15 +0100)]
Merge pull request #11410 from rgacogne/ddist-lua-types
dnsdist: Define types for Lua arrays and associative arrays
Fred Morcos [Thu, 17 Mar 2022 13:06:10 +0000 (14:06 +0100)]
Merge pull request #11425 from fredmorcos/add-fred-to-changelog-scripts
Add `fredmorcos` to changelog scripts
Fred Morcos [Thu, 17 Mar 2022 11:11:14 +0000 (12:11 +0100)]
Add my username to changelog scripts
Fred Morcos [Wed, 16 Mar 2022 13:05:35 +0000 (14:05 +0100)]
Cleanup makeIPv6sockaddr
Fred Morcos [Wed, 16 Mar 2022 12:55:16 +0000 (13:55 +0100)]
Formatting makeIPv6sockaddr
Fred Morcos [Wed, 16 Mar 2022 11:52:46 +0000 (12:52 +0100)]
Cleanup: uint16_t port value cannot be larger than 65535
Fred Morcos [Tue, 15 Mar 2022 12:53:27 +0000 (13:53 +0100)]
Disable the use-trailing-return-type diagnostic from clang-tidy
Fred Morcos [Tue, 15 Mar 2022 09:33:14 +0000 (10:33 +0100)]
Add import/export-zone-key-pem to pdnsutil bash completion
Fred Morcos [Tue, 15 Mar 2022 09:29:22 +0000 (10:29 +0100)]
Update pdnsutil command-line help
closes: #11321
Fred Morcos [Tue, 15 Mar 2022 09:27:27 +0000 (10:27 +0100)]
User documentation of import-zone-key-pem and export-zone-key-pem
Fred Morcos [Tue, 15 Mar 2022 09:27:09 +0000 (10:27 +0100)]
User documentation: Typo
Fred Morcos [Mon, 14 Mar 2022 10:26:43 +0000 (11:26 +0100)]
Support the export of ECDSA keys to PEM
Part of #11325
Fred Morcos [Sun, 27 Feb 2022 19:23:29 +0000 (20:23 +0100)]
Support the import of ECDSA keys from PEM files
- Add support to import ECDSA keys from PEM files.
- Adds a test for ECDSA key import from PEM.
- Instantiate key engine without trial-and-error algorithm search.
Part of #11325
Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
Fred Morcos [Wed, 9 Mar 2022 09:16:52 +0000 (10:16 +0100)]
Add a helper to get errno message in a reasonable way
Fred Morcos [Mon, 21 Feb 2022 09:44:21 +0000 (10:44 +0100)]
Cleanup
Fred Morcos [Mon, 21 Feb 2022 09:39:18 +0000 (10:39 +0100)]
Formatting
Fred Morcos [Wed, 16 Feb 2022 08:43:48 +0000 (09:43 +0100)]
Whitespace
Remi Gacogne [Thu, 17 Mar 2022 09:24:25 +0000 (10:24 +0100)]
dnsdist: Define types for Lua arrays and associative arrays
That PR defines types for the mapping of Lua arrays and associatives
arrays to C++, improving readability and consistency.
Peter van Dijk [Thu, 17 Mar 2022 07:01:56 +0000 (08:01 +0100)]
auth docs: fix typo in RFC number
Peter van Dijk [Wed, 16 Mar 2022 18:36:56 +0000 (19:36 +0100)]
Merge pull request #11421 from Habbie/docs-algoroll
auth docs: add algorithm rolling guide
Peter van Dijk [Wed, 16 Mar 2022 11:36:06 +0000 (12:36 +0100)]
auth docs: add algorithm rolling guide
Otto Moerbeek [Tue, 15 Mar 2022 13:13:40 +0000 (14:13 +0100)]
Merge pull request #11382 from omoerbeek/rec-forward-docs
rec: Document forward-zones behavior better wrt delegations.
Fred Morcos [Tue, 15 Mar 2022 09:53:11 +0000 (10:53 +0100)]
Merge pull request #11401 from fredmorcos/checked-str-int-conversions
Checked conversion from string to signed/unsigned integer
Fred Morcos [Tue, 15 Mar 2022 08:54:45 +0000 (09:54 +0100)]
Port values should always be uint16_t
Fred Morcos [Tue, 15 Mar 2022 08:53:34 +0000 (09:53 +0100)]
Integral value of an algorithm should always be unsigned
Fred Morcos [Mon, 7 Mar 2022 08:07:23 +0000 (09:07 +0100)]
Move most of pdns_stou to Pdns::stoi and Pdns::stou
This also creates the Pdns namespace and renames pdns_stou to Pdns::stou and separates
signed from unsigned conversion (Pdns::stoi and Pdns::stou) which are now implemented in
terms of Pdns::checked_conv and return a generic integer.
Fred Morcos [Mon, 7 Mar 2022 08:44:42 +0000 (09:44 +0100)]
Fix printf format string
Fred Morcos [Fri, 4 Mar 2022 11:18:43 +0000 (12:18 +0100)]
Formatting
Fred Morcos [Fri, 4 Mar 2022 11:18:29 +0000 (12:18 +0100)]
Whitespace
Fred Morcos [Mon, 7 Mar 2022 09:00:40 +0000 (10:00 +0100)]
Fix dist doc warning
Fred Morcos [Tue, 8 Mar 2022 11:37:56 +0000 (12:37 +0100)]
Enable code documentation for all items
Fred Morcos [Tue, 8 Mar 2022 11:36:51 +0000 (12:36 +0100)]
GitIgnore codedocs/html directory
Fred Morcos [Mon, 7 Mar 2022 08:49:37 +0000 (09:49 +0100)]
GitIgnore clangd cache dir under recorsor and dist
Otto Moerbeek [Mon, 14 Mar 2022 20:53:36 +0000 (21:53 +0100)]
Merge pull request #11405 from omoerbeek/rec-perm-vs-timeout
rec: Distinguish between unreachable and timeout for throttling
Otto Moerbeek [Mon, 14 Mar 2022 20:38:07 +0000 (21:38 +0100)]
Merge pull request #11397 from omoerbeek/rec-clean-tcp
rec: Wrong task was used to clean outgoing TCP
Otto Moerbeek [Mon, 14 Mar 2022 20:37:44 +0000 (21:37 +0100)]
Merge pull request #11376 from omoerbeek/rec-refresh-qm-ns-interaction
rec: Be more careful using refresh mode only for the record asked.
Otto Moerbeek [Mon, 14 Mar 2022 20:35:19 +0000 (21:35 +0100)]
typo
Co-authored-by: Remi Gacogne <github@coredump.fr>
Fred Morcos [Mon, 14 Mar 2022 15:06:37 +0000 (16:06 +0100)]
Merge pull request #11377 from fredmorcos/documentation-devenv
Documentation for a PowerDNS development environment based on a language server
Otto Moerbeek [Fri, 4 Mar 2022 08:03:00 +0000 (09:03 +0100)]
Add instructions to use `compiledb`.
Fred Morcos [Wed, 2 Mar 2022 12:57:49 +0000 (13:57 +0100)]
Documentation: Add section about minimal Emacs devenv with Eglot
Fred Morcos [Sun, 27 Feb 2022 03:43:29 +0000 (04:43 +0100)]
Documentation: Add section on debugging
Fred Morcos [Sat, 26 Feb 2022 14:49:54 +0000 (15:49 +0100)]
Documentation: Add document about devenv with a language server
Also adds documentation on setting up Emacs to work with `clangd` and
`clang-tidy` using `lsp-mode`.
Fred Morcos [Sat, 26 Feb 2022 14:49:41 +0000 (15:49 +0100)]
Documentation: Add section on code checkers and `clang-tidy`
Peter van Dijk [Mon, 14 Mar 2022 14:01:00 +0000 (15:01 +0100)]
Merge pull request #11415 from Habbie/dnsdist-newserver-default-port
dnsdist: more useful default ports for DoT/DoH backends