]> git.ipfire.org Git - thirdparty/pdns.git/log
thirdparty/pdns.git
2 years agoreport which backend failed to instantiate 13065/head
Peter van Dijk [Mon, 24 Jul 2023 08:52:56 +0000 (10:52 +0200)] 
report which backend failed to instantiate

2 years agoMerge pull request #13012 from rgacogne/ddist-healthcheck-spurious
Remi Gacogne [Thu, 20 Jul 2023 10:18:14 +0000 (12:18 +0200)] 
Merge pull request #13012 from rgacogne/ddist-healthcheck-spurious

dnsdist: Better handling of spurious wake-ups, interrupted calls

2 years agoMerge pull request #13041 from rgacogne/auth-coverity
Remi Gacogne [Thu, 20 Jul 2023 10:08:52 +0000 (12:08 +0200)] 
Merge pull request #13041 from rgacogne/auth-coverity

auth: Fix a bunch of warnings reported by Coverity

2 years agodnsdist: Add suggestions from code review 13012/head
Remi Gacogne [Thu, 20 Jul 2023 09:17:27 +0000 (11:17 +0200)] 
dnsdist: Add suggestions from code review

2 years agoMerge pull request #13021 from omoerbeek/rec-pb-cache-tags
Otto Moerbeek [Thu, 20 Jul 2023 09:14:19 +0000 (11:14 +0200)] 
Merge pull request #13021 from omoerbeek/rec-pb-cache-tags

Rec: fix setting of policy tags

2 years agoMerge pull request #13052 from rgacogne/fix-getmessagefromerrno-libcrypto
Remi Gacogne [Thu, 20 Jul 2023 08:59:09 +0000 (10:59 +0200)] 
Merge pull request #13052 from rgacogne/fix-getmessagefromerrno-libcrypto

misc: `pdns::getMessageFromErrno()` does not depend on libcrypto

2 years agoMerge pull request #13042 from jpmens/patch-15
Remi Gacogne [Thu, 20 Jul 2023 08:57:55 +0000 (10:57 +0200)] 
Merge pull request #13042 from jpmens/patch-15

Typo in dnsupdate.rst

2 years agoApply suggestions from code review 13021/head
Otto Moerbeek [Mon, 17 Jul 2023 10:10:35 +0000 (12:10 +0200)] 
Apply suggestions from code review

Co-authored-by: Remi Gacogne <github@coredump.fr>
2 years agoDo not store tags set by gettag(_ffi) into the PC by keeping them separate.
Otto Moerbeek [Fri, 14 Jul 2023 10:52:08 +0000 (12:52 +0200)] 
Do not store tags set by gettag(_ffi) into the PC by keeping them separate.

We do pass them to the other Lua functions, but take care to erase them
aagin before creating the partial PB message stored into the cache.

2 years agoUse gettag
Otto Moerbeek [Wed, 12 Jul 2023 13:15:57 +0000 (15:15 +0200)] 
Use gettag

2 years agoSet the pb policy tags in the right places
Otto Moerbeek [Wed, 12 Jul 2023 12:58:53 +0000 (14:58 +0200)] 
Set the pb policy tags in the right places

2 years agoRegression test for pb tags coming out of packet cache or not
Otto Moerbeek [Wed, 12 Jul 2023 12:46:23 +0000 (14:46 +0200)] 
Regression test for pb tags coming out of packet cache or not

2 years agomisc: `pdns::getMessageFromErrno()` does not depend on libcrypto 13052/head
Remi Gacogne [Thu, 20 Jul 2023 08:09:12 +0000 (10:09 +0200)] 
misc: `pdns::getMessageFromErrno()` does not depend on libcrypto

This prevents compiling dnsdist when libcrypto is not available, which
should be possible.

2 years agoMerge pull request #13047 from Habbie/pyyaml-6.0.1
Peter van Dijk [Thu, 20 Jul 2023 07:54:19 +0000 (09:54 +0200)] 
Merge pull request #13047 from Habbie/pyyaml-6.0.1

auth docs: pin pyyaml 6.0.1 specifically

2 years agoMerge pull request #13045 from omoerbeek/less-copyright-years
Otto Moerbeek [Thu, 20 Jul 2023 05:51:09 +0000 (07:51 +0200)] 
Merge pull request #13045 from omoerbeek/less-copyright-years

Further removal op copyright years

2 years agoMerge pull request #13048 from omoerbeek/rec-dnstap-regr-errno
Otto Moerbeek [Tue, 18 Jul 2023 12:51:28 +0000 (14:51 +0200)] 
Merge pull request #13048 from omoerbeek/rec-dnstap-regr-errno

rec: include errno in dnstap regression test

2 years agoinclude errno 13048/head
Otto Moerbeek [Tue, 18 Jul 2023 11:48:11 +0000 (13:48 +0200)] 
include errno

to avoid:
     File "/__w/pdns/pdns/regression-tests.recursor-dnssec/test_RecDnstap.py", line 189, in FrameStreamUnixListener
        if e.errno in (errno.EBADF, errno.EPIPE):
     NameError: name 'errno' is not defined

2 years agoauth docs: pin pyyaml 6.0.1 specifically, see #13046 13047/head
Peter van Dijk [Tue, 18 Jul 2023 09:49:18 +0000 (11:49 +0200)] 
auth docs: pin pyyaml 6.0.1 specifically, see #13046

2 years agoRemove copyright years in webserver output; noted by @mind04 13045/head
Otto Moerbeek [Tue, 18 Jul 2023 08:18:31 +0000 (10:18 +0200)] 
Remove copyright years in webserver output; noted by @mind04

2 years agoFurther removal op copyright years
Otto Moerbeek [Tue, 18 Jul 2023 08:09:32 +0000 (10:09 +0200)] 
Further removal op copyright years

Fixes #13004

2 years agoMerge pull request #13044 from omoerbeek/copyright-no-year
Peter van Dijk [Mon, 17 Jul 2023 17:29:06 +0000 (19:29 +0200)] 
Merge pull request #13044 from omoerbeek/copyright-no-year

Do not include year(s) in copyright messages.

2 years agoDo not include year(s) in copyright messages. 13044/head
Otto Moerbeek [Mon, 17 Jul 2023 15:00:04 +0000 (17:00 +0200)] 
Do not include year(s) in copyright messages.

It's too hard to keep up-to-date and serves no real purpose.

2 years agoTypo in dnsupdate.rst 13042/head
Jan-Piet Mens [Mon, 17 Jul 2023 13:28:18 +0000 (15:28 +0200)] 
Typo in dnsupdate.rst

2 years agoMerge pull request #13040 from zeha/rm-dnsproxy-unused-decl
Peter van Dijk [Mon, 17 Jul 2023 13:05:39 +0000 (15:05 +0200)] 
Merge pull request #13040 from zeha/rm-dnsproxy-unused-decl

auth: DNSProxy: remove declaration without implementation

2 years agoauth: Fix 'exceptions not caught' warnings from Coverity 13041/head
Remi Gacogne [Mon, 17 Jul 2023 10:19:11 +0000 (12:19 +0200)] 
auth: Fix 'exceptions not caught' warnings from Coverity

2 years agoauth: Apply Coverity's suggestion to prevent copies in loops w/ auto
Remi Gacogne [Mon, 17 Jul 2023 10:18:10 +0000 (12:18 +0200)] 
auth: Apply Coverity's suggestion to prevent copies in loops w/ auto

2 years agoauth: DNSProxy: remove declaration without implementation 13040/head
Chris Hofstaedtler [Mon, 17 Jul 2023 11:52:19 +0000 (13:52 +0200)] 
auth: DNSProxy: remove declaration without implementation

2 years agoMerge pull request #12753 from cmouse/pkcs11-relogin
Peter van Dijk [Mon, 17 Jul 2023 11:36:39 +0000 (13:36 +0200)] 
Merge pull request #12753 from cmouse/pkcs11-relogin

pkcs11signers: If private key object has CKA_ALWAYS_AUTHENTICATE attribute, perform CKU_CONTEXT_SPECIFIC login after OperationInit to make it actually work.

2 years agoMerge pull request #13032 from setharnold/patch-8
Otto Moerbeek [Mon, 17 Jul 2023 11:23:49 +0000 (13:23 +0200)] 
Merge pull request #13032 from setharnold/patch-8

Update settings.rst -- clarify edns-subnet-allow-list

2 years agoMerge pull request #13035 from Call-Me-G-Now/patch-3
Remi Gacogne [Mon, 17 Jul 2023 10:20:27 +0000 (12:20 +0200)] 
Merge pull request #13035 from Call-Me-G-Now/patch-3

Update dnsdist changelog

2 years agoauth: Apply Coverity's suggestions to initialize field members
Remi Gacogne [Mon, 17 Jul 2023 10:17:38 +0000 (12:17 +0200)] 
auth: Apply Coverity's suggestions to initialize field members

2 years agoauth: Apply Coverity's suggestions to move objects whenever possible
Remi Gacogne [Mon, 17 Jul 2023 10:16:47 +0000 (12:16 +0200)] 
auth: Apply Coverity's suggestions to move objects whenever possible

2 years agoRemove dnsdist-healthchecks.* from the 'not formatted' list
Remi Gacogne [Tue, 11 Jul 2023 08:40:53 +0000 (10:40 +0200)] 
Remove dnsdist-healthchecks.* from the 'not formatted' list

2 years agodnsdist: Reformat dnsdist-healthchecks.cc and dnsdist-healthchecks.hh
Remi Gacogne [Tue, 11 Jul 2023 08:38:57 +0000 (10:38 +0200)] 
dnsdist: Reformat dnsdist-healthchecks.cc and dnsdist-healthchecks.hh

2 years agodnsdist: Delint dnsdist-healthchecks.cc
Remi Gacogne [Tue, 11 Jul 2023 08:37:08 +0000 (10:37 +0200)] 
dnsdist: Delint dnsdist-healthchecks.cc

2 years agodnsdist: Better handling of spurious wake-ups, interrupted calls
Remi Gacogne [Mon, 10 Jul 2023 15:49:51 +0000 (17:49 +0200)] 
dnsdist: Better handling of spurious wake-ups, interrupted calls

If we were woken up by the multiplexer but have actually nothing to read,
or the call to `recv()` is interrupted, we do not want to stop listening
for the health-check response event. It is also not useful to log about
it, even at "verbose health-check" level.
Note that we would have logged previously, so this kind of event would
not have gone unnoticed anyway.

2 years agoMerge pull request #13036 from Habbie/dnsdist-changelog-indent
Remi Gacogne [Mon, 17 Jul 2023 08:14:25 +0000 (10:14 +0200)] 
Merge pull request #13036 from Habbie/dnsdist-changelog-indent

dnsdist changelog: fix indentation of this line

2 years agoMerge pull request #13026 from rgacogne/dnsheader-bitfield-uint16
Remi Gacogne [Mon, 17 Jul 2023 08:08:06 +0000 (10:08 +0200)] 
Merge pull request #13026 from rgacogne/dnsheader-bitfield-uint16

dnsheader: Switch from bitfield to uint16_t whenever possible

2 years agodnsdist changelog: fix indentation of this line 13036/head
Peter van Dijk [Mon, 17 Jul 2023 07:03:23 +0000 (09:03 +0200)] 
dnsdist changelog: fix indentation of this line

2 years agoMerge pull request #13034 from Call-Me-G-Now/patch-2
Peter van Dijk [Mon, 17 Jul 2023 06:55:47 +0000 (08:55 +0200)] 
Merge pull request #13034 from Call-Me-G-Now/patch-2

Update recursor changelog

2 years agoMerge pull request #13033 from Call-Me-G-Now/patch-1
Peter van Dijk [Mon, 17 Jul 2023 06:55:00 +0000 (08:55 +0200)] 
Merge pull request #13033 from Call-Me-G-Now/patch-1

update changelog

2 years agoUpdate changelog 13035/head
Call-Me-G-Now [Sun, 16 Jul 2023 20:34:28 +0000 (22:34 +0200)] 
Update changelog

2 years agoUpdate changelog
Call-Me-G-Now [Sun, 16 Jul 2023 20:28:21 +0000 (22:28 +0200)] 
Update changelog

2 years agoUpdate changelog
Call-Me-G-Now [Sun, 16 Jul 2023 20:13:44 +0000 (22:13 +0200)] 
Update changelog

2 years agoUpdate changelog 13034/head
Call-Me-G-Now [Sun, 16 Jul 2023 19:58:55 +0000 (21:58 +0200)] 
Update changelog

Naming inconsistencies pdns-auth <> pdns-rec docs

- Release Notes <> Release Guide
- upgrading.html <> upgrade.html

2 years agoUpdate changelog
Call-Me-G-Now [Sun, 16 Jul 2023 19:54:07 +0000 (21:54 +0200)] 
Update changelog

2 years agocleanup 13033/head
Call-Me-G-Now [Sun, 16 Jul 2023 19:17:50 +0000 (21:17 +0200)] 
cleanup

2 years agoupdate changelog
Call-Me-G-Now [Sun, 16 Jul 2023 19:12:33 +0000 (21:12 +0200)] 
update changelog

2 years agoUpdate settings.rst -- clarify edns-subnet-allow-list 13032/head
Seth Arnold [Sat, 15 Jul 2023 01:21:01 +0000 (01:21 +0000)] 
Update settings.rst -- clarify edns-subnet-allow-list

Try to reduce confusion about what the edns-subnet-allow-list setting does and doesn't affect.

2 years agoMerge pull request #13029 from kovacs-andras/master
Peter van Dijk [Thu, 13 Jul 2023 23:19:09 +0000 (01:19 +0200)] 
Merge pull request #13029 from kovacs-andras/master

wait for mysql.service

2 years agowait for mysql.service 13029/head
Andras Kovacs [Thu, 13 Jul 2023 20:44:02 +0000 (22:44 +0200)] 
wait for mysql.service

2 years agodnsheader: Switch from bitfield to uint16_t whenever possible 13026/head
Remi Gacogne [Thu, 13 Jul 2023 08:42:55 +0000 (10:42 +0200)] 
dnsheader: Switch from bitfield to uint16_t whenever possible

2 years agopkcs11signers: Add braces 12753/head
Aki Tuomi [Thu, 4 May 2023 19:36:18 +0000 (22:36 +0300)] 
pkcs11signers: Add braces

Satisfies clang-tidy

2 years agopkcs11signers: Support CKA_ALWAYS_AUTHENTICATE
Aki Tuomi [Sun, 16 Apr 2023 18:09:29 +0000 (21:09 +0300)] 
pkcs11signers: Support CKA_ALWAYS_AUTHENTICATE

If private key has this flag, relogin with CKU_CONTEXT_SPECIFIC
before sign/verify operation.

2 years agopkcs11signers: Use emplace_back for attributes
Aki Tuomi [Thu, 13 Jul 2023 06:51:45 +0000 (09:51 +0300)] 
pkcs11signers: Use emplace_back for attributes

2 years agoMerge pull request #13022 from omoerbeek/rec-fix-arc4random-linking
Otto Moerbeek [Wed, 12 Jul 2023 14:26:36 +0000 (16:26 +0200)] 
Merge pull request #13022 from omoerbeek/rec-fix-arc4random-linking

rec: libarc4random should be linked even if libsodium is not used

2 years agorec: libarc4random should be linked even if libsodium is not used 13022/head
Otto Moerbeek [Wed, 12 Jul 2023 13:43:55 +0000 (15:43 +0200)] 
rec: libarc4random should be linked even if libsodium is not used

2 years agoMerge pull request #13009 from rgacogne/ddist-heathcheck-metrics
Remi Gacogne [Tue, 11 Jul 2023 08:59:43 +0000 (10:59 +0200)] 
Merge pull request #13009 from rgacogne/ddist-heathcheck-metrics

dnsdist: Add metrics for health-check failures

2 years agodnsdist: Add a couple comments in the health-check timeout handling code 13009/head
Remi Gacogne [Tue, 11 Jul 2023 08:15:51 +0000 (10:15 +0200)] 
dnsdist: Add a couple comments in the health-check timeout handling code

2 years agodnsdist: Add metrics for health-check failures
Remi Gacogne [Mon, 10 Jul 2023 11:50:57 +0000 (13:50 +0200)] 
dnsdist: Add metrics for health-check failures

2 years agoMerge pull request #12938 from omoerbeek/auth-coverty-time_t
Otto Moerbeek [Mon, 10 Jul 2023 08:56:04 +0000 (10:56 +0200)] 
Merge pull request #12938 from omoerbeek/auth-coverty-time_t

auth: Fix coverity time_t related warnings

2 years agoMerge pull request #12912 from omoerbeek/rec-nose-to-pytest
Otto Moerbeek [Mon, 10 Jul 2023 08:55:48 +0000 (10:55 +0200)] 
Merge pull request #12912 from omoerbeek/rec-nose-to-pytest

rec: Upgrade regression tests to use pytest instead of nose

2 years agoMerge pull request #12805 from hlindqvist/clarify-log-aa-not-set
Otto Moerbeek [Mon, 10 Jul 2023 08:55:06 +0000 (10:55 +0200)] 
Merge pull request #12805 from hlindqvist/clarify-log-aa-not-set

Clarify log message for NODATA/NXDOMAIN without AA

2 years agoMerge pull request #12976 from rgacogne/ddist-fix-doh-xforwardedfor-maxtcpconnperclient
Remi Gacogne [Mon, 10 Jul 2023 08:48:40 +0000 (10:48 +0200)] 
Merge pull request #12976 from rgacogne/ddist-fix-doh-xforwardedfor-maxtcpconnperclient

dnsdist: Fix a crash when X-Forwarded-For overrides the initial source IP

2 years agoMerge pull request #12974 from rgacogne/ddist-coverity-394511
Remi Gacogne [Mon, 10 Jul 2023 08:47:20 +0000 (10:47 +0200)] 
Merge pull request #12974 from rgacogne/ddist-coverity-394511

dnsdist: Fix "Pointer to local outside storage" reported by Coverity

2 years agoMerge pull request #13001 from omoerbeek/arc4random-build-fix2
Otto Moerbeek [Fri, 7 Jul 2023 13:50:17 +0000 (15:50 +0200)] 
Merge pull request #13001 from omoerbeek/arc4random-build-fix2

Fix build part2: include chacha_private.h and explicit_bzero.c

2 years agoMerge pull request #13002 from Habbie/auth-4.8.1-docs-secpoll
Peter van Dijk [Fri, 7 Jul 2023 12:52:28 +0000 (14:52 +0200)] 
Merge pull request #13002 from Habbie/auth-4.8.1-docs-secpoll

auth 4.8.1: docs & secpoll

2 years agoauth 4.8.1: docs & secpoll 13002/head
Peter van Dijk [Fri, 7 Jul 2023 12:32:33 +0000 (14:32 +0200)] 
auth 4.8.1: docs & secpoll

2 years agoUse PDNS_CHECK_SECURE_MEMSET, as suggested by @rcagogne 13001/head
Otto Moerbeek [Fri, 7 Jul 2023 12:03:33 +0000 (14:03 +0200)] 
Use PDNS_CHECK_SECURE_MEMSET, as suggested by @rcagogne

2 years agoAlso include explcit_bzero(), which is needed when using older glibc
Otto Moerbeek [Fri, 7 Jul 2023 10:49:24 +0000 (12:49 +0200)] 
Also include explcit_bzero(), which is needed when using older glibc

2 years agoFix build: put chacha_private.h into _SOURCES
Otto Moerbeek [Fri, 7 Jul 2023 10:02:14 +0000 (12:02 +0200)] 
Fix build: put chacha_private.h into _SOURCES

Also fix redundant declaration warnings

Followup to #12999

2 years agoMerge pull request #12999 from omoerbeek/arc4random-build-fix
Otto Moerbeek [Fri, 7 Jul 2023 09:51:55 +0000 (11:51 +0200)] 
Merge pull request #12999 from omoerbeek/arc4random-build-fix

Fix build: put arc4random.hh into _SOURCES

2 years agoFix build: put arc4random.hh into _SOURCES 12999/head
Otto Moerbeek [Fri, 7 Jul 2023 09:04:23 +0000 (11:04 +0200)] 
Fix build: put arc4random.hh into _SOURCES

Also a tiny bit of cleanup

2 years agoMerge pull request #12931 from omoerbeek/use-arc4random
Otto Moerbeek [Fri, 7 Jul 2023 06:14:26 +0000 (08:14 +0200)] 
Merge pull request #12931 from omoerbeek/use-arc4random

Use arc4random only for random values

2 years agoMerge pull request #12985 from Habbie/lmdb-check-index
Peter van Dijk [Thu, 6 Jul 2023 14:59:26 +0000 (16:59 +0200)] 
Merge pull request #12985 from Habbie/lmdb-check-index

auth lmdb: add backend commands for checking & refreshing indexes

2 years agoMerge pull request #12990 from Habbie/lmdb-dup-delete-rwtx
Peter van Dijk [Thu, 6 Jul 2023 14:58:46 +0000 (16:58 +0200)] 
Merge pull request #12990 from Habbie/lmdb-dup-delete-rwtx

auth lmdb: in Lightning Stream mode, during deleteDomain, use RW transaction to get ID list

2 years agodelint waitFor2Data 12931/head
Otto Moerbeek [Tue, 20 Jun 2023 14:57:21 +0000 (16:57 +0200)] 
delint waitFor2Data

2 years agoRemove commented out code, add #pragma once
Otto Moerbeek [Tue, 20 Jun 2023 14:47:35 +0000 (16:47 +0200)] 
Remove commented out code, add #pragma once

2 years agoBuild libarc4random in CodeQL target for dnsdist
Otto Moerbeek [Tue, 20 Jun 2023 14:31:27 +0000 (16:31 +0200)] 
Build libarc4random in CodeQL target for dnsdist

2 years agoFix dependency for remote backend test code
Otto Moerbeek [Tue, 20 Jun 2023 13:29:03 +0000 (15:29 +0200)] 
Fix dependency for remote backend test code

2 years agoFuzzing target needs arc4random as well
Otto Moerbeek [Tue, 20 Jun 2023 11:46:50 +0000 (13:46 +0200)] 
Fuzzing target needs arc4random as well

2 years agoFix configure syntax
Otto Moerbeek [Tue, 20 Jun 2023 11:11:07 +0000 (13:11 +0200)] 
Fix configure syntax

2 years agoZap reference to dns_random_urandom.cc
Otto Moerbeek [Tue, 20 Jun 2023 10:56:23 +0000 (12:56 +0200)] 
Zap reference to dns_random_urandom.cc

2 years agoFormat
Otto Moerbeek [Tue, 20 Jun 2023 10:52:41 +0000 (12:52 +0200)] 
Format

2 years agoStop using random(), only place left is in dnsdist-random.cc as a fallback
Otto Moerbeek [Tue, 20 Jun 2023 10:50:36 +0000 (12:50 +0200)] 
Stop using random(), only place left is in dnsdist-random.cc as a fallback

2 years agoTweaks for macOS
Otto Moerbeek [Tue, 20 Jun 2023 10:01:54 +0000 (12:01 +0200)] 
Tweaks for macOS

2 years agoStart buildina and using arc4random
Otto Moerbeek [Tue, 20 Jun 2023 09:19:42 +0000 (11:19 +0200)] 
Start buildina and using arc4random

2 years agoPort of the openss-poratble arc4random code to our build environment
Otto Moerbeek [Tue, 20 Jun 2023 09:17:00 +0000 (11:17 +0200)] 
Port of the openss-poratble arc4random code to our build environment

2 years agoInitial needed files from openssh-portable
Otto Moerbeek [Tue, 20 Jun 2023 08:02:52 +0000 (10:02 +0200)] 
Initial needed files from openssh-portable

2 years agoauth lmdb: in Lightning Stream mode, during deleteDomain, use RW transaction to get... 12990/head
Peter van Dijk [Thu, 6 Jul 2023 13:09:07 +0000 (15:09 +0200)] 
auth lmdb: in Lightning Stream mode, during deleteDomain, use RW transaction to get ID list

2 years agoauth lmdb: add index refresh-all backend command 12985/head
Peter van Dijk [Thu, 6 Jul 2023 10:28:22 +0000 (12:28 +0200)] 
auth lmdb: add index refresh-all backend command

2 years agoauth lmdb: add 'index check domains' and 'index refresh domains <ID>' backend-cmds
Peter van Dijk [Tue, 4 Jul 2023 18:25:09 +0000 (20:25 +0200)] 
auth lmdb: add 'index check domains' and 'index refresh domains <ID>' backend-cmds

2 years agoMerge pull request #12776 from jacobbunk/tsig-qtype
Remi Gacogne [Tue, 4 Jul 2023 14:40:29 +0000 (16:40 +0200)] 
Merge pull request #12776 from jacobbunk/tsig-qtype

Make DNSQType.TSIG available in dnsdist

2 years agoauth: Simplify the SQL upgrade condition 12776/head
Remi Gacogne [Mon, 3 Jul 2023 18:08:36 +0000 (20:08 +0200)] 
auth: Simplify the SQL upgrade condition

2 years agodnsdist: Make clang-tidy happy 12976/head
Remi Gacogne [Mon, 3 Jul 2023 18:03:54 +0000 (20:03 +0200)] 
dnsdist: Make clang-tidy happy

We will have to come back if ComboAddress ever becomes heavier, but
hey.

2 years agoMerge pull request #12979 from rgacogne/build-package-workflow-permissions
Remi Gacogne [Mon, 3 Jul 2023 17:59:57 +0000 (19:59 +0200)] 
Merge pull request #12979 from rgacogne/build-package-workflow-permissions

builder-dispatch: Explicitly grant permissions to the build package workflow

2 years agobuilder-dispatch: Explicitly grant id-token: write to the build package workflow 12979/head
Remi Gacogne [Mon, 3 Jul 2023 13:28:21 +0000 (15:28 +0200)] 
builder-dispatch: Explicitly grant id-token: write to the build package workflow

2 years agodnsdist: Fix a crash when X-Forwarded-For overrides the initial source IP
Remi Gacogne [Mon, 3 Jul 2023 12:06:05 +0000 (14:06 +0200)] 
dnsdist: Fix a crash when X-Forwarded-For overrides the initial source IP

When both the processing of X-Forwarded-For DNS-over-https headers
(`trustForwardedForHeader=true`) and a maximum number of concurrent
TCP connections per client (`setMaxTCPConnectionsPerClient()`) are
enabled, dnsdist could crash because of an uncaught exception:
```
dnsdist[X]: terminate called after throwing an instance of 'std::runtime_error'
dnsdist[X]:   what():  DOH thread failed to launch: map::at
```
This was caused by the TCP connection being first accounted for with the
initial source IP (from the upstream HTTP proxy) but later released using
the IP extracted from the X-Forwarded-For header, leading to an unexpected
failure to locate the corresponding entry in the map.

We might not actually want to enforce the maximum number of concurrent
TCP connections per client when X-Forwarded-For processing is enabled,
though, because we usually want to rate limit the actual client and
not the HTTP proxy, but X-Forwarded-For being set per HTTP query, instead
of per-connection, makes that pretty much impossible at our level since
the same connection from the HTTP proxy can be reused for several clients.
The proxy protocol would be a better option to enforce that limit.

2 years agoMerge pull request #12955 from rgacogne/ddist-fix-doc-codeblocks
Remi Gacogne [Mon, 3 Jul 2023 11:38:25 +0000 (13:38 +0200)] 
Merge pull request #12955 from rgacogne/ddist-fix-doc-codeblocks

dnsdist: Fix the rendering of some Lua configuration examples

2 years agoMerge pull request #12970 from rgacogne/fix-build-provenance
Remi Gacogne [Mon, 3 Jul 2023 11:29:53 +0000 (13:29 +0200)] 
Merge pull request #12970 from rgacogne/fix-build-provenance

build-packages: Fix the package buikding workflow