]>
git.ipfire.org Git - thirdparty/pdns.git/log
Fred Morcos [Tue, 22 Aug 2023 14:50:00 +0000 (16:50 +0200)]
Use the C++ header file generated by bison instead of opting for a C header file
Fred Morcos [Tue, 22 Aug 2023 14:49:49 +0000 (16:49 +0200)]
Bindlexer whitespace cleanup
Remi Gacogne [Mon, 21 Aug 2023 09:26:16 +0000 (11:26 +0200)]
Merge pull request #13155 from rgacogne/channel-make-blocking-params-explicit
channel: Make the blocking parameters of the object queue explicit
Otto Moerbeek [Mon, 21 Aug 2023 08:25:17 +0000 (10:25 +0200)]
Merge pull request #13102 from omoerbeek/rec-nodata-condition
rec: Do not assume the records are in a particular order when determining if an answer is NODATA
Otto Moerbeek [Mon, 21 Aug 2023 08:24:55 +0000 (10:24 +0200)]
Merge pull request #13106 from omoerbeek/rec-aggr-cache-replace
rec: replace data in the aggressive cache if new data becomes available
Fred Morcos [Fri, 18 Aug 2023 19:57:53 +0000 (21:57 +0200)]
Merge pull request #13144 from fredmorcos/iputils-cleanup
Consistency: Use #ifdef instead of #if in `iputils.cc`
Fred Morcos [Fri, 18 Aug 2023 19:44:16 +0000 (21:44 +0200)]
Merge pull request #13152 from fredmorcos/cleanup-yaml-to-json
Cleanup `convert-yaml-to-json.py`
Fred Morcos [Wed, 16 Aug 2023 12:14:21 +0000 (14:14 +0200)]
Consistency: Use #ifdef instead of #if in iputils.cc
Remi Gacogne [Wed, 16 Aug 2023 14:42:26 +0000 (16:42 +0200)]
channel: Make the blocking parameters of the object queue explicit
Remi Gacogne [Fri, 18 Aug 2023 11:03:04 +0000 (13:03 +0200)]
Merge pull request #13151 from aj-gh/fixtypos
Fix a few typos in log messages
Remi Gacogne [Fri, 18 Aug 2023 11:02:36 +0000 (13:02 +0200)]
Merge pull request #13147 from chbruyand/dnsdist-channel-fix
dnsdist: DOH - make query channel receiving part blocking
Fred Morcos [Thu, 17 Aug 2023 14:59:37 +0000 (16:59 +0200)]
Cleanup convert-yaml-to-json.py
Andreas Jakum [Thu, 17 Aug 2023 13:24:05 +0000 (15:24 +0200)]
Fix a few typos.
Remi Gacogne [Thu, 17 Aug 2023 10:06:50 +0000 (12:06 +0200)]
Merge pull request #13149 from rgacogne/ddist-fix-frontend-metrics-recvmmsg
dnsdist: Properly record self-answered UDP responses with recvmmsg
Remi Gacogne [Thu, 17 Aug 2023 09:37:30 +0000 (11:37 +0200)]
Merge pull request #13146 from chbruyand/dnsdist-cosmetic-fixes
dnsdist: cosmetic compilation warning fixes
Remi Gacogne [Thu, 17 Aug 2023 09:19:15 +0000 (11:19 +0200)]
dnsdist: Properly record self-answered UDP responses with recvmmsg
Responses sent directly from dnsdist, without reaching out to a backend
(self-generated and cache hits answers, mostly) where not properly
accounted for in frontend metrics, ring buffer entries and latency
computation when recvmmsg/sendmmsg support was enabled via
`setUDPMultipleMessagesVectorSize()`.
Charles-Henri Bruyand [Wed, 16 Aug 2023 15:20:21 +0000 (17:20 +0200)]
dnsdsit: reset IncomingTCPConnectionState's buffer with clear() instead of resize()
Charles-Henri Bruyand [Wed, 16 Aug 2023 14:32:22 +0000 (16:32 +0200)]
dnsdist: remove unused variables warnings
Charles-Henri Bruyand [Wed, 16 Aug 2023 15:28:23 +0000 (17:28 +0200)]
dnsdist: make query channel receiving part blocking to avoid unnecessary CPU consumption
Remi Gacogne [Wed, 16 Aug 2023 13:59:21 +0000 (15:59 +0200)]
Merge pull request #13141 from rgacogne/auth-coverity-4
tools: Address more Coverity warnings
Peter van Dijk [Wed, 16 Aug 2023 11:31:20 +0000 (13:31 +0200)]
Merge pull request #13005 from jellekaufmann/master
optsize off by -4 when including DNS cookie
Remi Gacogne [Wed, 16 Aug 2023 09:46:03 +0000 (11:46 +0200)]
dnsbulktest: Fix warnings from clang-tidy
Remi Gacogne [Wed, 16 Aug 2023 09:45:49 +0000 (11:45 +0200)]
calidns: Fix warnings from clang-tidy
Remi Gacogne [Wed, 16 Aug 2023 09:13:09 +0000 (11:13 +0200)]
dnsgram: Fix Coverity CID
1401647
Remi Gacogne [Wed, 16 Aug 2023 08:15:42 +0000 (10:15 +0200)]
ixfrdist: Fix Coverity CID
1504137 : Uncaught exception
Remi Gacogne [Wed, 16 Aug 2023 08:15:07 +0000 (10:15 +0200)]
dnsbulktest: Fix Coverity CID
1401681 and
1401676
Remi Gacogne [Wed, 16 Aug 2023 08:14:25 +0000 (10:14 +0200)]
calidns: Fix Coverity CID
1401679 : Uncaught exception
Remi Gacogne [Wed, 16 Aug 2023 07:28:01 +0000 (09:28 +0200)]
Merge pull request #13135 from rgacogne/ddist-gettc
dnsdist: Add a DNSHeader:getTC() Lua binding
Peter van Dijk [Tue, 15 Aug 2023 19:02:14 +0000 (21:02 +0200)]
Merge pull request #13138 from Habbie/cid398388
coverity CID 398388: useless <0 check on unsigned value
Remi Gacogne [Tue, 15 Aug 2023 16:07:52 +0000 (18:07 +0200)]
dnsdist: Remove a second useless check, useless static casts
Peter van Dijk [Tue, 15 Aug 2023 16:27:24 +0000 (18:27 +0200)]
Merge pull request #13139 from fredmorcos/minor-cleanups
Minor cleanup
Fred Morcos [Tue, 15 Aug 2023 11:22:34 +0000 (13:22 +0200)]
gettime: fix minor compilation warnings
Fred Morcos [Tue, 15 Aug 2023 11:22:51 +0000 (13:22 +0200)]
Makefile whitespace
Peter van Dijk [Tue, 15 Aug 2023 11:41:04 +0000 (13:41 +0200)]
Merge pull request #13136 from Habbie/ixfrdist-soa-aa
ixfrdist: set AA=1 on SOA responses
Peter van Dijk [Tue, 15 Aug 2023 11:40:49 +0000 (13:40 +0200)]
Merge pull request #13134 from Habbie/ixfrdist-pytest
ixfrdist: switch testing to pytest
Peter van Dijk [Tue, 15 Aug 2023 08:28:46 +0000 (10:28 +0200)]
coverity CID 398388: useless <0 check on unsigned value
Remi Gacogne [Mon, 14 Aug 2023 15:50:52 +0000 (17:50 +0200)]
dnsdist: Fix the documented return value of DNSHeader:getTC()
Peter van Dijk [Mon, 14 Aug 2023 14:52:27 +0000 (16:52 +0200)]
ixfrdist: set AA=1 on SOA responses
Peter van Dijk [Mon, 14 Aug 2023 15:10:10 +0000 (17:10 +0200)]
eqdnsmessage: adjust to type changes in dnspython
Remi Gacogne [Mon, 14 Aug 2023 15:08:05 +0000 (17:08 +0200)]
Merge pull request #13094 from rgacogne/ixfrdist-main-complexity
ixfrdist: Reduce the complexity of the main function
Remi Gacogne [Mon, 14 Aug 2023 15:02:39 +0000 (17:02 +0200)]
dnsdist: Add a DNSHeader:getTC() Lua binding
Peter van Dijk [Mon, 14 Aug 2023 14:55:02 +0000 (16:55 +0200)]
ixfrdist: switch testing to pytest
Peter van Dijk [Mon, 14 Aug 2023 13:32:30 +0000 (15:32 +0200)]
ixfrdist: after --help or --version, exit (includes var rename)
Remi Gacogne [Mon, 14 Aug 2023 12:39:15 +0000 (14:39 +0200)]
Merge pull request #13114 from rgacogne/auth-coverity-3
auth: Fix uninitialized scalar field warnings from Coverity
Peter van Dijk [Mon, 14 Aug 2023 12:23:02 +0000 (14:23 +0200)]
Merge pull request #13093 from rgacogne/ixfrdist-fix-max-soa-refresh
ixfrdist: Fix the validation of 'max-soa-refresh'
Remi Gacogne [Mon, 14 Aug 2023 11:23:40 +0000 (13:23 +0200)]
Merge pull request #13113 from rgacogne/ddist-discovery-short-read
dnsdist: Properly handle short reads on backend upgrade discovery
Remi Gacogne [Mon, 14 Aug 2023 10:15:53 +0000 (12:15 +0200)]
ixfrdist: Call `getpwuid()` before going multi-threaded
Remi Gacogne [Mon, 14 Aug 2023 10:09:40 +0000 (12:09 +0200)]
auth: Fix Coverity CID
1504120 : Uninitialized scalar field
Remi Gacogne [Mon, 14 Aug 2023 10:09:00 +0000 (12:09 +0200)]
auth: Fix coverity CID
1030024 : Uninitialized scalar field
Remi Gacogne [Mon, 14 Aug 2023 09:01:41 +0000 (11:01 +0200)]
dnsdist: Uglify the code to make the formatter happy
Peter van Dijk [Mon, 14 Aug 2023 08:58:27 +0000 (10:58 +0200)]
Merge pull request #13105 from Habbie/rec-ixfr-debugging
(I)XFR: handle partial read of len prefix
Remi Gacogne [Mon, 14 Aug 2023 08:57:38 +0000 (10:57 +0200)]
dnsdist: Add a 'partial read' case to the backend upgrade tests
Remi Gacogne [Mon, 14 Aug 2023 08:56:53 +0000 (10:56 +0200)]
sstuff: Document that Socket::readWithTimeout() does not handle partial reads
Remi Gacogne [Mon, 14 Aug 2023 08:56:21 +0000 (10:56 +0200)]
dnsdist: Properly handle short reads on backend upgrade discovery
Peter van Dijk [Mon, 14 Aug 2023 08:23:30 +0000 (10:23 +0200)]
Merge pull request #13111 from franklouwers/master
Document default for `webserver-loglevel`
Frank Louwers [Thu, 10 Aug 2023 12:44:51 +0000 (14:44 +0200)]
Document default for `webserver-loglevel`
Peter van Dijk [Thu, 10 Aug 2023 12:14:39 +0000 (14:14 +0200)]
Merge pull request #12565 from jsoref/harmonize-xfr-out-messages
auth: harmonize *xfr log messages
Peter van Dijk [Wed, 9 Aug 2023 14:59:40 +0000 (16:59 +0200)]
Merge pull request #12949 from rgacogne/auth-channel
auth: Refactor the MultiThreadDistributor using pdns::channel
Otto Moerbeek [Wed, 9 Aug 2023 11:45:12 +0000 (13:45 +0200)]
Make clang-tidy happy
Otto Moerbeek [Wed, 9 Aug 2023 08:09:36 +0000 (10:09 +0200)]
remove redundant assignment
Peter van Dijk [Wed, 9 Aug 2023 07:26:35 +0000 (09:26 +0200)]
Merge pull request #13108 from fredmorcos/auth-fix-bind-backend-warnings
Auth: Fix warnings in bind backend
Otto Moerbeek [Wed, 9 Aug 2023 06:26:05 +0000 (08:26 +0200)]
Merge pull request #13098 from omoerbeek/rec-docs-upgrade-stack
rec: Expand the note on max-recursion-depth in the upgrade notes
Fred Morcos [Tue, 8 Aug 2023 21:11:47 +0000 (23:11 +0200)]
Auth: Fix warnings in bind backend
Otto Moerbeek [Tue, 8 Aug 2023 19:02:32 +0000 (21:02 +0200)]
Merge pull request #13107 from paddg/max-packetcache-entries-doc-patch-1
Update max-packetcache-entries setting doc
Peter van Dijk [Mon, 7 Aug 2023 17:13:36 +0000 (19:13 +0200)]
IXFR client: handle partial reads of the TCP chunk length header, plus:
* add primarySOACount to exception text
* add indicator of current state to exception text
* a test
Winfried Angele [Tue, 8 Aug 2023 14:32:27 +0000 (16:32 +0200)]
Update max-packetcache-entries setting doc
Since 4.9.0, the packet cache is sharded and shared by all threads.
Otto Moerbeek [Tue, 8 Aug 2023 10:15:00 +0000 (12:15 +0200)]
rec: replace data in the aggressive cache if it becomes available
Currently, new data does not get recorded into the aggressive cache
if there's an existing entry that matches. Together with the fact
that in some cases pruning can be unfair (it scans the zones
always in the same order and stops clearing when it has reached the
goal) and/or not very active (when the recursor is lighlty loaded)
this has the consequence that old expired records can remain in
the cache that prevent new data to be recorded and used.
Peter van Dijk [Mon, 7 Aug 2023 17:13:11 +0000 (19:13 +0200)]
typo fix
Otto Moerbeek [Fri, 4 Aug 2023 11:07:59 +0000 (13:07 +0200)]
rec: Do not assume the records are in a particular order when determining if an answer is
NODATA.
Peter van Dijk [Thu, 3 Aug 2023 09:42:33 +0000 (11:42 +0200)]
Merge pull request #13096 from Habbie/lmdb-do-reset-index-timestamp
auth lmdb: when broadcasting indexes, -do- rewrite them even if they are unchanged
Peter van Dijk [Thu, 3 Aug 2023 09:22:37 +0000 (11:22 +0200)]
Merge pull request #13089 from Habbie/auth-docs-metadata-dnssec
auth docs: remove domainmetadata/DNSSEC warning, has not been true for years
Otto Moerbeek [Thu, 3 Aug 2023 09:12:11 +0000 (11:12 +0200)]
Expand the note on max-recursion-depth
Peter van Dijk [Wed, 2 Aug 2023 12:35:32 +0000 (14:35 +0200)]
auth lmdb: when broadcasting indexes, -do- rewrite them even if they are unchanged
Peter van Dijk [Wed, 2 Aug 2023 10:02:58 +0000 (12:02 +0200)]
Merge pull request #13087 from Habbie/rm-init.d
remove unused sysv init files
Peter van Dijk [Mon, 31 Jul 2023 10:53:34 +0000 (12:53 +0200)]
remove unused sysv init files - we don't ship them, and non-systemd downstream packages all have their own
Remi Gacogne [Tue, 1 Aug 2023 15:50:57 +0000 (17:50 +0200)]
ixfrdist: Delint ixfrdist.cc a bit more
Remi Gacogne [Tue, 1 Aug 2023 14:25:08 +0000 (16:25 +0200)]
Merge pull request #13092 from rgacogne/rec-coverity
rec: Fixes a few performance issues reported by Coverity
Remi Gacogne [Tue, 1 Aug 2023 14:22:35 +0000 (16:22 +0200)]
Merge pull request #13091 from rgacogne/auth-coverity-2
auth: Fixes a few issues reported by Coverity
Remi Gacogne [Tue, 1 Aug 2023 14:20:50 +0000 (16:20 +0200)]
ixfrdist: Reduce the complexity of the main function
Remi Gacogne [Tue, 1 Aug 2023 14:17:49 +0000 (16:17 +0200)]
ixfrdist: Fix the validation of 'max-soa-refresh'
Remi Gacogne [Tue, 1 Aug 2023 13:09:59 +0000 (15:09 +0200)]
rec: Prevent a copy when distributing UDP queries to workers
Reported by Coverity as CID
1509301 .
Remi Gacogne [Tue, 1 Aug 2023 13:09:25 +0000 (15:09 +0200)]
rec: Prevent a copy in RecursorLua4::DNSQuestion::addAnswer
Reported by Coverity as
1509322
Remi Gacogne [Tue, 1 Aug 2023 11:56:03 +0000 (13:56 +0200)]
pdnsutil: Set a proper umask before writing the temporary zone file
This does not matter on Linux where mkstemp ensures that "the file
is created with permissions 0600 that is, read plus write for owner
only" but it might on other systems as POSIX does not require mkstemp
to do so.
Reported by Coverity as CID
1501165 .
Remi Gacogne [Tue, 1 Aug 2023 11:54:30 +0000 (13:54 +0200)]
ixfrdist: Ensure exceptions are properly caught
Reported by Coverity as CIDs
1504095 ,
1504097 ,
1504109 ,
1504112 ,
1504113 ,
1504114 ,
1504137 and
1504138 .
Remi Gacogne [Tue, 1 Aug 2023 11:53:54 +0000 (13:53 +0200)]
pkcs11signers: Fix a possibly unitialized variable
Reported by Coverity as CID
1504120 .
Remi Gacogne [Tue, 1 Aug 2023 11:52:53 +0000 (13:52 +0200)]
auth: Make Coverity happy about 'ifurlextup' (CID
1509357 )
Remi Gacogne [Tue, 1 Aug 2023 11:51:52 +0000 (13:51 +0200)]
speedtest: Make coverity happy (CID
1513038 )
Remi Gacogne [Tue, 1 Aug 2023 11:51:20 +0000 (13:51 +0200)]
fuzzing: Add a missing cstdint header to the fuzzing targets
Remi Gacogne [Tue, 1 Aug 2023 11:49:50 +0000 (13:49 +0200)]
lmdbbackend: Prevent a useless copy in LMDBBackend::getAllDomainsFiltered()
Reported by Coverity as
1510936 : AUTO_CAUSES_COPY.
Remi Gacogne [Tue, 1 Aug 2023 11:23:01 +0000 (13:23 +0200)]
Merge pull request #13013 from rgacogne/ddist-get-rule-action-matched
dnsdist: Add Lua bindings to access selector and action
Remi Gacogne [Tue, 1 Aug 2023 09:42:29 +0000 (11:42 +0200)]
Merge pull request #13018 from rgacogne/calidns-fix-ecs-0
calidns: Fix setting an ECS source of 0
Remi Gacogne [Tue, 1 Aug 2023 09:03:29 +0000 (11:03 +0200)]
Merge pull request #13088 from rgacogne/ddist-remove-useless-user-group-unit-sed
dnsdist: Stop passing -u dnsdist -g dnsdist on systemd's ExecStart
Remi Gacogne [Tue, 1 Aug 2023 09:02:51 +0000 (11:02 +0200)]
Merge pull request #13084 from rgacogne/ddist-fix-dnsdistconf-grp-rpm
dnsdist: Fix the group of the dnsdist.conf file when installed via RPM
Peter van Dijk [Tue, 1 Aug 2023 09:00:55 +0000 (11:00 +0200)]
auth docs: remove domainmetadata/DNSSEC warning, has not been true for years
Remi Gacogne [Tue, 1 Aug 2023 08:57:16 +0000 (10:57 +0200)]
dnsdist: Fix a c/p mistake in the description of getSelfAnsweredResponseRule
Remi Gacogne [Tue, 1 Aug 2023 08:55:16 +0000 (10:55 +0200)]
dnsdist: Add a comment indicating we are fine with at() throwing
Remi Gacogne [Tue, 1 Aug 2023 08:52:24 +0000 (10:52 +0200)]
dnsdist: Fix indentation
Remi Gacogne [Mon, 31 Jul 2023 15:43:07 +0000 (17:43 +0200)]
calidns: Fix the use of `ntohl` instead of `htonl` in ECS handling
Remi Gacogne [Wed, 12 Jul 2023 11:07:29 +0000 (13:07 +0200)]
calidns: Use the full 32-bit range for 0.0.0.0/0, via Otto
Remi Gacogne [Wed, 12 Jul 2023 08:49:31 +0000 (10:49 +0200)]
calidns: Fix setting an ECS source of 0