]> git.ipfire.org Git - thirdparty/pdns.git/log
thirdparty/pdns.git
8 months agoauthtests: remove stray whitespace 14604/head
Chris Hofstaedtler [Fri, 27 Sep 2024 06:21:10 +0000 (08:21 +0200)] 
authtests: remove stray whitespace

8 months agoauth: optimize !d_doResolveAcrossZones case
Chris Hofstaedtler [Fri, 27 Sep 2024 06:21:32 +0000 (08:21 +0200)] 
auth: optimize !d_doResolveAcrossZones case

8 months agoauth: allow turning off across-zone resolving
Chris Hofstaedtler [Wed, 28 Aug 2024 09:52:31 +0000 (11:52 +0200)] 
auth: allow turning off across-zone resolving

Default is unchanged. Turning off the new setting causes CNAME targets
to not be followed across (local) zones. Also, queries that could be
answered by following a local delegations are similarly not resolved.

10 months agoMerge pull request #14701 from zeha/zeha-13039-refac
Peter van Dijk [Thu, 26 Sep 2024 09:30:57 +0000 (11:30 +0200)] 
Merge pull request #14701 from zeha/zeha-13039-refac

auth: move checkForCorrectTSIG into packethandler

10 months agoMerge pull request #14713 from rgacogne/fix-coverity-secrets
Remi Gacogne [Wed, 25 Sep 2024 14:19:18 +0000 (16:19 +0200)] 
Merge pull request #14713 from rgacogne/fix-coverity-secrets

coverity: Use the correct secret token

10 months agoMerge pull request #14620 from fredmorcos/lmdb-cleanups
Fred Morcos [Wed, 25 Sep 2024 13:24:39 +0000 (15:24 +0200)] 
Merge pull request #14620 from fredmorcos/lmdb-cleanups

Cleanups to lmdb source files

10 months agocoverity: Use the correct secret token 14713/head
Remi Gacogne [Wed, 25 Sep 2024 13:20:15 +0000 (15:20 +0200)] 
coverity: Use the correct secret token

We have one Coverity token per product, and not a global token.

10 months agoReplace memcpy with std::append 14620/head
Fred Morcos [Wed, 25 Sep 2024 12:18:10 +0000 (14:18 +0200)] 
Replace memcpy with std::append

10 months agoMerge pull request #14670 from Habbie/webserver-ise-reason
Peter van Dijk [Wed, 25 Sep 2024 09:35:42 +0000 (11:35 +0200)] 
Merge pull request #14670 from Habbie/webserver-ise-reason

webserver.cc: try to pass exception text with 500 errors

10 months agoFix new impl of serializeToBuffer
Fred Morcos [Tue, 24 Sep 2024 12:04:16 +0000 (14:04 +0200)] 
Fix new impl of serializeToBuffer

10 months agoMerge pull request #14705 from fredmorcos/cleanup-clang-config-files
Fred Morcos [Tue, 24 Sep 2024 09:21:29 +0000 (11:21 +0200)] 
Merge pull request #14705 from fredmorcos/cleanup-clang-config-files

Cleanup clang config files

10 months agoFixup deserializeFromBuffer
Fred Morcos [Tue, 24 Sep 2024 07:59:21 +0000 (09:59 +0200)] 
Fixup deserializeFromBuffer

10 months agoRewrite serializeToBuffer
Fred Morcos [Tue, 24 Sep 2024 07:56:07 +0000 (09:56 +0200)] 
Rewrite serializeToBuffer

10 months agoCleanup lmdb-typed.cc
Fred Morcos [Tue, 24 Sep 2024 07:28:17 +0000 (09:28 +0200)] 
Cleanup lmdb-typed.cc

10 months agoRevert the boost archive formatting
Fred Morcos [Tue, 24 Sep 2024 07:21:08 +0000 (09:21 +0200)] 
Revert the boost archive formatting

10 months agoRename serTo/FromString to (de)serializeTo/FromBuffer
Fred Morcos [Tue, 30 Jul 2024 12:09:15 +0000 (14:09 +0200)] 
Rename serTo/FromString to (de)serializeTo/FromBuffer

10 months agoSome cleanups to lmdb-typed.hh
Fred Morcos [Tue, 30 Jul 2024 12:08:35 +0000 (14:08 +0200)] 
Some cleanups to lmdb-typed.hh

Mostly automated formatting and renames with some documentation formatting and rewording.

10 months agoFormat lmdb-typed.cc
Fred Morcos [Tue, 23 Jul 2024 12:39:57 +0000 (14:39 +0200)] 
Format lmdb-typed.cc

10 months agoSome formatting in lmdbbackend.cc
Fred Morcos [Tue, 23 Jul 2024 12:39:44 +0000 (14:39 +0200)] 
Some formatting in lmdbbackend.cc

10 months agoMerge pull request #14625 from fredmorcos/fix-lmdb-mdb-env-leak
Fred Morcos [Tue, 24 Sep 2024 09:17:41 +0000 (11:17 +0200)] 
Merge pull request #14625 from fredmorcos/fix-lmdb-mdb-env-leak

Fix leak of MDB_env object

10 months agoMerge pull request #14704 from fredmorcos/fix-clang-tidy
Fred Morcos [Tue, 24 Sep 2024 08:35:35 +0000 (10:35 +0200)] 
Merge pull request #14704 from fredmorcos/fix-clang-tidy

Fix clang-tidy

10 months agoCleanup clang-format file 14705/head
Fred Morcos [Tue, 24 Sep 2024 08:31:15 +0000 (10:31 +0200)] 
Cleanup clang-format file

10 months agoCleanup clang-tidy files
Fred Morcos [Tue, 24 Sep 2024 08:30:53 +0000 (10:30 +0200)] 
Cleanup clang-tidy files

10 months agoMerge pull request #14703 from fredmorcos/refactor-meson-fuzz
Fred Morcos [Tue, 24 Sep 2024 08:13:05 +0000 (10:13 +0200)] 
Merge pull request #14703 from fredmorcos/refactor-meson-fuzz

Refactor meson building of fuzz tools

10 months agoFix clang-tidy 14704/head
Fred Morcos [Tue, 24 Sep 2024 07:25:59 +0000 (09:25 +0200)] 
Fix clang-tidy

10 months agoRefactor meson handling of fuzz tools 14703/head
Fred Morcos [Tue, 24 Sep 2024 07:12:03 +0000 (09:12 +0200)] 
Refactor meson handling of fuzz tools

10 months agoNolint exit(1) 14625/head
Fred Morcos [Tue, 24 Sep 2024 07:11:45 +0000 (09:11 +0200)] 
Nolint exit(1)

10 months agoMerge pull request #14651 from omoerbeek/rec-boost-no-more-ucontext
Otto Moerbeek [Mon, 23 Sep 2024 15:04:26 +0000 (17:04 +0200)] 
Merge pull request #14651 from omoerbeek/rec-boost-no-more-ucontext

rec: stop supporting ucontext flavor for context switching

10 months agoMerge pull request #14702 from omoerbeek/no-pdns-dir-in-zip
Otto Moerbeek [Mon, 23 Sep 2024 14:37:59 +0000 (16:37 +0200)] 
Merge pull request #14702 from omoerbeek/no-pdns-dir-in-zip

Do not include a stray pdns dir in the recursor artifacts

10 months agoMerge pull request #14692 from omoerbeek/rec-named-forw-multiple
Otto Moerbeek [Mon, 23 Sep 2024 14:13:25 +0000 (16:13 +0200)] 
Merge pull request #14692 from omoerbeek/rec-named-forw-multiple

rec: use multiple targets for the named forward test

10 months agoMerge pull request #14507 from rgacogne/ddist-document-zero-scope
Remi Gacogne [Mon, 23 Sep 2024 14:08:44 +0000 (16:08 +0200)] 
Merge pull request #14507 from rgacogne/ddist-document-zero-scope

dnsdist: Better documentation of the zero-scope feature

10 months agoAdd comment 14702/head
Otto Moerbeek [Mon, 23 Sep 2024 12:05:41 +0000 (14:05 +0200)] 
Add comment

10 months agoMerge pull request #14698 from Habbie/dnf-sbom-version-arch-optional
Peter van Dijk [Mon, 23 Sep 2024 12:24:55 +0000 (14:24 +0200)] 
Merge pull request #14698 from Habbie/dnf-sbom-version-arch-optional

dnf sbom: handle arch absence

10 months agoDo not include a stray pdns dir in the recursor artifacts
Otto Moerbeek [Mon, 23 Sep 2024 09:21:13 +0000 (11:21 +0200)] 
Do not include a stray pdns dir in the recursor artifacts

This is caused by pdns-recursor matching pdns*, which is intended to select
auth files only.
Not terribly happy with the code duplication, but we would end up in quoting hell otherwise.

10 months agoauth: mark doQuestion as a known readability-function-cognitive-complexity problem 14701/head
Chris Hofstaedtler [Mon, 23 Sep 2024 10:51:34 +0000 (12:51 +0200)] 
auth: mark doQuestion as a known readability-function-cognitive-complexity problem

10 months agodnf sbom: handle arch absence 14698/head
Peter van Dijk [Fri, 20 Sep 2024 16:41:58 +0000 (18:41 +0200)] 
dnf sbom: handle arch absence

10 months agoauth: move checkForCorrectTSIG into packethandler
Chris Hofstaedtler [Tue, 27 Aug 2024 19:28:36 +0000 (21:28 +0200)] 
auth: move checkForCorrectTSIG into packethandler

To avoid DNSPacket pulling UeberBackend.

10 months agoMerge pull request #14580 from rgacogne/fix-coverity
Remi Gacogne [Fri, 20 Sep 2024 14:25:46 +0000 (16:25 +0200)] 
Merge pull request #14580 from rgacogne/fix-coverity

Move coverity to a reusable workflow, add a dispatcher workflow

10 months agoMerge pull request #14691 from Habbie/dnf-sbom-version
Peter van Dijk [Fri, 20 Sep 2024 13:18:48 +0000 (15:18 +0200)] 
Merge pull request #14691 from Habbie/dnf-sbom-version

dnf sbom: use same logic for our version number too

10 months agoadd arch too 14691/head
Peter van Dijk [Fri, 20 Sep 2024 12:15:17 +0000 (14:15 +0200)] 
add arch too

10 months agoMerge pull request #14687 from rgacogne/ddist-changelog-secpoll-1.8.4
Remi Gacogne [Fri, 20 Sep 2024 11:02:41 +0000 (13:02 +0200)] 
Merge pull request #14687 from rgacogne/ddist-changelog-secpoll-1.8.4

dnsdist: Update ChangeLog and secpoll for 1.8.4

10 months agoMove coverity to a reusable workflow, add a dispatcher workflow 14580/head
Remi Gacogne [Thu, 22 Aug 2024 11:58:34 +0000 (13:58 +0200)] 
Move coverity to a reusable workflow, add a dispatcher workflow

10 months agorec: use multiple targets for the named forward test 14692/head
Otto Moerbeek [Thu, 19 Sep 2024 12:33:39 +0000 (14:33 +0200)] 
rec: use multiple targets for the named forward test

This tries to work around the occasional GH networking issues

10 months agodnf sbom: use same logic for our version number too
Peter van Dijk [Thu, 19 Sep 2024 12:50:07 +0000 (14:50 +0200)] 
dnf sbom: use same logic for our version number too

10 months agodnsdist: Fix formatting in the ChangeLog, as suggested by Habbie 14687/head
Remi Gacogne [Thu, 19 Sep 2024 10:24:02 +0000 (12:24 +0200)] 
dnsdist: Fix formatting in the ChangeLog, as suggested by Habbie

10 months agodnsdist: Update ChangeLog and secpoll for 1.8.4
Remi Gacogne [Thu, 19 Sep 2024 09:23:54 +0000 (11:23 +0200)] 
dnsdist: Update ChangeLog and secpoll for 1.8.4

10 months agoMerge pull request #14686 from Habbie/newer-mssql
Peter van Dijk [Thu, 19 Sep 2024 10:30:56 +0000 (12:30 +0200)] 
Merge pull request #14686 from Habbie/newer-mssql

auth mssql CI: switch to 2022-CU12 image

10 months agoauth mssql CI: switch to 2022-CU12 image 14686/head
Peter van Dijk [Thu, 19 Sep 2024 08:47:07 +0000 (10:47 +0200)] 
auth mssql CI: switch to 2022-CU12 image

https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240915.1 broke mssql.

https://github.com/microsoft/mssql-docker/issues/868 fits the kernel upgrade.

this commit switches from 2017-GA to 2022-CU12, which unbreaks the build

10 months agoMerge pull request #14681 from phonedph1/patch-4
Remi Gacogne [Wed, 18 Sep 2024 07:16:07 +0000 (09:16 +0200)] 
Merge pull request #14681 from phonedph1/patch-4

dnsdist: very nitty Update dnsdist-lua-actions.cc

10 months agoUpdate dnsdist-lua-actions.cc 14681/head
phonedph1 [Tue, 17 Sep 2024 21:50:24 +0000 (15:50 -0600)] 
Update dnsdist-lua-actions.cc

10 months agoMerge pull request #14678 from omoerbeek/rec-meson-mplexer
Otto Moerbeek [Tue, 17 Sep 2024 14:41:25 +0000 (16:41 +0200)] 
Merge pull request #14678 from omoerbeek/rec-meson-mplexer

rec: meson build: link in right multiplexer

10 months agorec: meson build: link in right multiplexer 14678/head
Otto Moerbeek [Tue, 17 Sep 2024 13:44:47 +0000 (15:44 +0200)] 
rec: meson build: link in right multiplexer

10 months agoMerge pull request #14671 from rgacogne/ddist-store-tlsioctx
Remi Gacogne [Tue, 17 Sep 2024 10:58:21 +0000 (12:58 +0200)] 
Merge pull request #14671 from rgacogne/ddist-store-tlsioctx

dnsdist: Always store the `OpenSSLTLSIOCtx` in the connection

10 months agodnsdist: Fix clang-tidy warnings 14671/head
Remi Gacogne [Mon, 16 Sep 2024 11:31:50 +0000 (13:31 +0200)] 
dnsdist: Fix clang-tidy warnings

10 months agoMerge pull request #14674 from romeroalx/gh-actions-skip-debian-11-meson
Fred Morcos [Mon, 16 Sep 2024 11:29:34 +0000 (13:29 +0200)] 
Merge pull request #14674 from romeroalx/gh-actions-skip-debian-11-meson

GH actions: skip job build-auth with meson for Debian 11

10 months agodnsdist: Set the ALPN of TLS contexts right away
Remi Gacogne [Mon, 16 Sep 2024 10:27:00 +0000 (12:27 +0200)] 
dnsdist: Set the ALPN of TLS contexts right away

10 months agodnsdist: Remove NPN support, it has been deprecated for a very long time
Remi Gacogne [Mon, 16 Sep 2024 08:59:21 +0000 (10:59 +0200)] 
dnsdist: Remove NPN support, it has been deprecated for a very long time

10 months agodnsdist: Fix clang-tidy warnings
Remi Gacogne [Fri, 13 Sep 2024 14:38:16 +0000 (16:38 +0200)] 
dnsdist: Fix clang-tidy warnings

10 months agodnsdist: Always store the OpenSSLTLSIOCtx in the connection
Remi Gacogne [Fri, 13 Sep 2024 13:57:38 +0000 (15:57 +0200)] 
dnsdist: Always store the OpenSSLTLSIOCtx in the connection

10 months agoMerge pull request #14045 from Habbie/auth-api-rrset-comments-spurious-records
Peter van Dijk [Mon, 16 Sep 2024 09:47:59 +0000 (11:47 +0200)] 
Merge pull request #14045 from Habbie/auth-api-rrset-comments-spurious-records

auth API: when querying with rrset_name, respect it for comments too

10 months agogh actions: skip build-auth with meson for debian 11 14674/head
romeroalx [Mon, 16 Sep 2024 04:39:26 +0000 (06:39 +0200)] 
gh actions: skip build-auth with meson for debian 11

10 months agoMerge pull request #14669 from omoerbeek/rec-chain-test-tweaks
Otto Moerbeek [Fri, 13 Sep 2024 15:37:48 +0000 (17:37 +0200)] 
Merge pull request #14669 from omoerbeek/rec-chain-test-tweaks

rec: make chain test more robust and fix max chain size accounting

10 months agowebserver.cc: try to pass exception text with 500 errors 14670/head
Peter van Dijk [Fri, 13 Sep 2024 13:46:06 +0000 (15:46 +0200)] 
webserver.cc: try to pass exception text with 500 errors

fixes #14637 -if- the client sends `Accept: application/json`

10 months agoMerge pull request #14667 from rgacogne/ddist-coverity-20240913
Remi Gacogne [Fri, 13 Sep 2024 13:27:29 +0000 (15:27 +0200)] 
Merge pull request #14667 from rgacogne/ddist-coverity-20240913

dnsdist: Fix a few warnings from Coverity

10 months agorec: make chain test more robust and fix max chain size accounting 14669/head
Otto Moerbeek [Fri, 13 Sep 2024 09:00:14 +0000 (11:00 +0200)] 
rec: make chain test more robust and fix max chain size accounting

10 months agoMerge pull request #14668 from rgacogne/ddist-more-symlinks
Remi Gacogne [Fri, 13 Sep 2024 10:06:46 +0000 (12:06 +0200)] 
Merge pull request #14668 from rgacogne/ddist-more-symlinks

dnsdist: Move yet more dnsdist-specific files to `dnsdistdist`

10 months agoMerge pull request #14666 from omoerbeek/fstrm-too-large-cout
Otto Moerbeek [Fri, 13 Sep 2024 09:00:53 +0000 (11:00 +0200)] 
Merge pull request #14666 from omoerbeek/fstrm-too-large-cout

Introduce a "too large" counter for the framestream remote logger

10 months agodnsdist: Move README-dnsdist.md and eBPF-related files to dnsdistdist/ 14668/head
Remi Gacogne [Fri, 13 Sep 2024 08:03:06 +0000 (10:03 +0200)] 
dnsdist: Move README-dnsdist.md and eBPF-related files to dnsdistdist/

10 months agodnsdist: Remove symbolic links for more dnsdist-specific files
Remi Gacogne [Fri, 13 Sep 2024 08:02:37 +0000 (10:02 +0200)] 
dnsdist: Remove symbolic links for more dnsdist-specific files

10 months agodnsdist: Fix a few warnings from Coverity 14667/head
Remi Gacogne [Fri, 13 Sep 2024 07:59:10 +0000 (09:59 +0200)] 
dnsdist: Fix a few warnings from Coverity

10 months agoIntroduce a "too large" counter for the framestream remote logger 14666/head
Otto Moerbeek [Fri, 13 Sep 2024 07:26:34 +0000 (09:26 +0200)] 
Introduce a "too large" counter for the framestream remote logger

10 months agoMerge pull request #14655 from omoerbeek/rec-dot-test-multiple
Otto Moerbeek [Fri, 13 Sep 2024 05:28:50 +0000 (07:28 +0200)] 
Merge pull request #14655 from omoerbeek/rec-dot-test-multiple

rec: use multiple forwarding targets for DoT forwarding test

10 months agoMerge pull request #14662 from rgacogne/ddist-mv-remaining-files
Remi Gacogne [Thu, 12 Sep 2024 12:20:46 +0000 (14:20 +0200)] 
Merge pull request #14662 from rgacogne/ddist-mv-remaining-files

dnsdist: Move a few remaining dnsdist-specific files to `dnsdistdist/`

10 months agoMerge pull request #14661 from rgacogne/remove-pdns_hw.cc
Remi Gacogne [Thu, 12 Sep 2024 11:58:06 +0000 (13:58 +0200)] 
Merge pull request #14661 from rgacogne/remove-pdns_hw.cc

Remove unused pdns_hw.cc

10 months agoMerge pull request #14663 from rgacogne/enable-sholder-unit-test
Remi Gacogne [Thu, 12 Sep 2024 11:57:36 +0000 (13:57 +0200)] 
Merge pull request #14663 from rgacogne/enable-sholder-unit-test

Enable the (tiny) shared holder unit test

10 months agoFormat and delint test-sholder_hh.cc 14663/head
Remi Gacogne [Tue, 10 Sep 2024 14:23:39 +0000 (16:23 +0200)] 
Format and delint test-sholder_hh.cc

10 months agoActually enable the shared holder unit tests in dnsdist and rec
Remi Gacogne [Tue, 10 Sep 2024 14:23:14 +0000 (16:23 +0200)] 
Actually enable the shared holder unit tests in dnsdist and rec

10 months agodnsdist: Fix a clang-tidy warning in bpf-filter.cc 14662/head
Remi Gacogne [Thu, 12 Sep 2024 10:01:35 +0000 (12:01 +0200)] 
dnsdist: Fix a clang-tidy warning in bpf-filter.cc

10 months agoRemove unused pdns_hw.cc 14661/head
Remi Gacogne [Tue, 10 Sep 2024 14:24:08 +0000 (16:24 +0200)] 
Remove unused pdns_hw.cc

10 months agorec: use multiple forwarding targets for DoT forwarding test 14655/head
Otto Moerbeek [Tue, 10 Sep 2024 14:20:06 +0000 (16:20 +0200)] 
rec: use multiple forwarding targets for DoT forwarding test

10 months agodnsdist: Format moved files
Remi Gacogne [Tue, 10 Sep 2024 14:07:05 +0000 (16:07 +0200)] 
dnsdist: Format moved files

10 months agodnsdist: Move dnsdist-specific files
Remi Gacogne [Tue, 10 Sep 2024 14:05:18 +0000 (16:05 +0200)] 
dnsdist: Move dnsdist-specific files

10 months agodnsdist: Remove symbolic links for dnsdist-specific files
Remi Gacogne [Tue, 10 Sep 2024 14:04:08 +0000 (16:04 +0200)] 
dnsdist: Remove symbolic links for dnsdist-specific files

10 months agoMerge pull request #14642 from Habbie/lua-record-thread-names
Peter van Dijk [Tue, 10 Sep 2024 13:45:06 +0000 (15:45 +0200)] 
Merge pull request #14642 from Habbie/lua-record-thread-names

auth: more and better thread names

10 months agoTidy 14651/head
Otto Moerbeek [Tue, 10 Sep 2024 13:21:55 +0000 (15:21 +0200)] 
Tidy

10 months agorec: stop supporting ucontext flavor for context switching
Otto Moerbeek [Tue, 10 Sep 2024 11:06:30 +0000 (13:06 +0200)] 
rec: stop supporting ucontext flavor for context switching

10 months agoMerge pull request #14633 from omoerbeek/boost-version
Otto Moerbeek [Tue, 10 Sep 2024 10:58:39 +0000 (12:58 +0200)] 
Merge pull request #14633 from omoerbeek/boost-version

Move minmial boost version to 1.54

10 months agoTwo more now redundant cases spotted by rgacogne 14633/head
Otto Moerbeek [Tue, 10 Sep 2024 09:32:02 +0000 (11:32 +0200)] 
Two more now redundant cases spotted by rgacogne

10 months agoMerge pull request #14634 from omoerbeek/rec-unit-tests-random
Otto Moerbeek [Tue, 10 Sep 2024 09:33:08 +0000 (11:33 +0200)] 
Merge pull request #14634 from omoerbeek/rec-unit-tests-random

Randomize unit tests always

10 months agoMerge pull request #14650 from omoerbeek/rec-docs-upgrade-default
Otto Moerbeek [Tue, 10 Sep 2024 08:22:07 +0000 (10:22 +0200)] 
Merge pull request #14650 from omoerbeek/rec-docs-upgrade-default

rec: document potential upgrade issue

10 months agoauth signer: set thread name 14642/head
Peter van Dijk [Tue, 10 Sep 2024 08:13:32 +0000 (10:13 +0200)] 
auth signer: set thread name

10 months agoauth communicator: fix retrieval thread name
Peter van Dijk [Tue, 10 Sep 2024 08:13:25 +0000 (10:13 +0200)] 
auth communicator: fix retrieval thread name

10 months agoauth LUA: reset thread name after async runs
Peter van Dijk [Tue, 10 Sep 2024 08:13:00 +0000 (10:13 +0200)] 
auth LUA: reset thread name after async runs

10 months agodnsdist: Apply Otto's suggestions to the documentation 14507/head
Remi Gacogne [Tue, 10 Sep 2024 07:39:36 +0000 (09:39 +0200)] 
dnsdist: Apply Otto's suggestions to the documentation

Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
10 months agodnsdist: Apply Otto's suggestions to the documentation
Remi Gacogne [Tue, 10 Sep 2024 07:39:27 +0000 (09:39 +0200)] 
dnsdist: Apply Otto's suggestions to the documentation

Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
10 months agorec: document potential upgrade issue 14650/head
Otto Moerbeek [Tue, 10 Sep 2024 07:35:27 +0000 (09:35 +0200)] 
rec: document potential upgrade issue

10 months agoMerge pull request #14636 from rgacogne/ddist-fix-proxy-protocol-outside-tls-dot
Remi Gacogne [Tue, 10 Sep 2024 07:30:33 +0000 (09:30 +0200)] 
Merge pull request #14636 from rgacogne/ddist-fix-proxy-protocol-outside-tls-dot

dnsdist: Fix handling of proxy protocol payload outside of TLS for DoT

10 months agoMerge pull request #14577 from rgacogne/ddist-ffi-edns-version-extended
Remi Gacogne [Tue, 10 Sep 2024 07:29:02 +0000 (09:29 +0200)] 
Merge pull request #14577 from rgacogne/ddist-ffi-edns-version-extended

dnsdist: Add Lua FFI accessors for EDNS version and extended rcode

10 months agoauth LUA: better thread names
Peter van Dijk [Mon, 9 Sep 2024 14:04:00 +0000 (16:04 +0200)] 
auth LUA: better thread names

10 months agodnsdist: Fix handling of proxy protocol payload outside of TLS for DoT 14636/head
Remi Gacogne [Mon, 9 Sep 2024 12:20:48 +0000 (14:20 +0200)] 
dnsdist: Fix handling of proxy protocol payload outside of TLS for DoT

After reading the proxy protocol payload from the I/O buffer
we were clearing the buffer but failed to properly reset the
position, leading to an exception when trying to read the DNS
payload after processing the TLS handshake:

```
Got an exception while handling (reading) TCP query from 127.0.0.1:59426: Calling tryRead() with a too small buffer (2) for a read of 18446744073709551566 bytes starting at 52
```

The huge value comes from the fact that the position (52 here)
is larger than the size of the buffer (2 at this point to read
the size of the incoming DNS payload), leading to an unsigned
underflow. The code is properly detecting that the value makes
no sense in this context, but the connection is then dropped
because we cannot recover.

It turns out we had a end-to-end test for the "proxy protocol
outside of TLS" case but only over incoming DoH, and the DoH
case avoids this specific issue because the buffer is always
properly resized, and the position updated.