]>
git.ipfire.org Git - thirdparty/pdns.git/log
Otto Moerbeek [Tue, 10 Sep 2024 13:21:55 +0000 (15:21 +0200)]
Tidy
Otto Moerbeek [Tue, 10 Sep 2024 11:06:30 +0000 (13:06 +0200)]
rec: stop supporting ucontext flavor for context switching
Otto Moerbeek [Tue, 10 Sep 2024 10:58:39 +0000 (12:58 +0200)]
Merge pull request #14633 from omoerbeek/boost-version
Move minmial boost version to 1.54
Otto Moerbeek [Tue, 10 Sep 2024 09:32:02 +0000 (11:32 +0200)]
Two more now redundant cases spotted by rgacogne
Otto Moerbeek [Tue, 10 Sep 2024 09:33:08 +0000 (11:33 +0200)]
Merge pull request #14634 from omoerbeek/rec-unit-tests-random
Randomize unit tests always
Otto Moerbeek [Tue, 10 Sep 2024 08:22:07 +0000 (10:22 +0200)]
Merge pull request #14650 from omoerbeek/rec-docs-upgrade-default
rec: document potential upgrade issue
Otto Moerbeek [Tue, 10 Sep 2024 07:35:27 +0000 (09:35 +0200)]
rec: document potential upgrade issue
Remi Gacogne [Tue, 10 Sep 2024 07:30:33 +0000 (09:30 +0200)]
Merge pull request #14636 from rgacogne/ddist-fix-proxy-protocol-outside-tls-dot
dnsdist: Fix handling of proxy protocol payload outside of TLS for DoT
Remi Gacogne [Tue, 10 Sep 2024 07:29:02 +0000 (09:29 +0200)]
Merge pull request #14577 from rgacogne/ddist-ffi-edns-version-extended
dnsdist: Add Lua FFI accessors for EDNS version and extended rcode
Remi Gacogne [Mon, 9 Sep 2024 12:20:48 +0000 (14:20 +0200)]
dnsdist: Fix handling of proxy protocol payload outside of TLS for DoT
After reading the proxy protocol payload from the I/O buffer
we were clearing the buffer but failed to properly reset the
position, leading to an exception when trying to read the DNS
payload after processing the TLS handshake:
```
Got an exception while handling (reading) TCP query from 127.0.0.1:59426: Calling tryRead() with a too small buffer (2) for a read of
18446744073709551566 bytes starting at 52
```
The huge value comes from the fact that the position (52 here)
is larger than the size of the buffer (2 at this point to read
the size of the incoming DNS payload), leading to an unsigned
underflow. The code is properly detecting that the value makes
no sense in this context, but the connection is then dropped
because we cannot recover.
It turns out we had a end-to-end test for the "proxy protocol
outside of TLS" case but only over incoming DoH, and the DoH
case avoids this specific issue because the buffer is always
properly resized, and the position updated.
Otto Moerbeek [Mon, 9 Sep 2024 07:27:07 +0000 (09:27 +0200)]
Also do auth and dnsdist testrunner
Otto Moerbeek [Fri, 6 Sep 2024 14:12:47 +0000 (16:12 +0200)]
Move minmial boost version to 1.54
Otto Moerbeek [Mon, 9 Sep 2024 07:03:49 +0000 (09:03 +0200)]
Merge pull request #14628 from omoerbeek/rec-chain-waiterid
rec: avoid duplicated waiter ids for chained requests
Otto Moerbeek [Fri, 6 Sep 2024 12:23:31 +0000 (14:23 +0200)]
Disable tracing for test_Chain, it chokes GH
Peter van Dijk [Fri, 6 Sep 2024 13:07:08 +0000 (15:07 +0200)]
Merge pull request #14561 from jsoref/oversized-chunk-see-11804
Add doc reference to oversized chunk message
Otto Moerbeek [Fri, 6 Sep 2024 12:48:40 +0000 (14:48 +0200)]
Always randomize test runs
Otto Moerbeek [Fri, 6 Sep 2024 12:40:20 +0000 (14:40 +0200)]
Tidy
Otto Moerbeek [Fri, 6 Sep 2024 11:29:17 +0000 (13:29 +0200)]
Add basic chain test that hits the case of #14624
We do rely on that OS queueing the UDP packets, hope it will do so long enough
Otto Moerbeek [Fri, 6 Sep 2024 10:12:14 +0000 (12:12 +0200)]
rec: avoid duplicated waiter ids for chained requests
Peter van Dijk [Thu, 5 Sep 2024 09:47:29 +0000 (11:47 +0200)]
Merge pull request #14619 from Habbie/table-render
auth docs backends: fix table rendering
Peter van Dijk [Tue, 3 Sep 2024 14:40:24 +0000 (16:40 +0200)]
auth docs backends: fix table rendering
Remi Gacogne [Tue, 3 Sep 2024 14:37:50 +0000 (16:37 +0200)]
Merge pull request #14618 from rgacogne/ddist-hashpassword-example
dnsdist: Add an example of how to use `hashPassword()`
Remi Gacogne [Tue, 3 Sep 2024 13:30:29 +0000 (15:30 +0200)]
spell-check: Allow argon/scrypt patterns
Remi Gacogne [Tue, 3 Sep 2024 13:18:40 +0000 (15:18 +0200)]
dnsdist: Add an example of how to use `hashPassword()`
Peter van Dijk [Tue, 3 Sep 2024 12:12:52 +0000 (14:12 +0200)]
Merge pull request #14546 from robertsilen/patch2
add mariadb to table
Otto Moerbeek [Tue, 3 Sep 2024 08:46:37 +0000 (10:46 +0200)]
Merge pull request #14595 from omoerbeek/rec-sanitize-rework
rec: rework sanitize code
Otto Moerbeek [Tue, 3 Sep 2024 08:46:17 +0000 (10:46 +0200)]
Merge pull request #14606 from omoerbeek/rec-tcp-in-limit
rec: rework the way tcp-in limits is maintained
Peter van Dijk [Tue, 3 Sep 2024 08:10:21 +0000 (10:10 +0200)]
Merge pull request #14613 from fredmorcos/cleanup-clang-tidy-config
Remove leftover config from old clang-tidy versions
Peter van Dijk [Tue, 3 Sep 2024 08:08:07 +0000 (10:08 +0200)]
Merge pull request #14612 from Habbie/qsize-threads-docs
auth docs: fix one error and expand a bit on queues and threads
Peter van Dijk [Tue, 3 Sep 2024 08:05:04 +0000 (10:05 +0200)]
Merge pull request #14614 from fredmorcos/lmdb-regtests-gdb
Add a way to run pdnsutil using a debugger as part of the LMDB regression tests
Otto Moerbeek [Tue, 3 Sep 2024 07:37:45 +0000 (09:37 +0200)]
Add upgrade note wrt changed incoming TCP handling
Otto Moerbeek [Tue, 3 Sep 2024 07:57:51 +0000 (09:57 +0200)]
Merge pull request #14602 from omoerbeek/ddist-test-async-obsd
dnsdist: adapt unit test to avoid race on OpenBSD
Otto Moerbeek [Tue, 3 Sep 2024 07:55:35 +0000 (09:55 +0200)]
Add/fix a comment
Peter van Dijk [Tue, 3 Sep 2024 07:36:14 +0000 (09:36 +0200)]
clarify that we restart the entire pdns on a queue overfill in this place too
Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Otto Moerbeek [Wed, 28 Aug 2024 07:28:48 +0000 (09:28 +0200)]
dnsdist: adapt unit test to avoid race on OpenBSD
It looks like OpenBSD has different thread scheduler behaviour, and it
can take a while for the error condition to be set.
Peter van Dijk [Tue, 3 Sep 2024 07:04:30 +0000 (09:04 +0200)]
clarify that we restart the entire pdns on a queue overfill
Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Peter van Dijk [Mon, 2 Sep 2024 11:52:05 +0000 (13:52 +0200)]
auth docs: fix one error and expand a bit on queues and threads
Fred Morcos [Mon, 2 Sep 2024 16:16:47 +0000 (18:16 +0200)]
Add a way to run pdnsutil using gdb in lmdb regression test
Fred Morcos [Fri, 30 Aug 2024 11:25:04 +0000 (13:25 +0200)]
Whitespace cleanup
Fred Morcos [Thu, 29 Aug 2024 10:13:19 +0000 (12:13 +0200)]
Remove leftover config from old clang-tidy versions
Otto Moerbeek [Wed, 28 Aug 2024 09:32:20 +0000 (11:32 +0200)]
Add metrics
Remi Gacogne [Thu, 29 Aug 2024 09:22:26 +0000 (11:22 +0200)]
Merge pull request #14573 from rgacogne/ddist-top-timeouts
dnsdist: Stop reporting timeouts in `topSlow()`, add `topTimeouts()`
Peter van Dijk [Thu, 29 Aug 2024 07:29:09 +0000 (09:29 +0200)]
Merge pull request #14608 from fredmorcos/gitignore-ccls-cache
Gitignore the ccls cache
Peter van Dijk [Thu, 29 Aug 2024 07:28:17 +0000 (09:28 +0200)]
Merge pull request #14607 from omoerbeek/rec-docs-lua-pattern
rec docs: fix *.lua, * has special meaning
Peter van Dijk [Thu, 29 Aug 2024 07:26:59 +0000 (09:26 +0200)]
Merge pull request #14605 from cloudandheat/doc/dont-query-meets-forward-zones
Mention effect of dont_query on forward_zones
Remi Gacogne [Thu, 29 Aug 2024 06:32:23 +0000 (08:32 +0200)]
Merge pull request #14534 from rgacogne/ddist-warn-setmaxtcpclientthreads
dnsdist: Add warnings about large values passed to `setMaxTCPClientThreads`
Remi Gacogne [Thu, 29 Aug 2024 06:31:14 +0000 (08:31 +0200)]
Merge pull request #14570 from rgacogne/ddist-fix-dynblocks-lua-until
dnsdist: Return a valid unix timestamp for Dynamic Block's `until`
Fred Morcos [Wed, 28 Aug 2024 18:27:15 +0000 (20:27 +0200)]
Gitignore the ccls cache
Otto Moerbeek [Wed, 28 Aug 2024 13:38:08 +0000 (15:38 +0200)]
rec docs: fix *.lua, * has special meaning
Jonas Schäfer [Wed, 28 Aug 2024 12:04:53 +0000 (14:04 +0200)]
Mention effect of dont_query on forward_zones
Peter van Dijk [Wed, 28 Aug 2024 10:00:06 +0000 (12:00 +0200)]
Merge pull request #14597 from zeha/zeha-auth-backend-state
auth: encapsulate lookup()-cleanup
Peter van Dijk [Wed, 28 Aug 2024 09:58:04 +0000 (11:58 +0200)]
Merge pull request #14586 from jsoref/check-spelling-md
Let check-spelling check `.md` files
Peter van Dijk [Wed, 28 Aug 2024 09:51:24 +0000 (11:51 +0200)]
Merge pull request #14599 from zeha/zeha-auth-regtestspy-aliasaaaa
regression-tests.auth-py: actually test ALIAS AAAA cases
Peter van Dijk [Wed, 28 Aug 2024 09:48:22 +0000 (11:48 +0200)]
Merge pull request #14598 from zeha/zeha-auth-regtestspy-meson
regression-tests.auth-py: allow running with meson, and on macOS
Peter van Dijk [Wed, 28 Aug 2024 09:48:13 +0000 (11:48 +0200)]
Merge pull request #14592 from zeha/luadocfix
auth docs: reword LUA return paragraph
Otto Moerbeek [Wed, 28 Aug 2024 08:55:39 +0000 (10:55 +0200)]
rec: change the way incoming TCP higher than max_tcp_clients is handled
Keep accepting connections, but drop them immediately if we're over limit. This
- avoids having lots of incoming TCP connections at the listen queue in the OS
- Immediately takes effect, instead of relying on the lazy enforming of the limit
No seperate counter for now, also, maybe a log message should be added?
Also consider the per client limit for that.
Peter van Dijk [Wed, 28 Aug 2024 08:53:22 +0000 (10:53 +0200)]
Merge pull request #14509 from Habbie/auth-settings-removed
auth docs: mark settings removed in 4.9.0
Peter van Dijk [Wed, 28 Aug 2024 08:47:20 +0000 (10:47 +0200)]
Merge pull request #14576 from Habbie/sqlite-begin-immediate
ssqlite3: use "begin immediate" to avoid later fights over upgrading to write
Peter van Dijk [Wed, 28 Aug 2024 08:40:31 +0000 (10:40 +0200)]
Merge pull request #14590 from zeha/zeha-13039-doc
auth dnsproxy: document network ought to be trusted
Otto Moerbeek [Wed, 14 Aug 2024 08:05:48 +0000 (10:05 +0200)]
Be more strict with names we allow in the answer section
Otto Moerbeek [Wed, 24 Jul 2024 09:08:07 +0000 (11:08 +0200)]
Avoid calling erase() when sanitizing records
Otto Moerbeek [Wed, 28 Aug 2024 05:49:55 +0000 (07:49 +0200)]
Merge pull request #14596 from romeroalx/update-pip-pinned-pkgs-pbr
docs - pip pinning: set pbr version to 6.1.0
Chris Hofstaedtler [Tue, 27 Aug 2024 18:47:28 +0000 (20:47 +0200)]
regression-tests.auth-py: actually test ALIAS AAAA cases
Chris Hofstaedtler [Tue, 27 Aug 2024 18:40:24 +0000 (20:40 +0200)]
regression-tests.auth-py: avoid authbind on macOS
Not necessary.
Chris Hofstaedtler [Tue, 27 Aug 2024 18:37:11 +0000 (20:37 +0200)]
regression-tests.auth-py: allow running with meson
dynamic modules are untested
Chris Hofstaedtler [Tue, 27 Aug 2024 17:49:33 +0000 (19:49 +0200)]
auth: encapsulate lookup()-cleanup
Chris Hofstaedtler [Tue, 27 Aug 2024 08:59:18 +0000 (10:59 +0200)]
auth dnsproxy: document network ought to be trusted
We are reusing the source UDP port for a very long time. Cannot have
people interfere or try to attack us then.
romeroalx [Tue, 27 Aug 2024 14:11:41 +0000 (16:11 +0200)]
docs - pip pinning: set pbr version to 6.1.0
Otto Moerbeek [Tue, 27 Aug 2024 13:51:17 +0000 (15:51 +0200)]
Merge pull request #14593 from omoerbeek/rec-regr-test-names
rec: make sure names of classes and confdirs are consistent in regr tests
Otto Moerbeek [Tue, 27 Aug 2024 12:35:48 +0000 (14:35 +0200)]
rec: make sure names of classes and confdirs are consistent in regr tests
Otherwise printlogs.py does not work as expected
Josh Soref [Mon, 26 Aug 2024 18:33:30 +0000 (14:33 -0400)]
Let check-spelling check .md files
Josh Soref [Mon, 26 Aug 2024 18:38:20 +0000 (14:38 -0400)]
spelling: produced
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Josh Soref [Mon, 26 Aug 2024 18:37:00 +0000 (14:37 -0400)]
spelling: occurrence
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Josh Soref [Mon, 26 Aug 2024 18:36:52 +0000 (14:36 -0400)]
spelling: incompatibility
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Josh Soref [Mon, 26 Aug 2024 18:36:03 +0000 (14:36 -0400)]
spelling: github
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Josh Soref [Mon, 26 Aug 2024 18:36:40 +0000 (14:36 -0400)]
spelling: documentation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Josh Soref [Mon, 26 Aug 2024 18:36:30 +0000 (14:36 -0400)]
spelling: below
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Peter van Dijk [Tue, 27 Aug 2024 12:21:27 +0000 (14:21 +0200)]
Merge pull request #14591 from zeha/zeha-13039
auth dnsproxy: make local port range configurable
Peter van Dijk [Tue, 27 Aug 2024 12:19:47 +0000 (14:19 +0200)]
Merge pull request #14589 from zeha/docfixes
auth docs: fix invalid reference
Peter van Dijk [Tue, 27 Aug 2024 12:14:36 +0000 (14:14 +0200)]
Merge pull request #14588 from Habbie/dnsdist-version-conf-flags
dnsdist: add configure args to --version output
Chris Hofstaedtler [Tue, 27 Aug 2024 09:41:39 +0000 (11:41 +0200)]
auth docs: reword LUA return paragraph
Avoids misrender and warning from sphinx.
Chris Hofstaedtler [Tue, 27 Aug 2024 09:17:34 +0000 (11:17 +0200)]
auth dnsproxy: make local port range configurable
Chris Hofstaedtler [Tue, 27 Aug 2024 09:13:25 +0000 (11:13 +0200)]
auth docs: fix invalid reference
```
docs/settings.rst:1407: WARNING: undefined label: _stat-overload-drops (if the link has no caption the label must precede a section header)
```
Otto Moerbeek [Tue, 27 Aug 2024 09:09:03 +0000 (11:09 +0200)]
Merge pull request #14558 from omoerbeek/rec-regr-nod-races
rec: fix regression test nod races and printlogs.py
Otto Moerbeek [Tue, 27 Aug 2024 08:10:00 +0000 (10:10 +0200)]
Don't hardcode arch in test script
Peter van Dijk [Tue, 27 Aug 2024 07:56:32 +0000 (09:56 +0200)]
NOLINT for hard to avoid macro usage
Co-authored-by: Remi Gacogne <github@coredump.fr>
Peter van Dijk [Tue, 27 Aug 2024 07:50:44 +0000 (09:50 +0200)]
dnsdist: add configure args to --version output
Remi Gacogne [Tue, 27 Aug 2024 07:46:20 +0000 (09:46 +0200)]
Merge pull request #14585 from rgacogne/rec-typos-settings
rec: Fix a few typos in the settings files
Peter van Dijk [Tue, 27 Aug 2024 07:40:05 +0000 (09:40 +0200)]
Merge pull request #14587 from jsoref/not-otherwise
docs: Improve wording docs about oversized chunks
Josh Soref [Mon, 26 Aug 2024 18:50:38 +0000 (14:50 -0400)]
docs: Improve wording docs about oversized chunks
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Remi Gacogne [Mon, 26 Aug 2024 15:53:02 +0000 (17:53 +0200)]
rec: Fix a few typos in the settings files
Otto Moerbeek [Mon, 26 Aug 2024 10:00:43 +0000 (12:00 +0200)]
Merge pull request #14555 from omoerbeek/rec-err-msg-inalid-default
rec: better error message in case of syntax errors in defaults defined in table.py
Remi Gacogne [Mon, 26 Aug 2024 09:29:54 +0000 (11:29 +0200)]
Merge pull request #14584 from rgacogne/yahttp-httpbase-virtual-dtor
YaHTTP: Fix a non-virtual destructor warning in the `HTTPBase` class
Remi Gacogne [Mon, 26 Aug 2024 08:47:10 +0000 (10:47 +0200)]
YaHTTP: Fix a non-virtual destructor warning in the `HTTPBase` class
`g++` 14.2.1's `-Wnon-virtual-dtor` complains:
```
‘class YaHTTP::HTTPBase’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
```
Otto Moerbeek [Fri, 23 Aug 2024 07:30:17 +0000 (09:30 +0200)]
Merge pull request #14557 from omoerbeek/rec-rpz-stats-always
rec: always include all stats for RPZs in Prometheus data (previously zero stats would be skipped)
Alexis Romero [Thu, 22 Aug 2024 21:43:53 +0000 (23:43 +0200)]
Merge pull request #14565 from romeroalx/ci-coveralls-continue-on-failure
GH Actions - Coveralls: avoid CI failure when upload fails
romeroalx [Mon, 15 Jul 2024 11:01:13 +0000 (13:01 +0200)]
gh actions - .github/workflows/builder-releases-dispatch: simplify description for jobs
romeroalx [Mon, 15 Jul 2024 11:00:53 +0000 (13:00 +0200)]
gh actions - build-and-test-all-releases-dispatch: simplify description for jobs
romeroalx [Mon, 15 Jul 2024 10:41:57 +0000 (12:41 +0200)]
gh actions - coveralls: avoid CI failure by setting fail-on-error: false
Remi Gacogne [Thu, 22 Aug 2024 15:17:17 +0000 (17:17 +0200)]
Merge pull request #14579 from rgacogne/fix-coverity-cargo
Fix the Coverity workflow after the Quiche installation refactoring