Process review comments from @rgacogne

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Print port if != 53

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Process comments from pieterlexis wrt tests

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Move timestamp() function to misc.cc

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Process another set of review comments from pieterlexis

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Process review comment from pieterlexis: upgrade guide additions

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Add config to persistently list auths not supporting cookies

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Add feature to add "Cookies Unsupported" entries to cookie-table using rec_control

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Allow clearing of specific entries in cookie table using rec_control

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Formatting and tidy

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Better naming of cookie metrics

Factor out the code to compute the EDNS Error code

Implement EDNSOpts::getFirstOption and use it in lwres

Apply suggestions from Habbie (the trivial ones first)

Use ostringstream for constructing cookie displaystring, add a few comments why binding to a given local address is needed

Tidy

Typos in comments and docs from Miod

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>

Fix ifdef botch

Reformat

Comments and docs tweaks

Add metrics for cookies

Refactor cookie code out of asyncresolve

Fix regression tests

Better tracing

Invalid cookie case, plus test of moving to next NS in that case

four states: unknown, supported, unsupported and probing

Basic cookies test: enable cookies in rec and talk to auths with cookies disabled and enabled

Add setting, remove debug lines

TCP support for cookies, taking into account idle outgoing connections

Tidy rec-tcpout.??

Initial very raw version

Merge pull request #16054 from PowerDNS/dependabot/pip/regression-tests.dnsdist/h2-4.3.0

build(deps): bump h2 from 4.2.0 to 4.3.0 in /regression-tests.dnsdist

Merge pull request #16058 from omoerbeek/version-configure-in

rec/dnsdist: add (back) the line that sets the version in configure.ac

Merge pull request #16059 from miodvallat/where_is_my_404

REST API: bring back 404 errors

Merge pull request #15773 from karelbilek/kb/clarify_auth

dnsdist: Clarify different webserver auths

Merge pull request #16064 from rgacogne/ddist-properly-handle-truncation-sendmmsg

dnsdist: Properly handle truncation for UDP responses sent via `sendmmsg`

Merge pull request #15891 from miodvallat/behind_the_backend

Improve lmdb dyndns test results

Merge pull request #16024 from miodvallat/update_unless_don't

Correctly handle dnsupdate reject by Lua policy

Merge pull request #16050 from miodvallat/what_time_is_it

Display SOA check timestamps in human-readable form

dnsdist: Clarify different webserver auths

dnsdist: Properly handle truncation for UDP responses sent via `sendmmsg`

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #15966 from miodvallat/unsafe

pdnsutil: report corrupted records

Merge pull request #15969 from miodvallat/seventh_json_of_a_seventh_json

web server: try harder to return response in the same type as the request

Add optional backend method to let them return invalid records.

Use this in pdnsutil check-zone to report these ill-formed records which
would otherwise never made visible.

Fixes: #4941
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Update lmdb dyndns oracles.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Use pdnsutil backend-cmd list to get NSEC3 details in dyndns tests.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Add a "list" backend-cmd which allows us to get NSEC3 ordername data.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Merge pull request #16016 from Habbie/random-doc-nits

auth: random doc nits

Prevent the /* OPTIONS handler to turn every 404 error into 405.

Fixes: #14572
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Merge pull request #16056 from rkr-23/patch-1

Auth: Fix misleading description of tcp-control-port argument.

rec/dnsdist: add (back) the line that sets the version in configure.ac

Partial revert of #15717
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16046 from miodvallat/transfer_of_confusion

Make axfr error message more helpful when a domain can't be found

Fix misleading description of tcp-control-port argument.

Signed-off-by: Ramsanker K R <164614935+rkr-23@users.noreply.github.com>

Merge pull request #16044 from omoerbeek/rec-prep-5.3.0

rec: prep for rec-5.3.0

build(deps): bump h2 from 4.2.0 to 4.3.0 in /regression-tests.dnsdist

Bumps [h2](https://github.com/python-hyper/h2) from 4.2.0 to 4.3.0.
- [Changelog](https://github.com/python-hyper/h2/blob/master/CHANGELOG.rst)
- [Commits](https://github.com/python-hyper/h2/compare/v4.2.0...v4.3.0)

---
updated-dependencies:
- dependency-name: h2
  dependency-version: 4.3.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge pull request #16022 from romeroalx/fix-pip-pinning-2508

Update Python package pinning for setup_requires dependency `pbr` to version `7.0.1`

Display SOA check timestamps in human-readable form.

Fixes: #11134
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Merge pull request #16043 from omoerbeek/dnsdist-build-gcc8

dnsdist: allow building wth gcc8, which needs -lstdc++fs as link argument

Make axfr error message more helpful when a domain can't be found.

Fixes: #11084
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Merge pull request #16042 from omoerbeek/dnsdist-incr-macro

dnsdist: don't increment in a potential macro argument

rec: prep for rec-5.3.0

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

dnsdist: allow building wth gcc8, which needs -lstdc++fs as link argument

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

dnsdist: don't increment in a potential macro argument

Fixes g++ 8: ../dnsdist-crypto.cc:291:16: warning: operation on 'count' may be undefined [-Wsequence-point]

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16038 from rgacogne/ddist-add-missing-dist-files

dnsdist: Add missing generated files to the dist tarball

Merge pull request #15537 from romeroalx/ci-daily-build-pkgs-rel

GH actions: add daily build-packages for rel/* branches to ci

Merge pull request #15874 from rgacogne/ddist-get-current-runtime-config-optimization

dnsdist: Only check the freshness of the configuration when needed

dnsdist: Add missing generated files to the dist tarball

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

process comments from Miod

dnsdist: Expose `refreshRuntimeConfiguration` to Lua

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16007 from rgacogne/ddist-h2-25

dnsdist: Add mitigations for the HTTP/2 MadeYouReset attack

Merge pull request #16034 from rgacogne/ddist-upgrade-h2o-226pdns3

dnsdist: Upgrade h2o to 2.2.6-pdns3

Merge pull request #16033 from miodvallat/boost_your_readability

Remove boost < 1.54 leftovers

dnsdist: Fix invalid log formatters spotted by Otto

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Remove preprocessor check for Boost < 1.54.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Remove workaround for Boost 1.53 since we require at least 1.54 to build.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

dnsdist: Upgrade h2o to 2.2.6-pdns3

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

clang-tidy always finds something to complain about.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Merge pull request #16021 from omoerbeek/rec-include-logr

rec: include logr.hh in bridge.hh

Return Refused when the lua update policy declines all updates.

Fixes: #14953
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Split PacketHandler::processUpdate() into multiple subfunctions. NFCI

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

rec: include logr.hh in bridge.hh

Not doing so results in creating a shared pointer to an incomplete class,
which does not work for all compilers/c++ lib combinations.

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

gh actions: add daily build-packages for rel/* branches

gh actions: removed daily buider for rel/* branches

pip pinning: update requirements.txt for pbr 7.0.1

Merge pull request #16011 from omoerbeek/rec-path-unlink-unmodernize

rec: Path.unlink(True) requires python 3.8, rewrite so it works on older versions

Merge pull request #15988 from Habbie/noracular

drop ubuntu oracular, it is EOL

dnsdist: Also refresh the configuration when `recvmmsg` is used

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16006 from miodvallat/12154-redone

More zone names in error messages

Merge pull request #15952 from miodvallat/system_five

auth: update CI for 5.x

clarify catz/views status

correct company name

Merge pull request #16012 from miodvallat/knocking_on_server's_door

auth: 5.0.0 release notes and secpoll update

5.0.0 release notes and secpoll update

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Merge pull request #15931 from rgacogne/ddist-faster-response-content-matching

dnsdist: Speed up response content matching

Merge pull request #15930 from rgacogne/ddist-backend-qps-limiter

dnsdist: Backend QPS limit refactoring

Merge pull request #15935 from rgacogne/ddist-incoming-concurrent-tcp-conn-counter-cleanup

dnsdist: Clean up incoming TCP connections counters once per minute

Refactor `DNSName::matches` around `pdns_ilexicographical_compare_three_way`

And rename it to hopefully prevent any confusion regarding when it can be used.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16010 from omoerbeek/rec-pubsuffix-followup

rec: check for pubsuffix.cc presence, followup to #15782

dnsdist: Remove unused `BasicQPSLimiter` and `QPSLimiter` ctors

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16009 from miodvallat/backport-15991-to-auth-5.0.x

auth-5.0: backport "Fix Boost system lib dependency: it is no longer available since 1.89"