dnsdist: Fix invalid log formatters spotted by Otto

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 36aeac05daeffcbc41443b47660982f65d73b7da)

dnsdist: Apply Miod and clang-tidy's suggestions

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit f2bee342a4b53cd4ea4896e280ccafeb9f24db34)

dnsdist: Stop reading on incoming DoH sockets if we are done

If the underlying library doesn't want to read, we have nothing
to send at the moment, but we are still waiting for responses,
there is no need to keep polling the socket.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit e0a5a6dc4ab9557442ddbba56d03f6e4fb132bf2)

dnsdist: Fix the accounting of "killed" streams

The way the nghttp2 library works means that we can get notified
that a stream has been closed while we are still in the function
sending the actual response. This is not a "killed" stream, but
just a regular closure.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit b81ed956d2f0b6bc538b34ee7e7ad304be233e7a)

dnsdist: Define `dnsdist::doh::MAX_INCOMING_CONCURRENT_STREAMS`

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 866c8f3fff753d3b2a03c1da50e8d53056880a46)

dnsdist: Tentative h2o fix for MadeYouReset

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 2406bc461dbac384b07ed7dbb73a87def6354bd6)

dnsdist: Enforce concurrent streams count for pending queries

The gist of the `MadeYouRest` attack is that streams can be reset
by the client, and thus no longer count towards the maximum number
of a streams as far as the library is concerned, while the server
is still processing the query and doing actual work.
This pull request introduces a counter for "killed but still being
processed streams" to prevent it.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 0214032c5f09fcfb440e5c5120f1491cb4f0fda4)

Merge pull request #16032 from rgacogne/ddist20-backport-15881

dnsdist-2.0.x: Backport 15881 - Support mnemonics for the Opcode selector

Merge pull request #16031 from rgacogne/ddist20-backport-15817

dnsdist-2.0.x: Backport 15817: switch Docker images to Debian Trixie

Merge pull request #16030 from rgacogne/ddist20-backport-15915

dnsdist-2.0.x: Backport 15915: Properly set up env vars with meson

dns: Get rid of the ugly special case for OpCode 3

As suggested by Miod.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit b6898b5f3787e2528225fd5e22927f2e5ba3cc2b)

dnsdist: Support mnemonics for the Opcode selector

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 1a37caf4bcef0ad8362ce5b2bf8f01e90c81986d)

Merge pull request #16029 from rgacogne/ddist20-backport-15959

dnsdist-2.0.x: Backport 15959: dnsdist --version: report yaml support

switch Docker images to Debian Trixie

(cherry picked from commit 4a92c4bbda9c5a0d0b9b30865dff71d70226cfcf)

rec and dnsdist: properly set up env vars

env.append() appends to an existing value

Should fix the error in #15896, but the reported location of cargo
still might be wrong.

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
(cherry picked from commit 6d3c2334aa84258eaee409eb7e545eb67121a4a5)

dnsdist --version: report yaml support

(cherry picked from commit 8ac38640efa2c90f1db59fddcd32cdb6c29d41db)

Merge pull request #16020 from rgacogne/ddist20-backport-15931

dnsdist-2.0.x: Backport 15931- Speed up response content matching

Merge pull request #16019 from rgacogne/ddist20-backport-15935

dnsdist-2.0.x: Backport 15935 - Clean up incoming TCP connections counters once per minute

Merge pull request #16018 from rgacogne/ddist20-backport-15904

dnsdist-2.0.x: Backport 15904 - Fix systemd template unit and restricted network families when building with meson

Merge pull request #16017 from rgacogne/ddist20-backport-15902

dnsdist-2.0.x: Backport 15902 - Fix QType rate dynamic block with YAML

Refactor `DNSName::matches` around `pdns_ilexicographical_compare_three_way`

And rename it to hopefully prevent any confusion regarding when it can be used.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit f78521d7f73d1f176602e33d03fae6e40fa86602)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Yet another clang-tidy warning

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit aa5ca15a59efa4602efc5d78e17514dfe4edab16)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsname: Fix clang-tidy warnings

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit afbae807a3dbb00b9ac8e20daa8b5bef353a1764)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsname: Add a comment about what `DNSName::matches` accepts

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 7394dd09afce13c1cd287c2b63f8d129e8be22af)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix clang-tidy warnings

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 93e1cbbc014526ce4f39b54dd084cfa040980dbe)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Speed up response content matching

This commit introduces a new method to compare a `DNSName`
against a view of raw, wire-format bytes, skipping the
allocation and copy that is usually required to get a
second `DNSName` object to compare against.
This signifitcantly reduces the amount of time matching
a DNS response received from a backend against the content
we expect to find.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 67eb73850f3141c44963d95ef815fe6a0586d2a8)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist-2.0.x: Backport pdns_ilexicographical_compare_three_way

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix error in comment spotted by Otto (seconds -> minutes)

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit e5a0cc4475cb668824d7d5a45086665f038f3b16)

dnsdist: Fix clang-tidy warnings

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit d80362d7d2f1d50d0cd449b62ef7fdea4354eed3)

dnsdist: Clean up incoming TCP connections counters once per minute

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit df406c37e23974d4fa1575dcf54ef53ef8276fa6)

dnsdist: Fix restricted network families when building with meson

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 84da8caf2bb5e0c74f706b7248d9abf379485180)

dnsdist: Fix systemd template unit when building with meson

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit b8b86d5644f46b2f07cd7f633cbfd98395ec8ec6)

Merge pull request #16003 from rgacogne/ddist20-quiche-0.24.5

dnsdist-2.0.x: Backport 16002 - Update Cloudflare's Quiche to 0.24.5 in our packages

dnsdist: Update Cloudflare's Quiche to 0.24.5 in our packages

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit e9af7f9c2f9e2b8969fc6be7bc35d0de2decdb77)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #15925 from rgacogne/ddist20-backport-15916

dnsdist-2.0.x: backport 15916 - Update rings' atomic counter without holding the lock

Merge pull request #15926 from rgacogne/ddist20-backport-15917

dnsdist-2.0.x: Backport 15917 - Return early when a rule chain is empty

Merge pull request #15927 from rgacogne/ddist20-backport-15918

dnsdist-2.0.x: Backport 15918 - Update a cache's atomic counter without holding the lock

Merge pull request #15920 from rgacogne/ddist20-upgrade-quiche

dnsdist-2.0.x: Upgrade Cloudflare's Quiche to 0.24.4

dnsdist: Update rings' atomic counter without holding the lock

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit f30e5ca0993defc6bacd5584d5ce19d32900d71d)

dnsdist: Update a cache's atomic counter without holding the lock

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit e579d8f2977f17efcf5f7f158500a9df53c2370d)

dnsdist: Return early when a rule chain is empty

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 1ae16e707a6cb1c80d611b72e9e4599707332645)

dnsdist: Apply Miod's suggestions (thanks!)

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 3b6b96bdd38d6ef380140aa95702d9ab7e706b67)

dnsdist: Fix QType rate dynamic block with YAML

The YAML configuration for the the "QType rate" dynamic block was
totally broken, trying to configure a rcode rate rule instead of a
qtype rate one.
Thanks to HellSpawn for reporting this the issue!

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit eb01c11a5418da08d5e11acdd519e2816e937835)

dnsdist: Upgrade Cloudflare's Quiche to 0.24.4

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #15879 from rgacogne/ddist20-backport-15871

dnsdist-2.0.x: Backport 15871 - Use an unordered map for pools

Merge pull request #15880 from rgacogne/ddist20-backport-15872

dnsdist-2.0.x: Backport 15872 - Only parse EDNS Z once

Merge pull request #15878 from rgacogne/ddist20-backport-15870

dnsdist-2.0.x: Avoid constructing a DNSResponse object when not really needed

Merge pull request #15877 from rgacogne/ddist20-backport-15869

dnsdist-2.0.x: Backport 15869 - Small speedup for getEDNSUDPPayloadSizeAndZ()

Merge pull request #15876 from rgacogne/ddist20-backport-15868

dnsdist-2.0.x: Backport 15868 - Improve the scalability of the MAC address cache

Merge pull request #15875 from rgacogne/ddist20-backport-15861

dnsdist-2.0.x: Backport 15861 - Fix out-of-tree builds with autotools

dnsdist: Only parse EDNS Z once

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit d071f0027e663206fedaa433496c4e3bd49718ee)

dnsdist: Use an unordered map for pools

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 516c3156553f874e31926671c2afed0b53b3ef19)

dnsdist: Avoid constructing a DNSResponse object when not really needed

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 4843b77823b100d652d9116165da4b4913a48ad3)

dnsparser: Add a comment explaining that the OPT RR has to be in additional

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 336a601b2bd2d6475eca39a6ad1489a02354cdca)

dnsdist: Small speedup for getEDNSUDPPayloadSizeAndZ()

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 4e7c4d06db5f6421bc33ccf7d7e72b36fe4e68db)

dnsdist: Improve the scalability of the MAC address cache

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 574075d9a9204d44f41982fd78bb5b90a2bcfb89)

dnsdist: Fix out-of-tree builds with autotools

Stolen from Habbie, many thanks!

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 412e0da107a9c6e8df4f6ad7958f6705d5e975fc)

Merge pull request #15842 from rgacogne/ddist20-backport-15823

dnsdist-2.0.x: Backport 15823 - Bring back listening on multiple web server addresses

Merge pull request #15841 from rgacogne/ddist20-backport-15822

dnsdist-2.0.x: Backport 15822 - Allow registering NMG objects from YAML

dnsdist: Document that negative entries in netmask lists are supported

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit aa18df7da0df93890100f2c82e79ed5eeee78e6b)

dnsdist: Apply Otto's suggestion

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 08d790466b2e465700f193b503ff0a76a3a0680e)

dnsdist: Allow registering NMG objects from YAML

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit f158a09f2d82c305a8297cd36713decb2cadb8f0)

Merge pull request #15837 from rgacogne/ddist20-backport-15829

dnsdist-2.0.x: Backport 15829 - dnsdist-rust-lib: honor RUSTC_TARGET_ARCH

Merge pull request #15838 from rgacogne/ddist20-backport-15819

dnsdist-2.0.x: Backport 15819 - Handle named rcodes in the YAML configuration

Merge pull request #15839 from rgacogne/ddist20-backport-15815

dnsdist-2.0.x: Backport 15815 - Properly process the YAML source parameter for backends

Merge pull request #15840 from rgacogne/ddist20-backport-15813

dnsdist-2.0.x: Backport 15813 - Properly link with `libdl` when building with `autotools`

Merge pull request #15843 from rgacogne/ddist20-backport-15833

dnsdist-2.0.x: Backport 15833 - Fix narrowing conversion on 32-bit systems by using uint64_t instead of size_t

Fix narrowing conversion on 32-bit systems by using uint64_t instead of size_t

(cherry picked from commit 83ac5035c5676ee9bd75b79ecfb7778f0e9d599a)

dnsdist: Fix a clang-tidy warning

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit a5b8fe9689a4fa5ca4974f2fb17336d7327b54f2)

dnsdist: Bring back listening on multiple web server addresses

This was broken during the refactoring of the configuration between
1.9.x and 2.0.x.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 11f9083073119595c655988a3981ab5f1ccc2e40)

dnsdist: Properly link with `libdl` when building with `autotools`

Depending on the system we might actually need to link with `libdl`
when our Rust library is used, and the mechanism to do that was not
properly set up when building with `autotools` (we were adding `LIBDL`
to the the libraries we need but the variable was not properly filled).
Unfortunately the systems we are exercising in our CI do not need to
explicitly link with `libdl` so we did not notice.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 83416a76b6df3af560514caea8c45e750f1fd24b)

dnsdist: Properly process the YAML source parameter for backends

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 451a06cd0065fbd1364347cece5335bf921402af)

dns: Fix another clang-tidy warning

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 1ba566f50364a09d7ffa7391f4928fa8019157d1)

dns: Add short descriptions for extended rcodes as well

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 4a1a3e3ed7ea4b5b9d42657c74b90b821dc95421)

dns: Fix a clang-tidy warning

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 24570745905593be704ceaa990ecaa442d842d95)

dnsdist: The ability to use RCode names in YAML will be backported to 2.0

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit f593ec1327e74c6916502c4d2ad9039e1342d7ee)

dns: Add unit tests for the RCode/ERCode/Opcode helpers

(cherry picked from commit d147b9dbd5df717c4dd299d05037b6e7a78b1061)

dns: Add short description for the Not Zone rcode

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 3e114916d5efd1cd35f8f1e25f7bba02f647a1d7)

dns: Rewrite `RCode::from_short` with `std::find` and `std::distance`

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 978fca63b078da822c15d1a9bdee9bd0bb4a7349)

dnsdist: Fix a typo in the upgrade guide

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit e5db082886b36f30d9780439249c656ad0738605)

dnsdist: Document changed YAML parameters

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 852772af5e54aa2c5aeb17a4565c57a5251aba40)

dnsdist: Handle named rcodes in all YAML configuration items

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit d442fb9443d7b89afd95f3f56e85d62931217841)

dnsdist: Handle named rcodes in the dynamic block YAML configuration

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit f84cc5ad3e19c73cc45b393d0934d9c4579bde10)

dnsdist: Add a Dynamic block rcode rate test using YAML

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 24691dd78daa343d17280dc8b44b54770430affc)

dnsdist-rust-lib: honor RUSTC_TARGET_ARCH

Like for pdns-recursor and also like in the meson build.

Necessary as Debian's cargo always puts the output files into target/<arch>/...

(cherry picked from commit d6515621f452557e45e4498d508c6b6c60e7660a)

Merge pull request #15805 from rgacogne/ddist20-backport-15639

dnsdist-2.0.x: Backport 15639 - Add el-10 target

builder: avoid duplicate installation of meson/quiche/rust

(cherry picked from commit adc4a45244c64cfcd52d03b8a392224c3851e1ff)

builder: add el-10 target, based on rockylinux:10 for now

cherry-picked from 32a5ef17f4aa04822b79aafd2c783c19433955a5

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #15787 from rgacogne/ddist20-remove-more-workflows

dnsdist-2.0.x: Remove more useless workflows

Merge pull request #15784 from rgacogne/ddist20-backport-15747

dnsdist-2.0.x: Backport 15747 - Add a Lua binding to get objects declared in YAML

dnsdist-2.0.x: Remove more useless workflows

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Add an explicit return type to getObjectFromYAMLConfiguration

As suggested by Otto.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 9263b481855ffc6e3324f2d342ce66b57e4ac0fa)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Add a regression test for `getObjectFromYAMLConfiguration`

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit 80f292fc5d96ab59afea63aaf8323267081b9114)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Add a Lua binding to get objects declared in YAML

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
(cherry picked from commit d98d50b1939016d03a522cb6a79834088949e913)
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #15780 from rgacogne/ddist20-backport-15751

dnsdist-2.0.x: Backport to 15751 - Error on unsupported backend protocols from YAML

Merge pull request #15779 from rgacogne/ddist20-backport-15750

dnsdist-2.0.x: Backport 15750 - Fix logging and XSK YAML settings being ignored

Merge pull request #15778 from rgacogne/ddist20-backport-15739

dnsdist-2.0.x: Backport 15739 - lmdb-safe: Fix a small race in `getMDBEnv`

Merge pull request #15777 from rgacogne/ddist20-backport-15738

dnsdist-2.0.x: Backport 15738 - Prevent users from opening the same LMDB twice

Merge pull request #15776 from rgacogne/ddist20-backport-15735

dnsdist-2.0.x: Backport 15735 - lmdb-safe: Improve the scalability of transaction maps

Merge pull request #15775 from rgacogne/ddist20-backport-15718

dnsdist-2.0.x: Backport 15718 - Return nil for non-existing Lua objects